From: Marco Varlese <marco.varlese@suse.com>
Date: Wed, 18 Apr 2018 06:50:57 +0000 (+0200)
Subject: SCTP: coverity warnings
X-Git-Tag: v18.04~11
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F74%2F11874%2F2;p=vpp.git

SCTP: coverity warnings

This patch addresses the warning 182994

Change-Id: I071f3cbdf9965c7b57d444f79430ee75c66c856e
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
---

diff --git a/src/vnet/sctp/sctp_input.c b/src/vnet/sctp/sctp_input.c
index bc36a7f91d5..775d14ae21a 100644
--- a/src/vnet/sctp/sctp_input.c
+++ b/src/vnet/sctp/sctp_input.c
@@ -483,7 +483,6 @@ sctp_handle_init_ack (sctp_header_t * sctp_hdr,
 {
   sctp_init_ack_chunk_t *init_ack_chunk =
     (sctp_init_ack_chunk_t *) (sctp_hdr);
-  sctp_state_cookie_param_t state_cookie;
 
   char hostname[FQDN_MAX_LENGTH];
 
@@ -560,8 +559,9 @@ sctp_handle_init_ack (sctp_header_t * sctp_hdr,
 		sctp_state_cookie_param_t *state_cookie_param =
 		  (sctp_state_cookie_param_t *) opt_params_hdr;
 
-		clib_memcpy (&state_cookie, state_cookie_param,
+		clib_memcpy (&(sctp_conn->cookie_param), state_cookie_param,
 			     sizeof (sctp_state_cookie_param_t));
+
 		break;
 	      }
 	    case SCTP_HOSTNAME_ADDRESS_TYPE:
@@ -587,9 +587,6 @@ sctp_handle_init_ack (sctp_header_t * sctp_hdr,
 	}
     }
 
-  clib_memcpy (&(sctp_conn->cookie_param), &state_cookie,
-	       sizeof (sctp_state_cookie_param_t));
-
   sctp_prepare_cookie_echo_chunk (sctp_conn, idx, b0, 1);
 
   /* Start the T1_COOKIE timer */