From: Matus Fabian <matfabia@cisco.com>
Date: Fri, 25 Jul 2025 13:09:27 +0000 (-0400)
Subject: hs-test: h2 client memory leak test
X-Git-Tag: v26.02-rc0~151
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F79%2F43479%2F2;p=vpp.git

hs-test: h2 client memory leak test

Type: test

Change-Id: Ie8c49e84031d0da06c9770de25e94ff8166457f9
Signed-off-by: Matus Fabian <matfabia@cisco.com>
---

diff --git a/extras/hs-test/http2_test.go b/extras/hs-test/http2_test.go
index 3cc0304d8f9..82230a0643e 100644
--- a/extras/hs-test/http2_test.go
+++ b/extras/hs-test/http2_test.go
@@ -14,7 +14,7 @@ import (
 func init() {
 	RegisterH2Tests(Http2TcpGetTest, Http2TcpPostTest, Http2MultiplexingTest, Http2TlsTest, Http2ContinuationTxTest, Http2ServerMemLeakTest,
 		Http2ClientGetTest, Http2ClientPostTest, Http2ClientPostPtrTest, Http2ClientGetRepeatTest, Http2ClientMultiplexingTest,
-		Http2ClientH2cTest)
+		Http2ClientH2cTest, Http2ClientMemLeakTest)
 	RegisterH2MWTests(Http2MultiplexingMWTest, Http2ClientMultiplexingMWTest)
 	RegisterVethTests(Http2CliTlsTest, Http2ClientContinuationTest)
 }
@@ -139,10 +139,17 @@ func Http2ServerMemLeakTest(s *Http2Suite) {
 	/* no goVPP less noise */
 	vpp.Disconnect()
 
-	/* warmup request (FIB) */
+	/* warmup requests (FIB, pools) */
 	args := fmt.Sprintf("--max-time 10 --noproxy '*' --http2-prior-knowledge -z %s %s %s %s", target, target, target, target)
 	_, log := s.RunCurlContainer(s.Containers.Curl, args)
 	s.AssertContains(log, "HTTP/2 200")
+	for i := 0; i < 10; i++ {
+		time.Sleep(time.Second * 1)
+		s.AssertNil(s.Containers.Curl.Start())
+	}
+
+	/* let's give it some time to clean up sessions, so pool elements can be reused and we have less noise */
+	time.Sleep(time.Second * 15)
 
 	vpp.EnableMemoryTrace()
 	traces1, err := vpp.GetMemoryTrace()
@@ -260,6 +267,7 @@ func Http2ClientGetRepeatTest(s *Http2Suite) {
 	cmd := fmt.Sprintf("http client http2 repeat %d uri %s", 10, uri)
 	o := vpp.Vppctl(cmd)
 	s.Log(o)
+	s.AssertContains(o, "10 request(s)")
 }
 
 func Http2ClientMultiplexingTest(s *Http2Suite) {
@@ -333,3 +341,43 @@ func Http2ClientContinuationTest(s *VethsSuite) {
 	s.AssertContains(o, "HTTP/2 200 OK")
 	s.AssertGreaterThan(strings.Count(o, "x"), 32768)
 }
+
+func Http2ClientMemLeakTest(s *Http2Suite) {
+	s.SkipUnlessLeakCheck()
+
+	vpp := s.Containers.Vpp.VppInstance
+	serverAddress := s.HostAddr() + ":" + s.Ports.Port1
+
+	s.CreateNginxServer()
+	s.AssertNil(s.Containers.NginxServer.Start())
+
+	uri := "http://" + serverAddress + "/64B"
+
+	/* no goVPP less noise */
+	vpp.Disconnect()
+
+	/* warmup requests (FIB, pools) */
+	cmd := fmt.Sprintf("http client verbose http2 uri %s", uri)
+	o := vpp.Vppctl(cmd)
+	s.AssertContains(o, "HTTP/2 200 OK")
+	/* do second request because pool is at threshold and will grow again */
+	o = vpp.Vppctl(cmd)
+	s.AssertContains(o, "HTTP/2 200 OK")
+
+	/* let's give it some time to clean up sessions, so pool elements can be reused and we have less noise */
+	time.Sleep(time.Second * 15)
+
+	vpp.EnableMemoryTrace()
+	traces1, err := vpp.GetMemoryTrace()
+	s.AssertNil(err, fmt.Sprint(err))
+
+	o = vpp.Vppctl(cmd)
+	s.AssertContains(o, "HTTP/2 200 OK")
+
+	/* let's give it some time to clean up sessions */
+	time.Sleep(time.Second * 15)
+
+	traces2, err := vpp.GetMemoryTrace()
+	s.AssertNil(err, fmt.Sprint(err))
+	vpp.MemLeakCheck(traces1, traces2)
+}