From: Jakub Grajciar <jgrajcia@cisco.com>
Date: Tue, 9 Oct 2018 08:02:46 +0000 (+0200)
Subject: memif: coverity fix
X-Git-Tag: v18.10-rc1~2
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F86%2F15186%2F2;p=vpp.git

memif: coverity fix

Change-Id: I2b14e2a035a37b04816aac1e610146be58ad1e92
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
---

diff --git a/src/plugins/memif/memif.c b/src/plugins/memif/memif.c
index 63f72a30de4..e8fb0e94a69 100644
--- a/src/plugins/memif/memif.c
+++ b/src/plugins/memif/memif.c
@@ -680,8 +680,10 @@ memif_socket_filename_add_del (u8 is_add, u32 sock_id, u8 * sock_filename)
 	}
 
       /* check dir existance and access rights for effective user/group IDs */
-      if (faccessat ( /* ignored */ -1, dir, F_OK | R_OK | W_OK, AT_EACCESS) <
-	  0)
+      if ((dir == NULL)
+	  ||
+	  (faccessat ( /* ignored */ -1, dir, F_OK | R_OK | W_OK, AT_EACCESS)
+	   < 0))
 	{
 	  vec_free (dir);
 	  return VNET_API_ERROR_INVALID_ARGUMENT;