From: Matus Fabian <matfabia@cisco.com>
Date: Tue, 14 May 2024 08:04:35 +0000 (+0200)
Subject: http: fix unsupported client app method
X-Git-Tag: v24.10-rc0~7
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F87%2F40887%2F2;p=vpp.git

http: fix unsupported client app method

HTTP client app code currently support only GET method but method
set in message from client app was silently ignored.

Type: fix

Change-Id: I99dc6323d9783ee5a20623e7923cfdbf31474a4f
Signed-off-by: Matus Fabian <matfabia@cisco.com>
---

diff --git a/src/plugins/http/http.c b/src/plugins/http/http.c
index 797be1b7a16..893dd877c29 100644
--- a/src/plugins/http/http.c
+++ b/src/plugins/http/http.c
@@ -824,6 +824,13 @@ http_state_wait_app_method (http_conn_t *hc, transport_send_params_t *sp)
       goto error;
     }
 
+  /* currently we support only GET method */
+  if (msg.method_type != HTTP_REQ_GET)
+    {
+      clib_warning ("unsupported method %d", msg.method_type);
+      goto error;
+    }
+
   vec_validate (buf, msg.data.len - 1);
   rv = svm_fifo_dequeue (as->tx_fifo, msg.data.len, buf);
   ASSERT (rv == msg.data.len);