From: Ivan Shvedunov <ivan4th@gmail.com>
Date: Sat, 16 Jan 2021 00:43:01 +0000 (+0300)
Subject: tcp: remove bad assert
X-Git-Tag: v21.10-rc0~717
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F91%2F30791%2F1;p=vpp.git

tcp: remove bad assert

Don't assume that half-open connections pending removal are always
successful.

Type: fix
Signed-off-by: Ivan Shvedunov <ivan4th@gmail.com>
Change-Id: I955077a4ed2389b9ee38d97e27a7c7761c860a4a
---

diff --git a/src/vnet/tcp/tcp_input.c b/src/vnet/tcp/tcp_input.c
index 0a3d31588ee..a159d850728 100644
--- a/src/vnet/tcp/tcp_input.c
+++ b/src/vnet/tcp/tcp_input.c
@@ -1812,13 +1812,10 @@ tcp46_syn_sent_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
 	  goto drop;
 	}
 
-      /* Half-open completed recently but the connection was't removed
-       * yet by the owning thread */
+      /* Half-open completed or cancelled recently but the connection
+       * was't removed yet by the owning thread */
       if (PREDICT_FALSE (tc0->flags & TCP_CONN_HALF_OPEN_DONE))
 	{
-	  /* Make sure the connection actually exists */
-	  ASSERT (tcp_lookup_connection (tc0->c_fib_index, b0,
-					 my_thread_index, is_ip4));
 	  error0 = TCP_ERROR_SPURIOUS_SYN_ACK;
 	  goto drop;
 	}