vpp.git
2 years agodevices: add af-packet v3 api 32/35932/4
Mohsin Kazmi [Mon, 11 Apr 2022 16:14:45 +0000 (16:14 +0000)]
devices: add af-packet v3 api

Type: improvement

Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: I4679acbe4fd4400d57c0a79b0a6c74c8f1639703

2 years agoflow: support generic flow and RSS action in vapi 14/35614/8
Ting Xu [Tue, 8 Mar 2022 07:22:56 +0000 (07:22 +0000)]
flow: support generic flow and RSS action in vapi

Add generic flow type and rss action type to vapi. It is to support
creating generic flow rule via vapi.

Type: feature

Signed-off-by: Ting Xu <ting.xu@intel.com>
Change-Id: Ifeaa007679487e02bd2903dc591d80a1caba33bc

2 years agovppinfra: fix memory trace 89/36189/2
Leung Lai Yung [Sun, 22 May 2022 13:25:53 +0000 (13:25 +0000)]
vppinfra: fix memory trace

Type: fix

reset the memory trace if mem trace is turned on

Signed-off-by: Leung Lai Yung <benkerbuild@gmail.com>
Change-Id: Ib99355b9ed42ff66c720bbea5cbbf03c65820d12

2 years agovlib: implement aux data handoff 66/36166/4
Mohammed Hawari [Wed, 18 May 2022 08:08:47 +0000 (10:08 +0200)]
vlib: implement aux data handoff

Type: improvement
Change-Id: I20b41537a249a55f01004e45392b34adaa8fd792
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
2 years agoapi: start enum values from 0 94/36194/1
Filip Varga [Mon, 23 May 2022 19:18:38 +0000 (21:18 +0200)]
api: start enum values from 0

C enum values by default start from 0.
All unassigned names should get value as value of previous name plus one.
The problem was that default value was 0 and adding one for the first
value would make generated api files start from 1 instead of 0.

Type: fix

Change-Id: I772d6411435648de3ec514f57025ef1acae87338
Signed-off-by: Filip Varga <fivarga@cisco.com>
2 years agodpdk: fix update link state 84/36184/3
Alexander Skorichenko [Fri, 20 May 2022 11:13:19 +0000 (11:13 +0000)]
dpdk: fix update link state

Type: fix

Correct vnet_hw_interface_t flags update on link state changes.
Currently incomplete set of flags is applied on each change,
only flags related to the most recent change are being set correct.
E.g. setting the link up would erase the duplex part of the flags.

Signed-off-by: Alexander Skorichenko <askorichenko@netgate.com>
Change-Id: I5b95e1c0eaea0c283b108dbf7f809682ec9064eb

2 years agolinux-cp: fix display of link_speed 76/36176/2
Anton Nikolaev [Thu, 19 May 2022 10:52:01 +0000 (10:52 +0000)]
linux-cp: fix display of link_speed

Type: fix

Don't set link speed for tap interface when link speed is unknown

Signed-off-by: Anton Nikolaev <anikolaev@netgate.com>
Change-Id: Ia97277b3bf7c958fa665e4ead8d0e48f02921e69

2 years agoip: reassembly - fixing stepping index in a better way 78/36178/3
Vijayabhaskar Katamreddy [Thu, 19 May 2022 17:07:22 +0000 (17:07 +0000)]
ip: reassembly - fixing stepping index in a better way

Type: fix

pool_is_free_index() check is performed only for the first element

Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Change-Id: Icadc715a9b54761ec69805a134a69a262137536d

2 years agoip: reassembly - adding custom reassembly node 79/36179/2
Vijayabhaskar Katamreddy [Thu, 19 May 2022 17:48:13 +0000 (17:48 +0000)]
ip: reassembly - adding custom reassembly node

Type: fix

Custom node functionality is missing in v6,  so bringing in similar to v4 functionality into ip6 as well

Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Change-Id: I28b0be2fc55a00bfc0b456b1caaa1dcf5641a44e

2 years agovirtio: use the internal hdr offsets of buffer metadata for offloads 67/36167/2
Mohsin Kazmi [Wed, 18 May 2022 16:51:57 +0000 (16:51 +0000)]
virtio: use the internal hdr offsets of buffer metadata for offloads

Type: improvement

Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: Ie63c360f2e42e9e5799f5c536453823ea95ed3b8

2 years agoapi: refactor api data storage 68/36168/7
Damjan Marion [Wed, 18 May 2022 20:16:11 +0000 (22:16 +0200)]
api: refactor api data storage

single struct to hold all api handler, flags, etc.
Provide functions to toggle flags instead of writing directly to
internal data.

Type: refactor
Change-Id: I4730d7290e57489de8eda34a72211527e015b721
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agoikev2: fix tunnel direction 57/36157/3
Stanislav Zaikin [Tue, 17 May 2022 17:18:53 +0000 (19:18 +0200)]
ikev2: fix tunnel direction

Type: fix

Change-Id: I480b1fcace1c27a5cb2d2956cec80b379105b55d
Signed-off-by: Stanislav Zaikin <zstaseg@gmail.com>
2 years ago ip: reassembly - pacing reassembly timeouts 36/36136/7
Vijayabhaskar Katamreddy [Fri, 13 May 2022 13:07:19 +0000 (13:07 +0000)]
 ip: reassembly - pacing reassembly timeouts

Type: fix

Pace the main thread activity for reassembly timeouts, to avoid barrier syncs

Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Change-Id: If8c62a05c7d28bfa6ac530c2cd5124834b4e8a70

2 years agostats: fix collector updates of symlinks 46/36146/3
Arthur de Kerhor [Mon, 16 May 2022 17:46:22 +0000 (19:46 +0200)]
stats: fix collector updates of symlinks

A node name is not bound to a node index. For example, if an interface
is deleted and re-added, the indexes of its nodes "<itfc_name>-tx"
and "<itfc_name>-output" may change. Thus, when the collector updates
the nodes stats, it should first delete all the symlinks for nodes that
have changed their names before adding new symlinks. Otherwise, it
could attempt to add already existing symlinks or delete valid ones.

Example of a series of command that triggers a crash in the assert
`ASSERT (node_data[i].symlinks[j] != CLIB_U32_MAX);`:

```
create loopback interface
create loopback interface
```
Wait for the nodes stats to update, then:
```
delete loopback interface intfc loop0
delete loopback interface intfc loop1
create loopback interface
create loopback interface
```

Type: fix

Change-Id: Ief8e7135e5c02dc6bc64dc94b76cff21ea9ab3a9
Signed-off-by: Arthur de Kerhor <arthurdekerhor@gmail.com>
2 years agoip: reassembly - increasing the nbuckets for reass 65/36165/2
Vijayabhaskar Katamreddy [Wed, 18 May 2022 14:31:03 +0000 (14:31 +0000)]
ip: reassembly - increasing the nbuckets for reass

Type: fix

Adding stats from debugging point of view

Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Change-Id: I3118d3fd5d630fad80a42ab960e30459789123cf

2 years agovppinfra: fix non-vector build on x86_64 64/36164/2
Damjan Marion [Wed, 18 May 2022 13:27:27 +0000 (15:27 +0200)]
vppinfra: fix non-vector build on x86_64

Type: fix
Fixes: 56f54af
Change-Id: Id03185953eb16da3a3276d2f21d64499784bbf17
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agomisc: update config script in IKEv2 test 34/36134/5
Filip Tehlar [Fri, 13 May 2022 00:36:39 +0000 (00:36 +0000)]
misc: update config script in IKEv2 test

Type: fix

Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Change-Id: Iba82f8e0f18f3e1e4da57f4c23ba9272e87afd93

2 years agoip: reassembly - increasing the nbuckets for reass 47/36147/2
Vijayabhaskar Katamreddy [Mon, 16 May 2022 22:18:37 +0000 (22:18 +0000)]
ip: reassembly - increasing the nbuckets for reass

Type: fix

as number of reass contexts increasing based on workers, increasing the number of nbuckets for bihash

Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Change-Id: I83d061a709ecb8845ce745b18d03fdefc795787f

2 years agointerface: fix overflow of link speed. 40/36140/4
Anton Nikolaev [Mon, 16 May 2022 10:33:17 +0000 (10:33 +0000)]
interface: fix overflow of link speed.

Type: fix

There were several places where mbps were converted to kbps for
link_speed, but often drivers of devices set link speed to unknown
(0xFFFFFFFF) on initialization, so there was multiplication of
link_speed equal 0xFFFFFFFF(UINT32_MAX) by 1000, this provides
overflow of unsigned int, and as result link_speed was equal
4295 Gbps, but actually link_speed is unknown.

Signed-off-by: Anton Nikolaev <anikolaev@netgate.com>
Change-Id: Ib462ed6ed685654af4687041e115bfb74e640f13

2 years agoacl: memory leak in acl_fa_session_cleaner_process 48/36148/1
Steven Luong [Mon, 16 May 2022 22:53:43 +0000 (15:53 -0700)]
acl: memory leak in acl_fa_session_cleaner_process

The statement
  pw0->pending_clear_sw_if_index_bitmap =
    clib_bitmap_dup (pw0->serviced_sw_if_index_bitmap);
will cause pw0->pending_clear_sw_if_index_bitmap's previous
vector to be gone. Need to free it prior to calling clib_bitmap_dup()

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I20de780e73daea7be17efa0bf660af2592cd4680

2 years agoflowprobe: add api messages to obtain current state 29/36129/6
Alexander Chernavin [Thu, 12 May 2022 14:56:24 +0000 (14:56 +0000)]
flowprobe: add api messages to obtain current state

Type: improvement

With this change:
 - add dump/details messages to obtain interfaces for which IPFIX flow
   record generation is enabled;
 - add get message to obtain parameters;
 - add a new message to set parameters with validation present and to
   correspond with get/set naming;
 - add tests for get/set parameters and dump/details interfaces.

Change-Id: I09f6ec990171ac8bcb9d2f5c92629803b8ab6c28
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
2 years agoip: format table ids with %u 39/36139/1
Nathan Skrzypczak [Mon, 16 May 2022 08:44:32 +0000 (10:44 +0200)]
ip: format table ids with %u

Type: fix

Change-Id: I69f7e23b23e8cfcfe57ba019862470e0eb4b06db
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
2 years agovlib: exec cli line-by-line processing and script updates 37/36137/2
Damjan Marion [Fri, 13 May 2022 22:14:02 +0000 (00:14 +0200)]
vlib: exec cli line-by-line processing and script updates

Type: improvement
Change-Id: I82e7c0acc547794bcc7c42f4b8881a8251bf7a9b
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agosession: revert "fix session cli maybe parse wrong args if executed in files" 38/36138/1
Damjan Marion [Fri, 13 May 2022 22:24:34 +0000 (00:24 +0200)]
session: revert "fix session cli maybe parse wrong args if executed in files"

Fixed at infra level.

Type: improvement
Change-Id: I43cf16870c1d2e12189073f7786d62375c46e2c2
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agovlib: process startup config exec scripts line by line 01/36101/6
Damjan Marion [Sun, 8 May 2022 18:48:37 +0000 (20:48 +0200)]
vlib: process startup config exec scripts line by line

This fixes long standing annoyance that CLIs with optional args cannot
be executed from file, as they cannot distinguish between valid optional
args and next line in the file.

Multiline statements can be provided simply by using backslash before \n.
Also comments are supported - everything after # is ignored up to the
end of the line.

Example:

 # multiline cli using backslash
show version \
       verbose # end of line comment

packet-generator new { \
   name x \
   limit 5 \
   # comment inside cmultiline cli \
   size 128-128 \
   interface local0 \
   node null-node \
   data { \
       incrementing 30 \
   } \
}

Type: fix

Change-Id: Ia6d588169bae14e6e3f18effe94820d05ace1dbf
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agodpdk: fix overflow in mtu arithmetic 31/36131/2
Mohammed Hawari [Fri, 13 May 2022 07:45:12 +0000 (09:45 +0200)]
dpdk: fix overflow in mtu arithmetic

When the driver's max_rx_pktlen is >= 65536, max_supported_frame_size
overflows and queue creation fails.

Change-Id: If78707cb698adf8619ec44a852dd05d570917577
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: fix

2 years agotests: fix pnat tests formatting 32/36132/1
Alexander Chernavin [Fri, 13 May 2022 08:34:34 +0000 (08:34 +0000)]
tests: fix pnat tests formatting

Type: fix

Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Change-Id: I944dc8418e7ab541ae96141c15e04abb33635ac4

2 years agoip: reassembly - Fixing buffer leaks, corruption 16/36116/6
Vijayabhaskar Katamreddy [Mon, 9 May 2022 14:13:07 +0000 (14:13 +0000)]
ip: reassembly - Fixing buffer leaks, corruption

Type: fix

*Buffer leaks and corruptions during internal errors, either overriding
or missing to add the buffer to the list

Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Change-Id: I6c2406cff53a741e800e2d05593696f3e9fd6ff5

2 years agoflowprobe: add support for reporting on inbound packets 94/36094/4
Alexander Chernavin [Fri, 6 May 2022 11:35:59 +0000 (11:35 +0000)]
flowprobe: add support for reporting on inbound packets

Type: feature

Currently, the plugin supports only IPFIX flow record generation for
outbound packets.

With this change:
 - add a new API message for enabling the feature on an interface that
   accepts direction (rx, tx, both);
 - update existing debug command for feature enabling to accept
   direction;
 - update existing debug command for showing currently enabled feature
   on interfaces to display direction;
 - update templates to include a direction field;
 - generate flow records on the specified direction and data path;
 - report direction in flow data;
 - update tests to use the new API;
 - add tests for inbound flows.

Change-Id: I121fd904b38408641036ebeea848df7a4e5e0b30
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
2 years agopnat: add support to wildcard IP Protocol field if not specified 12/36112/5
Fahad Naeem [Tue, 10 May 2022 06:03:52 +0000 (01:03 -0500)]
pnat: add support to wildcard IP Protocol field if not specified

- add pnat_binding_add_v2 which explicitly requires match mask to
  set to PNAT_PROTO if we want to match on IP Protocol
- fix pnat_binding_add backward compatibility i.e. no need to set
  match mast to PNAT_PROTO

Type: improvement

Signed-off-by: Fahad Naeem <fahadnaeemkhan@gmail.com>
Change-Id: I5a23244be55b7d4c10552c555881527a4b2f325f

2 years agotests: fix checkstyle-python 25/36125/4
Klement Sekera [Wed, 11 May 2022 14:54:09 +0000 (16:54 +0200)]
tests: fix checkstyle-python

Add --check to black to pass back error value and fail checkstyle if
a reformat would occur.

Type: fix
Fixes: d9b0c6fbf7aa5bd9af84264105b39c82028a4a29
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
Change-Id: I9a1fbe224929fc461ff833a589f73ca06e7cc9d6

2 years agoapi: revert the changes to atexit for shared memory client 24/36124/2
Andrew Yourtchenko [Wed, 11 May 2022 13:41:20 +0000 (13:41 +0000)]
api: revert the changes to atexit for shared memory client

2ca88ff97884ec9ed20a853b13cee6d86f9c9d0f introduced the change
into the shared memory atexit, which breaks IPSec tests in some
environments.

Type: fix
Fixes: 2ca88ff97884ec9ed20a853b13cee6d86f9c9d0f
Change-Id: Ia132cb045e8d66f55e41d29cffdca3458d61096d
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2 years agodpdk: clear the RTE_MEMPOOL_F_NON_IO 22/36122/2
Mohammed Hawari [Wed, 11 May 2022 09:36:19 +0000 (11:36 +0200)]
dpdk: clear the RTE_MEMPOOL_F_NON_IO

This mempool flag should be cleared when the mempool is populated, to
reproduce the behaviour of rte_mempool_populate_iova in DPDK 22.03

Change-Id: I4c0e07efca9df2e472e8e393689127c01cf66da2
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: fix
Fixes: 2f132efc3cafde5a0dd01ef8a91606528970cdf7

2 years agotests: replace pycodestyle with black 43/36043/15
Klement Sekera [Tue, 26 Apr 2022 17:02:15 +0000 (19:02 +0200)]
tests: replace pycodestyle with black

Drop pycodestyle for code style checking in favor of black. Black is
much faster, stable PEP8 compliant code style checker offering also
automatic formatting. It aims to be very stable and produce smallest
diffs. It's used by many small and big projects.

Running checkstyle with black takes a few seconds with a terse output.
Thus, test-checkstyle-diff is no longer necessary.

Expand scope of checkstyle to all python files in the repo, replacing
test-checkstyle with checkstyle-python.

Also, fixstyle-python is now available for automatic style formatting.

Note: python virtualenv has been consolidated in test/Makefile,
test/requirements*.txt which will eventually be moved to a central
location.  This is required to simply the automated generation of
docker executor images in the CI.

Type: improvement
Change-Id: I022a326603485f58585e879ac0f697fceefbc9c8
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2 years agonat: improve icmp type detection performance 96/26896/5
Klement Sekera [Wed, 6 May 2020 10:11:36 +0000 (10:11 +0000)]
nat: improve icmp type detection performance

Replace code with branchless code.

Type: improvement

Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: Ic38a20ad33483c1c26f90a927f8b963b0ead4a87

2 years agoip: reassembly: add documentation 96/35096/4
Klement Sekera [Tue, 25 Jan 2022 17:32:38 +0000 (17:32 +0000)]
ip: reassembly: add documentation

Type: docs
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I23008cde47d8b7a531346eab02902e2ced18742a

2 years agoip: fix buffer leaks in reassembly 93/32393/8
Klement Sekera [Thu, 20 May 2021 10:23:00 +0000 (12:23 +0200)]
ip: fix buffer leaks in reassembly

Type: fix
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I952ba7e042779855e29628d048da7edec1caaafd

2 years agovhost: memory leak upon deleting vhost-user interface 00/36100/2
Steven Luong [Fri, 6 May 2022 20:34:10 +0000 (13:34 -0700)]
vhost: memory leak upon deleting vhost-user interface

We allocate vring_spinlock for all vrings in the vui, not just the ones
being used. So when we free the vui, we have to free vring_spinlock for
all vrings, not just the one being used.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I3951fda71ce6e11474b04302116ea9e08b404758

2 years agodevices: fix crash on invalid interface 84/36084/3
Gabriel Ganne [Thu, 5 May 2022 08:16:56 +0000 (10:16 +0200)]
devices: fix crash on invalid interface

Type: fix

A simple "create host-interface name xxx" is enough to trigger the bug:
The interface is not found, and we goto error with apif=NULL

Signed-off-by: Gabriel Ganne <gabriel.ganne@gmail.com>
Change-Id: I2f894176d39b3d15efab054dc7340e7a0600a2e8

2 years agosession: fix session cli maybe parse wrong args if executed in files 74/36074/6
Xiaoming Jiang [Mon, 2 May 2022 15:07:31 +0000 (15:07 +0000)]
session: fix session cli maybe parse wrong args if executed in files

Type: fix

Signed-off-by: Xiaoming Jiang <jiangxiaoming@outlook.com>
Change-Id: Id19a52df4f237cf5d85d305fdc279ab7df2d6f4b

2 years agostats: add vlib_stats_free_string_vector 90/36090/2
Damjan Marion [Fri, 6 May 2022 10:39:10 +0000 (12:39 +0200)]
stats: add vlib_stats_free_string_vector

Type: improvement
Change-Id: Ifa9f908b24b5fe867826601d32eeb4f0d639fbeb
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agovppinfra: free vector against its heap 92/36092/2
Damjan Marion [Fri, 6 May 2022 10:37:30 +0000 (12:37 +0200)]
vppinfra: free vector against its heap

Type: fix
Change-Id: Ie292ee56dd5265a56ef472554aaf086e61da7089
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agostats: strings in string vector are c strings 91/36091/1
Damjan Marion [Fri, 6 May 2022 10:38:19 +0000 (12:38 +0200)]
stats: strings in string vector are c strings

Type: fix
Change-Id: I9cf9376f2813f7bceecc6a9d714dcb98df77615d
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agodpdk: fix generic flow input parsing in FDIR 86/36086/1
Ting Xu [Thu, 5 May 2022 09:12:50 +0000 (09:12 +0000)]
dpdk: fix generic flow input parsing in FDIR

This patch fixes the issue that in DPDK FDIR generic flow parsing, the
inputs will be changed during processing, which will lead to a failure
in vnet flow when creating generic flow rules.

Type: fix

Signed-off-by: Ting Xu <ting.xu@intel.com>
Change-Id: I107735a305ff48593d66746e0cd642c76ad5700d

2 years agordma: two small improvements for rdma interface 82/36082/2
Jieqiang Wang [Thu, 5 May 2022 12:33:57 +0000 (12:33 +0000)]
rdma: two small improvements for rdma interface

- fix branch prediction for checking rdma ERROR flag
- add the missing right angle bracket to help message

Type: improvement
Signed-off-by: Jieqiang Wang <jieqiang.wang@arm.com>
Reviewed-by: Lijian Zhang <lijian.zhang@arm.com>
Reviewed-by: Tianyu Li <tianyu.li@arm.com>
Change-Id: I2ce667631b3e3f60939069e2a16ddba0ff12a695

2 years agovat2: fix argument parsing 80/36080/2
Dave Wallace [Wed, 4 May 2022 21:31:55 +0000 (17:31 -0400)]
vat2: fix argument parsing

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I6d40ce90330d644469937a24eec47ea5bd5b649b

2 years agopolicer: output interface policer 58/35958/10
Stanislav Zaikin [Tue, 5 Apr 2022 17:23:12 +0000 (19:23 +0200)]
policer: output interface policer

Type: improvement

Change-Id: Ibc1b5059ed51c34334340534e9eb68121f556bce
Signed-off-by: Stanislav Zaikin <zstaseg@gmail.com>
2 years agoudp: remove buggy assert in udp encap 76/36076/2
Benoît Ganne [Wed, 4 May 2022 09:26:09 +0000 (11:26 +0200)]
udp: remove buggy assert in udp encap

It looks like in a distant past we were using a vnet_rewrite but this
no longer the case.

Type: fix

Change-Id: Ib8d336aec7d5abd7749f543739f531144e76e551
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2 years agotls: free app session if connect notify refused 79/36079/2
Florin Coras [Wed, 4 May 2022 19:02:56 +0000 (12:02 -0700)]
tls: free app session if connect notify refused

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iee6784c37a835b49d962ae6f87c279cbe65dde15

2 years agovhost: use_custom_mac set in create_vhost_user_if_v2 73/35873/7
Fahad Naeem [Mon, 4 Apr 2022 14:31:04 +0000 (10:31 -0400)]
vhost: use_custom_mac set in create_vhost_user_if_v2

Type: fix

set use_custom_mac for args in create_vhost_user_if_v2 API
Add testcase for custom mac-address

Signed-off-by: Fahad Naeem <fahadnaeemkhan@gmail.com>
Change-Id: Iac64d818e0f1e6d36187fe769ee33d202aaafd05
Signed-off-by: Fahad Naeem <fahadnaeemkhan@gmail.com>
2 years agoipsec: support per next-header next-nodes 41/35941/3
Benoît Ganne [Mon, 11 Apr 2022 16:51:25 +0000 (18:51 +0200)]
ipsec: support per next-header next-nodes

Type: feature

Change-Id: I940b6c9d206e407f3e17d66c97233cd658984e61
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2 years agotests: handle removed interface 65/35965/2
Klement Sekera [Thu, 14 Apr 2022 14:29:07 +0000 (16:29 +0200)]
tests: handle removed interface

Catch exception if sw_if_index is invalid when querying interface
binding config. If the interface is not there, it's surely not bound to
any table ...

Type: improvement
Change-Id: I1f3e04a631653feb5c2350662b6a041adccefa1f
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
2 years agovapi: support api clients within vpp process 11/35111/11
Ole Troan [Thu, 27 Jan 2022 15:25:43 +0000 (16:25 +0100)]
vapi: support api clients within vpp process

Add vapi_connect_from_vpp() and vapi_disconnect_from_vpp()
calls to allow API clients from within VPP process.

Add a new memclnt_create version that gives the user a
knob to enable or disable dead client scans (keepalive).

Type: feature
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id0b7bb89308db3a3aed2d3fcbedf4e1282dcd03f
Signed-off-by: Ole Troan <ot@cisco.com>
2 years agodhcp: fix dhcp_compl_event 69/36069/4
Jing Peng [Fri, 29 Apr 2022 19:14:07 +0000 (15:14 -0400)]
dhcp: fix dhcp_compl_event

This patch fixes two problems:

1. The lease field in the dhcp_compl_event message can include a list of
vl_api_domain_server_t structs, but no memory is allocated for it.
2. The DNS server address is not copied properly, resulting in wrong IP4
addresses in the event message.

Type: fix

Signed-off-by: Jing Peng <pj.hades@gmail.com>
Change-Id: I42c533e7af697568c69714011d983f88368a7e15

2 years agobuild: use env to find bash path 68/36068/1
Damjan Marion [Fri, 29 Apr 2022 17:09:38 +0000 (19:09 +0200)]
build: use env to find bash path

Type: make
Change-Id: I9f87134ac05d99051888024f889f05dae8e3feec
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agovppinfra: fix clib_mem_destroy 60/36060/2
Damjan Marion [Thu, 28 Apr 2022 15:46:13 +0000 (17:46 +0200)]
vppinfra: fix clib_mem_destroy

Passing wrong pointer to clib_mem_vm_unmap...

Type: fix
Change-Id: I1f695d77bc45d9a6de3a4a3da1fbe6faebdad15e
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agotests: fix handling failed test case 34/36034/2
Klement Sekera [Mon, 25 Apr 2022 14:39:09 +0000 (16:39 +0200)]
tests: fix handling failed test case

Add missing parameter where required.

Type: fix
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
Change-Id: I8cd7c31848836e3233cb79d1dd21884167db4354

2 years agotests: fix assert_nothing_captured 27/36027/5
Klement Sekera [Sat, 23 Apr 2022 09:34:29 +0000 (11:34 +0200)]
tests: fix assert_nothing_captured

Type: fix
Fixes: 26cd0242c95025e0d644db3a80dfe8dee83b6d7a
Change-Id: I9a88221af65f170dc6b1f0dc0992df401e489fa2
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
2 years agobuild: remove mbedtls from rpm dependencies 59/36059/3
Florin Coras [Thu, 28 Apr 2022 14:55:07 +0000 (07:55 -0700)]
build: remove mbedtls from rpm dependencies

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I50dfed0fba3c8547f5c52998cf777f2ed1d2e4a5

2 years agowireguard: Document wireguard async mode default 43/35943/3
Jon Loeliger [Tue, 12 Apr 2022 15:06:49 +0000 (10:06 -0500)]
wireguard: Document wireguard async mode default

Type: improvement
Signed-off-by: Jon Loeliger <jdl@netgate.com>
Change-Id: I446eb86c097d1bf99f05ee47f1c550689d70ced2

2 years agoaf_xdp: more meaningful frame_size error message 58/36058/2
Benoît Ganne [Thu, 28 Apr 2022 09:07:14 +0000 (11:07 +0200)]
af_xdp: more meaningful frame_size error message

Type: improvement

Change-Id: If3a83848ae0741334887c654b65e424b99caa73c
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2 years agosession: fix coverity warning 50/36050/3
Florin Coras [Wed, 27 Apr 2022 02:32:11 +0000 (19:32 -0700)]
session: fix coverity warning

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I67f5a2c8902dd14c09472c25599b3b1b493a6948

2 years agovapi: Fix build when directory contains @ 57/36057/1
Renato Botelho do Couto [Wed, 27 Apr 2022 20:51:20 +0000 (17:51 -0300)]
vapi: Fix build when directory contains @

During build some header guards are created based on full path where
build is happening.  If one directory contains @ character build breaks
because compiler believes it's a macro declaration.

Jenkins adds `@${EXECUTOR_NUMBER}` suffix to workspace directory when
it uses more than one executor for that job, breaking the build.

Replace any @ character on guard name by _ to get it fixed.

Type: fix
Change-Id: Id0f4cfc33fda95e168541aa4e353a0d08aa3b664
Signed-off-by: Renato Botelho do Couto <renato@netgate.com>
2 years agolinux-cp: sync addr and neigh only for lcp interfaces 36/36036/2
Stanislav Zaikin [Mon, 25 Apr 2022 17:11:36 +0000 (19:11 +0200)]
linux-cp: sync addr and neigh only for lcp interfaces

Type: fix

Signed-off-by: Stanislav Zaikin <zstaseg@gmail.com>
Change-Id: I792467b73449074e59c4232b1f82d134c399624c

2 years agolibmemif: timer causes spin at 100% cpu 29/36029/3
Daniel Béreš [Fri, 22 Apr 2022 08:06:17 +0000 (08:06 +0000)]
libmemif: timer causes spin at 100% cpu

In case of timer is set and expires:
1. timer_fd is readable and stay readable.
2. timer_fd is part of epoll_fd set. This makes epoll_pwait()
   calls return immediately instead of sleeping.

Type: fix

Signed-off-by: Daniel Béreš <dberes@cisco.com>
Change-Id: I9b228464fe45b83def9b182c885d6febf428049c

2 years agoflow: enable RSS queue group action for 5G enhancement 80/35780/2
Ting Xu [Fri, 25 Mar 2022 03:45:07 +0000 (03:45 +0000)]
flow: enable RSS queue group action for 5G enhancement

Enable the flow action for RSS queue group. Packets can be distributed
among queues in group based on specific fields. Queues must be continous
in the group. This feature is to support 5G enhancement requirement.

Type: feature

Signed-off-by: Ting Xu <ting.xu@intel.com>
Change-Id: I74fdc617659bcb61f00b3b1934c95ab1c73bb8f3

2 years agosession: export session counts to stats segment 37/36037/2
Florin Coras [Mon, 25 Apr 2022 23:15:02 +0000 (16:15 -0700)]
session: export session counts to stats segment

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I02aec410eaa7ccb999159b6967414fbaf4e76a3f

2 years agostats: string vector and node collector improvements 71/35971/2
Damjan Marion [Fri, 15 Apr 2022 13:53:17 +0000 (15:53 +0200)]
stats: string vector and node collector improvements

Type: improvement
Change-Id: Ibdadeb4e685f45a93f45504a84709391489abb6a
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agobuild: add option to build only for native CPU 30/36030/3
Damjan Marion [Mon, 25 Apr 2022 10:38:40 +0000 (12:38 +0200)]
build: add option to build only for native CPU

Significantly reduces compilation time for uses who are interested
to run binaries only on the build machine.

Type: make
Change-Id: I431f6f7374b6dfa8b3f7c72dc69f3d5cafd1f6bb
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agobuild: fix 16-8-8 mtrie build option 19/36019/2
Benoît Ganne [Fri, 22 Apr 2022 08:10:37 +0000 (10:10 +0200)]
build: fix 16-8-8 mtrie build option

VPP_IP_FIB_MTRIE_16 should be defined only if the option is enabled
instead of being defined as "ON" or "OFF".

Type: fix

Change-Id: Ib4e29a827bcbd84c8012f05ad264c1408ffccee7
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2 years agohsa: vcl test client epoll worker loop 68/35968/13
Florin Coras [Fri, 15 Apr 2022 01:19:42 +0000 (18:19 -0700)]
hsa: vcl test client epoll worker loop

Supports more connections and track connect time. Can be used to measure
CPS. Only works in unidirectional mode for now.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I70bc6a271996407dd16a96115f509bd680a0f302

2 years agosession: fix ctrl evt rpc elt pool realloc 17/36017/2
Florin Coras [Fri, 22 Apr 2022 01:03:12 +0000 (18:03 -0700)]
session: fix ctrl evt rpc elt pool realloc

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I79bfe91e81983b619c61a32285d8e038c2654147

2 years agosession svm: fix mq producer wait on q and ring 00/36000/4
Florin Coras [Wed, 20 Apr 2022 01:57:24 +0000 (18:57 -0700)]
session svm: fix mq producer wait on q and ring

Make sure producer drops lock when it waits for empty ring slot.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id77d54ee8c01bed20c9eaf5ad372ed4b1e9fa712

2 years agonat: tweak rfc7857 tcp connection tracking 92/35692/7
Ole Troan [Thu, 17 Mar 2022 10:58:38 +0000 (11:58 +0100)]
nat: tweak rfc7857 tcp connection tracking

The RFC7857 state machine introduced in 56c492a is a trade-off.
It tries to retain sessions as much as possible and also offers
some protection against spurious RST by re-establishing sessions if data
is received after the RST. From experience in the wild, this algorithm is
a little too liberal, as it leaves too many spurious established sessions
in the session table.

E.g. a oberserved pattern is:
client      server
         <- FIN, ACK
ACK      ->
ACK      ->
RST, ACK ->

With the current state machine this would leave the session in established state.

These proposed changes do:
 - require 3-way handshake to establish session.
   (current requires only to see SYNs from both sides)
 - RST will move session to transitory without recovery if data is sent after
 - Only a single FIN is needed to move to transitory

Fixes: 56c492aa0502751de2dd9d890096a82c5f04776d
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I92e593e00b2efe48d04997642d85bd59e0eaa2ea
Signed-off-by: Ole Troan <ot@cisco.com>
2 years agodevices: remove redundant access in af-packet input 30/35930/3
Mohsin Kazmi [Mon, 11 Apr 2022 12:52:28 +0000 (12:52 +0000)]
devices: remove redundant access in af-packet input

Type: fix

current_data is set to 0 for each packet in af-packet input node.
It is not required to include it to calculate the headers offset.

Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: I538d8c04e24c758155b3f8d6a1532472ef549459

2 years agosession: add support for listen proxies 73/35973/6
Florin Coras [Fri, 15 Apr 2022 19:37:48 +0000 (12:37 -0700)]
session: add support for listen proxies

Listener proxies are allowed to listen on IPs that are not local.
Configurable only by builtin apps for now.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Idb380ee3584a088878a03d45fd85e7bb0deeb590

2 years agonat: fix deleting nat ei out interface feature 72/35972/2
Alexander Skorichenko [Fri, 15 Apr 2022 16:32:18 +0000 (16:32 +0000)]
nat: fix deleting nat ei out interface feature

Type: fix

Set is_add function argument to 0 when deleting interface role.

Change-Id: I6ca88d6511e1c88285e51b3750eb501fde2b341b
Signed-off-by: Alexander Skorichenko <askorichenko@netgate.com>
2 years agorpm-packaging: remove mbedtls dependency 75/35975/3
Florin Coras [Mon, 18 Apr 2022 16:29:59 +0000 (09:29 -0700)]
rpm-packaging: remove mbedtls dependency

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Idf325b7f1ce75e973dbea4d5836609590c85dc38

2 years agohsa: vcl test client allow non-blocking connects 74/35974/2
Florin Coras [Fri, 15 Apr 2022 23:01:43 +0000 (16:01 -0700)]
hsa: vcl test client allow non-blocking connects

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If7dd56e76efc31ed66b865e2c7231d22ec2322b4

2 years agohsa: support configurable vcl client wrk loop 45/35945/10
Florin Coras [Wed, 13 Apr 2022 05:16:11 +0000 (22:16 -0700)]
hsa: support configurable vcl client wrk loop

Type: refactor

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I5e49f43b18ff011ce0b7259ed58854d81f910826

2 years agostats: store heap in the directory_entry vector 69/35969/2
Damjan Marion [Fri, 15 Apr 2022 13:27:24 +0000 (15:27 +0200)]
stats: store heap in the directory_entry vector

Type: improvement
Change-Id: I878803d14d1070ef5a00ed9d3f72022906d55191
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agobuild: c compiler version warnings 67/35967/6
Damjan Marion [Thu, 14 Apr 2022 20:18:19 +0000 (22:18 +0200)]
build: c compiler version warnings

Type: make
Change-Id: I9455da47f03383df822436d1adc4c4b5e58c7cf9
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agoapi: fix infinite loop in show api dump CLI 70/35970/2
Andrew Yourtchenko [Fri, 15 Apr 2022 14:23:41 +0000 (14:23 +0000)]
api: fix infinite loop in show api dump CLI

The following illustrates the problem:

./build-root/install-vpp_debug-native/vpp/bin/vpp api-trace { on } unix { cli-listen /tmp/vpp-api-cli.sock } plugins { plugin dpdk_plugin.so { disable } }
sleep 5
./build-root/install-vpp_debug-native/vpp/bin/vppctl -s /tmp/vpp-api-cli.sock show version
./build-root/install-vpp_debug-native/vpp/bin/vppctl -s /tmp/vpp-api-cli.sock show api dump file /tmp/api-table.master-api-baseline compare

The last CLI hangs in an infinite loop.

Fix the typo which got in during the conversion of _vec_len to read-only:

.@@ -1285,7 +1285,7 @@ extract_name (u8 * s)
.   rv = vec_dup (s);
.
.   while (vec_len (rv) && rv[vec_len (rv)] != '_')
.-    _vec_len (rv)--;
.+    vec_dec_len (rv, 0);
.

Type: fix
Fixes: 8bea589cfe0fca1a6f560e16ca66a4cf199041a2
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Change-Id: I4f895348ae0ebaaba9da97c3a440912d38210f10

2 years agovlib: disable cpu pinning if not configured 07/34707/13
Benoît Ganne [Thu, 9 Dec 2021 17:24:21 +0000 (18:24 +0100)]
vlib: disable cpu pinning if not configured

In some environment like when running a lot of functional tests, it can
be useful to run more VPP instances than CPU and let the Linux scheduler
decide what to do. This change disable cpu pinning altogether in the
single-threaded case, provided that no main-core is explicitely
specified in the config

Type: improvement

Change-Id: I8c2f36fdd49c00f9adaaeb4c81aefb27c3420a9b
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
2 years agogtpu: fix memory leak 24/35924/2
Leung Lai Yung [Sat, 9 Apr 2022 10:45:12 +0000 (10:45 +0000)]
gtpu: fix memory leak

Type: fix

Free the old rewrite string before assigning a new rewrite string for the updated new tteid value.

Signed-off-by: Leung Lai Yung <benkerbuild@gmail.com>
Change-Id: I1ec19bce6afda3dfdc31c8724b32ac7b9bc84e89

2 years agobuild: Ignore buildinfo file 60/35960/3
Renato Botelho do Couto [Thu, 14 Apr 2022 12:03:30 +0000 (09:03 -0300)]
build: Ignore buildinfo file

During deb package build, a .buildinfo file is created at build-root.
Add this to .gitignore.

Type: make

Signed-off-by: Renato Botelho do Couto <renato@netgate.com>
Change-Id: Id86c21e22aa2b9e4b559cfc0bc662de835fa1621

2 years agoipsec: perf improvement of ipsec4_input_node using flow cache 03/32903/8
Zachary Leaf [Fri, 25 Jun 2021 13:11:15 +0000 (08:11 -0500)]
ipsec: perf improvement of ipsec4_input_node using flow cache

Adding flow cache support to improve inbound IPv4/IPSec Security Policy
Database (SPD) lookup performance. By enabling the flow cache in startup
conf, this replaces a linear O(N) SPD search, with an O(1) hash table
search.

This patch is the ipsec4_input_node counterpart to
https://gerrit.fd.io/r/c/vpp/+/31694, and shares much of the same code,
theory and mechanism of action.

Details about the flow cache:
  Mechanism:
  1. First packet of a flow will undergo linear search in SPD
     table. Once a policy match is found, a new entry will be added
     into the flow cache. From 2nd packet onwards, the policy lookup
     will happen in flow cache.
  2. The flow cache is implemented using a hash table without collision
     handling. This will avoid the logic to age out or recycle the old
     flows in flow cache. Whenever a collision occurs, the old entry
     will be overwritten by the new entry. Worst case is when all the
     256 packets in a batch result in collision, falling back to linear
     search. Average and best case will be O(1).
  3. The size of flow cache is fixed and decided based on the number
     of flows to be supported. The default is set to 1 million flows,
     but is configurable by a startup.conf option.
  4. Whenever a SPD rule is added/deleted by the control plane, all
     current flow cache entries will be invalidated. As the SPD API is
     not mp-safe, the data plane will wait for the control plane
     operation to complete.
     Cache invalidation is via an epoch counter that is incremented on
     policy add/del and stored with each entry in the flow cache. If the
     epoch counter in the flow cache does not match the current count,
     the entry is considered stale, and we fall back to linear search.

  The following configurable options are available through startup
  conf under the ipsec{} entry:
  1. ipv4-inbound-spd-flow-cache on/off - enable SPD flow cache
     (default off)
  2. ipv4-inbound-spd-hash-buckets %d - set number of hash buckets
     (default 4,194,304: ~1 million flows with 25% load factor)

  Performance with 1 core, 1 ESP Tunnel, null-decrypt then bypass,
  94B (null encrypted packet) for different SPD policy matching indices:

  SPD Policy index    : 2          10         100        1000
  Throughput          : Mbps/Mbps  Mbps/Mbps  Mbps/Mbps  Mbps/Mbps
  (Baseline/Optimized)
  ARM TX2             : 300/290    230/290    70/290     8.5/290

Type: improvement
Signed-off-by: Zachary Leaf <zachary.leaf@arm.com>
Signed-off-by: mgovind <govindarajan.Mohandoss@arm.com>
Tested-by: Jieqiang Wang <jieqiang.wang@arm.com>
Change-Id: I8be2ad4715accbb335c38cd933904119db75827b

2 years agocrypto-openssl: use getrandom syscall 54/35954/2
Guillaume Solignac [Wed, 13 Apr 2022 13:52:05 +0000 (15:52 +0200)]
crypto-openssl: use getrandom syscall

The sys/random.h header, which provides the getrandom syscall wrapper,
was only added in glibc2.25. To make it compatible with older version,
we can directly call the syscall.

Type: improvement
Signed-off-by: Guillaume Solignac <gsoligna@cisco.com>
Change-Id: I93c5f8a49c0323511a4e34273f0b3c0e24663bfd

2 years agovppinfra: fix GCC 7.3 build error with asm inline 49/35949/2
Guillaume Solignac [Wed, 13 Apr 2022 10:03:48 +0000 (12:03 +0200)]
vppinfra: fix GCC 7.3 build error with asm inline

GCC added asm inline in 8.3, so we change asm inline to asm volatile.

Type: fix
Fixes: d5045e68a782 ("vppinfra: introduce clib_perfmom")
Signed-off-by: Guillaume Solignac <gsoligna@cisco.com>
Change-Id: I9f7781ba9de66211404348ff477a17059b408a78

2 years agobuild: fix rpm build nasm not found 46/35946/2
Tianyu Li [Tue, 12 Apr 2022 07:05:08 +0000 (15:05 +0800)]
build: fix rpm build nasm not found

Type: make
Signed-off-by: Tianyu Li <tianyu.li@arm.com>
Change-Id: I7ac1d0472edf8d48eac21a7b580a06456bf60c30

2 years agovppinfra: fix clang-10 build error with asm inline 47/35947/1
Tianyu Li [Tue, 12 Apr 2022 03:58:29 +0000 (03:58 +0000)]
vppinfra: fix clang-10 build error with asm inline

clang start to support parse asm inline from clang-11,
Use asm volatile instead.

Type: fix
Fixes: d5045e68a782 ("vppinfra: introduce clib_perfmom")
Signed-off-by: Tianyu Li <tianyu.li@arm.com>
Change-Id: I00e5e19856caaed94e22f8fa6cf4f918483976a4

2 years agovppinfra: vector perf improvements 91/35891/9
Damjan Marion [Mon, 11 Apr 2022 16:41:49 +0000 (18:41 +0200)]
vppinfra: vector perf improvements

Type: improvement
Change-Id: I37c187af80c21b8fb1ab15af112527a837e0df9e
Signed-off-by: Damjan Marion <damarion@cisco.com>
2 years agoip: fix arc start in ip46-local for local mfib entries 28/35928/2
Alexander Chernavin [Mon, 11 Apr 2022 13:02:11 +0000 (13:02 +0000)]
ip: fix arc start in ip46-local for local mfib entries

Type: fix

After changes made in f840880, VRRP IPv6 cannot reply for neighbor
solicitations requesting the link layer address of the configured
virtual address.

VRRP IPv6 enables the vrrp6-nd-input feature in the ip6-local feature
arc for an interface on which a virtual router is configured. When
neighbor solicitations arrive on that interface, ip6-local should start
feature arc walk for that interface and the messages should be processed
by vrrp6-nd-input. The problem is that currently, the feature arc is
started for the interface obtained from the receive DPO that has
interface unset (i.e. max u32) for local mfib entries. Thus, the feature
arc is started not on the interface the messages were received on and
vrrp6-nd-input is not traversed.

With this fix, if interface obtained from the receive DPO is unset, use
RX interface from the buffer to start the ip46-local feature arc.

Also, enable tests of this case for both IPv4 and IPv6 address families
that are currently tagged as extended and not run on every change. They
configure VRRP with priority 255 and are expected to be stable.

Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Change-Id: I11ef3d5a7a986e04431e8613d1510b8666094bd7

2 years agohsa: fix coverity warning 40/35940/1
Florin Coras [Tue, 12 Apr 2022 14:34:35 +0000 (07:34 -0700)]
hsa: fix coverity warning

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I9cf21ee7ad363dd1af5ca75f07bfe38d8fe749f9

2 years agohsa: vcl test client option to close only client 37/35937/3
Florin Coras [Tue, 12 Apr 2022 02:28:11 +0000 (19:28 -0700)]
hsa: vcl test client option to close only client

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I45c63e0a7d7179a0f27ca3f093bd3cf7458a12d3

2 years agotcp: limit persist segment size if window available 51/35651/3
Florin Coras [Tue, 15 Mar 2022 21:24:59 +0000 (14:24 -0700)]
tcp: limit persist segment size if window available

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ie1ae401d5105aa42761d3cac5dfbe523f3995c87

2 years agotests: fix bihash unit test threads count 36/35936/4
Jing Peng [Mon, 11 Apr 2022 20:36:28 +0000 (16:36 -0400)]
tests: fix bihash unit test threads count

In test_bihash_threads, if a test thread fails to be created,
it is still counted towards the total thread count, which could
lead to never-ending test loop. This patch fixes the issue.

Type: fix

Signed-off-by: Jing Peng <pj.hades@gmail.com>
Change-Id: Ic0f1d4dde9c5ea672b52f0e2e49f16d42f982b77

2 years agoteib: use nexthop table id 33/35933/1
Benoît Ganne [Mon, 11 Apr 2022 08:45:43 +0000 (10:45 +0200)]
teib: use nexthop table id

Use the specified nexthop table id instead of the interface table id.

Type: fix

Change-Id: I61bf61d50d2716fcd9a6e35df4d60222dc4f36d5
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2 years agointerface: fix the offloads 72/35872/2
Mohsin Kazmi [Fri, 1 Apr 2022 13:42:20 +0000 (13:42 +0000)]
interface: fix the offloads

Type: fix

Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: I9f3d1a8574b15f09a458baad98c815e087fd60b8

2 years agotls: fix connected notifications with no app wrk 26/35926/5
Florin Coras [Sun, 10 Apr 2022 20:34:47 +0000 (13:34 -0700)]
tls: fix connected notifications with no app wrk

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I805131b4e3d0cb2fab1d3bf76db659c67522c2e8