Neale Ranns [Wed, 19 Jun 2019 13:25:56 +0000 (06:25 -0700)]
gbp: VRF scoped contracts
Type: feature
Change-Id: I01772cfc3a0118a5c49bf346339788824e6931b2
Signed-off-by: Neale Ranns <nranns@cisco.com>
Paul Vinciguerra [Sat, 29 Jun 2019 12:33:05 +0000 (08:33 -0400)]
papi: refactor set_errors_str
Assuming 2500 50 char lines:
string_concat elapsed: 5.
919933e-04
string_join elapsed: 2.
830029e-04
string_concat size: 156,312,500
string_join size: 125,000
Type: refactor
Change-Id: I0a400265426bde492e9a651d24996ddcfe954aa1
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Neale Ranns [Sun, 30 Jun 2019 09:05:05 +0000 (09:05 +0000)]
igmp: accept packets that have more on the wire data than IGMP reports.
IGMPv3 sends a variable length of sources in a query. Today if the
amount of data on the wire does not exactly match that required for the
number of sources the packet is dropped.
Relax this check and instead accept the packet is the amount of wire
data is equal or greater than the number of sources.
Some devices on the wild internet pad small packets.
Type: feature
Change-Id: I102682814b38c0a0614d71816c9a286d90b834df
Signed-off-by: Neale Ranns <nranns@cisco.com>
Paul Vinciguerra [Wed, 26 Jun 2019 01:02:40 +0000 (21:02 -0400)]
pg: format_pg_input_trace - reorder fields
00:00:00:814640: pg-input
stream pcap0-sw_if_index-1, 42 bytes, 1 sw_if_index
is changed to:
00:00:00:814640: pg-input
stream pcap0-sw_if_index-1, 42 bytes, sw_if_index 1
Type: style
Change-Id: I9bb32494c9c1d08bc7588f088ed67a60ed3236dd
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Steven Luong [Tue, 25 Jun 2019 20:47:06 +0000 (13:47 -0700)]
devices: virtio pci leaking spinlock
Memory is dirt cheap. But there is no need to throw it away.
Type: fix
Change-Id: I155130ab3c435b1c04d7c0e9f54795b8de9383d9
Signed-off-by: Steven Luong <sluong@cisco.com>
Florin Coras [Fri, 28 Jun 2019 19:45:12 +0000 (12:45 -0700)]
svm: rename fifo tx notifications to reflect use
Type: refactor
Change-Id: I651db44acdcb666a9c63e1037352cf88c68795b5
Signed-off-by: Florin Coras <fcoras@cisco.com>
Vijayabhaskar Katamreddy [Fri, 28 Jun 2019 19:59:23 +0000 (12:59 -0700)]
interface: fixes for buliding for 32bit targets
* structure alignment and padding issues
Type: fix
Change-Id: Ic7c2a8cb5a5526902463f3b4d2d93284b454ab6f
Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Neale Ranns [Wed, 19 Jun 2019 07:14:10 +0000 (07:14 +0000)]
ip: ip-lookup - remove the dead code
Type: refactor
Change-Id: I791cc63e989df049104420faf74fc28f965b6648
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Barach [Fri, 28 Jun 2019 19:08:49 +0000 (15:08 -0400)]
vppinfra: add dummy/noop f32/f64 endian swap fns
Makes life easier for binary API language bindings
Type: fix
Change-Id: Ib459274fda05153d01cbb7bc328a8407e3ee5027
Signed-off-by: Dave Barach <dave@barachs.net>
Nathan Skrzypczak [Wed, 22 May 2019 16:41:50 +0000 (18:41 +0200)]
quic : Use TX event for app read notification
Type: feature
Change-Id: I1846cdeb35f079249f66a0351aa244c540923a43
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Florin Coras [Fri, 28 Jun 2019 16:18:48 +0000 (09:18 -0700)]
tcp: reject out-of-order fins
Type:fix
Change-Id: Iab2c308739f7733dbf70953e0ea87dcc404c60da
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 28 Jun 2019 16:41:28 +0000 (09:41 -0700)]
tcp: fix close-waiting check for outstanding tx data
Type: fix
Change-Id: I9e0e1bb933c38b17ac9fb8bf11b81e2fed021bf8
Signed-off-by: Florin Coras <fcoras@cisco.com>
Nathan Skrzypczak [Wed, 26 Jun 2019 11:53:08 +0000 (13:53 +0200)]
session: add half_open_has_fifos for UDPC
Type: fix
Change-Id: Iede83a4e72b88fd55bf56ec0ca71c9196ce743cd
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Paul Vinciguerra [Thu, 27 Jun 2019 00:45:08 +0000 (20:45 -0400)]
tests: handle TypeErrors in calls to VppDiedError
Type: test
Change-Id: I869768ed25efa3350f025fba329466db69805803
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Benoît Ganne [Thu, 27 Jun 2019 15:31:28 +0000 (17:31 +0200)]
tap: fix memory errors in create/delete
If the host interface name is not specified at creation, host_if_name
was wrongly set to a stack-allocated variable. Make sure it always
points to a heap allocated vector.
At deletion time, we must free all allocated vectors.
Type:fix
Change-Id: I17751f38e95097998d51225fdccbf3ce3c365593
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Neale Ranns [Fri, 28 Jun 2019 08:33:24 +0000 (08:33 +0000)]
igmp: Trace more data form input packets
Type: feature
Change-Id: I40ecc0da1281115f6e540064224538fe9472887e
Signed-off-by: Neale Ranns <nranns@cisco.com>
Vladimir Kropylev [Wed, 26 Jun 2019 09:56:21 +0000 (12:56 +0300)]
tcp: Setup initial CWND as configured
Type: feature
Change-Id: I7f476f4f81994c9c6cc2e8091de08adff4bcbc77
Signed-off-by: Vladimir Kropylev <vladimir.kropylev@enea.com>
Florin Coras [Thu, 27 Jun 2019 17:32:27 +0000 (10:32 -0700)]
sctp: add option to enable/disable
Type: feature
By default sctp is disabled to avoid wasting cycles.
Change-Id: I1e2f764c7168b5c15062efbe5895de93dcc2614e
Signed-off-by: Florin Coras <fcoras@cisco.com>
Aloys Augustin [Fri, 21 Jun 2019 15:04:29 +0000 (17:04 +0200)]
tests: pin python dependencies
This commit ensures that the tests always run with the exact same
version for all the Python dependencies. It uses pip-tools to achieve
that.
Our top-level dependencies are specified in the requirements.txt file.
From this file, pip-tools generates the requirements-{2,3}.txt file,
which pins all the versions of all the recursive dependencies, and is
used to install the packages in the test virtualenv.
To change or add a top-level dependency, update requirements.txt and run
make test as usual with python2 and python3. The requirements-{2,3}.txt
file will be updated and you can verify that nothing breaks. Then add
all requirements* files in your commit.
To refresh the python packages (i.e. get new versions of the recursive
dependencies, or of the dependencies that are not pinned in
requirements.txt), just run:
PYTHON=python2.7 make test-refresh-deps
PYTHON=python3.6 make test-refresh-deps
and this will update the requirements-{2,3}.txt files. Ideally we
should run this after each release.
Type: make
Change-Id: Ic533de3d06ec4019ff38f5231208da6f1025bfc7
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
Nathan Skrzypczak [Wed, 19 Jun 2019 11:42:37 +0000 (13:42 +0200)]
session: Add transport vft protocol options
Type: refactor
Change-Id: I4e0afc206e4871596c2ed8a6ca00914a379f1526
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Aloys Augustin [Thu, 27 Jun 2019 14:10:23 +0000 (16:10 +0200)]
quic: fix tests
Reduce the amount of data sent to avoid a hang in the QUIC stack when
the fifos get full. This fixes the QUIC tests in debug mode while
https://gerrit.fd.io/r/c/19823/ is not merged.
Change-Id: I1ed4c5dc3d41c09bc674de808f3778a074b15454
Type: test
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
Florin Coras [Thu, 27 Jun 2019 04:11:26 +0000 (21:11 -0700)]
svm: improve fifo segment test
Type: feature
Try to also catch weirdness when running tests on arm cpus.
Change-Id: I45ab7c225f43623447271e67ebf37f94236a288f
Signed-off-by: Florin Coras <fcoras@cisco.com>
Paul Vinciguerra [Wed, 26 Jun 2019 00:51:31 +0000 (20:51 -0400)]
tests: rename stream name in tests
PacketGenerator streams were named based on their sw_if_index but without
knowing that, it looked like it was paired with the interface instance value.
Reencode the name to encode the data in a clearer way.
20:48:12,859 CLI: packet-generator new pcap
/tmp/vpp-unittest-TestClassifierPBR-6DVQW2/pg0_in.pcap
source pg0 name pcap0-sw_if_index-1
Change-Id: I5b82193943fee0cf060900d73aaaaecca1247105
Type: style
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
jdenisco [Wed, 26 Jun 2019 18:17:12 +0000 (18:17 +0000)]
docs: Update the vhost section
Change-Id: Ic7a144ffda0d0a3e0f6f9bc1a4790ab36fdf002e
Signed-off-by: jdenisco <jdenisco@cisco.com>
Neale Ranns [Thu, 27 Jun 2019 08:13:35 +0000 (08:13 +0000)]
build: remove japi-install from Makefile
Type: fix
Change-Id: I63245280a0939d07f495b11005596ffdfe1d85c8
Signed-off-by: Neale Ranns <nranns@cisco.com>
Steven Luong [Wed, 26 Jun 2019 22:32:43 +0000 (15:32 -0700)]
lacp: custom dump for sw_interface_lacp_dump
Add custom dump code for sw_interface_lacp_dump
Type: fix
Change-Id: Ifa76192ec65f596391c07b151d2a7fceed502665
Signed-off-by: Steven Luong <sluong@cisco.com>
Neale Ranns [Wed, 26 Jun 2019 13:59:53 +0000 (06:59 -0700)]
vom: get the tests working again
Type: fix
Fixes:
097fa66b
Change-Id: Ib73714665e3325c7e1e8f939275933a4d219f96b
Signed-off-by: Neale Ranns <nranns@cisco.com>
Vratko Polak [Wed, 26 Jun 2019 15:24:56 +0000 (17:24 +0200)]
papi: prevent message_table inconsistencies
Socket transport is maintaining message_table to map
message name to index. After disconnect and re-connect,
the VPP may have been restarted with different set of plugins,
so message_table has to be wiped.
+ Edited MAINTAINERS to recognize "papi" as a separate component.
Type: fix
Change-Id: I1f16ad7ee0886e03bbc6a17bcddbfcaa322354e5
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Florin Coras [Wed, 26 Jun 2019 16:11:23 +0000 (09:11 -0700)]
tcp session: improvement to tests
Type: fix
Attempt at fixing a random failing tcp test
Change-Id: I73aa31e26dd2df77d8b975e4fc88df16d8991863
Signed-off-by: Florin Coras <fcoras@cisco.com>
Zhiyong Yang [Fri, 14 Jun 2019 01:14:33 +0000 (21:14 -0400)]
bonding: fix comment typo
Type: style
Change-Id: I28908756019f8ca54c50334c470d8eded5621ade
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Florin Coras [Wed, 26 Jun 2019 01:14:13 +0000 (18:14 -0700)]
svm: fix fifo segment free chunk bytes accounting
Type:fix
Change-Id: Icab89337eb3dbdc93d0fb453cfd34090026072b7
Signed-off-by: Florin Coras <fcoras@cisco.com>
Paul Vinciguerra [Wed, 26 Jun 2019 10:52:32 +0000 (06:52 -0400)]
tests: fix test-checkstyle failure in test_memif.py
Type: style
Change-Id: Ifea1fed5a6943605a6111afb33c54a8ff852d087
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Neale Ranns [Wed, 26 Jun 2019 09:16:50 +0000 (02:16 -0700)]
fib: default flow hash config for each DPO protocol type
Type: fix
Fixes:
59fa121f
Change-Id: I9eb4fe1612734e54932228527c37bf33b705dbdb
Signed-off-by: Neale Ranns <nranns@cisco.com>
Lijian.Zhang [Wed, 29 May 2019 09:13:42 +0000 (17:13 +0800)]
vppinfra: add u64x2_scatter/u32x4_scatter
Add u64x2_scatter/u32x4_scatter in vector_neon.h. u64x2_scatter/u32x4_scatter
scatters data from SIMD register to scattered memory locations.
Type: feature
Change-Id: I298d5478c7ba6935ab7402a6d467c7ee00f17e9f
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Sirshak Das <Sirshak.Das@arm.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Benoît Ganne [Thu, 6 Jun 2019 15:53:21 +0000 (17:53 +0200)]
gbp: enforce same endpoint mac and ip src
During packet classification, make sure packets coming from an EP also
matches this specific EP IP address and vice-versa. This prevents and EP
to send a packet on behalf of another EP.
Type: fix
Change-Id: I30287644ec73b90d9b6913952a82b2baedf6a5ff
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Paul Vinciguerra [Thu, 6 Jun 2019 18:07:55 +0000 (14:07 -0400)]
api: refactor format_vl_api_prefix_t return keys
format_vl_api_prefix_t returns a dict with keys 'address' and 'address_length',
but other format_vl_api_prefix functions return a dict with 'prefix', and 'len'.
Refactor all format_vl_api_prefix_t to return consistent keys 'address' and 'len'.
Type: refactor
Change-Id: I5f9558fc2da8742a303266e011102f5b2db80aad
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Tue, 18 Jun 2019 11:57:53 +0000 (07:57 -0400)]
tests: set object_id for routes.
Object id's are used as keys in the object repository.
They need to be unique.
Also useful for debugging in log.txt.
Type: test
Change-Id: I69b5f3a7508918a5780ff8f20d27d4a3c34a5699
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Neale Ranns [Wed, 26 Jun 2019 07:26:08 +0000 (00:26 -0700)]
vom: fix test build failure
Type: fix
Fixes:
097fa66b
Change-Id: Id5ae4029f27af6cba76d6527c0d3d7212ab84f3e
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Fri, 21 Jun 2019 14:57:18 +0000 (07:57 -0700)]
api: Remove the inlines file and replace with library functions
using inlines exposes the users to the internal data types used by VPP, namely vec.h. This file does not compile with a C++ compiler.
Type: feature
Change-Id: I1544fdd9eae998309f865df61df78571bdb96903
Signed-off-by: Neale Ranns <nranns@cisco.com>
Jakub Grajciar [Tue, 25 Jun 2019 08:22:11 +0000 (10:22 +0200)]
tests: fix memif tests
remote_test.py - Remove 'ret' arg from _remote_exec(), so that the function
always reads the reply from the pipe. (fix unmatched request/reply)
memif_test.py - Don't register VppIpRoute to VppObjectRegistry.
Type: fix
Change-Id: I8a51e7ffd68df5f379534f5ddd5ec9367a89be32
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Chore [Tue, 25 Jun 2019 12:45:37 +0000 (17:15 +0430)]
misc: nat is added to MAINTAINERS file.
Type: fix
Change-Id: I3c6a0abad22c86c7125dc10e6d9be3d5af6d4ee3
Signed-off-by: Chore <s3m2e1.6star@gmail.com>
Mohsin Kazmi [Tue, 25 Jun 2019 12:55:46 +0000 (14:55 +0200)]
vom: Add getter for interface admin state
Type: feature
Change-Id: I3409bedb45f033210202c151a2267b036b8b97d6
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Paul Vinciguerra [Tue, 25 Jun 2019 21:57:31 +0000 (17:57 -0400)]
api: initialize sw_if_index earlier in vxlan_gbp_tunnel_add_del
In the case of an error, it is uninitialized.
Type: fix
Change-Id: Ib88fb997e5eef410c1cd970674d9385575f30366
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Steven Luong [Tue, 25 Jun 2019 23:01:41 +0000 (16:01 -0700)]
misc: add bond_dump, slave_dump, and rx_placement_dump
Fixed the missing bond_dump, slave_dump, and rx_placement_dump in
custom_dump.c
Type: fix
Change-Id: I9bf9ce071db175543edb383768c5915b939758ae
Signed-off-by: Steven Luong <sluong@cisco.com>
Steven Luong [Wed, 26 Jun 2019 05:36:26 +0000 (22:36 -0700)]
vmxnet3: custom dump and debug cli fix
Add missing custom dump for vmxnet3_create, vmxnet3_delete, and
vmxnet3_dump.
Fix vmxnet3_create debug cli which may not parse all parameters
correctly due to passing address of u16 to unformat(). The fix is
to use a u32 local variable to receive the correct value from
unformat().
Type: fix
Change-Id: I04251c9ed0ab397ed4b1b5843a73880aec98b9f6
Signed-off-by: Steven Luong <sluong@cisco.com>
Neale Ranns [Tue, 25 Jun 2019 11:38:37 +0000 (11:38 +0000)]
fib: adj cover refinement check change
Usually the adj cover refinement check which ensures that for any
adj sourced prefix its cover is connected, is satified by the presence
of the interface source. The interface source has a high priority
hence during the adj refinement check get_flags() which uses the best
source, usually returns the flags for the interface source. However,
in the presence of higher priority sources that interpose get_flags does
not return connected and the check fails.
With this change add a specific check for the interface source if the
best is not connected.
Type: feature
Change-Id: Iabc3e29fe7c447fc3ef313e40b00d48fab09fba4
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Tue, 25 Jun 2019 19:55:15 +0000 (12:55 -0700)]
hsa: move vcl test apps to hsa
Type: refactor
Change-Id: I352975585c1091bfc5b85d7f8fe985f9059820a7
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Tue, 25 Jun 2019 22:30:12 +0000 (15:30 -0700)]
misc: fix sctp test with debug images
Type:fix
Change-Id: I6bf938d8c71b0fac6e093278132b00fc1ab951bb
Signed-off-by: Florin Coras <fcoras@cisco.com>
Vratko Polak [Tue, 25 Jun 2019 17:01:34 +0000 (19:01 +0200)]
tests: one more ipfix flush cli to api replacement
Type: fix
Fixes:
21b83e96d6076cda01ee80343840bc1166557150
Change-Id: I8216127ddbbf3301d2602bab54dbc433233387a2
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Vladimir Kropylev [Mon, 24 Jun 2019 21:06:52 +0000 (00:06 +0300)]
tcp: window update ack
Type: feature
Provide interface for sending Window Update ACK,
ensuring it will be sent only once, if RWND became non-zero,
after zero RWND has been advertised before.
Change-Id: I7f0d8af76d7763208625df68ab4ac3727fdaf449
Signed-off-by: Vladimir Kropylev <vladimir.kropylev@enea.com>
Andreas Schultz [Tue, 25 Jun 2019 13:29:06 +0000 (15:29 +0200)]
vppinfra: fix tw_timer_first_expires_in_ticks for multiple wheels
When only the fast in wheel is in use, the next expiring has
to be within the fast_slot_bitmap.
With mutliple wheels, the next expiring timer could be in the
slow wheel. The timers on the slow wheel are only moved into the
fast wheel when the fast wheel index reaches TW_SLOTS_PER_RING.
When calculating the next expiring timer we therefor need to
consider the timers on the slow wheel as well.
When there are no more before reaching TW_SLOTS_PER_RING, instead
of scanning the slow wheel, return the number of ticks until
TW_SLOTS_PER_RING is reached.
Type: fix
Change-Id: I847031f8efc015c888d082f0b0c1bd500aa65704
Signed-off-by: Andreas Schultz <andreas.schultz@travelping.com>
Signed-off-by: Dave Barach <dave@barachs.net>
Florin Coras [Wed, 12 Jun 2019 22:38:19 +0000 (15:38 -0700)]
tcp: delivery rate estimator
Type: feature
First cut implementation with limited testing. The feature is not
enabled by default and the expectation is that cc algorithms will enable
it on demand.
Change-Id: I92b70cb4dabcff0e9ccd1d725952c4880af394da
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Barach [Tue, 25 Jun 2019 14:16:10 +0000 (10:16 -0400)]
build: fix error messages in check_commit_msg.sh
Type: fix
Change-Id: I432c22880a418be35ad9f99c3e4afc90449e83d1
Signed-off-by: Dave Barach <dave@barachs.net>
Florin Coras [Tue, 25 Jun 2019 02:33:40 +0000 (19:33 -0700)]
lisp: move cp tests to unittest
Type: refactor
Also reformats and fixes some of the tests.
Change-Id: I074c677fd9b28e192f72a2db32f6f2dbda9a314f
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Tue, 25 Jun 2019 01:02:43 +0000 (18:02 -0700)]
hsa: move external echo apps to hsa
Type: refactor
Change-Id: I9a5c2abfd0c5444b31d9020cea918f9cd28f1ac2
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Mon, 24 Jun 2019 23:54:52 +0000 (16:54 -0700)]
svm: make sure chunk search does not return tnil
Type:fix
Change-Id: I8405bf8d93b4468c54f4f3c5dcd21ef91a6b1048
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Tue, 25 Jun 2019 00:31:33 +0000 (17:31 -0700)]
hsa: move session-apps to host-stack apps plugin
Type:refactor
Change-Id: I114fea3a54258797e961d8627a99ba2098674d20
Signed-off-by: Florin Coras <fcoras@cisco.com>
Paul Vinciguerra [Sun, 16 Jun 2019 00:31:31 +0000 (20:31 -0400)]
tests: fix test_gbp.py.
A number of VppGbpContractRules were missing the hash_mode_t
and were being replaced by an optional kwarg.
Type: fix
Change-Id: I6ca03c93b69e4355c237a6c9402e1e178b701b21
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Chore [Tue, 25 Jun 2019 09:51:26 +0000 (14:21 +0430)]
quic: test_quic.py style is fixed.
Type: test
Change-Id: I943f95ef740a0646b2da363c6a16dff1f4a2bb83
Signed-off-by: Chore <s3m2e1.6star@gmail.com>
Paul Vinciguerra [Wed, 19 Jun 2019 14:29:24 +0000 (10:29 -0400)]
tests: if vpp is dead, specify the test name in the output
'Exception: VPP is dead when setting up the test'
is more helpful with the test info.
Type: test
Change-Id: I6a262fdcf2ecb33aae17bef3d19745053a0bade8
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Thu, 20 Jun 2019 17:46:46 +0000 (13:46 -0400)]
api: fix vac_read return codes
- vac_read was returning the same code for multiple errors.
- Refactor VppTransportShmemIOError to capture rv and description.
Type: refactor
Change-Id: Ifb8ca5ff679f658bcd92a43ecddaffd2fc18dbd5
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Guillaume Solignac [Wed, 15 May 2019 10:02:33 +0000 (12:02 +0200)]
ipsec: print spi in hexadecimal
Print the SPI in hexadecimal and decimal.
Type: feature
Change-Id: I012e94f9147058064e06c6bb4622ab6b6507957d
Signed-off-by: Guillaume Solignac <gsoligna@cisco.com>
Filip Tehlar [Thu, 20 Jun 2019 23:53:43 +0000 (23:53 +0000)]
avf: fix clear hw stats
AVF plugin is missing a handler for clearing stats. This patch will
implement it.
Ticket: VPP-1701
Type: fix
Change-Id: If4b4354da442065896bb001deda23f64ddc18fb4
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Neale Ranns [Fri, 21 Jun 2019 12:44:11 +0000 (12:44 +0000)]
ipsec: return error if the engine backend has no handler for the
requested alogrithm.
Type: feature
Change-Id: I19a9c14b2bb52ba2fc66246845b7ada73d5095d1
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Wallace [Wed, 5 Jun 2019 14:40:07 +0000 (10:40 -0400)]
quic: server create streams test case
Type: test
* Refactor quic_echo test app
* Add timinig capabilities
* Add multiple quic tests
Change-Id: I3302c66539b12c1375d1a0c6d46f9ff4c6f2b27c
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Nathan Skrzypczak [Thu, 20 Jun 2019 07:58:37 +0000 (09:58 +0200)]
session: full lock on session_send_evt_to_thread
Type: fix
This was causing issues in QUIC when an app client & the protocol
app compete for the worker msg_queue. Might not be ideal performance-
wise.
Change-Id: I629892253d5b5d968f31ad1d56f18463e143d6b4
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Andrew Yourtchenko [Mon, 24 Jun 2019 16:26:24 +0000 (16:26 +0000)]
tests: fix the MAINTAINERS file
Undo the change from I8488ab318a596c9b737308829cedfb7e96e57302 to the MAINTAINERS file
Change-Id: Ieea4a59dad127c2f2dcd86a6a0c699c23fb9158d
Type: fix
Fixes:
d84661c
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Dave Barach [Fri, 21 Jun 2019 22:24:07 +0000 (18:24 -0400)]
vlib: packet tracer support for pkt thread handoffs
Type: feature
Change-Id: Ia3d9a47679202c2a47cd3746b50e86c6b8627ef6
Signed-off-by: Dave Barach <dave@barachs.net>
Paul Vinciguerra [Mon, 24 Jun 2019 13:55:46 +0000 (09:55 -0400)]
api: implement ipfix_flush
-Migrate tests to api and cleanup:
'# FIXME this should be an API call' in tests.
Type: feature
Change-Id: I715f9f8acc0f2af9c974ea221b2aea46692a6218
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Thu, 20 Jun 2019 16:24:12 +0000 (12:24 -0400)]
tests: refactor VppDiedError.
- Move Exception into same module as TestCase.
- Move the error reporting logic inside the error.
- Allows testing of the returncode and signal_name for tests to consume.
- Fix the signal reporting code:
VppDiedError: VPP subprocess died unexpectedly with returncode -6 [unknown].
displays as:
VppDiedError: VPP subprocess died unexpectedly with return code: -6 [SIGABRT].
Type: test
Change-Id: I8488ab318a596c9b737308829cedfb7e96e57302
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Steven Luong [Thu, 20 Jun 2019 18:43:22 +0000 (11:43 -0700)]
lacp: convert clib_warning to event logger
Replace clib_warning with event logger. The messages for the latter are
stored in the event buffers which can be viewed with debug CLI anytime.
Type: fix
Change-Id: I5ede4d1f1f9f0ab8d66394f49383fc1838d397ae
Signed-off-by: Steven Luong <sluong@cisco.com>
Neale Ranns [Fri, 21 Jun 2019 15:03:30 +0000 (08:03 -0700)]
misc: update maintainers to include VOM
Type: feature
Change-Id: I324127934f1a129c23f232940b991fd1455891c8
Signed-off-by: Neale Ranns <nranns@cisco.com>
Lijian.Zhang [Wed, 29 May 2019 09:08:47 +0000 (17:08 +0800)]
vppinfra: add u64x2_gather/u32x4_gather
Add u64x2_gather/u32x4_gather in vector_neon.h. u64x2_gather/u32x4_gather
gathers data from scattered memory locations to a SIMD register.
Type: feature
Change-Id: I1dd27e38af28b9bed85143014c86197ee549fede
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Sirshak Das <Sirshak.Das@arm.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Florin Coras [Thu, 20 Jun 2019 19:18:31 +0000 (12:18 -0700)]
tcp: add option to pass opaque to next node
Type:feature
Change-Id: I0b72954a6ae6a05abe0761cb4f227072863f127b
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ole Troan [Thu, 20 Jun 2019 12:06:07 +0000 (14:06 +0200)]
vppapigen: allow negative number in NUM token
Change-Id: I964cb44f8604187390009dcef7dd766b3804c3ca
Type: make
Signed-off-by: Ole Troan <ot@cisco.com>
Andrew Yourtchenko [Wed, 19 Jun 2019 12:09:51 +0000 (12:09 +0000)]
interface: fix the incorrect sizes/offsets in the tso segmentation
The copying of the first segment copied too small amount of data.
The copying of the second and subsequent segments used the wrong
data offset - for the case of GSO enabled it starts from 12 bytes
earlier.
Change-Id: I3adc532c175babc1ca1e121c7e12e6cafbdb9974
Type: fix
Ticket: VPP-1700
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Dave Barach [Tue, 18 Jun 2019 17:57:26 +0000 (10:57 -0700)]
ipsec: add ipsec api custom-dump routines
Type: feature
Change-Id: I637ca85bb0c5c3e9704e242747b1174bfcd74e02
Signed-off-by: Dave Barach <dave@barachs.net>
Nathan Skrzypczak [Wed, 19 Jun 2019 12:47:41 +0000 (14:47 +0200)]
quic: remove session flags identifying Q/S sessions
Type: refactor
Change-Id: Id68c5ae6d57df0fc556bbf583a66e538e641ffb1
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Ole Troan [Thu, 20 Jun 2019 09:53:33 +0000 (11:53 +0200)]
vat: vec_free/errmsh copy paste error
Change-Id: I808ae95666b82f04979b57cfe237a8f83bb68264
Type: fix
Fixes:
283cd2e9af
Signed-off-by: Ole Troan <ot@cisco.com>
Paul Vinciguerra [Thu, 20 Jun 2019 01:21:13 +0000 (21:21 -0400)]
tests: move output from CI results and put in log
NAT session details are output to the test results.
Twice NAT44 OK
Acquire twice NAT44 addresses from interface OK
21:10:42,661 NAT44 sessions:
-------- thread 0 vpp_main: 1 sessions --------
172.16.1.2: 0 dynamic translations, 1 static translations
i2o 172.16.1.2 proto tcp port 8080 fib 0
o2i 10.0.0.3 proto tcp port 80 fib 0
external host o2i 172.16.2.2:4567 i2o 10.0.1.3:42296
index 1869
last heard 97.99
total pkts 2, total bytes 80
static translation
load-balancing
twice-nat
Twice NAT44 local service load balancing OK
NAT44 translate packet with unknown protocol OK
Type: test
Change-Id: I932a4a1133d597bb82da6e04f2ea833094a481da
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Thu, 20 Jun 2019 02:19:02 +0000 (22:19 -0400)]
misc: papi - add __repr__ to FuncWrapper
Eases troubleshooting.
Changes:
<FuncWrapper object at 0x7fa7402de790>
to
<FuncWrapper(func=<want_ip6_ra_events(u16 _vl_msg_id, u32 client_index, u32 context, u8 enable_disable, u32 pid)>)>
Type: refactor
Change-Id: I3a893090e024a63a0b3b0de51cb3bb2d2a1678c5
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Tue, 18 Jun 2019 14:27:32 +0000 (10:27 -0400)]
api: fix return code in vxlan_gbp_tunnel_add_del
Return VNET_API_ERROR_INVALID_VALUE intead of 1.
Type: fix
Change-Id: Ie5465cad9ca07b9147306a808e8b13d0c4867913
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Mohsin Kazmi [Wed, 19 Jun 2019 18:25:37 +0000 (20:25 +0200)]
tap: fix the total length of packet for stats byte
Type: fix
Fixes:
8389fb9
Change-Id: I31076db78507736631609146d4cca28597aca704
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Mohsin Kazmi [Mon, 10 Jun 2019 09:20:15 +0000 (11:20 +0200)]
tap: add support to configure tap interface host MTU size
This patch adds support to configure host mtu size using
api, cli or startup.conf.
Type: feature
Change-Id: I8ab087d82dbe7dedc498825c1a3ea3fcb2cce030
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Paul Vinciguerra [Wed, 19 Jun 2019 02:59:55 +0000 (22:59 -0400)]
tests: add sudo to gdb commands
Prepend sudo to the gdb command line.
Type: test
Change-Id: I09013c3ca512e26de0c46c02f643b21064ba499c
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Klement Sekera [Tue, 4 Jun 2019 19:14:26 +0000 (21:14 +0200)]
buffers: fix crash
this change is being made to fix a crash when current_data < 0 in buffer
linearization function
Ticket: N/A
Type: fix
Fixes:
f883f6a1132ad4bb7aa9d9a79d420274fbcf3b64
Change-Id: Ia4ede823f673780e0c30d075b091db42e183650d
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Florin Coras [Wed, 19 Jun 2019 23:45:09 +0000 (16:45 -0700)]
vppinfra: fix rbtree node delete
Type:fix
Make sure tnil color is black and that the right node colors are
updated.
Change-Id: Ibd9d7ea9438df4dab977202955957824723a865d
Signed-off-by: Florin Coras <fcoras@cisco.com>
Mohsin Kazmi [Wed, 12 Jun 2019 11:59:00 +0000 (13:59 +0200)]
gbp: Add support for arp unicast forward in gbp bridge domain
Type: feature
Change-Id: Id487fe46194d0a89bd5ac53a9f4ff78b5ff6de60
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Neale Ranns [Wed, 19 Jun 2019 14:07:13 +0000 (07:07 -0700)]
l2: BD ARP termination entry API update
Type: refactor
Change-Id: I492b6e88acadf0ab0e4d7b1c0c5d1cab84c1726f
Signed-off-by: Neale Ranns <nranns@cisco.com>
Paul Vinciguerra [Tue, 18 Jun 2019 03:07:13 +0000 (23:07 -0400)]
api: fix typos in api error descriptions
Type: style
Change-Id: I81c281c7277dbaea499f3072e01e7f59bf646825
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Klement Sekera [Wed, 19 Jun 2019 11:26:34 +0000 (11:26 +0000)]
ipsec: fix l2 header handling in ah encrypt
Use proper length for copying l2 layer in ah encrypt code. Previously
code assumed that there is alywas just one ethernet header preceding IP
header, which might not be true always.
Change-Id: I176fd93b25cf1b9d9c2dc4e420ad48a94d5f4fb8
Ticket: VPP-1539
Type: fix
Fixes: N/A
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Mohsin Kazmi [Tue, 18 Jun 2019 21:45:54 +0000 (23:45 +0200)]
interface: Fix the tso segmentation
ASSERT (b[0]->current_length > 0) fails in single loop of
function vnet_interface_output_node_inline_gso.
Under 'do_segmentation' condition, there are two places in code
which execute "continue" in while-loop without incrementing the
pointer to next buffer which is wrong behavior. In fact, at one
place, current buffer is also freed. In which case, during next
iteration buffer ptr still points to free buffer which current
length is 0 and triggers the above assert.
Type: fix
Change-Id: Ic9d540748c1d00a54e18acc2b0f23730728d7460
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Steven Luong [Wed, 19 Jun 2019 02:34:43 +0000 (19:34 -0700)]
misc: add bonding, lacp and vmxnet3 to MAINTAINERS
Type: make
Change-Id: I8a28707a14ca6bcaf44b2a26dfc30ef2f2dbe749
Signed-off-by: Steven Luong <sluong@cisco.com>
Paul Vinciguerra [Tue, 18 Jun 2019 15:05:38 +0000 (11:05 -0400)]
tests: send packet output to log - test_punt.py
Move output to log.txt.
11:51:58,111 Verifying against 3 packets in verify_udp_pkts.
11:51:58,111 ###[ Ethernet ]###
dst = 02:fe:4c:62:06:e5
src = 02:01:00:00:ff:02
type = 0x800
\###[ IP ]###
version = 4
ihl = 5
tos = 0x0
len = 128
...
Type: test
Change-Id: Iebaf34c2ac16e7fa8dffbdeadf18ab6c5f4c7494
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Benoît Ganne [Mon, 17 Jun 2019 12:42:47 +0000 (14:42 +0200)]
mpls: fix header offset overflow
rw_len (MPLS rewrite string length) is declared as unsigned but is used
as -rw_len with vlib_buffer_advance(), resulting in a wrong, huge
offset.
Type: fix
Fixes:
734d430f37251bc7e71d507983ee640ae1625fbe
Ticket: VPP-1705
Change-Id: I7357249f7e50b7d30fd61f5be4858a26e43df85d
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Vladimir Kropylev [Mon, 17 Jun 2019 18:38:00 +0000 (21:38 +0300)]
session: call session_dequeue_notify after svm_fifo_dequeue_drop
Type: fix
dequeue_notify callback at app-layer needs to know available space in fifo,
so, session_dequeue_notify should be called after svm_fifo_dequeue_drop
Change-Id: I136675d29ec32bea9b33a05deb6710f72ce8d5b1
Signed-off-by: Vladimir Kropylev <vladimir.kropylev@enea.com>
Steven Luong [Tue, 18 Jun 2019 16:56:07 +0000 (09:56 -0700)]
tests: fix checkstyle failure in test_stats_client.py
New job submitted to Jenkins reported checkstyle failure in
test_stats_client.py. It needs a blank line in one place and line is
too long in another place.
Type: fix
Change-Id: I9b18df1df449a287570d614d6c5b514ceb88480c
Signed-off-by: Steven Luong <sluong@cisco.com>
Florin Coras [Tue, 18 Jun 2019 15:55:14 +0000 (08:55 -0700)]
tcp: allow custom output next node
Type: feature
Change-Id: If9804d3685d2a52efa06e412ae1ebb39c6a44b8b
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Tue, 18 Jun 2019 17:57:26 +0000 (10:57 -0700)]
ipsec: fix ipv6 tunnel protect tests
Type: fix
Change-Id: I1f8007ae659097152046aa1396cc23f126e29018
Signed-off-by: Florin Coras <fcoras@cisco.com>
Paul Vinciguerra [Tue, 18 Jun 2019 11:57:53 +0000 (07:57 -0400)]
build: update MAINTAINERS
Type: make
Change-Id: If82324f27163ab4ea270aac909c48a95dd1621ec
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>