Damjan Marion [Tue, 24 Mar 2020 12:51:13 +0000 (13:51 +0100)]
avf: proper promisc handling
Type: fix
Change-Id: Id20a0fe77372602fd211156ccee01c18d829d8df
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Wed, 11 Mar 2020 18:30:48 +0000 (18:30 +0000)]
tcp: add lost and in flight to byte tracker
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I3b0041d72d835cbb11e803cc56ac4c68a68238a0
Vratko Polak [Mon, 23 Mar 2020 12:01:54 +0000 (13:01 +0100)]
ikev2: fix typo in .api description
Type: style
Change-Id: Ie81eb7e3d872923daaa8ae8dad060a4da85349c5
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Florin Coras [Mon, 23 Mar 2020 18:13:32 +0000 (18:13 +0000)]
ipsec: Revert "ipsec: fix chained ESP"
This reverts commit
c2c1bfd9b72aec88526c06479b128725eb525866.
Reason for revert: Seems it's breaking ipsec esp tests
Type: fix
Change-Id: Iac590eee23cbf92a10c62dafa789aa9c3b2284dd
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Barach [Fri, 20 Mar 2020 12:06:04 +0000 (08:06 -0400)]
docs: add container functional test writeup
Fix global copyright date
Type: docs
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I7f010d63ec010982f2c8c8388f14214fa6ced0a7
Tetsuya Murakami [Sun, 22 Mar 2020 20:19:43 +0000 (13:19 -0700)]
srv6-mobile: Fix the coverity issues
Fix for the coverity issues.
Type: fix
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I6bf8a874a9a94b9b7d62da047a401eda8a448567
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Jakub Grajciar [Wed, 4 Mar 2020 12:08:27 +0000 (13:08 +0100)]
sr: srv6 API cleanup
Use consistent API types.
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I3c348ad2fca8bb3d9a246af7a2aa9dc9c33f57c3
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Filip Tehlar [Thu, 13 Feb 2020 07:49:30 +0000 (07:49 +0000)]
ipsec: fix chained ESP
This fixes a special case when buffer chain enters decrypt node
and becomes a single buffer after decryption.
Type: fix
Change-Id: I1d4da029b952baa97400adb7173aa63fd97d916b
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Alexander Chernavin [Fri, 20 Mar 2020 14:36:43 +0000 (10:36 -0400)]
ipsec: increment no-tunnel counter in ipsec-tun-input
If "no-tunnel" error erises, you will not see it in the "show errors"
output because the packet will be punted. That fact complicates
troubleshooting.
Type: improvement
Change-Id: Ic08347f81131a4a73a05b66acbfb02797373f5ab
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Steven Luong [Tue, 17 Mar 2020 16:01:30 +0000 (09:01 -0700)]
virtio: vhost gso checksum error when both indirect and mrg_rxbuf are off
Turn on gso, turn off both indirect and mrg_rxbuf caused traffic received
and sent with checksum error. The problem is we are not mapping the hdr
correctly in the shared memory address.
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I7ef3bc2755544167b0e624365988111b17399e89
Mohsin Kazmi [Wed, 18 Mar 2020 12:17:00 +0000 (13:17 +0100)]
tap: fix the numa/queue for buffers
Type: fix
Change-Id: Ib320171708bebde6d1dae0b2c665f9bcfc9102db
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Mohsin Kazmi [Thu, 5 Mar 2020 12:22:41 +0000 (12:22 +0000)]
virtio: improve error handling
Type: improvement
Change-Id: I134465760272ceb29f85486cba838d8687696bbf
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
John DeNisco [Fri, 20 Mar 2020 14:03:47 +0000 (10:03 -0400)]
docs: Fix build on fresh ubuntu 18.04
Type: docs
Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: If842c92183a9cf4b5a9773dced3298005b327e1a
Lijian.Zhang [Thu, 19 Mar 2020 02:22:52 +0000 (10:22 +0800)]
dpdk: false link down issue with ixgbe NIC
This issue is observed with X520-2 NICs on FD.io lab Taishan server.
After VPP booting up and bringing up the interfaces with command "set
interface state <interface> up", it still shows link down status from
the command "show hardware-interfaces". However, the hardware link
status is actually up. dpdk_process() cannot get the hardware link
status correctly via rte_eth_link_get_nowait().
In ixgbe_dev_link_update_share(), if the media type is fiber and the
link is down, a flag (IXGBE_FLAG_NEED_LINK_CONFIG) is set. A callback to
ixgbe_dev_setup_link_alarm_handler() is scheduled trying to set up the
link and clear the flag afterwards.
If the device is started or stopped before the flag is cleared, the
scheduled callback is canceled. This causes the flag to remain set and
subsequent calls to ixgbe_dev_link_update_share() return without trying
to retrieve the link state because the flag is set.
When the callback is canceled by either interface start or stop
operation, in ixgbe_dev_cancel_link_thread(), after cancelling the
callback/thread, unset the flag on the device to avoid this condition.
Type: fix
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Reviewed-by: Jieqiang Wang <Jieqiang.Wang@arm.com>
Change-Id: I04de377dc048307a78a5b7109ebdfaf376d5e029
Dave Barach [Sat, 21 Mar 2020 15:15:48 +0000 (11:15 -0400)]
vppinfra: fix typo in dlmalloc.c
Fix libffi package name for Ubuntu 20.04
Type: fix
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Idc567717494b4c40c307f20a40d5e10cd26b0a46
Tetsuya Murakami [Sat, 21 Mar 2020 21:47:02 +0000 (14:47 -0700)]
srv6-mobile: Fix the localsid length issue on vnet/srv6
Fix the following issue.
1. The localsid length was not stored in sr localsid structure.
2. SRv6 mobile test cases were modified based on the new sr localsid CLI syntax.
Type: fix
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: Ieb7620c35439e90a599802a7e0dba61a39707349
Tetsuya Murakami [Thu, 5 Mar 2020 00:27:14 +0000 (16:27 -0800)]
srv6-mobile: Support GTP4/6.DT and User Plane message mapping
Support the following new features in srv6-mobile.
1. GTP4.DT
2. GTP6.DT
3. User Plane Message encoding based on draft-murakami-dmm-user-plane-message-encoding-01
4. Add SRv6 mobile test cases
Type: feature
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I890e5171bf03513d54b4830f01b9dc7f47fe7c48
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Rajesh Goel [Tue, 17 Mar 2020 09:13:09 +0000 (14:43 +0530)]
ipsec: efficient layout of ESP per thread data
Type: fix
Change-Id: I1ba921503a41ca37ce5c920682893617740571a9
Signed-off-by: Rajesh Goel <rajegoel@cisco.com>
Klement Sekera [Thu, 20 Feb 2020 11:39:58 +0000 (11:39 +0000)]
vppinfra: fix minor cuckoo bugs and add cuckoo_16_8
Type: improvement
Change-Id: If1164d2eb81e9d4748436cb1bb8b164857d70565
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Nick Zavaritsky [Thu, 5 Mar 2020 17:24:37 +0000 (17:24 +0000)]
gtpu: encap-vrf-id in show gtpu tunnels command
Show encap-vrf-id instead of fib-idx. When a tunnel is created, you
specify encap-vrf-id, hence it makes sense for the show command to
present it the same way. Fib index, on the other hand, is the internal
artifact of how IP tables are managed; showing it isn't helpful.
Type: improvement
Change-Id: I8d1713d6727dd8685d6c10c07f421c18edafa6e0
Signed-off-by: Nick Zavaritsky <nick.zavaritsky@emnify.com>
Jan Cavojsky [Tue, 3 Mar 2020 15:25:58 +0000 (16:25 +0100)]
libmemif: don't consume rx queue interrupt, if memif_rx_burst fails
Type: fix
Signed-off-by: Jan Cavojsky <jan.cavojsky@pantheon.tech>
Change-Id: Ic6c15c88c80c4045c290cd78533be6f070c7470a
Jieqiang Wang [Mon, 20 Jan 2020 05:43:38 +0000 (13:43 +0800)]
vlib: leave SIGPROF signal with its default handler
When profiling VPP with MAP (a software profile suite on Arm CPUs, see details in
https://www.arm.com/products/development-tools/server-and-hpc/forge/map) on Arm
servers, VPP will receive SIGPROF signal because MAP uses SIGPROF signal to drive
its sampler to do profiling on VPP. However, the default action of SIGPROF signal
handler in VPP such as unix_signal_handler() is process termination. To profile
VPP with MAP, the SIGPROF handler should be left as default, and MAP sampler will
overwrite it with its own implementation.
Type: feature
Change-Id: Ie14e513d35ec27a66e95067689408bad8ed1ad6b
Signed-off-by: Jieqiang Wang <jieqiang.wang@arm.com>
Vladimir Isaev [Tue, 17 Mar 2020 09:56:31 +0000 (12:56 +0300)]
vlib: allow using core 0 as a last resort
Right now even following configuration fails:
cpu {
corelist-workers 0
}
I think we should allow user to use CPU 0 if he explicitly
configured it or as the last automatically assigned core.
Type: improvement
Signed-off-by: Vladimir Isaev <visaev@netgate.com>
Change-Id: I041c30349bace558c673475e9a0cffccae5821f7
Vladimir Isaev [Tue, 17 Mar 2020 09:30:11 +0000 (12:30 +0300)]
vlib: complain if workers are configured twice
Right now following configuration leads to crash:
cpu {
corelist-workers 2
workers 2
}
because threads count will be set to 2, but we have only
one core in coremask.
Type: fix
Signed-off-by: Vladimir Isaev <visaev@netgate.com>
Change-Id: Ia93b892733971e7c8ddfceaaec5f4eb8bf9063ac
Filip Tehlar [Tue, 17 Mar 2020 15:26:06 +0000 (15:26 +0000)]
ikev2: fix l2 interface
Type: fix
Change-Id: Ic6457da31846721e334f144f15d404575eeb73e5
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Mohsin Kazmi [Thu, 19 Mar 2020 13:03:31 +0000 (14:03 +0100)]
virtio: fix link up/down flag
Type: fix
"set int state <interface> down" puts the virtio device link
down. It will not put the link in "UP" state, when
"set int state <interface up>" will be used again to change
the interface admin up. This patch fixes it.
To test:
create tap
set int state tap0 up
set int state tap0 down
sh hardware
sh int
set int state tap0 up
sh int
sh hardware
Change-Id: I3c0e31539f8a2a1e40220e7fb57eedecf408f067
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Filip Tehlar [Mon, 2 Mar 2020 15:17:37 +0000 (15:17 +0000)]
ikev2: add support for custom ipsec-over-udp port
Type: feature
Change-Id: Ifee2b3dca85ea915067b9285e3636802bf0c19a8
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Mohsin Kazmi [Thu, 27 Feb 2020 10:49:21 +0000 (11:49 +0100)]
virtio: fix the out of order descriptors in tx
Type: fix
Some vhost-backends give used descriptors back in
out-of-order. This patch fixes the native virtio to
handle out-of-order descriptors.
Change-Id: I57323303349f6a385e412ee22772ab979ae8edbf
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Jieqiang Wang [Mon, 13 Jan 2020 09:15:13 +0000 (17:15 +0800)]
vlib: fix error when creating avf interface on SMP system
On SMP architecture, '/sys/bus/pci/devices/<devices id>/numa_node' file
will return -1 as a valid value if it does not have any NUMA node information.
Using -1 as a valid node id to access data structures will cause memory issue.
Fix the error by setting the value of numa_node to 0 if '/sys/bus/pci/devices/
<devices id>/numa_node' returns -1 and it is a SMP system.
Type: fix
Change-Id: Ib60e79c3656fe5b17e08fd9011122683e8b08b6f
Signed-off-by: Jieqiang Wang <jieqiang.wang@arm.com>
Florin Coras [Fri, 20 Mar 2020 20:25:37 +0000 (20:25 +0000)]
tcp: avoid spurious retransmit attempt
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I6ce6fb0fe0ceb8a70b6a13e6a72fdb842bfded7a
Benoît Ganne [Thu, 19 Mar 2020 10:41:07 +0000 (11:41 +0100)]
rdma: ring db only once per vector on tx
Type: improvement
Change-Id: I09b017d60bc38ff8a4a7a73aff42b27611bd8955
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Andreas Schultz [Fri, 20 Mar 2020 08:39:59 +0000 (09:39 +0100)]
session: export session_alloc_for_connection
Type: refactor
Signed-off-by: Andreas Schultz <andreas.schultz@travelping.com>
Change-Id: I45c6f434065ab0ad8ada3184b5a875a32a1b3faa
Jawahar Santosh Gundapaneni [Thu, 19 Mar 2020 20:42:28 +0000 (16:42 -0400)]
ip: provide extern declaration for ip punt nodes
Type: fix
Signed-off-by: Jawahar Santosh Gundapaneni <jgundapa@cisco.com>
Change-Id: Ife0f7749a72cc834a3d811f8cf6b5a0840157014
Jakub Grajciar [Fri, 20 Mar 2020 12:48:50 +0000 (13:48 +0100)]
ip: ip API types coverity fix
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I6b2c7550ae5918c27b02b1173533d2042c6c15c7
Florin Coras [Tue, 17 Mar 2020 17:09:12 +0000 (17:09 +0000)]
tcp: move accept init to separate reusable function
Type: refactor
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I5120eb321e9e2050eb64dca9e2dfb6256ff2b62d
Florin Coras [Fri, 13 Mar 2020 20:39:43 +0000 (20:39 +0000)]
tcp: force deschedule if no send space available
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iae9f118f710153b6c0e390265039db7434e67ed8
Florin Coras [Fri, 13 Mar 2020 17:54:42 +0000 (17:54 +0000)]
session tcp udp: consolidate transport snd apis
Type: improvement
Use only one api to retrieve transport send parameters. Additionally,
allow transports to request postponing and descheduling of events.
With this, tcp now requests descheduling of sessions when the
connections are stuck probing for zero snd_wnd
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I722c974f3e68fa15424c519a1fffacda43af050c
Florin Coras [Thu, 12 Mar 2020 15:50:57 +0000 (15:50 +0000)]
tcp: count dupacks with no sacks
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia2e29b4776c0f8df666da39a14c5ef2fa1693c21
Jakub Grajciar [Thu, 19 Mar 2020 07:03:55 +0000 (08:03 +0100)]
ip: change ip API enums address_family and ip_proto size to u8
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I73d27520726543d6375caad76a841339f68c3533
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Neale Ranns [Tue, 17 Mar 2020 14:24:09 +0000 (14:24 +0000)]
fib: format functions for path
Type: improvement
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Ib7a9e457cb2462e6ce9e5e2af53d1f997f4ae6cf
Dave Barach [Wed, 18 Mar 2020 14:14:40 +0000 (10:14 -0400)]
build: add snap packaging (experimental)
Type: feature
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I5a5efde5378f63d89d82d71ae009c7595aaa800c
Jon Loeliger [Mon, 9 Mar 2020 18:13:35 +0000 (13:13 -0500)]
ethernet: Copy only 6 bytes of mac address into a u64
Rather than leaving 2 bytes of junk in the upper word
of a mac address represented as a u64, zero them out.
That way later compairsons stand a chance of matching
when deleting a bridge's arp termination entries.
The volatile qualifier shouldn't be needed here, but
without it the compiler removes the clib_memcpy() at -O2.
Bad compiler. No biscuit.
Type: fix
commit:
faf22cb303b65e2a6bf8dad959d7f5ee6d031c4f
Change-Id: Iebcf35fdd421293dccbcaefadef767f7e139438e
Signed-off-by: Jon Loeliger <jdl@netgate.com>
ShivaShankarK [Wed, 18 Mar 2020 10:04:11 +0000 (15:34 +0530)]
pg: update packet generator test scripts
update packet generator test scripts to reflect latest code changes
Type: fix
Signed-off-by: ShivaShankarK <shivaashankar1204@gmail.com>
Change-Id: I048a5e8b9b0506dcb0b664e5549d13f51b2e2ea6
Neale Ranns [Tue, 17 Mar 2020 14:25:10 +0000 (14:25 +0000)]
fib: Always install all routers mcast addresses
Type: improvement
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Ia8dff15855a81cf29729bdaa3ff28fbe3254fa97
Ryujiro Shibuya [Tue, 17 Mar 2020 02:04:28 +0000 (02:04 +0000)]
svm: fifo test
Type: feature
Adding a very simple test case just to confirm that setting fifo size
same as the current in-use size would result no space to enqueue, which
is zero-window in the TCP.
Signed-off-by: Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>
Change-Id: I6d60449386eaa270f801d2046cc7e546f843bf34
Neale Ranns [Mon, 24 Feb 2020 13:32:30 +0000 (13:32 +0000)]
ip: ip_address_t uses ip46_address_t
Type: improvement
type re-use.
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Ic2a2e6babf9ae66a1e53aec53a6cd157e1893dc8
Damjan Marion [Mon, 16 Mar 2020 16:53:38 +0000 (17:53 +0100)]
ipsec: initialize algs to none in 'create ipsec tunnel' cli
Type: fix
Change-Id: I901c9384710eee5847b3fbce060c78e115ba4169
Signed-off-by: Damjan Marion <damarion@cisco.com>
Jakub Grajciar [Mon, 2 Mar 2020 12:23:21 +0000 (13:23 +0100)]
api: API cleanup
Use consistent API types.
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ic108311e09c56cc2b3db63d5850598b6896a7897
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Neale Ranns [Mon, 16 Mar 2020 18:16:34 +0000 (18:16 +0000)]
arp: Restore CLI for setting ARP proxy entries
Type: fix
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I3a21afef86990c1198ffcc47ffe2dba8a97125ee
Damjan Marion [Mon, 16 Mar 2020 13:44:10 +0000 (14:44 +0100)]
rdma: optimize tx wqe_init
Type: improvement
Change-Id: I7f28a3f03ab1ea8461c52743c61dc23a57965237
Signed-off-by: Damjan Marion <damarion@cisco.com>
Benoît Ganne [Mon, 16 Dec 2019 09:42:25 +0000 (10:42 +0100)]
rdma: introduce direct verb for Cx4/5 tx
Direct Verb allows for direct access to NIC HW rx/tx rings. This patch
introduce TX direct verb support for Mellanox ConnectX-4/5 adapters.
'dv' mode must be explicitely selected at interface creation to benefit
from this.
Type: feature
Change-Id: If830ba9f33db73299acdbddc68b5c09eaf6add98
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Damjan Marion [Thu, 12 Mar 2020 10:56:00 +0000 (11:56 +0100)]
rdma: add Mellanox mlx5 Direct Verbs receive support
Type: feature
Change-Id: I3f287ab536a482c366ad7df47e1c04e640992ebc
Signed-off-by: Damjan Marion <damarion@cisco.com>
Ryujiro Shibuya [Fri, 13 Mar 2020 12:45:06 +0000 (12:45 +0000)]
svm: chunk alloc stats
Type: feature
Showing number of allocated chunks by size, in addition to the freelist chunks by size.
Signed-off-by: Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>
Change-Id: I50f7b695a217f132d5f0b307182a34752d3fe1dc
Simon Zhang [Fri, 13 Mar 2020 09:03:53 +0000 (17:03 +0800)]
tls: refactor Picotls ctx_read function to reduce one time memory copy
Type: refactor
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: I7a952fd95e49468a0d1c763b3e289648c93539da
Jakub Grajciar [Mon, 2 Mar 2020 12:55:31 +0000 (13:55 +0100)]
vxlan: vxlan/vxlan.api API cleanup
Use consistent API types.
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I7f6f37ec6eed780322e2488d6eb0f5681945ba09
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Alexander Chernavin [Thu, 12 Mar 2020 12:42:12 +0000 (08:42 -0400)]
map: fix translation of icmp4 error messages
ICMP error messages are translated to ICMPv6 error messages with
erroneous destination address in the outer IPv6 header because sender
port is used instead of receiver port.
Both source and destination addresses in the inner IPv6 header are
translated erroneously because source and destination addresses of the
inner IPv4 header are getting zeroed during the translation.
With this commit, use receiver port for translation and save addresses
of the inner IPv4 header before translation of the inner header.
Type: fix
Change-Id: I1e93d54c1bbc154b401adcbb0fb661299655d01a
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Klement Sekera [Thu, 12 Mar 2020 13:39:24 +0000 (14:39 +0100)]
nat: test cleanup
Type: improvement
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I5ec761bfcdc13a8238b83ff46c2f1c53ec0e79d8
Simon Zhang [Wed, 11 Mar 2020 19:37:55 +0000 (03:37 +0800)]
tls: small refactor for Picotls engine ctx_write function
Type: refactor
Change-Id: I761fc764e6771dc95eb64614479c27fd44016690
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Elias Rudberg [Fri, 13 Mar 2020 13:26:50 +0000 (14:26 +0100)]
nat: in2out/out2in handoff node index bugfix
This fixes a bug in the initialization of handoff_out2in_index and
handoff_in2out_index where the node index for out2in was set to the
in2out node, and vice versa.
Type: fix
Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
Change-Id: I983ddd3b3cec06f4cb3fb95b2a9cda4ab6d1270f
Florin Coras [Thu, 12 Mar 2020 23:26:11 +0000 (23:26 +0000)]
vlib: add verbose sh node option
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I915dace4afe07ac3281f248ef7468fa5247c9668
Pablo Camarillo [Thu, 12 Mar 2020 16:26:45 +0000 (16:26 +0000)]
sr: SRv6 coverity
Fixes 4 coverity issues
Type: fix
Signed-off-by: Pablo Camarillo <pcamaril@cisco.com>
Change-Id: Ib3ef1df3e5d601d7751445ae1c9603bb6ce0f80c
Dave Barach [Fri, 13 Mar 2020 12:32:28 +0000 (08:32 -0400)]
devices: netlink create the object if missing
Type: fix
Fixes:
b49bc1a
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I3dd81a2484c8b4925fd07556576c29d1cde337e1
Filip Varga [Tue, 25 Feb 2020 13:31:33 +0000 (14:31 +0100)]
nat: timed out session scavenging upgrade
Patch changes the behavior of session scavenging and fixes multiple
nat issues. Allows proper session clearing and removes issue with lingering sessions
in session db. Patch also updates and fixes CLI/API calls for better readability
of session state metrics. Fixes security issue that would allow attacker to
reuse timed out session in both directions (in2out/out2in).
Type: improvement
Signed-off-by: Filip Varga <fivarga@cisco.com>
Change-Id: I78897585a2a57291fad5db6d457941aa0a0457bd
Neale Ranns [Wed, 11 Mar 2020 14:57:54 +0000 (10:57 -0400)]
dpdk-ipsec: Fix for multipoint IPSEC
Type: fix
fetch the sa_index from the correct location
Change-Id: I351035ee0226c47585995ff9122320fd5c73ec53
Signed-off-by: Neale Ranns <nranns@cisco.com>
Klement Sekera [Thu, 12 Mar 2020 11:30:21 +0000 (12:30 +0100)]
tests: avoid unnecessary rebuilds
Improve dependency tracking on vapi_test directory so that vapi_c_test
rebuild doesn't force vapi_cpp_test rebuild and vice versa.
Type: improvement
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I00094c6374981333858ddbe6ae934cfda3b33a36
Benoît Ganne [Thu, 12 Mar 2020 10:55:09 +0000 (11:55 +0100)]
rdma: cleanup rdma-core build
Type: improvement
Change-Id: I298bbb81c753d60288ac63bebf2bdfea323af68b
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Florin Coras [Tue, 10 Mar 2020 04:46:32 +0000 (04:46 +0000)]
svm: cleanup chunk and fifo allocation
Type: refactor
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2426211f48b242e51aeb1edc87c1cd21c526dbfa
Dave Barach [Wed, 11 Mar 2020 14:31:36 +0000 (10:31 -0400)]
vppinfra: refactor clib_timebase_t
Add a clib_time_t * argument to clib_timebase_init(...), to encourage
client code to share the vlib_main_t's clib_time_t object.
Display the current day / date in GMT via the "show time" debug CLI.
Fix the test framework so it processes the new "show time" output format.
Type: refactor
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I5e52d57eb164b7cdb6355362d520df6928491711
Dave Barach [Thu, 12 Mar 2020 18:43:04 +0000 (14:43 -0400)]
vppinfra: remove time jump workaround
A partial revert of gerrit 25729. The last_run_time == 0.0 check is
necessary and remains in place.
Type: fix
Fixes:
3d9f134
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I3d2c9f90b2bc867f02c4749a5b19f997b84185b9
Chenmin Sun [Fri, 6 Mar 2020 15:09:32 +0000 (23:09 +0800)]
dpdk: tx/rx burst function description refactor
DPDK provides two new APIs to retrieve information about the Tx/Rx
packet burst mode:
rte_eth_tx_burst_mode_get
rte_eth_rx_burst_mode_get
This patch leverages these two APIs to describe the tx/rx mode.
Currently, Intel X710/E810 and Mellanox Mlx5 support the new APIs.
For NICs that don't support the new APIs, still use the original way
to print their tx/rx function name
Type: refactor
Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: Ibe47f5debe3b3f17f462fbf9834394e22845cc08
Matthew Smith [Thu, 12 Mar 2020 15:29:31 +0000 (10:29 -0500)]
vrrp: unit tests do not run by default
Type: fix
Fixes:
39e9428b90
VRRP unit tests fail sometimes for changes which have not touched any
code related to VRRP. There were some timing-related changes recently
which probably made the VRRP tests, which rely on a VR changing state
within a certain amount of time, start failing.
Set the VRRP tests to only run with the extended tests rather than
running by default. This is temporary so VRRP will not cause spurious
build failures while a proper solution is figured out.
Change-Id: I5826ea39b944dfb9b0ca4bdfa2ebbe86d269f935
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Fan Zhang [Thu, 12 Mar 2020 09:26:38 +0000 (09:26 +0000)]
vlib: fix unix cli SIGSEGV for empty line input
When logging is enabled, an empty line input (press Enter only)
will cause SIGSEGV. This patch fixes the problem by checking
the command length first.
Type: fix
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: Ib4cbd1c7bfd6a694e289d28958875c7d2356a93e
Jakub Grajciar [Mon, 2 Mar 2020 12:16:53 +0000 (13:16 +0100)]
policer: API cleanup
Use consistent API types.
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ia14f33992353b419b70b55beed63ab8ed6a2e837
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Filip Tehlar [Sat, 7 Mar 2020 20:55:59 +0000 (20:55 +0000)]
ikev2: fix udp encap
Type: fix
Change-Id: I2c89accddf2307fa975b71e974d4091499f104ed
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Pablo Camarillo [Wed, 18 Dec 2019 17:13:13 +0000 (17:13 +0000)]
sr: SRv6 uN behavior
Implements the uN behavior
Type: feature
Change-Id: Icb5efc560e09052cd183b468772cf7f799f81194
Signed-off-by: pcamaril <pcamaril@cisco.com>
Filip Varga [Wed, 11 Mar 2020 11:49:46 +0000 (12:49 +0100)]
nat: dslite plugin separation
Type: refactor
Signed-off-by: Filip Varga <fivarga@cisco.com>
Change-Id: I81546423200cc7f8a06b527dac8ead191a9e0519
John DeNisco [Wed, 11 Mar 2020 13:47:21 +0000 (09:47 -0400)]
docs: Add feature build to publish script
Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: I6a938f426b9a8e1242fa5c6f9716a3f9db4d4976
Dave Barach [Wed, 11 Mar 2020 13:00:47 +0000 (09:00 -0400)]
docs: describe clib_time monotonic timebase support
Type: docs
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I5b27d8b945472388498a4afc4be8dd868bb45ac3
Florin Coras [Tue, 10 Mar 2020 23:19:53 +0000 (23:19 +0000)]
vppinfra: minimize tw verbosity on timebase jump
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I5db3457a9fed11d6ecf6eaabcdf8f1d1177b2a9f
Paul Vinciguerra [Sun, 1 Mar 2020 05:47:17 +0000 (00:47 -0500)]
vlib: unix cli - log cli commands one per line
This changeset modifies the log output so that cli commands now look like:
cat /tmp/vpp-cli.log
2020/03/10 19:24:42:186: ***** Start: PID 29570 *****
/* [0] is stdin */
2020/03/10 19:24:53:518[0]: show clock
2020/03/10 19:24:56:078[0]: show clock
2020/03/10 19:25:01:983[0]: show pci
/* [1] is vppctl socket */
2020/03/10 19:26:14:372[1]: show ver
2020/03/10 19:26:23:395[1]: show hardware-interfaces
2020/03/10 19:26:28:507[1]: q
instead of:
cat /tmp/vpp-cli.log
2020/03/01 00:40:12:834: ***** Start: PID 29974 *****
2020/03/01 00:40:24:969[0]: show interface2020/03/01 00:40:31:945[0]: show clo2020/03/01 00:40:41:288[0]: show classify 2020/03/01 00:40:43:753[0]: show classify ?2020/03/01 00:40:53:392[0]: show classify tables2020/03/01 00:40:57:352[0]: quit
Type: improvement
Change-Id: I38d85535977296d174db7121ae340850b6476a39
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Dave Barach [Tue, 10 Mar 2020 20:59:39 +0000 (16:59 -0400)]
tests: add running_gcov_tests to framework.py
Mark a few code coverage tests appropriately:
@unittest.skipUnless(running_gcov_tests, "part of code coverage tests")
def test_my_coverage_unittest(self):
<etc>
Almost exactly like "make EXTENDED_TESTS=yes test".
Type: feature
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ic6d0a097a608ba93442b3d88252f66f8e6805b97
Florin Coras [Tue, 10 Mar 2020 19:34:28 +0000 (19:34 +0000)]
tcp: protect against forced cleanups
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I0c3b847044d522f55dfd8262afa7c161d5bd5dd3
Dave Barach [Tue, 10 Mar 2020 13:01:02 +0000 (09:01 -0400)]
vppinfra: improve timebase resilience
Deal with arbitrary kernel reference time changes: for example,
yanking the kernel reference clock back to a time before vpp started.
Best practice involves aligning the kernel reference clock with
reality prior to starting apps which use 10us granularity timers.
Compute change in the reference and cpu clocks. Recompute the vpp
start time reference and and total cpu clock count, using the current
clock tick rate.
Next, compute a new clock rate sample. If the sample seems sane,
factor it into the exponentially smoothed clock rate and recalculate
total cpu ticks based on the new clock rate.
Type: fix
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ib6132ffbbe0e6d140725676de5e35be112a31dfe
Paul Vinciguerra [Sun, 1 Mar 2020 06:42:28 +0000 (01:42 -0500)]
docs: doxygen fix siphon under python3
siphon used cgi.escape which was deprecated in python 3.2 and
removed in python 3.8.
Update the code to use html.escape instead.
Type: fix
Change-Id: I3192e3f69a4a95fe23cb24e1c29194ba5310932b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Jieqiang Wang [Wed, 12 Feb 2020 12:13:34 +0000 (12:13 +0000)]
build: add libssl-dev for ubuntu 16.04 and 18.04
The recent changes to Makefile lead to the lack of libssl-dev
dependency for ubuntu 16.04 and 18.04. Add libssl-dev to DEB_DEPENDS
variable for corresponding ubuntu version.
Type: fix
Change-Id: I42e0e4761d5ec377de71b11cccf747c7f55ca337
Signed-off-by: Jieqiang Wang <jieqiang.wang@arm.com>
Dave Barach [Tue, 10 Mar 2020 11:13:20 +0000 (07:13 -0400)]
lb: fix coverity warning
Type: fix
Ticket: VPP-1837
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I357eb72d478d8175ab9c7cf502d312ab3112213e
IJsbrand Wijnands [Thu, 5 Mar 2020 18:56:26 +0000 (10:56 -0800)]
mpls: add user defined name tag to mpls tunnels
This allows a user creating MPLS tunnel through the bin_api to add a name tag. This is useful
to correlate the Tunnel with its use-case. Also useful if the user needs to recover the MPLS
Tunnel after a restart (mark-sweep).
Type: feature
Change-Id:
Signed-off-by: IJsbrand Wijnands <ice@cisco.com>
Change-Id: Idc080a63810a176ab090a2678a73d2cf9f7b523f
Jakub Grajciar [Fri, 28 Feb 2020 07:26:32 +0000 (08:26 +0100)]
ipsec: API cleanup
Use consistent API types.
Change vl_api_ipsec_proto_t to iana values:
ESP 50,
AH 51,
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I2becefb343246e0233f290fefbfdd172d8237325
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Florin Coras [Fri, 6 Mar 2020 02:23:58 +0000 (02:23 +0000)]
svm: track fifo segment virtual memory consumption
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I89d33d8e7e7ab049750439b22ba50372fd2261ca
Dave Barach [Sun, 8 Mar 2020 12:27:19 +0000 (08:27 -0400)]
vppinfra: fix corner cases in tw_timer_expire
Type: fix
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I4b3ff6e9c8e1d76037b168aeab36dcb5b4482260
Vratko Polak [Mon, 9 Mar 2020 17:30:02 +0000 (18:30 +0100)]
ip-neighbor: add description to the age parameter
Type: docs
Change-Id: I311301328fb5e47ba1c3caaff18431738bbd1233
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Andreas Schultz [Mon, 9 Mar 2020 10:36:15 +0000 (11:36 +0100)]
udp: fix UDP socket byte order in lookup
The port registry uses host byte order for while the session API
uses network order. In a single place the conversion was missing.
Type: fix
Signed-off-by: Andreas Schultz <andreas.schultz@travelping.com>
Change-Id: Ic8cfe2cb4e0711b3e0614060ff6b4f2fe4ed4391
Jakub Grajciar [Thu, 24 Oct 2019 11:52:42 +0000 (13:52 +0200)]
l2: API cleanup
Use consistent API types.
Type: fix
Change-Id: I7ac7cd00606101864fa3422e7b9ea2f1143665dd
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Paul Vinciguerra [Fri, 1 Nov 2019 02:34:30 +0000 (22:34 -0400)]
docs: Add list of nodes for 'trace add'
(provided by Andrew/Damjan: git grep -h -B20 VLIB_NODE_FLAG_TRACE_SUPPORTED | grep VLIB_REGISTER_NODE | awk -F [\(\),] '{print $2 }' | sed 's/_/-/g' | sort |sed 's/-node//' )
Type: docs
Change-Id: I4a58fe5ed6bb3598551482ea1c5f16e502cbd6a7
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Damjan Marion [Wed, 4 Mar 2020 19:06:06 +0000 (20:06 +0100)]
vppinfra: fix 32-bit overflow in os_cpu_clock_frequency
Type: fix
Change-Id: I23250fcbc70086584b5448baec9af9a1528992f5
Signed-off-by: Damjan Marion <damarion@cisco.com>
Signed-off-by: Dave Barach <dave@barachs.net>
Florin Coras [Sat, 7 Mar 2020 17:45:47 +0000 (17:45 +0000)]
vcl: fix coverity warning
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I35fba8f17bdd6e2f5612358608ff6c13f4b431fe
Simon Zhang [Thu, 5 Mar 2020 11:49:37 +0000 (19:49 +0800)]
tls: refactor ctx_write function to avoid allocate new memory every time
Type: refactor
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: Ic34729d58a4218046afacaffc765649beb056a24
Renato Botelho do Couto [Fri, 6 Mar 2020 19:42:22 +0000 (13:42 -0600)]
misc: Fix vpp-selinux-policy dependency on CentOS 8
policycoreutils-python is now called python3-policycoreutils on
CentOS 8.
Type: fix
Signed-off-by: Renato Botelho do Couto <renato@netgate.com>
Change-Id: I46264c66a2a719d546e0926f3bd716e986461963
Vladimir Ratnikov [Fri, 28 Feb 2020 13:48:21 +0000 (08:48 -0500)]
ip-neighbor: populate neighbor age via API
When we get ip-neigbor information using VPP API,
it's age can be very useful information.
This patch adds age entry to API and neighbor type
Type: feature
Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
Change-Id: I822e70ba7a2bdd85fec40930cfc9341ab71f7cb3
Florin Coras [Fri, 6 Mar 2020 02:25:09 +0000 (02:25 +0000)]
session: fix session reschedule condition
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I01441e958517e31260e67c8caea5f75d684b2711