Chris Luke [Sat, 10 Sep 2016 00:16:04 +0000 (20:16 -0400)]
Check for zero-sized Graphvix config file on Ubuntu; VPP-396
- The previous change only accounted for a missing Graphviz config
file; apparently it can be zero-sized too.
Change-Id: Ic6957d10cdc7cb7b9da72d2b2a0f8913100870c5
Signed-off-by: Chris Luke <chrisy@flirble.org>
Chris Luke [Fri, 9 Sep 2016 21:51:42 +0000 (17:51 -0400)]
On Ubuntu check for graphviz system config
- Sometimes it seems Ubuntu doesn't always set up the Graphviz
handler config. If it's missing, generate it.
Change-Id: I2c1e566817de8415f8b360c6f967cd76307a2a52
Signed-off-by: Chris Luke <chrisy@flirble.org>
Juraj Sloboda [Tue, 6 Sep 2016 11:43:52 +0000 (04:43 -0700)]
Fix bugs in IPFIX code discovered by coverity
Change-Id: Ibe6ccb99c3c29c14efb34191f209a2f6a14293f7
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
Vengada Govindan [Thu, 8 Sep 2016 05:19:36 +0000 (22:19 -0700)]
Fix Coverity issue in trace_util.c (REVERSE_INULL), thanks to Damjan for highlighting this.
Change-Id: I22b1dc800624042e043e7632179f6281a6ccaafc
Signed-off-by: Vengada Govindan <venggovi@cisco.com>
Chris Luke [Wed, 7 Sep 2016 17:28:59 +0000 (13:28 -0400)]
VPP-346 Improve Doxygen include path mechanism
- If present, include the directories where API header files
are generated into.
- Improve extraction of include paths from CPP
- Generalize the file/directory exclusion
This reduces some of the "warning" chatter from Doxygen.
Change-Id: I7ac02bff1639fe63f11263176020b0f040255017
Signed-off-by: Chris Luke <chrisy@flirble.org>
Florin Coras [Tue, 6 Sep 2016 13:18:21 +0000 (15:18 +0200)]
VPP-388 Improve IP header lookup in ipsec_output
Change-Id: I5df0067c9ce56d7a15a991b82d4761924d91758b
Signed-off-by: Florin Coras <fcoras@cisco.com>
Steve Shin [Wed, 7 Sep 2016 15:25:04 +0000 (08:25 -0700)]
Fix MTU size for the bonded interface
Configure the MTU/L3 packet size of the bonded interface
as the lowest value of the slave intefaces
Change-Id: I34fb4c2156e8ad3d9bf45efe332405d53f72867c
Signed-off-by: Steve Shin <jonshin@cisco.com>
Ed Warnicke [Wed, 7 Sep 2016 17:12:52 +0000 (17:12 +0000)]
VPP-390: include *.so symlinks in vpp-lib
Currently, vpp-lib rpm includes symlinks for
*.so.0 -> *.so.0.0.0
but not
*.so -> *.so.0.0.0
This causes linker issues in cases where vpp-lib and vpp-devel rpms
are installed and sources are built that rely on libraries in vpp-lib.
Example:
libtool: link: gcc -shared -fPIC -DPIC jvpp/.libs/libjvpp_nsh_la-jvpp_nsh.o -lvlibmemoryclient -lvlibapi -lsvm -lvppinfra -lpthread -lm -lrt -ljvpp_common -L/usr/lib64 -O2 -Wl,-soname -Wl,libjvpp_nsh.so.0 -o .libs/libjvpp_nsh.so.0.0.0
/usr/bin/ld: cannot find -lvlibmemoryclient
/usr/bin/ld: cannot find -lvlibapi
/usr/bin/ld: cannot find -lsvm
/usr/bin/ld: cannot find -lvppinfra
collect2: error: ld returned 1 exit status
Change-Id: Ic8eebc696f973ea348be0b43e7cfb289efbe44fe
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Matus Fabian [Wed, 7 Sep 2016 06:19:43 +0000 (23:19 -0700)]
VPP-382: Add ipsec tunnel interface to sw_interface_dump
Change-Id: I9e49c9b6deedb750269da04e3332a3b0742d382c
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Matus Fabian [Wed, 7 Sep 2016 12:57:09 +0000 (05:57 -0700)]
VPP-387: Fixed ipsec-input trace
Change-Id: I0a687c5d5f745a6c82a58c8e20b987180704a685
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Pierre Pfister [Wed, 27 Jul 2016 15:38:20 +0000 (16:38 +0100)]
Vhost-User: Implement Indirect Descriptors
One of the main issue with virtio is the small queue size.
VPP can quickly fill the queue before Linux could empty it,
resulting in packet losses.
Virtio indirect descriptors double the number of packet
which may fit in the virtio queue (From 128 to 256 with standard qemu
which hardcodes queue size to 256).
Linux will not use such descriptors if the virtio MRG feature is
enabled. You may add mrg_rxbuff=off option to qemu commandline
when starting the VM such as to disable this feature. This way,
Linux will use indirect buffers to receive packets.
But it seems that Linux never uses indirect buffers to send packets.
This patch also includes some optimization modifications.
Change-Id: I26940d41ce6b7e3a08d5516018a8c46c5316ce1c
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
Damjan Marion [Wed, 7 Sep 2016 11:10:50 +0000 (13:10 +0200)]
checkstyle: improve speed by checking only recently changed files
This change makes checkstyle much faster by checking only recently
changed files. It only checks files changed in last commit and files
which are localy modified. Old behavior is preserved by specifying
argument "--full" when invoking script.
In addition "make checkstyle" and "make "fixstyle" actions are added
to the top-level Makefile.
Change-Id: I7d86225bd282f32ee508e7f52692a3778ac8dcda
Signed-off-by: Damjan Marion <damarion@cisco.com>
Juraj Sloboda [Mon, 8 Aug 2016 06:43:42 +0000 (23:43 -0700)]
VPP-204 Rework and finish IPFIX implementation
Rework flow report registration system - add streams
Add support for IPv6 and src and dst ports for TCP and UDP protocols
Implement binary API for IPFIX classifier module
Change-Id: Id05cc0127a7b95ceaeebf9c79a32c6936449bd63
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
Damjan Marion [Tue, 6 Sep 2016 20:26:03 +0000 (22:26 +0200)]
Avoid use of node index 0 by registering null-node
In some cases it is convenient to use 0 as an invalid node index
so here we make sure that index 0 is not used.
Change-Id: I5af6bef6769d56086ceb343423185f22843732bd
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Tue, 6 Sep 2016 20:30:16 +0000 (22:30 +0200)]
Add support for input nodes in interrupt mode on the worker threads
Change-Id: Ice2e0e60c801bd6fb67f3a544e95e9ffaa22ca16
Signed-off-by: Damjan Marion <damarion@cisco.com>
Chris Luke [Tue, 6 Sep 2016 13:32:36 +0000 (09:32 -0400)]
VPP-346 More VPP doc fixes
- Fix issue in Doxy dependency check when nothing needs to be installed.
'set -e' and plain '[]' logic don't mix well.
- Fix Makefile snafu when building Doxy output for a single file.
- Include only one of vnet/vnet/buffer.c/dpdk_buffer.c in docs depending on
DPDKness. This could do with some improvement in future, eg to properly
align the pre-doxy steps with what Doxy does.
- Fix rendering of 'inline' tag in Doxygen by having it interpret
always_inline as "inline static".
- Bunch of duplicate CLI command structure names that confused docs and may
one day have caused debugging issues.
- Several other Doxygen syntax issues fixed, like documenting non-existant
parameters (usually just the wrong parameter name, typos, etc)
Change-Id: Ia8cca545e5de9f8750602bffa3c4548acc8971aa
Signed-off-by: Chris Luke <chrisy@flirble.org>
John Lo [Sun, 4 Sep 2016 12:55:34 +0000 (08:55 -0400)]
Add packet/byte count output tx stats to tunap interface
Change-Id: I167c49d2a64e7a36a176d57054ecd99b398a9cca
Signed-off-by: John Lo <loj@cisco.com>
Vengada Govindan [Thu, 25 Aug 2016 17:34:34 +0000 (10:34 -0700)]
Move iOAM Trace as a plugin
Change-Id: I78322e91485e5429871bd356f668b8ed90f4265a
Signed-off-by: Vengada Govindan <venggovi@cisco.com>
Florin Coras [Tue, 6 Sep 2016 14:29:34 +0000 (16:29 +0200)]
VPP-386 Fix map-server output in lisp-cp-lookup trace
Change-Id: I67dd7896932b8ea96062b9ff074959c172b51ba4
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Tue, 6 Sep 2016 11:36:11 +0000 (13:36 +0200)]
VPP-381 Add LISP interfaces to sw_interface_dump
Change-Id: I62b65472e77a33b1fc94f7c4975b5e9cbf358f41
Signed-off-by: Florin Coras <fcoras@cisco.com>
Sergio Gonzalez Monroy [Tue, 6 Sep 2016 13:06:06 +0000 (14:06 +0100)]
IPsec speculative enqueue in exception path, fixes VPP-384
Enqueue buffers into next frame before validating them.
Change-Id: I466518bc6f304678136a2c3d37f136ce878eef05
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Florin Coras [Mon, 5 Sep 2016 17:54:17 +0000 (19:54 +0200)]
VPP-385: Fix ARP for indirect adjacencies
Change-Id: I48cffb8acbd9e6655d7ec661ee8f7e0689b12a2d
Signed-off-by: Florin Coras <fcoras@cisco.com>
Jan [Mon, 5 Sep 2016 09:32:30 +0000 (11:32 +0200)]
Update CSIT tests 160821 -> 160904
- update of CSIT operational branch to be used for VPP-patch test
Change-Id: I5159d0a320305fd3a8ca927fa742ddd4df87b271
Signed-off-by: Jan Gelety <jgelety@cisco.com>
John Lo [Fri, 2 Sep 2016 04:13:41 +0000 (00:13 -0400)]
VPP-358: Add IPv6 ND Event Notification and Termination
Additional fix to vpp_api_test to show which kind of arp/ip6-nd
event is received, whether it is address resolution or mac/ip binding.
Change-Id: Ic65b895cd1bfbe2f34d1b68891a1a580852fbcdb
Signed-off-by: John Lo <loj@cisco.com>
Ole Troan [Wed, 31 Aug 2016 12:50:49 +0000 (14:50 +0200)]
Add in-message cli_request/cli_reply API
This new CLI API is meant to replace the
cli_request/cli_reply that uses shared memory.
PS: checkstyle -- *hate*
Change-Id: I6318f8f6b9be2c2398b49dac9e2193c1998ea724
Signed-off-by: Ole Troan <ot@cisco.com>
Alex Popovsky [Fri, 2 Sep 2016 03:57:45 +0000 (20:57 -0700)]
Fix for invalid check of SPARSE_VEC_INVALID_INDEX
When looking up a UDP port / GRE protocol in the sparse vectors
next_by_dst_port / next_by_protocol a data from the vector was
tested for SPARSE_VEC_INVALID_INDEX instead of sparse index itself.
This doesn’t matter for most cases since V[0] = 0 is true for all
sparse vectors. This however could cause an issue when a valid
sparse entry e.g. V[1234] = 0, with data (0) mistakenly passing
the test for SPARSE_VEC_INVALID_INDEX, while the index itself (1234)
is a valid index.
Change-Id: I04818cc43efeae047a4dae79078157d48b8c359c
Signed-off-by: Alex Popovsky <apopovsk@cisco.com>
Chris Luke [Thu, 1 Sep 2016 13:04:01 +0000 (09:04 -0400)]
VPP-221 Improve doxygen dependency check
Only try to install packages if they're not installed.
Saves a trip through sudo which is useful when you have a
non-privileged account generating the docs.
Change-Id: I3709aceb15516a45ea2f9510d91c6d2e42c8c349
Signed-off-by: Chris Luke <chrisy@flirble.org>
Ed Warnicke [Thu, 1 Sep 2016 01:48:47 +0000 (18:48 -0700)]
VPP-374: getting jvppgen.py into rpm vpp-devel package
Change-Id: Ia2643f33170da92fde0f8228c8d8393f23e98d11
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Alex Popovsky [Fri, 2 Sep 2016 00:38:09 +0000 (17:38 -0700)]
Clean-up unused context arrays in UDP and GRE nodes
Removed unused sparse_index_by_next_index vector in local context
of UDP and GRE nodes. Most probably copy paste leftovers from PPP
implementation where it is realy used
Change-Id: I97e81035e2fd451c6f5a7bc31df96db9e6d2cebf
Signed-off-by: Alex Popovsky <apopovsk@cisco.com>
Ed Warnicke [Thu, 1 Sep 2016 18:54:27 +0000 (11:54 -0700)]
VPP-373: stop building from /vpp mount
Change-Id: I7f8fe8fa6c24b4229b0cb45e6c83e7cb2828e2da
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Chris Luke [Thu, 1 Sep 2016 18:31:46 +0000 (14:31 -0400)]
VPP-346 A swathe of doc fixes
Fixes various Doxygen warnings and other structural defects.
Note: This does not attempt to improve the content of the
documentation; only to improve the syntax and structure of it
and in some cases the consistency.
Change-Id: Ib1915f33edbdbc4558c85565de80dce323193906
Signed-off-by: Chris Luke <chrisy@flirble.org>
Shwetha [Thu, 1 Sep 2016 06:29:19 +0000 (07:29 +0100)]
VPP-341: iOAM plugin documentation
Change-Id: I0042ce8b8a70bb709765037c3636be667ad88aa2
Signed-off-by: Shwetha <shwethab@cisco.com>
Shwetha [Wed, 31 Aug 2016 03:55:58 +0000 (04:55 +0100)]
Fix for vl_client_get_first_plugin_msg_id:266: plugin 'export_eb694f98' not registered
Change-Id: Iad6d8513e55a5f4609c7edb5505067d1136e84ea
Signed-off-by: Shwetha <shwethab@cisco.com>
Dave Barach [Tue, 30 Aug 2016 21:01:52 +0000 (17:01 -0400)]
VPP-369 Add an L2 output classification feature
Change-Id: If03162d328c1ea179249e734537ebb01bade3331
Signed-off-by: Dave Barach <dave@barachs.net>
John Lo [Sat, 27 Aug 2016 05:11:57 +0000 (01:11 -0400)]
VPP-358: Add IPv6 ND Event Notification and Termination
Add IPv6 equivalent of IPv4 ARP event notification which covers address
resolution for L3 and MAC/IP binding in L2 BD and ARP termination in BD.
For IPv6, ICMP6 neighbor solicitation and advertisement packets are
utilized instead of ARP request and response packets for IPv4.
Change-Id: I0088fa173e4480de297c8053ea2fcd0821322815
Signed-off-by: John Lo <loj@cisco.com>
Keith Burns (alagalah) [Mon, 8 Aug 2016 22:56:50 +0000 (15:56 -0700)]
VPP-303 - Documentation changes for vnet/vnet/sr
Change-Id: If8b76959d7c29c216bf03609483a2c9e1d034f46
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Calvin [Thu, 28 Jul 2016 17:52:05 +0000 (13:52 -0400)]
VPP-210: Add "sh api status"
Change-Id: I164761bc2b242b6be527d057108dd09b99653ff5
Signed-off-by: Calvin <calvin.ference@gmail.com>
Chris Luke [Wed, 31 Aug 2016 14:04:58 +0000 (10:04 -0400)]
VPP-221 Loosen Doxygen CLI command struct parser
Make the struct parser slighty slightly more accomodating of
whitespace in places it has no business being.
Also add missing OS_ID thing to Doxygen makefile.
Change-Id: Id3d198fd926f7a6c2ed40bc2d08907aad5d5ac33
Signed-off-by: Chris Luke <chrisy@flirble.org>
Chris Luke [Sat, 30 Jul 2016 19:05:07 +0000 (15:05 -0400)]
VPP-189 Tweak hash_foreach_pair to avoid static warning
Coverity doesn't like when an incrementing pointer is taken from
the address of a singleton; it cries that this is a potential
buffer overrun.
Since the cases of this in hash_foreach_pair are based on items
from a simple union used just to have different types point to
the same location it's a simple matter of using the pointer to
that location directly. Since we then aren't using the members
of the union, we can change that to an opaque pointer (void *).
This accounts for >60 issues in Coverity.
Whilst here, convert some useful existing comments into a docblock.
Change-Id: I114183ab7d7948d4a6a703451417f79fa37634eb
Signed-off-by: Chris Luke <chrisy@flirble.org>
Chris Luke [Mon, 25 Jul 2016 20:38:11 +0000 (16:38 -0400)]
VPP-221 CLI auto-documentation infrastructure
As a step before Doxygen, extract CLI-related struct initializers
from the code and parse that into a summary of the CLI commands
available with the provided help text, such as it is. At the moment
this only renders this into an indexed Markdown file that Doxygen
then picks up but later we can use this information to enrich the
existing VLIB_CLI_COMMAND macro documentor as well as provide
runtime documentation to VPP that is stored on disk outside the
binary image.
Additionally support a comment block immediately prior to
VLIB_CLI_COMMAND CLI command definitions in the form /*? ... ?*/
that can be used to include long-form documentation without having
it compiled into VPP.
Examples of documenting CLI commands can be found in
vlib/vlib/unix/cli.c which, whilst not perfect, should provide a
starting point. Screen captures of sample output can be seen at
https://chrisy.flirble.org/vpp/doxy-cli-example.png and
https://chrisy.flirble.org/vpp/doxy-cli-index.png .
Next, shift the Doxygen root makefile targets to their own Makefile.
The primary reason for this is that the siphon targets do dependency
tracking which means it needs to generate those dependencies whenever
make is run; that is pointless if we're not going to generate any
documentation. This includes the package dependencies since they since
they sometimes unnecessarily interfere with the code build in some cases
at the moment; later we will look to building a Python venv to host the
Python modules we use.
One final remark: In future we may consider deprecating .long_help
in the VLIB_CLI_COMMAND structure entirely but add perhaps .usage_help.
.short_help would be reserved for a summary of the command function
and .usage_help provide the syntax of that command. These changes would
provide great semantic value to the automaticly generated CLI
documentation. I could also see having .long_help replaced by a
mechanism that reads it from disk at runtime with a rudimentary
Markdown/Doxygen filter so that we can use the same text that is used in
the published documentation.
Change-Id: I80d6fe349b47dce649fa77d21ffec0ddb45c7bbf
Signed-off-by: Chris Luke <chrisy@flirble.org>
Pavel Kotucek [Fri, 26 Aug 2016 11:35:40 +0000 (13:35 +0200)]
VPP-240: delete subinterface
Added new CLI and API command to delete subinterface.
Change-Id: Ia92a8facc6ad84634bdec430093e6add02ee674e
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
Ed Warnicke [Wed, 31 Aug 2016 01:09:24 +0000 (18:09 -0700)]
Fix for vppctl to suppress "load_one_plugin:63: Loaded plugin:" msgs
Change-Id: I06fcb024036b48a6401d2865a2181b122cb32108
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Filip Tehlar [Tue, 30 Aug 2016 13:05:18 +0000 (15:05 +0200)]
VPP-365: Fix sending of bd_index in lisp_eid_table_add_del_map
Change-Id: I1f8fd65fa33b0bc7ee07aa0eeb5f794a7ede9537
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Florin Coras [Tue, 30 Aug 2016 09:46:11 +0000 (11:46 +0200)]
VPP-364 Add vpp-api/python/build to gitignore
Change-Id: I16a594ad75c085b8d0b74cf2f472f88a655253c0
Signed-off-by: Florin Coras <fcoras@cisco.com>
John Lo [Tue, 30 Aug 2016 04:10:09 +0000 (00:10 -0400)]
VPP-361: Memory leak on delete of VXLAN over IPv6 tunnel
The key for VXLAN over IPv6 tunnel is allocated on create and should
be freed on delete.
Change-Id: I11bdd9465030fed57cc4bbd28dbccdf952633b34
Signed-off-by: John Lo <loj@cisco.com>
Filip Tehlar [Sat, 27 Aug 2016 06:40:26 +0000 (08:40 +0200)]
VPP-353: Fully support LISP negative mappings in API
Change-Id: I71943fb4ae2a2f71bcf1ad73512812edf96c06da
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Dave Barach [Mon, 29 Aug 2016 20:31:47 +0000 (16:31 -0400)]
VPP-360 Allow L2 classify to use dynamic graph arcs
Simple change so we can program L2 classifier per-session next-indices
and per-table miss-next-indices using dynamically-created graph arcs.
Change-Id: I9d4a3c82b83e94557075d56a6842d7075ed58905
Signed-off-by: Dave Barach <dave@barachs.net>
Ole Troan [Thu, 25 Aug 2016 10:26:47 +0000 (12:26 +0200)]
VPP-310 Mapping algorithm compute wrong ea-bits
Mapping of IPv4 prefixes ended up writing past IPv6 prefix + EA bits
length.
(Added some unit testing code).
Change-Id: I59893b44eea5cebf00a23afc405832741f84cf4f
Signed-off-by: Ole Troan <ot@cisco.com>
Keith Burns (alagalah) [Thu, 25 Aug 2016 18:21:39 +0000 (11:21 -0700)]
VPP-307: Documentation for vnet/vnet/vxlan-gpe
Change-Id: Iaab6f4b63ed0d986be1ac0636c692b46098ad54d
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Florin Coras [Thu, 25 Aug 2016 23:47:47 +0000 (19:47 -0400)]
VPP-357 Fix vni for LISP fwd entry removals
Change-Id: I5d20c1939f7a5a142bf696b34143f7ebca6afbcb
Signed-off-by: Florin Coras <fcoras@cisco.com>
Filip Tehlar [Fri, 26 Aug 2016 10:44:38 +0000 (12:44 +0200)]
VPP-356: Fix wrong byte order in LISP API
Change-Id: Ib2284025b8394a87f1d5765713adb7070b450cba
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Keith Burns (alagalah) [Thu, 25 Aug 2016 20:37:37 +0000 (13:37 -0700)]
VPP-305: Documentation for vnet/vnet/unix
Change-Id: I3f1a225033ecebe0cedfc3466b552176461b76ab
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Filip Tehlar [Wed, 24 Aug 2016 12:11:07 +0000 (14:11 +0200)]
VPP-329: Add L2 support to lisp_eid_table_map_dump
Change-Id: Idfb115cd1f95394f4a4a569dc34c0488a1d58558
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Calvin Ference [Thu, 25 Aug 2016 14:04:09 +0000 (10:04 -0400)]
VPP-271: Coding style cleanup vnet/vnet/snap
Change-Id: I810082b5a4072b11ffd0bcc2917347562deb253a
Signed-off-by: Calvin Ference <cference@inocybe.ca>
Dave Barach [Wed, 24 Aug 2016 22:36:03 +0000 (18:36 -0400)]
Save rewrite length for post-rewrite rewind action
Change-Id: I5dd52714f8422c15bf78da19bcb63246f9d0103d
Signed-off-by: Dave Barach <dave@barachs.net>
Yi Yang [Thu, 18 Aug 2016 06:06:52 +0000 (14:06 +0800)]
Fix vxlan-gpe next protocol value
vxlan4_gpe_rewrite and vxlan6_gpe_rewrite used the fixed value
VXLAN_GPE_PROTOCOL_IP4 for next protocol regardless of vxlan-gpe
port next protocol, this commit fixed it and used the value from
vxlan-gpe port.
Change-Id: I22ba25fbde1c0630960cbcfd196e14231fbf1af3
Signed-off-by: Yi Yang <yi.y.yang@intel.com>
Ole Troan [Wed, 24 Aug 2016 19:10:46 +0000 (21:10 +0200)]
Adding python-dev dependency to main Makefile.
Change-Id: I9968015acfc2cc63f97dee25538a9b3e61fac5b6
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Wed, 24 Aug 2016 22:24:08 +0000 (00:24 +0200)]
VPP-228 VPP-326: MAP: Adding additional API/CLI input parameter checks.
Added checks for EA bits length + PSID length > 64.
Removed incorrect check in VAT that required all arguments as mandatory.
Change-Id: I33a138612d199d7c5ce59abe1a7d7ecede3522bc
Signed-off-by: Ole Troan <ot@cisco.com>
Filip Tehlar [Wed, 24 Aug 2016 09:28:02 +0000 (11:28 +0200)]
VPP-328: Add dump call for listing LISP VNIs
Change-Id: I45c054ad638a0e918dddefa4468ff65452949970
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
AkshayaNadahalli [Thu, 25 Aug 2016 08:55:28 +0000 (10:55 +0200)]
Fix ip6-rewrite drops when no feature is configured
In ip6_rewrite_inline(), only in dual loop next0 and next1 are set to IP6_REWRITE_NEXT_DROP and never updated unless there is an o/p feature configured on it. So any packets processed under dual loop are dropped.
Single loop works fine as next0 is updated correctly.
Fix is to update next node from adjacency under dual packet loop processing.
Change-Id: I902fcc84ed307464d92499f9d37137af660b592c
Signed-off-by: AkshayaNadahalli <anadahal@cisco.com>
Damjan Marion [Wed, 24 Aug 2016 12:32:39 +0000 (14:32 +0200)]
Fix issues with vhost-user when dpdk vhost-user is disabled, fixes VPP-347, VPP-349
Change-Id: I774bab98e43d55678a67a7708ca50edbbd4cbb06
Signed-off-by: Damjan Marion <damarion@cisco.com>
Sean Chandler [Mon, 22 Aug 2016 20:32:22 +0000 (16:32 -0400)]
VPP-345: pull in upstream checksum patch for ICMP packets
http://www.dpdk.org/dev/patchwork/patch/15216/
Change-Id: I91b67f3e5c0abff52626e504e2707814ae0c3ed0
Signed-off-by: Sean Chandler <seandchandler@gmail.com>
Ole Troan [Mon, 1 Aug 2016 02:59:13 +0000 (04:59 +0200)]
VPP Python language binding - plugin support
- Moved Python generator tool to tools directory
- Added build-vpp-api Makefile target
- Generator now only creates a Python representation of the .api
the rest of the framework is in the vpp_papi script
- Each plugin has its own namespace.
- Plugin Python files are installed in vpp_papi_plugins for easy
use inside the build tree.
Change-Id: I272c83bb7e5d5e416bdbd8a790a3cc35c5a04e38
Signed-off-by: Ole Troan <ot@cisco.com>
Calvin [Wed, 24 Aug 2016 14:35:59 +0000 (10:35 -0400)]
VPP-262: Coding standards cleanup vnet/vnet/llc
Change-Id: I15d71ecf9e8ed37a52cbbd45cdc0fc4ee87c0e5f
Signed-off-by: Calvin Ference <cference@inocybe.ca>
Dave Barach [Tue, 23 Aug 2016 19:23:10 +0000 (15:23 -0400)]
VPP-346 Document the ip feature registration scheme
Change-Id: I81a9e963bdeb437ca228f11aaedca8d122be7471
Signed-off-by: Dave Barach <dave@barachs.net>
Ole Troan [Wed, 24 Aug 2016 14:17:29 +0000 (16:17 +0200)]
VPP-340: MAP-T wrong destination address
The bug was in VAT MAP code parsing a 32 bit integer into a 8 bit
type. Perhaps we should try to build some defences in
unformat_chech_input() to avoid these errors.
Rebuild.
Change-Id: Iae4959f7e04d889da2e9650a4201c4db15d74201
Signed-off-by: Ole Troan <ot@cisco.com>
Filip Tehlar [Mon, 22 Aug 2016 10:29:21 +0000 (12:29 +0200)]
VPP-321: Fix param order of unformat_lisp_eid_api
Change-Id: Ib00ca0f0dab4784a3fb34ffd91c18a3940e9a5d5
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Filip Tehlar [Thu, 11 Aug 2016 10:21:37 +0000 (12:21 +0200)]
VPP-323: Add LISP locator set index to reply API message
Change-Id: Id798f63f4cf1a8aa7a75931bc23d3c7f5d738938
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Damjan Marion [Mon, 22 Aug 2016 22:53:22 +0000 (00:53 +0200)]
Fix PCI vendor_id/device_id detection for SR-IOV devices
Change-Id: I06ae392c7c8c3b4be7fd46560add442f42927c22
Signed-off-by: Damjan Marion <damarion@cisco.com>
Filip Tehlar [Tue, 23 Aug 2016 08:52:44 +0000 (10:52 +0200)]
VPP-342: Don't allow remote mapping to overwrite local or static mapping
Change-Id: I9888d7c087da538b81a6a1967edbdf1103cc095a
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Damjan Marion [Mon, 22 Aug 2016 20:34:38 +0000 (22:34 +0200)]
dpdk: Remove obsolete VMXNET3 driver start/stop workaround
Change-Id: I4f46f2965891b0bd0d69a2c426068b0fb1ba881e
Signed-off-by: Damjan Marion <damarion@cisco.com>
Calvin [Fri, 19 Aug 2016 20:23:14 +0000 (16:23 -0400)]
VPP-267: Style cleanup for vnet/vnet/pg
Change-Id: I6c8bf1dfee7db4b658c2afa4888bcd52b03808fd
Signed-off-by: Calvin <calvin.ference@gmail.com>
Calvin [Fri, 19 Aug 2016 17:43:59 +0000 (13:43 -0400)]
VPP-270: Code style cleanup for vnet/vnet/ppp
Change-Id: I637f1860fedb208d7242dc2798b3d55abac891a3
Signed-off-by: Calvin <calvin.ference@gmail.com>
Shwetha [Mon, 8 Aug 2016 14:51:04 +0000 (15:51 +0100)]
Raw export of IP6 packet with iOAM metadata
- is enabled on iOAM pop nodes with "set ioam export ipfix collector"
- ioam_export_node Hooks into vlib graph b/n ip6-hop-by-hop node and ip6-pop-hop-by-hop node
- A buffer per worker thread is created for collecting packet data to be exported
- ioam_export_node exports first 3 cachelines by collecting it in a MTU sized frame, slaps on ipfix header for export
- ioam_export_thread process node - checks for unsent record buffers for longer than 20 seconds and exports it
- Added dual loop and prefetch in add, hop-by-hop and pop functions
To be done:
- IPfix template
- Multi collector distribution of ipfix packets
- Port to be configurable
Change-Id: I959b4253036551382562bdaf10a83fd6f2f1c88b
Signed-off-by: Shwetha <shwethab@cisco.com>
Jan [Mon, 22 Aug 2016 08:38:35 +0000 (10:38 +0200)]
Update CSIT tests 160815 -> 160821
- update of CSIT operational branch to be used for VPP-patch test
Change-Id: I4791551fa0b161ac0347d992bcda4bc1fb8c74d2
Signed-off-by: Jan <jgelety@cisco.com>
Dave Barach [Wed, 17 Aug 2016 15:54:30 +0000 (11:54 -0400)]
VPP-337 Add per interface IN filtering
- ip post-rewrite feature subgraph arc support
Change-Id: Ia4b07197463021ade916326231af246e2559a290
Signed-off-by: Dave Barach <dave@barachs.net>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Steve Shin [Fri, 19 Aug 2016 00:34:52 +0000 (17:34 -0700)]
vhost-user: unmap previously configured memory if necessary
If there's any memory-mapped region configued previously,
it should be unmapped before setting up a new vhost memory table.
Otherwise, huge page leakage will happen.
Change-Id: I375f603ea303919f1502df44a26a7384ab2ea00e
Signed-off-by: Steve Shin <jonshin@cisco.com>
Steve Shin [Thu, 18 Aug 2016 15:16:27 +0000 (08:16 -0700)]
tuntap_rx modification to handle jumbo packets ( > 2K bytes)
Change-Id: Iebe30b87457741ac268b24c96fa7ea8ad1e101a6
Signed-off-by: Steve Shin <jonshin@cisco.com>
Keith Burns (alagalah) [Thu, 18 Aug 2016 00:43:39 +0000 (17:43 -0700)]
Bump of JVPP version for new MASTER.
Change-Id: If03efcea871641e33fa079d3c1c308dc8e23cdcc
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Matus Fabian [Wed, 10 Aug 2016 08:55:36 +0000 (01:55 -0700)]
VPP-202: L2-GRE over IPSec
GRE encapsulate layer 2 traffic and IPSec encrypt what is encapsulated by GRE.
The whole point of L2-GRE over IPSec is to tunnel layer 2 over GRE and IPSec by
bridging the physical interface with IPSec-GRE tunnel interface.
Change-Id: Ia4cf9ed407bf663770e0d8905c0ad44ce73bd23b
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Ed Warnicke [Wed, 17 Aug 2016 18:53:08 +0000 (11:53 -0700)]
VPP-336: Fix build order for jvpp_{core,registry}.la dependency on jvpp_common.la
Change-Id: I886d087532d20bf7e6555da44e4e75ee0ca38268
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Damjan Marion [Wed, 17 Aug 2016 15:05:46 +0000 (17:05 +0200)]
Coding standards cleanup in vnet/vnet/devices, fixes VPP-248
Change-Id: I35cf89bf1aa54b76294876e9feb0ed0ccc316975
Signed-off-by: Damjan Marion <damarion@cisco.com>
Marek Gradzki [Wed, 17 Aug 2016 10:33:50 +0000 (12:33 +0200)]
VPP-205: documentation update
Change-Id: I98e5bdbd0472c2973885defe2712b53d9da8a536
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Florin Coras [Tue, 16 Aug 2016 21:04:00 +0000 (23:04 +0200)]
VPP-261 Coding standards cleanup - vnet/vnet/lisp-gpe
Change-Id: I1bc2098e79ce753f3d72f05f2fcac9ab00d0d052
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Tue, 16 Aug 2016 19:09:14 +0000 (21:09 +0200)]
VPP-260 Coding standards cleanup - vnet/vnet/lisp-cp
Change-Id: I29b84c44c12ab746e9e61c30efa0ac3418d1a09a
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Tue, 16 Aug 2016 09:27:02 +0000 (11:27 +0200)]
Fix coverity issues in IPSec code, fixes VPP-189
Change-Id: I4e43606884ebad9a84abda779b82417192727ef3
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Tue, 16 Aug 2016 20:53:54 +0000 (22:53 +0200)]
Coding standards cleanup - remove trailing whitespace, fixes VPP-332
Change-Id: I649a17f8fa47599faf438b2e596f53761790d10c
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Tue, 16 Aug 2016 16:56:08 +0000 (18:56 +0200)]
Coding standards cleanup in vnet/vnet/devices/dpdk, partially fixes VPP-248
Change-Id: Ie3ee4ccc126c5db9020779cbd06b0d1da99c8411
Signed-off-by: Damjan Marion <damarion@cisco.com>
Marek Gradzki [Tue, 26 Jul 2016 13:28:22 +0000 (15:28 +0200)]
VPP-205: jvpp plugin support.
Splits jvpp into two jars
jvpp-registry.jar - base jvpp functionality
jvpp-core.jar - Java wrapper for vpe.api
Plugins can be generated the same way jvpp-core.jar is.
Example (nsh):
https://gerrit.fd.io/r/#/c/2118/
Change-Id: I2254f90b2c3e423563bb91bf70877979f1e90a7d
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Florin Coras [Mon, 15 Aug 2016 17:16:32 +0000 (19:16 +0200)]
VPP-330 Track pending map-requests with a fifo
Change-Id: Icc64abb91047f756c955c880f6f85b26faef666a
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ed Warnicke [Mon, 11 Jul 2016 17:29:41 +0000 (10:29 -0700)]
Create python package for jvpp generation.
Change-Id: I2254f90b2c3e423563bb91bf70877979f1e86a6b
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Calvin [Wed, 10 Aug 2016 15:01:41 +0000 (11:01 -0400)]
VPP-258: Style change for l2tp
Change-Id: Ib456558974820d8d45114b2bbad014a3a3aa2d21
Signed-off-by: Calvin <calvin.ference@gmail.com>
Signed-off-by: Dave Barach <dave@barachs.net>
Damjan Marion [Tue, 16 Aug 2016 11:25:59 +0000 (13:25 +0200)]
Fix coverity issues in DPDK code, fixes VPP-189
Change-Id: Ie2ebb29451200158504bda8c616d57821edbd749
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Tue, 16 Aug 2016 10:37:24 +0000 (12:37 +0200)]
Fix coverity issues in vhost-user code, fixes VPP-189
Change-Id: Ief95aac5d4451f411dbed8050528708c0b1b7732
Signed-off-by: Damjan Marion <damarion@cisco.com>
Keith Burns (alagalah) [Tue, 16 Aug 2016 01:33:19 +0000 (18:33 -0700)]
VPP251 - Code style vnet/vnet/ethernet
Change-Id: I3e51ca70a8e1ac7f6584bc5b0271ee4daacc1084
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Calvin [Thu, 11 Aug 2016 18:10:51 +0000 (14:10 -0400)]
VPP-266: style change for vnet/vnet/osi
Change-Id: I6004a96f9f791fb9fbc961440c9988f7a3ca7db0
Signed-off-by: Calvin <calvin.ference@gmail.com>
Jianfeng Tan [Thu, 11 Aug 2016 02:17:30 +0000 (02:17 +0000)]
Vhost-User: Fix calculate memory region size
The memory region size calculation is wrong. For example, a region
with size of 1G (hugepage size is also 1G), and offset is zero, use
the previous way to calculate, the ultimate size to mmap and munmap
is 2G, which could lead to segment fault when munmap is executed.
This patch refers the way in DPDK to calculate the region size.
Change-Id: I6f35cde15e2402be0025c556c192b87a46bbf978
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
Jan [Mon, 15 Aug 2016 14:56:42 +0000 (16:56 +0200)]
Update CSIT tests 160807 -> 160815
- update of CSIT operational branch to be used for VPP-patch test
Change-Id: Ia9cb275d9471f3c25a02f943d0ace65aec425f8d
Signed-off-by: Jan <jgelety@cisco.com>
Dave Barach [Mon, 15 Aug 2016 19:31:15 +0000 (15:31 -0400)]
VPP-257 Coding standards cleanup for vnet/vnet/l2
Change-Id: Iba5f33675bb2eb806e9becdc42b11da5d3932d55
Signed-off-by: Dave Barach <dave@barachs.net>
Filip Tehlar [Mon, 18 Jul 2016 15:35:40 +0000 (17:35 +0200)]
VPP-198: LISP map-resolver failover algorithm
Change-Id: Iadd49e58a359a2e58610bd1793818ec8a25d51f1
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>