vpp.git
3 years agocrypto-native: fix multi-arch variant initialization 25/29925/3
Ray Kinsella [Fri, 13 Nov 2020 09:29:44 +0000 (09:29 +0000)]
crypto-native: fix multi-arch variant initialization

crypto_native/main.h is being built as default,
and crypto_native_main is initialized with a size of 64 bytes.

crypto_native/aes_gcm.c and crypto_native/aes_cbc.c are march
variants, their ICL variants are expecting crypto_native_main
to be 256 bytes.

Type: fix

Signed-off-by: Georgii Tkachuk <georgii.tkachuk@intel.com>
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Change-Id: I4cddb75b712ea83c9cfca621887605d7bae104ec

3 years agonat: api,cli and test update & cleanup 17/29717/5
Filip Varga [Mon, 2 Nov 2020 11:11:12 +0000 (12:11 +0100)]
nat: api,cli and test update & cleanup

Cleanup of print functions in api file,
splitting functionality of cleanup callbacks for ED
and EI NAT. Updating and fixing API & CLI calls.

Type: refactor

Change-Id: I7a9dc4c8b1d2ca29db4754be7dfa4f698942127a
Signed-off-by: Filip Varga <fivarga@cisco.com>
3 years agosr: show the hop-limit value used for SRv6 encapsulation 70/29870/2
Ahmed Abdelsalam [Tue, 10 Nov 2020 17:19:12 +0000 (17:19 +0000)]
sr: show the hop-limit value used for SRv6 encapsulation

Implements CLI to show the hop-limit value used for the
outer IPv6 header of the SRv6 encapsulation.

Type: feature
Signed-off-by: Ahmed Abdelsalam <ahabdels@cisco.com>
Change-Id: I1f3d8f71fb94494ae6ab8104b9fcf989c5585d5c

3 years agoavf: don't switch process if already running process node 16/29916/2
Damjan Marion [Thu, 12 Nov 2020 14:48:15 +0000 (15:48 +0100)]
avf: don't switch process if already running process node

Type: fix
Change-Id: I82b11339402b5848b27c600f6484aaeee66cc888
Signed-off-by: Damjan Marion <damarion@cisco.com>
3 years agotcp: push last buffered sequence 90/29790/11
Florin Coras [Fri, 6 Nov 2020 03:01:44 +0000 (19:01 -0800)]
tcp: push last buffered sequence

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iba914ac69585e89f174f09e74ae716df1b080c59

3 years agonat: use table ID for nat44 ipfix session events 87/29787/2
Matthew Smith [Wed, 4 Nov 2020 23:07:44 +0000 (17:07 -0600)]
nat: use table ID for nat44 ipfix session events

Type: fix

IPfix messages about NAT44 session create/delete were being populated
with the FIB table index instead of the table ID. The table ID is the
correct identifier to report externally (NAT64 IPfix messages for BIB
and session create/delete use table ID, as does NAT syslogging). Convert
the table index to an ID before adding it to the IPfix NAT44 session
create/delete message data.

Change-Id: I0166384752b17ff3a8c55aa19fa2af7a8140791e
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
3 years agodevices: remove unused code 91/29891/2
Damjan Marion [Thu, 12 Nov 2020 10:20:27 +0000 (11:20 +0100)]
devices: remove unused code

Type: refactor
Change-Id: I3f561818bc7c221f676477a52c7c7781624c185a
Signed-off-by: Damjan Marion <damarion@cisco.com>
3 years agovirtio: fix the index issue 86/29886/2
Mohsin Kazmi [Wed, 11 Nov 2020 19:28:35 +0000 (20:28 +0100)]
virtio: fix the index issue

Type: fix

Fixes: 587f9130424fd451e4ba823240d02f655fb197d1

Change-Id: I230993a54c84e22e324de2a8defeda83c517d733
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
3 years agotcp: validate fin seq in closing states 07/29807/4
Florin Coras [Fri, 6 Nov 2020 22:21:26 +0000 (14:21 -0800)]
tcp: validate fin seq in closing states

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id8673cff699cfdc1ac68797b9ab5cdf6f6b578a3

3 years agovcl: remove unused configs 59/29859/3
Florin Coras [Tue, 10 Nov 2020 03:59:16 +0000 (19:59 -0800)]
vcl: remove unused configs

Type: refactor

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia8698c7ba63fc549f821863bb54fe72cc3a8d5be

3 years agovpp: use vpp heap for libc 49/28949/4
Benoît Ganne [Fri, 18 Sep 2020 08:05:37 +0000 (10:05 +0200)]
vpp: use vpp heap for libc

This makes libc use vpp main heap instead of the default libc heap.
This gives better visibility (accounting, tracing) on allocations
happening in external libraries called from vpp (eg. OpenSSL).

Type: feature

Change-Id: I5d8a673472145a4e090bedb443b8c58a967d1cca
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agotcp: fix test for trailing bytes 57/29857/2
Florin Coras [Tue, 10 Nov 2020 03:03:09 +0000 (19:03 -0800)]
tcp: fix test for trailing bytes

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I6455f2d38a2927f16fd4cb0e26b8560a2357cebe

3 years agosr: Show IPv6 address used as SRv6 Encaps source 26/29826/2
Ahmed Abdelsalam [Mon, 9 Nov 2020 14:04:07 +0000 (14:04 +0000)]
sr: Show IPv6 address used as SRv6 Encaps source

Implements CLI to show the IPv6 address used as source address for the SRv6 encapsulation.

Type: feature
Signed-off-by: Ahmed Abdelsalam <ahabdels@cisco.com>
Change-Id: Ia442d9345a7793836148d890745fc5dc92729b6f

3 years agoclassify: fix classify filter trace del cli processing 36/29736/5
Jon Loeliger [Tue, 3 Nov 2020 20:49:10 +0000 (15:49 -0500)]
classify: fix classify filter trace del cli processing

When a 'del' is used to delete a classify table, only the
mask is needed to locate the table.  Any match vector is
unneeded.  The tests failed to notice this, but if the
test is run by hand in vppctl, it issues a parse error.

Fix the test so that it doesn't supply irrelevant data.
Fix the CLI processing to read always complete newline
terminated line of input instead.  This allows unneeded
CLI parameters to be ignored.  It also necessitated
fixing a trace test which had then erroneously split
a single CLI command over multiple lines.

While in the area, fix a latent bug on table matching
where a test for compatible mask vector sizes were
not matching impedance properly (byte vs ux32x4).

Type: fix
Signed-off-by: Jon Loeliger <jdl@netgate.com>
Change-Id: I1177ab1dd417f3d11f30eecbaa2b0fb1015c3ab5

3 years agocnat: Fix invalid adj_index 35/29735/2
Nathan Skrzypczak [Tue, 3 Nov 2020 16:44:28 +0000 (17:44 +0100)]
cnat: Fix invalid adj_index

Type: fix

When using sNAT in combination with cnat translations
it might happen that the cnat_node_vip.c picks up a
translation on a session that has an invalid lb index,
thus resulting in a later crash in ip4-load-balance

Change-Id: I82607086b2d672a9dcf26bfb82ad7f83e6474562
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
3 years agoip6-nd: fix memory leaks 56/29856/3
Dave Barach [Mon, 9 Nov 2020 22:11:57 +0000 (17:11 -0500)]
ip6-nd: fix memory leaks

Quite a noticeable amount of memory. Recoded ra event tx and rx fns in
the usual manner, which terminated the leaks.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I486d348456b465ad3940a280d4cf489e8dd655a5

3 years agohsa: remove fake binary api registration in echo apps 31/29831/3
Florin Coras [Mon, 9 Nov 2020 17:39:28 +0000 (09:39 -0800)]
hsa: remove fake binary api registration in echo apps

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I73fbf991f42e643f906b6a3badd95ef46106eb25

3 years agovcl: remove support for shm api connections 17/29817/3
Florin Coras [Mon, 9 Nov 2020 02:04:33 +0000 (18:04 -0800)]
vcl: remove support for shm api connections

Session layer only supports bapi with socket transport or app socket api
attachements. Going forward this will be further restricted to the
latter.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ib368cf2ce92bbca192cca977664800879cd4058e

3 years agosession: remove support for shm bapi attachment 16/29816/5
Florin Coras [Mon, 9 Nov 2020 00:50:39 +0000 (16:50 -0800)]
session: remove support for shm bapi attachment

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I21bda0c46406aff54ad8fe5e44491e8e332de170

3 years agovlib: support macros in initial config file 28/29828/2
Dave Barach [Mon, 9 Nov 2020 15:30:06 +0000 (10:30 -0500)]
vlib: support macros in initial config file

Type: improvement
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: If8a19eb6688755311a3430437331ddf13c7e28c8

3 years agosession: delegate fifo ooo lookup init to transports 12/29812/3
Florin Coras [Sat, 7 Nov 2020 00:59:08 +0000 (16:59 -0800)]
session: delegate fifo ooo lookup init to transports

Fifo chunk ooo lookup data structures are private (not allocated on
segment heap) and should only be initialized by transport protocols that
require out-of-order enqueues/dequeues (like tcp).

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iaa15d6850385bf903cc501c54c2752e8e811449e

3 years agoikev2: add tests for DPD 25/29825/2
Filip Tehlar [Mon, 9 Nov 2020 13:23:24 +0000 (13:23 +0000)]
ikev2: add tests for DPD

Type: test

Change-Id: I9c1129a8596344551f3f8f2e029846d22511482e
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
3 years agosession: default to using memfd mq segments 15/29815/2
Florin Coras [Sun, 8 Nov 2020 22:36:19 +0000 (14:36 -0800)]
session: default to using memfd mq segments

First step towards deprecating the use of binary api's segment for mq
allocation.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I9d3d17e4d406575d64e0426bb65465130a84980a

3 years agovlib: fix trace number accounting 22/29222/5
Benoît Ganne [Fri, 2 Oct 2020 17:36:57 +0000 (19:36 +0200)]
vlib: fix trace number accounting

When using classifier to filter traces, not all packets will be traced.
In that case, we should only count traced packets.

Type: fix

Change-Id: I87d1e217b580ebff8c6ade7860eb43950420ae78
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agoikev2: fix msg IDs generation 47/29747/2
Filip Tehlar [Sat, 31 Oct 2020 02:17:16 +0000 (02:17 +0000)]
ikev2: fix msg IDs generation

Type: fix

Change-Id: Id922895c269f0d2450e55fcb6871b6857f443462
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
3 years agoikev2: fix udp encap 95/29795/2
Filip Tehlar [Fri, 6 Nov 2020 11:00:42 +0000 (11:00 +0000)]
ikev2: fix udp encap

Type: fix

Change-Id: I8c66f79f2d8cfff7c6d45e1fc5b529ffb3941491
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
3 years agotap: add function to set speed 84/28684/3
Alexander Chernavin [Fri, 4 Sep 2020 13:24:20 +0000 (09:24 -0400)]
tap: add function to set speed

A plugin can set the speed on a host interface making it possible for
host applications to be aware of the actual interface speed, not the
one that the driver reports by default.

With this change, add a function to set speed on a host interface.

Type: feature
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Change-Id: I259a52b736022bdd805e8d92dcd1bfd5c58f6f96

3 years agoipsec: fix unformat types 99/29799/2
Benoît Ganne [Fri, 6 Nov 2020 09:51:47 +0000 (10:51 +0100)]
ipsec: fix unformat types

ipsec_{crypto,integ}_alg_t are packed and smaller than u32. Callers are
using those enums so unformat functions should too instead of u32 to
not overflow the stack.

Type: fix

Change-Id: Ifc86366f1928ca6352f06f390a88ac64668289d5
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agoipsec: fix outer table id lookup in ipsec tun script 00/29800/2
Benoît Ganne [Fri, 6 Nov 2020 09:55:22 +0000 (10:55 +0100)]
ipsec: fix outer table id lookup in ipsec tun script

Type: fix

Change-Id: I195949b610dca1b860baca18a059d39949627961
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agoipsec: add support for tx-table-id in cli + example 01/29801/2
Benoît Ganne [Fri, 6 Nov 2020 13:14:23 +0000 (14:14 +0100)]
ipsec: add support for tx-table-id in cli + example

Type: improvement

Change-Id: I840741dfe040718b682935cdbcb0ba958d45a591
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agotcp: avoid consuming trailing bytes 88/29788/2
Florin Coras [Thu, 5 Nov 2020 21:39:48 +0000 (13:39 -0800)]
tcp: avoid consuming trailing bytes

Thanks to Shaligram Prakash <Shaligram.Prakash@enea.com> for reporting.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I135d23957a0dbb56a30994dfe3a316efd1eabad1

3 years agonat: fix hairpinning trace 31/29531/4
Klement Sekera [Mon, 19 Oct 2020 13:42:41 +0000 (13:42 +0000)]
nat: fix hairpinning trace

Type: fix
Fixes: 17a8ab6857f023bc1436d84808acc58dd614203e
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I597d08d1d2457116e6856fa40cd65987e13a28d4

3 years agovppinfra: mspace_get_aligned should respect MALLOC_ALIGNMENT 83/29783/2
Damjan Marion [Thu, 5 Nov 2020 13:54:08 +0000 (14:54 +0100)]
vppinfra: mspace_get_aligned should respect MALLOC_ALIGNMENT

While underlying mspace_malloc() respects MALLOC_ALIGNMENT (16)
mspace_get_aligned moves start of data for 4 bytes making final result
not aligned to MALLOC_ALIGNED.

Type: fix
Change-Id: Ib1584f315e3658b3b748ebf4886fb7389ce640fe
Signed-off-by: Damjan Marion <damarion@cisco.com>
3 years agobuild: link time optimization for release builds 97/29597/10
Damjan Marion [Thu, 22 Oct 2020 12:23:47 +0000 (14:23 +0200)]
build: link time optimization for release builds

Type: improvement
Change-Id: I0e24f1d2ad5c7a11a8bd40125428f86aca867bec
Signed-off-by: Damjan Marion <damarion@cisco.com>
3 years agobuild: run garbage collection while linking plugins 85/29785/2
Damjan Marion [Thu, 5 Nov 2020 16:55:53 +0000 (17:55 +0100)]
build: run garbage collection while linking plugins

Ask linker to remove symbols which are not referenced or exported.

Type: improvement
Change-Id: Iec01fda7ec5b14bab8f36d25c2652bd6fe619961
Signed-off-by: Damjan Marion <damarion@cisco.com>
3 years agonat: remove unnecessary code 01/29701/2
Klement Sekera [Fri, 30 Oct 2020 16:17:00 +0000 (16:17 +0000)]
nat: remove unnecessary code

Type: improvement

Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I478f5dcbf7595c62611d25a40aa356d8ce09d216

3 years agotap: allow change of carrier state on host 45/28645/4
Matthew Smith [Fri, 24 Jul 2020 18:38:03 +0000 (13:38 -0500)]
tap: allow change of carrier state on host

Type: feature

Add a function to adjust the link state of the host side of a tap
interface. If an application (e.g. route protocol daemons) running on
the host uses netlink to monitor interface state, a plugin
could use this function to communicate a loss of connectivity
to the application by making the interface appear to go down.

Requires a somewhat recent kernel. E.g. it does not have any effect
on CentOS 7 but it works on CentOS 8.

Change-Id: I677ee7889d2eb142e2395bea98f0b4d7e7e7f810
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
3 years agovirtio: misc optimizations 06/29706/4
Damjan Marion [Sat, 31 Oct 2020 22:40:51 +0000 (23:40 +0100)]
virtio: misc optimizations

Type: improvement
Change-Id: Iaf98a60e37dd28828feca365b8fdc5d2f7ae6935
Signed-off-by: Damjan Marion <damarion@cisco.com>
3 years agoip: fix doxygen doc for address add/del command 54/29554/2
Benoît Ganne [Tue, 20 Oct 2020 12:36:55 +0000 (14:36 +0200)]
ip: fix doxygen doc for address add/del command

Type: docs

Change-Id: I96d5cdb41bd938f06d2d72f2625bf1b3d2c5b1b4
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agocnat: reduce compile time 24/29724/3
Nathan Skrzypczak [Mon, 2 Nov 2020 16:29:52 +0000 (17:29 +0100)]
cnat: reduce compile time

Compile time reduced from ~30s to 2s for
cnat_node_vip.c & cnat_node_snat.c This doesn't
impact performance for now as ts update rwlock
is the main bottleneck.

Type: improvement

Change-Id: Ic92df300ae0dfddc5235c350bd021e73e7c850d9
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
3 years agonat: fix byte order of vrf_id in logging 77/29777/2
Alexander Chernavin [Thu, 5 Nov 2020 07:53:57 +0000 (02:53 -0500)]
nat: fix byte order of vrf_id in logging

Type: fix
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Change-Id: I9930a2a90caa78e848fe657ab2da863467be41ea

3 years agovirtio: move retry logic to outer function 05/29705/4
Damjan Marion [Sat, 31 Oct 2020 21:47:01 +0000 (22:47 +0100)]
virtio: move retry logic to outer function

Improves compile time....

Type: improvement
Change-Id: I310a2e55e5e488a953d65fd065f7795a43d2e9a7
Signed-off-by: Damjan Marion <damarion@cisco.com>
3 years agofeature: reset interface feature arc on interface deletion 51/29751/3
Benoît Ganne [Wed, 4 Nov 2020 09:02:03 +0000 (10:02 +0100)]
feature: reset interface feature arc on interface deletion

When removing an interface we must reset all per-interface per-feature
arc data to ensure we do not get wrong feature arc config data when the
sw_if_index is recycled.

Type: fix

Change-Id: I8c9d850d7c62b7b77193da4258ab5fb9bdda85a6
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agonat: remove unused code 50/29750/2
Klement Sekera [Wed, 4 Nov 2020 17:40:53 +0000 (17:40 +0000)]
nat: remove unused code

Type: improvement
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: Ibbdfb0a2d1ff64044a0f6b2443b526bd1cf12f93

3 years agosession: fix ct server session thread index 55/29755/3
Florin Coras [Wed, 4 Nov 2020 21:08:35 +0000 (13:08 -0800)]
session: fix ct server session thread index

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I835b61f0b88a7324b09d82400debd78ad8b95401

3 years agobuild: better detection of libbpf dependencies 09/29309/4
Benoît Ganne [Thu, 8 Oct 2020 12:08:47 +0000 (14:08 +0200)]
build: better detection of libbpf dependencies

Type: fix

Change-Id: Ib496e6eb0a76e6268aea09d5f4495f3ecd921ec2
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agovlib: add postmortem pcap dispatch trace 34/29734/2
Dave Barach [Tue, 3 Nov 2020 14:59:06 +0000 (09:59 -0500)]
vlib: add postmortem pcap dispatch trace

Inspired by a real-life conundrum: scenario X involves a vpp crash in
ip4-load-balance because vnet_buffer(b)->ip.adj_index[VLIB_TX] is
(still) set to ~0.

The problem takes most of a day to occur, and we need to see the
broken packet's graph trajectory, metadata, etc. to understand the
problem.

Fix a signed/unsigned ASSERT bug in vlib_get_trace_count().

Rename elog_post_mortem_dump() -> vlib_post_mortem_dump(), add
dispatch trace post-mortem dump.

Add FILTER_FLAG_POST_MORTEM so we can (putatively) capture a ludicrous
number of buffer traces, without actually using more than one dispatch
cycle's worth of memory.

Type: improvement

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: If093202ef071df46e290370bd9b33bf6560d30e6

3 years agordma: various fixes for chained buffers tx 32/29732/5
Mohammed Hawari [Mon, 2 Nov 2020 13:05:03 +0000 (14:05 +0100)]
rdma: various fixes for chained buffers tx

Type: fix
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Change-Id: I428c87e581db335362fef30e274db8947a896416

4 years agoikev2: add option to disable NAT traversal 15/29715/5
Filip Tehlar [Fri, 30 Oct 2020 04:47:44 +0000 (04:47 +0000)]
ikev2: add option to disable NAT traversal

Type: feature
Ticket: VPP-1935

Change-Id: I705f84047b112279377590157a1c7b4a34f693d2
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
3 years agoikev2: fix reply during rekey 20/29720/3
Filip Tehlar [Fri, 30 Oct 2020 05:28:11 +0000 (05:28 +0000)]
ikev2: fix reply during rekey

Type: fix

Change-Id: If87f4b8ae92508215fe91178958fe2ddb91e5a35
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
3 years agoikev2: increase tick interval in process node 19/29719/4
Filip Tehlar [Fri, 30 Oct 2020 05:59:55 +0000 (05:59 +0000)]
ikev2: increase tick interval in process node

This helps to resolve sporadic failures in unit tests.

Type: fix

Change-Id: I3abd77ed74310f9729a841e8569eafe6d7758dcb
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
3 years agotls: fix picotls engine crypto multi-thread issue 29/29729/2
Simon Zhang [Tue, 3 Nov 2020 15:48:03 +0000 (23:48 +0800)]
tls: fix picotls engine crypto multi-thread issue

Type: fix

Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: Ib454ccae5a81f91a744db82b72c7f1fcb29aa0cc

3 years agosession: reduce max session node frame size 28/29728/3
Florin Coras [Tue, 3 Nov 2020 03:00:10 +0000 (19:00 -0800)]
session: reduce max session node frame size

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I9e6b5e245533c9ea7bb8dc4f784a31fcb0da88bd

3 years agonat: bihash: fix buckets calc and remove mem param 38/29638/4
Klement Sekera [Mon, 26 Oct 2020 13:42:41 +0000 (13:42 +0000)]
nat: bihash: fix buckets calc and remove mem param

Calculate bihash buckets as n_elts / 2.5 rounded to closest pow2
per Damjan's recommendation. Remove memory configuration parameters
because bihash init ignores them anyway as it resides in main heap now.

Type: improvement
Change-Id: I189f463f3c4640106cce4f12d3c5a62969276a82
Signed-off-by: Klement Sekera <ksekera@cisco.com>
3 years agoikev2: cli for disabling dead peer detection 18/29718/3
Filip Tehlar [Fri, 30 Oct 2020 05:52:19 +0000 (05:52 +0000)]
ikev2: cli for disabling dead peer detection

Type: feature

Change-Id: I0db0a9b2f872753fa64d27335838cb34645a9ee8
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
3 years agonat: fix nat64 disable 48/29548/3
Benoît Ganne [Tue, 20 Oct 2020 12:07:55 +0000 (14:07 +0200)]
nat: fix nat64 disable

 - we should not copy and iterate over the pool underlying vector, as
   slots can be freed (ie in the freelist).
 - delete interface instead of adding them again
 - fix the log message

Type: fix

Change-Id: If0a7a2f475b4f40793eb29ea80a9d29fe5d1bcb9
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agoikev2: fix memory leak 16/29716/2
Filip Tehlar [Fri, 30 Oct 2020 05:00:18 +0000 (05:00 +0000)]
ikev2: fix memory leak

Type: fix

Change-Id: I33c38c791cc9a28898de402ae831c4862073eb2d
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
3 years agoipsec: Tunnel SA DSCP behaviour 48/24148/12
Neale Ranns [Thu, 2 Jan 2020 04:06:10 +0000 (04:06 +0000)]
ipsec: Tunnel SA DSCP behaviour

Type: feature

 - use tunnel_encap_decap_flags to control the copying of DSCP/ECN/etc
during IPSEC tunnel mode encap.
 - use DSCP value to have fixed encap value.

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: If4f51fd4c1dcbb0422aac9bd078e5c14af5bf11f

4 years agovcl: support fifo segments with ct sessions 56/29656/4
Florin Coras [Thu, 29 Oct 2020 04:22:04 +0000 (21:22 -0700)]
vcl: support fifo segments with ct sessions

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Icf0194f569da88f26a4cba29d8fe75a0bddfc144

4 years agosession: fix ct cleanup before full establishement 55/29655/5
Florin Coras [Wed, 28 Oct 2020 23:41:26 +0000 (16:41 -0700)]
session: fix ct cleanup before full establishement

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I58fb0e05f62eae45818c23e8e148ff6758ba463a

4 years agovcl session: minimize ct io events 44/29644/7
Florin Coras [Wed, 28 Oct 2020 07:37:15 +0000 (00:37 -0700)]
vcl session: minimize ct io events

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ic4072fbc182fff38a28b415be0bb16f0559a4064

4 years agotap: fix the segv 49/29649/3
Mohsin Kazmi [Wed, 28 Oct 2020 18:35:53 +0000 (19:35 +0100)]
tap: fix the segv

Type: fix

Change-Id: I53cb96950f8658d7159fb0bd8ecfa50b6977e5af
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agovcl: fix epoll fd cleanup 53/29653/3
Florin Coras [Wed, 28 Oct 2020 19:51:10 +0000 (12:51 -0700)]
vcl: fix epoll fd cleanup

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2886155495ac0e518b9dc09856132cc2f6843503

4 years agobuild: explicitly stop vpp in vpp.preinst 52/29652/1
Dave Barach [Wed, 28 Oct 2020 18:56:12 +0000 (14:56 -0400)]
build: explicitly stop vpp in vpp.preinst

Otherwise, "dpkg -i <vpp-debian-packages>" hangs. This is a new
behavior.

Type: improvement

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I614e6d64b59df1753c8812fdab0f851c8181a7fe

4 years agomisc: Break the big IP header files to improve compile time 34/29634/4
Neale Ranns [Mon, 26 Oct 2020 13:00:06 +0000 (13:00 +0000)]
misc: Break the big IP header files to improve compile time

Type: refactor

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: Id1801519638a9b97175847d7ed58824fb83433d6

4 years agovirtio: fix the buffer array index 46/29646/1
Mohsin Kazmi [Wed, 28 Oct 2020 09:42:32 +0000 (10:42 +0100)]
virtio: fix the buffer array index

Type: fix

Fixes: 2e6f624f1f82ae0351dd05ad5d930d6876105519

Change-Id: I24a9822d1968a134c7e41221f48296cc8a67dd91
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agovcl: postpone unhandled ctrl events if needed 36/29636/8
Florin Coras [Mon, 26 Oct 2020 22:35:40 +0000 (15:35 -0700)]
vcl: postpone unhandled ctrl events if needed

Unhandled control events, i.e., events delivered outside of epoll/select
loops, that need to be propagated to apps should be postponed such that
epoll and select can later deliver them.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I3d05e154382631a16a19e71494c2d92c35dacb70

4 years agosession: per worker state for ct sessions 18/29618/7
Florin Coras [Fri, 23 Oct 2020 23:31:40 +0000 (16:31 -0700)]
session: per worker state for ct sessions

Type: feature

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id6f7b2b969eb50eb7611e4e9ca77b7ef0e0519a1

4 years agovppinfra: clib_mem_vm_{un}map thread safe 27/29627/2
Damjan Marion [Mon, 26 Oct 2020 09:39:30 +0000 (10:39 +0100)]
vppinfra: clib_mem_vm_{un}map thread safe

Type: improvement
Change-Id: I1ab1b100000b4d7212c58e10312e16e7527bd333
Signed-off-by: Damjan Marion <damarion@cisco.com>
4 years agomemif: handle unexpected EPOLLOUT for RX queue 81/29581/4
Steven Luong [Wed, 21 Oct 2020 19:54:29 +0000 (12:54 -0700)]
memif: handle unexpected EPOLLOUT for RX queue

Getting an unexpected EPOLLOUT for RX queue and crashing due to missing
callback function on write_function to handle EPOLLOUT.

(gdb) f 5
f 5
    node=<optimized out>, vm=0x7f948bbe4540 <vlib_global_main>) at /vpp/src/vlib/unix/input.c:325
325       errors[n_errors] = f->write_function (f);
(gdb) p *e
p *e
$21 = {events = 4, data = {ptr = 0x23, fd = 35, u32 = 35, u64 = 35}}
(gdb) p file_main.file_pool[e->data.fd]
p file_main.file_pool[e->data.fd]
$22 = {file_descriptor = 37, flags = 1, polling_thread_index = 0, private_data = 65536,
  read_function = 0x7f944a87b140 <memif_int_fd_read_ready>, write_function = 0x0,
  error_function = 0x0, description = 0x7f944be22400 "memif0/1 rx 0 int", read_events = 0,
  write_events = 1, error_events = 0}
(gdb)

File descriptors are recycled. It is likely that the EPOLLOUT is meant
for the previous owner of the same file descriptor number which memif
recycled and memif RX did not expect to receive an EPOLLOUT. For
defensive play, we create a dummy callback function to ignore the
EPOLLOUT instead of crashing.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I535cadbb9b71d3db2995b118c59a12c71f10af09

4 years agovirtio: improve the compile time 31/29631/3
Mohsin Kazmi [Mon, 26 Oct 2020 11:41:41 +0000 (12:41 +0100)]
virtio: improve the compile time

Type: improvement

packet buffering is common code to tun/tap/virtio.

Change-Id: I59a339f268a28a0c32756e52d10d1ed6b207db42
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agodpdk: allow offline build by caching build-deps 96/29596/3
Mohammed Hawari [Thu, 22 Oct 2020 12:14:04 +0000 (14:14 +0200)]
dpdk: allow offline build by caching build-deps

Change-Id: I40262c640be24f4ca48a2e1461fbc2eb2b0c4c96
Type: fix
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
4 years agovirtio: reduce the compile time for device.c 15/29615/4
Mohsin Kazmi [Fri, 23 Oct 2020 09:23:52 +0000 (11:23 +0200)]
virtio: reduce the compile time for device.c

Type: improvement

GRO is common to tap/tun/virtio devices. Hence move to
common place.

Change-Id: Ibb099f3a80f493ddb934df6bb7640f7c9c370fd5
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agotls: separate init from enable 20/29620/3
Florin Coras [Sun, 25 Oct 2020 21:01:37 +0000 (14:01 -0700)]
tls: separate init from enable

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Icdeddeffd95492ca34f37e1904b1f5f6d150a6bc

4 years agosession: fix feature disable 19/29619/5
Florin Coras [Sun, 25 Oct 2020 21:00:29 +0000 (14:00 -0700)]
session: fix feature disable

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I69e912ddf64d8ec89f8d93e02a201781b99de0bd

4 years agosession: fix ct local listener session index 22/29622/3
Florin Coras [Mon, 26 Oct 2020 02:06:57 +0000 (19:06 -0700)]
session: fix ct local listener session index

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I015443caefb13306858b4ccadeb0b979ea87299a

4 years agovcl: avoid epoll cleanup before app close 24/29624/3
Florin Coras [Mon, 26 Oct 2020 03:28:23 +0000 (20:28 -0700)]
vcl: avoid epoll cleanup before app close

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I09f9faab72e6b77c975b8b79694081216c6ba115

4 years agotcp: byte tracker fix 23/29623/3
Ryujiro Shibuya [Fri, 23 Oct 2020 07:35:53 +0000 (07:35 +0000)]
tcp: byte tracker fix

Type: fix

Signed-off-by: Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>
Change-Id: If7e22978a6b65f5b68ccb2bd97b5e0fba167b3bf

4 years agoavf: use atomic store instead of barrier 28/29628/2
Damjan Marion [Mon, 26 Oct 2020 10:27:13 +0000 (11:27 +0100)]
avf: use atomic store instead of barrier

Type: improvement
Change-Id: Ifea5f0c2fecb99fd320a2e1141f4b4f0d6a793ca
Signed-off-by: Damjan Marion <damarion@cisco.com>
4 years agordma: fix clang-11 build 26/29626/2
Damjan Marion [Mon, 26 Oct 2020 09:05:29 +0000 (10:05 +0100)]
rdma: fix clang-11 build

/vpp/src/plugins/rdma/rdma.h:203:17: error: field 'buffer_template' with variable sized type 'vlib_buffer_t' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
  vlib_buffer_t buffer_template;

Type: fix
Change-Id: I4661839f262e01fe274a2ee7b3cb70f9bc6b7c62
Signed-off-by: Damjan Marion <damarion@cisco.com>
4 years agonat: nat44 cli command fix 32/29632/3
Filip Varga [Mon, 26 Oct 2020 12:05:19 +0000 (13:05 +0100)]
nat: nat44 cli command fix

Type: fix
Change-Id: I4aa0dac544582703316cbcfabe67bcb7dc24d4f7
Signed-off-by: Filip Varga <fivarga@cisco.com>
4 years agofib: API to extract any resolving interface rather than the one from the 29/29629/2
Neale Ranns [Mon, 26 Oct 2020 10:44:54 +0000 (10:44 +0000)]
fib: API to extract any resolving interface rather than the one from the
best source

Type: improvement

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: Iaa91cbc7eba94f4ffbdc249ecdb49770bd2ae916

4 years agovlib: add VLIB_REGISTER_LOG_CLASS macro 17/29617/2
Damjan Marion [Fri, 23 Oct 2020 19:52:50 +0000 (21:52 +0200)]
vlib: add VLIB_REGISTER_LOG_CLASS macro

Type: improvement
Change-Id: Iafcaeb88fa3569e042fb9cb270cf062b145416e2
Signed-off-by: Damjan Marion <damarion@cisco.com>
4 years agopppoe: make pppoe plugin work with dot1q subinterfaces 64/26964/10
zstas [Sat, 9 May 2020 16:57:23 +0000 (16:57 +0000)]
pppoe: make pppoe plugin work with dot1q subinterfaces

- Enabling arc "device-input" with the next node "pppoe-input" on the pppoe cp interface: to get rid of L3_MAC_MISMATCH error
- Parsing in the "pppoe-input" node fixed to parse all headers from the scratch
- Getting mac address directly from encap interface when filling up DPO adjacency. Anyway, in the case of the dot1q subinterface, we need to get vlan tags to fill the DPO adjacency.

Type: improvement

Change-Id: I5405931b0f58bef7b852c079a7e66e0da8b5de0f
Signed-off-by: Stanislav Zaikin <zstaseg@gmail.com>
4 years agovmxnet3: vmxnet3_dump is broken 36/29536/2
Steven Luong [Tue, 20 Oct 2020 00:21:10 +0000 (17:21 -0700)]
vmxnet3: vmxnet3_dump is broken

control ping id was not set

Fixes: gerrit 22396 / I009e806997461ad790f125d6359993862e1c5e5d
Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I6e96533f150da4bd0e651b5572345246623ae0ad

4 years agoaf_xdp: add option to claim all available rx queues 49/28849/2
Benoît Ganne [Tue, 15 Sep 2020 13:25:43 +0000 (15:25 +0200)]
af_xdp: add option to claim all available rx queues

Type: feature

Change-Id: I97176c2c90ea664a68078b3a7b7d44eb237a7f13
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agoipsec: remove pending node 28/29528/3
Fan Zhang [Mon, 19 Oct 2020 12:08:34 +0000 (13:08 +0100)]
ipsec: remove pending node

This patch removes esp-encrypt-pending and esp-decrypt-pending
graph nodes from ipsec data-path.

Type: improvement

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: Icd90837eafdbfbfdf348681dcafb872593978980

4 years agovrrp: asynchronous events on VR state change 15/29315/3
Matthew Smith [Thu, 8 Oct 2020 16:11:27 +0000 (11:11 -0500)]
vrrp: asynchronous events on VR state change

Type: feature

Add API message for an API client to subscribe/unsubscribe to receive
an event when a VRRP VR changes state. Add code to build and send the
events.

Change-Id: Ie92cadd4850d4352c1aaa79c4b0a7daa0f3b04e7
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
4 years agordma: implement striding rq for multiseg rx 75/29575/3
Mohammed Hawari [Wed, 21 Oct 2020 12:48:38 +0000 (14:48 +0200)]
rdma: implement striding rq for multiseg rx

This change leverages the striding RQ feature of
ConnectX-5 adapters to support chained buffers on
the RX path. In Striding RQ mode, WQE are SG lists
of data segments, each mapped to a vlib_buffer.
When a packet is received, it can consume one or
multiple data segments belonging to the WQE,
without wasting the whole WQE.

Change-Id: I74eba5b2c2c66538e75e046335058ba011cb27fd
Type: improvement
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
4 years agordma: add RSS support for IPv6 and TCP 85/29485/2
Benoît Ganne [Fri, 16 Oct 2020 15:12:41 +0000 (17:12 +0200)]
rdma: add RSS support for IPv6 and TCP

Type: feature

Change-Id: I8b0d918e6f13325954b29bf34e4ef224c1315c51
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agobuild: add compile_commands.json cleanup script 14/29614/3
Damjan Marion [Fri, 23 Oct 2020 15:20:32 +0000 (17:20 +0200)]
build: add compile_commands.json cleanup script

Type: make
Change-Id: I8d6a5018bddf029e106df3cb8b8eded4fa28067d
Signed-off-by: Damjan Marion <damarion@cisco.com>
4 years agocnat: coverity fix 13/29613/2
Nathan Skrzypczak [Fri, 23 Oct 2020 15:03:14 +0000 (17:03 +0200)]
cnat: coverity fix

Type: fix

Change-Id: Ie1153a0e0f1e9770bf3e0de9291131db91724b2e
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agolb: Loadbalancer plugin, correctly rewrite checksum in L3DSR, non-TCP cases 73/28673/6
Hiroki Narukawa [Fri, 4 Sep 2020 06:41:40 +0000 (15:41 +0900)]
lb: Loadbalancer plugin, correctly rewrite checksum in L3DSR, non-TCP cases

Current loadbalancer seems to rewrite the 17th and 18th octet of L4 header regardless of which kind of L4 protocol is used in case of L3DSR.

In case UDP, it rewrites 9th and 10th octet of payload (because UDP header is 8 octets long). If UDP payload is less than 8 octets, UDP checksum becomes invalid.

In other protocols similar problems is likely to occue.

This patch checks which L4 protocol is used, and rewrite packet regarding the L4 protocol.

Signed-off-by: Hiroki Narukawa <nhirokinet@nhiroki.net>
Change-Id: I84390ff58a33f05efac0421856beea89014adc72
Type: fix

4 years agovmxnet3: add sw_if_index filter to vmxnet3 interface dump 85/29585/3
Steven Luong [Wed, 21 Oct 2020 23:55:49 +0000 (16:55 -0700)]
vmxnet3: add sw_if_index filter to vmxnet3 interface dump

Introduce a replacement API for vmxnet3_dump which supports interface
filter.

Type: improvement

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I76074db2aa34b397ce570a2019c43e042a9c7838

4 years agovlib: log: fix non-null terminated strings 89/29589/3
jiangxiaoming [Thu, 22 Oct 2020 02:08:36 +0000 (10:08 +0800)]
vlib: log: fix non-null terminated strings

Type: fix
Signed-off-by: jiangxiaoming <jiangxiaoming@outlook.com>
Change-Id: Id61966048875ca56a416caa520125c8c2366bf7b

4 years agotcp: remove snd_una_max 16/29616/3
Florin Coras [Fri, 23 Oct 2020 17:45:48 +0000 (10:45 -0700)]
tcp: remove snd_una_max

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I03f923053499f219035c9b7b6640fc575568d474

4 years agotcp: remove force retransmit timer update 00/29600/7
Florin Coras [Thu, 22 Oct 2020 18:22:22 +0000 (11:22 -0700)]
tcp: remove force retransmit timer update

Also simplify condition for detecting unintended timer pops.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I8b120dfc2d16e40ee865240dbc9667708cd1c808

4 years agobuild: fix typo in dpdk-20.08 patch #0003 08/29508/1
Dave Wallace [Fri, 23 Oct 2020 13:35:12 +0000 (09:35 -0400)]
build: fix typo in dpdk-20.08 patch #0003

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Id0b3264e723f1df161a606e4dbdcd70c36d448a4
(cherry picked from commit ee3ea114961610476bac544a979fdee8278d2b9e)

4 years agotcp: remove delack time config 03/29603/2
Florin Coras [Thu, 22 Oct 2020 22:49:05 +0000 (15:49 -0700)]
tcp: remove delack time config

Type: refactor

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iae5045686c62ad9279be350cffeaa41b8297d179

4 years agonat: nat44 enable/disable dynamic config 63/29463/5
Filip Varga [Wed, 30 Sep 2020 20:24:47 +0000 (22:24 +0200)]
nat: nat44 enable/disable dynamic config

This patch changes initialization and configuration of NAT
plugin. Instead of allocating data structures at vpp plugin
initialization phase allocation and configuration happens
after calling enable API or CLI call. This reduces base VPP
memory footprint and also enables dynamic reconfiguration
of the NAT plugin.

Type: improvement
Change-Id: I42c069ee19a0311d043ac1f3f230d87bc8d2680f
Signed-off-by: Filip Varga <fivarga@cisco.com>