sharath reddy [Wed, 29 Nov 2017 14:38:11 +0000 (20:08 +0530)]
VPP-273 Coding standards cleanup - vnet/vnet/unix
Change-Id: Ibac5a4588e66f6d3ad42dd2583e1e84b7d2314c4
Signed-off-by: sharath reddy <sharathkumarboyanapally@gmail.com>
Swarup Nayak [Tue, 5 Dec 2017 04:16:17 +0000 (09:46 +0530)]
call unformat_free in some flow, remove unnecessary calls
Change-Id: I565277eafbce3d4f59a7f0d497fca1c4fed3cfc8
Signed-off-by: Swarup Nayak <swarupnpvt@gmail.com>
Florin Coras [Sat, 9 Dec 2017 16:15:00 +0000 (08:15 -0800)]
vcl: fix session preallocation
Change-Id: I174ba43380e97104f6721af647c699922e996f5a
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Sun, 10 Dec 2017 22:54:46 +0000 (23:54 +0100)]
vlib: fix issues in the new pci code reported by coverity
Change-Id: I8acc5c419b6ad01937c3aecec42801463d4a119a
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Sun, 10 Dec 2017 13:32:31 +0000 (05:32 -0800)]
BIER coverity Fix
Change-Id: I17f95775756b8fd5ee390432f6d8041abbd9f974
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Sat, 9 Dec 2017 20:19:01 +0000 (21:19 +0100)]
tap_v2: fix issues reported by coverity
Change-Id: I1bbd3f6ece255edfd4ebf268ac60f79dce1d10e7
Signed-off-by: Damjan Marion <damarion@cisco.com>
Klement Sekera [Sun, 10 Dec 2017 04:15:41 +0000 (05:15 +0100)]
improve vapi json parser error handling
Change-Id: I39b975e6dc3b3ed1f81c1736ed498aee05f6a88b
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Andreas Schultz [Fri, 8 Dec 2017 15:35:56 +0000 (16:35 +0100)]
update builtin UDP server to new vnet_session API
* app_index has to be valid
* vnet_session needs to be enabled before binding
Change-Id: I410a25153e650d8bc332131a81bf46a0175566d4
Signed-off-by: Andreas Schultz <aschultz@warp10.net>
Andreas Schultz [Fri, 8 Dec 2017 14:12:36 +0000 (15:12 +0100)]
make sure the very first fragment triggers an rx_callback
On the first session server, the first payload packet gets queued
but the Rx callback will only be invoked when the second packet
is received.
By initializing enqueue_epoch in the session, we can make sure that
the RX callback will be invoked for the first packet as well.
Change-Id: I60e2cf8d4d2ca71d461ca003d459c8e6e6956a4d
Signed-off-by: Andreas Schultz <aschultz@warp10.net>
Swarup Nayak [Mon, 4 Dec 2017 06:24:43 +0000 (11:54 +0530)]
VPP-1077 Add meaningful error info, when executing command with enable/disable option
Change-Id: I47dd6f9637f0214971e3191852d84aa92d64b8c0
Signed-off-by: Swarup Nayak <swarupnpvt@gmail.com>
Neale Ranns [Tue, 5 Dec 2017 21:24:04 +0000 (13:24 -0800)]
BIER in non-MPLS netowrks
as decsribed in section 2.2
ihttps://tools.ietf.org/html/draft-ietf-bier-mpls-encapsulation-10
with BIFT encoding from:
https://tools.ietf.org/html/draft-wijnandsxu-bier-non-mpls-bift-encoding-00
changes:
1 - introduce the new BIFT lookup table. BIER tables that have an associated
MPLS label are added to the MPLS-FIB. Those that don't are added to the
BIER table
2 - BIER routes that have no associated output MPLS label will add a BIFT label.
3 - The BIER FMask has a path-list as a member to resolve via any possible path.
Change-Id: I1fd4d9dbd074f0e855c16e9329b81460ebe1efce
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Thu, 5 Oct 2017 13:32:41 +0000 (15:32 +0200)]
vlib: PCI rework to support VFIO
Also fixes old ixge driver, so it works with recent physmem changes and
vfio.
Change-Id: Id4be74b34daed47cd281a77eec43d6692340d882
Signed-off-by: Damjan Marion <damarion@cisco.com>
khemendra kumar [Fri, 8 Dec 2017 12:36:52 +0000 (18:06 +0530)]
VPP-249 Coding standards cleanup - vnet/vnet/dhcp
Change-Id: I45a166b5780675d2bc6fe90595f413725704eaa8
Signed-off-by: khemendra kumar <khemendra.kumar13@gmail.com>
Marek Gradzki [Fri, 8 Dec 2017 14:26:55 +0000 (15:26 +0100)]
jvpp: include all api files from @top_builddir@/vpp
Currently:
- vpe.api (supported previously)
- stats.api
- oam.api
Change-Id: Iab48d5d142e9a1ea0a4f366352b1d9429cc47309
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 7 Dec 2017 14:40:11 +0000 (15:40 +0100)]
jvpp: do not hardcode event sufixes (VPP-940)
JVpp maps request messages with replies
for Java API user convenience, e.g.:
- do not polute send APIs with messages other than requests/dumps,
- allow callback registration only for replies/details and events.
Since there are no conventions for event message naming
(https://wiki.fd.io/view/VPP/API_Concepts#API_Conventions),
jvpp should not limit events to messages
that end with 'event' or 'counters' suffix.
Instead jvpp should treat all messages
except for requests/dumps as potential events.
Such behaviour was introduced on Java API level by
https://gerrit.fd.io/r/#/c/8377/
in order support reusing
details messages as events (e.g. BFD events).
This patch goes one step forward by
relaxing rules at jvpp generation level.
Change-Id: I2a35e9eb2a288b2cf02d36ca95e6cb13e76e19e3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Neale Ranns [Fri, 8 Dec 2017 21:53:41 +0000 (13:53 -0800)]
Remove the unused 'create VRF if needed' API parameters
Change-Id: I35e166feeb0ac1e0e570efe07cb5f4cbeb5b8670
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Damjan Marion [Mon, 4 Dec 2017 19:03:37 +0000 (20:03 +0100)]
tapv2: multiple improvements
- change interface naming scheme
- rework netlink code
- add option to set link address, namespace
Change-Id: Icf667babb3077a07617b0b87c45c957e345cb4d1
Signed-off-by: Damjan Marion <damarion@cisco.com>
Sergio Gonzalez Monroy [Fri, 8 Dec 2017 11:25:13 +0000 (11:25 +0000)]
vppinfra: fix issues depending on compiler
It looks like different compiler versions produce different results for
expressions like "(cast) ptr + inc".
Use parenthesis to avoid such issues.
Change-Id: I93a9883bf5fc05ae462df5b004817775f0739405
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Klement Sekera [Wed, 8 Nov 2017 03:13:49 +0000 (04:13 +0100)]
punt: fix tracing for partially traced chains
This fixes a crash if the first buffer in buffer chain is not traced,
but some other buffer (mid-chain) is.
Change-Id: I2c9f529ae0bc3263d20981e0cb83ce24ed292bd8
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Mohsin Kazmi [Tue, 5 Dec 2017 13:48:58 +0000 (14:48 +0100)]
vom: acl-l3: Fix pretty print for TCP mask and flags
Change-Id: If14d1b2d9b73de77321d94f10d48fa1bb04846f6
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Neale Ranns [Thu, 7 Dec 2017 16:48:02 +0000 (08:48 -0800)]
VOM: prefix bit fiddling
Change-Id: I4fbf4a574f455628d56e78cefc1a76adc06bc801
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Marek Gradzki [Thu, 7 Dec 2017 16:17:35 +0000 (17:17 +0100)]
jvpp: unify notification handling
Since introduction of dedicated SW Interface Event,
there is no need for special handling of messages
that can be both requests and events.
Change-Id: I76575e32c6d5b19e9a1ca953e5841d8ac3de4de7
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Marek Gradzki [Thu, 7 Dec 2017 15:49:26 +0000 (16:49 +0100)]
jvpp: remove special request<>reply mappings
Since L2FibTable removal
and introduction of dedicated SW Interface Event,
special message handling code can be removed.
The patch also fixes issues
found by Intelij's code inspection tool.
Change-Id: Ic4b2fd12ac30c7627f4cd6769716e4bb52ec0b10
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Swarup Nayak [Wed, 6 Dec 2017 13:25:43 +0000 (18:55 +0530)]
Corrected help string of show ip punt
Change-Id: I32ec3ff341e70ceaa6203df5a9e7c3ffdae20a06
Signed-off-by: Swarup Nayak <swarupnpvt@gmail.com>
satish.karunanithi [Wed, 6 Dec 2017 10:41:59 +0000 (16:11 +0530)]
VPP-259 Coding standards cleanup - vnet/vnet/lawful-intercept
Change-Id: Ie750c9fe06c067226b90bdcc3ea423b74d16562d
Signed-off-by: satish.karunanithi <satish.fdio@gmail.com>
Neale Ranns [Wed, 6 Dec 2017 08:45:33 +0000 (00:45 -0800)]
Label stack size exceeded fix
Change-Id: Ibe2041d83e9b5be16801dc316bd472ae4f6e8c31
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Thu, 23 Nov 2017 03:22:48 +0000 (19:22 -0800)]
session: support for rule tags overwriting
Change-Id: I0cf48b69042996afcb8b192f5fd98165058d9e1d
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ole Troan [Wed, 6 Dec 2017 16:00:05 +0000 (17:00 +0100)]
UT: Repaired broken C unit tests (--enable-tests)
Change-Id: I63d720378b92813993525f80fee90fc79df27fba
Signed-off-by: Ole Troan <ot@cisco.com>
Hongjun Ni [Mon, 13 Nov 2017 12:34:06 +0000 (20:34 +0800)]
Restructure some files in LB to src/vnet to reuse
Change-Id: Ic8b193e93ce18ca82b294816aa7ee0ef31d64bc2
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
Dave Barach [Tue, 5 Dec 2017 17:21:59 +0000 (12:21 -0500)]
Remove unused, uninteresting code
Move elog_sample.c to src/examples/vlib
Change-Id: I7d32c83c424b9ca4a057372c7fc6a6e2b7dab034
Signed-off-by: Dave Barach <dave@barachs.net>
Dave Barach [Tue, 5 Dec 2017 19:48:56 +0000 (14:48 -0500)]
make clib_maplog_update_header(...) globally accessible
clib_maplog_process(...): handle logs which weren't closed properly.
It will happen.
Change-Id: Ibcf9c9ea7a09991e6294050e7d2979a0d3f965cf
Signed-off-by: Dave Barach <dave@barachs.net>
Neale Ranns [Tue, 5 Dec 2017 21:34:36 +0000 (13:34 -0800)]
fix bug in pager
the format statement can return NULL before the pager has pages.
Change-Id: Ibabfd107e64fc9ab0eb142c28c155506f0d25828
Signed-off-by: Neale Ranns <nranns@cisco.com>
Gabriel Ganne [Tue, 5 Dec 2017 13:26:33 +0000 (14:26 +0100)]
fill "show cpu" Flag list on aarch64 platforms (VPP-1065)
use getauxval(AT_HWCAP) to get the processor capabilities.
The result should be the same as calling
cat /proc/cpuinfo | grep Feature | head -n1
All but one (aes) features have a different name.
handle aes by adding it an arch prefix, which is skipped during print
and a clib_cpu_supports_aes() custom function.
Change-Id: If9830bd5a17bac1bd1b5337dacbb0ddbb8ed6b18
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
Milan Lenco [Tue, 5 Dec 2017 11:18:15 +0000 (12:18 +0100)]
tap_v2: convert ring size from network to host order
Change-Id: Ica1be5c75c83ac64c7063bfeff1f4d00702a00e1
Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech>
Sergio Gonzalez Monroy [Sun, 26 Nov 2017 15:25:43 +0000 (15:25 +0000)]
dpdk/ipsec: multiple fixes
- fix ESP transport mode
- safely free crypto sessions
- use rte_mempool_virt2phy/rte_mempool_virt2iova
- align DPDK QAT capabilities for IPsec usage (DPDK 17.08)
- reserve 16B for aad (reference cryptodev doc)
Change-Id: I3822a7456fb5a255c767f5a44a429f91a140fe64
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Eyal Bari [Mon, 4 Dec 2017 17:58:12 +0000 (19:58 +0200)]
dpdk:remove duplicate code
unify code from both branches
Change-Id: Iae7325cff8c799c7827727ad7465bec089e39f50
Signed-off-by: Eyal Bari <ebari@cisco.com>
Gabriel Ganne [Tue, 5 Dec 2017 14:14:07 +0000 (15:14 +0100)]
remove smp dead code (VPP-1066)
this follows commit
01d86c7f6f05938c7d3fe181bd0aa2f75ccdd1df
which removed many unused functions from smp.h
Change-Id: I3aa0954a5e2319cc526fa68dda113f3cbe063960
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
Neale Ranns [Mon, 4 Dec 2017 20:00:30 +0000 (20:00 +0000)]
Revert "FIB: optimise for src memory allocations"
This reverts commit
84517cfd1508f6da24937f310f7fffe752f22584.
Change-Id: Ic7eeffa2ed4607d3d653f34b93c20c833c789ee1
Signed-off-by: Neale Ranns <nranns@cisco.com>
Steven [Mon, 4 Dec 2017 07:40:54 +0000 (23:40 -0800)]
vnet: set vnet_buffer l2_hdr_offset and l3_hdr_offset
Changes made in ethernet_input to set l2_hdr_offset,l3_hdr_offset, and
their corresponding flags.
Please note that ethernet_input, as a critical DP, incurs a few extra cpu
cycles due to this patch, but for a worthy cause.
Change-Id: Ie9ae352ea62959d2779ebcca98a1898e3d9e1d6f
Signed-off-by: Steven <sluong@cisco.com>
Eyal Bari [Mon, 4 Dec 2017 11:57:45 +0000 (13:57 +0200)]
vlib: switch when frames are different
[ebari] no need to switch if next2, next3 are equal to next_index
[dbarach] change fix_speculation calculaton to a branch-free xor/or tree
Change-Id: I0131dc4499218363d5b0ce8f6440ce74e0b22bb9
Signed-off-by: Eyal Bari <ebari@cisco.com>
Signed-off-by: Dave Barach <dave@barachs.net>
Damjan Marion [Mon, 4 Dec 2017 14:25:58 +0000 (15:25 +0100)]
tap_v2: move code to vnet/devices/tap
virtio backend stays in vnet/devices/virtio
Change-Id: Idbf04f1c645a809ed408670ba330662859fe9309
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Mon, 4 Dec 2017 14:14:52 +0000 (15:14 +0100)]
tapcli: change interface name
As tapcli code is going to be deprecated and replaced with tap v2 code,
change the interface naming so the new code can use form tap-X.
Change-Id: I2684a880c037caee677927214752c00cf97f63f6
Signed-off-by: Damjan Marion <damarion@cisco.com>
Eyal Bari [Mon, 4 Dec 2017 14:40:30 +0000 (16:40 +0200)]
dpdk: remove unused "use_rss" flag
Change-Id: I31d2cbb02a0f59603ef1adc0d185e3d775dfda2f
Signed-off-by: Eyal Bari <ebari@cisco.com>
Eyal Bari [Mon, 4 Dec 2017 12:50:29 +0000 (14:50 +0200)]
dpdk: remove duplicate function
dpdk_rx_next_from_packet_start is equivalent to dpdk_rx_next_from_etype and seems to have no side effects
Change-Id: I629dadfbfb35ad1f5c7198e7824883ae4bd6abaa
Signed-off-by: Eyal Bari <ebari@cisco.com>
Eyal Bari [Mon, 4 Dec 2017 12:04:57 +0000 (14:04 +0200)]
dpdk: remove unused cached eth input node
Change-Id: Ic43c70bfe3e93cb3e6cfab7cda1986e44e371c06
Signed-off-by: Eyal Bari <ebari@cisco.com>
Renato Botelho do Couto [Thu, 30 Nov 2017 21:41:22 +0000 (15:41 -0600)]
Optimize RPM build process
* Remove unused variable OS_VERSION_ID
* Do all RPM building in build-root/rpmbuild
* Add build-root/rpmbuild to .gitignore
* Move redundant code to a target called 'spec'
* Copy spec file to SPECS instead of SOURCES
* Only set %{_topdir} macro when it's undefined, and because of that
remove sed call to delete definition on spec file
* Pass _version and _release using --define parameter instead of using
sed to add them to .spec
* Move rpm files to build-root after build finishes
* Add dist tarball to .gitignore
Change-Id: I230d60b62914056b353f7f8701d14754b0bf7f8c
Signed-off-by: Renato Botelho do Couto <renato@netgate.com>
Steven [Sun, 3 Dec 2017 04:17:27 +0000 (20:17 -0800)]
tap_v2: coverity strikes, again!
fd is not close when IOCTL encounters an error which causes resource
leak. The fix is to initialize fd to -1. At return, close fd if
it has a valid value.
Change-Id: I53c4f5c71ca0f556fb6586f5849e7cb622632d8f
Signed-off-by: Steven <sluong@cisco.com>
Jan Gelety [Mon, 4 Dec 2017 08:24:07 +0000 (09:24 +0100)]
Update CSIT tests 171127 -> 171204
- update of CSIT operational branch to be used for VPP-patch test
Change-Id: I9a154daa661fc5f2f1e7c2eeb77a4bb08d4e34be
Signed-off-by: Jan Gelety <jgelety@cisco.com>
Damjan Marion [Mon, 4 Dec 2017 10:23:58 +0000 (11:23 +0100)]
virtio: zero data structs in virtio_vring_init
Change-Id: I877cf1abb062a90f428c3ec0cab5c6e9dad0ca82
Signed-off-by: Damjan Marion <damarion@cisco.com>
Dave Barach [Fri, 1 Dec 2017 21:20:32 +0000 (16:20 -0500)]
maplog headers, offline processing, doxygen tags
Change-Id: I0545018ec02f3706ad6a2da6fc13537db5c31a2d
Signed-off-by: Dave Barach <dave@barachs.net>
Mohsin Kazmi [Fri, 1 Dec 2017 14:12:57 +0000 (15:12 +0100)]
VOM: l2fib: Add bvi flag support
Change-Id: I03d7508649e80a538fcf9541815e2c29224bc87a
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Damjan Marion [Fri, 1 Dec 2017 12:34:24 +0000 (13:34 +0100)]
tap_v2: multiple improvements
- add support for assigning tap interface to the bridge
- add support for assigning tap interface host side ip4 and ip6 address
- host namespace can be specified as PID (pid:12345) or full path to file
- automatically bring linux interface up
Change-Id: I1cf7c3cad9a740e430cc1b9c2bb0aad0ba4cc8d8
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Fri, 1 Dec 2017 12:54:06 +0000 (04:54 -0800)]
gpe: fix gpe enable/disable command
Return error if not input provided.
Change-Id: I4a68fafaf4efd74395e513baa7f18fa55b83de87
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Thu, 30 Nov 2017 21:07:39 +0000 (16:07 -0500)]
session: allocate cb messages from client ring
Change-Id: Ib644a1840c5f24203b6968561f467fbe5e255055
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Barach [Fri, 1 Dec 2017 15:24:28 +0000 (10:24 -0500)]
Coverity warning be gone
Change-Id: I0946c0a124f3fc9a0aa87499a35edfeaabaec932
Signed-off-by: Dave Barach <dave@barachs.net>
Steven [Fri, 1 Dec 2017 14:58:56 +0000 (06:58 -0800)]
vnet: fix a typo in vnet/buffer.c
vnet_buffer->l3_hdr_offset should be displayed as l3-hdr-offset,
not l2-hdr-offset.
Change-Id: Ib8ec9d17a1b4167a2204002023ba2260e8ba36c4
Signed-off-by: Steven <sluong@cisco.com>
Steven [Fri, 1 Dec 2017 00:56:54 +0000 (16:56 -0800)]
virtio: fix coverity warnings
Fix 3 coverity warnings
1. api_format.c: init net_ns = 0 and remove its corresponding vec_add and
vec_free
2. netlink.c (reported in tap.c before the code was removed): resource leaked
due to fd is not close
3. tap.c: subtract 1 for size when calling strncpy to accommodate the
terminated NULL character
Change-Id: Iff4e66604862f0c06dac227b8cfd48d3979e41a5
Signed-off-by: Steven <sluong@cisco.com>
Neale Ranns [Fri, 1 Dec 2017 08:19:43 +0000 (00:19 -0800)]
VOM: fixes for interface recreate on agent restart and L2 re-binding
Change-Id: I14c838ee99f9bc2db66bb2e775039d2cb2e7924f
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Andrew Yourtchenko [Tue, 28 Nov 2017 21:14:16 +0000 (22:14 +0100)]
acl-plugin: fix coverity 177970-177973,178891, and incorrect reset of dot1q/dot1ad classifier mask
17797[1-3] have been a false positive in the optional debug CLI argument handling,
178891 was triggered by an unnecessary use of memcpy.
Also fix the issue reported by khers (thanks!) - since 178891 was in the same place.
Change-Id: I3a804e2b1d25d74c11fcc389020d2c1fd69902b2
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Damjan Marion [Thu, 30 Nov 2017 19:56:37 +0000 (20:56 +0100)]
tap_v2: move netlink code to separate file
Change-Id: Ib091875f77ea99421aec0947fd17833c4e6d2ec2
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Tue, 21 Nov 2017 15:22:55 +0000 (16:22 +0100)]
dpdk: bump to 17.11
Change-Id: I84fafa369c6f16295e1c24d9712de2229bf78a91
Signed-off-by: Damjan Marion <damarion@cisco.com>
Matus Fabian [Tue, 28 Nov 2017 12:29:41 +0000 (04:29 -0800)]
NAT44: identity NAT (VPP-1073)
Identity mapping translate an IP address to itself.
Change-Id: Icc0ca5102d32547a4b0c75720b5f5bf41ed69c71
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Damjan Marion [Fri, 13 Oct 2017 16:29:53 +0000 (18:29 +0200)]
virtio: fast TAP interfaces with vhost-net backend
Change-Id: Ided667356d5c6fb9648eb34685aabd6b16a598b7
Signed-off-by: Damjan Marion <damarion@cisco.com>
Signed-off-by: Steven Luong <sluong@cisco.com>
Neale Ranns [Tue, 28 Nov 2017 12:36:37 +0000 (04:36 -0800)]
Fix CLI path parsing for via interface only
before:
DBGvpp# ip route add 1.1.1.1/32 via mpls-tunnel0
ip route add 1.1.1.1/32 via mpls-tunnel0
ip route: parse error `via mpls-tunnel0'
DBGvpp# ip route add 1.1.1.1/32 via via mpls-tunnel0
ip route add 1.1.1.1/32 via via mpls-tunnel0
after:
DBGvpp# ip route add 1.1.1.1/32 via via mpls-tunnel1
ip route add 1.1.1.1/32 via via mpls-tunnel1
Change-Id: I2185a82fcf0799d59de9cb16e09b7f297faffab9
Signed-off-by: Neale Ranns <nranns@cisco.com>
Juraj Sloboda [Wed, 29 Nov 2017 15:15:25 +0000 (16:15 +0100)]
Fix variable mismatch
Change-Id: Iae2f9f9652cecdf7e754700b2fe107ad61ff8ff9
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
Marco Varlese [Wed, 29 Nov 2017 15:13:04 +0000 (16:13 +0100)]
Cleanup and simplify
This patch addresses two things:
1) It simplifies the Makefile to build RPMs by removing duplication and
use environment variables instead;
2) It aligns openSUSE with others with regards to invoke "pkg-rpm" by
the build.sh for Vagrant
Change-Id: I51557f54e4ddf49d83bb69fa0035c8fff122857e
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Florin Coras [Tue, 28 Nov 2017 19:59:20 +0000 (11:59 -0800)]
af_packet: update tx_frame even when ring exhausted
Change-Id: I2fde74b53d6b4dc54d4af7020130f7b22463d70f
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Wallace [Thu, 30 Nov 2017 03:46:32 +0000 (22:46 -0500)]
VCL: add vpp api q length to config file.
Change-Id: Ibe3e6cea0ea2fc700ef0a284c8ea5fe5d5476514
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Dave Barach [Wed, 29 Nov 2017 21:59:01 +0000 (16:59 -0500)]
mmap-based fixed-size record double-buffered logger
Change-Id: I760b482b9de457bbb17de817db7079b57d3f5ec1
Signed-off-by: Dave Barach <dave@barachs.net>
Dave Wallace [Mon, 27 Nov 2017 22:07:51 +0000 (17:07 -0500)]
VCL-LDPRELOAD: Fix connect return value handling.
Change-Id: I51d82f39d450834f0ba4d9415aa3e62eb61fc1e9
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Dave Wallace [Wed, 29 Nov 2017 08:24:06 +0000 (03:24 -0500)]
VCL: drain the vpp app event queue.
Change-Id: If988b8ad33465819d0e5ab9ef92ffd69b3c7851c
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Neale Ranns [Wed, 29 Nov 2017 10:39:53 +0000 (02:39 -0800)]
Add some indent-off to the node declarations in ip4-forward
Change-Id: Icab8f1411da22bd56ef0de3b100eaa9519a42f52
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Wed, 29 Nov 2017 05:07:11 +0000 (00:07 -0500)]
session: fix preallocation of local endpoint table
Change-Id: I67a73e31bda9e497859297fcc1765e880572884a
Signed-off-by: Florin Coras <fcoras@cisco.com>
Matus Fabian [Wed, 29 Nov 2017 07:27:36 +0000 (23:27 -0800)]
NAT: Remove old SNAT API (VPP-1070)
Change-Id: I3d936d456ee27b2e0857843295efb60a9f2d0be7
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Damjan Marion [Wed, 29 Nov 2017 11:28:38 +0000 (12:28 +0100)]
Revert "Dpdk: 17.08 tarball updated 11/27"
DPDK tarball was changed by mistake and now it is reverted back.
This reverts commit
3d786efcb087533320e89f80077127fc507cfd99.
Change-Id: I1a07b96fbc3f4fe13bb4a5c401036cae4ac5d346
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Wed, 29 Nov 2017 08:59:31 +0000 (00:59 -0800)]
Include allocated table memory in 'sh fib mem' output
DBGvpp# sh fib mem
FIB memory
Tables:
SAFI Number Bytes
IPv4 unicast 2 673066
IPv6 unicast 2
1054608
MPLS 1
4194312
IPv4 multicast 2 2322
IPv6 multicast 2 ???
Nodes:
Name Size in-use /allocated totals
Entry 96 20 / 20 1920/1920
Entry Source 32 0 / 0 0/0
Entry Path-Extensions 60 0 / 0 0/0
multicast-Entry 192 12 / 12 2304/2304
Path-list 40 28 / 28 1120/1120
uRPF-list 16 20 / 20 320/320
Path 72 28 / 28 2016/2016
Node-list elements 20 28 / 28 560/560
Node-list heads 8 30 / 30 240/240
Change-Id: I8c8f6f1c87502a40265bf4f302d0daef111a4a4e
Signed-off-by: Neale Ranns <nranns@cisco.com>
“mukeshyadav1984” [Tue, 28 Nov 2017 18:52:34 +0000 (10:52 -0800)]
DES-CBC/3DES-CBC support for VPP IPSec Core
Change-Id: I876f215b129e5e59d3acc6447ce40458cc341eba
Signed-off-by: “mukeshyadav1984” <mukyadav@cisco.com>
Marco Varlese [Tue, 28 Nov 2017 13:50:45 +0000 (14:50 +0100)]
Using $(CURDIR) to fix the absolute path issue
Change-Id: Ic26edd34a2980fc8cf34514433a7b7076660316e
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Dave Barach [Tue, 28 Nov 2017 23:55:09 +0000 (18:55 -0500)]
Configure vat-plugin-path and vat-plugin-name-filter
To facilitate in-tree plugin API testing, via the "binary-api..."
debug CLI command.
Change-Id: If7ee88a6a0dbc8e8f4555cb41e259db24e378a64
Signed-off-by: Dave Barach <dave@barachs.net>
Ed Kern [Tue, 28 Nov 2017 18:17:00 +0000 (11:17 -0700)]
Dpdk: 17.08 tarball updated 11/27
The dpdk package posted on static.dpdk.org for 17.08
was updated 11/27. This updates the checksum thats
statically included in makefile. Looks like they
also changed the dir structure to add -stable.
fast.dpdk.org has issues with its mirrors being in
sync...changing to static.dpdk.org for now
Change-Id: Id81e328b07873700ae3f76e1ca819f94f26f38c8
Signed-off-by: Ed Kern <ejk@cisco.com>
Neale Ranns [Wed, 29 Nov 2017 06:29:13 +0000 (22:29 -0800)]
VOM: logging, populate and stats fixes
logging: allow a client to register a callback handler to recieve log messages
that way the client can maintain a correctly sequenced log
populate: fix the creation of interface and the setting of the handle
stats: the reset promise idea is not defined behaviour.
Use an eanble/disable command pair
Change-Id: I347720bb65df2874c7619e722d593bc863ee2bf1
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Florin Coras [Wed, 29 Nov 2017 00:35:44 +0000 (19:35 -0500)]
Make whole version string available in core files
Change-Id: I1f292e6035e1ff9e7bdca8f0a9275ebd3d4d8d0a
Signed-off-by: Florin Coras <fcoras@cisco.com>
khemendra kumar [Mon, 27 Nov 2017 09:45:53 +0000 (15:15 +0530)]
VPP-246 Coding standards cleanup - vnet/vnet/classify
Signed-off-by: khemendra kumar <khemendra.kumar13@gmail.com>
Change-Id: I0d94ef604d34da6981e7c2d2b4da5ec3ec5fb19a
Krishanpal singh [Thu, 23 Nov 2017 13:13:08 +0000 (18:43 +0530)]
VPP-268 Coding standards cleanup - vnet/vnet/plugin
Change-Id: Ida719f3997cb14ad869e97f6d8de301a0d19c370
Signed-off-by: Krishanpal singh <krish.singh03@gmail.com>
Dave Barach [Tue, 28 Nov 2017 15:11:42 +0000 (10:11 -0500)]
Shut down session queue input nodes on exit
Shut off (especially) worker-thread session queue input nodes.
Otherwise, vpp can crash when the main thread unmaps the API segment.
Change-Id: Idf855e7570e0066cc921ae34bc53afabaa9e1dba
Signed-off-by: Dave Barach <dave@barachs.net>
Florin Coras [Mon, 27 Nov 2017 09:34:14 +0000 (04:34 -0500)]
tcp: fix retransmissions under buffer shortage
- add debugging scaffolding for simulating buffer shortage
Change-Id: Ice519d74f9c4e4094c4586c548185135b7bb5f2d
Signed-off-by: Florin Coras <fcoras@cisco.com>
Gabriel Ganne [Tue, 28 Nov 2017 08:55:07 +0000 (09:55 +0100)]
net/virtio: support modern device id
Add legacy and modern macros to pci_config header.
This follows dpdk commit:
4c7903658f6b5a8f4901224ef405445541b91e4a
And PCI Device Conformance doc :
docs.oasis-open.org/virtio/virtio/v1.0/cs02/virtio-v1.0-cs02.html#x1-640001
Change-Id: Iacd40ea8c06f220736ca0bc7ce68bcf1e55b68f6
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
“mukeshyadav1984” [Thu, 23 Nov 2017 10:39:33 +0000 (02:39 -0800)]
IPSec AH protocol enhancement in VPP native core
Change-Id: Iec5804d768485f4015bbf732d8d19ef2f24e6939
Signed-off-by: “mukeshyadav1984” <mukyadav@cisco.com>
Damjan Marion [Mon, 27 Nov 2017 18:55:14 +0000 (19:55 +0100)]
dpdk: fix issue when tx offload stops working after MTU change
Change-Id: I3713b4c460a3cd414b560e16aac054aee2e1181b
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Mon, 27 Nov 2017 18:37:05 +0000 (10:37 -0800)]
vcl: fix session handle in accept reply
Change-Id: I5afd840c07714fc457bb37f8f40e1fcc0bd11314
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Mon, 27 Nov 2017 11:12:00 +0000 (03:12 -0800)]
session: return bound listener for proxy accepts
This, if such a listener exists.
Change-Id: I974cc858c1e2fee50189c3c67e4abb76be32a98a
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Mon, 27 Nov 2017 02:43:25 +0000 (18:43 -0800)]
dpdk: fix trajectory compilation
Change-Id: I53f917cd58101a14667641ee9cecd1eabf3f71d9
Signed-off-by: Florin Coras <fcoras@cisco.com>
Swarup Nayak [Mon, 27 Nov 2017 04:57:43 +0000 (10:27 +0530)]
VPP-253 Coding standards cleanup - vnet/vnet/gre
Change-Id: I95f98b91faf74178c05f30da9eb3d6125193b7ef
Signed-off-by: Swarup Nayak <swarupnpvt@gmail.com>
Neale Ranns [Mon, 27 Nov 2017 09:03:25 +0000 (01:03 -0800)]
Fix - sh ip fib mtrie sum
Change-Id: I62a6ee78ee9ad73fd58a46fbdca54fd964fec113
Signed-off-by: Neale Ranns <nranns@cisco.com>
Pablo Camarillo [Thu, 16 Nov 2017 15:02:50 +0000 (16:02 +0100)]
SRv6 improvements to binary API
Change-Id: I260f5fe43074c0be973309f0a0895f50f0ca7c2b
Signed-off-by: Pablo Camarillo <pcamaril@cisco.com>
Marco Varlese [Mon, 27 Nov 2017 15:46:04 +0000 (16:46 +0100)]
Address COVERITY warnings
Among many false positives the potential NULL pointer dereference seems
to be a valid one hence addressing that with this patch.
Change-Id: Ia55784475294e96f60df64baf8820b459bb85bb7
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Neale Ranns [Mon, 27 Nov 2017 12:52:35 +0000 (04:52 -0800)]
VOM: favour make_shared
Change-Id: I0c5e198049d510f3b3f9a6aefe49c315449768e3
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Jan Gelety [Mon, 27 Nov 2017 08:51:17 +0000 (09:51 +0100)]
Update CSIT tests 171030 -> 171127
- update of CSIT operational branch to be used for VPP-patch test
Change-Id: I54f8d49f541102163964a41403ab993a51534e7e
Signed-off-by: Jan Gelety <jgelety@cisco.com>
Florin Coras [Mon, 27 Nov 2017 10:43:30 +0000 (02:43 -0800)]
tcp: fix proxy connection validation
Change-Id: Icb0274cd3bcabfab8bdff6dec7440a3a15edfbf1
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Fri, 24 Nov 2017 19:15:23 +0000 (20:15 +0100)]
vlib: make vlib_buffer_alloc inline function
Currently, every alloc involves callback function call. With this change
callback function is called only if there is no empty buffers on the
free list.
Change-Id: I2238c19ece7ce182c49ba0f2485add52f335f3b6
Signed-off-by: Damjan Marion <damarion@cisco.com>