Make rpm push handle SRPMs

* Fix the rpm push to search out and push SRPMs

* Fix the rpm push to actually push a file as it was referencing a bad
  variable

* Fix up some minor linting issues

Change-Id: I4d2e66ad52e593b71b969ab1b5faad254cc35e2d
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix virl scripts broken by {os}

Change-Id: I9f16666cf18753ce47d74fa21c125b1375407ecf
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Have merge job push rpms to the yum repo

Change-Id: I0d16b75d8e8770894577659cd9b6ae0fc2140db9
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Turn on multi-os merge jobs

Change-Id: Iff99c3e8b8dadc6334b33fe5aff688102273fcb5
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Enabled centos7 build

Change-Id: I7fafacbe2fa58313e320de2e3a8a498898e89601
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Machinery for multi-os build.

This patch should provide machinery for multi os build
It also provides machinery for multi-branch build

Change-Id: I29db20f159f18af2cab512ab6df6b03d9f81ff15
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Split vpp-verify-perfomance job

- split job to include manual trigger keyword: verify-perf-long and
  verify-perf-short

Change-Id: Ie2048704313634cc9ea62ce67e80fc921bef2e18
Signed-off-by: pmikus <pmikus@cisco.com>

Merge "Make vpp-csit-verify-virl patch-triggered."

Make vpp-csit-verify-virl patch-triggered.

Change-Id: I90855a0b7a9a0e346a83beb42ada824bebd6eff6
Signed-off-by: Stefan Kobza <skobza@cisco.com>

VPP performance check job

- add job-template into jenkins layout view

Change-Id: I41a9e865713100b63913b9f5e4a3ea6d97bb3231
Signed-off-by: pmikus <pmikus@cisco.com>

VPP performance check job

- vpp-csit-hw-perf job to check performance of proposed patch
- build, copy, install, start perf tests

Change-Id: I2ae4cee916532c4d57715e2bd739d3109ab7ccf6
Signed-off-by: pmikus <pmikus@cisco.com>

Merge "Use tagging instead of branching for csit-verified"

Use tagging instead of branching for csit-verified

- use tags instead of branches in case of
  job "csit-vpp-master-verify-weekly"

Change-Id: Icbdcc2a57e1ab17d634ce3b8deedbc481f8f313c
Signed-off-by: Jan Gelety <jgelety@cisco.com>

Make robot framework output-path parametrizable.

csit-vpp-verify-virl job is blocked now, because output-path is not a
variable in robot-framework macro. This patch changes that.

Change-Id: I1c31342af6dfae66ce3e21e751470e476cc5be39
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Fix rh_systems shell function

The rh_systems shell function was not properly defined. This corrects it
so that the bootstrapping can work

Change-Id: Ic5f03feac7deb5c8da54f3db4b0fb6a599ff0d85
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Add basebuild for centos

Change-Id: I8a8ba3fe1fd3fb12ed3f3004bbc863cb7b2c9872
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Refactor basebuild in prep to add Centos image

Change-Id: I9583a1e3a64c40460d5196ce28261230234ff80b
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Update of the job 'vpp-csit-verify-virl'

Job is updated to be run manually and to use
csit-verified branch to test vpp.

Change-Id: I7a56594cb840c374bc849c095241655290e6b0bd
Signed-off-by: Jan Gelety <jgelety@cisco.com>

CSIT: new job 'csit-vpp-verify-master'

This job is aimed to test latest csit master code against
latest stable vpp release. If the verification is successfull
then push curent master to master-verified branch

Change-Id: I18316f6f96e793721ee78c3b83a18ff74778cabf
Signed-off-by: Miroslav Miklus <mmiklus@cisco.com>

Add job parameters to csit jenkins jobs.

Change-Id: Ibe5d4c527eb773acfc5283584a2c4d72df6bd335
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Remove standard csit jobs from Zuul.

Until OpenStack issues with L2 transparency are resolved, make csit
jobs Jenkins triggered again.

Change-Id: Ie82357275b91804e64a194a8de5c51acf9c27743
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Fix typo for git-scm

Change-Id: Ibb8ddd694792ba82545d9d0abc25f3080ee6c3b3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add new networks for multilink testing

Switch to Interlink1-6 networks for multilink labs

Change-Id: I119a9751e96ebf787e23234cc53a5882b419976b
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix merge/integration jobs to build master, not gerrit

Change-Id: I72afb24d177b3b81e9427d43c3adb4a0a80fd240
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Remove system pylint installation from pylint job.

Change-Id: Ic4894018ffa10e7742bd798c17bdbe6de7945a0a
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Add honeycomb-integration job

Because we need the up-to-date vpp-japi.jar, its important
to rebuild when vpp rebuilds that jar.

Change-Id: Ifdfc93cd4274be1ceb8f92a5daf9084b9d9ed174
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Add new nodepool CSIT job trigger to zuul.

Change-Id: Ie57378604ed1d2ca7d0ac20304da9f97bb909ab6
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Add new nodepool csit-vpp-functional job.

Make new job in csit project that gets triggered on CSIT changeset. This
is an entry-point to integrate CSIT functionality with LF's VM infra.
The actual integration is going to happen in CSIT, where we can tune the
bootstrap script and then move it into ci-management.

Change-Id: Icbfaf0a7b27899af4bea97d80a1883c7dd2df52e
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Fix csit-vpp-functional-hw-tb2 job

Regular JJB "- job:" sections do not parse variables. This patch changes
it to use a "- job-template:" section which do parse variables.

Change-Id: Idd1753f9596ec67a9cf86096ff0416db4c07407e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Add vpp jenkins job to build vpp and run csit tests."

Add vpp jenkins job to build vpp and run csit tests.

To start integrating with VPP verify job, start csit tests for each VPP
verify run. Until artifacts passing is solved between jenkins upstream
and downstream jobs, build the VPP project again in this job. Then
check out csit project, copy the deb packages to the cloned dir and
start the testcase.

Prevent the job non-voting, so that it does not polute VPP reviews with
erroneous results. We'll switch to normal voting after all potential
problems are ironed out, and the job is stable.

Change-Id: I9e35e19a1d8b2a64b8e65473fef93e0b537eded2
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Move csit-vpp-functional-virl to zuul.

Change-Id: I240b93105039e8838f711f545eafd95f354bee16
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Remove parameters from csit-vpp-functional-hw-tb2.

Zuul has SKIPping this job, and parameters are the only difference when
comparing the job to other zuul jobs.

Change-Id: I529577170797bd7cb2fc00f3ac1c483eba97e2de
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Make subnodes easily identifiable

When nodepool brings online a node and subnodes they are presently all
named the same way. This makes it difficult to pinpoint the leader node
of a set if we need to do any work directly against OpenStack. This
change will cause sub-nodes to have the prefix of np-sub- and the rest
of the name from the leader node making it clear.

Change-Id: I536b2e4437a93f118436e8eeb6869a2f691be0f6
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Move csit-vpp-functional-hw-tb2 to zuul.

The job should be started only by adding 'hw-tb2-check' comment to gerrit.

Change-Id: I219568fc6756838939f74ed62f14d1a07b117e37
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Add current nodepool configuration

This adds in the nodepool configuration that we are presently using.
This is the starting point for the community to help define what build
slave definitions are needed.

Change-Id: I1c6325869a0a411265994090f9dc754de03ea173
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Attache nodepool jobs to zuul

This attaches the ci-management-{verify,merge}-nodepool jobs up to the
proper zuul trigger points (check, post-merge)

Change-Id: I7a67affb8c27d19eabcf72704d8e65b402dc1202
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Add nodepool management jobs

Add jobs for doing nodepool management

Change-Id: I9d5b74850f51c7f950ccb3580c1aa7f981786494
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Add manual triggered csit-vpp-functional-hw-tb2 job.

This job would be create from the same template as
csit-vpp-functional-virl, but for the time being this have to be
manually triggered. I didn't find a way how to parametrize
gerrit-trigger-patch-submitted so I've created
gerrit-trigger-manually-triggered.

Change-Id: I2d4f2c6bb8ebb94cd8563132feac765d46e1b56d
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Add verify / merge zuul jobs and update layout

* Update the zuul layout.yaml with changes that are currently being hand
managed.

* Add in the verify and merge jobs for zuul (which have temporarily
  been handmanged in as well)

Change-Id: I1f86488165f384def27d03593d161a56f955e4b9
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Add new verify / merge jobs for zuul

We need jobs to be able to manage zuul layout changes. This brings those
jobs in

Change-Id: If6397b0d7f52edc7f2668a2351c35e637ef92888
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Rename ci-management-merge

Rename the ci-managment-merge job to be ci-management-merge-jjb as it is
jjb specific. This sets us up to support
ci-managment-{verify,merge}-{zuul,nodepool} job definitions as each of
these job definitions is verify specific to the tool being managed

Change-Id: I1bfcc02411af043f349ca5b62aac17bffe8df363
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Move ci-management jobs to own directory

Let's make the ci-management jobs be a little more consistent with other
projects and have them live in their own directory. Global macros will
still live at the root jjb level.

Change-Id: Ie9bd90ae049b4b83fad050b697e14aced18de4a6
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Remove unneeded ci-management weekly job

We've found that as the projects grow that having a weekly job to
refresh the JJB fails more often than it succeeds. As this can be done
as a manual process by the releng team it's better to just remove the
job than have it sit around failing.

Change-Id: I48d154d3cb459171f76526844ef6b64269982c42
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Add PYTHONPATH to pylint execution env.

Change-Id: If8a696ee812ddc0b7b3cdb262455d5b2ac4c54d0
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Merge "Add violations publisher plugin for pylint."

Add violations publisher plugin for pylint.

Change-Id: I5685d1679f0e26d87e7c704637304c6f8c5a00e5
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Remove unnecessary jclouds wrapper for pylint validation.

Change-Id: Icfbebedf1ada83a1badcec796b0b986819f265ef
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Enable robot framework jenkins plugin.

Change-Id: I506ea3dd431b559c3ce1e756f2310103da05024d
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Separate VIRL test job; Make VIRL job non-concurrent.

Rename csit-vpp-functional to csit-vpp-functional-virl to express the
tests are being run on VIRL environment. This one of first steps to
separate job runs environments - LF's multi-node VMs and VIRL.

Make the VIRL job non-concurrent, as we are working on mechanisms of
spawning of VIRL simulations and VPP installation.

Change-Id: I0c9f5a1973b7d7764bb192b91d9e8b331f4b40a2
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Rename csit validate job, add pylint installation to script.

Adding sudo apt-get install script to the pylint validation job. Will
move it to the Vagrantfile after all deps are known and fixed.

Change-Id: I17feaaf4280388088df77f8921a26c1c1c873557
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Trigger build of this project for CSIT patches.

Until CSIT is fully integrated and functional, we need to have an
option to trigger jenkins build easily by CSIT project change rather
than VPP build. This is a temporary trigger setup.

Change-Id: I0040158024cf9446b1533b04599e1912f08d3ea8
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Fix ci-management-verify not testing the submitted commit

The ci verify job was testing branch HEAD which doesn't help us verify
code submissions. This patch fixes it so that we pass a parameter
{commit} to represent the branch or commit that we should run against.
Sets the merge job to run against $ZUUL_BRANCH while the verify job
runs against $ZUUL_COMMIT.

Change-Id: I9516bfc14a9981c5e8348e0a6324a3c15b5afc32
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add make csit-vpp-validate-pylint job more descriptive

Change-Id: I409d4dced99f349e994947ae98ce9e1a4416712b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix typo in csit validate job template

Change-Id: I3fec5aaf21d165515375c9fafbb4c5830d621d33
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix pylint template name conflict

Change-Id: I9019459ecde83644e747382f84141c86b77297fa
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Rework CSIT jobs - 1 validates CSIT commits, 1 tests vpp debs."

Add virtualenv and pip to jenkins executor image.

Change-Id: I4315eeacff98fa4c9a41a53e608b90a68024d92f
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Rework CSIT jobs - 1 validates CSIT commits, 1 tests vpp debs.

Change-Id: I6e8b78fec5b458cfdac6864617cdbd342b6f0594
Signed-off-by: Stefan Kobza <skobza@cisco.com>

Remove the toolchain_test jobs

Toolchain test is no longer needed and the repo is currently admin
access / visible only until we can clean gerrit.

Change-Id: I891755a0411be350249a1e3966c5d66abf8165a6
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Turn down some of the spurious publishers.

Espcially the aggressive archive artifacts.

Change-Id: Ia20cfddb2ee543f000ca4d99f0462be7a740b608
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Fix Zuul failing --force-message against Gerrit 2.12

We probably don't need the "success-message" and "failure-message" but I
think adding it for clarity of which type of job is leaving a comment is
nice.

Change-Id: I7210c0281e3954f714ad5aa308ad8206f25878be
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Convert ci-management jobs to zuul

Change-Id: I58d6f956a7efdecfe537c3b6b5bdc88f29cae723
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Finish converting toolchain_test to zuul

* Migrate toolchain_test-merge to using zuul
* update toolchain_test-verify to use new scm macro
* drop the project and branch parameters as zuul doesn't honor them
  anyway

Change-Id: I678bcc3c19477fa245de99d5bc4d09d822339e09
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Add new zuul-trigger-scm macro

Add a new macro for zuul triggered scm

Change-Id: Ib23b7ba3d802339951e57a864a0fa40d954de5de
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Switch toolchain_test-verify to using zuul

Change-Id: Icf49effa5ca4a7eb75d15a93bd504dbc21d3bc17
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix commit hook url

Change-Id: Ia6f15d9cb6b95a764c0ed3c05f22da812c0352fe
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Undo switch off of Gerrit Trigger

I can't keep working on this anymore today and leaving it configured for
zuul overrnight is a broken concept.

This moves everything back to Gerrit Trigger control. We can move jobs
individually tomorrow.

Change-Id: I6943708a6001acb7c5acfe6a6746d6c056813f52
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

missed a recursive call

Change-Id: Ie0cb6b45f1ca57c4cef85f7550482f664aaa6879
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

JJB needs to be recursive from the CLI

Our puppet module doesn't properly the JJB recursive flag in the ini
file. So, let's just make sure it happens even if not set by setting the
flag in the call.

Change-Id: Ia23fd404f357db08fb3b4b39862de9ed80695319
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Migrate to Zuul configuration

Change-Id: I055731ac99ae40960ee1e6a3e5cf0595d8da4600
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Move JJB jobs to dedicated static slave

Zuul has a problem where it can't control jobs that are tied to the
master. As we need JJB jobs to also be able to actually do some work on
the the Zuul system we're statically tying it into Jenkins with a
requirement that only jobs specifically targetting it can run there.

Change-Id: I5a689056edbfa2e154b88d6b3df0a9b97fa17192
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Enabled CCACHE_DIR to persist between jobs

Change-Id: I7d7fc9c8c0dd561e4abbab481ccf4f879763e2e6
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Merge "Turn off archiving for vpp verify and merge job"

Turn off archiving for vpp verify and merge job

Change-Id: If94f2c76740c8250a403557f0ceab0f17df4ddf7
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Update build-bot toolchain to match the vpp ubuntu Vagrantfile.

Change-Id: I03c63afdd02f0082bf0bd800e0d2f3b01b151415
Signed-off-by: Dave Barach <dave@barachs.net>

Add V=0 to make command line;TAG=vpp_debug -> TAG=vpp

Change-Id: I4235334db36609be45b1e31e80659d5cda1827da
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Fix .gitreview to have correct URL

Now that we have a proper name the .gitreview file should reflect this.

Change-Id: I23902395270480b87aefe4476fc11a4ddc1524ee
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Archive target/ dirs and keep pax-exam unpack area

Change-Id: I2f9eb1ce744881da675551bef420e1ccbbf172bf
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Redirect job output to file and archive them

Also limit max artifacts to keep to 5.

Change-Id: If7603844d12e43f208817dc77b015ddc63786d99
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Change honeycomb-settings UUID

JJB doesn't handle the latest config file provider IDs for objects
properly as it expects them all to be prefixed with
org.jenkinsci.plugins.configfiles.maven.MavenSettingsConfig otherwise it
believes the information to be a file path (which doesn't work!) As
such, the honeycomb-settings ID has been fixed up to be more inline with
what JJB expects / requires (until we can get it patched). This required
a restart of Jenkins to take effect.

Change-Id: I60092b1a229d498d672b60fef9554fd7a16d5b60
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix the repo name that the project looks for

honeycomb was mispelled and we hadn't caught that previously.

Change-Id: Ib33a61b1297a4afa246d33c3091298c20999373c
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Add gerrit trigger to csit job

Change-Id: I26d5f8a4431d362fa018a6073c6628101bb4a0f0
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Setup csit job to do verify

Setup the csit job to do verify and execute ./bootstrap.sh if it exists.
It will fail the job if it does not exist

Change-Id: Ie5f776009f6079693d452b299c3bc185451550ac
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Update vpp maven deployment

Update the vpp maven deployment script to use the correct repo and
namespace

Change-Id: If3da11885ea674131cc1fe5fd91d3ccaca8f5a83
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Merge "Build vpp on csit manual trigger"

Make sure that jjb jobs run on master node only

Change-Id: I2fc3110e8992c45ffcdf9758be7b9453a1b53272
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Build vpp on csit manual trigger

Change-Id: I9a8234a0fab0e13537ff5e91d542a42eefcaf287
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Rename of job

- correct repo
- jenkins regex puts in right tab

Change-Id: I314a02d90df8847178082c054f706ae74fca9639
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Robot testing framework

- please note this ties in with new CSIT repo and this change
referenced here: https://gerrit.projectrotterdam.info/r/#/c/91/

Change-Id: I6cad694155c65b7618bbb5dea5bac3888fbcbe59
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Initial Honeycomb JJB Commit

Change-Id: I50e3c7534ade3f241848df5896190038d3cc3410
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Add honeycomb settings macro

Change-Id: Iffe82075d466356e1522be20c6967abb8858184b
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Allow ci-management to do concurrent verifies

Make sure that our verify jobs for ci-management are allowed to be run
in parallel

Change-Id: I7390c836f88968f3d9d2538111dba389648cb72d
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Enable concurrent verifies for vpp

Make sure that the verify job for vpp allows for concurrent runs

Change-Id: Ifb88cdba872150c2d7c67b7651728123b8ab2c25
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Some additional items needed for testing in basebuild

Change-Id: I4730136b45d79f081d9bc649025bc34af62c21a5
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Make the script fail build if mvn deploy fails

The script wasn't picking up a failed mvn deploy failure. This changes
it so that we need an definite exit code of 0 to not fail the build.

Change-Id: I094bf1e149f779061223496a0b2bc347a3705b5b
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Update the deployment repo and also detect failure

A failed upload was not being detected and causing the job to fail. This
fixes it so that if the maven upload fails we'll fail the build.

Also, at Ed's request there is now a .dev repo for the regular merge
time deb files so we need to push there and not to .release

Change-Id: I08e01979c35c248f6e0fcc6c3b166f2148a9b9f0
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Do not double up the _amd64 for maven push script

Change-Id: If6f686d44442a42e98e4d5d783a4c2d869c98023
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

Fix up push script repoId selector and classifications

The settings files use a - separator for the repoIDs so we need to make
sure that we're concatenating against a - instead of .

Additionally we're tightening up the version classification of the
pushed objects. This may not be 100% still but it should be better than
what we were attempting previously.

Change-Id: I726f9d87c3441357701ad79b7357a337c6636a42
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>

ENV var test for MAVEN_SELECTOR was inverted

The script should be detecting on a null ENV var, not a non-null
variable. In other words, the test was inverted.

Change-Id: If5ee68301300ec363e171f99798c06daa1428ede
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>