Klement Sekera [Wed, 21 Mar 2018 16:48:50 +0000 (17:48 +0100)]
make test: use vpp-dev repo for py-lispnetworking
Change-Id: Ia87d55cad1d466a4cc624f06abbc322cddb5608c
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Klement Sekera [Wed, 21 Mar 2018 16:44:20 +0000 (17:44 +0100)]
allow specifying number of concurrent jobs
If defined, Use MAKE_PARALLEL_JOBS as number of concurrent jobs for
build process instead of the internal calculation based on /proc/cpuinfo.
Change-Id: I18d1f526dc5c156c1cd9c9cf6dbbfd9cb8dbbad7
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Klement Sekera [Fri, 23 Mar 2018 09:50:11 +0000 (10:50 +0100)]
make test: enhance core-file information
Change-Id: I1283960a9a49f6d70b9d7b7793cfb345c22ccdea
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Matthew Smith [Fri, 23 Mar 2018 13:30:16 +0000 (08:30 -0500)]
User session counters stay <= per-user limit
When a user session is allocated/reused, only increase
one of the session counters for that user if the counters
are below the per-user limit.
THis addresses a SEGV that arises after the following
sequence of events:
- an outside interface IP address is put in a pool
- a user exceeds the number of per-user translations by
an amount greater than the number of per-user translations
(nsessions + nstaticsessions > 100 + 100)
- the outside interface IP address is deleted and then added
again (observed when using DHCP client, likely happens if
address changed via CLI, API also)
- the user sends more packets that should be translated
When nsessions is > the per-user limit,
nat_session_alloc_or_recycle() reclaims the oldest existing
user session. When an outside address is deleted, the
corresponding user sessions are deleted. If the counters were
far above the per-user limit, the deletions wouldn't result
in the counters dropping back below the limit. So no session
could be reclaimed -> SEGV.
Change-Id: I940bafba0fd5385a563e2ce87534688eb9469f12
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Neale Ranns [Fri, 23 Mar 2018 18:53:12 +0000 (11:53 -0700)]
Add client hw address to DHCP offer and ack in test case
Change-Id: Ifc9bb4ea39b504372a6a39bbf56c29761d0c6111
Signed-off-by: Neale Ranns <nranns@cisco.com>
Andrew Yourtchenko [Fri, 23 Mar 2018 14:23:15 +0000 (15:23 +0100)]
acl-plugin: improvements in 'show acl-plugin macip acl' CLI
- allow to optionally specify the specific MACIP ACL index:
'show acl-plugin macip acl [index N]'
- after showing the MACIP ACL, show the sw_if_index of
interface(s) where it is applied.
Also, add some executions of this debug commands
to the MACIP test case for easy verification.
Change-Id: I56cf8272abc20b1b2581b60d528d27a70d186b18
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Dave Barach [Fri, 23 Mar 2018 13:52:52 +0000 (09:52 -0400)]
Drop dhcp pkts w/ hardware address mismatches
Add a few dhcp client rx packet/state counters
Temporarily disable the dhcp client unit test, since it trips over the
newly-added hardware address check.
Change-Id: I7f68607e6ed3d738cba357c3fe76664a99b71cd8
Signed-off-by: Dave Barach <dave@barachs.net>
Marco Varlese [Fri, 23 Mar 2018 12:32:50 +0000 (13:32 +0100)]
IPSEC_AH: broken initialization (VPP-1208)
The init-path for IPSEC_AH where the CTX gets initialized is broken
since the for-loop never executes due to the wrong usage of
tm->n_vlib_mains which being subtracted by 1.
Change-Id: I4d967f52cd3ca061aa60d824d65f446e06162403
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Florin Coras [Fri, 16 Mar 2018 15:48:31 +0000 (08:48 -0700)]
tcp/session: sprinkle prefetches
Change-Id: Idef3c665580c13d72e99f43d16b8b13cc6ab746f
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 23 Mar 2018 04:24:31 +0000 (21:24 -0700)]
session: allow builtin apps to register names
Change-Id: I4b428e170436671b329657283cf7653befc85c9f
Signed-off-by: Florin Coras <fcoras@cisco.com>
Andrew Yourtchenko [Fri, 23 Mar 2018 11:20:56 +0000 (12:20 +0100)]
acl-plugin: make test: do not use a debug CLI where API can be used
Parsing the list of applied ACLs from the debug CLI output
is not a good idea, since the debug CLI can and will change.
Fix that.
Change-Id: Ia47214863f2658a54219f59cb974b5cbc536f862
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Andrew Yourtchenko [Fri, 23 Mar 2018 10:56:23 +0000 (11:56 +0100)]
acl-plugin: set ACL heap within the exported functions that might alloc memory
The functions which get called by other plugins need to set the acl plugin heap,
such that the other plugins do not have to think about it.
Change-Id: I673073f17116ffe444c163bf3dff40821d0c2686
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Klement Sekera [Wed, 21 Mar 2018 11:35:51 +0000 (12:35 +0100)]
make test: code cleanup
Change-Id: Ic689de569e5b6e6209d16d6acdb13c489daca1f5
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Matus Fabian [Fri, 23 Mar 2018 10:42:06 +0000 (03:42 -0700)]
NAT44: fix ICMP checksum update crash (VPP-1205)
Change-Id: I3e4bbfe205c86cb0839dd5c542f083dbe6bea881
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Andrew Yourtchenko [Fri, 23 Mar 2018 09:38:46 +0000 (10:38 +0100)]
acl-plugin: make test: add a test which deletes an interface with applied ACL
There was no test coverage for a scenario of an interface having an
ACL and that interface being deleted. Add a basic sanity test which
applies an ACL to an interface and then deletes that interface.
Change-Id: Ib6462e02cf69f1173125ac2481c608f68eb389ac
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Andrew Yourtchenko [Fri, 23 Mar 2018 08:34:29 +0000 (09:34 +0100)]
acl-plugin: make test: shuffle applied ACLs as part of the tests
During the testing of
94f9a6de3f706243d138e05b63fef1d5c8174f6c
I realized there was no test coverage for the cases where
the ACLs are added then modified while having beein applied.
This change adds some simple shuffling to l2l3 ACL test set,
whereby after each of the ACLs being applied, a few extra ACLs
are applied at the front and the back of the list, and are changed
several times, the base for the changes being the set of all the
ACEs that are being applied previously.
After these few shuffles, the routine restores the applied ACLs
and proceeds to the test as usual.
Change-Id: Ieda2aa5b7963746d62484e54719309de9c1ee752
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Neale Ranns [Wed, 21 Mar 2018 23:34:28 +0000 (16:34 -0700)]
IGMP: coverity fixes and remove checks for scapy IGMPv3
Change-Id: Ic2eddc803f9ba8215e37388a686004830211cf6f
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Steven [Fri, 23 Mar 2018 00:46:58 +0000 (17:46 -0700)]
bond: performance enhancement
We were only puting one packet per frame to the output node. Change to
buffer multiple packets per frame. Performance is now on top of dpdk-based
bonding.
Put a spinlock in the tx thread in case the rug is pulled under us.
Change-Id: Ifda5af086a984a7301972cd6c8e428217f676a95
Signed-off-by: Steven <sluong@cisco.com>
Mohsin Kazmi [Thu, 22 Mar 2018 15:07:05 +0000 (16:07 +0100)]
vom: itf: make vhost_user as socket slave
Change-Id: I57b2ec35d9629fb5336c1ccfa4c6c849df118f7b
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Dave Barach [Thu, 22 Mar 2018 12:15:05 +0000 (08:15 -0400)]
VPP-1204: Fix coverity warning
Change-Id: Iacb32e6e855f7b77108154d956ef27ee141bbde0
Signed-off-by: Dave Barach <dave@barachs.net>
Dave Barach [Thu, 22 Mar 2018 14:54:45 +0000 (10:54 -0400)]
Add circular logging
Change-Id: Ide8bf41e24a427643a3a17b1c9089993790c12a6
Signed-off-by: Dave Barach <dave@barachs.net>
Damjan Marion [Thu, 22 Mar 2018 22:34:06 +0000 (23:34 +0100)]
Revert "acl-plugin: improvement on 'show acl-plugin' CLI"
This reverts commit
378ac0533e5ac8c3121d8f66ba61a8548e55282f.
Change-Id: If34b1c964453adb0e4c44e3eab4f6e306bd9c9e9
Signed-off-by: Damjan Marion <damarion@cisco.com>
Andrew Yourtchenko [Wed, 21 Mar 2018 18:53:39 +0000 (19:53 +0100)]
acl-plugin: implement ACL lookup contexts for "ACL as a service" use by other plugins
This code implements the functionality required for other plugins wishing
to perform ACL lookups in the contexts of their choice, rather than only
in the context of the interface in/out.
The lookups are the stateless ACLs - there is no concept of "direction"
within the context, hence no concept of "connection" either.
The plugins need to include the
The file acl_lookup_context.md has more info.
Change-Id: I91ba97428cc92b24d1517e808dc2fd8e56ea2f8d
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Mohsin Kazmi [Thu, 22 Mar 2018 14:46:37 +0000 (15:46 +0100)]
gbp: Add the next node lookup
Change-Id: Ia0f659b810f2c79b1a6c98ce566a86ce413c7448
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Matus Fabian [Thu, 22 Mar 2018 12:50:47 +0000 (05:50 -0700)]
NAT44: interface output feature and dst NAT (VPP-1200)
Do not translate packet which go out via nat44-in2out-output and was tranlated
in nat44-out2in before. On way back forward packet to nat44-in2out node.
Change-Id: I934d69856f0178c86ff879bc691c9e074b8485c8
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Damjan Marion [Thu, 2 Nov 2017 16:07:59 +0000 (17:07 +0100)]
memif: version 2
In version 1 of the protocol sender was always ring producer and
receiver was consumer. In version 2 slave is always producer,
and in case of master-to-slave rings, slave is responsible for
populating ring with empty buffers.
As this is major change, we need to bump version number.
In addition, descriptor size is reduced to 16 bytes.
This change allows zero-copy-slave operation (to be privided in the separate
patch).
Change-Id: I02115d232f455ffc05c0bd247f7d03f47252cfaf
Signed-off-by: Damjan Marion <damarion@cisco.com>
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Dave Barach [Tue, 20 Mar 2018 12:49:02 +0000 (08:49 -0400)]
Avoid atomic ops when polling queues
Change-Id: I31c6a0a1d11b5b12d8a5c32c29fea9618b1a53d4
Signed-off-by: Dave Barach <dave@barachs.net>
Mohsin Kazmi [Wed, 21 Mar 2018 14:55:28 +0000 (15:55 +0100)]
vom: l2-emulation: Fix sweep function
Change-Id: I6fdb9e7b718c696f7352541f90026cf60f11338f
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Damjan Marion [Wed, 21 Mar 2018 21:27:46 +0000 (22:27 +0100)]
udp: make udp encap pool cacheline aligned
This fixes issue with unaligned vector access on gcc-7.
As udp_encap_t is declared as cacheline aligned, alloc also need to be.
Change-Id: Ic30876911baf2c22c135097490075fa7bcf0ca18
Signed-off-by: Damjan Marion <damarion@cisco.com>
Steve Shin [Wed, 21 Mar 2018 18:35:12 +0000 (11:35 -0700)]
acl-plugin: improvement on 'show acl-plugin' CLI
- Show interface on which given MACIP ACL is applied
- index is added for show acl-plugin macip acl:
ex) show acl-plugin macip acl [index N]
Change-Id: I3e888c8e3267060fe157dfc1bbe3e65371bd858a
Signed-off-by: Steve Shin <jonshin@cisco.com>
Steven [Wed, 20 Dec 2017 20:43:01 +0000 (12:43 -0800)]
bond: Add bonding driver and LACP protocol
Add bonding driver to support creation of bond interface which composes of
multiple slave interfaces. The slave interfaces could be physical interfaces,
or just any virtual interfaces. For example, memif interfaces.
The syntax to create a bond interface is
create bond mode <lacp | xor | acitve-backup | broadcast | round-robin>
To enslave an interface to the bond interface,
enslave interface TenGigabitEthernet6/0/0 to BondEthernet0
Please see src/plugins/lacp/lacp_doc.md for more examples and additional
options.
LACP is a control plane protocol which manages and monitors the status of
the slave interfaces. The protocol is part of 802.3ad standard. This patch
implements LACPv1. LACPv2 is not supported.
To enable LACP on the bond interface, specify "mode lacp" when the bond
interface is created. The syntax to enslave a slave interface is the same as
other bonding modes.
Change-Id: I06581d3b87635972f9f0e1ec50b67560fc13e26c
Signed-off-by: Steven <sluong@cisco.com>
Dave Barach [Wed, 21 Mar 2018 17:45:12 +0000 (13:45 -0400)]
VPP_1202: handle DHCP NAK packets
Change-Id: I469a734747099cef2d135d77e4db0244e24bf0bc
Signed-off-by: Dave Barach <dbarach@cisco.com>
Neale Ranns [Tue, 20 Mar 2018 08:47:35 +0000 (01:47 -0700)]
UDP Encap counters
Change-Id: Ib5639981dca0b11b2d62acf2c0963cc95c380f70
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Wed, 21 Mar 2018 13:44:01 +0000 (09:44 -0400)]
Detailed Interface stats API takes sw_if_index
Change-Id: Id09d777c1706c1d613b14b719bcac596194465cd
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Wed, 21 Mar 2018 14:19:15 +0000 (10:19 -0400)]
IGMP plugin initialises the FIB/MFIB via ip4 module
Change-Id: If9d7b266c4b49d4e7810ebc7d18fa154532d0322
Signed-off-by: Neale Ranns <nranns@cisco.com>
Matus Fabian [Tue, 20 Mar 2018 11:31:42 +0000 (04:31 -0700)]
NAT44: fix removal of LB static mappings with same local address and port pair (VPP-1199)
Change-Id: Iad8c626e83bbc58d5c85b6736f5a3dd5bc9ceafb
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Klement Sekera [Thu, 22 Feb 2018 10:41:12 +0000 (11:41 +0100)]
reassembly: feature/concurrency
This change makes ip reassembly an interface feature, while adding
concurrency support. Due to this, punt is no longer needed to test
reassembly.
Change-Id: I467669514ec33283ce935be0f1dd08f07684f0c7
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Neale Ranns [Wed, 21 Feb 2018 12:57:17 +0000 (04:57 -0800)]
FIB Interpose Source
The interpose source allows the source/provider to insert/interpose
a DPO in the forwarding chain of the FIB entry ahead of the forwarding
provided by the next best source. For example if the API source (i.e
the 'control plane') has provided an adjacency for forwarding, then
an interpose source (e.g. a monitoring service) couold interpose a
replicatte DPO to copy the traffic to another location AND forward
using the API's adjacency.
To use the interose feature an existing source (i.e FIB_SOURCE_PLUGIN_HI)
cn specifiy as a flag FIB_ENTRY_FLAG_INTERPOSE and provide a DPO to
interpose. One might also consider using interpose in conjunction with
FIB_ENTRY_FLAG_COVER_INHERIT to ensure the interpose object affects
all prefixes in the sub-tree.
Change-Id: I8b2737b985f8f7c08123406d0491881def347b52
Signed-off-by: Neale Ranns <nranns@cisco.com>
Steve Shin [Mon, 19 Mar 2018 18:36:10 +0000 (11:36 -0700)]
Fix Allow ARP packets for dot1q interface with MACIP enabled
ARP packets need to be allowed for dot1q interface when MACIP is enabled.
Change-Id: I33dd3cb6c6100c49420d57360a277f65c55ac816
Signed-off-by: Steve Shin <jonshin@cisco.com>
Dave Wallace [Mon, 19 Mar 2018 14:38:00 +0000 (10:38 -0400)]
VCL: Fix Coverity CID183003
*** CID 183003: Program hangs (LOCK)
/src/vcl/vppcom.c: 2988 in vppcom_session_accept()
Change-Id: I123b73198d305fb0226516942caa410d3647a6bc
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Neale Ranns [Mon, 19 Mar 2018 16:24:07 +0000 (12:24 -0400)]
Use x(void) not x() in new interface stats code
Change-Id: Iaceaba4dc22341c631c858516b960ce97c4aa564
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Sun, 18 Mar 2018 15:22:17 +0000 (08:22 -0700)]
session: fix coverity warnings
Change-Id: I022dc40476ea9c30957b12bf1bd0629c6eb41cda
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Mon, 19 Mar 2018 09:32:57 +0000 (02:32 -0700)]
Coverity found bugs in recent MPLS changes
Change-Id: I590945fdc1af53208c990a52bbecdc992fd27532
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Neale Ranns [Mon, 19 Mar 2018 09:39:45 +0000 (02:39 -0700)]
QoS code coverity found errors
Change-Id: I6b125b79bdc560bfb81f307367c844b6a5af6368
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Neale Ranns [Mon, 19 Mar 2018 09:43:28 +0000 (02:43 -0700)]
FIB code coverity found defect
Change-Id: I7cdc29dd6481242aaace75138cc34e2f5ea76b81
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Dave Wallace [Mon, 19 Mar 2018 15:18:30 +0000 (11:18 -0400)]
VCL: Fix Coverity CID183009
Change-Id: I0233b20eb4c7dcb325e15b97a22ecd54200f6fde
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Neale Ranns [Fri, 16 Mar 2018 23:26:21 +0000 (16:26 -0700)]
Interface Unicast, Multicast and Broadcast stats on the API
Change-Id: I7c75da358aff1bd0216a602a49f2909cef5d920d
Signed-off-by: Neale Ranns <nranns@cisco.com>
Jakub Grajciar [Fri, 8 Dec 2017 15:28:42 +0000 (16:28 +0100)]
IGMP plugin
- host mode:
igmp_listen - API to signal that the host has joined an (S,G)
- route mode:
igmp_enable - API to enable the reception of host IGMP messages
igmp_event - API to report the host join/leave from an (S,G)
Change-Id: Id180ec27dee617d33ab3088f5dcf6125d3aa9c8f
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Matus Fabian [Mon, 19 Mar 2018 10:58:41 +0000 (03:58 -0700)]
QoS: publish qos.api.h file
Change-Id: Ice041610c23563ead13019216516aff23b7775b9
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Ole Troan [Mon, 19 Mar 2018 11:14:02 +0000 (12:14 +0100)]
IPIP: Fix coverity error.
Change-Id: Ia2b3350bf8e2c72eee3f33936ba16dd817c75c72
Signed-off-by: Ole Troan <ot@cisco.com>
Neale Ranns [Sun, 25 Feb 2018 20:27:18 +0000 (12:27 -0800)]
Scapy upgrade to 2.4.0.rc5
- many of the patches fd.io applies in test/patches/2.3.3 are now upstreamed in 2.4
- 2.4 adds support for IGMPv3 which is my main motivation for the upgrade
Change-Id: If2c0a524e3cba320b4a5d8cd07817c6ea2bf0c5a
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dmitry Vakhrushev [Fri, 16 Mar 2018 17:26:32 +0000 (20:26 +0300)]
FIX: Fixed ip6_fib_dump api function response.
Change-Id: I26c5d61bc2f6188bcd4ecac4b5e9385821b0398b
Signed-off-by: Dmitry Vakhrushev <dmitry@netgate.com>
Neale Ranns [Fri, 16 Mar 2018 10:22:39 +0000 (03:22 -0700)]
Remove unnumbered configuration on interface delete
Change-Id: Iae5532c3d53e208831f3b2782242d9e59d367087
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Fri, 16 Mar 2018 16:13:37 +0000 (09:13 -0700)]
cli: make q work again
After the addition of "qos" cli, "quit" command is not the only match
for "q". Therefore, add a separate "q" cli to avoid ambiguity.
Change-Id: I84f6ddce14ef7d5fa7089537cb62adfecea0e501
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Tue, 27 Feb 2018 11:45:38 +0000 (03:45 -0800)]
QoS recording and marking
Change-Id: Ie5a50def4ec1e4a3b3404a8b6ab9ec248bc16744
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Barach [Fri, 16 Mar 2018 19:21:35 +0000 (15:21 -0400)]
Fix a long-latent bi=0 bug in vlib_buffer_add_data
Change vlib_buffer_add_data() so it interprets ~0 to mean please
allocate a new buffer, instead of 0. Fixed a couple of calls to pass
~0 instead of 0.
Zero has always been a valid buffer index, we never happened to
actually use it until recent buffer allocator changes.
The presenting symptom: ASSERT failure when running "make
TEST=test_mpls test-debug"
Change-Id: Ic909913c1d464b3434d6d47e0c58f978806854d5
Signed-off-by: Dave Barach <dave@barachs.net>
Juraj Sloboda [Thu, 1 Feb 2018 14:18:49 +0000 (15:18 +0100)]
IPv6 ND Router discovery control plane (VPP-1095)
Change-Id: I4b5b60e7c6f618bb935eab1e96a2e79bbb14f58f
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
Klement Sekera [Thu, 30 Nov 2017 06:00:31 +0000 (07:00 +0100)]
stats: allow configuring poller delay
This introduces a startup config option for configuring stats poller delay.
Use `stats { interval <seconds> }` to configure the delay at startup.
The default value remains unchanged - 10 seconds.
Change-Id: If12cb1f7f6f1f8ecfa461561bc77847cdf260388
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Matus Fabian [Fri, 16 Mar 2018 12:44:24 +0000 (05:44 -0700)]
IPSec: fix IPv6 policy deleting
Change-Id: I9f487d6033edde09557709f94f97fc8a70246b09
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Neale Ranns [Fri, 16 Mar 2018 12:08:24 +0000 (05:08 -0700)]
remove spurious print statements from DVR tests
Change-Id: I3b1c71b144b4760922a467086fcdb410cd225c57
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Thu, 15 Mar 2018 23:54:30 +0000 (00:54 +0100)]
Fix sample-plugin build on ubuntu 18.04
Change-Id: Ia10aadc7f969b20e8cd50989230a80e7e21cbff4
Signed-off-by: Damjan Marion <damarion@cisco.com>
Juraj Sloboda [Mon, 15 Jan 2018 09:39:21 +0000 (10:39 +0100)]
IPv6 ND Router discovery data plane (VPP-1095)
Add API call to send Router Solicitation messages.
Save info from incoming Router Advertisement messages and notify listeners.
Change-Id: Ie518b5492231e03291bd4c4280be4727bfecab46
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
Florin Coras [Thu, 15 Mar 2018 14:45:27 +0000 (07:45 -0700)]
session: allow local host binds
Change-Id: I906bbc5bc75279f210093fb9276db9e35ee44c1f
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Thu, 15 Mar 2018 18:36:41 +0000 (19:36 +0100)]
remove bootstrap from top-level Makefile
Change-Id: I9f2a1ba9153ff57958b230a1ba2afeb9df50fd45
Signed-off-by: Damjan Marion <damarion@cisco.com>
Keith Burns (alagalah) [Thu, 15 Mar 2018 17:04:20 +0000 (10:04 -0700)]
Update session local address is_ip4 on bind when not global
Change-Id: I73ddca5a86e83c9f547778828bb49d2bd4675eaf
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Dave Wallace [Thu, 15 Mar 2018 00:01:28 +0000 (20:01 -0400)]
make test: Add VCL iperf3 tests
Change-Id: I101a44aa4913bee8d9a1aa37822e8e7e61c7aa1d
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Florin Coras [Fri, 9 Mar 2018 21:05:53 +0000 (13:05 -0800)]
tls: add openssl engine
Change-Id: I6c215858d2c9c620787632b570950b15274c0df2
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ole Troan [Wed, 14 Mar 2018 19:39:40 +0000 (20:39 +0100)]
IPIP: Linter on test_*.py
Change-Id: Icd491e382a2da0e5d55a673458605bc37e39b669
Signed-off-by: Ole Troan <ot@cisco.com>
Vijayabhaskar Katamreddy [Wed, 14 Mar 2018 21:04:27 +0000 (14:04 -0700)]
Add a helper function to fetch vlib node index for already stacked dpos
Change-Id: Ie07c6f3723312ce88046570dcbe591b72724657b
Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Damjan Marion [Wed, 14 Mar 2018 21:09:22 +0000 (22:09 +0100)]
use system provided ccache links
Change-Id: I0860bbd0cf368fc3638b861504ebf642ee9d3807
Signed-off-by: Damjan Marion <damarion@cisco.com>
Jon Loeliger [Wed, 14 Mar 2018 19:08:43 +0000 (14:08 -0500)]
IPIP: Also publish the ipip.api.h file.
Change-Id: I0b1237db541b752393483496ea19dec55799454e
Signed-off-by: Jon Loeliger <jdl@netgate.com>
Damjan Marion [Wed, 14 Mar 2018 19:58:39 +0000 (20:58 +0100)]
fix 'make build'
Change-Id: I4ec24ffd39f83d9c2d4115e7a06a5eb84a08aae8
Signed-off-by: Damjan Marion <damarion@cisco.com>
Klement Sekera [Wed, 14 Mar 2018 17:14:49 +0000 (18:14 +0100)]
make test: early core detection, code cleanup
Change-Id: I503d69f902f1c8d3107fb3f2b9f31b0083ebb747
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Dave Barach [Tue, 13 Mar 2018 16:54:43 +0000 (12:54 -0400)]
Clean up vpp build bootstrap step
Net of rewriting vppapigen in python-ply, there's no need to compile
vppinfra.
Install a copy of vppapigen in .../build-root/tools/bin, so
the sample plugin build will work. Rationalize suffix-rules.mk.
Add clang, clang++ links to .../build-root/ccache-bin.
Change-Id: Ib4017848b7767b6054238ea544ee5319667c3659
Signed-off-by: Dave Barach <dave@barachs.net>
Billy McFall [Wed, 14 Mar 2018 13:34:02 +0000 (09:34 -0400)]
VPP-1197: SELinux: 'create tap' (vhost-net backend TAP) fails when
SELinux is enable
Update the SELinux Policy to allow management of the new vhost-net
backend TAP interface.
Change-Id: I2d0633a7fce2ee2a4d6e0008ab13599647c14f42
Signed-off-by: Billy McFall <bmcfall@redhat.com>
Damjan Marion [Tue, 13 Mar 2018 20:32:17 +0000 (21:32 +0100)]
vlib: internal buffer manager rework
- buffer_main is no longer part of vlib_main_t
- pool of free lists is still part of vlib_main_t
- mheap is not used anymore for buffer allocation
- simple bitmap bassed buffer alloc scheme is introduced
Change-Id: I3e1e6d00e2c8122293ed0a741245eb841315a1ff
Signed-off-by: Damjan Marion <damarion@cisco.com>
Szymon Sliwa [Wed, 14 Mar 2018 11:54:55 +0000 (11:54 +0000)]
Prevent calling rte_eth_xstats_get not initialized dev
DPDK API forbids calling rte_eth_xstats_get on a port
which has not been setup up yet.
Citing the DPDK docs (reformated):
"
The functions exported by the application Ethernet API to setup a device
designated by its port identifier must be invoked in the following order:
rte_eth_dev_configure()
rte_eth_tx_queue_setup()
rte_eth_rx_queue_setup()
rte_eth_dev_start()
Then, the network application can invoke, in any order, the functions
exported by the Ethernet API to get the MAC address of a given device,
to get the speed and the status of a device physical link, to
receive/transmit [burst of] packets, and so on.
"
original can be found here:
http://dpdk.org/doc/api/rte__ethdev_8h.html#
a36ba70a5a6fce2c2c1f774828ba78f8d
Change-Id: I91854b8b0dd12dd028b4b36665cca49f16eac24c
Signed-off-by: Szymon Sliwa <szs@semihalf.com>
Ole Troan [Thu, 8 Mar 2018 11:30:43 +0000 (12:30 +0100)]
IPIP: Add IP{v4,v6} over IP{v4,v6} configured tunnel support.
Change-Id: I166301c9e2388bae5f70ec0179d663a2703e27f5
Signed-off-by: Ole Troan <ot@cisco.com>
Dave Wallace [Tue, 13 Mar 2018 23:31:16 +0000 (19:31 -0400)]
socket_test.sh: Don't hard code debug image with gdb.
Change-Id: Idd6c175b9102c74621c027136ab4550821a23ecc
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Klement Sekera [Tue, 13 Mar 2018 20:22:32 +0000 (21:22 +0100)]
make test: handle multiple failures in one case
Change-Id: I5451ddec4bfdede12653415f90bf991e81494033
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Dave Wallace [Tue, 13 Mar 2018 23:37:54 +0000 (19:37 -0400)]
VCL: Handle epoll HUP events in sock_test_server
Change-Id: I7b13319228c498a565f8556b73628e7ff3b106c4
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Francois Clad [Tue, 13 Mar 2018 18:03:44 +0000 (19:03 +0100)]
srv6-plugins: fixing documentation
Change-Id: I72439df585e56b3cbb7051f056fc35cddf0c864b
Signed-off-by: Francois Clad <fclad@cisco.com>
Francois Clad [Thu, 1 Feb 2018 13:51:33 +0000 (14:51 +0100)]
srv6: minor CLI modifications
'sr steer [...] via sr policy [...]' -> 'sr steer [...] via [...]'
'show sr steering policies' -> 'show sr steering-policies'
'clear sr localsid counters' -> 'clear sr localsid-counters'
Change-Id: I0efbf38753a4bd0b7fba8cd08250e136e8e55199
Signed-off-by: Francois Clad <fclad@cisco.com>
John Lo [Wed, 14 Mar 2018 01:53:18 +0000 (21:53 -0400)]
Improve l2_macs_events API to provide MAC move information
Change mac_entry layout in l2_macs_event API message so the MAC
entry can be either add, delete or move where the sw_if_index of
an existing MAC entry changed. Also added a 8-bit flags field
in mac_entry for any future expansion.
Change-Id: I3bf9e1cf2556f2938202025a5d0772c2ce2fc99f
Signed-off-by: John Lo <loj@cisco.com>
Mohsin Kazmi [Wed, 7 Mar 2018 18:53:51 +0000 (19:53 +0100)]
VOM: acl: Add support for acl ethertype unbind and dump
Change-Id: I667b9ccabe54c8f9cff5b1a2e63864965f5064f5
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Chaoyu Jin [Tue, 13 Mar 2018 14:37:41 +0000 (07:37 -0700)]
At AF_PACKET socket create, do intf bind before rx ring cfg to avoid receiving pkts from other interfaces
Change-Id: Ie40ee9129edaac717e716b469f4d10f3c29a4932
Signed-off-by: Chaoyu Jin <chjin@cisco.com>
Dave Wallace [Tue, 13 Mar 2018 23:42:02 +0000 (19:42 -0400)]
VCL: Fix race condition in event thread function
Change-Id: I8586faee0b3a40932cd711b60cebe1a23ff82a56
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Marco Varlese [Tue, 13 Mar 2018 14:44:56 +0000 (15:44 +0100)]
SCTP: data retransmission & snd_space fix
This patch addresses two things:
1) The data retransmission which needs to be taken care of when the
SCTP_TIMER_T3_RXTX;
2) The correct calculation of the amount of data transmittable
considered: the local window, the peer window and any data inflight.
Change-Id: I2d03a6cb43e4e7770c4910f8547c66e1026aeace
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Neale Ranns [Mon, 12 Mar 2018 13:59:36 +0000 (06:59 -0700)]
Common form of fib-path reproting in dumps
Change-Id: I8f6fdbbeef2ac7e9fe5d87490ae5cba6e9a0b294
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Tue, 13 Mar 2018 14:51:50 +0000 (07:51 -0700)]
FIB: DVR paths are not considered L3 attached
Change-Id: Ie473dca3264b480b007d2eb500aaa557b889c7c1
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Jakub Grajciar [Tue, 13 Mar 2018 12:57:50 +0000 (13:57 +0100)]
libmemif: ubuntu 18.04 build fix
Change-Id: I6624cacd625eea6a9b8214f67d14ec162e2c0195
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Dave Barach [Mon, 12 Mar 2018 21:38:31 +0000 (17:38 -0400)]
Rationalize plugin symbol error reporting
Change-Id: I64f2b2007f30fc1c6bd2990ba0d7ccbcd43cdb38
Signed-off-by: Dave Barach <dave@barachs.net>
Marco Varlese [Mon, 12 Mar 2018 11:36:59 +0000 (12:36 +0100)]
SCTP: cumulative SACK fix
A bug was found affecting the cumulative sending of SACK messages.
Because the next0 was never assigned to the next_output the SACK message
was never leaving the peer.
Further, two new flags have been added to distinguish when a peer is
AWAITING a SACK message (e.g. DATA is inflight and waiting to be
acknowledged).
Change-Id: Ibb5a98f7e5fed15cdc76710b74195cac031d59ed
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Jon Loeliger [Mon, 12 Mar 2018 19:50:08 +0000 (14:50 -0500)]
SPAN: Add 'is_l2" flag to DETAILS response messages.
Change-Id: I375bb0e663bc082d98a29fb101c653557ddc8f55
Signed-off-by: Jon Loeliger <jdl@netgate.com>
Dave Barach [Mon, 12 Mar 2018 19:56:41 +0000 (15:56 -0400)]
Remove md5.[ch] from vppinfra
Removed the sole use of it from ip6_neighbor.c
Change-Id: Ie53cb3b6a3a41ec0917ec2042e5006d0cfaefc01
Signed-off-by: Dave Barach <dave@barachs.net>
Dave Barach [Mon, 12 Mar 2018 13:31:36 +0000 (09:31 -0400)]
License text cleanup
Change-Id: I105375c653b1a1dce8f0f71005b281ff137c6f42
Signed-off-by: Dave Barach <dave@barachs.net>
Matus Fabian [Fri, 9 Mar 2018 13:07:35 +0000 (05:07 -0800)]
NAT44: fix nat_not_translate_output_feature in dual loop (VPP-1194)
Change-Id: Icb858414145db0e5fef495e155903b3b935e50ba
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Matus Fabian [Wed, 7 Mar 2018 12:57:22 +0000 (04:57 -0800)]
NAT44: fix nat_not_translate_output_feature for ICMP (VPP-1191)
Change-Id: I1552e1418b704fdf1f1fa2c0174313b9b82a37a3
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Andrew Yourtchenko [Wed, 7 Mar 2018 16:35:59 +0000 (17:35 +0100)]
vnet: l2-classify: prefetch (n+2, n+3) rather than (n+1, n+2) inside dual loop code
The dual loop within the L2 classifier processes the (n, n+1) packets,
the prefetching was trying to prefetch (n+1, n+2) - thus half of the
prefetches were not used - because the next iteration needs (n+2, n+3).
Change-Id: I827d20845dbdd0dcdcf463ee25661a7921428992
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
John Lo [Sat, 10 Mar 2018 00:48:42 +0000 (19:48 -0500)]
dpdk-input node packet trace intermittent on IP forwading path
Packet trace initiated by dpdk-input node would occasionally
not fully function if next node is ip4-input.
Change packet trace saving order in the quad-loop so "sho trace"
will display trace in packet receive order.
Fold calling of vlib_trace_buffer() into dpdk_add_trace().
Change-Id: I9d7a9bf3b9391f95590e66150b26b0b15912d803
Signed-off-by: John Lo <loj@cisco.com>