Florin Coras [Wed, 5 May 2021 16:54:00 +0000 (09:54 -0700)]
session: rpc for connects to main
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ifa47e1500e5cfb3c717f87b1d21131b9531c9005
Steven Luong [Fri, 14 May 2021 22:33:01 +0000 (15:33 -0700)]
lacp: coverity fix on null pointer dereference
Coverity complains on null pointer dereference. It is not likely to
happen.
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Iab726a1e2d60725cec7ab0bbd2787b62e6393d33
Florin Coras [Sat, 15 May 2021 03:11:14 +0000 (20:11 -0700)]
session: fix coverity warning
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I24484a5192d7e683507ed640f75fb37914c0efb0
Florin Coras [Fri, 14 May 2021 16:22:20 +0000 (09:22 -0700)]
tcp: remove ho lock
Half-open sessions are allocated by main thread and cleaned up on main
with timers.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I37f000920a45908b62b5501ae9d54a88a9e4c609
Damjan Marion [Fri, 14 May 2021 13:00:05 +0000 (15:00 +0200)]
vlib: remove unused code
Type: refactor
Change-Id: Ia5f670541dd43a4f6d731dda84b2d898195643fc
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 14 May 2021 12:50:01 +0000 (14:50 +0200)]
vlib: pass node runtime to vlib_buffer_enqueue_to_thread()
Mechanical change for patch following this one...
Type: improvement
Change-Id: Iee12f3a8851f35569e6c039494a94fc36e83d20f
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 14 May 2021 13:26:53 +0000 (15:26 +0200)]
avf: free spinlock on txq removal
Type: fix
Change-Id: I8e9a907a227f82b870a945b94731dc3204c23ee1
Signed-off-by: Damjan Marion <damarion@cisco.com>
Mohammed Hawari [Tue, 11 May 2021 15:28:44 +0000 (17:28 +0200)]
interface: fix converity in update_runtime_data
Change-Id: I59eb41516b5e052109428ae70660ed49126c25bb
Type: fix
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Damjan Marion [Fri, 14 May 2021 13:48:52 +0000 (15:48 +0200)]
interface: update tx queue runtime if vector size changes
Fixes issue which causes crash in case when VPP only runs with main thread.
Type: fix
Change-Id: Ia0ca973bb7e7ff81f15b37764ae248e2502bdcec
Signed-off-by: Damjan Marion <damarion@cisco.com>
liuyacan [Fri, 14 May 2021 02:11:03 +0000 (02:11 +0000)]
vcl: fix lookup listener assert
The following timing may happen:
1. vpp accept new connection, send ACCEPTED to vcl, but vcl has
not handle it
2. vcl unbind the listener, go into DISCONNECT state
3. vcl handle the ACCEPTED event
Type: fix
Signed-off-by: liuyacan <liuyacan@corp.netease.com>
Change-Id: If9a96a153af38763db062df133c2fdcc04ceba9b
Florin Coras [Thu, 13 May 2021 18:37:43 +0000 (11:37 -0700)]
session: switch ct to vc and track half-opens
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I7f9c4b9b6e523ab549087ad21724f34f08fca793
Florin Coras [Thu, 13 May 2021 15:36:56 +0000 (08:36 -0700)]
tls: switch dtls to vc and track half-opens
Also adds support for half-open support transport migration.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id04c194138956336f93246bbed0332a7030c67e2
Steven Luong [Wed, 12 May 2021 21:38:22 +0000 (14:38 -0700)]
lacp: Prohibiting bonding with remote having different key than 1st member
After forming the bonding with 1st remote member, Subsequent member must
have the same key in order to join the same bonding group.
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I9ff6d6c083a5b6a26beedbd7181d5a120cb5710b
Damjan Marion [Thu, 13 May 2021 12:19:33 +0000 (14:19 +0200)]
interface: fix tx queue runtime update
Type: fix
Change-Id: I5ce7e57ae277de26af602fe786048bf21b8612f8
Signed-off-by: Damjan Marion <damarion@cisco.com>
Dave Wallace [Thu, 13 May 2021 01:43:59 +0000 (21:43 -0400)]
tests: move test source to vpp/test
- Generate copyright year and version
instead of using hard-coded data
Type: refactor
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I6058f5025323b3aa483f5df4a2c4371e27b5914e
Nathan Skrzypczak [Wed, 12 May 2021 16:47:12 +0000 (18:47 +0200)]
quic: remove cmake --target
Type: fix
This isnt needed as we pass
CMAKE_SKIP_INSTALL_ALL_DEPENDENCY
Change-Id: I1406d84192efb9baedf7df680aca0b96bb0eef01
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Damjan Marion [Wed, 12 May 2021 09:51:08 +0000 (11:51 +0200)]
misc: change VFIO group ownership and permissions in vfctl script
This is missing step to allow runing VPP unpriviledged
with AVF driver.
Type: improvement
Change-Id: I37dfad9236691c1a8e2837a5811536170c65d7bc
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Wed, 12 May 2021 12:43:21 +0000 (14:43 +0200)]
avf: avoid eating our own tail
This happens in case we are not able to refill ring with new buffers.
Type: fix
Change-Id: I727e55c5b8482d9b8aeb4a9933a9a755fe21e55f
Signed-off-by: Damjan Marion <damarion@cisco.com>
Chenmin Sun [Mon, 10 May 2021 12:11:49 +0000 (20:11 +0800)]
flow: fix vxlan vni convert bug
This patch fixes a vxlan vni field conversion bug in flow api layer
Type: fix
Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I37b2ffb54792f48b390ff42da577db2c4869d253
Florin Coras [Tue, 11 May 2021 04:12:27 +0000 (21:12 -0700)]
tls: switch to vc service and track half-open sessions
Half-open tls sessions are now tracked by the app worker and are cleaned
up only when tcp cleans up its half-open session, i.e., independent of
when the established tls context is allocated.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If5d594d7095192dd527daf4ea1358ffeccdfcc7a
Florin Coras [Tue, 11 May 2021 18:55:07 +0000 (11:55 -0700)]
session: return connect session handle to app
App transports not supported for now. Will have to be updated
individually.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I75cb6c4e1c5af008af72858a9ee573016812abd4
Fan Zhang [Tue, 11 May 2021 11:53:15 +0000 (12:53 +0100)]
crypto: add chacha20-poly1305 support to ipsecmb
Type: feature
This patch adds chacha20-poly1305 single and chained algorithm
support to ipsecmb crypto engine.
Signed-off-by: DariuszX Kazimierski <dariuszx.kazimierski@intel.com>
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: If04ee0c8f985b07fd31dad1ce29000ec6f1733c5
liuyacan [Sun, 9 May 2021 03:50:40 +0000 (03:50 +0000)]
session: support half-close connection
Some app(e.g. Envoy) may call shutdown() instead of close() when
draining connection.
Type: improvement
Signed-off-by: liuyacan <liuyacan@corp.netease.com>
Change-Id: I9543b9ca3caa87b10b134fd1fc4019124e41e4d2
Aloys Augustin [Tue, 13 Apr 2021 19:14:55 +0000 (21:14 +0200)]
ip: ensure ttl doesn't decrease to 0 when punting
Change-Id: I248ef12fd34ea2a1c383fbcc530a8ffeb31ba92b
Type: fix
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
Damjan Marion [Thu, 15 Apr 2021 11:12:51 +0000 (13:12 +0200)]
interface: tx queue infra
Type: improvement
Change-Id: I415b2f980de10ca3154d2c8677c24792453eccd0
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Mon, 10 May 2021 12:51:44 +0000 (14:51 +0200)]
build: compiler flags handling cleanup
Type: make
Change-Id: I51f30edb91e09525ba116fe3941f2e43f9718da7
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Tue, 11 May 2021 00:21:06 +0000 (17:21 -0700)]
quic: alloc ctx on udp thread
UDP sessions are allocated on first worker because main does not poll.
Consequently, quic should also allocate connection on first, to avoid
multiple migration events.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ice229a42c399e87150e0f6dd76e2e06ab271556c
Nathan Skrzypczak [Fri, 7 May 2021 17:39:51 +0000 (19:39 +0200)]
vppinfra: Add missing %o
This is used in vppinfra/socket.c:495
Type: feature
Change-Id: I89b409ae7abb01723108ae3e6c55bb1675db50ee
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Dave Barach [Mon, 10 May 2021 23:01:42 +0000 (19:01 -0400)]
vlib: exec cmd handle scripts with blank lines
Type: fix
Fixes:
2f96e7648b9b7d501088eddff7e4a761973e71f4
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ia75c863850c0df978f61bfc0343a167d8636ed97
hemant_mnkcg [Tue, 27 Apr 2021 22:02:13 +0000 (18:02 -0400)]
misc: fix crash in lawful intercept CLI
Type: fix
Signed-off-by: hemant_mnkcg <hemant@mnkcg.com>
Change-Id: I097815617053dac09de7ad3092b3d3071770114f
Florin Coras [Sat, 8 May 2021 02:39:43 +0000 (19:39 -0700)]
session: use half-open sessions for vc establishment
Use half-open sessions to track virtual circuit connection
establishment. These sesssions can only be allocated and freed by the
thread that allocates half-open connections (main). Consequently, they
can only be freed on half-open cleanup notifications from transports.
Goal is to simplify state tracking within the session layer but it's
also a first step towards allowing builtin apps to track and cleanup
outstanding connects.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I8a535906d13eb7f8966deb82333839de80f8049f
Benoît Ganne [Mon, 10 May 2021 12:10:19 +0000 (14:10 +0200)]
dpdk: do not crash when failing to bring interface up
If dpdk device starts failed for some reason, we should not try to get
stats and the interface must remain down.
Type: fix
Change-Id: I0079f89d3b43a9b47553991347da8ed4ce6ede8d
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Mon, 10 May 2021 12:07:49 +0000 (14:07 +0200)]
rdma: bump to rdma-core v35.0
Type: improvement
Change-Id: I5f7ff309aacbfd7a5a8a973bcc7ba04ba44923c5
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Florin Coras [Sat, 8 May 2021 22:29:50 +0000 (15:29 -0700)]
svm: try chunk alloc only if enough space available
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I3c52dd783601d50e981f75bd05a7b95c03bb5c22
Mohsin Kazmi [Wed, 5 May 2021 16:25:39 +0000 (16:25 +0000)]
gso: fix the gro coalesced chain len
Type: fix
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: I86b940384a6898d4cb04f3decf30996c94b43d07
wanghanlin [Sat, 8 May 2021 03:39:53 +0000 (11:39 +0800)]
api: fix crash in vl_msg_api_free
VPP crash when ASSERT in clib_mem_free.
Type: fix
Signed-off-by: wanghanlin <wanghanlin@corp.netease.com>
Change-Id: Id06d833caab3385446528d62a6ed3bde38d57db0
Steven Luong [Thu, 6 May 2021 17:00:30 +0000 (10:00 -0700)]
vhost: low performance in interrupt mode in some cases
When vhost and another interface, say tap, are configured for interrupt
mode, performance number may be very low from vhost.
Further analysis discovers that when vhost posts an interrupt to the
RX infra, there is a 10 msec delay in waking up its input routine.
The delay is due to vhost posts the interrupt from the main thread
which tries to wake up the worker thread.
The fix is for vhost to move the posting interrupt call to the
corresponding input worker thread by calling
vnet_hw_if_set_rx_queue_file_index() to set it up.
While at it, streamline the function vhost_user_kickfd_read_ready()
since it will be called from the worker thread.
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I9beedcd33e1558c8335da4ee7fadc51c29ee4589
Nathan Skrzypczak [Fri, 7 May 2021 16:16:58 +0000 (18:16 +0200)]
memif: Fix delete on error
Type: fix
Change-Id: I3cc09630cae999cc194a0eedb4d2cfee7a826b76
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Mohammed Hawari [Fri, 7 May 2021 15:27:51 +0000 (17:27 +0200)]
avf: fix coverity
Change-Id: I54025eb0e4ee861b2b2fed554b006405cba38bb9
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: fix
Fixes:
bd376a8ce8425f45b23074398949e8055de29280
Dave Wallace [Sat, 8 May 2021 01:40:54 +0000 (21:40 -0400)]
tests: fix another race condition in punt tests
- Don't close the socket and don't stop receiving
until after draining the existing data in the
socket.
Type: fix
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I38dfff4d6273eeddb5196f5cf2a60b580e1c93e6
Fan Zhang [Fri, 7 May 2021 11:50:18 +0000 (12:50 +0100)]
dpdk: fix cryptodev session handler
Type: fix
This patch fixes the possible segmentation fault in DPDK
cryptodev when deleting session.
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: Ie81de09f7250eb5c1ed6ee471363137d8372fe27
Damjan Marion [Fri, 7 May 2021 07:20:54 +0000 (09:20 +0200)]
build: bump ipsecmb version to 1.0
Type: improvement
Change-Id: If2c0db46805c0a8c995a76938f049568f57f7560
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Thu, 6 May 2021 22:32:14 +0000 (15:32 -0700)]
session: connects seg manager is always first
By convention, connects segment manager will be first. Therefore it will
be the one with the first segment wherein lies the app's message queue.
Saves us the trouble of allocating it on first connect, if app started
by listening, and we no longer need to track if it's assignable to a
listener or if it can be removed.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iba9a8ffaab618eeb41ec2144dcfee62d006dc7a2
Nathan Skrzypczak [Tue, 4 May 2021 13:46:33 +0000 (15:46 +0200)]
avf: Fix cksum offload / ipsec
VNET_BUFFER_F_OFFLOAD means 'check 2nd cacheline'
but we can still have TCP_CKSUM=0 & UDP_CKSUM=0
Type: fix
Change-Id: I42b5974f6d34b777aa959c06c67619a5c83c5805
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Damjan Marion [Thu, 6 May 2021 15:34:49 +0000 (17:34 +0200)]
vppinfra: add universal array mask_compare and compress funcs
Type: improvement
Change-Id: I6d812339f626ea630ad9354632d2f9506122d379
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Thu, 6 May 2021 19:46:04 +0000 (12:46 -0700)]
vcl: add dtls test
Type: test
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I726ab3a22399e970b0dd37a5b174062137265914
Damjan Marion [Thu, 6 May 2021 18:48:34 +0000 (20:48 +0200)]
build: add FORCE_ON option for multiarch variants
Type: make
Change-Id: I37fb925a9cc2dfc21dd7874f4b20a6943b28efc8
Signed-off-by: Damjan Marion <damarion@cisco.com>
Dave Wallace [Thu, 6 May 2021 19:59:59 +0000 (15:59 -0400)]
tests: fix race condition in punt tests
Type: fix
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I6cb13e044bbb966cbb61802094e96220d3a0c951
Damjan Marion [Tue, 4 May 2021 07:37:56 +0000 (09:37 +0200)]
build: fix ./configure help
Type: make
Change-Id: I2479f1f84d32bf3e7266625a01174c1706bea7be
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Thu, 6 May 2021 19:24:40 +0000 (12:24 -0700)]
vcl: move tests to src/tests
Type: refactor
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If622dfcc6f98d90cac0487e6bb9eb8c0bb01cf85
Ole Troan [Thu, 6 May 2021 09:02:37 +0000 (11:02 +0200)]
stats: move vector_rate counters into provider
Type: improvement
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Iae1fb59a6dc9679c0fa0b87fa5232d551a7995a5
Ole Troan [Thu, 6 May 2021 14:15:35 +0000 (16:15 +0200)]
vlib: remove unused simple counters fields
Type: improvement
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I46cfdcd02e5fda310367da17532cd2f355044811
Signed-off-by: Ole Troan <ot@cisco.com>
Florin Coras [Thu, 6 May 2021 07:08:18 +0000 (00:08 -0700)]
vcl: reduce iperf tests output
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia6197e99ebc42367624da27387216dc4cdb3141b
Florin Coras [Thu, 6 May 2021 03:48:02 +0000 (20:48 -0700)]
vppinfra: export unserialize_elog_main for g2
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ifb322a7eb7ca14c3561ea34e40b80e3d1ce1b6a5
Damjan Marion [Thu, 6 May 2021 15:28:12 +0000 (17:28 +0200)]
vppinfra: fix tests
Type: fix
Change-Id: If59a66aae658dd35dbcb4987ab00c306b3c6e2e2
Signed-off-by: Damjan Marion <damarion@cisco.com>
Ole Troan [Thu, 6 May 2021 12:09:50 +0000 (14:09 +0200)]
vlib: rename vl_counter_t to vlib_error_desc_t
Type: improvement
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I368b0410db2d633d3c52199c840e24d21952c1b4
Ole Troan [Wed, 5 May 2021 07:23:17 +0000 (09:23 +0200)]
stats: memory heap counters
- Add counters for the main-heap
- Add additional counters per heap:
STAT_MEM_TOTAL
STAT_MEM_USED,
STAT_MEM_FREE,
STAT_MEM_USED_MMAP,
STAT_MEM_TOTAL_ALLOC,
STAT_MEM_FREE_CHUNKS,
STAT_MEM_RELEASABLE,
The per-heap counters are organised as a two dimensional vector.
total, used and free are directly available via symlinks.
vpp_get_stats ls "^/mem/"
/mem/stat segment
/mem/stat segment/total
/mem/stat segment/used
/mem/stat segment/free
/mem/main heap
/mem/main heap/total
/mem/main heap/used
/mem/main heap/free
vpp_get_stats dump "^/mem/main\ heap$"
[0 @ 0]:
1073741776 packets /mem/main heap
[1 @ 0]:
91586688 packets /mem/main heap
[2 @ 0]:
982155088 packets /mem/main heap
[3 @ 0]: 0 packets /mem/main heap
[4 @ 0]:
1073741776 packets /mem/main heap
[5 @ 0]: 433 packets /mem/main heap
[6 @ 0]:
981708688 packets /mem/main heap
Type: feature
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I36725dde3b4b3befd27a8b4d3ba931f2d3b627cc
Ole Troan [Thu, 6 May 2021 11:39:55 +0000 (13:39 +0200)]
pnat: coverity errors
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ic38cfbdcab86172bad6ec6cb4c66c83f8deed64f
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Wed, 10 Mar 2021 11:52:53 +0000 (12:52 +0100)]
memif: add severity to counters
Also rename counters in stat segment to make them more filesystem friendly.
Type: improvement
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8a3f3ec318931f5475fcb181f8b4a079a1fa4b9c
Signed-off-by: Ole Troan <ot@cisco.com>
Mohsin Kazmi [Wed, 5 May 2021 12:26:38 +0000 (14:26 +0200)]
vlib: fix the offload flags size
Type: fix
Change-Id: I433fe3799975fe3ba00fa30226f6e8dae34e88fc
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Damjan Marion [Wed, 5 May 2021 18:06:39 +0000 (20:06 +0200)]
vppinfra: enfoce function pointer cast in CLIB_MARCH_FN_POINTER
Type: improvement
Change-Id: I6ba9f9467a3990f1436a60b1dbc6cb795fd18ba9
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Wed, 5 May 2021 17:31:41 +0000 (19:31 +0200)]
vppinfra: fix x86 packs / packus wrappers
They both take signed value as input.
Type: fix
Change-Id: If3d8ec4e0b1c02d7d65262bdd9db49ff7fbfef39
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Wed, 5 May 2021 12:36:04 +0000 (14:36 +0200)]
avf: remove dead store
Type: fix
Change-Id: Ic8d965aecea6b5b729e3f414235e676d62de779a
Signed-off-by: Damjan Marion <damarion@cisco.com>
Maxime Peim [Thu, 15 Apr 2021 11:52:12 +0000 (13:52 +0200)]
vlib: fix adaptive mode flag unset on nodes reforking
The adaptive mode flag is being unset on
nodes reforking. The flag is copied in order
to avoid this issue.
Old flags are copied for all nodes.
Type: fix
Signed-off-by: Maxime Peim <mpeim@cisco.com>
Change-Id: Ic29b20fc0e4454ce4b3765c478f55bf650b4572a
Filip Varga [Mon, 3 May 2021 11:45:16 +0000 (13:45 +0200)]
nat: cli commands parsing fix
Newline get's ignored when parsing configuration file.
Type: fix
Signed-off-by: Filip Varga <fivarga@cisco.com>
Change-Id: Ib4f86177150dfe3bc085231a9268cf730490ea81
Filip Varga [Tue, 4 May 2021 14:27:33 +0000 (16:27 +0200)]
nat: fixing cfg file parsing cli issues
Type: fix
Change-Id: I35012bb2f7af1996c954641af40f3223bc7f37e4
Signed-off-by: Filip Varga <fivarga@cisco.com>
Damjan Marion [Wed, 5 May 2021 08:24:38 +0000 (10:24 +0200)]
build: set CMAKE_EXPORT_COMPILE_COMMANDS
Type: make
Change-Id: I8c59c91b4af49efcfcf7544df01b3d20511abe52
Signed-off-by: Damjan Marion <damarion@cisco.com>
Mohsin Kazmi [Fri, 23 Apr 2021 13:16:50 +0000 (15:16 +0200)]
vlib: move offload flags to 1st cacheline in vlib_buffer_t
Type: improvement
Some tests i.e. ipsec see performance regression when offload flags
are moved to 2nd cacheline. This patch moves them back to 1st cacheline.
Change-Id: I6ead45ff6d2c467b0d248f409e27c2ba31758741
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Matthew Smith [Wed, 28 Apr 2021 16:48:39 +0000 (11:48 -0500)]
misc: ipfix process node wait time adjustment
Type: fix
The ipfix process node has a hardcoded 5s sleep between sending packets.
The interval between template packets is configurable, but the timing
of packets being sent does not match configuration because of the time
being hardcoded. E.g. -
With template interval set to 3s, a packet will be sent every 5s.
With template interval set to 8s, a packet will be sent every 10s.
Honor the configuration by reducing the wait time to less than 5s if a
template will need to be sent less than 5s from the current time.
Change-Id: I8c11f7bc502ce5b20b6e82a7e7a135a8805a2bad
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Paul Vinciguerra [Wed, 5 May 2021 04:19:00 +0000 (00:19 -0400)]
api: fix crash in custom dump
Change-Id: Iffc52b4f52c235b0b5d13d2b42467cb2be0bf934
Type: fix
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Filip Tehlar [Mon, 3 May 2021 15:29:56 +0000 (15:29 +0000)]
crypto crypto-openssl: support hashing operations
Type: feature
Change-Id: I36041fe5c5f0ff129aee42516189807e96f62123
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Florin Coras [Wed, 5 May 2021 02:30:58 +0000 (19:30 -0700)]
tcp: cleanup rcv-process and bulk buffer translation
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2ca8a5e30e55a84d4567422e4b7fcf90830921d3
Florin Coras [Tue, 4 May 2021 21:53:25 +0000 (14:53 -0700)]
tcp: cleanup listen node and bulk buffer translation
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2d11b1411a7653b94fddd889a5f28640c5f5566c
Florin Coras [Wed, 5 May 2021 00:08:49 +0000 (17:08 -0700)]
tcp: cleanup syn-sent and bulk buffer translation
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Idb286e77a877a6a60aa532263277f002fc002e48
Florin Coras [Fri, 23 Apr 2021 01:53:30 +0000 (18:53 -0700)]
tcp: cleanup established and bulk buffer translation
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ic37f640b7f0d0a041c003e76c8f29c21b5e664b3
Mohsin Kazmi [Tue, 4 May 2021 14:36:09 +0000 (16:36 +0200)]
virtio: add simple drop counter for interface
Type: improvement
Change-Id: I4ac6b1a6553e26a5c26b6761fa3c4cc5d4925486
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Mohsin Kazmi [Wed, 28 Apr 2021 16:55:45 +0000 (18:55 +0200)]
virtio: fix the interrupt
Type: fix
virtio/tap interfaces set the empty buffers in the input node
for receiving data. Backend uses those buffers, fills them with
data and notifies the virtio/tap driver. But virtio/tap driver
gets into stall state if interface is created and configured
through exec script on VPP startup.conf and put the interface in
interrupt mode while VPP is only configured with main thread.
This patch fixes the problem by prefilling buffers during the
interface creation.
Change-Id: Ibc4d0e70e127ccc4b7cf8b2b18406ae4b02c73b4
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Arthur de Kerhor [Thu, 11 Mar 2021 18:26:54 +0000 (10:26 -0800)]
stats: adding symlinks for nodes and interfaces in the stat segment
A given interface counter (e.g rx) can be accessed via
/interfaces/<interface_name>/<counter_name>.
Same goes with nodes: /nodes/<node_name>/<counter_name>
As interfaces may contain '/' in their names,
these are replaced by '_' in symlinks
Also added 2 tests for the stat segment
Type: feature
Signed-off-by: Arthur de Kerhor <arthurdekerhor@gmail.com>
Change-Id: I27da252e7b3dc177815616ca46b5c200a456bf0f
Signed-off-by: Ole Troan <ot@cisco.com>
Ray Kinsella [Tue, 4 May 2021 09:07:26 +0000 (10:07 +0100)]
dpdk: allow configuration of max-simd-bitwidth
Enable configuration of DPDK's max-simd-bitwidth through the startup.conf
Type: improvement
Change-Id: I455148714ffc7caa257931526f310dbefd7ab01c
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Mohammed Hawari [Tue, 4 May 2021 09:34:37 +0000 (11:34 +0200)]
misc: improve src detection in configure script
Change-Id: I2c45b160d76883044a3a7db0afcac0c56bcd2bcf
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: feature
Mohammed Hawari [Tue, 4 May 2021 08:15:32 +0000 (10:15 +0200)]
avf: fix simultaneous txq wrap and tx retry
Change-Id: Ic2b853cda98c3010d2abb5c7ada1b1f6c5bc9f74
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: fix
Fixes:
ca1812dbe714fc8e4de13f88df2d3b830d95a2c9
Ticket: VPP-1980
Benoît Ganne [Wed, 17 Mar 2021 13:41:33 +0000 (14:41 +0100)]
rdma: add support for RSS configuration
Type: feature
Change-Id: I911ee94b624ef5edf46b34666597eff93df1d1ed
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Mon, 3 May 2021 15:02:39 +0000 (17:02 +0200)]
rdma: support non-power-of-2 number of rxq
Type: improvement
Change-Id: I7b78a8470aa3fd271120587d08e82afb23cb195b
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Damjan Marion [Mon, 3 May 2021 10:40:27 +0000 (12:40 +0200)]
build: add set-build-type-* targets to CMake
Type: make
Change-Id: Icf37873b461cd034567dc1b99e23d1bbb3f4b9f0
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Mon, 3 May 2021 15:34:53 +0000 (08:34 -0700)]
quic: fix coverity warning
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I277f2e9ae2b763f5833778406d11218211163e43
liuyacan [Fri, 30 Apr 2021 08:57:37 +0000 (08:57 +0000)]
session: lookup listener with iface address
We add interface address to the global lookup table, so we should
use it as the key when lookup listener. Otherwise, when multiple
threads listen on 0.0.0.0 (local scope disable), duplicate
listeners and sessions would be allocated but only one works.
Type: fix
Signed-off-by: liuyacan <liuyacan@corp.netease.com>
Change-Id: I86f36475c16e217c6c5293a62c4fb5c9477a191e
Damjan Marion [Tue, 27 Apr 2021 16:23:20 +0000 (18:23 +0200)]
rdma: avoid unnencessary inlining
Type: fix
Change-Id: Ifc4b30675365ebb5d69c018a34fd17a5090b30e1
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Sat, 1 May 2021 12:56:13 +0000 (14:56 +0200)]
vlib: multiarch vlib_frame_queue_dequeue()
Fact that it needs to copy buffer indices justifies this move.
Type: improvement
Change-Id: I5eb815ccc4cca0ef70b092eb83a49b713efdcbeb
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Sat, 1 May 2021 00:50:29 +0000 (17:50 -0700)]
quic: improve udp dgram write
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2992c66d11fe6adc96b525b0fde533e5ff58d7e4
Florin Coras [Sun, 2 May 2021 02:01:42 +0000 (19:01 -0700)]
tls: cleanup dtls migrated context
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I433cc1b7a29f785a431618641317bbfbbe2cf2f4
Florin Coras [Sat, 1 May 2021 23:01:40 +0000 (16:01 -0700)]
vcl: attr api to set endpt ext config
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I06cd3721c1b534e9449bf96760c02ca30628c21e
Benoît Ganne [Thu, 4 Mar 2021 13:31:03 +0000 (14:31 +0100)]
vlib: refactor trajectory trace debug feature
trajectory trace has been broken for a while because we used to save the
buffer trajectory in a vector pointed to in opaque2. This does not work
well when opaque2 is copied (eg. because of a clone) as 2 buffers end up
sharing the same vector.
This dedicates a full cacheline in the buffer metadata instead when
trajectory is compiled in. No dynamic allocation, no sharing, no tears.
Type: refactor
Change-Id: I6a028ca1b48d38f393a36979e5e452c2dd48ad3f
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Damjan Marion [Fri, 30 Apr 2021 17:31:09 +0000 (19:31 +0200)]
build: add option to turn off some march variants
Type: make
Change-Id: I53f7995c7e7a7ff829c662d71f37d88780bdd140
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 30 Apr 2021 18:27:53 +0000 (20:27 +0200)]
build: declare some CMake variables as advanced
Type: make
Change-Id: I780c1c81a50cb92bc89c05856efd8ef88479c0ab
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 29 Apr 2021 16:47:25 +0000 (18:47 +0200)]
misc: experimental configure script
Type: make
Change-Id: Iaeb9d22eec9a7a763b63899814a44e78c8050f1f
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Fri, 30 Apr 2021 00:07:06 +0000 (17:07 -0700)]
quic: report number of packets sent on custom tx
A transport's custom_tx function must report the number of segments that
it enqueued.
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ie088c4215e6f17df639159820b8adf46b96fbb46
Florin Coras [Fri, 30 Apr 2021 04:28:03 +0000 (21:28 -0700)]
hsa: vcl test client incremental stats
Add option to print per second tx stats
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I7f226a6521da13ab29de65a441f73d4e56fb57cf
Damjan Marion [Fri, 30 Apr 2021 09:11:08 +0000 (11:11 +0200)]
build: switch release build to -O3
Type: make
Change-Id: Ia39c2f847e7b4907fdd3fcac75897b8b4c545a65
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Thu, 29 Apr 2021 18:55:23 +0000 (11:55 -0700)]
session: accept notifies for sessions in created state
Makes sure we don't notify apps of sessions that are closing or multiple
times for the same session.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I07145e5e00bbe8eb1df2946059459e9fe05cfeb7
liuyacan [Wed, 28 Apr 2021 11:34:03 +0000 (11:34 +0000)]
session: cleanup CREATED sessions when listener goes down
We should cleanup sessions in CREATED state when listener goes
down, otherwise they may use unpredictable sessions as listeners
later.
Type: fix
Signed-off-by: liuyacan <liuyacan@corp.netease.com>
Change-Id: Ifbd0a0fb46275bd9d89e5aee19a70c1d01d15764