Florin Coras [Wed, 4 Nov 2020 21:08:35 +0000 (13:08 -0800)]
session: fix ct server session thread index
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I835b61f0b88a7324b09d82400debd78ad8b95401
Benoît Ganne [Thu, 8 Oct 2020 12:08:47 +0000 (14:08 +0200)]
build: better detection of libbpf dependencies
Type: fix
Change-Id: Ib496e6eb0a76e6268aea09d5f4495f3ecd921ec2
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Dave Barach [Tue, 3 Nov 2020 14:59:06 +0000 (09:59 -0500)]
vlib: add postmortem pcap dispatch trace
Inspired by a real-life conundrum: scenario X involves a vpp crash in
ip4-load-balance because vnet_buffer(b)->ip.adj_index[VLIB_TX] is
(still) set to ~0.
The problem takes most of a day to occur, and we need to see the
broken packet's graph trajectory, metadata, etc. to understand the
problem.
Fix a signed/unsigned ASSERT bug in vlib_get_trace_count().
Rename elog_post_mortem_dump() -> vlib_post_mortem_dump(), add
dispatch trace post-mortem dump.
Add FILTER_FLAG_POST_MORTEM so we can (putatively) capture a ludicrous
number of buffer traces, without actually using more than one dispatch
cycle's worth of memory.
Type: improvement
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: If093202ef071df46e290370bd9b33bf6560d30e6
Mohammed Hawari [Mon, 2 Nov 2020 13:05:03 +0000 (14:05 +0100)]
rdma: various fixes for chained buffers tx
Type: fix
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Change-Id: I428c87e581db335362fef30e274db8947a896416
Filip Tehlar [Fri, 30 Oct 2020 04:47:44 +0000 (04:47 +0000)]
ikev2: add option to disable NAT traversal
Type: feature
Ticket: VPP-1935
Change-Id: I705f84047b112279377590157a1c7b4a34f693d2
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Filip Tehlar [Fri, 30 Oct 2020 05:28:11 +0000 (05:28 +0000)]
ikev2: fix reply during rekey
Type: fix
Change-Id: If87f4b8ae92508215fe91178958fe2ddb91e5a35
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Filip Tehlar [Fri, 30 Oct 2020 05:59:55 +0000 (05:59 +0000)]
ikev2: increase tick interval in process node
This helps to resolve sporadic failures in unit tests.
Type: fix
Change-Id: I3abd77ed74310f9729a841e8569eafe6d7758dcb
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Simon Zhang [Tue, 3 Nov 2020 15:48:03 +0000 (23:48 +0800)]
tls: fix picotls engine crypto multi-thread issue
Type: fix
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: Ib454ccae5a81f91a744db82b72c7f1fcb29aa0cc
Florin Coras [Tue, 3 Nov 2020 03:00:10 +0000 (19:00 -0800)]
session: reduce max session node frame size
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I9e6b5e245533c9ea7bb8dc4f784a31fcb0da88bd
Klement Sekera [Mon, 26 Oct 2020 13:42:41 +0000 (13:42 +0000)]
nat: bihash: fix buckets calc and remove mem param
Calculate bihash buckets as n_elts / 2.5 rounded to closest pow2
per Damjan's recommendation. Remove memory configuration parameters
because bihash init ignores them anyway as it resides in main heap now.
Type: improvement
Change-Id: I189f463f3c4640106cce4f12d3c5a62969276a82
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Filip Tehlar [Fri, 30 Oct 2020 05:52:19 +0000 (05:52 +0000)]
ikev2: cli for disabling dead peer detection
Type: feature
Change-Id: I0db0a9b2f872753fa64d27335838cb34645a9ee8
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Benoît Ganne [Tue, 20 Oct 2020 12:07:55 +0000 (14:07 +0200)]
nat: fix nat64 disable
- we should not copy and iterate over the pool underlying vector, as
slots can be freed (ie in the freelist).
- delete interface instead of adding them again
- fix the log message
Type: fix
Change-Id: If0a7a2f475b4f40793eb29ea80a9d29fe5d1bcb9
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Filip Tehlar [Fri, 30 Oct 2020 05:00:18 +0000 (05:00 +0000)]
ikev2: fix memory leak
Type: fix
Change-Id: I33c38c791cc9a28898de402ae831c4862073eb2d
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Neale Ranns [Thu, 2 Jan 2020 04:06:10 +0000 (04:06 +0000)]
ipsec: Tunnel SA DSCP behaviour
Type: feature
- use tunnel_encap_decap_flags to control the copying of DSCP/ECN/etc
during IPSEC tunnel mode encap.
- use DSCP value to have fixed encap value.
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: If4f51fd4c1dcbb0422aac9bd078e5c14af5bf11f
Florin Coras [Thu, 29 Oct 2020 04:22:04 +0000 (21:22 -0700)]
vcl: support fifo segments with ct sessions
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Icf0194f569da88f26a4cba29d8fe75a0bddfc144
Florin Coras [Wed, 28 Oct 2020 23:41:26 +0000 (16:41 -0700)]
session: fix ct cleanup before full establishement
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I58fb0e05f62eae45818c23e8e148ff6758ba463a
Florin Coras [Wed, 28 Oct 2020 07:37:15 +0000 (00:37 -0700)]
vcl session: minimize ct io events
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ic4072fbc182fff38a28b415be0bb16f0559a4064
Mohsin Kazmi [Wed, 28 Oct 2020 18:35:53 +0000 (19:35 +0100)]
tap: fix the segv
Type: fix
Change-Id: I53cb96950f8658d7159fb0bd8ecfa50b6977e5af
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Florin Coras [Wed, 28 Oct 2020 19:51:10 +0000 (12:51 -0700)]
vcl: fix epoll fd cleanup
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2886155495ac0e518b9dc09856132cc2f6843503
Dave Barach [Wed, 28 Oct 2020 18:56:12 +0000 (14:56 -0400)]
build: explicitly stop vpp in vpp.preinst
Otherwise, "dpkg -i <vpp-debian-packages>" hangs. This is a new
behavior.
Type: improvement
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I614e6d64b59df1753c8812fdab0f851c8181a7fe
Neale Ranns [Mon, 26 Oct 2020 13:00:06 +0000 (13:00 +0000)]
misc: Break the big IP header files to improve compile time
Type: refactor
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: Id1801519638a9b97175847d7ed58824fb83433d6
Mohsin Kazmi [Wed, 28 Oct 2020 09:42:32 +0000 (10:42 +0100)]
virtio: fix the buffer array index
Type: fix
Fixes:
2e6f624f1f82ae0351dd05ad5d930d6876105519
Change-Id: I24a9822d1968a134c7e41221f48296cc8a67dd91
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Florin Coras [Mon, 26 Oct 2020 22:35:40 +0000 (15:35 -0700)]
vcl: postpone unhandled ctrl events if needed
Unhandled control events, i.e., events delivered outside of epoll/select
loops, that need to be propagated to apps should be postponed such that
epoll and select can later deliver them.
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I3d05e154382631a16a19e71494c2d92c35dacb70
Florin Coras [Fri, 23 Oct 2020 23:31:40 +0000 (16:31 -0700)]
session: per worker state for ct sessions
Type: feature
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id6f7b2b969eb50eb7611e4e9ca77b7ef0e0519a1
Damjan Marion [Mon, 26 Oct 2020 09:39:30 +0000 (10:39 +0100)]
vppinfra: clib_mem_vm_{un}map thread safe
Type: improvement
Change-Id: I1ab1b100000b4d7212c58e10312e16e7527bd333
Signed-off-by: Damjan Marion <damarion@cisco.com>
Steven Luong [Wed, 21 Oct 2020 19:54:29 +0000 (12:54 -0700)]
memif: handle unexpected EPOLLOUT for RX queue
Getting an unexpected EPOLLOUT for RX queue and crashing due to missing
callback function on write_function to handle EPOLLOUT.
(gdb) f 5
f 5
node=<optimized out>, vm=0x7f948bbe4540 <vlib_global_main>) at /vpp/src/vlib/unix/input.c:325
325 errors[n_errors] = f->write_function (f);
(gdb) p *e
p *e
$21 = {events = 4, data = {ptr = 0x23, fd = 35, u32 = 35, u64 = 35}}
(gdb) p file_main.file_pool[e->data.fd]
p file_main.file_pool[e->data.fd]
$22 = {file_descriptor = 37, flags = 1, polling_thread_index = 0, private_data = 65536,
read_function = 0x7f944a87b140 <memif_int_fd_read_ready>, write_function = 0x0,
error_function = 0x0, description = 0x7f944be22400 "memif0/1 rx 0 int", read_events = 0,
write_events = 1, error_events = 0}
(gdb)
File descriptors are recycled. It is likely that the EPOLLOUT is meant
for the previous owner of the same file descriptor number which memif
recycled and memif RX did not expect to receive an EPOLLOUT. For
defensive play, we create a dummy callback function to ignore the
EPOLLOUT instead of crashing.
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I535cadbb9b71d3db2995b118c59a12c71f10af09
Mohsin Kazmi [Mon, 26 Oct 2020 11:41:41 +0000 (12:41 +0100)]
virtio: improve the compile time
Type: improvement
packet buffering is common code to tun/tap/virtio.
Change-Id: I59a339f268a28a0c32756e52d10d1ed6b207db42
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Mohammed Hawari [Thu, 22 Oct 2020 12:14:04 +0000 (14:14 +0200)]
dpdk: allow offline build by caching build-deps
Change-Id: I40262c640be24f4ca48a2e1461fbc2eb2b0c4c96
Type: fix
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Mohsin Kazmi [Fri, 23 Oct 2020 09:23:52 +0000 (11:23 +0200)]
virtio: reduce the compile time for device.c
Type: improvement
GRO is common to tap/tun/virtio devices. Hence move to
common place.
Change-Id: Ibb099f3a80f493ddb934df6bb7640f7c9c370fd5
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Florin Coras [Sun, 25 Oct 2020 21:01:37 +0000 (14:01 -0700)]
tls: separate init from enable
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Icdeddeffd95492ca34f37e1904b1f5f6d150a6bc
Florin Coras [Sun, 25 Oct 2020 21:00:29 +0000 (14:00 -0700)]
session: fix feature disable
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I69e912ddf64d8ec89f8d93e02a201781b99de0bd
Florin Coras [Mon, 26 Oct 2020 02:06:57 +0000 (19:06 -0700)]
session: fix ct local listener session index
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I015443caefb13306858b4ccadeb0b979ea87299a
Florin Coras [Mon, 26 Oct 2020 03:28:23 +0000 (20:28 -0700)]
vcl: avoid epoll cleanup before app close
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I09f9faab72e6b77c975b8b79694081216c6ba115
Ryujiro Shibuya [Fri, 23 Oct 2020 07:35:53 +0000 (07:35 +0000)]
tcp: byte tracker fix
Type: fix
Signed-off-by: Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>
Change-Id: If7e22978a6b65f5b68ccb2bd97b5e0fba167b3bf
Damjan Marion [Mon, 26 Oct 2020 10:27:13 +0000 (11:27 +0100)]
avf: use atomic store instead of barrier
Type: improvement
Change-Id: Ifea5f0c2fecb99fd320a2e1141f4b4f0d6a793ca
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Mon, 26 Oct 2020 09:05:29 +0000 (10:05 +0100)]
rdma: fix clang-11 build
/vpp/src/plugins/rdma/rdma.h:203:17: error: field 'buffer_template' with variable sized type 'vlib_buffer_t' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
vlib_buffer_t buffer_template;
Type: fix
Change-Id: I4661839f262e01fe274a2ee7b3cb70f9bc6b7c62
Signed-off-by: Damjan Marion <damarion@cisco.com>
Filip Varga [Mon, 26 Oct 2020 12:05:19 +0000 (13:05 +0100)]
nat: nat44 cli command fix
Type: fix
Change-Id: I4aa0dac544582703316cbcfabe67bcb7dc24d4f7
Signed-off-by: Filip Varga <fivarga@cisco.com>
Neale Ranns [Mon, 26 Oct 2020 10:44:54 +0000 (10:44 +0000)]
fib: API to extract any resolving interface rather than the one from the
best source
Type: improvement
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: Iaa91cbc7eba94f4ffbdc249ecdb49770bd2ae916
Damjan Marion [Fri, 23 Oct 2020 19:52:50 +0000 (21:52 +0200)]
vlib: add VLIB_REGISTER_LOG_CLASS macro
Type: improvement
Change-Id: Iafcaeb88fa3569e042fb9cb270cf062b145416e2
Signed-off-by: Damjan Marion <damarion@cisco.com>
zstas [Sat, 9 May 2020 16:57:23 +0000 (16:57 +0000)]
pppoe: make pppoe plugin work with dot1q subinterfaces
- Enabling arc "device-input" with the next node "pppoe-input" on the pppoe cp interface: to get rid of L3_MAC_MISMATCH error
- Parsing in the "pppoe-input" node fixed to parse all headers from the scratch
- Getting mac address directly from encap interface when filling up DPO adjacency. Anyway, in the case of the dot1q subinterface, we need to get vlan tags to fill the DPO adjacency.
Type: improvement
Change-Id: I5405931b0f58bef7b852c079a7e66e0da8b5de0f
Signed-off-by: Stanislav Zaikin <zstaseg@gmail.com>
Steven Luong [Tue, 20 Oct 2020 00:21:10 +0000 (17:21 -0700)]
vmxnet3: vmxnet3_dump is broken
control ping id was not set
Fixes: gerrit 22396 / I009e806997461ad790f125d6359993862e1c5e5d
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I6e96533f150da4bd0e651b5572345246623ae0ad
Benoît Ganne [Tue, 15 Sep 2020 13:25:43 +0000 (15:25 +0200)]
af_xdp: add option to claim all available rx queues
Type: feature
Change-Id: I97176c2c90ea664a68078b3a7b7d44eb237a7f13
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Fan Zhang [Mon, 19 Oct 2020 12:08:34 +0000 (13:08 +0100)]
ipsec: remove pending node
This patch removes esp-encrypt-pending and esp-decrypt-pending
graph nodes from ipsec data-path.
Type: improvement
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: Icd90837eafdbfbfdf348681dcafb872593978980
Matthew Smith [Thu, 8 Oct 2020 16:11:27 +0000 (11:11 -0500)]
vrrp: asynchronous events on VR state change
Type: feature
Add API message for an API client to subscribe/unsubscribe to receive
an event when a VRRP VR changes state. Add code to build and send the
events.
Change-Id: Ie92cadd4850d4352c1aaa79c4b0a7daa0f3b04e7
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Mohammed Hawari [Wed, 21 Oct 2020 12:48:38 +0000 (14:48 +0200)]
rdma: implement striding rq for multiseg rx
This change leverages the striding RQ feature of
ConnectX-5 adapters to support chained buffers on
the RX path. In Striding RQ mode, WQE are SG lists
of data segments, each mapped to a vlib_buffer.
When a packet is received, it can consume one or
multiple data segments belonging to the WQE,
without wasting the whole WQE.
Change-Id: I74eba5b2c2c66538e75e046335058ba011cb27fd
Type: improvement
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Benoît Ganne [Fri, 16 Oct 2020 15:12:41 +0000 (17:12 +0200)]
rdma: add RSS support for IPv6 and TCP
Type: feature
Change-Id: I8b0d918e6f13325954b29bf34e4ef224c1315c51
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Damjan Marion [Fri, 23 Oct 2020 15:20:32 +0000 (17:20 +0200)]
build: add compile_commands.json cleanup script
Type: make
Change-Id: I8d6a5018bddf029e106df3cb8b8eded4fa28067d
Signed-off-by: Damjan Marion <damarion@cisco.com>
Nathan Skrzypczak [Fri, 23 Oct 2020 15:03:14 +0000 (17:03 +0200)]
cnat: coverity fix
Type: fix
Change-Id: Ie1153a0e0f1e9770bf3e0de9291131db91724b2e
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Hiroki Narukawa [Fri, 4 Sep 2020 06:41:40 +0000 (15:41 +0900)]
lb: Loadbalancer plugin, correctly rewrite checksum in L3DSR, non-TCP cases
Current loadbalancer seems to rewrite the 17th and 18th octet of L4 header regardless of which kind of L4 protocol is used in case of L3DSR.
In case UDP, it rewrites 9th and 10th octet of payload (because UDP header is 8 octets long). If UDP payload is less than 8 octets, UDP checksum becomes invalid.
In other protocols similar problems is likely to occue.
This patch checks which L4 protocol is used, and rewrite packet regarding the L4 protocol.
Signed-off-by: Hiroki Narukawa <nhirokinet@nhiroki.net>
Change-Id: I84390ff58a33f05efac0421856beea89014adc72
Type: fix
Steven Luong [Wed, 21 Oct 2020 23:55:49 +0000 (16:55 -0700)]
vmxnet3: add sw_if_index filter to vmxnet3 interface dump
Introduce a replacement API for vmxnet3_dump which supports interface
filter.
Type: improvement
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I76074db2aa34b397ce570a2019c43e042a9c7838
jiangxiaoming [Thu, 22 Oct 2020 02:08:36 +0000 (10:08 +0800)]
vlib: log: fix non-null terminated strings
Type: fix
Signed-off-by: jiangxiaoming <jiangxiaoming@outlook.com>
Change-Id: Id61966048875ca56a416caa520125c8c2366bf7b
Florin Coras [Fri, 23 Oct 2020 17:45:48 +0000 (10:45 -0700)]
tcp: remove snd_una_max
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I03f923053499f219035c9b7b6640fc575568d474
Florin Coras [Thu, 22 Oct 2020 18:22:22 +0000 (11:22 -0700)]
tcp: remove force retransmit timer update
Also simplify condition for detecting unintended timer pops.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I8b120dfc2d16e40ee865240dbc9667708cd1c808
Dave Wallace [Fri, 23 Oct 2020 13:35:12 +0000 (09:35 -0400)]
build: fix typo in dpdk-20.08 patch #0003
Type: fix
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Id0b3264e723f1df161a606e4dbdcd70c36d448a4
(cherry picked from commit
ee3ea114961610476bac544a979fdee8278d2b9e)
Florin Coras [Thu, 22 Oct 2020 22:49:05 +0000 (15:49 -0700)]
tcp: remove delack time config
Type: refactor
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iae5045686c62ad9279be350cffeaa41b8297d179
Filip Varga [Wed, 30 Sep 2020 20:24:47 +0000 (22:24 +0200)]
nat: nat44 enable/disable dynamic config
This patch changes initialization and configuration of NAT
plugin. Instead of allocating data structures at vpp plugin
initialization phase allocation and configuration happens
after calling enable API or CLI call. This reduces base VPP
memory footprint and also enables dynamic reconfiguration
of the NAT plugin.
Type: improvement
Change-Id: I42c069ee19a0311d043ac1f3f230d87bc8d2680f
Signed-off-by: Filip Varga <fivarga@cisco.com>
jiangxiaoming [Thu, 22 Oct 2020 01:08:04 +0000 (09:08 +0800)]
vppinfra: add bihash_8/24_16 to headers list
Type: improvement
Signed-off-by: jiangxiaoming <jiangxiaoming@outlook.com>
Change-Id: Ic67977995dbcba97240009373a4b9e9b57c63706
Steven Luong [Mon, 12 Oct 2020 17:43:28 +0000 (10:43 -0700)]
virtio: checksum error reported for ip6 traffic with GSO enable
When GSO is enabled, vhost clears the checksum field prior to transmitting
the packet. Some newer kernel version does not like that and complains
about checksum error. This was seen with ip6 traffic.
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I7c6f2a6148f4a30107bfa8b078f5990e64300cf1
Florin Coras [Thu, 22 Oct 2020 18:59:55 +0000 (11:59 -0700)]
svm: support large memfd segments
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2221934083eb82183af9159e705833bd0984bd5d
Florin Coras [Thu, 22 Oct 2020 06:24:53 +0000 (23:24 -0700)]
tcp: no send space in timer recovery
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I9461b6539c504ca844c25d04abe95929f842e4e9
Juraj Linkeš [Thu, 22 Oct 2020 11:29:28 +0000 (13:29 +0200)]
vppinfra: missing __clib_export va_unformat
Fix an issue observed on aarch64 systems when running with dpdk plugin:
dpdk_plugin.so: undefined symbol: va_unformat
Type: fix
Fixes:
dae1c7ed38e9f7a86e66f3674de62778cc981331
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Change-Id: I22b7ee842dc606f96effdeb7aa4e161496986aed
Mohammed Hawari [Wed, 21 Oct 2020 14:41:30 +0000 (16:41 +0200)]
pci: set PCI memory enable before mapping PCI BAR
This change mitigates software faults issued by some versions of the
linux kernel vfio-pci driver when VF PCI BARs are used without setting
the memory enable bit in the PCI configuration. This problem is
mentionned in https://lkml.org/lkml/2020/6/25/628
Change-Id: Idc177be4a5adb6ee467b4dd8f055f133ff267fe1
Type: improvement
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Damjan Marion [Wed, 21 Oct 2020 21:55:08 +0000 (23:55 +0200)]
build: add -E to sudo invocation in top-level Makefile
Type: make
Change-Id: I447c6082bfe4aa549e6a7ebc156b657419fc608c
Signed-off-by: Damjan Marion <damarion@cisco.com>
Mohsin Kazmi [Wed, 21 Oct 2020 16:32:59 +0000 (18:32 +0200)]
tap: fix the api for use of vec_len
Type: fix
Fixes:
03b76a20c569b8275beb8783691300a7d66b54a4
Change-Id: Ife788974cb7b2c35f40a017dd195dc2f7ee797b4
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Ryujiro Shibuya [Thu, 22 Oct 2020 05:26:32 +0000 (05:26 +0000)]
tcp: updating time constans as timer tick changed
Type: fix
Signed-off-by: Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>
Change-Id: Ibe305b96f04ffdc95ddb07d144dc00119ae69a07
Damjan Marion [Wed, 21 Oct 2020 17:43:36 +0000 (19:43 +0200)]
vlib: per-class logging configuration in startup.conf
logging {
class avf {
rate-limit 200
level debug
syslog-level debug
}
class dpdk/cryptodev {
rate-limit 200
level disabled
syslog-level disabled
}
}
Type: improvement
Change-Id: Iebe49b3ed4dfbfd589e80fcd2f9a63a8fe66b83b
Signed-off-by: Damjan Marion <damarion@cisco.com>
Ole Troan [Wed, 21 Oct 2020 09:55:28 +0000 (11:55 +0200)]
stats: missing dimension in stat_set_simple_counter
A simple counter is a two dimensional array by threads and
counter index. 28017 introduced an error missing the first
dimension.
If a vector is updated at the same time as a client reads,
an invalid pointer my result. This will be caught by the
optimistic locking after copying out the data, but if
following a pointer outside of the stat segment then
the stat client would crash. Add suitable boundary checks
for access to stat memory segment.
Fixes:
7d29e320fb2855a1ddb7a6af09078b8ed636de01
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I94f124ec71d98218c4eda5d124ac5594743d93d6
Nathan Skrzypczak [Wed, 21 Oct 2020 17:30:48 +0000 (19:30 +0200)]
vppinfra: missing __clib_export
Type: fix
Change-Id: I2dbd435d04a09f632286e5d669edc5fafd384f94
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Damjan Marion [Wed, 21 Oct 2020 10:43:40 +0000 (12:43 +0200)]
vlib: print logs to stderr if interactive or nosyslog set
If VPP is started in interactive mode, instead of sending logs to syslog
server we print them directly to stderr.
Output is colorized, but that can be turned off with unix { nocolor }
Type: improvement
Change-Id: I9a0f0803e4cba2849a6efa0b6a86b9614ed33ced
Signed-off-by: Damjan Marion <damarion@cisco.com>
Dave Wallace [Mon, 19 Oct 2020 18:57:55 +0000 (14:57 -0400)]
build: fix broken debian dependencies on ubuntu-18.04 & debian-9
- Installation vpp-plugin-core from packagecloud.io/master
& packagecloud.io/2009 breaks due to invalid dependencies
on newer versions of libmbedtls & libmbedcrypto
Type: fix
Fixes:
641467406
Change-Id: If736dabcc4a91a04b46515620dd87662b7b14260
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Filip Tehlar [Sat, 10 Oct 2020 04:39:11 +0000 (04:39 +0000)]
ikev2: support sending requests from responder
Type: improvement
Ticket: VPP-1894
Change-Id: I5a24a48416bca2ffbd346cdaa813fb25801e6c9b
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Neale Ranns [Mon, 19 Oct 2020 09:59:41 +0000 (09:59 +0000)]
ipsec: support for multipoint on ipsec interfaces
Type: feature
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Iae9fe35cfbce4c675fa25e0800c0f4629a83e012
Neale Ranns [Tue, 20 Oct 2020 07:20:17 +0000 (07:20 +0000)]
ip: convert u32 entry_flags to vl_api_mfib_entry_flags_t on mroute API
Type: fix
This is not an API change, it's the same values, just a different named
type.
also use VppEnum values in tests
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I3a18b529514f3cc9467ae4e8ac3e88d067fc776b
Filip Tehlar [Wed, 7 Oct 2020 23:52:37 +0000 (23:52 +0000)]
ikev2: fix setting responder/initiator addresses
Type: fix
Change-Id: Ic406aa914d92e802a5fb0f27c2ffa1b98db012b0
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Filip Tehlar [Wed, 7 Oct 2020 19:17:00 +0000 (19:17 +0000)]
ikev2: prevent crash after no IP address
Type: fix
Ticket: VPP-1900
This fixes a crash when initiating IKE connection using interface
without any IP address.
It also ensures that the IKE connection is automatically retried once the
interface obtains an address.
Signed-off-by: jan_cavojsky <Jan.Cavojsky@pantheon.tech>
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Change-Id: Ia1919c349e64b3a0a4198365e075e177e3ba3de5
Nathan Skrzypczak [Tue, 13 Oct 2020 15:26:47 +0000 (17:26 +0200)]
cnat: allow max_u16 translation backends
Type: fix
Allow for 65536 backends for a translation.
- use u32 instead of u8
- filter out back_walk with more than
FIB_PATH_LIST_POPULAR backends
- we're still limited by u16 lb_n_buckets
in src/vnet/dpo/load_balance.h
Change-Id: Ib37b958e59b25ef5ef9f92b82008d626860faddd
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Mohsin Kazmi [Mon, 12 Oct 2020 11:01:24 +0000 (13:01 +0200)]
virtio: run process to send interrupts to input nodes
Type: improvement
virtio interfaces support packet coalescing and buffering which
depends on timer expiry to flush the stored packets periodically.
virtio input node checks timer expiry and schedules tx queue
accordingly. In poll mode, timer expiry is handled naturally,
as input node runs periodically. In interrupt mode, virtio
input node depends on the interrupts send from backend.
Stored packets could starve, if there would not be interrupts
to input node.
This patch implements a process node which periodically
sends interrupt to virtio input node given coalescing or buffering
feature is enabled on an interface.
Change-Id: Ic38f749f74b001073d4d0579dca149d0a4cea039
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Neale Ranns [Mon, 19 Oct 2020 13:23:33 +0000 (13:23 +0000)]
ipsec: Add to the SA info directly in the bihash
Type: improvement
this save the cache miss on the protect structure.
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I867d5e49df5edfd6b368f17a34747f32840080e4
Florin Coras [Wed, 21 Oct 2020 01:44:41 +0000 (18:44 -0700)]
vcl: wait for sendto to connect if needed
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I39948b046c79dea1b034619e1eaa22dd8a4997fb
Benoît Ganne [Wed, 21 Oct 2020 10:18:58 +0000 (12:18 +0200)]
misc: fix tracedump graph api initialization overflow
vppapigen does not create config entries for services stream messages.
It is not needed anyway as the api handler does not rely on VPPAPI
macros.
Type: fix
Change-Id: Iba188b0fc6388c478d7e4d0c7ee2c05ed672e23f
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Mon, 19 Oct 2020 07:49:09 +0000 (09:49 +0200)]
af_xdp: fix NUMA node parsing
Non-NUMA systems might report -1 as NUMA node.
Type: fix
Change-Id: I092c817ea670009d6f530cc70ad13d45e15fd363
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Florin Coras [Tue, 20 Oct 2020 20:40:17 +0000 (13:40 -0700)]
stn: remove dependency on tcp and udp headers
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I8a842759009ec0f433f0aeff47f4e1c889d7b211
Florin Coras [Tue, 20 Oct 2020 20:45:51 +0000 (13:45 -0700)]
gso: remove dependency on tcp proto implementation
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I3af84e968c38df0452746729dcb722d48fa438fb
Benoît Ganne [Tue, 20 Oct 2020 12:31:55 +0000 (14:31 +0200)]
svm: fix ASAN annotations for external chunks
Chunks can be allocated from another process. We need to manually
mark them as accessible for ASAN.
Type: fix
Change-Id: Ifbeef3346e9cee2c1231f80cbcf7f9673b5b54be
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Wed, 21 Oct 2020 08:02:18 +0000 (10:02 +0200)]
vppinfra: fix ASAN annotation
Type: fix
Change-Id: I90b537eba7f56dbb1928f0ab5f157218affb43f5
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Wed, 21 Oct 2020 09:13:24 +0000 (11:13 +0200)]
svm: fix fifo unit test
- fix fifo initialization overflowing chunk size
- stick to the default base virtual address to initialize fifo. ASAN
can be picky about address space
Type: fix
Change-Id: If9a29138d2c207859d72845e928290c808c4a982
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Damjan Marion [Mon, 19 Oct 2020 15:15:58 +0000 (17:15 +0200)]
virtio: improve input node performance
- Avoid feature arc lookup per packet, as all packets belong to the
same interface
- don't validate enqueue for l2 packets, as they all have same
destionation
Type: improvement
Change-Id: I32ddd801f219eab9281736abafdc91a4ff9e0989
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Tue, 20 Oct 2020 10:11:06 +0000 (12:11 +0200)]
virtio: move lock and kick to outer function
Type: improvement
Change-Id: I4fdcb40142e8cc9f5f1d0035116659543d5d92fe
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Tue, 20 Oct 2020 21:59:43 +0000 (14:59 -0700)]
misc: minimize dependencies on udp.h
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id13f33843b230a1d169560742c4f7b2dc17d8718
jiangxiaoming [Wed, 21 Oct 2020 01:54:33 +0000 (09:54 +0800)]
tls: enable cert key pair setting for connect
Type: improvement
Signed-off-by: jiangxiaoming <jiangxiaoming@outlook.com>
Change-Id: Ie0e6d48d65b0b8b493e9d49cfdf93c645523659a
Dimitrios Markou [Mon, 12 Oct 2020 10:44:38 +0000 (12:44 +0200)]
dpdk: Disable VLAN filtering for VLAN sub-interface in i40e driver
When creating a VLAN sub-interface on a Fortville i40e DPDK VF,
the data plane does not work properly.
Enabling vlan filter offload overrides the VLAN strip offload setting to on.
The VLAN strip offload must be disabled for VPP VLAN sub-interfaces to work.
Ticket: https://jira.fd.io/browse/VPP-1933
Type: fix
Signed-off-by: Dimitrios Markou <dimitrios.markou@est.tech>
Change-Id: I02c6980e3b01870b69a9375f281125ad48477827
Dave Barach [Tue, 20 Oct 2020 19:17:50 +0000 (15:17 -0400)]
vppinfra: export elog_read_file_not_inline()
Type: fix
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ib9fb1723b55bf322c9fd9f928a3e3b4a529bca5b
Ole Troan [Tue, 20 Oct 2020 12:36:13 +0000 (14:36 +0200)]
stats: crash when adding/deleting interfaces
create tap
delete tap tap0
create loopback interface
delete loopback interface intfc loop0
create tap <- here I hit a segmentation fault
Type: fix
Fixes:
148c7b768721231325a349fa82db693190513b53
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If270cc57610e2ded7422e7030d8c1f9fadd4d233
Florin Coras [Tue, 4 Aug 2020 01:55:40 +0000 (18:55 -0700)]
vcl: confirm reset on transport cleanup
Type: fix
Change-Id: Ife579f305409bf987639634213008a7d7f35acd7
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Tue, 20 Oct 2020 03:51:36 +0000 (20:51 -0700)]
vcl: more session struct cleanup
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I8e466e789c860caaa55f67095a57fc6ab670f32b
Benoît Ganne [Tue, 20 Oct 2020 12:12:20 +0000 (14:12 +0200)]
wireguard: reset secret data before freeing it
Type: fix
Change-Id: I880bdd55ae5da0b9775a3fb548d44512348a7bc6
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Florin Coras [Tue, 20 Oct 2020 01:36:48 +0000 (18:36 -0700)]
vcl: convert vep variables into flags
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ief017abc4879bc928746d9f5b9d2cfe04da89bd3
Neale Ranns [Tue, 20 Oct 2020 08:49:31 +0000 (08:49 +0000)]
ipsec: Stack the adj from the destination in the SA's TX table
Type: fix
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Ib7f39243e051cdf44cc7151d14458a7fab42c6a8
Florin Coras [Mon, 19 Oct 2020 03:17:49 +0000 (20:17 -0700)]
vcl: cleanup read and write ready
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ib6afedf24c7bd7cc0d98bb324a83517030a05aa7
Dave Barach [Mon, 19 Oct 2020 20:05:07 +0000 (16:05 -0400)]
vppinfra: minor refactor in lock.h
For whatever reason, "typedef struct { ... } *foo_t" gives cgo a
horrible case of indigestion. A minor refactor makes the pain go away.
Type: refactor
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I856b2abf9b16348d2f6145178e683e722914c756