vpp.git
7 years agoEdit Lisp locator_set API 85/1785/22
Andrej Kozemcak [Mon, 20 Jun 2016 06:47:57 +0000 (08:47 +0200)]
Edit Lisp locator_set API

Change the output format of lisp locator_set API.
Create new API for lisp locator.
Change lisp_enable_disable_status_dump -> show_lisp_status, not use dump
function.

Change-Id: Ie2024cbf5e55b22ba077266220bf8584d5cac07a
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoVPE_API small fix for LISP locator_set 11/2111/2
Andrej Kozemcak [Thu, 28 Jul 2016 07:22:03 +0000 (09:22 +0200)]
VPE_API small fix for LISP locator_set

- add documentation
- use new feature in vpe_api

Change-Id: I2708383aa886494d948feea1869c3fabae94c7bf
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoUpdate CSIT test 160710 -> 160727 10/2110/1
Andrej Kozemcak [Thu, 28 Jul 2016 07:26:23 +0000 (09:26 +0200)]
Update CSIT test 160710 -> 160727

Change-Id: Ia6e4e951a409a3b8caef16bb62d9969ae030b667
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoVPP-210: Clearer error codes in vlib-api for API trace save 05/2105/2
root [Wed, 27 Jul 2016 15:01:31 +0000 (08:01 -0700)]
VPP-210: Clearer error codes in vlib-api for API trace save

Change-Id: Ic02eaaaa8cf7a0f1c75eca8e3b87956d5e9045e7
Signed-off-by: root <calvin.ference@gmail.com>
7 years agoVPP-189 coverity warning cleanups 04/2104/3
Dave Barach [Wed, 27 Jul 2016 14:00:58 +0000 (10:00 -0400)]
VPP-189 coverity warning cleanups

Change-Id: Ia4fbf4352119504e022b89d10d44a5259d94f316
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVhost-User: Fix bind sockaddr length 71/2071/4
Pierre Pfister [Mon, 25 Jul 2016 13:32:02 +0000 (14:32 +0100)]
Vhost-User: Fix bind sockaddr length

The sockaddr length argument provided to bind was wrong.
This patch also adds an error message in the CLI when the
vhost-user add function fails.

Change-Id: Ib4466accffe49c8c3f4951ebf3a83a24529f6a5b
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoVAT add_locator_set api support multiple locators 02/2102/2
Andrej Kozemcak [Wed, 27 Jul 2016 08:33:38 +0000 (10:33 +0200)]
VAT add_locator_set api support multiple locators

Change-Id: I22df3d4407bd7fdd953783f00605380a2d6fb46e
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoVPP-214: IPSec cli/api vector ck and ik initialization 99/2099/1
Matus Fabian [Wed, 27 Jul 2016 06:54:07 +0000 (23:54 -0700)]
VPP-214: IPSec cli/api vector ck and ik initialization

Change-Id: I34e19d1feb350c47987b9764b642ef9baa000581
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoVPP-223 General documentation updates 93/2093/1
Chris Luke [Tue, 26 Jul 2016 17:06:10 +0000 (13:06 -0400)]
VPP-223 General documentation updates

Per the TWS session...

- Some simple treatment of the contents of pool.h
- Changing some \brief commands to @brief. (will do a more
  complete pass at this later.)

Change-Id: I050ee69c59c4b572ac295b5f86940b7f4c934cd9
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoVPP-165 Update directory list in README 90/2090/3
Chris Luke [Tue, 26 Jul 2016 16:02:46 +0000 (12:02 -0400)]
VPP-165 Update directory list in README

Change-Id: I7bc983860d6cc40f264e509e74b92978667324bc
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoFix missing include dirs in doxygen 88/2088/2
Chris Luke [Mon, 25 Jul 2016 23:58:27 +0000 (19:58 -0400)]
Fix missing include dirs in doxygen

Also allow a developer to alter the directories scanned at runtime to
facilitate shorter run-times when writing documentation.

Change-Id: I2a09519661a3abe1fbc0cfc294000934852af951
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agopolicer classify 69/1669/8
Matus Fabian [Mon, 20 Jun 2016 15:10:42 +0000 (08:10 -0700)]
policer classify

JIRA: VPP-114

If the classifier finds a matching entry, it sends packet to the policer,
packet should be pre-colored for color-aware policers.

Change-Id: I10cb53b49907137769418f230df2cab577d0f3a0
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoFix coverity warnings 86/2086/1
Dave Barach [Tue, 26 Jul 2016 14:30:50 +0000 (10:30 -0400)]
Fix coverity warnings

Change-Id: I37131f2d814a608fe9098daff83ff395f7ce99d7
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoFix Coverty warning in lisp_add_del_map_resolver_command_fn 80/2080/1
Florin Coras [Tue, 26 Jul 2016 10:12:17 +0000 (12:12 +0200)]
Fix Coverty warning in lisp_add_del_map_resolver_command_fn

Change-Id: I074d9e026ae42aa14caedc56287816ab64968425
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoAuthor: Dave Barach <dave@barachs.net> 79/2079/2
Dave Barach [Mon, 25 Jul 2016 20:13:00 +0000 (16:13 -0400)]
Author: Dave Barach <dave@barachs.net>
--- log message follows this line --
Coverity: fix minor bug in test code

Change-Id: I5921874b4902fc7fe140a9b22852e7d18583e7ae
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-142 - Follow up fix for shared_count in indirect adjacencies 78/2078/1
John Lo [Mon, 25 Jul 2016 18:34:48 +0000 (14:34 -0400)]
VPP-142 - Follow up fix for shared_count in indirect adjacencies

Change-Id: Ia2d0351ffd40c75cbf9611e00a7e111189ad70b5
Signed-off-by: John Lo <loj@cisco.com>
7 years agoVPP-108: fix buffer overrun 63/2063/1
Dave Barach [Sat, 23 Jul 2016 23:25:37 +0000 (19:25 -0400)]
VPP-108: fix buffer overrun

Probably not seen (yet) in practice due to the message ring allocation
scheme.

Change-Id: I7f01b5c09e0a172ad43ec3b8416e2791cada6122
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-189 Fix 137 coverity no-op issues from vpeapigen 62/2062/3
Chris Luke [Fri, 22 Jul 2016 13:40:19 +0000 (09:40 -0400)]
VPP-189 Fix 137 coverity no-op issues from vpeapigen

vpeapigen is not properly detecting no-op endian swap operations (on u8
or u8[] types) which in turn causes Coverity to currently report ~137
minor issues from the generated vpe.api.h file.

This patch makes vpeapigen comment out those no-op situations thus:

    /* a->interface_name[0..63] = a->interface_name[0..63] (no-op) */
    /* a->admin_up_down = a->admin_up_down (no-op) */

Change-Id: Ifbc5c93e1939206656e0515b528a4d167c539fd2
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoAdd DPDK 16.07 support (rc3 based) 38/2038/2
Damjan Marion [Wed, 13 Jul 2016 20:44:18 +0000 (22:44 +0200)]
Add DPDK 16.07 support (rc3 based)

DPDK vhost-user support is disabled due to significan changes
in the DPDK vhost-user code which are not compatible with current
VPP code.

Change-Id: I3f0d28cb75f6370282ec7e33d57cbfb77e1a3ce1
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoHONEYCOMB-83: Add Gre Feature 51/2051/3
Hongjun Ni [Fri, 22 Jul 2016 10:19:19 +0000 (18:19 +0800)]
HONEYCOMB-83: Add Gre Feature

PatchSet 3: use clib_memcpy for copy.
PatchSet 2: use clib_memcpy() to copy IP address.
PatchSet 1: Support IPv6 interface for GRE API.

Change-Id: I80ee4b61df15da7fd851b682a97d5d49f89568b7
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
7 years agoAdd support for Chelsio T540-CR and T580-CR 41/2041/5
Damjan Marion [Thu, 21 Jul 2016 12:22:59 +0000 (05:22 -0700)]
Add support for Chelsio T540-CR and T580-CR

Change-Id: Ibe927027c2aea6f2d85a9c50bf462c552b63861c
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoAs interface is set to L3 mode, reset its output_node_index for l2-output 49/2049/2
John Lo [Thu, 21 Jul 2016 18:54:05 +0000 (14:54 -0400)]
As interface is set to L3 mode, reset its output_node_index for l2-output

As an interface is changed from L2 bridging/xconenct to L3 mode, reset the
output_node_index for l2-output for the interface's sw_if_index. The reset
needs to be done in case the sw_if_index of this interface is freed and
reused for another interface type afterwards. Otherwise, the stale output
node may be used by l2-output for this sw_if_index and result in undesirable
behavior including the possibility of VPP crash.

Change-Id: Idd91d288c7643f0a1975a6787fcc330d03a7fac7
Signed-off-by: John Lo <loj@cisco.com>
7 years agoImprove interface naming for NICs ports sharing same PCI ID 40/2040/4
Damjan Marion [Thu, 21 Jul 2016 10:42:37 +0000 (03:42 -0700)]
Improve interface naming for NICs ports sharing same PCI ID

Change-Id: I68d708f5dd76dc7a46c3c8634aa8f18c515177e5
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoUpdating gitignore for generated plugins folder 43/2043/2
Keith Burns (alagalah) [Thu, 21 Jul 2016 13:12:13 +0000 (06:12 -0700)]
Updating gitignore for generated plugins folder

Change-Id: I266db9f4667c4f720d6109fad5c4d31eb182ed30
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoRename reused LISP interfaces 19/2019/2
Florin Coras [Tue, 19 Jul 2016 14:27:08 +0000 (16:27 +0200)]
Rename reused LISP interfaces

Change-Id: I0efb4c488ea18504a87c845f8fe399f0333d5be2
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoFix CLI for adding LISP fwd entries 21/2021/2
Florin Coras [Tue, 19 Jul 2016 13:27:58 +0000 (15:27 +0200)]
Fix CLI for adding LISP fwd entries

Change-Id: Ib707d252e624e3c1c4ac261fd3cef17b097633e5
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agol2_rw preload starts where data is 64/1964/3
Pierre Pfister [Fri, 15 Jul 2016 07:41:04 +0000 (08:41 +0100)]
l2_rw preload starts where data is

Change-Id: I8819f78dedb02abd38ae0c404e9524ebde12191f
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agotapcli: Use error counter for buffer allocation error 65/1965/3
Pierre Pfister [Fri, 15 Jul 2016 07:44:10 +0000 (08:44 +0100)]
tapcli: Use error counter for buffer allocation error

Change-Id: Ic51a0d17918de56869cfd4a371054fb380000089
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agobuild-root/vagrant: Fix SSE4.x for VB 31/2031/2
Ray [Wed, 20 Jul 2016 12:13:18 +0000 (13:13 +0100)]
build-root/vagrant: Fix SSE4.x for VB

Number of users are reporting issues using VPP with Vagrant and the
VirtualBox provider. VPP quits complaining that SSE support is not enabled.

This change explicity enables SSE4.x support in the VirtualBox VM.

Change-Id: Ia26dc43276aae4179609febfd705d868fa3e07c6
Signed-off-by: Ray <ray.kinsella@intel.com>
7 years agoAdd API calls for packet generator 39/1939/4
Pavel Kotucek [Tue, 12 Jul 2016 08:18:26 +0000 (10:18 +0200)]
Add API calls for packet generator

Added new API to:
- create packet generator interface
- enable packet generator per stream or all
- capture into file

Change-Id: I0e6c1f28069853e4b26f0dc9d282353b0b7f6512
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
7 years agoVPP-123: remove japi (the old Java API) 33/2033/4
Marek Gradzki [Wed, 20 Jul 2016 12:53:48 +0000 (14:53 +0200)]
VPP-123: remove japi (the old Java API)

MANUAL_JAVA flag (used only by the japi)
was also removed.

Change-Id: Ied21521b2410af1c357afb04cbf9e849632ddc5f
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoENIC driver update to init mbuf data offset to RTE_PKTMBUF_HEADROOM 37/2037/1
John Lo [Wed, 20 Jul 2016 20:14:57 +0000 (16:14 -0400)]
ENIC driver update to init mbuf data offset to RTE_PKTMBUF_HEADROOM

Change-Id: I19e3e2b28c45d9f7efdd791d6dab126f6508df3e
Signed-off-by: John Lo <loj@cisco.com>
7 years agoAdd new lisp API - Show pitr 32/2032/1
Andrej Kozemcak [Mon, 18 Jul 2016 11:55:37 +0000 (13:55 +0200)]
Add new lisp API - Show pitr

VAT API:
   - show_lisp_pitr
CLI API:
   - show lisp pitr

Change-Id: Ibd31cb09efc34a49b439338e9467faf7a151f2cd
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
7 years agoL2TP: Add option for custom fib id for outgoing encapsulated packets 67/1967/3
Pierre Pfister [Fri, 15 Jul 2016 08:19:39 +0000 (09:19 +0100)]
L2TP: Add option for custom fib id for outgoing encapsulated packets

If a custom fib ID is used (different from ~0), the associated
fib is used to forward outgoing encapsulated packets.
Otherwise, the fib used is the same as for any packet
received on the original RX interface (L2TP does not modify RX interface index).

Change-Id: I4533d5f7fa432c78c937d3acdd802d0d1c92a0c7
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoIP6 forward: Add ND route when next-hop is unknown link local 56/1856/4
Pierre Pfister [Tue, 5 Jul 2016 14:36:26 +0000 (15:36 +0100)]
IP6 forward: Add ND route when next-hop is unknown link local

Indirect routes have been recently added. When the next-hop is not known,
an indirect route is automatically installed instead. But it makes no
sense to add an indirect route for a link-local next-hop addresses.

Instead, it may make sense to add an ND entry to the
yet-to-be-met neighbor.

Also corrected some indentation.

Change-Id: Ia83c9cd1feafac742680745e82c6faf9f2e1e536
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoILA: Add direction option to disable ila2sir or sir2ila 28/2028/1
Pierre Pfister [Wed, 20 Jul 2016 07:39:38 +0000 (08:39 +0100)]
ILA: Add direction option to disable ila2sir or sir2ila

In a ILA router use case as described by the draft, it is proposed
to disable ILA to SIR translation and do SIR to ILA only.

Change-Id: I8d0980bb75c8d925c1d1aa4563030919dd220620
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoVPP-203 Find the relative next node index by node names 22/2022/1
Keith Burns (alagalah) [Tue, 19 Jul 2016 21:47:43 +0000 (14:47 -0700)]
VPP-203 Find the relative next node index by node names

vat# get_next_index node-name vxlan4-input next-node-name l2-input
next node index 1

Change-Id: Ib71be8a408d08d59b0ed7dfb6ada9711cf29bd69
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoOn bonded interface admin-down, should stop all slave links 91/1991/3
John Lo [Mon, 18 Jul 2016 22:06:14 +0000 (18:06 -0400)]
On bonded interface admin-down, should stop all slave links

When bonded interface is set to admin down, all slave links should
also be stopped or they will continue to receive packets and then
be dropped because bonded interface is down.

Also remove setting bonded interface L3 packet size limit to that of
slave on startup - it is not needed and can cause undesirable side
effect if its value become incompatible with bonded interface MTU.

Change-Id: Ibdd8acac0ca41a867131441eb26518592bb7d98a
Signed-off-by: John Lo <loj@cisco.com>
7 years agoFix CLI to add LISP interface 08/2008/3
Florin Coras [Tue, 19 Jul 2016 09:52:35 +0000 (11:52 +0200)]
Fix CLI to add LISP interface

Change-Id: Id59a5f3dcea46679deb759a8e4af187125f33cbd
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoTap: Fix hardware address assignment 84/1984/3
Mohsin KAZMI [Mon, 18 Jul 2016 14:57:40 +0000 (16:57 +0200)]
Tap: Fix hardware address assignment

[VPP-200]: Previously, VPP set the same hardware address to tap interface as of
Linux side tap interface, if neither hardware address nor 'random'
keyword were given explicitly on VPP command line during tap creation or
modification, which was default case.

This patch makes sure to set the different hardware addresses randomly
as default case. While one can set unique hardware address or similar to
one at Linux side using VPP tap command line.

Change-Id: Ie0a82f3706834e87426d66c6e869ec4edfefe932
Signed-off-by: Mohsin KAZMI <sykazmi@cisco.com>
7 years agoAdd uid/gid config parameters to shared-vm database map operator 86/1986/1
Dave Barach [Mon, 18 Jul 2016 18:23:36 +0000 (14:23 -0400)]
Add uid/gid config parameters to shared-vm database map operator

So vpp_get_metrics and similar will not need to run as root

Change-Id: I635e830834c82990ad84ddaae06f2e50e55fd616
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoFix "show hardware" CLI display for bonded interface may corrupt heap 85/1985/2
John Lo [Mon, 18 Jul 2016 16:20:09 +0000 (12:20 -0400)]
Fix "show hardware" CLI display for bonded interface may corrupt heap

Change-Id: Ie379844047b6402884653d3fd682010a1d09d14a
Signed-off-by: John Lo <loj@cisco.com>
7 years agoFix local eid API in VAT 83/1983/1
Florin Coras [Mon, 18 Jul 2016 15:06:20 +0000 (17:06 +0200)]
Fix local eid API in VAT

Change-Id: I14fb0378944db5bf7a8843b4dc361de748659ece
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoUse oper-160710 CSIT branch for 'verify' jobs 63/1963/3
Miroslav Miklus [Fri, 15 Jul 2016 07:22:48 +0000 (09:22 +0200)]
Use oper-160710 CSIT branch for 'verify' jobs

Change-Id: I798a1f4168a6d3e60fc9f115b33cd7a5b2782df6
Signed-off-by: Miroslav Miklus <mmiklus@cisco.com>
7 years agoOutput format change from "vlan 802.1q" to "802.1q vlan", addition to VPP-111 81/1981/1
marek zavodsky [Mon, 18 Jul 2016 08:59:57 +0000 (10:59 +0200)]
Output format change from "vlan 802.1q" to "802.1q vlan", addition to VPP-111

Change-Id: Ieac14c88e6f0d2d88da1fe47f981fa33ae6f7c23
Signed-off-by: marek zavodsky <mazavods@gmail.com>
7 years agoImprove "indent foo.c" prep script 79/1979/2
Dave Barach [Sun, 17 Jul 2016 15:52:10 +0000 (11:52 -0400)]
Improve "indent foo.c" prep script

Change-Id: Ibb569b745954a11fb9c7751ad2d4140b922478fe
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-187: Standardized retvalue types in vpe.api 75/1975/2
Calvin [Fri, 15 Jul 2016 19:07:58 +0000 (15:07 -0400)]
VPP-187: Standardized retvalue types in vpe.api

Change-Id: I0cb0d2588a824c0fa040bbc5a30c3bb8be96aa0f
Signed-off-by: Calvin <calvin.ference@gmail.com>
7 years agoAdd ILA plugin 78/1978/2
Pierre Pfister [Sat, 16 Jul 2016 07:51:16 +0000 (08:51 +0100)]
Add ILA plugin

This plugin is implementation of Identifier Locator Addressing (ILA)
per IETF draft-herbert-nvo3-ila-2

Change-Id: I5d5f8fb55c490f358f628bceb5f57e7e7408e6ed
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
Signed-off-by: Wolfgang <wolfgang.beck01@gmail.com>
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoAdd DPDK patches for i40e vPMD (ptype and ip checksum offload) 77/1977/2
Damjan Marion [Sat, 16 Jul 2016 15:47:22 +0000 (17:47 +0200)]
Add DPDK patches for i40e vPMD (ptype and ip checksum offload)

Change-Id: Idf38ee8f8cfc31be62fcf0b828832b2f06876815
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years ago- fixed misleading indentation (fixes compilation error on gcc versio 6.1.1) 76/1976/1
Wolfgang [Sat, 16 Jul 2016 09:23:43 +0000 (11:23 +0200)]
- fixed misleading indentation (fixes compilation error on gcc versio 6.1.1)

Change-Id: I7f666a5fb9dac3cac88633d01e1941dac7cc012d
Signed-off-by: Wolfgang Beck <wolfgang.beck01@gmail.com>
7 years agovhost-user: Reset virt-queue info when a vhost interface is disconnected. 62/1962/3
Steve Shin [Thu, 14 Jul 2016 19:06:01 +0000 (12:06 -0700)]
vhost-user: Reset virt-queue info when a vhost interface is disconnected.

When a vhost interface is disconneted, virt-queue info should be cleaned up.
This will avoid any potential vpp crash due to unmmaped memory access.

Change-Id: Ia20153da9eb45412bb41d76ef66ede175ea6fef1
Signed-off-by: Steve Shin <jonshin@cisco.com>
7 years agoAdd a command line utility to display critical vpp engine metrics 61/1961/3
Dave Barach [Thu, 14 Jul 2016 14:05:37 +0000 (07:05 -0700)]
Add a command line utility to display critical vpp engine metrics

vector rate, aggregate rx rate, [configurable] significant error rate

Change-Id: If0b7316a62cb8478d1466f1c9a9903d6df2a6ca0
Signed-off-by: Dave Barach <openvpp@barachs.net>
7 years agoShow 802.1q/802.1ah details in the trace output, fixes VPP-111 46/1746/5
marek zavodsky [Thu, 7 Jul 2016 01:16:10 +0000 (03:16 +0200)]
Show 802.1q/802.1ah details in the trace output, fixes VPP-111

added one line to dpdk-input trace to display vlan tci when PKT_RX_VLAN_PKT flag set
cleaned trace output of af_packet node. Added formatter for vlan_tci.
Merged with John Lo's ethernet trace extension:
Decode both dot1q and dot1ad VLAN tags in ethernet format function
and show what type of vlan tag it is.

dpdk-input & ethernet trace output example of ARP:

00:00:41:545481: dpdk-input
  TenGigabitEthernet8/0/1 rx queue 0
  buffer 0x10f2e: current data 0, length 60, free-list 0, totlen-nifb 0, trace 0x1
  PKT MBUF: port 4, nb_segs 1, pkt_len 60
    buf_len 2176, data_len 60, ol_flags 0x1, data_off 128, phys_addr 0x70e38ac0
    packet_type 0x0
    Packet Offload Flags
      PKT_RX_VLAN_PKT (0x0001) RX packet is a 802.1q VLAN packet ID 100
  ARP: 8c:60:4f:dd:ca:81 -> ff:ff:ff:ff:ff:ff vlan 802.1q id 100
  request, type ethernet/IP4, address size 6/4
  8c:60:4f:dd:ca:81/172.16.110.1 -> ff:ff:ff:ff:ff:ff/172.16.110.10
00:00:41:545492: ethernet-input
  ARP: 8c:60:4f:dd:ca:81 -> ff:ff:ff:ff:ff:ff vlan 802.1q id 100
00:00:41:545499: error-drop
  ethernet-input: unknown vlan

Change-Id: Iae67a945fda4aa2f24032e305a24544dd182b065
Signed-off-by: marek zavodsky <mazavods@gmail.com>
7 years agoVPP-189 Addtional fixes for last coverity fix in linux_pci.c 58/1958/3
John Lo [Wed, 13 Jul 2016 22:13:02 +0000 (18:13 -0400)]
VPP-189 Addtional fixes for last coverity fix in linux_pci.c

Fix VPP startup problem where it cannot attach to a combination
of 3 Intel igb 1GE ports and 2 Intel ixgbe 10GE ports whose PCI
addresses are specified in the DPDK section of VPP startup
config file as follows:
dpdk { dev 0000:02:00.1 dev 0000:02:00.2 dev 0000:02:00.3
       dev 0000:05:00.0 dev 0000:05:00.1 }

Change-Id: Ibb12f9e9a9184d00da51a49961772ac3a42a2d1d
Signed-off-by: John Lo <loj@cisco.com>
7 years agoAdd API dump call for vrf/vni mapping to vpp-api-test 52/1952/2
Filip Tehlar [Wed, 13 Jul 2016 11:17:15 +0000 (13:17 +0200)]
Add API dump call for vrf/vni mapping to vpp-api-test

Change-Id: I7a028ce9ddf21bd3a7d4991ba1be05e5e74202d6
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoAdd plugins debian packaging 53/1953/1
Damjan Marion [Wed, 13 Jul 2016 11:42:33 +0000 (13:42 +0200)]
Add plugins debian packaging

New debian package "vpp-plugins" is created with enabled plugins.

Change-Id: I8920178e8874f12e075858001ec44257dfaf497d
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agopacket-generator: various fixes 46/1946/1
Damjan Marion [Tue, 12 Jul 2016 19:58:19 +0000 (21:58 +0200)]
packet-generator: various fixes

Change-Id: I8f1be9a501574ff4d5024ed0d632392708716e77
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoShow cli for plugin path, name filter and loaded plugins 36/1936/2
Shwetha Bhandari [Mon, 11 Jul 2016 22:08:54 +0000 (23:08 +0100)]
Show cli for plugin path, name filter and loaded plugins

Change-Id: If6ab5f08bcdcf5e24bb8b31926894d2a56cb6c14
Signed-off-by: Shwetha Bhandari <shwethab@cisco.com>
7 years agopolicer action 27/1327/6
Matus Fabian [Tue, 31 May 2016 14:33:29 +0000 (07:33 -0700)]
policer action

JIRA: VPP-90

Policer allows you to specify the action to be taken on a packet:
    conform-action (green color)
    exceed-action (yellow color)
    violate-action (red color)
Action to take on packets:
    drop - drops the packet
    transmit - transmits the packet, the packet is not altered
    mark-and-transmit <DSCP> - sets the DSCP value and transmits the packet

Change-Id: I59c037e55e7e2a9fc9b9752e92426f3977f5587b
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoAdd incrementing MAC / count support for the l2fib_add_del API 37/1937/2
Dave Barach [Mon, 11 Jul 2016 23:48:42 +0000 (16:48 -0700)]
Add incrementing MAC / count support for the l2fib_add_del API

Change-Id: I1df1cd3d2630baab979e840153f1f109d3ead0c2
Signed-off-by: Dave Barach <openvpp@barachs.net>
7 years agoENIC driver update to allow bonded interface admin down/up to pass traffic 35/1935/2
John Lo [Mon, 11 Jul 2016 22:09:51 +0000 (18:09 -0400)]
ENIC driver update to allow bonded interface admin down/up to pass traffic

When ENIC ports are used as slaves to a bonded interface, these patches
enable traffic on bonded interface to resume properly on admin down and
then up of the bonded interface.

Change-Id: I339926010da614068417c72009b7af2f892890ce
Signed-off-by: John Lo <loj@cisco.com>
7 years agoVPP-190: support variable length array syntax in request messages 29/1929/2
Marek Gradzki [Mon, 11 Jul 2016 06:35:32 +0000 (08:35 +0200)]
VPP-190: support variable length array syntax in request messages

The information is aleardy stored in array.length field, but
vpe.api syntax should be uniform.

Change-Id: Id84cd95c088281609c70548346cf0e408a6f49ff
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoSimplify API to add LISP adjacencies 28/1928/2
Florin Coras [Sun, 10 Jul 2016 18:09:32 +0000 (20:09 +0200)]
Simplify API to add LISP adjacencies

The API to add an adjacency requires that two things be provided 1) a
local and a remote eid 2) the whole remote mapping for the remote eid.
Since the API to add remote mappings can be used for 2), 1) in
combination with this API are enough to add an adjacency.

Change-Id: Ibe7474924bc3f28b6aed19cefa78fdb812de5eac
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-183: IPSec transport mode 33/1933/1
Matus Fabian [Mon, 11 Jul 2016 14:08:55 +0000 (07:08 -0700)]
VPP-183: IPSec transport mode

Change-Id: I22399aa9d55db0d91da7ba6acbbf552c0d201458
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agodpdk: disable CRC stripping 22/1922/2
Damjan Marion [Fri, 8 Jul 2016 15:36:50 +0000 (17:36 +0200)]
dpdk: disable CRC stripping

Change-Id: I7006a3068c22e18e62c84abb8cc6124695b9ca44
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agopacket-generator: fix pcap stream support 27/1927/2
Damjan Marion [Fri, 8 Jul 2016 20:08:16 +0000 (22:08 +0200)]
packet-generator: fix pcap stream support

Change-Id: I494280964deda1d9448540cb5c6e7a8b750fff93
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agofd-io-styleify for svm 26/1926/1
Dave Barach [Fri, 8 Jul 2016 18:44:23 +0000 (14:44 -0400)]
fd-io-styleify for svm

Change-Id: I816de8b1f255dc3bc6d2904566ea0b0f68fac5d8
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-192 ip_neighbor_add_del incomplete vat help 21/1921/2
Chris Luke [Fri, 8 Jul 2016 14:34:00 +0000 (10:34 -0400)]
VPP-192 ip_neighbor_add_del incomplete vat help

Adds missing items to ip_neighbor_add_del help text

Change-Id: I1d74c7d31ec6d96f8de9bfb5bfc7872b9cbef682
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agofd-io-styleify pass 20/1920/3
Dave Barach [Fri, 8 Jul 2016 13:38:52 +0000 (09:38 -0400)]
fd-io-styleify pass

Change-Id: I72d0dff064162d11321257c858f68da1ba79ea48
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agofd-io-styleify pass 18/1918/6
Dave Barach [Fri, 8 Jul 2016 12:13:45 +0000 (08:13 -0400)]
fd-io-styleify pass

Change-Id: If2d57a213fc2fec996db26df332910c3d2105f97
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoIPv6 frag: avoid overflow while parsing extension headers 13/1813/3
Yoann Desmouceaux [Wed, 29 Jun 2016 16:30:29 +0000 (18:30 +0200)]
IPv6 frag: avoid overflow while parsing extension headers

A malicious packet could advertise an extension header length bigger than
the actual packet length, which would cause an overflow.

Change-Id: I277123e6fde6937b0170f2b2e33846bd22848ac4
Signed-off-by: Yoann Desmouceaux <ydesmouc@cisco.com>
7 years agoAdd locator prority and weight to LISP API 14/1914/2
Filip Tehlar [Thu, 7 Jul 2016 13:40:36 +0000 (15:40 +0200)]
Add locator prority and weight to LISP API

Change-Id: Ifa9bcd9a9c5dbda00ff8096909ccbc822445b8cb
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoRemove unnecessary and obsolete configure.ac directives 16/1916/3
Damjan Marion [Fri, 8 Jul 2016 11:57:11 +0000 (13:57 +0200)]
Remove unnecessary and obsolete configure.ac directives

Also enable silent rules where missing

Change-Id: Ia521886815c862b013f01df4cc18fd8a298aaaa1
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoUpdate emacs plugin skeleton 15/1915/2
Damjan Marion [Fri, 8 Jul 2016 11:46:48 +0000 (13:46 +0200)]
Update emacs plugin skeleton

Change-Id: I52b370abd8b6fec34b8219a274f2de404e072a97
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoAdd IPFIX to vpp-api-test 01/1901/3
Juraj Sloboda [Thu, 7 Jul 2016 07:18:57 +0000 (00:18 -0700)]
Add IPFIX to vpp-api-test

Change-Id: I32dcfb1c33f0b2324de1ebf08851e8b65793e4ea
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
7 years agoAdd binary API for IPFIX 00/1900/2
Juraj Sloboda [Thu, 7 Jul 2016 06:11:47 +0000 (23:11 -0700)]
Add binary API for IPFIX

Change-Id: I3346b18126d65b72726e977dfb11ba4c380056c0
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
7 years agoMake IPFIX src port configurable 99/1899/3
Juraj Sloboda [Thu, 7 Jul 2016 00:04:06 +0000 (17:04 -0700)]
Make IPFIX src port configurable

Make src port configurable in flow report sample code

Change-Id: Ic7d3c3de17b83821106a827fb65e79381044da7e
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
7 years agoMultiple changes in the plugin build infra 07/1907/6
Damjan Marion [Thu, 7 Jul 2016 18:27:49 +0000 (20:27 +0200)]
Multiple changes in the plugin build infra

- configure.ac - some plugins are enabled by default
- Plugin .so files are placed into corresponding subdirs
- WITH_PLUGIN_TOOLKIT macro is retired - not needed anymore
- plugins/build-data is removed
- plugin makefiles are not building static libs anymore
- plugin makefiles are not installing header files to /usr/include
  anymore

Change-Id: I55681bd9ce34811f7eb1b2b24d9f0ca42df1cf04
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoVPP-189 Some bugfixes for issues reported by Coverity 03/1903/4
Chris Luke [Thu, 7 Jul 2016 15:01:17 +0000 (11:01 -0400)]
VPP-189 Some bugfixes for issues reported by Coverity

CID 130914 Buffer not null terminated
CID 130916 Unchecked return value
CID 130938 Unchecked return value from library
CID 130939 Unchecked return value from library
CID 130940 Unchecked return value from library
CID 131042 Argument cannot be negative
CID 131222 Resource leak
CID 131223 Resource leak
CID 131334 Double close
CID 131335 Read from pointer after free
CID 131211 Resource leak
CID 131212 Resource leak

Change-Id: Idd80b91f621278e0be15911f2ed4354dbe4fc7f2
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoAllow DPDK per interface startup config to enable/disable VLAN stripping 06/1906/3
John Lo [Thu, 7 Jul 2016 17:54:44 +0000 (13:54 -0400)]
Allow DPDK per interface startup config to enable/disable VLAN stripping

The init of VIC/ENIC ports enable VLAN stripping of received packets by
default, which is different to all other devices. The VLAN stripping of
ENIC ports can be disabled by adding the per device DPDK config as
"vlan-strip-offload off" such as:
  dpdk {...  dev 0000:0c:00.0 {vlan-strip-offload off} ...}
The per device config "vlan-strip-offload on" can be used for enabling VLAN
stripping for other devices which support this function but is disabled
by default.

Change-Id: I9c81904a87c26868a07900b03677aeeb57f72372
Signed-off-by: John Lo <loj@cisco.com>
7 years agoReset IPFIX streams after configuration change 98/1898/3
Juraj Sloboda [Wed, 6 Jul 2016 13:11:00 +0000 (06:11 -0700)]
Reset IPFIX streams after configuration change

Reset IPFIX streams if reconfiguring IP addresses or collector port

Change-Id: Idc914f90462572342d4ed02b538bb2d30b317931
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
7 years agoSet plugin path properly when using toplevel makefile to run/debug vpp 04/1904/5
Damjan Marion [Thu, 7 Jul 2016 15:56:48 +0000 (17:56 +0200)]
Set plugin path properly when using toplevel makefile to run/debug vpp

Change-Id: Ib6f7dd9d7e1d9f2f2108a8b89421149e4435d5ec
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoAdd configuration options for IPFIX 97/1897/2
Juraj Sloboda [Thu, 7 Jul 2016 10:23:15 +0000 (03:23 -0700)]
Add configuration options for IPFIX

Make Path MTU configurable
Make template resend interval configurable
Make collector port configurable

Change-Id: Ia557916137995ea565f0ede12e169efe81eb0a5d
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
7 years agoUse arbitrary FIB for IPFIX 96/1896/3
Juraj Sloboda [Fri, 1 Jul 2016 13:12:58 +0000 (06:12 -0700)]
Use arbitrary FIB for IPFIX

Change-Id: I85b3543a3f72a10e15c252e04ce2e4a390513ca9
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
7 years agoVPP-142 Recursive route sending traffic to wrong interface 34/1834/2
Neale [Fri, 1 Jul 2016 12:00:09 +0000 (13:00 +0100)]
VPP-142 Recursive route sending traffic to wrong interface

Indirect routes should always result in an indriect adjacency even when the route's next-hop is covered by a connceted, since the covering route may change and no tracking is in place.
Some de-duplication of code for installing indirect routes via the CLI and API.

Change-Id: I7a440ffba43ae3990b68cb407244c06bd0827534
Signed-off-by: Neale <nranns@cisco.com>
7 years agoVPP-148 added bvi_mac flag to l2fib_add_del api call similarly to cli 31/1831/2
marek zavodsky [Fri, 1 Jul 2016 01:49:53 +0000 (03:49 +0200)]
VPP-148 added bvi_mac flag to l2fib_add_del api call similarly to cli

Change-Id: I3b65e85d24ed37b6889af7e194fee45ec61b15a8
Signed-off-by: marek zavodsky <mazavods@gmail.com>
7 years agoFix bugs and do some optimization in IPFIX code 95/1895/2
Juraj Sloboda [Thu, 7 Jul 2016 09:59:28 +0000 (02:59 -0700)]
Fix bugs and do some optimization in IPFIX code

Change-Id: Iba8627062874eac63c584ec05343f4591f48c286
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
7 years agoDocument more nodes 93/1893/2
Dave Barach [Thu, 7 Jul 2016 14:10:17 +0000 (10:10 -0400)]
Document more nodes

Change-Id: Ib8ef0559aa0573bf1229e9c794d48520197f9c8a
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoRemove #if DPDK == 0, to eliminate a data structure size mismatch 02/1902/2
Dave Barach [Thu, 7 Jul 2016 14:35:56 +0000 (10:35 -0400)]
Remove #if DPDK == 0, to eliminate a data structure size mismatch

Otherwise, e.g. the ip4/6_main_t's change size between PLATFORM=vpp
and PLATFORM=vpp_lite. That, in turn, makes it far easier to build
broken plugins.

Change-Id: Ic962d75b170eee698de29c4e29849ce73d27caad
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoRemove duplicate code buffer_func.h 94/1894/2
Damjan Marion [Thu, 7 Jul 2016 14:20:13 +0000 (16:20 +0200)]
Remove duplicate code buffer_func.h

Change-Id: I57e442b1f3486c5e8caac9d2e288869ee10f37b8
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoFix deletion forwarding entries when deleting static remote mapping 88/1888/2
Filip Tehlar [Thu, 7 Jul 2016 07:58:08 +0000 (09:58 +0200)]
Fix deletion forwarding entries when deleting static remote mapping

Change-Id: I11207a0452cbccfb959ff426faefda4820463007
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoRetire support for DPDK 2.1.0 and older 83/1883/3
Damjan Marion [Wed, 6 Jul 2016 21:13:39 +0000 (23:13 +0200)]
Retire support for DPDK 2.1.0 and older

Change-Id: I3c3427c61e32d4727360aa802950bb9ab44afd84
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoAdd some doxygen tags 79/1879/4
Dave Barach [Wed, 6 Jul 2016 14:29:27 +0000 (10:29 -0400)]
Add some doxygen tags

Also add an index of node names

Change-Id: Id65c2e607976d8bad73deb738035a471be077196
Signed-off-by: Dave Barach <dave@barachs.net>
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoAdd an option to dump details about specific LISP EID in API/CLI 44/1844/3
Filip Tehlar [Mon, 4 Jul 2016 09:43:11 +0000 (11:43 +0200)]
Add an option to dump details about specific LISP EID in API/CLI

Change-Id: Ie5e6751fd791e7ca728522632332abe442a1a75b
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoRetire PLATFORM=virl 82/1882/2
Damjan Marion [Wed, 6 Jul 2016 20:52:49 +0000 (22:52 +0200)]
Retire PLATFORM=virl

Change-Id: Iaf9735258f456574534c1a581b983326badea171
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoAdd support for capturing packets on packet generator interfaces 57/1857/5
Damjan Marion [Mon, 4 Jul 2016 19:04:40 +0000 (21:04 +0200)]
Add support for capturing packets on packet generator interfaces

This patch introduces following changes:
 - 4 predefined pg/stream[0-3] interfaces are removed
 - Interface naming is changed form pg/streamX to pgX where X can be
   any u32 value
 - one pgX interface can handle multiple streams
 - keyword "source pgX" is added to "packet-generator add" command, X is 0
   by default
 - new cli "packet-generator capture" is introduced
 - new cli "create packet-generator interface pgX"

Change-Id: I768d075b9d4a34f0b5073debdc5dd4a0880c682c
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoNetmap: Fix Netmap Polling Issue 61/1861/3
Mohsin KAZMI [Wed, 6 Jul 2016 01:17:50 +0000 (03:17 +0200)]
Netmap: Fix Netmap Polling Issue

Previously, netmap node switched from interrupt to polling if
worker threads are enabled even if there was no netmap interface
running. Netmap input node consumed CPU cycles because of input
node calls but these cycles were wasted as input node did not have
any packet to process.

This patch fixes issue stated above using more intelligent way of enabling
or disabling polling based on interfaces count. But the pre-requisite
condition for polling is, worker thread(s) should be enabled.

Change-Id: I3a901823c7b040cce3393958981f439b9f290fe5
Signed-off-by: Mohsin KAZMI <sykazmi@cisco.com>
7 years agoVPP-184 - Bad type translation in jvpp 64/1864/2
Jan Srnicek [Wed, 6 Jul 2016 11:19:12 +0000 (13:19 +0200)]
VPP-184 - Bad type translation in jvpp

Change-Id: I6dda9eb8d58a2bc9a1e4d6636688dfa1f8bb88c6
Signed-off-by: Jan Srnicek <jan.srnicek@pantheon.tech>
7 years agoBug fix for VPP-104 about not being able to down a sub-if if the super-if is up 51/1851/3
Calvin [Mon, 4 Jul 2016 18:14:46 +0000 (14:14 -0400)]
Bug fix for VPP-104 about not being able to down a sub-if if the super-if is up

Change-Id: I913c9807519aa10e515d12fcfbcbfc22b58f5839
Signed-off-by: Calvin <calvin.ference@gmail.com>
7 years agoVPP-182: IPv4 static ARP entries should not be deleted on interface down 59/1859/3
John Lo [Tue, 5 Jul 2016 22:34:40 +0000 (18:34 -0400)]
VPP-182: IPv4 static ARP entries should not be deleted on interface down

IPv4 static ARP entries should remain when interface is set admin-down
and be reapplied on interface admin-up.

Change-Id: Ic0051865154230c2561d6e6421b05d842f147ca7
Signed-off-by: John Lo <loj@cisco.com>