Damjan Marion [Wed, 30 Sep 2020 12:15:24 +0000 (14:15 +0200)]
vpp: update 'show bihash' command
Type: improvement
Change-Id: I6d00ba840d2168af0658f97c45a42d39be7cbbad
Signed-off-by: Damjan Marion <damarion@cisco.com>
Filip Tehlar [Thu, 16 Jul 2020 07:25:56 +0000 (07:25 +0000)]
ikev2: better packet parsing functions
Ticket: VPP-1918
Type: improvement
Change-Id: I2bc3e30121697404dcd54f1c2127bd85ccc1029e
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Filip Tehlar [Mon, 17 Aug 2020 10:59:23 +0000 (10:59 +0000)]
ikev2: show IKE SA command improvements
Ticket: VPP-1898
Type: improvement
Change-Id: I1c56df331965c733a2d0eae63a12d5a4ee5a2e41
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Damjan Marion [Sat, 26 Sep 2020 17:32:34 +0000 (19:32 +0200)]
vppinfra: use heap to store bihash data
Type: improvement
Change-Id: Ifb0fa114414aa2fdc244f964612ca3ac3e29b5e1
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Tue, 29 Sep 2020 06:40:28 +0000 (23:40 -0700)]
svm session: use new clib mem apis for segments
"sh memory map" now reports shared memory segments mapped by session
layer for applications.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I7debdcd06c7728abfb5cf817a1ccc37de495472c
Steven Luong [Tue, 29 Sep 2020 23:23:25 +0000 (16:23 -0700)]
avf: check duplicate pci address upon create interface
Entering duplicate pci address when creating an avf interface causes
crash in register_node
(gdb) f 4
145 error_exit (1);
(gdb) up
354 clib_error ("more than one node named `%v'", n->name);
(gdb) p n
$1 = (vlib_node_t *) 0x7fffbbe55de4
(gdb) p n->name
$2 = (u8 *) 0x7fffbc410b10 "avf-0/4/a/0-tx"
(gdb)
The fix is to loop through the pci addresses in the avf interface pool
and to reject the duplicate.
Type: improvement
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I4ed6fb630fb11982d85c5bb325d9f0d6beeaf023
Artem Glazychev [Tue, 29 Sep 2020 18:07:46 +0000 (01:07 +0700)]
wireguard: fix udp-port registration
Type: fix
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Change-Id: I698ef299316004b797da1e74b64d067caac4bd2d
Florin Coras [Tue, 29 Sep 2020 17:27:07 +0000 (10:27 -0700)]
svm: fix max fifo size
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I52ac28ed6d420f03852a425b5a16a7eb8e94b628
Florin Coras [Tue, 29 Sep 2020 14:45:25 +0000 (07:45 -0700)]
hsa: fix coverity warning
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I046e5aa90016e45b5cbaec12593ba4ac7a659783
Filip Tehlar [Fri, 25 Sep 2020 16:55:03 +0000 (16:55 +0000)]
ikev2: fix false positive NAT detection
Type: fix
Change-Id: Id7f865f537c55d00a784eec51624ba28e903a083
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Mohsin Kazmi [Tue, 29 Sep 2020 10:01:25 +0000 (10:01 +0000)]
virtio: fix modern device queue notify
QUEUE_SELECT and QUEUE_NOTIFY_OFF registers are shared between all
workers operating on the same device and operations are not atomic
Type: fix
Change-Id: Ie017b1bfc7e3b6b4e59029f45db78eeffd9f3aeb
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Florin Coras [Fri, 25 Sep 2020 22:18:13 +0000 (15:18 -0700)]
vcl svm: provide apps access to fifo chunks
Type: feature
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2191b8594b1e87ecc00f237316457db249f73603
Artem Glazychev [Mon, 28 Sep 2020 12:54:35 +0000 (19:54 +0700)]
wireguard: fix license headers
Type: fix
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Change-Id: If5cc8894e0d1785dd04ab1e460e017580c9b41ce
Artem Glazychev [Mon, 28 Sep 2020 12:34:23 +0000 (19:34 +0700)]
wireguard: fix indents
Type: fix
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Change-Id: I84cd7b08eac62160cf407409d32dd40cec7ae9d6
Artem Glazychev [Mon, 28 Sep 2020 09:57:26 +0000 (16:57 +0700)]
wireguard: readme fix
Type: fix
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Change-Id: I0080a158fc3e17dfdd360f6ba164e3bfa3d585a6
Fan Zhang [Fri, 25 Sep 2020 21:36:04 +0000 (22:36 +0100)]
dpdk: fix compile
Type: fix
Since DPDK is now compiled by meson but some compiles in VPP is
missing. This patch fixes that.
- Fixes QAT PMD not compiled. QAT meson compile, even for sym
crypto PMD, is happened in drive/compress/qat. Originally all
PMDs in compressdev is disabled by default. This patch fixes
that.
- Fixes DPDK plugin version detection. DPDK meson build
generates rte_build_config.h, which containing all version
information in build-dpdk instead of rte_config.h in make.
This patch uses the file to detect version data.
- Removed SW crypto PMD auto-creation in cryptodev engine. In
case the AESNI-MB PMD required shared library is missing.
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: I7cd91abb5de303ff5e4c55cd05e011b57f883524
Steven Luong [Mon, 28 Sep 2020 19:25:22 +0000 (12:25 -0700)]
avf: validate queue size config
Check CLI queue size is within the range of 64 and 4096
Enhance show hardware to display queue size and number of queues.
Type: improvement
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I360e3cdb2e69e4ea7380ed924e71a5ae84ed4b64
Damjan Marion [Mon, 28 Sep 2020 17:03:37 +0000 (19:03 +0200)]
vppinfra: don't call dlmalloc API directly from the code
- it is confusing from end consumer perspective that some thing
is somewhere called heap and somewhere mspace
- this is base for additional work where heap pointer is not the same
thing like mspace
Type: improvement
Change-Id: I644d5a0de17690d65d164d8cec3c5654571629ef
Signed-off-by: Damjan Marion <damarion@cisco.com>
Benoît Ganne [Thu, 17 Sep 2020 15:08:07 +0000 (17:08 +0200)]
ikev2: fix memory leaks
Type: fix
Change-Id: I5be19a4923b37e2636621d36155178ac348ee41c
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Mohsin Kazmi [Mon, 28 Sep 2020 10:26:33 +0000 (10:26 +0000)]
virtio: add packet buffering on tx
Type: feature
This patch adds packet buffering on tx for
slow backend which have some jitter/delays
in freeing the vrings.
There are some limitations to the current design:
1) It only works in poll mode.
2) Atleast 1 rx queue of an interface (with buffering
enabled) should be placed on each worker and main thread.
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: Ib93c350298b228e80426e58ac77f3bbc93b8be27
Ray Kinsella [Tue, 7 Apr 2020 06:51:23 +0000 (07:51 +0100)]
classify: use clib_crc32c on supporting uarch
Use clib_crc32c in place of clib_xxhash on supporting uarch.
Type: improvement
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Change-Id: Icdfb4ffa92c2c9e7aebc3ec99f20e91392a103ab
Ray Kinsella [Thu, 12 Mar 2020 15:52:41 +0000 (15:52 +0000)]
classify: preformance improvements in classifiers
Reworked the code to reduce line fill buffer pressure. Improved compiler loop
unrolling, over the existing complex hand-unrolling. Updated the code to use
vlib_get_buffers & vlib_buffer_enqueue_to_next.
Type: improvement
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Change-Id: I7dca7515ba91672eaf50a6eecd13811210cf0006
Ole Troan [Mon, 28 Sep 2020 14:15:18 +0000 (16:15 +0200)]
api: remove clib_mem_init from vppapiclient contructor
Having the constructor in the vppapiclient library led to
conflicts with applications wanting to allocate their own heap.
Note: Change of behaviour, applications that do not use a CLIB
heap must now call vac_mem_init() before using any functions from
vppapiclient.
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ib155a54579ea5a0dbc26cb4b6daca1274e1dfdfa
Nathan Skrzypczak [Mon, 28 Sep 2020 08:13:19 +0000 (10:13 +0200)]
quic: Fix protip #47 / unformat (input_line)
Type: fix
Change-Id: Id03f50c46d28c850865cc76692424d063a0c2cfb
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Mohsin Kazmi [Fri, 25 Sep 2020 13:36:19 +0000 (15:36 +0200)]
virtio: fix the gro enable/disable on tx-vrings
Type: fix
Change-Id: I96c30baaf34fe7b0cd899966a507501e58cde934
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Dave Barach [Fri, 25 Sep 2020 21:30:27 +0000 (17:30 -0400)]
cnat: fix cnat_translation_cli_add_del
Make the command scriptable, use unformat_line_input.
"paths" never needed to be a pool, it's used as a vector. Pools *are*
vectors so no harm but... use vec_add2(...) instead.
Type: fix
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I65b42de77c3c17f532443319d8a5a15a0a930d66
Dave Barach [Sun, 27 Sep 2020 14:22:43 +0000 (10:22 -0400)]
cnat: fix session scanner restart point
Restart point saved by caller, do not restart at i=0.
Type: fix
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I36b7570085c4cbe84cea24339ae579e1fc906af8
Dave Wallace [Thu, 24 Sep 2020 16:30:46 +0000 (12:30 -0400)]
build: remove OS distros which are EOL
Type: fix
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: If80ff6bfbd42779a663af1e7dcfff80d75f47f1e
Nathan Skrzypczak [Mon, 21 Sep 2020 17:14:08 +0000 (19:14 +0200)]
cnat: Add DHCP support
Type: feature
Change-Id: I4bd50fd672ac35cf14ebda2b0b10ec0b9a208628
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Nathan Skrzypczak [Fri, 11 Sep 2020 15:30:06 +0000 (17:30 +0200)]
cnat: Introduce parametric source policy
Type: feature
Change-Id: I60ae9dd1c100b587d1902a20596b99a5c8a95df7
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Nathan Skrzypczak [Thu, 10 Sep 2020 15:44:41 +0000 (17:44 +0200)]
cnat: Add support for SNat ICMP
Type: feature
snat supports :
* echo request/reply by allocating an identifier
when translating echo requests
* icmp errors in the same manner as dnat
Change-Id: I684e983b0181f95c5eace5a984d40084e5625fa4
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Nathan Skrzypczak [Tue, 8 Sep 2020 13:16:08 +0000 (15:16 +0200)]
cnat: Ip ICMP error support
Type: feature
Add CNAT translation for ICMP 4 & 6 errors
inner packet will be translated according
to existing sessions.
Change-Id: If118751988f44ef96b800878596296d1ab8ab6f8
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Jon Loeliger [Fri, 25 Sep 2020 14:22:43 +0000 (09:22 -0500)]
docs: fix typo in bihash clib_bihash_search() documentation
Type: docs
Change-Id: Ic8c628141f8a24b857a654e2ea9129f5f97807b6
Signed-off-by: Jon Loeliger <jdl@netgate.com>
Dave Barach [Fri, 25 Sep 2020 14:18:04 +0000 (10:18 -0400)]
vppinfra: dont complain about linux-vdso.so.1
It's not an elf file, yadda yadda.
Type: fix
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ie02a058adab1068260d9baa0a19398dab8d912d1
Florin Coras [Thu, 24 Sep 2020 18:58:28 +0000 (11:58 -0700)]
vppinfra session: file platform independent private data
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id43b0b6db2b42ee5801236df0bd7f7225e1e081c
Klement Sekera [Fri, 25 Sep 2020 09:43:45 +0000 (09:43 +0000)]
bfd: add missing unlock
Thanks to Martin Sustrik for spotting the bug introduced by
a316744
and submitting the fix.
Type: fix
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I4984fc32503b0c7b6db3543834dfbbfed2a1f23c
Damjan Marion [Thu, 24 Sep 2020 11:53:46 +0000 (13:53 +0200)]
vppinfra: add clib_mem_set_numa_affinity()
Type: improvement
Change-Id: I81a7fb71c8ce0c0d22e326a4ddd01bc1c1aea5f7
Signed-off-by: Damjan Marion <damarion@cisco.com>
Mohsin Kazmi [Wed, 16 Sep 2020 16:53:16 +0000 (16:53 +0000)]
virtio: refactor tx trace
Type: refactor
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: I37fef2c32d0561b944b201a1012b87c7ac315e73
Artem Glazychev [Wed, 23 Sep 2020 13:47:48 +0000 (20:47 +0700)]
wireguard: coverity fix
Type: fix
Change-Id: Ib69b9d83a77d315368ce091085b6bc2d26994282
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Mohsin Kazmi [Wed, 23 Sep 2020 19:29:20 +0000 (19:29 +0000)]
vlib: fix the last error
Type: fix
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: I788678d85dfa1d5b99497013806047440028eb97
Dave Wallace [Thu, 24 Sep 2020 00:19:37 +0000 (20:19 -0400)]
build: fix missing openssl package on debian-10
- libssl-dev missing on debian-10 breaks
'make install-ext-deps'
Type: fix
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ib6a6f120147e8ae0dcfead6fae9f0a7a3434d687
Florin Coras [Wed, 23 Sep 2020 19:02:08 +0000 (12:02 -0700)]
session tcp udp tls quic: improve cli formatting
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iae5dbb8aaaf82d8e95c2ee8bbbe6844c9dd49f80
Florin Coras [Wed, 23 Sep 2020 17:31:27 +0000 (10:31 -0700)]
session: fix sapi coverity warning
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ib00ac02eabb06a300d01697b89d97b26dd3c4330
Dave Wallace [Wed, 23 Sep 2020 15:38:25 +0000 (11:38 -0400)]
build: fix fts.py to run on debian-9/python3.5
Type: fix
Change-Id: I1404e73dd2ee62b51746e9f4760c7c3ca3b5989e
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Damjan Marion [Mon, 21 Sep 2020 12:23:30 +0000 (14:23 +0200)]
ip: use main heap for mtrie, part 2 (remove args)
Type: improvement
Change-Id: I8c28c845c75657852f1e513e2832771fad6b90b7
Signed-off-by: Damjan Marion <damarion@cisco.com>
Vladimir Isaev [Wed, 23 Sep 2020 11:39:17 +0000 (14:39 +0300)]
lldp: fix format string for hw->name
Sanitizer found it. hw->name is not null terminated vector.
So use '%v' for it.
Type: fix
Signed-off-by: Vladimir Isaev <visaev@netgate.com>
Change-Id: Idea16b33d33b371f5b6f6ab403edd0b4860c95f2
Nathan Skrzypczak [Wed, 23 Sep 2020 08:43:16 +0000 (10:43 +0200)]
cnat: Disable default scanner process
Type: feature
Change-Id: Iba9d9f384eaa35c5522e828e3cbe4516416294db
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Artem Glazychev [Mon, 14 Sep 2020 04:36:01 +0000 (11:36 +0700)]
wireguard: add handoff node
All timer and control plane functions happen from main thread
Type: fix
Change-Id: I4fc333c644485cd17e6f426493feef91688d9b24
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Andrew Yourtchenko [Tue, 22 Sep 2020 15:11:51 +0000 (15:11 +0000)]
vppapigen: crcchecker: harmonize the in_progress marking
The format for deprecation is "option deprecated" now,
so harmonize the in-progress marking to logically be
"option in_progress"
At the same time recognize the legacy/erroneous
types of marking, print the warning.
Change-Id: If418dfadd69ffb112550164d63d13420e51cefd7
Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
jiangxiaoming [Wed, 23 Sep 2020 02:29:21 +0000 (10:29 +0800)]
tls: fix session format assert crash in connected callback
Type: fix
Signed-off-by: jiangxiaoming <jiangxiaoming@outlook.com>
Change-Id: I61b7988bf6a49a51041bc6085d5f0f4689ff45a6
Neale Ranns [Tue, 22 Sep 2020 13:20:27 +0000 (13:20 +0000)]
ipip: Add option to tunnel create help string
Type: style
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I3703b9a882b7577025f495d500daf08a916891b9
Andrew Yourtchenko [Tue, 22 Sep 2020 16:04:35 +0000 (16:04 +0000)]
build: allow for rc3/rc4 style tags
Historically, there was only rc1/rc2 tags, fix in case we tag
rc3/rc4 during longer release windows.
Type: fix
Change-Id: I4243a1c03663a877f96a06d647e89adb74abd977
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Neale Ranns [Mon, 21 Sep 2020 08:17:51 +0000 (08:17 +0000)]
lisp: Move to plugin
Type: refactor
Change-Id: I54df533a8f863c4e49742903cf2457f18b4fc506
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Tue, 22 Sep 2020 11:24:18 +0000 (11:24 +0000)]
vxlan-gbp: Mark APIs as in-progress
Type: fix
The GBP plugin that uses this module is also in-ptogress, hence so is
this module.
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I3cb5dd124afac05da013d92d67b2abf6cdf9b769
Yulong Pei [Mon, 21 Sep 2020 20:41:56 +0000 (13:41 -0700)]
crypto: revert crypto set handler all API
This reverts commit
8c91b2ae2b32d428ef35605707788fe064621cb3,
but keep a comment fix.
Type: fix
Signed-off-by: Yulong Pei <yulong.pei@intel.com>
Change-Id: Ia66941bf18d3efac96f41bdf905d877cfb3ab211
Florin Coras [Mon, 21 Sep 2020 17:45:56 +0000 (10:45 -0700)]
session: use wrk instead of thread index in node
Type: refactor
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia36d86eb108f0651fc3af8b4dbdc2d0b49e283da
Neale Ranns [Fri, 18 Sep 2020 07:35:06 +0000 (07:35 +0000)]
geneve: Move to plugin
Type: refactor
Change-Id: I613bf4d6517591351b212bfe6c8d93abf235f5dc
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Fri, 18 Sep 2020 14:05:45 +0000 (14:05 +0000)]
misc: Move l2tp to plugin
Type: refactor
Change-Id: Ifb36eeb146b87e9e305881429d32d6879e955e1e
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Fri, 18 Sep 2020 12:58:40 +0000 (12:58 +0000)]
lldp: Move to plugin
Type: refactor
Change-Id: Ifd770ff4850e63474bf4682ad463021b03786b4b
Signed-off-by: Neale Ranns <nranns@cisco.com>
Matthew Smith [Wed, 16 Sep 2020 21:41:26 +0000 (16:41 -0500)]
vrrp: set up multicast for both address families
Type: fix
When a VR is added, multicast accept routes are added which allow
inbound packets sent to the VRRP group address on the interface of the
VR so advertisements from peers can be received. If this is the first
VR added, also add a local forward route for the VRRP group address so
the packets will be processed by the VRRP input nodes.
When deciding whether to add/delete the local forward route, the total
number of VRs configured was being checked. If there are no VRs
configured initially and a VR is added for IPv4, this check would
correctly see that this was the first VR and add an IPv4 route. If an
IPv6 VR was configured subsequently, this check would find that a VR
was already configured and incorrectly decide that no route needed to
be added and IPv6 VRRP advertisements from peers would be dropped
as a result. The opposite would occur if you first added an IPv6 VR
followed by adding an IPv4 VR - whichever address family was added
first would work correctly and the other one would not work.
Since a route is needed for each address family, check on the per
address family count of VRs when deciding whether to add/delete the
local forward route instead of checking on the global count of VRs.
Change-Id: I851a7ef8a4f9e4e370d08b0832284a13387eb083
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Damjan Marion [Wed, 16 Sep 2020 15:06:45 +0000 (17:06 +0200)]
ip: use main heap for mtrie
Main heap can be hugepage backed so it is more efficient to use
main heap instead of allocating special heap just for mtrie....
Type: improvement
Change-Id: I210912ab8567c043205ddfc10fdcfde9a0fa7757
Signed-off-by: Damjan Marion <damarion@cisco.com>
Andrew Yourtchenko [Wed, 16 Sep 2020 12:10:27 +0000 (12:10 +0000)]
acl: remove custom ACL-plugin heap
Custom ACL-plugin heap was useful in early stages,
but it interferes with other infra optimizations.
Remove it and use global heap.
Change-Id: I2300548f1d1798dec27bc5a2a41cf37f9fcda95d
Type: improvement
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Damjan Marion [Thu, 17 Sep 2020 11:56:47 +0000 (13:56 +0200)]
dpdk: hugepage availibility check using new api
Type: improvement
Change-Id: Iab623a2e11bd5787f4cae549143f49888e0dd9c4
Signed-off-by: Damjan Marion <damarion@cisco.com>
Dave Wallace [Wed, 16 Sep 2020 21:04:24 +0000 (21:04 +0000)]
build: touch files when extracting rpm tarballs
Type: fix
- Long story short, intermittently centos jobs have been
failing with clock skew issues. When someone commits a
patch on a machine with the date ahead of UTC, then clock
skew will be encountered when extracting the RPM source
tarball. See [0] and [1] for details.
- Replace 'make bootstrap' with 'make install-dep' in
RPM package build specfile.
[0] https://unix.stackexchange.com/questions/164807/does-git-archive-use-the-wrong-file-timestamp
[1] https://git.fd.io/vpp/tree/Makefile#n380
Change-Id: Iebfb9eb2e26c1f2e4488e871da86d0c60b9f4048
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Dave Wallace [Fri, 18 Sep 2020 15:35:01 +0000 (15:35 +0000)]
build: remove opensuse build infra
- VPP on opensuse has not been supported
for several releases.
Type: fix
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I2b5316ad5c20a843b8936f4ceb473f932a5338d9
Florin Coras [Fri, 18 Sep 2020 23:15:47 +0000 (16:15 -0700)]
session: grab worker barrier for sapi msgs
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I7cdbcfeb6f77a720e190daf9fe555320e586bba8
Mohammed Hawari [Fri, 18 Sep 2020 19:47:04 +0000 (21:47 +0200)]
dpdk: prevent linking dpdk against libbsd
If libbsd is detected by the DPDK build system, DPDK does not provide
implementations for strlcpy and dynamically link against the one
provided by libbsd. When the DPDK plugin is loaded by VPP, a crash
occurs because libbsd is not loaded by VPP.
Type: fix
Change-Id: Ib691bbe27edcf0f6f0a3d39952e439027cef72cb
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Dave Wallace [Fri, 18 Sep 2020 20:23:55 +0000 (20:23 +0000)]
build: missing deb pkg on ubuntu-20.04
- The vpp build on the ubuntu-20.04 executor failed
due to the package 'dh-python' not getting
installed by 'make install-dep'
Type: fix
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Id9307ad1b4e34c413d90258c6bde2aa5afafec63
Matthew Smith [Thu, 17 Sep 2020 21:33:10 +0000 (16:33 -0500)]
fib: skip byte swap on n_paths in mroute details
Type: fix
While preparing to send a ip_mroute_details API message, the number
of paths for a multicast route is stored in an int in
send_ip_mroute_details(). Before the value in the int is copied into
the field n_paths in the API message, the byte order is swapped.
This results in n_paths getting set to 0.
Change the int to a u8 and omit the byte swap so API clients can
receive data on multicast route paths.
Change-Id: Ie6dcb0f7b135c5b5deeeb2e44147560dbbb12507
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Ole Troan [Tue, 15 Sep 2020 08:53:34 +0000 (10:53 +0200)]
vat: add infrastructure to align vnet test code and plugin test code
Split vat/api_format.c also for VNET features.
Use auto-generated VAT test code and support dynamic message ID allocation as for plugins.
The arp and geneve features as Guinea pigs.
Type: improvement
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I461591496766bdf10c5f950fd30f1a0ae05909da
Signed-off-by: Ole Troan <ot@cisco.com>
Sergey Matov [Tue, 15 Sep 2020 09:40:55 +0000 (13:40 +0400)]
vlib: add decrement counter method
Currently there is no way to decrease simple counter. To extend
counters API new method allows to decrement counter by given value.
This might be useful in implementation of statistics stored in stats
segment.
Type: improvement
Change-Id: I7c08c62bffa6a2d50e9e2cf884f7b2d48538f34b
Signed-off-by: Sergey Matov <sergey.matov@travelping.com>
Signed-off-by: Dave Barach <dave@barachs.net>
Vladimir Isaev [Fri, 18 Sep 2020 11:43:29 +0000 (14:43 +0300)]
tap: do not use strlen on vector
sanitizer complains about strlen on hi->name in tap_dump_ifs.
hi->name is a vector which is not null-terminated, so use vec_len.
Type: fix
Signed-off-by: Vladimir Isaev <visaev@netgate.com>
Change-Id: Icdd5f65369bb51b0c4a9cd86c24899e6febd837c
fanyf [Thu, 17 Sep 2020 14:10:41 +0000 (22:10 +0800)]
session: fix vpp exit abnormal due to application as a proxy server with ldp
Type: fix
The function of application_setup_proxy() be called when application run as a
proxy server, "app_wrk->first_segment_manager" be realloced in this function,
but variable of "sm" point original memory location.
Signed-off-by: fanyf <fanyufei521@outlook.com>
Change-Id: I753c9fb60d1c0794d5eede9f3fab48381a802e3c
Mohammed Hawari [Tue, 15 Sep 2020 12:05:11 +0000 (14:05 +0200)]
dpdk: call the meson-based build instead of Makefiles
Type: feature
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Change-Id: I576d92605da6d43e9b9f12238b18a518a0d69385
Benoît Ganne [Tue, 15 Sep 2020 08:58:07 +0000 (10:58 +0200)]
virtio: fix txq locking
Initialize txq lock only if some txq are shared and check if another
worker is already operating on the txq before processing gro timeouts
in input node.
Type: fix
Change-Id: I89dab6c0e6eb6a7aa621fa1548b0a2c76e6c7581
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Damjan Marion [Fri, 11 Sep 2020 20:18:35 +0000 (22:18 +0200)]
vpp: make main heap page size configurable from startup.conf
Type: improvement
Change-Id: I190c6896152c626aa7cb1055cfce5d9cfcd5b68b
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 17 Sep 2020 08:40:44 +0000 (10:40 +0200)]
stats: configurable page size
Type: improvement
Change-Id: I9973bce20a0a2a8a7e227cf96518de5b79374425
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Thu, 17 Sep 2020 12:56:47 +0000 (12:56 +0000)]
teib: Use ip_address_t not ip46_address_t
Type: improvement
Change-Id: Ica75c4e43d6198658a1954640c7ac56ea68bb39a
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Thu, 17 Sep 2020 11:29:33 +0000 (13:29 +0200)]
vlib: show FD in 'show memory map'
Type: improvement
Change-Id: I04752c011e4ca58f56aa53f6ae27bae93a5c4590
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Wed, 2 Sep 2020 14:46:53 +0000 (14:46 +0000)]
teib: Add adj-fibs for peers/adjacencies on p2mp interface
Type: fix
Change-Id: I6fdc4e952097e92ac3aa53e0be3ef99e0d801b28
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Fri, 11 Sep 2020 20:25:34 +0000 (22:25 +0200)]
vlib: map thread stack instead of allocating them from heap
Heap may use different page sizes so we will not be able to create
stack protection page.
Type: improvement
Change-Id: Ibb35c9f0a151c464ee0167d17f2bd773ef6f530b
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 11 Sep 2020 20:16:53 +0000 (22:16 +0200)]
vppinfra: support main heap with different page sizes
Type: improvement
Change-Id: I381fc3dec8580208d0e24637d791af69011aa83b
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Wed, 16 Sep 2020 19:36:00 +0000 (21:36 +0200)]
vppinfra: detect memory attributes on clib_mem_init
Type: improvement
Change-Id: I298aadfdf17d98dfb1ada1ec4f87e0821e6aeb7f
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 17 Sep 2020 07:54:07 +0000 (09:54 +0200)]
vppinfra: allow handoff to main thread
Type: improvement
Change-Id: If2e907967c9b75997b581ff0c058bd5c15e823f5
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Thu, 17 Sep 2020 00:44:58 +0000 (17:44 -0700)]
vcl: avoid heap use for ldp debug
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I798db694bdc63ae3a6e28d1908245b5ea0bfa84f
Steven Luong [Wed, 16 Sep 2020 20:10:53 +0000 (13:10 -0700)]
avf: wrong argument passed to avf_log_err
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ica4601c9d17e182cbc348989a9f75ab1cb18b78a
Damjan Marion [Wed, 16 Sep 2020 19:15:44 +0000 (21:15 +0200)]
vppinfra: introduce clib_mem_main
To hold more data later...
Type: improvement
Change-Id: I4006d22dcacd788988c4907f2c263fd4e4a9d398
Signed-off-by: Damjan Marion <damarion@cisco.com>
Benoît Ganne [Tue, 15 Sep 2020 08:45:55 +0000 (10:45 +0200)]
vpp: fix main heap init
NUMA node parsing with vlib_get_thread_core_numa() can failed on single
socket systems. Use clib_get_current_numa_node() instead as we already
pinned the main thread to the requested core.
Type: fix
Change-Id: I22339516d0305689a58584c92ded7c96eb53be39
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Steven Luong [Tue, 15 Sep 2020 16:48:38 +0000 (09:48 -0700)]
vmxnet3: gso fixes
outbound:
wrong header len computation
gso size and header length need to be set in the first segment of the
chain
inbound:
EOP may have zero length descriptor to terminate the chain
missing endian conversion for ethertype
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Iaa003c0e9af3ead4df6c6c0d5772a179d2ff15c4
Florin Coras [Tue, 15 Sep 2020 22:56:51 +0000 (15:56 -0700)]
vcl: refactor bapi client index for sapi reuse
Type: refactor
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ibebb6f7d4e610570693e213acd2f6d9332c563c6
Andrew Yourtchenko [Wed, 16 Sep 2020 09:48:59 +0000 (09:48 +0000)]
vppapigen: crcchecker: report in-progress messages
in-progress messages do not give any API stability guarantees,
by design, to allow easy iteration. Provide an easy way
to know which messages are in-progress.
If as a user you see "in-progress" message that you want
to use in production, please contact the feature owner
and discuss the path to removing the "in-progress" status
before that.
Change-Id: I27729995e26a70af373e642b871dbb5cc5526959
Type: improvement
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Yulong Pei [Tue, 15 Sep 2020 02:45:03 +0000 (19:45 -0700)]
crypto: Crypto set handler API to support set all as CLI
Type: improvement
Signed-off-by: Yulong Pei <yulong.pei@intel.com>
Change-Id: I43556f8c76c7aae64d9c927e1fda3c1774d7e49d
Mohsin Kazmi [Tue, 15 Sep 2020 16:41:44 +0000 (16:41 +0000)]
misc: fix the formatting style
Type: style
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: Id86e16677564669b0295bbb9fc1303fe39a21b6f
Ole Troan [Tue, 15 Sep 2020 09:37:16 +0000 (11:37 +0200)]
api: clean up use of deprecated flag
The syntax of the deprecated flag has evolved.
Clean up usage to be "option deprecated;".
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If2b639f275eb8db58b36c457f9245fe35a4d8cb1
Andrew Yourtchenko [Fri, 11 Sep 2020 17:40:52 +0000 (17:40 +0000)]
vppapigen: crcchecker: report deprecated messages
Report if the messages were marked as deprecated,
but not yet deleted.
Useful for building the release notes and comparing
between the releases.
Also, put the dict_compare() call into the report(),
since latter always consumes the output of the former.
Change-Id: Iceab3e94ff66da931a4669b612026bd162dd5d1a
Type: improvement
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
jan_cavojsky [Fri, 11 Sep 2020 08:45:17 +0000 (10:45 +0200)]
flowprobe: add show commands for params and list of interfaces for recording
Type: feature
Ticket: VPP-1861
Signed-off-by: jan_cavojsky <Jan.Cavojsky@pantheon.tech>
Change-Id: Iaeff13b19a712257223a4e77893cfd9398c18327
Dave Barach [Mon, 14 Sep 2020 14:21:11 +0000 (10:21 -0400)]
docs: improve plugin developer's guide
Topics added: disabling lightly-used, experimental, or test plugins
by default. Discourage folks from creating bihash tables, processes
etc. from VLIB_INIT_FUNCTIONs.
Type: docs
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I1235d64971e9ed50f992b75f96b77c934168276a
Simon Zhang [Tue, 15 Sep 2020 15:40:28 +0000 (23:40 +0800)]
tcp: make max gso packet size configurable
Type: improvement
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: I14de90f07d825c5c99023996a88173ee855e9a6f
Onong Tayeng [Tue, 15 Sep 2020 08:25:29 +0000 (13:55 +0530)]
lisp: fix lisp|one_eid_table_dump's local|remote options in vat
The local|remote options to vat's lisp|one_eid_table_dump api command
does not print the eid details instead it produces the following error
messages:
Filter error, unknown filter: 1
Filter error, unknown filter: 2
Type: fix
Signed-off-by: Onong Tayeng <otayeng@cisco.com>
Change-Id: I000c290b400dbf39bd883d57115923167092c9bd
Neale Ranns [Tue, 15 Sep 2020 07:13:46 +0000 (07:13 +0000)]
crypto: Crypto SW Scheduler Coverity Warnings
Type: fix
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I7f98d0c7847ecc40b90b78e5ae83f320575be310