misc: add vnet classify filter set support

Type: feature

Signed-off-by: Dave Barach <[email protected]>
Change-Id: I79b216d2499df143f53977e5b70382f6f887e0bc
(cherry picked from commit f5667c3055dbd6755277f085c6778c2b1104aa6e)

vlib: improve summary vector-rate statistics

Type: refactor

Signed-off-by: Dave Barach <[email protected]>
Change-Id: I4b77879b0a84fdec3c1518a972cf003d5135222d
Signed-off-by: Ole Troan <[email protected]>
(cherry picked from commit a8df85ce1fe957efa8301bd5b5ac3c03737d31f1)

stats: fix per-worker stat vector length

Type: fix

Change-Id: I198a2312f5fc6e922c8a6c51ba7248ce6e236f81
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit dba00cad1a2e41b4974911793cc76eab81a6e30e)

session: allow transport cleanup in any state

Type: fix

Third time's a charm

Change-Id: I31555a35d2b51f49a93a2a213c28896b0cad4c09
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit b5a2f7056967630c2834b0b4bf03520d96806c3e)

rdma: fix non-NULL terminated C-string overflow

Type: fix

Change-Id: I584777825636347c116bd084e348858bcb1b7d75
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit 7ff07354c3a6969e306f75bf28502a46697abcda)

session: fix io_evt mq locking

Type: fix

Change-Id: Iaa8045bba19cc305c84074668a20e1468d431b10
Signed-off-by: Nathan Skrzypczak <[email protected]>
(cherry picked from commit 35174b428b99978503332107a9f330d8b3478bd5)

tests: add quic plugin qclose/sclose tests

Type: test

Signed-off-by: Dave Wallace <[email protected]>
Change-Id: I3122b038f7d77c7e5e8ee7c24046da6c94ca2d2c
(cherry picked from commit 83c1e9a35b41c3bc871a2508f847e64528efccac)

ip: fix use-after-free in reassembly

 - ip{4,6}_reass_finalize() frees the reassembly context: do not access
it after the call.
 - traces access reassembly context: free it after and not before
tracing.

Type: fix

Change-Id: Ia3aaea9c7b74932e249e013be04b9bd7298fd187
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit 2d0ebd7ebc555565868038a09d80a61f5de29430)

classify: use vector code even when data is not aligned

Type: feature

Change-Id: I8f5f4841965beb13ebc8c2a37ce0dc331c920109
Signed-off-by: Damjan Marion <[email protected]>
(cherry picked from commit 8304933922620cef005b788a36a4d3f2eab45bb5)

ip: respect buffer boundary when searching for ipv6 headers

Type: fix

Change-Id: I5a5461652f8115fa1270e20f748178fb5f5450f2
Signed-off-by: Klement Sekera <[email protected]>
(cherry picked from commit 769145cdbc28324bd0b6304951199ec3d6e0e883)

session: fix unbind coverity warning

Type:fix

Change-Id: If4fce6bd9b06ed545d72df847afd6a74cdefe042
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit eef61bb81a22f4c61c01e5afc8bd3b8612a71534)

ipsec: add insecure option for format of SA

If specified, shows keys, otherwise redacts. This change sets this flag
in the existing CLI code (thus maintaining the old behavior). The use
case for not specifying the insecure flag (and thus redacting the keys
from the show output) is for log messages.

Type: feature
Signed-off-by: Christian E. Hopps <[email protected]>
Change-Id: I8c0ab6a9a8aba7c687a2559fa1a23fac9d0aa111
(cherry picked from commit 01d61e7881432a2c508fecbbab804d9c776abe1a)

vcl: initialize ctrl_mq in workers

Type: fix

Change-Id: I1b9c8b0f9292f039b941e18d8aca5d734d5f1e77
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 22ba3303d8e1ead33a4d032a532e38d255461c8a)

ipsec: allow null cipher with dpdk esp

The NULL cipher is a (valid) non-AEAD choice for ESP encrypt path.
Allow it.

Type: fix
Signed-off-by: Christian E. Hopps <[email protected]>
Change-Id: I6d8b66223a0ffb0952c2dd6fa898a8a2289fef7a
(cherry picked from commit 5a2426386d31c90e833c639332a80a8b60bfed2f)

ipsec: fix memleaks in ikev2 openssl code

- Need to always free created contexts
- Always pair init with cleanup for older openssl API.

Type: fix
Signed-off-by: Christian E. Hopps <[email protected]>
Change-Id: Ie8840403bcac500c20085d57240401ad39d119f8
(cherry picked from commit 9a5aab34f51bc1e5458456888ba142ee1055e1f4)

udp: do not send received packets to error-drop

This tends to pollute the error counter.

Type: fix
Signed-off-by: Aloys Augustin <[email protected]>
Change-Id: Idb628e767b074a5ee7e00d001bc88c378d7b8d0b
(cherry picked from commit 8fadb658a1b91a92f174fcf29a3620b644d8fe21)

session: fix cleanup in closing states

Type: fix

Change-Id: Iccc283bb98d3bb459a711ec2b74d6a32ad12903b
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 54c93cfc2556d9c6d2cf472f51d4c2866a556ef6)

fib: fix some typos in fib/mtrie

Type: fix

Change-Id: I1af0e4a9bc23a3b6b6d3a74df093801ab6cae1f8
Signed-off-by: Lijian Zhang <[email protected]>
(cherry picked from commit 33af8c1ed89f15cf0601ee891e9603bef16f2c93)

ip: refactor reassembly

this is a preparation step for introducing other reassembly types

Type: refactor

Change-Id: I197e299dbd729b00eead31667913b8ceff915d63
Signed-off-by: Klement Sekera <[email protected]>
(cherry picked from commit 896c896a3c4ed563a270281ff8b50fd253f4833f)

papi: truncate long logger messages

Dumping whole cli_inband output causes huge unformatted messages written
to logger, so truncate these to avoid that.

Type: fix

Change-Id: I59565a98e3595cbfe4971cc346e104cb198d8f24
Signed-off-by: Klement Sekera <[email protected]>
(cherry picked from commit 5e2f84d2cf97a6efa89c1c4bbf80de6a8f03d2a8)

vlib: add flag to explicitelly mark nodes which can init per-node packet trace

Type: feature

Change-Id: I913f08383ee1c24d610c3d2aac07cef402570e2c
Signed-off-by: Damjan Marion <[email protected]>
(cherry picked from commit 7ca5aaac10e95306f74ea4afd52110dd46aa0381)

build: pass 'no-pci' to autgenerated config

Avoid aggresive hiijack of pci interfaces when 'make run' and
'make run-release' are used and there is no startup.conf present.

Type: feature

Change-Id: Id653b5f9ac3d2935a40299885e616960e75d4a95
Signed-off-by: Damjan Marion <[email protected]>
(cherry picked from commit be7ef3b5c2ebe973405a364454884fc21d35de95)

gbp: fix contract rule handling

Fix a memory leak when removing old GBP contract rules and make sure a
GBP contract rule exists when matching the corresponding ACL rule.

Type: fix
Fixes: 13a08cc098

Change-Id: Iba67d573e69280ad998488a7a3d3462341c68ea4
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit 44ca60ecdba866160bebbc6c1eb983674819d429)

hsa: fix typo in vpp_echo for tx-buf

fix typo and allow use of Gb, Mb or Kb for tx/rx-buf sizes

Type: fix

Change-Id: I2cfd4c09d6b14dd5c744d942eea09ca9ddcc0f46
Signed-off-by: MathiasRaoul <[email protected]>
(cherry picked from commit bb73ae7b14279a908991e19576a79b6d9a58a94d)

nat: fix update of outside fibs (output-feature)

NAT hasn't worked when NAT interfaces wasn't in
default VRF (fib_index = 0). This issue has been occurred with
interfaces with output-feature in endpoint-dependent mode.

Update VAT commands:
  - update nat44_add_del_address_range
  - add nat44_interface_add_del_output_feature

Ticket: VPP-1732
Type: fix

Change-Id: Iddea15dde4b948f159a0056d48c55bd917037fd1
Signed-off-by: Dmitry Vakhrushev <[email protected]>
(cherry picked from commit 6c57a4a985a1e4a49d1aeaf2684166cf2e122cfb)

ebuild: Add MAKE_PARALLEL_FLAGS to VPP build

Align with other packages.

Type: make

Change-Id: I3c8f5c6a349ce9d4e05f546945ae2d8dcf3b1b61
Signed-off-by: juraj.linkes <[email protected]>
(cherry picked from commit 1c887d9362f6c819e7fcf5b3bdecbeb386c9152b)

classify: remove includes from classifier header file

Type: refactor

Change-Id: I6f0af1c3078edce1c1b29a8b99c4a232d7084d33
Signed-off-by: Damjan Marion <[email protected]>
(cherry picked from commit 864d857c6c223be8ec11c588d65e8c5c2e211814)

hsa: refactor vpp_echo failure handling

- Return unique value for each failure condition
- Last failure value returned
- All failures included in description
- Output failure value and description

Type: test

Signed-off-by: Dave Wallace <[email protected]>
Change-Id: I72d5e7f660ad4765c468874421622607af6ae3d1
Signed-off-by: Dave Wallace <[email protected]>
(cherry picked from commit 0e402a98b20fbb7c5b715abd038c244c539bad36)

vcl: allow non-blocking connects

Type: feature

Change-Id: I55349f482ce6781337f747b2f0d2c0a027c3a675
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 57c88938f8a80e63e7307cacaca23b0ab3a51b6c)

ip: mfib CLI 'via local' fix

Type: fix

Change-Id: I6fd7bb27b95a50d37424f65dc51e8b341f8b1b28
Signed-off-by: Neale Ranns <[email protected]>
(cherry picked from commit eacc8c5943e44d19b5a65a68db3ad5adf9e37495)

session: validate connection in session lookup del

Type: fix

Change-Id: I4e2617f99064c5a96e4debae8b68716ca129ee73
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit e1e7fb88e47b0ec99d32ea0391d969542960391a)

tcp: use sacks for timer based recovery

Type: feature

If available, reuse sack scoreboard in timer triggered retransmit to
minimize spurious retransmits.

Additional changes/refactoring:
- limited transmit updates
- add sacked rxt count to scoreboard
- prr pacing of fast retransmits
- startup pacing updates
- changed loss window to flight + mss

Change-Id: I057de6a9d6401698bd1031d5cf5cfbb62f2bdf61
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 36ebcfffbc7ab0e83b4bb8dfaec16bf16cafb954)

ip: fix memory leak in ip_dump handler

Type: fix

A vector allocated by vl_api_ip_dump_t_handler() was not being
freed.

Change-Id: I13425b8087e60df60c6aaa1230aa7e6d60b101a8
Signed-off-by: Matthew Smith <[email protected]>
(cherry picked from commit 6d5f6592559bc0db4294c53236177d4e35e603c6)

session: avoid transport cleanup if previously deleted

Type: fix

Change-Id: I485d38c7d9473e2ad1cbd8e17a788ec8d29ab001
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit cac31a4a23241eb94e6982c049c0feb8b180c868)

hsa: fix vpp_echo stats output

- Output stats when there are missing timing events
- Add missing timing event status to the stats output

Type: fix

Signed-off-by: Dave Wallace <[email protected]>
Change-Id: I10a8db6db9568b98379df544d0098f9722a44867
(cherry picked from commit 789ac9de0674f3e5e064734dd81314716ed8cd1a)

session: move ctrl messages from bapi to mq

Type:refactor

Moves connect, disconnect, bind, unbind and app detach to message
queue from binary api. Simplifies app/vcl interaction with the session
layer since all session control messages are now handled over the mq.

Add/del segment messages require internal C api changes which affect all
builtin applications. They'll be moved in a different patch and might
not be back portable to 19.08.

Change-Id: I93f6d18e551b024effa75d47f5ff25f23ba8aff5
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 458089bbad9cf5bef6cf8119f23fc44e66b36ad3)

tcp: fix unformat cwnd multiplier

Type: fix

Change-Id: Ife4e650cb8b16f84ca6f77ba7b1d17a0f452fc3f
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 1df833e6deecaa1ca68d6e98af7fb109fc0ca18a)

fib: do not dump no-longer valid adjacencies

In some cases, we can refer to no-longer adjacencies (eg. in traces). Do
not dump them in this case as they are probably incorrect (memory can be
reused).

Type: fix

Change-Id: Ib653ba066bb6595ec6ec37d313a3124bce0eeed3
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit 138c37af5291e2045075052a4db036be03be4a85)

gbp: remove loopback interfaces between tests

Type: fix

Change-Id: I440f25b95b23b717518d101a1327ecf16d6ba39a
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit d51880c5de3a1b22d9ac510305bdfe98fa12e51c)

session: fix msg freeing on error

Type: fix

Change-Id: I0807f84737d5e98e69e9ed27a1de6813b2ddd138
Signed-off-by: Nathan Skrzypczak <[email protected]>
(cherry picked from commit 1afa7afffad6e296a97556aa4c9482f4cd544074)

tcp: refactor congestion event handling

Type: refactor

Minor cleanup to congestion event handling.

Change-Id: I7179ff9e21c1853382ba814652c9024f3e5b8a37
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit afef8bf22369d10ab8107a63b1e3529ed7dd6c8d)

session: builtin app rx notifications regardless of state

Type: feature

Provide rx notifications to builtin apps even after disconnect.
Consequently tcp connections that are past FIN_WAIT_1 can still receive
rx notifications.

This is not currently supported for external applications.

Change-Id: I529da7f7120b0e7c62c5026ac71f86d6b5196cf4
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 5c29029ef029edc96340f9eecf7fe24821f2ef2a)

ikev2: add support for GCM cipher

Type: feature
Change-Id: Ic703015b55f0ae947e5e44b10b74b3c79efe7da6
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit de2dd6c35653225525b071d4dc748451e0d6bd7d)

tests: split up the long running IPSec tests into separate classes

Type: test
Change-Id: Ieeae7f1653f5f2e8e49f258871b389ef8954c90b
Signed-off-by: Andrew Yourtchenko <[email protected]>
(cherry picked from commit fbc388986e3f38aaedff87b843137be81b7d4f91)

quic : refactor function naming

- functions renaming to be consistent with the other plugin functions name
- removing useless logs

Type: style

Signed-off-by: MathiasRaoul <[email protected]>
Change-Id: Iea212a799448975e01a92f16cc329de13907ff07
Signed-off-by: MathiasRaoul <[email protected]>
(cherry picked from commit b28349e891a5a6c69b9ee731bdee35405770519d)

tcp: compute snd time for rate sample

Type: feature

Change-Id: I6bd675dc28dbc34293e895911efe986844c0564f
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 7436b436733ea7217e745f3cc9971aaff1e3dfa4)

session: limit pacer bucket size

Type: feature

Change-Id: I3ca27b09670716eba463d7b16771f765a1bd6dcd
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 7c8f828ba353472e27369a77574bca532147e458)

vlib: fix cli process stack overflow

Some cli processes, including bringing up an i40e interface with dpdk,
consume more than the currently available stack space.

Type: fix
Fixes: VPP-1774
Signed-off-by: Aloys Augustin <[email protected]>
Change-Id: I86ceb9e6e07523d5e0f760b5922467f09a8d4006
(cherry picked from commit 735d2e202b6d68059049a233b0a870ec3713564d)

http_static: add dynamic GET / POST method hooks

Add .json output to format_vnet_sw_interface_cntrs(...)

Type: feature

Signed-off-by: Dave Barach <[email protected]>
Change-Id: Ied036ebfaaafbf1dfc2a4e396c00f09f40659400
(cherry picked from commit 5554c56a65cff3ef90844eb5e63d89283fae74df)

vlib: cli support ctrl-w to erase left word

Type: fix
Signed-off-by: Hiroki Shirokura <[email protected]>
Change-Id: I3ae7dc3858d0353764d629d6a9eff2bdab5f8768
(cherry picked from commit 67e4df144b8fd9ef45a188937441ce11260c8b67)

session: add session enable option in config file

Type: feature

Change-Id: I8f02873e75c6e890f6749806d4f02547f951c8ca
Signed-off-by: Nathan Skrzypczak <[email protected]>
(cherry picked from commit 1292d19c79c2fd4f09ffcc43ebf39f5d9d485c35)

hsa: Fix QUIC sessions count calculation

Type: fix
Signed-off-by: Aloys Augustin <[email protected]>
Change-Id: Ia53a41a30920f8af7cd00c6f809b32e7cc277b7a
(cherry picked from commit a786687ab44afe477cef90ca128a82ef0b177c62)

map: fix non-null-terminated C-string

Type: fix

Change-Id: Ia3a4693acd5eab234f60b37436c5b642b00bda46
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit 3c7c613cf18f7825e22190be45ea7f054efafb77)

dpdk: fix null-termination of strings

Fix problem with some strings not being null-terminated,
by using the vec_terminate_c_string macro in two places.
The problem was found using AddressSanitizer.
(Also make sure indentation is OK for those changes.)

Ticket: VPP-1772
Type: fix

Signed-off-by: Elias Rudberg <[email protected]>
Change-Id: Ib7826e3c322e58b649e2d7f6053786da618a5e9e
(cherry picked from commit 7fd402163c221919446942c0784073a56bfd4f70)

hsa: fix memory management bugs

Fix use-after-free and non-null terminated string.

Type: fix

Change-Id: Ibba2a6cae68c612a34477aa813b3bf27a0c8fc1f
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit 58519563acc0933771172941291b7d0de2ffeddc)

quic: fix use-after-free

Type: fix

Change-Id: I5e5e37684e336ca992dae8ea1d39b1fb103802b1
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit 6d6456ab421ee30f14aded964bad2d3ba55bcf20)

quic: fix non-null terminated hostname string

Type: fix

Change-Id: I089d359d5726050f32f69366547086216fdb3098
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit b840c773dc9d7f0f9f85753a20d00acb53a6bce7)

session: fix session filter range

Type:fix

Change-Id: I173f45bf3d90e6979675b2ac812a969539f02147
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 61a89f2b614184eeced3f67affed959897d4da18)

misc: fix shebang with missing env

This is needed for macos where /usr/bin/python[23] does not exist
and /usr/bin is write protected

Type: fix

Change-Id: Ia1b3c732248c78482993de532fa2ea96e376d90a
Signed-off-by: Nathan Skrzypczak <[email protected]>
(cherry picked from commit 5c2f96436afd0cef13797f764474a54f464d7916)

papi: let async calls return context

Callback receives "reply" messages containing context,
but previously there was no easy way
to get the automatically generated context value
of the originally sent "command" message.

With this, the caller can store the contexts,
so the callback knows which command got replied to.

Type: feature

Change-Id: I58ca812d20b03916f74096c396126710115a747c
Signed-off-by: Vratko Polak <[email protected]>
(cherry picked from commit 2f6e0c6002f732b7f938a0f770f19c9dec9269f1)

ikev2: fix crash during IKE SA Init exchange

Type: fix

Change-Id: If827fe348fe35d1221d29f91b7e6ea1624d13999
Signed-off-by: Filip Tehlar <[email protected]>
(cherry picked from commit b736e75d5bb2d132fb00c35b6aabaa52e5f624ad)

quic: fix server opening stream immediately

Previously, if the first thing a server did was to open a stream and
send data, this could trigger a crash on the clilent side VPP as the
quic session wouldn't be allocated.

Change-Id: I43990ce2a71217d6719ecae4da60111d05fbcfc0
Type: fix
Signed-off-by: Aloys Augustin <[email protected]>
(cherry picked from commit ffbfe3a2d6aaf4e847a1848c29fc8ce2997ed260)

build: fix unsupported CMake comparison operation

VERSION_GREATER_EQUAL is not supported before CMake version 3.7.

Type: fix

Signed-off-by: Jianlin Lv <[email protected]>
Change-Id: Id690b7b7c26121f9d289ebd0aaea0860be63795f
(cherry picked from commit ea397f5a67e8cdef1034757cb07fb409dd150fb8)

stats: add /if/<n>/<n>/state for lacp interface state

Add /if/lacp/<bond-sw_if_index>/<slave-sw_if_index>/state

<bond-sw_if_index> is a vector of the bond sw_if_index
<slave-sw_if_index> is a vector of the slave sw_if_index
Content is the integer value of the lacp actor state. The state is actually
a bitfield as described in the lacp protocol spec.

Type: feature

Signed-off-by: Steven Luong <[email protected]>
Change-Id: Ic6eca8ce2a1acd2d858e4e50b7eac1d000ea08e5
Signed-off-by: Ole Troan <[email protected]>
(cherry picked from commit 0f09a828ad2dc53d4f1e69de536f3104eaccc4b0)

tests: run vapi tests by default

Type: fix

Change-Id: I7b190507446fca745fc4bc6abbdeed48f55abdb9
Signed-off-by: Klement Sekera <[email protected]>
Signed-off-by: Andrew Yourtchenko <[email protected]>

stats: fix per_worker vector rate heap

The per_worker counters were outside of the stats heap.
Also fixes the length of the per_vector counter.
A simple vector is two dimensional including a thread dimension.

Fixes: f89a6de8f0
Type: fix
Signed-off-by: Ole Troan <[email protected]>
Change-Id: I370bf9cb033d264f42df2723e01b768dc270792b
(cherry picked from commit a41b0b78a4341478ee6c8701f9ec642b5c2d1cdd)

lb: vpp hang when executing "lb flush" commands with more parameters.

- get all vip list.
- get all as list per vip.

Ticket: VPP-1778
Type: fix

Change-Id: I0d82f38960ef1264d04ac07589a555d01f6e8110
Signed-off-by: Hongjun Ni <[email protected]>

build: fix running error with vmxnet3_test_plugin.so

vpp_api_test load vmxnet3_test_plugin.so error:
"load_one_plugin:42:/vpp/lib/vpp_api_test_plugins/vmxnet3_test_plugin.so:
  undefined symbol: unformat_vlib_pci_addr"

Type: fix

Signed-off-by: Jianlin Lv <[email protected]>
Change-Id: I444aa05d0bc3c4f4f25082388243f1adb305dd0a
(cherry picked from commit 082ebeba166accc87619c45e7de0c29c9f00d254)

libmemif: prevent crash in case of invalid connection handle

Type: fix

Signed-off-by: Jakub Grajciar <[email protected]>
Change-Id: I803c86a48e0148ef143026a5cd93e4510c4f0611
Signed-off-by: Jakub Grajciar <[email protected]>
(cherry picked from commit bdf3ebe358787ef240dc9fadc515dfd178dfef7b)

session: improve cli

Type: feature

Allow session cli filtering based on thread index, transport protocol,
session state and range of session pool indices. For instance

show session thread 1 proto tcp state ready range 0 20 verbose

Shows the session ids for the first 20 tcp sessions in thread 1 that are
in ready state.

To avoid excessive output that could reasult in the worker barrier being
held by the main thread for long periods of time, the session cli will
only output:
- session ids (verbose == 1) for a maximum of 50 sessions / worker
- verbose > 1 details for a maximum of 10 sessions

Change-Id: I2cfb351b548e2e0a1d5b4345810be613e2917d17
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 5bb23ecd098eac639641e2b3d62eb8744e0efef0)

tcp: use rate sample rtt in recovery if possible

If in recovery and rate samples are taken for burts that have not been
retransmitted, use the rtt estimate.

Type: feature

Change-Id: I95028f492008457c959157aa4ee4c3435fa9c3f0
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 1dbda64b467f020db131cb9a01422b8f3fbf58df)

tcp: cleanup scoreboard after recovery

Type: fix

When recovering from congestion, remove last hole in scoreboard if it
covers all bytes sent above snd_congestion.

Change-Id: I752accd4590cd9bf553c35a1bb40a38c308c04f5
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 321cfa5fcb8f347329a5296e2024ef0e6cef319f)

tcp: handle sack reneging

Type: feature

Change-Id: I201155b1b92cf7e57310af726879dab039090582
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 558e3e09577a7b49e2fec58e8ac27f3f3ae0592f)

tcp: enable gso in tcp hoststack

Type: feature

Change-Id: If68d07fbe8c6f7fffd2f93c7e854367082927e4f
Signed-off-by: Simon Zhang <[email protected]>
(cherry picked from commit 1146ff4bcd336d8efc19405f1d83914e6115a01f)

tcp: cc algos handle cwnd on congestion signal

Type: refactor

Change-Id: I15b10a22d0d0b83075a0eef5ef8c09cf76989866
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 8b4114e52f69b9292efb282e49ed4d90699ceeb8)

tcp: send rwnd update only if wnd is large enough

Type: feature

Change-Id: I3e97e05a31806afb6b2e84ecf05fb96d285db92e
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 017dc45243bad1b3708d0a9b902d23ca47859344)

tcp: force zero window on full rx fifo

Type: feature

Change-Id: I7c5684a9f88e56fd62d83a59c14c4e4a6f096b89
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 182d2198332c2a20891a7cdbceeaaf62b47924e8)

tcp: validate connections in output

Type: feature

This shouldn't happen unless connections are removed after buffers were
enqueued to tcp-output and before tcp-output runs. For instance, packet
is enqueued to tcp output and cleanup is called for connection.

Change-Id: Ib7dd82ffa6cfb21ff5068aba010e0a3497eeea13
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 78dae00881d26b205ee6721ce8c2bcae76996e79)

ethernet: move dmac filtering to inline function

In eth_input_process_frame(), destination MAC addresses are
compared to the interface hardware address in a loop. Move
this to a separate inline function to facilitate making changes
to the filtering logic more cleanly.

Type: refactor

Change-Id: I0978f01667e78af5214dbbc9ba223f5b84ce6b7e
Signed-off-by: Matthew Smith <[email protected]>
(cherry picked from commit fa20d4c5375c02f61e565b5fc57c490145bc0919)

session: avoid bihash list for session tables

Type: fix

Change-Id: I1dbc822061f43fcc25dfa5d1728f5c7575139f45
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 27eeb87f43d9d9dfab3d807f33fc5a4a68cb55d9)

gbp: fix set_mac() in unit tests

Do not use low-level sw_interface_set_mac_address() directly and use
higher-level set_mac() instead, otherwise interface local_mac and
configured mac are out-of-sync

Type: fix
Fixes: 25b049484f

Change-Id: I9366e7afb95ef00e25a94ca3b0e6309871169878
Signed-off-by: Benoît Ganne <[email protected]>
(cherry picked from commit a03d25d327ed9db40922cfcf247c3ee793c4754d)

tcp: fix rx min/max fifo size parsing

Type: fix

Change-Id: Iff4a13da654dbdf7f08bb6d0743b466a1e6be01b
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 4e1fcf49057b6bd9b4a3a32a8da20a721536c247)

tcp: improve mss computation

Type: fix

Use different mss for v4 and v6 packets.

Change-Id: Ifcd322c1fd74f749a42bae671dd6cfed8c32b150
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit cedcf608fefc5bdeff13bb0914fa15266e971d7c)

session : make sure session layer is enabled when cli operate the sessions.

Type: fix

show session rules tcp
vpp/src/vnet/session/application_namespace.c:34 (app_namespace_get)
 assertion `! pool_is_free (app_namespace_pool, _e)' fails
Thread 1 "vpp_main" received signal SIGABRT, Aborted.

Signed-off-by: Guanghua Zhang <[email protected]>
Change-Id: I3430339a598a92d0a38826471adeb4547b0b7df4
(cherry picked from commit fcd5e12b1c879b27d9ed53c9c5b3ae98b0a04ccf)

quic: disable quic plugin by default

Change-Id: I8eb243e80ff043a23cb3efae186164dad6c11ca8
Type: fix
Signed-off-by: Aloys Augustin <[email protected]>
(cherry picked from commit baf1c7ccc10134ee38d75532d7bef7d9f3fabfc9)

ipsec ip tcp l2: multiarch nodes cannot be declared as static

Credits to [email protected] who spotted the issue and identified
root cause.

Type: fix

Change-Id: I4afe74c47769484309f6aebca2de56ad32c8041f
Signed-off-by: Damjan Marion <[email protected]>
(cherry picked from commit d770cfc96257f9bd9e0c96c8ebe50e4531dc1bc5)

tests: fix centos detection

Type: fix
Fixes: defde0f870

Change-Id: Ib81e3610bd0fc22901a902dc76692f1951ead2b8
Signed-off-by: Klement Sekera <[email protected]>
(cherry picked from commit 3a350702ec24d1bde0483da1e946015c2b81e0c4)

session: move svm_fifo_clear_deq_ntf to before calling the app callback

Type: fix

in case the app requests another dequeue notification, it should not be cleared

Change-Id: I7e94e8e30ef098f87f5e7f4880af276970ee5b37
Signed-off-by: Vladimir Kropylev <[email protected]>
(cherry picked from commit 5c89fbf28665d13a0052fc88288c1524e0e93918)

devices: fix issue of per_interface_next_index

Per interface, next hop graph node can be customized
with vnet_hw_interface_rx_redirect_to_node function,
but it doesn't work well for af-packet type interface.

In current implementation, with function
af_packet_set_interface_next_node invoked next hop graph
node index can be set to apif->per_interface_next_index,
but it's not set to next0 properly for packet processing
in af_packet_device_input_fn.

Type: fix

Signed-off-by: Michael Yu <[email protected]>
Change-Id: I8e132ddd1c3c01b6f476de78546d4a9389b3ff87
Signed-off-by: Michael Yu <[email protected]>
(cherry picked from commit 90b34ed67a516c4391ad353ba431f8419b582d50)

tcp: track zero rwnd errors

Type: feature

Distinguish between rcv window errors and errors after we advertised a
zero rcv window, i.e., potential window probes.

Change-Id: I6cb453c7aaae456c0a05a8328cfaa55eaca10bf7
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit a495a3ea146a8484dac9f6b594fb2b044437c7a4)

ip: remove unused function parameter

Type: refactor

Signed-off-by: Simon Zhang <[email protected]>
Change-Id: I8674ff5f6f6336b256b7df8187afbb36ddef71fb
(cherry picked from commit e7eba48937c52478d3844745ebb63a4b9ce8d681)

lacp: continuing input packet trace from device driver

lacp gets the packet from the device driver. Let's continue the input
packet trace's trajectory instead of restarting it in lacp-input.

Type: fix

Signed-off-by: Steven Luong <[email protected]>
Change-Id: I4d4537e050742a23f74287086d38d39673ebd60f
(cherry picked from commit 977c1dec69bab72dcae0c62578be7fc0892e897b)

svm: fix fifo hdr freelist allocation

Type: fix

Change-Id: Ia362ad821db1fd506e973e1844cc3ec74703cc17
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 73cad33b56ffc08943e9c0d73ecb14466558baae)

hsa: clean up vpp_echo json output

Type: style

Change-Id: I8dbf2197b78690b94a346d6ff564648ab42f8235
Signed-off-by: Dave Wallace <[email protected]>
(cherry picked from commit 374f706bff707b8a4bcf62cb1ff0c48d5a65b3bf)

quic: enable stable quic tests

Type: test

Signed-off-by: Dave Wallace <[email protected]>
Change-Id: I041c011ee955acba656b774049b530efe1d50f22
(cherry picked from commit f3a8c0803376bcc05db3b80ed97039d1df601b63)

dns: update the MAINTAINERS file

This complements the cherrypick done within
commit 46441cb9cde2044c4e3e743d69418cecc897a63a to sync up the file state
with the corresponding commits in master branch.

Type: fix
Ticket: VPP-1752

Signed-off-by: Andrew Yourtchenko <[email protected]>
Signed-off-by: Dave Barach <[email protected]>
Change-Id: Idc82b1ad59adb0f7c185d27ced57e9a4c25ce62f
(cherry picked from commit 84a563ae4050cc0389dcd438fbe9ea882f2b8404)

avf: reduce default ITR interval

Type: fix
Fixes: b4ff07a

Change-Id: I361ec71944048734b73eec700e32531fb070194e
Signed-off-by: Damjan Marion <[email protected]>
(cherry picked from commit 87f0dc7377311a75e906233b398af89d41b72f15)

tap: fix tap interface not working on Arm issue

The VPP code tries to set all userspace memory in the table via IOCTL
to VHOST_SET_MEM_TABLE. But on aarch64, the userspace address range is
larger (48 bits) than that on x86 (47 bits). Below is an segment from
/proc/[vpp]/maps.

fffb41200000-fffb43a00000 rw-s 00000000 00:0e 532232
/anon_hugepage (deleted)

Instead of setting all userspace memory space to vhost-net, will only set
the address space reserved by pmalloc module during initialization.

Type: fix

Change-Id: I91cb35e990869b42094cf2cd0512593733d33677
Signed-off-by: Lijian Zhang <[email protected]>
Reviewed-by: Steve Capper <[email protected]>
(cherry picked from commit ba0da570f264785f6b50eff7829f6653c0924069)

stats: memory leak with per-node-counters on

vlib_node_get_nodes() creates a duplicate node structure which was never freed.

Type: fix
Fixes: 1ddbc0138b
Signed-off-by: Ole Troan <[email protected]>
Change-Id: Ib1200854937faaa694b398607d2f0ba65aa81c01
(cherry picked from commit b6fde4a8bae474c6b73d08d223028f42e396d452)

vppapitrace: add text output

Add new argument --todump, to mimic the VPP
api trace dump output.

Type: feature
Signed-off-by: Ole Troan <[email protected]>
Change-Id: Ia8c845b321ef9d55dd6e2f388165ca5498406ab6
(cherry picked from commit a2ac36c91749d5377b263c3d99d484ac33854eef)