Michal Cmarada [Fri, 18 Jan 2019 11:51:08 +0000 (12:51 +0100)]
fix data_length in IpSec API call (VPP-1548)
Change-Id: Idb2839f6082bd2e052be2bc5417f0ebb43d1c0a6
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
Su Wang [Fri, 11 Jan 2019 17:46:05 +0000 (12:46 -0500)]
log: bug fix register class compare mismatch
1. Otherwise, the log classes with same prefix, e.g. "abc" and
"abc-de" will all be registered into log class "abc";
2. Minor improvement for test log help string.
Change-Id: I8d93be5e8fa67db6012198b3442a9e2bddcb744a
Signed-off-by: Su Wang <su.z.wang@ericsson.com>
Jim Thompson [Sun, 20 Jan 2019 06:44:43 +0000 (00:44 -0600)]
minor fixup in map doc (people -> seconds)
Change-Id: I151c1afac2133ad32ad7779a59fffafee4b9de60
Signed-off-by: Jim Thompson <jim@netgate.com>
Florin Coras [Sun, 20 Jan 2019 00:45:13 +0000 (16:45 -0800)]
tcp: fix debugging without cc stats (VPP-1547)
Change-Id: I376856fcadce570bb555064435f5876eefb2befa
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Sat, 19 Jan 2019 19:29:18 +0000 (11:29 -0800)]
session: add support for vrf in session unformat (VPP-1546)
Change-Id: Ic5ba751c2bd2db9af4a21d3db40cc305d1208c30
Signed-off-by: Florin Coras <fcoras@cisco.com>
Steven Luong [Sat, 19 Jan 2019 06:53:18 +0000 (22:53 -0800)]
Fix GCC 8 compiler warnings on strncpy's truncated copy on debian distro
For some reason, GCC 8 in debian is pickier than GCC 8 in ubuntu. It complains
about things in strncpy like this
/home/sluong/vpp/src/vlib/linux/pci.c:485:7: error: ‘strncpy’ output may be
truncated copying 15 bytes from a string of length 255 [-Werror=stringop-truncation]
strncpy (ifr.ifr_name, e->d_name, sizeof (ifr.ifr_name) - 1);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/sluong/vpp/src/vlib/linux/pci.c: At top level:
It also complains similar things in string_test.c
The fix in pci.c is to convert strncpy to use clib_strncpy
The fix in string_test.c is condiational compile the complained code for GCC 8.
Change-Id: Ic9341ca54ed7407210502197a28283bc42c26662
Signed-off-by: Steven Luong <sluong@cisco.com>
Damjan Marion [Fri, 18 Jan 2019 19:45:30 +0000 (20:45 +0100)]
buffers: remove free-list information from buffer metadata
Change-Id: I6048c6a51efa826ac333f7d15919cb87dd766d74
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 18 Jan 2019 19:24:44 +0000 (20:24 +0100)]
buffers: remove freelist argument from vlib_buffer_add_data
Change-Id: Idb224b807373128b78dc46f177b2d2e0ed288349
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 18 Jan 2019 19:03:41 +0000 (20:03 +0100)]
Add vlib_buffer_copy_indices inline function
This reverts commit
1e59f9ddbdda14591967e1d66eab8623f9ba58e4.
Change-Id: Iae1d372b887e170d28cac2fe4c61325ee5a5894a
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 17 Jan 2019 17:25:11 +0000 (18:25 +0100)]
cmake: print all flags
Change-Id: Ie80ed430d8c9e2b8fe736402d357ac8b190ca6b7
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 18 Jan 2019 16:09:44 +0000 (17:09 +0100)]
Look for plugins in target triplet subdir
Change-Id: I3bab0ab05b4f552ad64392439fb48409ab0ab8c0
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 18 Jan 2019 18:56:09 +0000 (19:56 +0100)]
deprecate clib_memcpy64_x4
Storing buffer in local template seems to be better option....
Change-Id: I1a2fdd68cb956f99a5b36d2cd810fc623e089bcf
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Fri, 18 Jan 2019 20:12:29 +0000 (12:12 -0800)]
tcp: allow data in passive open ack (VPP-1545)
Change-Id: Iceb99d3f8b7029bd1b1e9ebafb1e0b3790c573e4
Signed-off-by: Florin Coras <fcoras@cisco.com>
Paul Vinciguerra [Sun, 13 Jan 2019 19:33:52 +0000 (11:33 -0800)]
VTL: Fix sphinx doc generation.
Remove unnecessary envvar magic for sphinx builds.
Just provide the proper mock objects.
Change-Id: I151513eb47d2f71cf221651145dbcdc153448772
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Fri, 18 Jan 2019 16:20:31 +0000 (08:20 -0800)]
VTL: Use latest version of syslog_rfc5424_parser (0.2.0) released: 190117
Upstream changes not compatable with: https://gerrit.fd.io/r/#/c/16797/
Running tests using custom test runner
Active filters: file=test_syslog.py, class=None, function=None
Adding tests from directory tree /vpp/test
1 out of 914 tests match specified filters
Not running extended tests (some tests will be skipped)
==============================================================================
Syslog Protocol Test Cases
==============================================================================
Syslog Protocol test OK
==============================================================================
TEST RESULTS:
Scheduled tests: 1
Executed tests: 1
Passed tests: 1
==============================================================================
Test run was successful
Change-Id: I42f86ae3e7f062c0343025ba16bc6e8d2c34ed50
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Florin Coras [Tue, 15 Jan 2019 16:03:17 +0000 (08:03 -0800)]
vcl: move forking logic to vls
Change-Id: I721542aca139d7908a4f917629856f82cae79962
Signed-off-by: Florin Coras <fcoras@cisco.com>
Paul Vinciguerra [Mon, 14 Jan 2019 16:51:17 +0000 (08:51 -0800)]
VTL: Don't swallow exceptions from syslog_rfc5424_parser
Change-Id: I4e93073ceb7b75476e847ae8d56301770c8b264f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Neale Ranns [Thu, 17 Jan 2019 16:28:58 +0000 (08:28 -0800)]
VOM: ip-mroute inspect register handler fix
Change-Id: I57689446005da00fa064e2938cfe55a9e1cef9fc
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Mon, 14 Jan 2019 23:36:03 +0000 (00:36 +0100)]
cmake: initial cross-compilation support
Change-Id: Ib9c2aba1eda08a22465441e33553b9b744c79d56
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Tue, 15 Jan 2019 07:33:46 +0000 (23:33 -0800)]
tls: preallocate app sessions on connect/accept
Avoid allocating session and possibly reallocating thread session pool
on builtin session rx.
Change-Id: I70e7c604678b44ce8d22603489e247a2c5faa439
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Tue, 15 Jan 2019 01:23:11 +0000 (17:23 -0800)]
vcl/session: replicate events for shared sessions
Change-Id: I7fb5402d4a530b5f2ffd9bb5787632099f4b4189
Signed-off-by: Florin Coras <fcoras@cisco.com>
Paul Vinciguerra [Sun, 13 Jan 2019 18:36:17 +0000 (10:36 -0800)]
VTL: Move doc generation and linting to python3.
* running linting/pycodestyle under python3 provides the additional benefit
of access to the python3 AST.
Change-Id: I659dbd2733471285867be95eec078f7415aa0bcd
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Dave Barach [Thu, 17 Jan 2019 14:30:43 +0000 (09:30 -0500)]
DOC ONLY: wireshark dissector upstreamed
Remove the last remnant from extra/wireshark, update the Sphinx docs
Change-Id: I5886557f17192475c03fcb0dfde581e1e63cea5c
Signed-off-by: Dave Barach <dave@barachs.net>
Simon Zhang [Thu, 17 Jan 2019 02:32:48 +0000 (10:32 +0800)]
Fix ASSERT usage issue in cryptodev
Change-Id: I764c6565f96e0cb9078503e54e3cf3bb3fd9ff3f
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
drenfong.wang [Tue, 15 Jan 2019 08:24:26 +0000 (08:24 +0000)]
cmake3 exsit in epel(centos), install epel-release
Change-Id: Ide06350dfb083ec25a52f6ef79f106abd80ccdbc
Signed-off-by: drenfong.wang <drenfong.wang@intel.com>
Stephen Hemminger [Wed, 16 Jan 2019 18:08:39 +0000 (10:08 -0800)]
vmbus: fix strncpy related warnings
The code that was manipulating interface names with ifreq was
causing warnings about possible truncation and non terminated
strings.
These are warnings only since kernel would allow a interface
name > 15 characters anyway.
Change-Id: I794a94fe310b8568403d4e3523c61d53468a6f02
Reported-by: Burt Silverman <burtms@gmail.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Stephen Hemminger [Wed, 16 Jan 2019 18:23:16 +0000 (10:23 -0800)]
pci: fix strncpy warnings
Doing strncpy(ifr.ifr_name, s, sizeof(ifr.ifr_name)) will cause
a warning about string truncation with GCC 8 (and other tools).
Fix this by using sizeof(ifr.ifr_name) - 1. Also, there is no
need to manually zero the end of the string since the whole
ifr structure is already zeroed by memset.
Change-Id: I9440d602ecdd9f8592b69bab2e77479146d00d76
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Simon Zhang [Wed, 16 Jan 2019 08:09:33 +0000 (16:09 +0800)]
fix dpdk cryptodev enable issue
Change-Id: I47d021522cfc92cfb3877449333cbf31022c06f4
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Dmitry Vakhrushev [Wed, 16 Jan 2019 14:44:03 +0000 (09:44 -0500)]
NAT: Fixed issues with dropping reverse packets with output-feature.
Fixed NAT issues with dropping reverse packets in case NAT worked
in 'endpoint-dependent' mode and outside interface has FIB different
from 0 when the output-feature is set.
In this case, the out2in_ed dynamic hash key was not being created
correctly.
Change-Id: I6362967f4b09a375a4606eedaa8e264795b25453
Signed-off-by: Dmitry Vakhrushev <dmitry@netgate.com>
Klement Sekera [Tue, 15 Jan 2019 12:25:09 +0000 (13:25 +0100)]
make test: raise packet tracing limit to 1000
Change-Id: I4309cefe13ee861342e7962c7652919a47748656
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Dave Barach [Wed, 16 Jan 2019 13:21:16 +0000 (08:21 -0500)]
DOC ONLY: update readme.md
Remove the source code, replace with reference to the upstreamed
patch.
Change-Id: I6f5430b1e9804530afbec1805353852e1da745d6
Signed-off-by: Dave Barach <dave@barachs.net>
Steven [Tue, 15 Jan 2019 17:26:18 +0000 (09:26 -0800)]
vmxnet3: add numa support and link speed
Allocate physmem on the same numa
set link speed
cap vmxnet3 support version to 3 if the device supports higher version
Change-Id: Id47dd83b0da53e623fd6cf3ad010e58158b1ab15
Signed-off-by: Steven <sluong@cisco.com>
Ole Troan [Mon, 7 Jan 2019 21:17:31 +0000 (22:17 +0100)]
api_helper_macro mp->pid is network endian
Change-Id: I7d2385b9e9bf5a62f3e9382ca2627a74a4e30785
Signed-off-by: Ole Troan <ot@cisco.com>
Paul Vinciguerra [Sun, 13 Jan 2019 18:26:05 +0000 (10:26 -0800)]
VTL: vpp_papi_provider: Don't shortcircuit vpp_papi jasonfile detection.
The detection login in vpp_papi is significantly more advanced than
the implementation in vpp_papi_provider.
Let's take full advantage of it and ensure consistent behavior.
Change-Id: I786e6d5f4588a0d74e863cce1b0bc1a93fa0e614
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Mon, 14 Jan 2019 00:09:10 +0000 (16:09 -0800)]
VTL: Allow running simple unittest.TestCases.
It came to my attention that Ole added a simple test in:
https://gerrit.fd.io/r/#/c/16381/ and the framework forced him
to launch an instance of VPP to test the formatting of a mac address.
This change allows the test framework to run standard unittest.TestCases
without the need to spawn a VPP instance.
Change-Id: I56651ab27c4c6bf920081a526f168a743d643201
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Mon, 14 Jan 2019 06:00:46 +0000 (22:00 -0800)]
VTL: New version of pyparsing breaks tests.
Specify use of version <2.3.1 released Jan 13, 2019
Change-Id: I23cfb802a677956b77897e0c2b690fac50e18541
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Simon Zhang [Wed, 9 Jan 2019 01:25:18 +0000 (09:25 +0800)]
remove useless line in dpdk cryptodev
Change-Id: I2ef33c7c15b3eb1f55bbfd5cbdd230d6a4d58936
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Alexander Chernavin [Thu, 13 Dec 2018 14:08:09 +0000 (09:08 -0500)]
bonding: support custom interface IDs
Change-Id: I78fe58144fa3ba2e1c7135897a13a2541f235c91
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Steven [Fri, 11 Jan 2019 16:29:41 +0000 (08:29 -0800)]
dpdk: show hardware may display the wrong information for rss active
Some dpdk driver does not support rte_eth_dev_rss_hash_conf_get. When that
happens, we display whatever that was in the stack variable for rss_hf which
is confusing.
The fix is to clear rss_hf prior to the call.
Before the fix
--------------
DBGvpp# sh hard
Name Idx Link Hardware
format_dpdk_device:599: rte_eth_dev_rss_hash_conf_get returned -95
GigabitEthernet13/0/0 2 up GigabitEthernet13/0/0
Link speed: 10 Gbps
Ethernet address 00:0c:29:c4:8c:eb
VMware VMXNET3
...
rss avail: ipv4 ipv4-tcp ipv6 ipv6-tcp
rss active: ipv4 ipv4-frag ipv4-tcp ipv4-udp ipv4-other
After the fix
-------------
DBGvpp# sh hard
Name Idx Link Hardware
format_dpdk_device:600: rte_eth_dev_rss_hash_conf_get returned -95
GigabitEthernet13/0/0 2 up GigabitEthernet13/0/0
Link speed: 10 Gbps
Ethernet address 00:0c:29:c4:8c:eb
VMware VMXNET3
..
rss avail: ipv4 ipv4-tcp ipv6 ipv6-tcp
rss active: none
Change-Id: If8f8327f0012eecc8d23cd7f3f9cc581ca025654
Signed-off-by: Steven <sluong@cisco.com>
Florin Coras [Thu, 10 Jan 2019 20:42:47 +0000 (12:42 -0800)]
session: generate wrong thread errors instead of crashing
Change-Id: I7e59ae718d2722c49d42b22a0874e1645a191e89
Signed-off-by: Florin Coras <fcoras@cisco.com>
Igor Mikhailov (imichail) [Fri, 11 Jan 2019 21:59:04 +0000 (13:59 -0800)]
Fix custom-dump for gre_add_del_tunnel: src and dst IPs
Change-Id: I747ca01dc8df9fb5e11168ec46979c4a1f1baa7c
Signed-off-by: Igor Mikhailov (imichail) <imichail@cisco.com>
Igor Mikhailov (imichail) [Fri, 11 Jan 2019 22:03:53 +0000 (14:03 -0800)]
Fix 'show interface span' field length
Allow to display longer interface names, e.g. VirtualEthernet0/0/0.102
The field length (32) is now the same as for 'show interface'.
Change-Id: I1cb1efd459acb800bfaeeec40b672c8b17cd8c3d
Signed-off-by: Igor Mikhailov (imichail) <imichail@cisco.com>
juraj.linkes [Thu, 10 Jan 2019 11:13:07 +0000 (12:13 +0100)]
Fix interactive tests
When running tests interactively (i.e. not using child process) the
tests are split into small suites each containing tests from a
VPPTestCase, but only the first suite is run. Fix this by creatin a new
suite with all of these small suites in it and running that suite.
Change-Id: I0236f4a980d01765eb993f41d54d98640bb2cd39
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
Mohsin Kazmi [Mon, 7 Jan 2019 14:33:13 +0000 (15:33 +0100)]
gbp2: Fix typo in condition
Change-Id: I1b327309586c9234a22cda011953a1940d31e1ba
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Steven [Tue, 8 Jan 2019 04:32:01 +0000 (20:32 -0800)]
strncpy_s_inline copies more bytes than necessary
Given n equals to the maximum number of bytes to copy from src in the API,
or the rough estimate strlen of src, strncpy_s_inline should not copy more
than the number of bytes, computed by strlen(src), to dst if n is greater than
strlen(src). The number of bytes to copy is computed by strnlen(src,n), not n.
Change-Id: I088b46125d9776962750e121f1fbf441952efc2b
Signed-off-by: Steven <sluong@cisco.com>
Paul Vinciguerra [Wed, 19 Dec 2018 10:05:25 +0000 (02:05 -0800)]
vpp_config: Rework for Python2/3 compatibility.
On ubuntu:
$cd <basedir>/extras/vpp_config
$./scripts/clean.sh
$./scripts/cp-data.sh
$sudo apt-get install python3-pip python3-setuptools
$python3 -m pip install .
$vpp-config
Changes:
* Convert to print() function.
* raw_input changes.
* floor division changes.
* replace vpp-config.py with a setuptools 'vpp-config' entry_point.
* replace netaddr with ipaddress from the standard library and backport.
* .decode() subprocess.Popen's stdout because in python3 they are bytes.
Change-Id: Id98894ee54e0c31a0ba0304134b159caef415705
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Neale Ranns [Thu, 10 Jan 2019 16:56:38 +0000 (08:56 -0800)]
VOM: IP route ECMP support
Change-Id: Iede0c30aacfe7289f428062bb9540410097c40e2
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Thu, 10 Jan 2019 04:04:38 +0000 (20:04 -0800)]
session/vcl: improve fifo tx notifications
Change-Id: Ied476c417c8ba5b4d7c615125c36eecd9ca64fbc
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Wed, 9 Jan 2019 08:04:04 +0000 (00:04 -0800)]
ARP/ND: copy opaque2 persistent fields to new packet
Change-Id: Ic65f686aaccaf8450732d88d7471b587faccaa9d
Signed-off-by: Neale Ranns <nranns@cisco.com>
juraj.linkes [Thu, 20 Dec 2018 13:53:27 +0000 (14:53 +0100)]
Enable random reassembly test for ARM
The underlying failure has been fixed and now the test can be
re-enabled.
Change-Id: I75251f6150ef1771dc23ea079799229690cf87d9
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
juraj.linkes [Fri, 21 Dec 2018 09:17:03 +0000 (10:17 +0100)]
Enable GBP tests for ARM
The underlying failure has been fixed.
Change-Id: If2ca92a17cfed1c2d7253e46ab161f301f847f29
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
Dave Barach [Wed, 9 Jan 2019 15:22:24 +0000 (10:22 -0500)]
Use the official libpcap file type
Change-Id: Ia34a4278eedc8cf450688b1fa0291e1f976868d3
Signed-off-by: Dave Barach <dave@barachs.net>
Paul Vinciguerra [Wed, 9 Jan 2019 04:57:30 +0000 (20:57 -0800)]
test/vpp_papi_provider.py: Fix simple copy/paste error.
Change-Id: I8993132bdd0931c96ba8bc879ec3b4ae938a46c5
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Tue, 8 Jan 2019 00:29:26 +0000 (16:29 -0800)]
test framework. Remove unused code.
Change-Id: I1bd14d5aff4918b58aef18fa0a9264e033989f6e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Mohsin Kazmi [Mon, 7 Jan 2019 18:54:20 +0000 (19:54 +0100)]
gbp: Fix coverity warnings
Change-Id: Iea64d246008b298edeeae338d781b79362f42046
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Jon Loeliger [Thu, 3 Jan 2019 18:56:02 +0000 (12:56 -0600)]
VXLAN: Prevent duplicate bypass graph nodes.
Change-Id: I68cc509b594b09751ff5e0e09bbca187a4a88edd
Signed-off-by: Jon Loeliger <jdl@netgate.com>
Hongjun Ni [Fri, 28 Dec 2018 10:27:04 +0000 (18:27 +0800)]
Fix name of ipv6-n-tuple
Change-Id: Ia95a75295e4865b4720573f164ccba8bcc7679ae
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
Damjan Marion [Thu, 20 Dec 2018 09:44:47 +0000 (10:44 +0100)]
virtio: fix kick race issue
Change-Id: I25b2a28513821bc5eab9ac6890a3964d412b0399
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Tue, 8 Jan 2019 01:49:17 +0000 (17:49 -0800)]
vcl/ldp: select cleanup/improvements
Change-Id: I640e69388f2ab0f66ad60c5165c749f5a5a9f525
Signed-off-by: Florin Coras <fcoras@cisco.com>
Steven [Sun, 6 Jan 2019 19:23:24 +0000 (11:23 -0800)]
string_test: coverity woe
Remove the needless tests and checks which coverity complains about in
string_test.c
Change-Id: I971650cada77136f06528a65625ef99bd3d7e915
Signed-off-by: Steven <sluong@cisco.com>
Andrew Yourtchenko [Mon, 7 Jan 2019 19:56:46 +0000 (20:56 +0100)]
tapv2: add "tap_flags" field to the TAPv2 interface API
Change-Id: I26f99d95f52c9fe107d17dcbbf5c6185523beade
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Damjan Marion [Mon, 7 Jan 2019 19:56:04 +0000 (20:56 +0100)]
avf: allocate descriptor memory from local numa
Change-Id: Ic56ee4ce83b282a5f0f5aed500721fe639b941b3
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Thu, 27 Dec 2018 11:21:28 +0000 (03:21 -0800)]
VOM: mroutes
- fixes in ip.api for dumping mroute path flags
Change-Id: I13b0cfb15d374250ed71bd4e13dda9b798c18204
Signed-off-by: Neale Ranns <nranns@cisco.com>
John Lo [Mon, 7 Jan 2019 20:16:33 +0000 (15:16 -0500)]
L2 BD API to flush all IP-MAC entries in the specified BD
Implement API/CLI to clear IP-MAC tables used for ARP-termination
in the specified bridge domain.
The CLI to flush MAC IP tables for a BD is:
set bridge-domain arp entry <bd-id> del-all
The API added is bd_ip_mac_flush.
Change-Id: I34ceb87c0f480c7102f6559312c24081ed485af8
Signed-off-by: John Lo <loj@cisco.com>
Jon Loeliger [Thu, 3 Jan 2019 23:12:59 +0000 (17:12 -0600)]
MAP: Prevent duplicate MAP-E/T graph nodes.
Change-Id: I6031f3f9cfa048a901a8424d33d47679115c2eb3
Signed-off-by: Jon Loeliger <jdl@netgate.com>
Ping Yu [Mon, 7 Jan 2019 21:03:07 +0000 (16:03 -0500)]
Change vpp code to align with openssl interface change
PR in openssl community is almost done, and need to change some code in VPP
to align with the openssl interface.
Change-Id: Ic7da53e507b67b53958760d07738dd774b1c526d
Signed-off-by: Ping Yu <ping.yu@intel.com>
Dave Barach [Mon, 7 Jan 2019 14:15:47 +0000 (09:15 -0500)]
Handle buffer alloc failure in vlib_buffer_add_data
It's not OK to crash due to a transient buffer allocation failure.
Return 1 if the requested operation failed, otherwise 0.
Buffer index parameter change to a value-result, so the caller can
differentiate between partial and complete allocation failure: callers
which request an initial allocation (inbound bi = ~0) need to check
the (out) value to decide whether or not to call vlib_buffer_free(...).
Change-Id: I03029d7f2714c17dca4630dfd95a1eb578b68384
Signed-off-by: Dave Barach <dave@barachs.net>
Andrej Kozemcak [Mon, 7 Jan 2019 07:39:22 +0000 (08:39 +0100)]
Fix TCP checksum.
Set TCP checksum to zero, before calculate the TCP checksum.
Change-Id: Id96743334481804b8ebb74afef2f1dbfed29e0cb
Signed-off-by: Andrej Kozemcak <andrej.kozemcak@pantheon.tech>
Florin Coras [Sat, 5 Jan 2019 01:05:43 +0000 (17:05 -0800)]
vcl/ldp: add locked sessions shim layer
Moves LDP logic that allows sharing of sessions between multi-process
app workers into a separate VCL shim layer. Also refactors LDP to use
the new layer.
Change-Id: I8198b51eae7d099a8c486e36b29e3a0cb8cee8e9
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Barach [Sun, 6 Jan 2019 20:06:06 +0000 (15:06 -0500)]
Update tcpdump / wireshark packet format writeup
Change-Id: I8195bae1421f68a823b86e12373840f5292ac0df
Signed-off-by: Dave Barach <dave@barachs.net>
Mohsin Kazmi [Mon, 7 Jan 2019 14:33:13 +0000 (15:33 +0100)]
gbp: Fix typo in condition
Change-Id: Ib474e2af98d98d54c9fc4070fab56799555c0f31
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Paul Vinciguerra [Sun, 6 Jan 2019 03:37:27 +0000 (19:37 -0800)]
vpp-api: Add context to VPPStatsIOError.
* Provide context information and return meaningful information.
VPPStatsIOError: Stat segment client connection returned: -2 Stat client socket open but couldn't connect.
Change-Id: I14ea35c58452a2cb7598a7efd136f0c7e1f5743a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Dave Barach [Sat, 5 Jan 2019 21:51:41 +0000 (16:51 -0500)]
pktgen: support mixed multi/single chunk pcap replay
Change-Id: I3d387b5e2b17f89ed688ea6cfee3fb6d782fe326
Signed-off-by: Dave Barach <dave@barachs.net>
Florin Coras [Thu, 3 Jan 2019 03:31:22 +0000 (19:31 -0800)]
vcl/session: add api for changing session app worker
In case of multi process apps, after forking, the parent may decide to
close part or all of the sessions it shares with the child. Because the
sessions have fifos allocated in the parent's segment manager, they must
be moved to the child's segment manager.
Change-Id: I85b4c8c8545005724023ee14043647719cef61dd
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ole Troan [Sat, 5 Jan 2019 10:27:54 +0000 (11:27 +0100)]
socket API: Use pool index instead of handle in sock_delete handler
The socket API used the socket index handle directly in the sock_delete handler,
resulting in "unknown client id" warnings, and a failure in return for socket clients.
Change-Id: Ia69f740ce0f834cd9b62b7157243a1f42bcad765
Signed-off-by: Ole Troan <ot@cisco.com>
Paul Vinciguerra [Wed, 19 Dec 2018 22:34:45 +0000 (14:34 -0800)]
VPP-1508: Python3: Support simultaneous p2/p3 venvs.
Change-Id: I24cf3e390f6f0b98be939ef717048742d3f183d6
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Florin Coras [Fri, 4 Jan 2019 16:45:22 +0000 (08:45 -0800)]
tcp: fix reset in syn-sent
Change-Id: I6732adc06fbb3d4b427e671ddcfe6eabc08d4a1b
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ping Yu [Sat, 1 Dec 2018 00:16:17 +0000 (19:16 -0500)]
Add TLS support for VCL
Ater this patch, vcl_test_client and vcl_test_server can work happily with
TLS connection.
"-S" is to indicate TLS connection.
Change-Id: I761894b0b5929912691625f0fe63604725b55978
Signed-off-by: Ping Yu <ping.yu@intel.com>
Koichiro Den [Wed, 2 Jan 2019 15:22:24 +0000 (00:22 +0900)]
libmemif: fix incorrect write leading to memory corruption
in the worst case scenario this leads to segfault in a hard-to-debug way.
Change-Id: I165adae0bd2dee26af777a2665c8c124d3a49808
Signed-off-by: Koichiro Den <den@klaipeden.com>
Michal Cmarada [Fri, 4 Jan 2019 12:29:25 +0000 (13:29 +0100)]
VPP-1525: additional fixes for strings in Japi
Change-Id: Ic5aa09fdc360cdded16d3c4693f0d4b2067f66d6
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
Florin Coras [Wed, 2 Jan 2019 18:10:08 +0000 (10:10 -0800)]
tcp: add more closing state arcs
Change-Id: If6f4d6404753b2d6b96e17f5414079bcdb9edde8
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Wed, 2 Jan 2019 20:22:02 +0000 (12:22 -0800)]
tcp: better randomize iss
Change-Id: I3638221e59024d6b7d82499d57e25b8e609f73cb
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Barach [Thu, 3 Jan 2019 14:30:00 +0000 (09:30 -0500)]
Fix used-before-set in vl_api_bridge_flags_t_handler
The aarch64 cross-compiler complains about this when building an
optimized image. So we fix it...
Change-Id: Ib2b2089c0534753d7d470311012fa0073ab27d1d
Signed-off-by: Dave Barach <dave@barachs.net>
Ping Yu [Wed, 26 Dec 2018 10:42:38 +0000 (05:42 -0500)]
Fix an issue in tls.c
Curernt code will overwrite parent_app_api_context, and defer the
setting after this value is used in callback.
Change-Id: Ie16e432fd0f4214e6deff3aa3b58b3be824b0331
Signed-off-by: Ping Yu <ping.yu@intel.com>
Florin Coras [Wed, 2 Jan 2019 17:43:01 +0000 (17:43 +0000)]
Revert "add ipsecmb plugin"
This reverts commit
be16020c5034bc69df25a8ecd7081aec9898d93c.
The arm verify job actually failed but the result was overwritten by an x86 ubuntu retry.
Change-Id: Idcae7691fc575053563b8ff8bcad661c15891668
Signed-off-by: Florin Coras <fcoras@cisco.com>
David Johnson [Fri, 14 Dec 2018 19:53:41 +0000 (14:53 -0500)]
Fixes for buliding for 32bit targets:
* u32/u64/uword mismatches
* pointer-to-int fixes
* printf formatting issues
* issues with incorrect "ULL" and related suffixes
* structure alignment and padding issues
Change-Id: I70b989007758755fe8211c074f651150680f60b4
Signed-off-by: David Johnson <davijoh3@cisco.com>
Paul Vinciguerra [Sun, 30 Dec 2018 19:07:36 +0000 (11:07 -0800)]
Add microarch details to 'show cpu'.
Change-Id: I31a3ff9e8f70468196c091027592a3aed2d09ac3
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Matthew Smith [Fri, 21 Dec 2018 17:53:16 +0000 (11:53 -0600)]
ipsec: fix support check when using AES-GCM
When adding an IPsec SA, ipsec_check_support_cb() is called. This
invokes a callback for AH and a callback for ESP to check if the
algorithms are supported.
When using AES-GCM on an ESP SA with the DPDK IPsec backend selected,
the AH callback fails. The DPDK IPsec backend has no AH support,
so the callback for the default OpenSSL backend is invoked. This
checks whether the crypto algorithm is AES-GCM and returns failure.
Only invoke the callback to check support for the IPsec protocol
of the SA - either AH or ESP rather than doing both.
Change-Id: Ic10be6a17b580d06ffb7e82ef5866e53a4f8b525
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Klement Sekera [Thu, 8 Nov 2018 12:25:49 +0000 (13:25 +0100)]
add ipsecmb plugin
Change-Id: I99c0737dfeeec2db267773625ddc9b55324fd237
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Florin Coras [Mon, 31 Dec 2018 01:11:31 +0000 (17:11 -0800)]
ldp/vcl: epoll and shutdown cleanup
Change-Id: I882b4c495426551fad63372dc106496c5e8c141e
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Barach [Tue, 1 Jan 2019 14:45:08 +0000 (09:45 -0500)]
Default huge page size to the regular page size
With this simple tweak, vpp is OK for "make test" or non-dpdk driver
operation over a kernel which doesn't support hugepages at all.
Tested on a Raspberry-pi 3B+ running the Ubuntu 18.04 64-bit server
beta image. It's amazing that such a minimal system will not only
self-compile vpp, but also run the unit tests. It's slow, but what do
you expect for that amount of money?
Change-Id: I7f080f871c828cc4b44be13809495278fadbd717
Signed-off-by: Dave Barach <dave@barachs.net>
Damjan Marion [Sun, 30 Dec 2018 17:09:59 +0000 (18:09 +0100)]
buffers: remove unused code
Change-Id: If2bbfbc52994f5de0879763e0b7a7864498debb6
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Thu, 27 Dec 2018 22:51:46 +0000 (14:51 -0800)]
vcl/ldp: add write msg function and fine tuning
Allows app to push data. Additionally, ensure reset/close replies are
not sent unless vcl closes the session.
Change-Id: Icbbf933cf57b55cfbcc7b802af0f83919a066f65
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Barach [Thu, 27 Dec 2018 18:57:41 +0000 (13:57 -0500)]
binary api clients: wait for vpp to start
Change-Id: I740a7423327b724e88fdfa35d90cb1285e9f9746
Signed-off-by: Dave Barach <dbarach@cisco.com>
Damjan Marion [Fri, 28 Dec 2018 16:43:22 +0000 (17:43 +0100)]
avf: tx dequeue optimizations
Change-Id: I9d8fcf930132e832941e5678a9278a029e104dc3
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 27 Dec 2018 15:18:55 +0000 (16:18 +0100)]
avf: chained buffers rx support
Change-Id: I76ba11441f0ab3d150cdd080919cda91eac60b01
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 27 Dec 2018 10:35:40 +0000 (11:35 +0100)]
avf: chained buffers tx support
Change-Id: Ib573d45def80b4123d5623fda920e6cda1247638
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 28 Dec 2018 14:46:10 +0000 (15:46 +0100)]
vppinfra: add simple ring implementation
Change-Id: I188e2dfd187d7b2ab7e0fbb11461f3db052f3224
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Thu, 27 Dec 2018 19:53:11 +0000 (11:53 -0800)]
session: free session after transport and app confirm
In addition to that, a bit of refactoring.
Change-Id: Iea1eabc2167bcdef185ec53bc09bae087c5398e6
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Thu, 27 Dec 2018 00:29:06 +0000 (16:29 -0800)]
vcl: handle invalid sessions in epoll
Change-Id: I62d37f3c05451e5667863a2c6c551872d5dac1ea
Signed-off-by: Florin Coras <fcoras@cisco.com>