session: add support for postponing transport cleanups

Add new session layer api that allows transports to request postponed
cleanups in session_input. Eventually this should become default
especially if transport connections are to be scrapable before cleanup.

Update tcp and udp for now.

Type: improvement

Change-Id: I74beef41d5deed68efa664b78c1cf95e980b3bde
Signed-off-by: Florin Coras <fcoras@cisco.com>

tcp: reuse and refactor use of del function

Rename tcp_connection_del to tcp_connection_cleanup_and_notify and use
where needed.

Type: refactor

Change-Id: I6007205a63620f1bbf20b59999e833b6d6f631d4
Signed-off-by: Florin Coras <fcoras@cisco.com>

hsa: http client - show latency when verbose

Type: improvement

Change-Id: I448818dcc4959989f89ed412e0bb87899150a8ea
Signed-off-by: Adrian Villin <avillin@cisco.com>

build: add install_manifest.txt to .gitignore

Type: make
Change-Id: I62c0a0a48c2c91496eed4f413b4ea34fcb7d9e8d
Signed-off-by: Damjan Marion <damarion@cisco.com>

vapi: connect/disconnect error handling uds transport

A sudden vpp restart can put vapi into weird state when it tries to read
from closed socket. Fix that by checking for EOF and add some more error
handling to connect and disconnect.

Type: fix

Change-Id: Ida4e69f839e6bfcc470a8a74899975263735d0c0
Signed-off-by: Stanislav Zaikin <stanislav.zaikin@46labs.com>

sr: fixed return msg id in policy update v2 handler

Type: fix

Change-Id: Id6cd8030235f097a41ada8f9a3d7450a71a2c34e
Signed-off-by: Kirill A. Khalitov <voronar@gmail.com>

vnet: add vapi interface feature enablement check function

Type: improvement

Change-Id: I813c832cf6673eae91bd38ab60e7f19a609a5025
Signed-off-by: Kirill A. Khalitov <kirill.khalitov@46labs.com>

linux-cp: do ip6-ll cleanup on interface removal

run a cleanup of ip6 mfib w/o depending on receiving a corresponding
netlink message

Type: fix

Change-Id: I98d5dbbbbb7a56d3ee6f5882b5d6465148049309
Signed-off-by: Stanislav Zaikin <stanislav.zaikin@46labs.com>

prom: return error when http_static not loaded

return error if vlib_get_plugin_symbol return 0 when
http_static_plugin.so is not loaded instead of crashing

Type: fix

Change-Id: Ic281c559c72d3c9f34bc9daae3aa55f0bb711a8a
Signed-off-by: Matus Fabian <matfabia@cisco.com>

pg: improve pg stream test

Type: improvement

Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: Iec449564a495aa4e88142daec1332137d3d0bbd8

pnat: expose binding_index over API

Type: improvement

VPP pnat is internally holding mapping between interface and pnat rule.
This is used by vppctl to delete rules. However querying this is not
possible over API, which makes it impossible to delete a rule w/o
keeping external cache of such mappings.

Change-Id: I3662bfb2caddbac0e1755068bdf7cb965c8acedb
Signed-off-by: Bartlomiej Leszak <bartlomiej.leszak@gmail.com>

vlib: remove unnecessary assert

All nodes can dispatch to other nodes...

Type: improvement
Change-Id: I5b2f1bb69e4118d36fe31f0ba5241ff99ac59ae0
Signed-off-by: Damjan Marion <damarion@cisco.com>

hs-test: adjust iperf performance limits

- asserting min transfer in each test instead of just the main function

Type: test

Change-Id: I1db00033ecd83546259c5fdeec0f6f7d46f19702
Signed-off-by: Adrian Villin <avillin@cisco.com>

hs-test: ignore images with no repo tags when creating containers

While iterating over images available in the system, the user might
have some images with no repo tags, which make hs-test panic when trying
to create containers. Make sure that we have repo tags to read from
before trying to do that.

Type: fix
Change-Id: Ibeaf5ac2685b191fcf258455b98f3165c202a319
Signed-off-by: Semir Sionek <ssionek@cisco.com>

vlib: add dispatch reason strings

Type: improvement
Change-Id: I090744e82ea949dc137bd76c97314a4097c5b842
Signed-off-by: Damjan Marion <damarion@cisco.com>

vlib: add 'use-current-dir' knob to unix {} conf

...to tell vpp to stay in current dir.

Type: improvement
Change-Id: I50813908fbe8bfe81f86c641a2bacc52bfe3122d
Signed-off-by: Damjan Marion <damarion@cisco.com>

vppinfra: silence clang-tidy unsafe warnings for sizeof (a->b[0])

Type: improvement
Change-Id: I23919d5c4e2ca7669053302cf52274cd1960bccc
Signed-off-by: Damjan Marion <damarion@cisco.com>

tcp: tcp_bt_flush_samples coverity fix

Type: fix

Change-Id: I844ac34c929a000dff4fd0f607b5543ad2876eb8
Signed-off-by: Matus Fabian <matfabia@cisco.com>

http_static: try_url_handler coverity fix

Type: fix

Change-Id: I33b0ae7bb5ced718ba5ba014d06994cd19a0daef
Signed-off-by: Matus Fabian <matfabia@cisco.com>

vcl: handle vcl as opposed to ldp reattaches

Type: fix

Change-Id: I01f8de268939a0f720db832ac533e5054aeef875
Signed-off-by: Florin Coras <fcoras@cisco.com>

vlib: refactor file handling

 - remove unix-input pre-input node
 - move epoll functionality to graph scheduler to ensure epoll happens
   before other pre-input nodes
 - add thread wakeup capability (each thread got eventfd instance)

Type: improvement

Change-Id: I1d6dfb61199b76aa16a4b17e3c31a104f137ebe6
Signed-off-by: Damjan Marion <damarion@cisco.com>

udp: track connection startup timestamp

Type: improvement

Change-Id: I8edea1beec82c8e2cfa87e0cc551609d46ee76a7
Signed-off-by: Florin Coras <fcoras@cisco.com>

hsa: add setting desired throughput option for test echo client

Introduce the throughput setting for the echo client, which enables
pacing out the sending of data.

Type: improvement
Change-Id: I337d6d7e3995faf246776edc88c2121cf0ff1b59
Signed-off-by: Semir Sionek <ssionek@cisco.com>

hsa: http_tps confirm data read

notify http transport when body data is read and transport requested
notification (e.g. used by h2 flow control)

Type: improvement

Change-Id: I5c900c19e1c4d14c907984148254316b2b6bd9d0
Signed-off-by: Matus Fabian <matfabia@cisco.com>

unittest: session_get_memory_usage coverity fix

Type: fix

Change-Id: I68b563693540ed0bc8a1d98c3063923a8cc56e67
Signed-off-by: Matus Fabian <matfabia@cisco.com>

build: add --prefix and --verbose to ./configure script

Type: improvement
Change-Id: I1c0f7d70c6988fa3f8bad7771da5a9a6f112e6ef
Signed-off-by: Damjan Marion <damarion@cisco.com>

tests: improve coverage report filters

Type: test

Change-Id: I840386b07f832fb79f6b606d9e3936ccc425f5be
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

vcl: remove detatched pipefds from all workers

Type: fix

Change-Id: Ib5d95b5ab0ce0731e2e53554023036959c265a5b
Signed-off-by: Florin Coras <fcoras@cisco.com>

tests: add an argument to select the vpp binary in run.py

Type: test

Change-Id: I5ec3a54e6f7661e2b742910b1f1fb1f5d4a28a36
Signed-off-by: Naveen Joy <najoy@cisco.com>

vppinfra: unify thread_index handling

use typedef for thread_index instead  if u16, u32, uword....

Type: improvement
Change-Id: Ib31a0f918035e07d8f53c46a3d80b9ad8b3df129
Signed-off-by: Damjan Marion <damarion@cisco.com>

crypto-ipsecmb: call init_mb_mgr_auto instead of the logic implemented on the plugin side

This patch replaces logic for calling init version  with the supported vector instruction set
for a given processor family in the plugin with the call to init_mb_mgr_auto,
which correctly implements it on the ipsecmb engine side.

Type: improvement

Change-Id: I43e502f622f5cc5613917e1c5c943c0ff27d8982
Signed-off-by: Piotr Bronowski <piotrx.bronowski@intel.com>

hs-test: added iperf packet reorder tests

Type: test

Change-Id: I1df8bc4e13bbbdd3c8ee15fbe645bd9a1e4d3fed
Signed-off-by: Adrian Villin <avillin@cisco.com>

http_static: url handler buffer large POST body

Add support to handle larger POST body in url handler using tx_buff,
member of hss_session_t, with configurable limit.

Add hss_confirm_data_read which notify http transport when body data
is read and transport requested notification (e.g. used by h2 flow
control).

Remove old deprecated api (v2 and v3).

Type: improvement

Change-Id: I62640bb9cb851cb567b8176bf01f02c63257ecb9
Signed-off-by: Matus Fabian <matfabia@cisco.com>

tests: update run.py to skip building vpp when running tests

Use make to build vpp before running tests using run.py. Also, fixes
an issue when running tests against an exisiting vpp caused due to
asfframework refactoring.

Type: test

Change-Id: I252a4083db6384caf799095d07f79a9f01240358
Signed-off-by: Naveen Joy <najoy@cisco.com>

build: update vpp-opt-deps to openssl 3.5.0

Type: feature

Change-Id: I55451dfa31ff48a3976fa84c7a3d93144b1ec890
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

memif: fix fib lookup in dma datapath

Packets received using the DMA datapath use the buffer template copied
from the dma_info per-thread data. The sw_if_index[VLIB_TX] was not set
in the vlib buffer template, so subsequent FIB lookups were done using
table 0. This is incorrect if the interface is assigned to a different
table.

Fix the behavior by setting the sw_if_index[VLIB_TX] to ~0, so the FIB
knows to use the table to which the interface is assigned, which is the
same behavior as the non-DMA memif datapath.

Type: fix

Change-Id: I17bf9d21ef8a82c56ef839fbf2b611a633db7255
Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>

vlib: move file_main to vlib/file.[ch]

mechanical change to accomodate following patch...

Type: refactor
Change-Id: I74be905534d8061d0f192b969cfbfd94272922f0
Signed-off-by: Damjan Marion <damarion@cisco.com>

vlib: remove unused variable

Type: improvement
Change-Id: I9a268e7687ebc78e36ef65666749e402b273695a
Signed-off-by: Damjan Marion <damarion@cisco.com>

http: http_app_worker_rx_notify improvement

Do not send rx event to app worker if there is already pending one

Type: improvement

Change-Id: I76c7e222ba13932be2079b5135ffadf5c98155e7
Signed-off-by: Matus Fabian <matfabia@cisco.com>

crypto: add support for aes-cbc with hmac

Type: feature

Support combined enc/auth algorithms with aes-cbc for enc and hmac
(sha1, sha256, md5 ...) for auth in th openssl crypto engine

Change-Id: If915a5aec84a2c365b68ef9f42497593abc1b70e
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>

udp: add basic stats per connection

Type: improvement

Change-Id: I95a3b9c85f4b6ab94250fc8fb5f2a4a142a2f833
Signed-off-by: Florin Coras <fcoras@cisco.com>

session: https parsing support

Type: improvement

Change-Id: I6ec29cda2cb841a70d6f5768f97666b2cc37febb
Signed-off-by: Adrian Villin <avillin@cisco.com>

http: fix http session deschedule

Type: fix

Change-Id: Ieda622ff48422e8f4707c8b624f14d93324e615d
Signed-off-by: Matus Fabian <matfabia@cisco.com>

snort: don't create listner until 1st instance is created

Type: improvement
Change-Id: I343eed4024648e198b7d852c35d5202817e12be3
Signed-off-by: Damjan Marion <damarion@cisco.com>

sr: fix unit tests

fixed several tests that were skipped a long time ago. And also added a test for ECMP

Type: fix

Change-Id: Id58302f3362f3db56cd5b467d761a177464f68c6
Signed-off-by: Artem Glazychev <glazychev@mts.ru>

hs-test: Add CPU pinning tests for 'relative' keyword

Type: test

Added tests to cpu_pinning_suite.go to verify that
VPP launches with different CPU configurations, including
configurations with the 'relative' keyword.

Change-Id: Ia6bef88ca22ebad5d37480230c8a84cabebab4a9
Signed-off-by: Hadi Rayan Al-Sandid <halsandi@cisco.com>

vppinfra: thread safe clib file

Type: improvement
Change-Id: I37663f0f600b6fe8c76de25e77d0425a10ef9a21
Signed-off-by: Damjan Marion <damarion@cisco.com>

vhost: don't access clib file data directly

Type: improvement
Change-Id: I78d2439e196f095aefc84a36061c9f5fe3cac312
Signed-off-by: Damjan Marion <damarion@cisco.com>

vppinfra: explicitelly cast to void * to silence clangd

Type: fix
Change-Id: I286c73d532368e3726269cce9a6993c4911e99cb
Signed-off-by: Damjan Marion <damarion@cisco.com>

vlib: thread safe logging

Type: improvement
Change-Id: I373c40f23bf221287731c86dc7e6ceacdb627f9d
Signed-off-by: Damjan Marion <damarion@cisco.com>

bonding: ASSERT fails for bif->active_members in TX path

Elements in bif->active_members are used without protection in the TX DP path.
However, elements in bif->active_members may freed by another thread asynchronously
and it may cause the ASSERT to fail when accessing elements.
The fix is to take a snapshot of the active_members and use that in the TX DP path.

Type: fix

Change-Id: I081cc81cc4d072807d6cbbcf5d21feb97f500362
Signed-off-by: Steven Luong <sluong@cisco.com>

vlib: timing wheel improvements

Type: improvement
Change-Id: I9b57ed8632e0afea9f4b67972619f411c27f35f2
Signed-off-by: Damjan Marion <damarion@cisco.com>

http: malformed request handling improvement

handle case when sum of the DATA frame payload lengths do not equal
value of content-length header

Type: improvement

Change-Id: I71c4114fb52d7ae1dba9645a3dcf41ffe3516e1f
Signed-off-by: Matus Fabian <matfabia@cisco.com>

tcp: remove erroneous exception seg check assert

Type: fix

Change-Id: Ic3ae960e8f4a28f96b9964f6a3bd60379dd3795f
Signed-off-by: Florin Coras <fcoras@cisco.com>

hs-test: added basic performance testing infra

- only works on ubuntu 22.04 for now
- usage: build docker images, 'make setup-cluster',
  then 'sudo make test-perf'
- TODO: documentation, install KinD and kubectl automatically,
   build containers before cluster setup

Type: feature

Change-Id: Ic4a78a0d9368d947404324c7af8c2520fa7ef3c0
Signed-off-by: Adrian Villin <avillin@cisco.com>

vlib: add 'relative' keyword for cpu configuration

Type: feature

Add keyword 'relative' to translate cpu pinning configuration
to match vpp launch affinity

Change-Id: Ic748e5f4269525764b7adc92a8a5e4877e59c5a3
Signed-off-by: hsandid <halsandi@cisco.com>

vlib: require main core with 'skip-cores' attribute

Type: fix

Not specifying main core with 'skip-cores' attribute can result
in launch issues e.g. if main thread pinned automatically by
scheduler to a cpu in 'skip-cores' range.

Change-Id: Ie47b3691e25ed4ff5d53887d3e1d5e8cb2be00b9
Signed-off-by: Hadi Rayan Al-Sandid <halsandi@cisco.com>

vlib: avoid confusion when parsing plugins section

config_one_plugin steal the vector allocated by unformat()
and memory leak in the error path of config_one_plugin
call vec_dup() and vec_free() when it's needed

Type: fix
Change-Id: I2407e0981e9628c40908cdd26683b98ae27c2159
Signed-off-by: Nicolas PLANEL <nplanel@cisco.com>

dpdk: fix key length for linked crypto algs

Change to key storage in vnet crypto was not propagated to linked algs
in dpdk cryptodev code. There is an explicit key length field now
instead of using vec_len() on the key data.

Type: fix
Fixes: 6676d95169

Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Change-Id: I27fbfa5b2da3db0930cf2b2f2addd00d7400c74d

vlib: fix restart cli command

Type: fix

Change-Id: I961a261a647863936021e4b29d406971fd76c0af
Signed-off-by: Benoît Ganne <bganne@cisco.com>

session: support builtin ct accepts

Type: improvement

Change-Id: I876630549e113b9ee5e81357a30523cbcc6b434e
Signed-off-by: Florin Coras <fcoras@cisco.com>

http_static: url handler POST improvement

for POST request url handler expect data immediately after msg,
but in case of http/2 this was broken because headers and data are
different frames

Type: improvement

Change-Id: I32f93c3945c10c95a7d2150a9b60f79bac2a7e5a
Signed-off-by: Matus Fabian <matfabia@cisco.com>

hs-test: http/2 testing with h2spec

suite is marked as pending since http plugin is not build with http/2
enabled by default

Type: test

Change-Id: If13f2add1f418060dae6d493f2cd800f9f734449
Signed-off-by: Matus Fabian <matfabia@cisco.com>

tcp: do not scale syn-ack window

Type: fix

Change-Id: I1d677a8d80065644a1ddfb3884d99feee04c4756
Signed-off-by: Florin Coras <fcoras@cisco.com>

vppinfra: move spinlock code into macro so it can be reused

Change-Id: Iead3b7e4fa374d1851aa76245407f6e77a26f832
Type: improvement
Signed-off-by: Damjan Marion <damarion@cisco.com>

http: http/2 improvements

- improved handling of malformed frames and protocol violations
- if frame payload is not in fifo stop rx processing

Type: improvement

Change-Id: I4f5bd3f2fda23f2170b63af47d11deca666be27b
Signed-off-by: Matus Fabian <matfabia@cisco.com>

vlib: don't enable api elog by default

Change-Id: Ie6eb9bf9560efbe78976b84e33eb880f2aa66dfe
Type: improvement
Signed-off-by: Damjan Marion <damarion@cisco.com>

vppinfra: fix includes in devicetree code

Type: fix
Change-Id: I493d8c1cc569074172fac79bbc31ed7d8df16a21
Signed-off-by: Damjan Marion <damarion@cisco.com>

http: check if version is known on cleanup

peer might close/reset cleartext connection before send something or
nothing and connection time-out, in this case do not call http vfts

Type: fix

Change-Id: Ie30217fb8c68bf96a8d498bb0d50c8b20eb0e370
Signed-off-by: Matus Fabian <matfabia@cisco.com>

http: PING frame support

Type: improvement

Change-Id: I932c97e4b9fc8d614ae77c3c949f04687a4f29ad
Signed-off-by: Matus Fabian <matfabia@cisco.com>

misc: update vpp python requirements

Type: fix

Change-Id: I715ea3b69342f7b8ab032e40320be9fa938c04e9
Signed-off-by: Naveen Joy <najoy@cisco.com>

vpp: add VPP_PLATFORM to show version output

- when building with VPP_PLATFORM=octeon10,
  the show version output does not include
  the VPP_PLATFORM which is included in the
  debian package name.  Adding this to the
  version helps clarify the platform/package
  name in CSIT trending graphs in addition
  to matching installed debian package name
  for packages with non-default VPP_PLATFORM.

Type: fix

Change-Id: Ieb582a1db576f5e676b97becfdce6ebdfdd3ae41
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

http: http/2 starting tcp connection

Type: feature

Change-Id: Ic731cf0f758f247cd067ca13ec2901c2c01b5065
Signed-off-by: Matus Fabian <matfabia@cisco.com>

http: http/2 stream state machine

server side stream state machine

Type: feature

Change-Id: I03ce57f6c1146f7e1dfd7d54db7d3e3ec7615991
Signed-off-by: Matus Fabian <matfabia@cisco.com>

http: http_buffer improvements

needed for http/2 to make data frame header

http_buffer_get_segs return number bytes in returned segments
http_buffer_is_drain changed to http_buffer_bytes_left
ptr buffer can track u64 data length

Type: improvement

Change-Id: I586bec69c851cb38d7be7af9e254cd240bbd7e62
Signed-off-by: Matus Fabian <matfabia@cisco.com>

http_static: support multiple listeners

Add support for multiple listeners that can be added and removed via
"http static listener" cli.

Type: feature

Change-Id: I024d1bf8b02b2046f1757656944b2d48662a1254
Signed-off-by: Florin Coras <fcoras@cisco.com>

http: handle ts closed notifications

Handle transport closed notifications and update connection state.
Also, handle closed state in app close notifications and force http
connection cleanup if transport is already closed to avoid waiting for
timer based cleanups.

Type: improvement

Change-Id: I26ee6a15b0993810d5a75fa56bb24e3396962f7b
Signed-off-by: Florin Coras <fcoras@cisco.com>

vlib: add vlib_node_unschedule() and vlib_node_is_scheduled()

Type: improvement
Change-Id: I18c3b2c688c2395e49976b9bb17c784cf6e62dc7
Signed-off-by: Damjan Marion <damarion@cisco.com>

iavf: fix promisc flags

define unused flag bits so they are initialized to zero

Change-Id: Ibcab38efa33d70cb4f8a813b5eaf001c8ddea4fe
Type: fix
Signed-off-by: Damjan Marion <damarion@cisco.com>

vlib: use libiberty to demangle backtrace if present

Only C++ for now.... but others like rust can be added easily

Type: improvement
Change-Id: Ic61766f9944c0c19711a40a4686d296605d6c10d
Signed-off-by: Damjan Marion <damarion@cisco.com>

crypto: make configurable crypto engines

Add a configuration sections crypto-engines, it works like plugins syntax :

The following configuration will load and register only openssl engine

'''
crypto-engines {
        default {disable}
        openssl {enable}
}
'''

And this one will load all engines except openssl

'''
crypto-engines {
        default {enable}
        openssl {disable}
}
'''

Type: feature
Change-Id: Ia637db93b497d0c4333704f3c024e85de3941791
Signed-off-by: Nicolas PLANEL <nplanel@cisco.com>
Signed-off-by: Nicolas PLANEL <nplanel@gmail.com>
Signed-off-by: Nicolas PLANEL <nplanel@cisco.com>

hsa: add timed runs option for echo client

Introduce the run-time parameter for echo client, which allows for
running for a certain time with a full buffer as opposed to running
until n amount of data is bounced back.

Type: improvement
Change-Id: I7b5b2138fe3fbbc36511331095a02dafd776fa94
Signed-off-by: Semir Sionek <ssionek@cisco.com>

hs-test: simplify core allocation

- no longer distinguishing between release and debug build in the CI
- core allocation will always start from core 1 (or 0 if CPU0=true)

Type: improvement

Change-Id: I4568bda01bd90fba14ca81f6669bdab3b7521415
Signed-off-by: Adrian Villin <avillin@cisco.com>

acl: use ip4_preflen_to_mask instead of artisanal function

Type: improvement
Change-Id: I4cd52a9f2b8814e8d27a72ea3547fd9f8ee23562
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

vat2: fix -p in vat2 help text

Since commit fe1fb3c31a short option -p stands for --plugin-path and -s
stands for --prefix. Adjust the help text. Also fix a typo and sort
option lists.

Type: fix
Change-Id: I8e9fd825cca930e13e0a09a4492f22951a25e2ee
Signed-off-by: Bence Romsics <bence.romsics@gmail.com>

tests: gracefully terminate iperf3 process to enable cleanups

Type: fix

Change-Id: I24660305ea20d7b69e825a785ce5be3f80b431eb
Signed-off-by: Naveen Joy <najoy@cisco.com>

tests: update lcov ignore_error param

Type: test

Add the value 'negative' into ignore_error param to fix lcov error
for test-cov.

Change-Id: Ia10f70315e9f9f24bfa1d177a7293b65c3889fd2
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>

octeon: set cpt descriptor count to 16k

Set the number of CPT descriptors to 16384.
Add an option to configure cpt descriptor count
from startup conf.

Type: feature

Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com>
Change-Id: Id1ffbe69ad7d457dbd0b11494be1dc0d4a28c324

octeon: fix invalid mac length in chacha poly

This patch fixes invalid mac length to resolve crash in Chacha Poly.

Type: fix

Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com>
Change-Id: Ia940a721b5cb47f7b5fe68adbea78adaaa0f54f0

build: fix the make-ext-deps

After the spring cleaning there were a couple of packages missing,
which prevented the install of the external dependencies.
Also as per Damjan, dkms is no longer needed for dpdk.

Type: fix
Fixes: 27c80923d0cc941c3d6954e2339b0ec75bcf18f9
Change-Id: I7f51577fee25283d64ddb898af87ae7520d6afb0
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

hsa: remove mbytes/gbytes parameters from echo client

...since we're already doing unformat_memory_size on the regular bytes
parameter anyway. In conjunction with that, adjust some make
test/hs-test tests to make use of this parameter.

Type: refactor
Change-Id: Ia0c2899a31b14a8689fdc256e25c4bb418de37fc
Signed-off-by: Semir Sionek <ssionek@cisco.com>

hs-test: remove assert in container.Exec

- removed so we can ignore errors (e.g. vppinstance.Stop)

Type: test

Change-Id: Ib83057eaac7ae6e7338ae9cb59ab2af6239c47a5
Signed-off-by: Adrian Villin <avillin@cisco.com>

http: leave space for msg header on transport method

Type: fix

Change-Id: I4bcc9c6168c18ccf5701b832c26b16d3bb24bc98
Signed-off-by: Florin Coras <fcoras@cisco.com>

http_static: POST to static files improvement

Type: improvement

Change-Id: I6a6794dee3c9e948227e6c08769d45aa595bfe02
Signed-off-by: Matus Fabian <matfabia@cisco.com>

tests: fix text cov-post

Type: test

Need to remove unused html/cmd_line file after genhtml based on
jjb/script/publish_cov.sh error about file name patter without
extension

Change-Id: I607951f8e464bb9e0bb88b4ee84010a5984f082a
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>

vcl: fix coverity warnings

Type: fix

Change-Id: I41a9332bdd7a34ce30eaa5cd2378990dbe8e31f5
Signed-off-by: Florin Coras <fcoras@cisco.com>

dma_intel: fix dsa software fallback

When a page fault occurs, and the "block on fault" flag is not set, the
DSA device reports the error in the completion descriptor and software
should complete the operation in software. This behavior works properly,
except the batch was not added to the list of pending batches, so the
DSA node failed to completely process the batch. The side effect is the
application callback is not called, so buffers are not freed, and the
batch is never added back to the freelist, leading to eventual buffer
exhaustion, and traffic stopping.

The fix is to make sure the batch is added to the list of pending
batches so the DSA node completes the batch. This change also removes
the line that increments the "submitted" counter as that is only used
to count batches that are submitted to hardware. A separate counter,
sw_fallback, is used to count batches that are handled in software.

Type: fix
Change-Id: Ib54e8d77ac02e5dca237bb9348440c3ddaad993b
Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>

tests: fix test cov for PG Stream and Session SDL

Type: test

Localized cli response waiting time configuration only for
test_pg_stream and test_session_sdl instead of asfframework conf

Change-Id: Iabeccdda97e518662f1243edd91217c02cdc8711
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>

tests: fix test cov

Type: test

Need to add cli response waiting timeout for test cov for test_session_sdl
and test_pg_stream.

Change-Id: I3eedfdb0de1ca01d9786742986fbcce2487500e3
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>

vcl: improve vpp detached handling for mq epoll apps

Apps that rely on epoll and use eventfds for mq signaling can
potentially sleep indefinitely if vcl detaches from vpp and no libc fd
generates events.

To avoid this, at detach time, force creation of a pair of pipes that
constantly generates mq_epfd events to force apps, including ldp, to
request vppcom epoll_waits which retry attaching to vpp.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ie2ac338cc10721829e6ac525ee7d6b812354e9a3