Mauro Sardara [Wed, 11 Dec 2019 18:37:19 +0000 (19:37 +0100)]
[HICN-430] Build sysrepo and libyang extra with correct dependencies
Change-Id: Icc758938acac76a407d3a6d37a4896c331e47380
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Mauro Sardara [Wed, 11 Dec 2019 17:45:15 +0000 (18:45 +0100)]
[HICN-430] Update extra dependencies
Change-Id: I10a505ea638688f7a08fc92bdecffead5721ae8b
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Jordan Augé [Wed, 11 Dec 2019 16:36:37 +0000 (16:36 +0000)]
Merge "[HICN-446] Face manager incorrectly sets up static routes in case of multihoming during startup"
Alberto Compagno [Wed, 11 Dec 2019 14:30:43 +0000 (14:30 +0000)]
[HICN-447] Converting incomplete udp face into a complete one
When inserting a udp face through cli or binary api, if an
incomplete udp face already exist with the same local and remote
addresses and port, the face is converted into a complete face
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: I8e7b5eee6c492367f663b2b97d50b6ca166b4824
Jordan Augé [Wed, 11 Dec 2019 14:08:48 +0000 (15:08 +0100)]
[HICN-446] Face manager incorrectly sets up static routes in case of multihoming during startup
Change-Id: Iee01146d3d9437f0267cfac3de793608cccca5bc
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Mauro Sardara [Wed, 11 Dec 2019 10:32:51 +0000 (11:32 +0100)]
[HICN-430] Do not install cmake on arm slaves.
Change-Id: I315862308d27fad6420bbce35de0fd6ad17a3240
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Mauro Sardara [Wed, 11 Dec 2019 10:20:44 +0000 (11:20 +0100)]
[HICN-430] Remove unspecified package.
Change-Id: I578395371585337ab7c8a2b3e25c365b473e2ee6
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Luca Muscariello [Wed, 11 Dec 2019 09:41:02 +0000 (09:41 +0000)]
Merge "[HICN-430] Rework on CMake"
Jordan Augé [Tue, 10 Dec 2019 22:57:37 +0000 (23:57 +0100)]
[HICN-438] facemgr should allow face creation with physical interface down
Change-Id: I6487fbec0607464a625daa01455ddac8fdd75ee2
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Mauro Sardara [Fri, 6 Dec 2019 17:25:28 +0000 (18:25 +0100)]
[HICN-430] Rework on CMake
Change way targets are defined: each project defines targets.
Fix project BUILD flags
Add build-extras bash script
Rework build tree of extras folder, using ExternalProject_Add
Change-Id: I82fa29896e54c8a033490eba013c3f0431bec9d0
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Michele Papalini [Tue, 10 Dec 2019 10:11:35 +0000 (10:11 +0000)]
Merge "[HICN-441] Fixed udp punting. Ip version of the punting (6 or 4) was set in the wrong way. Before enabling punting we were checking for the wrong table type (ip4 when it was 6 and vice versa)"
Alberto Compagno [Mon, 9 Dec 2019 16:56:47 +0000 (16:56 +0000)]
[HICN-441] Fixed udp punting.
Ip version of the punting (6 or 4) was set in the wrong way. Before
enabling punting we were checking for the wrong table type (ip4 when
it was 6 and vice versa)
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: I1d144010b5f26fdbc98517a647bc218692813f09
Jordan Augé [Mon, 9 Dec 2019 00:23:37 +0000 (01:23 +0100)]
[HICN-438] facemgr should allow face creation with physical interface down
Change-Id: I9d333f2d420c735d3867c0813dc93e82aceb3861
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
michele papalini [Fri, 6 Dec 2019 10:13:11 +0000 (11:13 +0100)]
[HICN-437] concurrency problem in rtc producer socket
Signed-off-by: michele papalini <micpapal@cisco.com>
Change-Id: I629914f48e00814796f16b201e03549e9c7941bd
Alberto Compagno [Thu, 5 Dec 2019 08:19:41 +0000 (08:19 +0000)]
Merge "[HICN-435] Fixed dependency name in libhicntransport"
Jordan Augé [Wed, 27 Nov 2019 08:05:39 +0000 (09:05 +0100)]
[HICN-420] MAP-Me code refactoring & face manager changes in support of mobility
Change-Id: Ifde50b4c161d1bda1326f18b705f575e539aea71
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Alberto Compagno [Wed, 4 Dec 2019 17:03:40 +0000 (17:03 +0000)]
[HICN-435] Fixed dependency name in libhicntransport
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: Ia2700df02a90f1acab30f52f642c90f2460c0282
mhemmatp [Wed, 4 Dec 2019 14:01:05 +0000 (15:01 +0100)]
[HICN-434] VAPI does not link to hicn sysrepo plugin
Signed-off-by: mhemmatp <mhemmatp@cisco.com>
Change-Id: I3d2fa27baf00b5fa70bef5c1c414475eabcd525c
Mauro Sardara [Wed, 4 Dec 2019 10:59:44 +0000 (10:59 +0000)]
Merge "[HICN-433] fix and tune parameters in rtc transport"
michele papalini [Wed, 4 Dec 2019 10:44:17 +0000 (11:44 +0100)]
[HICN-433] fix and tune parameters in rtc transport
Signed-off-by: michele papalini <micpapal@cisco.com>
Change-Id: Ib67d395e0c7c4ac4c11dabe44cbde417faa70e20
Alberto Compagno [Mon, 2 Dec 2019 19:41:05 +0000 (19:41 +0000)]
[HICN-427] Producer and consumer socket created with vapi
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: I44142385b191b4c9b5c4bb418bfbd06a5e102eec
Mauro Sardara [Wed, 4 Dec 2019 09:56:31 +0000 (09:56 +0000)]
Merge "to fix HICN-421 by adding cpack to libyang and sysrepo"
Alberto Compagno [Wed, 4 Dec 2019 09:47:10 +0000 (09:47 +0000)]
Merge "[HICN-428] Creating libctrl deb and rpm packages specific for hicn-plugin"
Jordan Augé [Mon, 2 Dec 2019 13:28:22 +0000 (14:28 +0100)]
to fix HICN-421 by adding cpack to libyang and sysrepo
Signed-off-by: Luca Muscariello <muscariello@ieee.org>
Change-Id: Ia9e0752f877c7fc0be6df85664d18e1caad86741
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Mauro Sardara [Wed, 4 Dec 2019 09:34:19 +0000 (10:34 +0100)]
[HICN-432] Set CPACK_COMPONENT_ALL variable with the global list of components.
Change-Id: I6a8c4dba362914ce4d80c86adffc8ca98ab4c2a1
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Alberto Compagno [Tue, 3 Dec 2019 16:00:27 +0000 (16:00 +0000)]
[HICN-428] Creating libctrl deb and rpm packages specific for hicn-plugin
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: I2460276eb400777105d3351dffdaf8452f01c51f
Alberto Compagno [Mon, 2 Dec 2019 18:28:10 +0000 (18:28 +0000)]
Merge "[HICN-425] RTC min window"
michele papalini [Mon, 2 Dec 2019 18:15:19 +0000 (19:15 +0100)]
[HICN-425] RTC min window
Signed-off-by: michele papalini <micpapal@cisco.com>
Change-Id: Ic75e11dcf43b7ed947a8f577d9aa5d345d5662ee
Mauro Sardara [Mon, 2 Dec 2019 15:32:33 +0000 (16:32 +0100)]
[HICN-426] Add isRunning API to consumer and producer socket.
Change-Id: I5a144f804b87c3575f24c57ba5086136ec02efcd
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Jordan Augé [Mon, 2 Dec 2019 13:28:22 +0000 (14:28 +0100)]
[HICN-419] Expose facelet id in facelet_list(_json) in facemgr API
Change-Id: Ibce2e82ba125ca2e927cd270a8c45855384cd7fa
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Alberto Compagno [Mon, 2 Dec 2019 12:49:15 +0000 (12:49 +0000)]
Merge "[HICN-425] RTC min window"
Michele Papalini [Mon, 2 Dec 2019 09:59:23 +0000 (09:59 +0000)]
Merge "[HICN-423] Handle exception of producer socket thrown upon socket disposing."
michele papalini [Mon, 2 Dec 2019 09:56:34 +0000 (10:56 +0100)]
[HICN-425] RTC min window
Signed-off-by: michele papalini <micpapal@cisco.com>
Change-Id: Ieb41ffff61ed4341dc9aacb58d3e7c397e72fc41
Robot [Fri, 29 Nov 2019 18:07:06 +0000 (18:07 +0000)]
[HICN-424] linking missing vpp libraries to libsysrepohicn
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: I70c1b1162fd7b7a093d60e03b55dcd01f62250f3
Alberto Compagno [Fri, 29 Nov 2019 16:07:18 +0000 (16:07 +0000)]
Merge "[HICN-403] update vapi communication with vpp"
Mauro Sardara [Fri, 29 Nov 2019 15:34:11 +0000 (16:34 +0100)]
[HICN-423] Handle exception of producer socket thrown upon socket disposing.
Change-Id: I2458d054150ca307cf7ac0391f7698ebf2e7466e
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Masoud Hemmatpour [Tue, 26 Nov 2019 11:05:02 +0000 (12:05 +0100)]
[HICN-403] update vapi communication with vpp
Signed-off-by: Masoud Hemmatpour <mhemmatp@cisco.com>
Change-Id: I6e05d96af049229a6dc2da0adf32707873cdc816
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Alberto Compagno [Wed, 27 Nov 2019 16:57:02 +0000 (16:57 +0000)]
[HICN-417] Creation of multiple sockets calls only one connect to vpp
vlibmemoryclient provided by vpp does not handle calling connect
multiple times from the same application. Creation of multiple
sockets call connect only one. Destruction of all the sockets
call disconnet to vpp.
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: I70f22c256f4f45640f80aae3da68541504852192
Jordan Augé [Tue, 26 Nov 2019 23:52:50 +0000 (00:52 +0100)]
[HICN-416] Fix error handling in facemgr netlink interface
Change-Id: Ia04a2f01005ec28a92cc5065ee2f3bddad27f573
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Alberto Compagno [Tue, 26 Nov 2019 14:29:28 +0000 (14:29 +0000)]
[HICN-414] Added udp punting on src port, or dst ports, or both
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: I86fa8d76b22a90aa87c6623206022057ac9f30f1
Alberto Compagno [Tue, 19 Nov 2019 17:57:20 +0000 (17:57 +0000)]
[HICN-398] Added face create/delete/list and listener list on libctrl for hicn-plugin
Listener list returns the list of interfaces and their ip addresses
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: I2582cf29d4f1f60964766d47ad8d6dc64504fd62
Jordan Augé [Mon, 25 Nov 2019 10:24:15 +0000 (10:24 +0000)]
Merge "[HICN-408] add a face manager interface for face priority control"
Jordan Augé [Mon, 25 Nov 2019 10:20:32 +0000 (11:20 +0100)]
[HICN-408] add a face manager interface for face priority control
Change-Id: I07cd4c100251c42ef32117a515e8e9e39b9c3031
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Mauro Sardara [Mon, 25 Nov 2019 08:53:19 +0000 (08:53 +0000)]
Merge "[HICN-406] Adding face deletion on the hicn-plugin when the corresponding socket is destroyed"
Jordan Augé [Sun, 24 Nov 2019 22:51:45 +0000 (23:51 +0100)]
[HICN-408] Add a face manager interface for face priority control
Change-Id: I768112c920154380a614d0c5858f50efa135903d
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Sun, 24 Nov 2019 22:44:49 +0000 (22:44 +0000)]
Merge "[HICN-408] add a face manager interface for face priority control"
Mauro Sardara [Fri, 22 Nov 2019 14:53:57 +0000 (14:53 +0000)]
Merge "[HICN-413] rtc client improvements"
michele papalini [Fri, 22 Nov 2019 14:38:40 +0000 (15:38 +0100)]
[HICN-413] rtc client improvements
Signed-off-by: michele papalini <micpapal@cisco.com>
Change-Id: Ia23dee91776ccaa0bdf667eefc850e298f966cec
Alberto Compagno [Fri, 22 Nov 2019 14:22:41 +0000 (15:22 +0100)]
[HICN-412] Added option LINK_FLAGSgto build_executable to specify link flags
Change-Id: I6b382abe374d896c9ea1e0ef5573ba166fafec94
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Alberto Compagno [Fri, 22 Nov 2019 13:50:37 +0000 (13:50 +0000)]
Merge "[HICN-411] Change how manifests are requested"
Alberto Compagno [Thu, 21 Nov 2019 12:06:33 +0000 (12:06 +0000)]
[HICN-406] Adding face deletion on the hicn-plugin when the corresponding socket is destroyed
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: I09268dc5ae2ad465b4a4f68607732c0d3f48e62e
Alberto Compagno [Fri, 22 Nov 2019 13:09:58 +0000 (13:09 +0000)]
Merge "[HICN-405] Added application face delete"
Alberto Compagno [Thu, 21 Nov 2019 11:59:54 +0000 (11:59 +0000)]
[HICN-405] Added application face delete
Added two new messages in the binary api:
- hicn_api_face_cons_del to delete a consumer face
- hicn_api_face_prod_del to delete a producer face
Added the corresponding commands in the vpp_api_test for debugging and testing
Reworked the cache policy structure to add a new function that flash the content store
from the content coming from the destroyed producer face. This is required since the CS
while each producer face has its own lru list. Removing only the producer face without
flushing the CS from the content coming from the producer face will lead to a segfault
in case there is a hit in the CS as the lru no longer exists and it won't be possible
to update the head of the lru.
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: I8776c86952d50900aa504dd22aec521ed25c1dae
Olivier Roques [Thu, 21 Nov 2019 15:47:00 +0000 (15:47 +0000)]
[HICN-411] Change how manifests are requested
This patch introduces a new way of requesting manifests such that
all the segments they contain fill the current transport window.
When a manifest (M) is received, we compute
L = last_segment_requested + current_window_size.
L is therefore equal or greater than the last segment of the
current window.
Then we compare L to the suffix of the next manifest that will
be (potentially) requested.
If L > next_manifest, it means that the last segment of the window is
greater than the first segment contained in the next manifest.
Therefore we request manifests until L <= next_manifest, ie until the
manifests would cover the entire window.
If L <= next_manifest, then all the manifests that were requested
already cover the window, so there's no need to request more. However
if the next manifest immediately follows the current one (M), we still
need to request it so that the content suffix queue is correctly
updated.
Signed-off-by: Olivier Roques <olvrqs@gmail.com>
Change-Id: I71a5a0031cd783277d0aa59fd68d5d7bf64fe6ae
Alberto Compagno [Fri, 22 Nov 2019 11:55:46 +0000 (11:55 +0000)]
Merge "[HICN-394] Add route commands add, list, del for the hicn-plugin"
michele papalini [Fri, 22 Nov 2019 10:24:43 +0000 (11:24 +0100)]
[HICN-410] reduce sentinel timer aggressiveness
Signed-off-by: michele papalini <micpapal@cisco.com>
Change-Id: I538d8266912fea244505e4d2ceccef0dd9a242bc
michele papalini [Fri, 22 Nov 2019 08:50:31 +0000 (09:50 +0100)]
[HICN-409] remove race condition in rtc procuder socket
Signed-off-by: michele papalini <micpapal@cisco.com>
Change-Id: Ifdc5d912b8687bae3da78fadb05524d78e767f5a
Junsu Choi [Fri, 22 Nov 2019 02:15:56 +0000 (11:15 +0900)]
[HICN-408] add a face manager interface for face priority control
Change-Id: I166cb56e7376fe896d41d6d371ecb3727b7563ce
Signed-off-by: Junsu Choi <junsu.choi@samsung.com>
Alberto Compagno [Thu, 21 Nov 2019 09:28:55 +0000 (09:28 +0000)]
Merge "[HICN-402] Limit in-flight interests for manifests"
Jordan Augé [Wed, 20 Nov 2019 23:38:09 +0000 (00:38 +0100)]
[HICN-379] Add face priority support in face manager
Change-Id: Iae19e016aae833b4bc95ff6d91d51b188f398e25
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Wed, 20 Nov 2019 17:06:01 +0000 (18:06 +0100)]
[HICN-404] double-free in facemgr (facemgr_list_facelets_json) + valgrind fixes
Change-Id: Id57873d3f4152af654f3bc27778d7015495597d7
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Olivier Roques [Wed, 20 Nov 2019 13:53:12 +0000 (13:53 +0000)]
[HICN-402] Limit in-flight interests for manifests
Currently, interests for manifests are sent independently of the
transport protocol. When receiving a manifest, interests for next
manifests are sent until the next window would be full of data
segments.
But there is no limit on the number of interests for manifests that
can be sent. After a while, the interest input buffer in the
producer's side is full of them and cannot satisfy the requests
quickly enough. This results in a large drop of bandwidth on the
consumer side. This patch allows to limit the number of in-flight
interests for manifests.
Signed-off-by: Olivier Roques <olvrqs@gmail.com>
Change-Id: Ic497bd55fd92233e4b47b04635fb9bf75506375e
Alberto Compagno [Fri, 15 Nov 2019 08:58:23 +0000 (08:58 +0000)]
[HICN-394] Add route commands add, list, del for the hicn-plugin
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Change-Id: I41641f6d27babaa1c413ecf2fe6eae0e499df97d
Jordan Augé [Tue, 19 Nov 2019 22:47:37 +0000 (22:47 +0000)]
Merge "[HICN-400] fix NULL content name in PIT entry (temporary workaround)"
Jordan Augé [Tue, 19 Nov 2019 16:49:30 +0000 (17:49 +0100)]
[HICN-400] fix NULL content name in PIT entry (temporary workaround)
Change-Id: I6a1d93a4e6beb78741d8243fc78d6ecff77b9034
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Tue, 19 Nov 2019 16:44:06 +0000 (17:44 +0100)]
[HICN-399] facemgr crashes after wifi disabled
Change-Id: I8d504b1e83f79d028f2e7bbfacda2824076aa72f
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Alberto Compagno [Tue, 19 Nov 2019 08:16:29 +0000 (08:16 +0000)]
Merge "[HICN-397] Added punting add message for punting on udp ports"
Alberto Compagno [Mon, 18 Nov 2019 13:54:58 +0000 (13:54 +0000)]
Merge "[HICN-391] Supporting midchain as adjacencies for an ip face"
Alberto Compagno [Mon, 18 Nov 2019 13:52:25 +0000 (14:52 +0100)]
[HICN-397] Added punting add message for punting on udp ports
Change-Id: Ieb5faf5d01e460179028eaba92170ee95cf35edf
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Mauro Sardara [Mon, 18 Nov 2019 10:51:08 +0000 (10:51 +0000)]
Merge "[HICN-225] Added generic binary api for handling faces"
Alberto Compagno [Mon, 18 Nov 2019 10:27:06 +0000 (11:27 +0100)]
[HICN-391] Supporting midchain as adjacencies for an ip face
Michain support is important to get a netx hop in a face
whose locator is resolved in the fib through a via.
Change-Id: Id0ff1522cedd5a093f242499e310a24625a3852a
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Alberto Compagno [Sun, 17 Nov 2019 11:50:48 +0000 (12:50 +0100)]
[HICN-225] Added generic binary api for handling faces
Supported messages are add, del, get, dump, get.
Each message contains a face id and the expected message has different
fields based on the face type.
The binary api specific for ip faces is still available for compatibility
but deprecated.
Change-Id: I899c6cf31a56abd39ad287ea3128993857997fcb
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Jordan Augé [Mon, 18 Nov 2019 09:33:07 +0000 (10:33 +0100)]
[HICN-379] Add face priority support in face manager
Change-Id: I1055e49c93e81105996a77c088fafd4b55fdc337
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Sat, 16 Nov 2019 23:07:12 +0000 (00:07 +0100)]
[HICN-379] Add face priority support in face manager
Change-Id: If4f75d44fc66414a4a70135de7827f5082b97112
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Sun, 17 Nov 2019 09:53:22 +0000 (09:53 +0000)]
Merge "[HICN-395] Static face/route maintainance though face manager"
Jordan Augé [Tue, 5 Nov 2019 11:56:37 +0000 (12:56 +0100)]
[HICN-378] Add a maximum number of reattempts in face manager before entering face ignore mode
Change-Id: Id6f8cc958d3c50027475d72d80eed6b65ac0996b
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Mon, 11 Nov 2019 23:15:11 +0000 (00:15 +0100)]
[HICN-395] Static face/route maintainance though face manager
Change-Id: I8f2287a262412bacc50f3c89756ec9fd6ce30d33
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Sat, 16 Nov 2019 23:28:04 +0000 (00:28 +0100)]
[HICN-396] Incorrect error handling order in facemgr during interface creation causes double free
Change-Id: I63f3ac8815611fe83e75edd283eabf4d721bdbac
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Fri, 15 Nov 2019 16:06:50 +0000 (17:06 +0100)]
[HICN-386] Improve API error management in libhicnctrl
Change-Id: Ifab987a17255e20077242888b052e312f9e4c964
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Fri, 15 Nov 2019 14:32:40 +0000 (15:32 +0100)]
[HICN-386] Improve API error management in libhicnctrl
Change-Id: I3f5e3840303265ccc3d4b864d026b63a2ccb7fdf
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Fri, 15 Nov 2019 12:20:09 +0000 (12:20 +0000)]
Merge "[HICN-386] Improve API error management in libhicnctrl"
Jordan Augé [Mon, 11 Nov 2019 23:03:08 +0000 (00:03 +0100)]
[HICN-386] Improve API error management in libhicnctrl
Change-Id: I332e74ebcd89798c93de50ae7a20f7af8f59f54c
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Olivier Roques [Tue, 12 Nov 2019 09:51:34 +0000 (09:51 +0000)]
[HICN-393] Fix various issues related to manifests
The current manifest implementation is broken:
1. ManifestIndexingManager, responsible for validating manifests and
segments and retrieving the next ones, assumes that all manifests
have the same size. This assumption affects the retrieval of next
manifests which is based on the number of segments the current
manifest contains. Therefore when a non-full manifests arrives,
the computed suffix of the next manifest is wrong and refer to a
content instead, which results in an error.
2. Manifests are used to update a suffix queue which stores all
the segments listed in manifests. This queue is used to retrieve
content sequentially via a pointer indicating the next content to
fetch. When the pointer reaches the end of the suffix queue, the
consumer stops sending interests. The correct behavior would be to
wait for a new manifest which would update the queue.
This patch fixes these two issues:
1. Issue 1 was fixed by using SuffixManifest (HICN-392). This allows
to set the capacity of a manifest at the start of the consumption
instead of checking each time the size of the current manifest and
then using that (non-constant) value to retrieve the next manifests.
2. Issue 2 was fixed by passing to ManifestIndexingManager a reference
to an object capable of calling the scheduleNextInterest function,
which is then called after a new manifest is retrieved to make sure
interests for content kept being sent. This is not an optimal solution
but rather a temporary one, until the retrieval of manifests is done
at the transport level rather than in ManifestIndexingManager.
This patch also changes the order of production: manifests are now
sent before content. To do so, contents are added into a queue until
the manifest is complete.
Signed-off-by: Olivier Roques <olvrqs@gmail.com>
Change-Id: I1a1bb92ca1cf2d3c745c1b65f6c7376f916c679b
Alberto Compagno [Thu, 14 Nov 2019 09:30:23 +0000 (09:30 +0000)]
Merge "[HICN-392] Assign independent suffixes for manifests/contents"
mashemat [Wed, 13 Nov 2019 10:48:09 +0000 (11:48 +0100)]
[HICN-375] Move cmake in ctrl/sysrepo-plugins to the main cmke in root
Signed-off-by: mashemat <mhemmatp@cisco.com>
Change-Id: I6c2f65e61a2f13db8261a32482336b21f07d5e45
Olivier Roques [Thu, 7 Nov 2019 10:05:52 +0000 (10:05 +0000)]
[HICN-392] Assign independent suffixes for manifests/contents
This patch introduces a new class, SuffixStrategy and two sub-classes,
SuffixContent and SuffixManifest which allow to independently assign
suffixes to contents and manifests respectively. The produce() function
in socket_producer.cc has also been changed to use them.
Given a strategy and an offset (and optionally the capacity of a
manifest), these classes automatically compute the correct next
suffixes for both type of data (manifest or content). This removes
the burden of having to manage suffixes for instance when producing
or when retrieving content, and could be expanded to add more
strategy in the future.
Currently the only existing strategy is "INCREMENTAL": manifests
with capacity N have a suffix multiple of N+1: 0, N+1, 2(N+1) etc.
Contents have a suffix incremented by 1 except when it conflicts
with a manifest: 1, 2, ..., N, N+2, N+3, ..., 2N+1, 2N+3...
Signed-off-by: Olivier Roques <olvrqs@gmail.com>
Change-Id: Ia7692d7325240de7bea6e38b668077042e5f8758
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
Michele Papalini [Tue, 12 Nov 2019 13:19:55 +0000 (13:19 +0000)]
Merge "[HICN-376] Add manual connection/route setting to face manager"
Jordan Augé [Tue, 12 Nov 2019 11:56:40 +0000 (12:56 +0100)]
[HICN-389] facemgr calls unregister_all multiple times in case of error
Change-Id: Iaac34a53ae95b511594a5dcd6b1e614eba9ff135
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Tue, 5 Nov 2019 13:18:34 +0000 (14:18 +0100)]
[HICN-376] Add manual connection/route setting to face manager
Change-Id: I5c24f687e8e815d0e2f437ff8ce7fbb2c76e0579
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Mon, 11 Nov 2019 17:49:13 +0000 (17:49 +0000)]
Merge "[HICN-383] Code cleanup"
Jordan Augé [Thu, 7 Nov 2019 15:42:01 +0000 (16:42 +0100)]
[HICN-385] fix route removal in hicnctrl, code uniformization in hicn-light control api
Change-Id: Id097368dcde993775f206623195cc5aa57b4fe12
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Tue, 5 Nov 2019 16:25:37 +0000 (17:25 +0100)]
[HICN-383] Code cleanup
Change-Id: I41ca0f411053992625dec0b32ffe6a444c5bc51c
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Tue, 5 Nov 2019 15:55:27 +0000 (16:55 +0100)]
[HICN-382] Misc compilation issues on MacOS (incl. Catalina specific code)
Change-Id: I4cb2378b2e44afbaedb984409a221b2e3f0e99b4
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Jordan Augé [Tue, 5 Nov 2019 12:28:49 +0000 (12:28 +0000)]
Merge "[HICN-372] Code clean up"
Michele Papalini [Tue, 5 Nov 2019 10:11:40 +0000 (10:11 +0000)]
Merge "[HICN-380] add libhicnctrl example (create face)"
Jordan Augé [Tue, 5 Nov 2019 09:51:17 +0000 (10:51 +0100)]
[HICN-380] add libhicnctrl example (create face)
Change-Id: I230d4cc51710fa4ce7ce24c97cd72b1fc7d1f573
Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
Alberto Compagno [Thu, 22 Aug 2019 07:48:32 +0000 (09:48 +0200)]
[HICN-262] Fix binary api to prevent byteswapping of ip addresses in vapi
Change-Id: If3f9a7db1e1310fdc08d1003b28e5e1d4006b61e
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
masoud [Thu, 31 Oct 2019 17:07:18 +0000 (18:07 +0100)]
[HICN-357] sysrepo plugin update
Signed-off-by: masoud <mhemmatp@cisco.com>
Change-Id: Idabe9d3a3b03139ad3cdb20c8c822e6dd7d4c553
Alberto Compagno [Mon, 4 Nov 2019 08:04:36 +0000 (08:04 +0000)]
Merge "[HICN-356] Fix uninitialized pointer"
Mauro Sardara [Thu, 31 Oct 2019 16:26:54 +0000 (16:26 +0000)]
[HICN-371] Fix invalid read reported by Valgrind when many timeouts happen.
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Change-Id: Ib31e731c02341234169bd5163eb86fe1da900e40
Signed-off-by: Mauro Sardara <msardara@cisco.com>