vpp.git
4 months agoarmada: fix rxq buffer pool assignment 50/41750/3
Damjan Marion [Thu, 24 Oct 2024 09:40:13 +0000 (11:40 +0200)]
armada: fix rxq buffer pool assignment

Type: fix
Change-Id: I5a78804986f400f8adc7f58f25fe5d7989a926ea
Signed-off-by: Damjan Marion <damarion@cisco.com>
4 months agoip: fix port extraction 31/41731/4
Klement Sekera [Wed, 23 Oct 2024 17:05:17 +0000 (19:05 +0200)]
ip: fix port extraction

Replace a hard-coded constant of 64 with 56, which is a more appropriate
value for when ICMP echo request is returned in ICMP error. Previously,
the size of such message would be smaller than 64 and parsing would not
return the correct value.

Type: fix
Change-Id: I1bdf8a2a23b1e6762b64210c71927c926f4547ad
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
4 months agodev: use typedefs in dev.h 44/41744/2
Damjan Marion [Wed, 23 Oct 2024 19:36:50 +0000 (21:36 +0200)]
dev: use typedefs in dev.h

Type: refactor
Change-Id: Ieb50d79bd7b9f0a59faf26a4f5bce3f89f25b287
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
4 months agodev: keep dev_instance data in struct 42/41742/2
Damjan Marion [Wed, 23 Oct 2024 18:56:27 +0000 (20:56 +0200)]
dev: keep dev_instance data in struct

Type: refactor
Change-Id: I05d04e2e9872d025384524b1bc133d909581e18a
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
4 months agodev: fix typo in function name 41/41741/2
Damjan Marion [Wed, 23 Oct 2024 16:46:51 +0000 (18:46 +0200)]
dev: fix typo in function name

vnet_dev_get_port_rx_node_idex -> vnet_dev_get_port_rx_node_index

Type: fix
Change-Id: I9a90e5822cbc93bcf2f91244b4eb4e5fff53c212
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
4 months agodev: _with_ptr process node calls 40/41740/2
Damjan Marion [Wed, 23 Oct 2024 16:38:18 +0000 (18:38 +0200)]
dev: _with_ptr process node calls

Type: improvement
Change-Id: Ib392d74e7629cef5d335e4320a71ceec25ddb020
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
4 months agoarmada: port and queue counters 39/41739/2
Damjan Marion [Wed, 23 Oct 2024 13:35:49 +0000 (15:35 +0200)]
armada: port and queue counters

Type: improvement
Change-Id: I221253be147e99cd082911f28d088b64ca96eff5
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
4 months agodev: add more units for counters 38/41738/2
Damjan Marion [Wed, 23 Oct 2024 13:19:46 +0000 (15:19 +0200)]
dev: add more units for counters

Type: improvement
Change-Id: If6f70fc34f47c31a986ba837c9a35ce139decfb1
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
4 months agoarmada: fix typo 37/41737/2
Damjan Marion [Wed, 23 Oct 2024 13:34:41 +0000 (15:34 +0200)]
armada: fix typo

Type: fix
Change-Id: I1c1eb9d7426086bb8023867b3118ece119bca05b
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
4 months agodhcp: fix buffer length after adding new option 72/41272/2
Artem Glazychev [Wed, 17 Jul 2024 09:48:45 +0000 (16:48 +0700)]
dhcp: fix buffer length after adding new option

The size of dhcp option should be o.length + 2 additional bytes of the header.
Incorrect offset results in an extra byte at the end of the packet:
...
0120  04 00 00 00 04 05 04 AC 10 04 01 FF 00
...
RFC2131 says the last should be the 'end' option (ff)

Type: fix

Change-Id: I056d755d29465aab8c1c55a0b930f65ece6fafce
Signed-off-by: Artem Glazychev <glazychev@mts.ru>
4 months agoarmada: set prinary address support 20/41720/2
Damjan Marion [Thu, 17 Oct 2024 14:52:08 +0000 (16:52 +0200)]
armada: set prinary address support

Type: improvement
Change-Id: I280cb3961ff4b18c6e02053c7526c19570add09d
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
4 months agobuild: fix gcov failure on ubuntu 24.04 81/41481/4
Dave Wallace [Tue, 27 Aug 2024 00:55:49 +0000 (20:55 -0400)]
build: fix gcov failure on ubuntu 24.04

Type: make

Change-Id: Ieee6562de4b9f68d701c27a3c3018431b28eb3b0
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
4 months agovapi: fix mem leak on uds transport 86/41686/2
Stanislav Zaikin [Mon, 7 Oct 2024 16:28:42 +0000 (18:28 +0200)]
vapi: fix mem leak on uds transport

Type: fix

Change-Id: I08b990eb2ede3c26e0981de033daa4cc6bd1af8e
Signed-off-by: Stanislav Zaikin <stanislav.zaikin@46labs.com>
4 months agodocs: fix statseg title in config reference 65/41665/3
Lukas Vogel [Tue, 1 Oct 2024 06:32:36 +0000 (08:32 +0200)]
docs: fix statseg title in config reference

Fix typo and put it on the correct level.

Type: fix
Change-Id: Ic7a8e557b22d0060d7f072132f00564e29d8e860
Signed-off-by: Lukas Vogel <vogel@anapaya.net>
4 months agodocs: Add FreeBSD Quick Start to README.md 26/41726/2
Tom Jones [Fri, 18 Oct 2024 15:12:59 +0000 (15:12 +0000)]
docs: Add FreeBSD Quick Start to README.md

Type: docs
Change-Id: I5b69d6638721586f503cbb5d516b7b4d52e2f2d7
Signed-off-by: Tom Jones <thj@freebsd.org>
4 months agopg: fix the buffer leak when pa steams are deleted 45/41645/2
Mohsin Kazmi [Mon, 21 Oct 2024 16:54:27 +0000 (16:54 +0000)]
pg: fix the buffer leak when pa steams are deleted

Type: fix

vpp# sh buffers
Pool Name            Index NUMA  Size  Data Size  Total  Avail  Cached   Used
default-numa-0         0     0   2304     2048   128270 125968   1108    1194
default-numa-1         1     1   2304     2048   128270 128270     0       0
vpp# sh pa
Name               Enabled        Count     Parameters
pg0-test-0           No         60900431    limit -1, rate 1.00e6 pps, size 64-64, buffer-size 2048, worker 0,
pg1-test-0           No         60900385    limit -1, rate 1.00e6 pps, size 64-64, buffer-size 2048, worker 0,
pg0-test-1           No         60898008    limit -1, rate 1.00e6 pps, size 64-64, buffer-size 2048, worker 1,
pg1-test-1           No         60897934    limit -1, rate 1.00e6 pps, size 64-64, buffer-size 2048, worker 1,
pg0-test-2           No         60900278    limit -1, rate 1.00e6 pps, size 64-64, buffer-size 2048, worker 2,
pg1-test-2           No         60900184    limit -1, rate 1.00e6 pps, size 64-64, buffer-size 2048, worker 2,
pg0-test-3           No         60900431    limit -1, rate 1.00e6 pps, size 64-64, buffer-size 2048, worker 3,
pg1-test-3           No         60900387    limit -1, rate 1.00e6 pps, size 64-64, buffer-size 2048, worker 3
vpp# pa delete pg0-test-0
vpp# pa delete pg0-test-1
vpp# pa delete pg0-test-2
vpp# pa delete pg0-test-3
vpp# pa delete pg1-test-0
vpp# pa delete pg1-test-1
vpp# pa delete pg1-test-2
vpp# pa delete pg1-test-3
vpp# sh buffer trace verbose
Pool Name            Index NUMA  Size  Data Size  Total  Avail  Cached   Used
default-numa-0         0     0   2304     2048   128270 126650   1620      0
default-numa-1         1     1   2304     2048   128270 128270     0       0

                          Node           Allocated               Freed                  In                 Out            Buffered
            unix-cli-process-0                   0                1194                   0                   0               -1194

Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: I03051a8f529df7801cf08f8374a994dbc00fc972

4 months agodpdk: validate number of tx descriptors 07/41607/2
Matthew Smith [Wed, 25 Sep 2024 16:26:58 +0000 (11:26 -0500)]
dpdk: validate number of tx descriptors

The default number of tx descriptors per queue is 1024. On some device
types, this is larger than the maximum allowed value and
rte_eth_tx_queue_setup() can return an error. Compare the configured
value to the maximum value for each device and set the configured
value to the maximum value if the configured value is larger.

Type: improvement

Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Change-Id: Ie29c5c6d58c76388f65f266032821140b0f879fb

4 months agotests: remove tag_fixme_ubuntu2204 01/41701/3
Ivan Ivanets [Thu, 10 Oct 2024 13:51:03 +0000 (16:51 +0300)]
tests: remove tag_fixme_ubuntu2204

Type: test

Activate tests that works successfully on ubuntu 22.04 but were
problematic on later version and were excluded by
@tag_fixme_ubuntu2204

Change-Id: I93c4626a120ce8b475e9c5ca933a5544d6337933
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>
4 months agohsa: refactor proxy to minimize lock usage 23/41723/8
Florin Coras [Fri, 18 Oct 2024 07:46:57 +0000 (00:46 -0700)]
hsa: refactor proxy to minimize lock usage

Use per worker context to minimize proxy session lock usage for io
events.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia0ea204a8b09f72300fd40745b299246d5d0ddb7

4 months agocrypto-native: adding missing ciphers 16/41716/3
Jerome Tollet [Thu, 17 Oct 2024 06:07:56 +0000 (08:07 +0200)]
crypto-native: adding missing ciphers

Type: docs

Change-Id: I23a15e1ecd4c41f6567299aa07bb5458d468acf8
Signed-off-by: Jerome Tollet <jtollet@cisco.com>
4 months agoocteon: add crypto framework 48/40548/13
Nithinsen Kaithakadan [Fri, 16 Feb 2024 06:28:04 +0000 (11:58 +0530)]
octeon: add crypto framework

Configure crypto device.
Add crypto support in control plane and data plane.
Control plane
 - Handle vnet crypto key add and delete
 - Register crypto async enqueue and dequeue handlers
Data plane
 - Add encryption and decryption support for
    - AES-GCM
    - AES-CBC hmac sha1/256/384/512
    - AES-CTR sha1
    - 3DES-CBC md5 sha1/256/384/512

Type: feature

Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com>
Signed-off-by: Monendra Singh Kushwaha <kmonendra@marvell.com>
Change-Id: Ia9e16c61ed84800a59e0c932a4ba6aa1423c1ec8

4 months agobfd: add support for multihop 24/41524/13
Abdel Baig [Tue, 3 Sep 2024 15:52:20 +0000 (11:52 -0400)]
bfd: add support for multihop

Type: feature

Change-Id: If23f9cc9317e7528f3c8d66303457206843a12c5
Signed-off-by: Abdel Baig <abdbaig@cisco.com>
4 months agohs-test: various improvements 44/41644/3
Adrian Villin [Tue, 15 Oct 2024 12:56:16 +0000 (14:56 +0200)]
hs-test: various improvements

- fixed timed out/panicked tests not copying logs to CI archives
- fixed log formatting
- renamed SuiteTimeout to TestTimeout
- fixed ginkgo node leak on test timeout -> added AssertChannelClosed
- updated docs

Type: test

Change-Id: Ia71d765bd61576230a4cfd26d4b14fd1be1692c7
Signed-off-by: Adrian Villin <avillin@cisco.com>
4 months agohsa: switch proxy to using first worker connects 08/41708/2
Florin Coras [Tue, 15 Oct 2024 02:43:42 +0000 (19:43 -0700)]
hsa: switch proxy to using first worker connects

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I04821236ba8ab02525bd99a1ed4572dfcf5e5131

4 months agohttp: Content-Length value parsing improvement 92/41692/3
Matus Fabian [Tue, 8 Oct 2024 18:06:32 +0000 (20:06 +0200)]
http: Content-Length value parsing improvement

Type: improvement

Change-Id: Ida8ca43b5fed41fc0b13a2dde97e7e35c55283c9
Signed-off-by: Matus Fabian <matfabia@cisco.com>
4 months agovppinfra: fix page stats for large heaps 07/41707/2
Damjan Marion [Mon, 14 Oct 2024 15:43:04 +0000 (17:43 +0200)]
vppinfra: fix page stats for large heaps

Type: fix
Fixes: 6bfd076
Change-Id: I8da83a8a755e5893da627c0555039c62975a5e84
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
4 months agohs-test: http_static wrk tests 90/41690/2
Matus Fabian [Tue, 8 Oct 2024 11:58:37 +0000 (13:58 +0200)]
hs-test: http_static wrk tests

Type: test

Change-Id: I87cddb88f2a62e79d66832827134ddaa95740839
Signed-off-by: Matus Fabian <matfabia@cisco.com>
4 months agohttp: timer pool assert crash fix 77/41677/3
Matus Fabian [Fri, 4 Oct 2024 12:35:26 +0000 (14:35 +0200)]
http: timer pool assert crash fix

Two iterations over expiret timers:
1) ivalidate timer handle and mark the connection as having a pending
   timer
2) send RPCs to workers

Type: fix

Change-Id: Iadc031c4e6d6f7bbd851d0421e6e0ea2d2b5e70f
Signed-off-by: Matus Fabian <matfabia@cisco.com>
4 months agohttp: track half-open sessions 04/41704/2
Matus Fabian [Wed, 9 Oct 2024 18:30:41 +0000 (20:30 +0200)]
http: track half-open sessions

It might happen that app detach during connecting period and worker
is not valid anymore when http_ts_connected_callback is called.

Type: improvement

Change-Id: I95f094e8bc0352728a61e3fe74ab0745859e2457
Signed-off-by: Matus Fabian <matfabia@cisco.com>
4 months agoip: fix ip_local_reassembly_get handler 06/41706/2
Stanislav Zaikin [Mon, 14 Oct 2024 10:42:44 +0000 (12:42 +0200)]
ip: fix ip_local_reassembly_get handler

Type: fix
Signed-off-by: Stanislav Zaikin <stanislav.zaikin@46labs.com>
Change-Id: I6431557d01756174005df26350c28299f83fcee0

5 months agosnort: add timestamps to packets 00/41700/2
Alexander Skorichenko [Tue, 8 Oct 2024 09:38:07 +0000 (11:38 +0200)]
snort: add timestamps to packets

Type: improvement

Change-Id: I810679c8a73c4d1b3fc2cc2300ded46a30d68e8f
Signed-off-by: Alexander Skorichenko <askorichenko@netgate.com>
5 months agohs-test: added dry run mode 34/41434/13
Adrian Villin [Wed, 25 Sep 2024 12:49:11 +0000 (14:49 +0200)]
hs-test: added dry run mode

- DRYRUN=true will set up most containers. Some need to be started
  manually (curl, nginx...). The framework will create a vpp-config
  file with interface configs that will get executed on VPP startup.
- set Ginkgo to use -v instead of -vv when running a single test
- s.Log() now supports formatting
- added 'useEnvVars' parameter to container.Exec

Type: test

Change-Id: Id1da7947a1448ee4b74b86cc4f243442256a5ba8
Signed-off-by: Adrian Villin <avillin@cisco.com>
5 months agodpdk: xstats as symlinks 68/41168/10
Ole Troan [Thu, 20 Jun 2024 20:33:19 +0000 (22:33 +0200)]
dpdk: xstats as symlinks

Type: improvement
Change-Id: I0df26e5a4d486b694ec90ba27b485a75bf264b20
Signed-off-by: Ole Troan <otroan@employees.org>
5 months agohs-test: support running multiple specific tests 41/41641/1
Adrian Villin [Wed, 9 Oct 2024 09:03:35 +0000 (11:03 +0200)]
hs-test: support running multiple specific tests

- make test TEST=[test1],[test2] runs those two tests in random order

Type: test

Change-Id: I1a1af7c99ef7867ca94cec4175605f428dcd58fd
Signed-off-by: Adrian Villin <avillin@cisco.com>
5 months agovppinfra: devicetree improvements 93/41693/3
Damjan Marion [Tue, 8 Oct 2024 18:47:38 +0000 (20:47 +0200)]
vppinfra: devicetree improvements

Type: improvement
Change-Id: If20ae74658702399f626b1af7bd3519e05a5d422
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 months agodev: add helper functions 95/41695/2
Damjan Marion [Tue, 8 Oct 2024 21:14:49 +0000 (23:14 +0200)]
dev: add helper functions

Type: improvement
Change-Id: I7c9e882b1cdf141b34e84dbfed46b392624d1f62
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 months agoarmada: fix tx queue init 96/41696/1
Damjan Marion [Tue, 8 Oct 2024 21:51:28 +0000 (23:51 +0200)]
armada: fix tx queue init

Type: fix
Fixes: 4e51841
Change-Id: Ife3cb43f54cc0700c469f89b0a5af0ff44143807
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 months agopg: fix the coverity warning 39/41639/3
Mohsin Kazmi [Mon, 7 Oct 2024 21:53:04 +0000 (21:53 +0000)]
pg: fix the coverity warning

Type: fix

Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: Ida88c304f110b05051211ce243fd04ce811a9d4d

5 months agohttp_static: fix first and add segment size 88/41688/5
Florin Coras [Mon, 7 Oct 2024 19:32:22 +0000 (12:32 -0700)]
http_static: fix first and add segment size

Allow segments bigger than 4GB

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I510f7cff75883fdbd6c0c22efff9a14e26c755f4

5 months agohsa: cannot delete/unlisten default uri 89/41689/1
Steven Luong [Mon, 7 Oct 2024 19:02:45 +0000 (12:02 -0700)]
hsa: cannot delete/unlisten default uri

Although it is rare that one wants to remove the default uri listener,
we should still support it.

The problem is that we strip the null character on unformatting the input.
We should not add a null character on formatting the default uri.

Type: fix

Change-Id: I08520dbd2a2448639ce023f9fd75555bc620e7ee
Signed-off-by: Steven Luong <sluong@cisco.com>
5 months agohs-test: force test failure when vpp core present 83/41683/2
Matus Fabian [Mon, 7 Oct 2024 10:56:32 +0000 (12:56 +0200)]
hs-test: force test failure when vpp core present

Type: test

Change-Id: I874ee185a51dda9b620f3b783e466b8e88600d18
Signed-off-by: Matus Fabian <matfabia@cisco.com>
5 months agoip: add extended shallow reassembly 39/40839/8
Klement Sekera [Fri, 19 Apr 2024 07:15:01 +0000 (09:15 +0200)]
ip: add extended shallow reassembly

This patch adds some fixes and improvements:

Fixes bug where save_rewrite_length gets overwritten on reassembly
handoff.

Fixes bug where duplicate fragments could cause a reassembly context
to be lost, because the race losing thread would remove bihash entry
created by winning thread.

Improves tracing by adding more events.

Adds extended shallow reassembly. This is a toggleable option, which if
turned on will cause reassembly to wait for both first and last
fragments to calculate total IP payload length. Furthermore it'll store
a local copy of first fragment and necessary data to retrieve it in
vnet_buffer2. This allows downstream features to access full L3/L4
headers when dealing with fragments.

Type: fix
Change-Id: I81695070533410c5815291dbc65ea71c87e3ae05
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
5 months agoip: fix feature logic 84/41684/2
Klement Sekera [Mon, 7 Oct 2024 11:05:12 +0000 (13:05 +0200)]
ip: fix feature logic

This fixes ip6 feature logic, so error and handoff packets are no longer
sent to next feature instead of being dropped/handed off.

Type: fix
Change-Id: If280de5345d9ed3b553dd3b3fa40274619d333ae
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
5 months agoip: add ip6 shallow reassembly output feature 38/40838/6
Klement Sekera [Sat, 13 Apr 2024 09:04:23 +0000 (11:04 +0200)]
ip: add ip6 shallow reassembly output feature

Type: improvement
Change-Id: I0cb4014f03abdd0e55d4bb7ff40ae293a6ed3562
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
5 months agovapi: don't store dict in length field 47/40547/3
Klement Sekera [Tue, 19 Mar 2024 10:06:59 +0000 (11:06 +0100)]
vapi: don't store dict in length field

Rather validate the format and use proper Field call.

Type: fix
Fixes: d7a32ebd9948ff37c15d8b6e0e5d9cf243026239
Change-Id: I78ac1e62911d613dc0d7a9bd6e8784fbe7f0a797
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
5 months agoip: fix ip4 shallow reassembly output feature handoff 37/40837/5
Klement Sekera [Sat, 13 Apr 2024 09:03:49 +0000 (11:03 +0200)]
ip: fix ip4 shallow reassembly output feature handoff

Use a new frame queue for output feature instead of passing frames
to standard feature.

Fixes bug where save_rewrite_length gets overwritten on reassembly
handoff.

Type: fix
Change-Id: I6c6191aec5f1c89e1ca0510a08781e390d327bbf
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
5 months agopg: add support to delete pg interface 38/41638/4
Mohsin Kazmi [Thu, 3 Oct 2024 23:18:17 +0000 (23:18 +0000)]
pg: add support to delete pg interface

Type: improvement

Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Change-Id: I3102fded415c644673fb79a0fdb7a7448ce20f26

5 months agosession vcl: add support for vcl transport attributes 73/41673/6
Florin Coras [Thu, 3 Oct 2024 07:34:03 +0000 (00:34 -0700)]
session vcl: add support for vcl transport attributes

Session layer can push transport attributes to vcl sessions which are
stored as vector for session lifetime.

Store original_dst_ip and port when available in vcl session attribute
vector.

Type: feature

Change-Id: Iab6c65ddcfed220fc919f564cd19083561812faf
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 months agohs-test: fix core_pattern volume mounts 76/41676/2
Florin Coras [Fri, 4 Oct 2024 05:06:02 +0000 (01:06 -0400)]
hs-test: fix core_pattern volume mounts

If system is configured to use something like apport, avoid mounting.

Type: fix

Change-Id: I6af900bd334acba974c9c4ae30c3b2ce26d1f49b
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 months agosession: use proper name for ct transport 75/41675/1
Florin Coras [Thu, 3 Oct 2024 20:54:05 +0000 (13:54 -0700)]
session: use proper name for ct transport

Type: refactor

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iebf5155a429c77143df9eb44f504fea28cddaf98

5 months agohs-test: prom consecutive connections test 71/41671/3
Matus Fabian [Wed, 2 Oct 2024 07:00:19 +0000 (09:00 +0200)]
hs-test: prom consecutive connections test

Type: test
Change-Id: Ide4571dd8ac9bcb64fcd5ba408b6d1f99d34185f
Signed-off-by: Matus Fabian <matfabia@cisco.com>
5 months agohs-test: added nginx multi-thread tests 31/41431/9
Adrian Villin [Thu, 19 Sep 2024 15:19:39 +0000 (17:19 +0200)]
hs-test: added nginx multi-thread tests

- added Dockerfile.envoy
- removed nginx vcl.conf file as it's created by
  the framework now

Type: test

Change-Id: I5f2be015c864c8d2aa938a22b1abece64989999b
Signed-off-by: Adrian Villin <avillin@cisco.com>
5 months agosession: allow session input rpcs 74/41674/3
Florin Coras [Thu, 3 Oct 2024 08:19:24 +0000 (01:19 -0700)]
session: allow session input rpcs

Type: improvement

Change-Id: Ib8e9f9fb6dfc553cc9e344544961832fecbea8c1
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 months agohs-test: use nginx 1.26.2 for NginxHttp3Test 37/41637/3
Adrian Villin [Wed, 2 Oct 2024 13:07:40 +0000 (15:07 +0200)]
hs-test: use nginx 1.26.2 for NginxHttp3Test

- test is no longer marked as extended
- no building required -> removed nginx build scripts

Type: test

Change-Id: I1814b1e4b7e514f81797efa3b5c1e818d2fe4cda
Signed-off-by: Adrian Villin <avillin@cisco.com>
5 months agosession: incomprehensible error message for adding sdl and rule-table entry 72/41672/1
Steven Luong [Wed, 2 Oct 2024 16:35:33 +0000 (09:35 -0700)]
session: incomprehensible error message for adding sdl and rule-table entry

1. When the backend engine is not enable, adding an entry returns
a confusing error message.

DBGvpp# session sdl add 191.1.1.30/32 action 1 tag blue-v4-rule1
session sdl add 191.1.1.30/32 action 1 tag blue-v4-rule1
unknown input `add  191.1.1.30/32 action 1 ta...'
DBGvpp#

2. When the sdl or rule-table entry is already present, adding the duplicate
entry returns a confusing error message.

DBGvpp# session sdl add  8.8.8.1/32 action 0
session sdl add  8.8.8.1/32 action 0
DBGvpp# session sdl add  8.8.8.1/32 action 0
session sdl add  8.8.8.1/32 action 0
session: session is already enable. Must disable first
DBGvpp#

The problem is because there are multiple cli commands start with "session".
When the command is failed with the best match chain, it passes the
command to the other parser chains which start with the keyword "session".
The other cli chain also fails to parse the command. The error message
that the previous parser chain returned may be overwritten by
the newest error message.

The fix is to not return an error in sdl and rule-table parser command chain.

Type: fix

Change-Id: If0165324a763f47ec98ab79a41c3ee9b10057454
Signed-off-by: Steven Luong <sluong@cisco.com>
5 months agobuild: fix dpdk mellanox driver build setting 61/41661/2
Dave Wallace [Tue, 1 Oct 2024 01:00:13 +0000 (21:00 -0400)]
build: fix dpdk mellanox driver build setting

- dpdk mellanox driver setting requires rdma-core.mk is included
  before dpdk.mk makefile.  Include check for rdma-core_version
  variable definition in dpdk.mk to prevent a re-occurance of this
  issue.

Type: fix
Fixes: 70522a1dc

Change-Id: I297cbd734ac7abe970eac7fb317d06b7acfc5a40
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
5 months agotests: fix wireguard test case failures 09/41609/5
Ivan Ivanets [Fri, 27 Sep 2024 14:11:18 +0000 (17:11 +0300)]
tests: fix wireguard test case failures

Type: test

There are random failures in the wireguard test cases that are not related to concurrency issues.
The root cause is a retry of the handshake initiation after (REKEY_TIMEOUT + JITTER) ms, where JITTER is a random value between 0 and 333 ms.

Solution: Add a filter parameter for the `send_and_expect` method of the vpptestcase.
This filter allows for excluding unexpected handshake initiation packets when the responder sends two packets (with `message_type = 1` and `message_type = 2`),while only a single packet (with `message_type = 2`) is expected.

Change-Id: I62816931fc1b85e2202f3d36eb6c2a23714644d5
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>
5 months agohttp: http_state_wait_server_reply fix 12/41612/1
Matus Fabian [Mon, 30 Sep 2024 11:52:12 +0000 (13:52 +0200)]
http: http_state_wait_server_reply fix

We enqueue 2 segments to app, first is masg (http_msg_t) and second
as much as possible of the raw data, so it must be:
max_enq - sizeof (msg)

Type: fix

Change-Id: Ib7ece7e0ad1aac99d687d49149f1bccea599b10f
Signed-off-by: Matus Fabian <matfabia@cisco.com>
5 months agohs-test: replaced gofmt with goimports 36/41636/2
Adrian Villin [Thu, 26 Sep 2024 09:24:34 +0000 (11:24 +0200)]
hs-test: replaced gofmt with goimports

- goimports properly formats imports

Type: test

Change-Id: I78c162dd552fd3ee3d59955d7ea215af30601425
Signed-off-by: Adrian Villin <avillin@cisco.com>
5 months agosession: fix SDL to use remote instead local 10/41610/4
Steven Luong [Fri, 27 Sep 2024 15:35:45 +0000 (08:35 -0700)]
session: fix SDL to use remote instead local

The language is
local == VPP local interface
remote == sender prefix to VPP node
SDL acts on remote prefix.

Type: fix

Change-Id: I82917c6ef801fc67430dfdd15c5630cb7a6347e0
Signed-off-by: Steven Luong <sluong@cisco.com>
5 months agohsa: Add multiple listeners support 96/41596/3
Steven Luong [Tue, 24 Sep 2024 23:17:00 +0000 (16:17 -0700)]
hsa: Add multiple listeners support

It is desirable that http cli server can support multiple listeners.
This is needed for supporting both ip4 and ip6 at the same time.

Added the optional keyword listener add | del to the
http cli server command.

Example usage:  start ip4 default uri and then add ip6 uri
http cli server
http cli server uri http://2001::2/80 listener add

Type: improvement

Change-Id: I884a4cd64ff676f9759a062b6d607a1742f610f3
Signed-off-by: Steven Luong <sluong@cisco.com>
5 months agosnort: API functions for plugin 67/41567/15
Alexander Skorichenko [Thu, 12 Sep 2024 07:32:46 +0000 (09:32 +0200)]
snort: API functions for plugin

Also, made disconnect-instance and delete-instance functions
available via cli.

Type: feature

Change-Id: I7939d27867959cb871b1cc7205b94410b53906fd
Signed-off-by: Alexander Skorichenko <askorichenko@netgate.com>
5 months agotls: cleanup engine hs cb and improve ctx formatting 87/39687/6
Florin Coras [Tue, 17 Oct 2023 18:59:49 +0000 (11:59 -0700)]
tls: cleanup engine hs cb and improve ctx formatting

Handshake completion is now tracked via a ctx flag so we no longer need
ctx_handshake_is_over.

Also, as we no longer prealloc application sessions, improve ctx state
formatting.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If48588ecde13e56fb99d1a46238bda53ed4eae1b

5 months agodev: dev process node scheduling improvements 02/41602/2
Damjan Marion [Wed, 25 Sep 2024 13:54:07 +0000 (15:54 +0200)]
dev: dev process node scheduling improvements

Type: improvement
Change-Id: If39e4d2b46820d5c0465fcc40d255fa95d137d38
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 months agovlib: process node scheduler rework 60/41560/10
Damjan Marion [Tue, 10 Sep 2024 15:07:49 +0000 (17:07 +0200)]
vlib: process node scheduler rework

This commit allow use od cooperative multitasking with multiple
descheduling reasons (i.e. event wait and suspend) inside the same
process node. In previus code remote node will wake up process node
by sending event evein if process node is waiting in
vlib_process_ssupend().

This change also allowed new vlib_process_yield() API which deschedules
current process and it puts it into the end of queue.

Change-Id: I846e5a99b4ea1809eb80895f6ffe0ef0b2fd21ae
Type: improvement
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 months agoocteon: fix pause flow control for lbk/sdp devices 98/41598/3
Alok Mishra [Tue, 24 Sep 2024 15:54:37 +0000 (20:54 +0500)]
octeon: fix pause flow control for lbk/sdp devices

Pause frame flow control is not supported for LBK (Loopback) and
SDP (System DPI Packet Interface Unit) devices.
This patch skips the pause flow configuration for these devices.

Type: fix
Fixes: 53239b4

Signed-off-by: Alok Mishra <almishra@marvell.com>
Change-Id: I3096fcef9df4ad59d64bfabb83f91f13813128a8

5 months agovppinfra: add CLIB_SWAP() 01/41601/2
Damjan Marion [Wed, 25 Sep 2024 13:52:16 +0000 (15:52 +0200)]
vppinfra: add CLIB_SWAP()

Type: improvement
Change-Id: I1911a9d6a0ca8e1d24ce7b95281886392081ffc6
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 months agosession: set dgram mss when not constrained by transport 97/41597/3
Florin Coras [Wed, 25 Sep 2024 06:37:40 +0000 (23:37 -0700)]
session: set dgram mss when not constrained by transport

Type: fix

Change-Id: I12ddcd56f2fecb504180cdc044a3b3c3d1db7e3c
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 months agobuild: add missing fib_walk.h to VNET_HEADERS 04/41504/2
Radislav Chugunov [Mon, 2 Sep 2024 07:47:09 +0000 (10:47 +0300)]
build: add missing fib_walk.h to VNET_HEADERS

Type: fix

Change-Id: Ie64ce16ea512b855a1b886eceb94c0e6ba33df05
Signed-off-by: Radislav Chugunov <chgnrdv@gmail.com>
5 months agodpdk: add new device ID for Cisco VIC VF 47/41547/3
Hyong Youb Kim [Tue, 6 Aug 2024 04:50:39 +0000 (21:50 -0700)]
dpdk: add new device ID for Cisco VIC VF

VIC now supports standard SR-IOV, as opposed to VM-FEX SR-IOV. It uses
a new device ID 0x02b7 for VF. Add it to the supported list.

Type: improvement
Change-Id: Ifc91c66f5e75dd005aa9d8a47700896a941abab5
Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
5 months agodpdk: Enable dpdk build on FreeBSD 54/41354/4
Tom Jones [Thu, 1 Feb 2024 16:10:44 +0000 (16:10 +0000)]
dpdk: Enable dpdk build on FreeBSD

Type: improvement
Change-Id: If897f3bdfc131f8d7c01718057b54087eff02d7a
Signed-off-by: Tom Jones <thj@freebsd.org>
5 months agovppinfra: exclude clib_dt_node_add_child on FreeBSD 64/41564/4
Tom Jones [Wed, 11 Sep 2024 15:42:32 +0000 (15:42 +0000)]
vppinfra: exclude clib_dt_node_add_child on FreeBSD

clib_dt_read_from_sysfs is the only user of clib_dt_node_add_child, on
FreeBSD this causes a build failure due to an unused function. Place
clib_dt_node_add_child behind an include guard for linux only.

Type: fix
Change-Id: I9641ffd10d9d15e1e552f570cd386211d3b4ab39
Signed-off-by: Tom Jones <thj@freebsd.org>
5 months agoocteon: enable h/w vlan tagging support 32/41532/2
Alok Mishra [Mon, 2 Sep 2024 13:28:21 +0000 (18:28 +0500)]
octeon: enable h/w vlan tagging support

This patch enables h/w vlan tagging by setting MAX_VTAG_INS
field in NIX_AF_SMQ_CFG register.
This is required to configure VLAN tag insertion
by the hardware for egress packets

Type: feature

Signed-off-by: Alok Mishra <almishra@marvell.com>
Change-Id: Ifcdf9c1e5b0b8ddc27cabab597ae91780ceca095

5 months agomisc: Initial 25.02-rc0 commit 32/41432/2 v25.02-rc0
Andrew Yourtchenko [Wed, 25 Sep 2024 09:54:37 +0000 (11:54 +0200)]
misc: Initial 25.02-rc0 commit

Type: docs
Change-Id: Ic8f0204752b93339203fe9ba04fdb77ba635e6d8
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 months agoipsec: cleanup tun protect on interface removal 46/41546/5
Stanislav Zaikin [Mon, 9 Sep 2024 13:00:33 +0000 (15:00 +0200)]
ipsec: cleanup tun protect on interface removal

when a protected tunnel gets deleted it's necessary to run a proper
cleanup

Type: fix

Change-Id: I9d2c60ecbf97c4df299ac5c2228b036bf3478a56
Signed-off-by: Stanislav Zaikin <stanislav.zaikin@46labs.com>
5 months agoocteon: enable ethernet pause frame support 87/41587/5
Alok Mishra [Fri, 9 Aug 2024 08:29:24 +0000 (13:29 +0500)]
octeon: enable ethernet pause frame support

This patch adds support for MAC pause flow control.
By default, pause flow control is enabled in the device
configuration.

Type: feature

Signed-off-by: Alok Mishra <almishra@marvell.com>
Change-Id: I0f448479a38fae615d87af7e736c6053ada89cca

5 months agoocteon: fix error handling for packet with error 89/41589/2
Monendra Singh Kushwaha [Fri, 20 Sep 2024 15:03:38 +0000 (20:33 +0530)]
octeon: fix error handling for packet with error

Type: fix

Change-Id: Ieb97f1526939bcd732c155d3a7535dca71971258
Signed-off-by: Monendra Singh Kushwaha <kmonendra@marvell.com>
5 months agoocteon: fix SDP device link information 95/41595/2
Monendra Singh Kushwaha [Mon, 23 Sep 2024 09:40:10 +0000 (15:10 +0530)]
octeon: fix SDP device link information

This patch fixes SDP (System DPI Packet Interface Unit)
device link information.

Type: fix

Change-Id: I4563094601d9bb24132e4dc712cde14daa7f4364
Signed-off-by: Monendra Singh Kushwaha <kmonendra@marvell.com>
5 months agohttp_static: fix memory hss_session using after be freed 93/41593/1
XiaomingJiang [Mon, 23 Sep 2024 08:42:40 +0000 (16:42 +0800)]
http_static: fix memory hss_session using after be freed

Type: fix

Change-Id: Ic3d3de4198310361de876a8224e4f7cd0b48b698
Signed-off-by: XiaomingJiang <jiangxiaoming@outlook.com>
5 months agobuild: archive make install-ext-deps build logs in ci 74/41574/2
Dave Wallace [Fri, 13 Sep 2024 18:29:24 +0000 (14:29 -0400)]
build: archive make install-ext-deps build logs in ci

- also add build/external artifacts to .gitignore file

Type: make

Change-Id: I9c8f4a312bbfddfa8024531e7246518c8c3589a4
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
5 months agoudp: node counter for connected sessions 90/41590/2
Florin Coras [Fri, 20 Sep 2024 16:40:57 +0000 (09:40 -0700)]
udp: node counter for connected sessions

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I4c0c1b27adb3e3ea3c3ff6353b068447db19fa85

5 months agohs-test: proxy testing improvements 86/41586/2
Matus Fabian [Fri, 20 Sep 2024 11:25:39 +0000 (13:25 +0200)]
hs-test: proxy testing improvements

- nginx and curl timeouts are extended if debug flag is set
- added write-out for curl (outputs extra info after transfer is done)

Type: test

Change-Id: I3f6c336a14cd00b9ae8669d2fa26e00709162100
Signed-off-by: Matus Fabian <matfabia@cisco.com>
5 months agohs-test: debugging utility methods 85/41585/1
Matus Fabian [Fri, 20 Sep 2024 08:44:08 +0000 (10:44 +0200)]
hs-test: debugging utility methods

Type: test

Change-Id: I0c7e8424e53f1ad1896cd8439027e6081ccfeb28
Signed-off-by: Matus Fabian <matfabia@cisco.com>
5 months agopvti: remove clib_warning at init time 30/41430/3
Andrew Yourtchenko [Thu, 19 Sep 2024 11:29:54 +0000 (13:29 +0200)]
pvti: remove clib_warning at init time

Type: fix
Change-Id: I62ccd96ea3549205510ff53118eab1fa3613d009
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 months agol2: fix DVR test failure on AWS Graviton on Ubuntu 22.04 29/41429/8
Andrew Yourtchenko [Tue, 17 Sep 2024 13:01:44 +0000 (15:01 +0200)]
l2: fix DVR test failure on AWS Graviton on Ubuntu 22.04

The AWS Graviton make test fails in dvr_test.py on Ubuntu 22.04,
due to a mismatching source MAC address. Debian 11 tests run fine.

The following can be seen in the log.txt trace:

00:00:00:756422: ethernet-input
  frame: flags 0x1, hw-if-index 3, sw-if-index 3
  IP4: 02:03:00:00:ff:02 -> de:ad:00:00:00:00 802.1q vlan 92
00:00:00:756435: l2-input
  l2-input: sw_if_index 6 dst de:ad:00:00:00:00 src 02:03:00:00:ff:02 [l2-input-vtr l2-learn l2-fwd l2-flood l2-flood ]
00:00:00:756438: l2-input-vtr
  l2-input-vtr: sw_if_index 6 dst de:ad:00:00:00:00 src 02:03:00:00:00:00 data 08 00 45 00 00 80 00 01 00 00 40 11
00:00:00:756441: l2-learn
  l2-learn: sw_if_index 6 dst de:ad:00:00:00:00 src 02:03:00:00:00:00 bd_index 1

Note how l2-input-vtr node has the two lowest bytes of the source MAC corrupted.

Discussing with Benoit, since this could be caused by unaligned memory accesses,
using clib_memcpy_fast.

Type: fix
Change-Id: I28991e1166335df0edd1e4b84fa72a2b1d0bb9bf
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 months agohs-test: containerize iperf tests 96/41196/13
Adrian Villin [Wed, 26 Jun 2024 07:47:10 +0000 (09:47 +0200)]
hs-test: containerize iperf tests

Type: test

Change-Id: I2c0bb76d96ccadd5ecfd6a04565420855043699e
Signed-off-by: Adrian Villin <avillin@cisco.com>
5 months agoocteon: fix compilation on octeon9 80/41580/1
Monendra Singh Kushwaha [Fri, 13 Sep 2024 10:40:37 +0000 (16:10 +0530)]
octeon: fix compilation on octeon9

Type: fix

Signed-off-by: Monendra Singh Kushwaha <kmonendra@marvell.com>
Change-Id: I9ffa78122dcd6b98cad9902e43ba8432fcd572b1

5 months agovcl: add http support to vcl_test_protos 00/41500/9
Aritra Basu [Wed, 28 Aug 2024 21:02:34 +0000 (14:02 -0700)]
vcl: add http support to vcl_test_protos

Type: improvement

Change-Id: Ibb493f1d7713d0e10b8bd1d5ff17b89967b53b8a
Signed-off-by: Aritra Basu <aritrbas@cisco.com>
5 months agopvti: Packet Vector Tunnel Interface 94/39994/47
Andrew Yourtchenko [Tue, 23 Jan 2024 11:57:51 +0000 (11:57 +0000)]
pvti: Packet Vector Tunnel Interface

This plugin implements a PoC of UDP-based tunnel substrate whose aim is
to specifically provide higher MTU to the upper layers by chunking
the payload PDUs into smaller packets with full 5-tuple.

At the same time, if there are multiple small packets to
the same destination during the vector processing, they
are packed into "carrier" packets up to underlay MTU size.

It does assume a trustworthy underlying medium, thus for the
operation over Internet it requires the use of encryption layer
underneath.

Type: feature
Change-Id: I323958fa8de62584f6ed15643ea689568a9a62bc
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 months agodpdk: bump to DPDK 24.07 and RDMA 52.0 72/41572/2
Kai Ji [Fri, 13 Sep 2024 16:06:02 +0000 (16:06 +0000)]
dpdk: bump to DPDK 24.07 and RDMA 52.0

This patch bumps DPDK version to 24.07 and RDMA version
per dpdk 24.07 release notes (rdma-core >= 52.0)

Type: feature
Change-Id: I07c6f27becdbcd3696b821bbfd145610775cf51e
Signed-off-by: Kai Ji <kai.ji@intel.com>
5 months agosession: improve sh session cli 70/41570/6
Florin Coras [Tue, 10 Sep 2024 22:24:39 +0000 (15:24 -0700)]
session: improve sh session cli

Add support for:
- "sh session verbose thread <n> [lcl|rmt|ep] <ip>[:port]", which can be
used to filter sessions based on transport ip:port
- "force-print" option to force printing even when it exceeds existing
printing thresholds

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iab3e58b8162664b425379d14818b8a4daa0ce345

5 months agohttp: update body_len from u32 to u64 48/41548/6
Aritra Basu [Tue, 10 Sep 2024 04:47:26 +0000 (21:47 -0700)]
http: update body_len from u32 to u64

Type: improvement

Change-Id: I381541fb180d6d6ba42e4d231d22a73c5d33ef65
Signed-off-by: Aritra Basu <aritrbas@cisco.com>
5 months agohsa: fix proxy ao connect 71/41571/1
Matus Fabian [Fri, 13 Sep 2024 14:22:27 +0000 (16:22 +0200)]
hsa: fix proxy ao connect

Make sure that proxy server doesn't try to open connection to the
target multiple times. When client is uploading huge amount of data
it might happen that proxy_rx_callback is called again before
connection to the target is established.

Type: fix
Change-Id: I4d272d37bc545f6f8790a115c8d26bcf3ea84f22
Signed-off-by: Matus Fabian <matfabia@cisco.com>
6 months agovppapigen: endian generation for vla for non u32 61/41561/3
Ole Troan [Tue, 10 Sep 2024 21:37:56 +0000 (23:37 +0200)]
vppapigen: endian generation for vla for non u32

The endian function for VLAs assumed length field to be of type u32.
That failed for APIs using different integer width.

Type: fix
Change-Id: I6ecaabb4563c8bafeb100a4c6c1eee9a08e6cabf
Signed-off-by: Ole Troan <otroan@employees.org>
6 months agovlib: introduce lazy next node initialization 96/41496/6
Mohammed Hawari [Thu, 29 Aug 2024 12:01:06 +0000 (14:01 +0200)]
vlib: introduce lazy next node initialization

This change allow a node registration A to name a next node B that does not
exist yet at registration time. When node B is effectively created,
vlib_node_main_lazy_next_update need to be called so that the vlib graph
is updated accordingly. To enable this behavior, node A needs to bear
the new VLIB_NODE_FLAG_ALLOW_LAZY_NEXT_NODES.

Change-Id: I561d3a0de19a0b7bd1045760a2ba8e27d27caa9a
Type: improvement
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
6 months agohsa: fix proxy ao tx callback 62/41562/3
Florin Coras [Tue, 10 Sep 2024 22:52:35 +0000 (15:52 -0700)]
hsa: fix proxy ao tx callback

Reuse existing proxy_force_ack for active open tx callback. This makes
sure proxy session is tcp (as opposed to tls) and also makes sure the
ack is sent from the thread that owns the proxy session.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I9692fa2c4feefd3db701f9449a35495cf7b3d9dc

6 months agovlib: fix gcc 13.2.0 build failure on ubuntu 24.04 59/41559/2
Dave Wallace [Tue, 10 Sep 2024 16:36:07 +0000 (12:36 -0400)]
vlib: fix gcc 13.2.0 build failure on ubuntu 24.04

Type: fix

Change-Id: I007d73d28633677395d4eb81534dbe2307b1a96f
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
6 months agohs-test: upload via proxy tests 40/41540/3
Matus Fabian [Fri, 6 Sep 2024 13:30:59 +0000 (15:30 +0200)]
hs-test: upload via proxy tests

Type: test
Change-Id: Id6b4e2348735081c827f814a814c976b601432ec
Signed-off-by: Matus Fabian <matfabia@cisco.com>
6 months agohsa: http_tps coverity fix 49/41549/1
Matus Fabian [Tue, 10 Sep 2024 08:20:11 +0000 (10:20 +0200)]
hsa: http_tps coverity fix

Type: fix
Change-Id: Iea00a03dc94dfd6d1f0532e629d2f3b38cb26c07
Signed-off-by: Matus Fabian <matfabia@cisco.com>
6 months agohttp: fixed missing static keyword 26/41426/2
Adrian Villin [Mon, 9 Sep 2024 07:30:27 +0000 (09:30 +0200)]
http: fixed missing static keyword

Type: improvement

Change-Id: Id7a16388a72fc5de5848f3fec7a6dbeb6188f913
Signed-off-by: Adrian Villin <avillin@cisco.com>