Simon Zhang [Tue, 24 Sep 2019 13:16:56 +0000 (21:16 +0800)]
tcp: fix tso not work in single buffer issue
Type: fix
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: Iddb6fd41812e8c97af58859ef43279cfc0f9d1df
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Dave Barach [Wed, 9 Oct 2019 21:28:04 +0000 (17:28 -0400)]
tests: add cli_return_response to vpp_papi_provider
To improve gcov/lcov code coverage stats, it's necessary to send
incorrect debug CLI commands; to force vpp into debug CLI error paths.
cli_return_response() sends commands and returns the response object,
so test vectors can handle failures.
Type: feature
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I4fab591c9d2e30c996f016e18e4fd69b9c5bed06
Ahmed Abdelsalam [Tue, 8 Oct 2019 16:27:34 +0000 (16:27 +0000)]
sr: fix deleting an SR l2 steering policy
Type: fix
Signed-off-by: Ahmed Abdelsalam <ahabdels@cisco.com>
Change-Id: I9e98b1622785e58484bf316ef491e44cfb06bcb7
Ole Troan [Wed, 9 Oct 2019 12:38:14 +0000 (14:38 +0200)]
acl: remove api boilerplate
Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Idc9c508eb0e3d4b0c3908360fb0771012a8e2bc0
Ole Troan [Wed, 9 Oct 2019 12:27:40 +0000 (14:27 +0200)]
mactime: fix undefined symbol in mactime_test
undefined symbol format_macaddress
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I5549173ef758e965cf7d9d4f6aa9457d135318f5
Jakub Grajciar [Tue, 1 Oct 2019 10:04:56 +0000 (12:04 +0200)]
geneve: API cleanup
Use consistent API types.
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I1964e4f0afe6f030ae9c8e28fcba5fd81aa1f130
Ole Troan [Wed, 9 Oct 2019 10:39:32 +0000 (12:39 +0200)]
memif: remove api boilerplate
Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Icab769607c4a5890dc80b8f2661faa7e297c2a27
Filip Tehlar [Wed, 2 Oct 2019 09:08:04 +0000 (09:08 +0000)]
ikev2: fix dangling pointer
Type: fix
Change-Id: I8aa9029e0a5cf21aa24a90b39eb2787653f65abb
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Ryujiro Shibuya [Wed, 9 Oct 2019 01:54:04 +0000 (02:54 +0100)]
session: avoid old io dispatch if no slots left to send
Type: fix
Signed-off-by: Ryujiro Shibuya <Ryujiro.Shibuya@owmobility.com>
Change-Id: I8e1f6cbd905ad5c21aed1b2e358540d0fbd7fc47
Nathan Skrzypczak [Wed, 31 Jul 2019 15:57:58 +0000 (17:57 +0200)]
docs: Add macos build documentation
Type: docs
Change-Id: Iee03aacab2cfcb4e87190302dc641e8273b7f096
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Klement Sekera [Tue, 1 Oct 2019 13:00:22 +0000 (13:00 +0000)]
map: use ip6-full-reassembly instead of own code
Remove map's implementation of reassembly and use common
ip6-full-reassembly functionality. This makes it easier to maintain by
removing duplicate code/functionality.
Type: refactor
Change-Id: I430e888b704e28c100a9ce075d1460cb529e4676
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Jakub Grajciar [Mon, 30 Sep 2019 11:06:48 +0000 (13:06 +0200)]
dhcp: dhcp6_pd_client_cp API cleanup
Use consistent API types.
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: If6c102a53d074cba7eca6b6af9855aa4486f38cc
Mohsin Kazmi [Fri, 27 Sep 2019 11:44:28 +0000 (13:44 +0200)]
interface: dump the interface device type
Type: feature
Change-Id: I22e2ef34631c9432311ff6457504e0649e0512b4
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Klement Sekera [Tue, 8 Oct 2019 08:57:45 +0000 (08:57 +0000)]
ip: fix coverity warning
Type: fix
Fixes:
0eb75d0e9c7624a4e8ac69fea7dbe12d39b75096
Change-Id: I8bcdc06b33bf4e12752b90dc3445fa51af552a46
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Dave Wallace [Tue, 24 Sep 2019 21:52:36 +0000 (17:52 -0400)]
build: clean up make help output
This change is designed to help the uninformed find the right way
to run extended tests by using the test-all[-debug] targets.
'make test EXTENDED_TESTS=y' fails to build as it has a dependency
on 'vom-install' which is conveniently included in test-all[-debug].
- clarify test-all[-debug] description and
make test-help description
- Also align indentation of make help output
Type: style
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ief54cc8a5af68c052aacb0d660237c5eb63451b5
Matthew Smith [Fri, 12 Jul 2019 16:48:24 +0000 (11:48 -0500)]
interface: callback to manage extra MAC addresses
Type: feature
New callback vnet_hw_interface_add_del_mac_address().
Add or delete secondary MAC addresses on a hardware interface.
This will allow packets to be processed which have a destination
MAC address other than the primary programmed MAC address without
needing to put the device into promiscuous mode.
Change-Id: I6beecbcb8932fc1fe45b567f76fa3706feefae2c
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Vratko Polak [Mon, 7 Oct 2019 12:52:53 +0000 (14:52 +0200)]
api: comment, simplify and fix api socket read
The function vl_socket_read_ready did contain some comments already,
but as they stated, the logic has to be tricky to cover multiple cases.
Comment:
+ Add function-level comment
+ Add comments to describe some of local variables
+ Add many comments to describe internal state at particular lines.
Simplify:
+ Remov mbp_set as it is never needed.
+ Replace msg_len with msgbuf_len to save "+ sizeof (msgbuf_t)".
Improve:
+ Early exit on EAGAIN.
Fix:
+ "n" now only tracks input_buffer.
Previously, it was entering the detection of additional messages
even for unprocessed_input.
+ Set up msg_buffer (including appending to unprocessed_input)
outside full-message-detection loop now,
so it cannot be executed multiple times as before.
Type: fix
Ticket: VPP-1785
Change-Id: I256e34b435be06844458744a13ea37a0e86a96f9
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Vratko Polak [Tue, 10 Sep 2019 11:35:11 +0000 (13:35 +0200)]
papi: introduce read_blocking
Previously, self.transport.q got the messages
(at least for socket transport), stored in the encoded (packed) form.
In order to avoid accessing internals for async reads,
a new method is introduced, to perform
blocking reads of decoded (unpacked) messages.
The method is also used in _call_vpp(),
so sync and async reads are kept compatible.
Type: feature
Change-Id: Id49792dfa57c00b1a14a198031c5398d09a9ba20
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Rajesh Goel [Sun, 6 Oct 2019 07:47:36 +0000 (13:17 +0530)]
mpls: support fragmentation of mpls output packet
Type: fix
Signed-off-by: Rajesh Goel <rajegoel@cisco.com>
Change-Id: Ie4372c5cf58ab215cdec5ce56f8a994daaba2844
Ole Troan [Tue, 8 Oct 2019 09:35:23 +0000 (11:35 +0200)]
ioam: remove api boilerplate
Note: The VAT _test.c plugins need some more adjustments.
Type: refactor
Change-Id: Ifa150683d7d68db7950f66ef85eea73c8281ba14
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Mon, 7 Oct 2019 14:22:00 +0000 (16:22 +0200)]
api: autogenerate event handler functions for *_test.c
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If75f63244f37ae3312832ca015f738c51ee7da1f
Signed-off-by: Ole Troan <ot@cisco.com>
Neale Ranns [Tue, 8 Oct 2019 05:40:54 +0000 (22:40 -0700)]
ip: only install IPv6 prefixes in FIB when the interface is up
otherwise they get installed twice and the reference counting means they are not removed.
This is the same behaviour as IPv4.
Type: fix
Change-Id: I9266e04ccff6ff06a577e85973a2ddbeb9dfc52b
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Tue, 8 Oct 2019 05:44:54 +0000 (22:44 -0700)]
fib: P2P interfaces do not need specific multicast adjacencies
they can use the 'auto' adj for all traffic
Type: fix
Change-Id: Id2b9557683252a94badc8f9dfab5f7b2ae26f1ee
Signed-off-by: Neale Ranns <nranns@cisco.com>
Nathan Skrzypczak [Fri, 13 Sep 2019 08:20:15 +0000 (10:20 +0200)]
hsa: use crypto_engine_type_t for TLS
Type: refactor
This patch does the following conversions
TLS_ENGINE_X -> CRYPTO_ENGINE_X
tls_engine_type_t -> crypto_engine_t
It does not change numbering of engines
Change-Id: I872dfaec3a6713bf4229c84d1ffd98b8b2419995
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Nathan Skrzypczak [Fri, 13 Sep 2019 09:08:13 +0000 (11:08 +0200)]
session: Add certificate store
Type: feature
This changes the behavior of both API calls
APPLICATION_TLS_CERT_ADD & APPLICATION_TLS_KEY_ADD
certificates and keys aren't bound to an app, they are
passed to it via connect / listen using the message
queue.
This should be followed by a per protocol (QUIC/TLS)
crypto_context store to save devrived structs
Change-Id: I36873bc8b63b5c72776c69e8cd9febc9cae31882
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Dave Wallace [Wed, 25 Sep 2019 21:58:24 +0000 (17:58 -0400)]
hsa: fix vpp_echo session close
- Convert asserts in vpp_echo to conditional checks
- Refactor error logging for session creation/deletion
- Fix session close anomalies
- Fix ECHO_* macros
- Add rx/tx results different cmdline options to
specify pass when counters are different
- Update close tests to send more than the fifo
sizes of data
- Specify rx/tx results diff options for early
close tests
- Set listen session state to closed on handling
unlisten reply
Type: fix
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I9d0075fcb18e20829f420da104d69523897b0552
Chenmin Sun [Mon, 7 Oct 2019 19:35:20 +0000 (03:35 +0800)]
vlib: fix cli process stack overflow
Type: fix
Some cli processes, including configuring an test flow
on an i40e interface consume more than the currently
available stack space.
Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I3df53d251cd43286f94647384d6e50a463bad15c
Florin Coras [Tue, 8 Oct 2019 00:19:09 +0000 (17:19 -0700)]
tcp: rate sample for persist segments
Type: fix
Change-Id: I7c38d2ad6364f098529f51c15b533eb234b82716
Signed-off-by: Florin Coras <fcoras@cisco.com>
IJsbrand Wijnands [Tue, 8 Oct 2019 11:50:55 +0000 (13:50 +0200)]
api: add bapi thread handle to api main structure.
Adding the thread handle to the api main structure allows the client process of
the bin api to manage the thread, like setting the thread name for example.
Type: feature
Change-Id: I38b58ddc83d5958c4bda76eadd371eee1545724b
Signed-off-by: IJsbrand Wijnands <ice@cisco.com>
Klement Sekera [Tue, 1 Oct 2019 19:14:34 +0000 (19:14 +0000)]
tests: handle unicode charactes in cli output
Type: fix
Change-Id: Ic4fb53e6d10a1de155a3088be81d53d9efeb0c0f
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Nathan Skrzypczak [Thu, 12 Sep 2019 14:02:13 +0000 (16:02 +0200)]
hsa: make vpp_echo use mq instead of bapi
Type: refactor
Change-Id: I4f370b09e22dbbc8920272df9a042dae04825bfc
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Nathan Skrzypczak [Wed, 2 Oct 2019 08:02:05 +0000 (10:02 +0200)]
session: add is_migrating flag
Type: fix
Add SESSION_F_IS_MIGRATING flag for session. It is set by the session
layer before poking the transport for migration. It's the transport
responsibility to unset the flag & act apropriatly if RX happens on
a migrating session.
Change-Id: Ie722917f1cf9344d8f041cad4ed8b064fb5853b6
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Jianlin Lv [Fri, 27 Sep 2019 01:35:41 +0000 (09:35 +0800)]
api: Add API support for marvell PP2 plugin
Support create/delete interface with PP2 api
Type: feature
Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
Change-Id: Ia9c0ac0f237fd9f71f5480d736d6bcabee763fff
Klement Sekera [Mon, 30 Sep 2019 09:25:04 +0000 (09:25 +0000)]
ip: remove dead code in ip6-svr
Type: fix
Fixes:
de34c35fc73226943538149fae9dbc5cfbdc6e75
Change-Id: Ia714c2e46627864091d3f686dbced4cdd9c1a773
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Haggai Eran [Sun, 6 Oct 2019 11:20:42 +0000 (14:20 +0300)]
docs: change VPP_WITH_SAMPLE_PLUGIN to SAMPLE_PLUGIN in sample plugin documentation
The sample_plugin_doc.md file refers to VPP_WITH_SAMPLE_PLUGIN make
parameter, while the VPP makefile uses SAMPLE_PLUGIN instead.
Type: docs
Signed-off-by: Haggai Eran <haggai.eran@gmail.com>
Change-Id: Id11090fcdc78b77e246da48d0d890865011f1132
Steven Luong [Wed, 2 Oct 2019 14:33:48 +0000 (07:33 -0700)]
devices: vhost not reading packets from vring
In a rare event, after the vhost protocol message exchange has finished and
the interface had been brought up successfully, the driver MAY still change
its mind about the memory regions by sending new memory maps via
SET_MEM_TABLE. Upon processing SET_MEM_TABLE, VPP invalidates the old memory
regions and the descriptor tables. But it does not re-compute the new
descriptor tables based on the new memory maps. Since VPP does not have the
descriptor tables, it does not read the packets from the vring.
In the normal working case, after SET_MEM_TABLE, the driver follows up with
SET_VRING_ADDRESS which VPP computes the descriptor tables.
The fix is to stash away the descriptor table addresses from
SET_VRING_ADDRESS. Re-compute the new descriptor tables when processing
SET_MEM_TABLE if descriptor table addresses are known.
Type: fix
Ticket: VPP-1784
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I3361f14c3a0372b8d07943eb6aa4b3a3f10708f9
(cherry picked from commit
61b8ba69f7a9540ed00576504528ce439f0286f5)
Benoît Ganne [Mon, 7 Oct 2019 13:36:10 +0000 (15:36 +0200)]
rdma: fix crash when failing to read pci addr on create
Type: fix
Change-Id: I543e2e5976cb384b81278a7ec98a0a6ab1612438
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Mon, 7 Oct 2019 13:57:32 +0000 (15:57 +0200)]
rdma: fix crash when failing to detect numa node on create
Type: fix
Change-Id: Ibb8e7c1c13869c1dce2385f58bd7260fcf776c5a
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Neale Ranns [Mon, 7 Oct 2019 07:39:28 +0000 (00:39 -0700)]
dhcp: Move to plugin
Type: feature
Change-Id: I3fe27a8ef577741d9a5c4f090ec91cf68fb44fe3
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Barach [Mon, 7 Oct 2019 16:04:31 +0000 (12:04 -0400)]
mactime: add a "top" command to watch device stats
Include a binary API change NOT suitable for cherry-picking into 19.08
Type: feature
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Id369514a3085f5e4bcee34819c55c4636df9b518
Klement Sekera [Mon, 7 Oct 2019 12:20:39 +0000 (12:20 +0000)]
ip: add tracing for ipv6 frag headers
Type: feature
Change-Id: I0e049b28d8c21b67ea4545e865eda4e88f10e485
Signed-off-by: Klement Sekera <ksekera@cisco.com>
MathiasRaoul [Mon, 7 Oct 2019 15:41:37 +0000 (15:41 +0000)]
quic: fix wrong condition in update_fifo_size
Type: fix
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: If371cde9412be29634164830c58634da248ad0ae
Neale Ranns [Mon, 7 Oct 2019 10:31:50 +0000 (10:31 +0000)]
mactime: remove unnecessary function declaration
Type: fix
Change-Id: I80cb666d9eae9d0f780d51fb95454d97ed320454
Signed-off-by: Neale Ranns <nranns@cisco.com>
Christian E. Hopps [Sun, 29 Sep 2019 01:36:36 +0000 (21:36 -0400)]
vlib: move thread barrier around mod of global node next data
The old code modified the node next array prior to obtaining the thread
barrier. Then it updated the runtime node data, and upon barrier release
caused reforking of each worker thread. The reforking clones the main
thread nodes and reconstructs the runtime node structure. This cloning
is not 100% "deep" in the sense that the node next array is
shared (i.e., only the pointer is copied). So prior to the barrier being
obtained the node's next array is being changed while workers are
actively using it (bad). Treating the node next array as read-only in
the workers and sharing it is a decent optimization so instead of trying
to fix that just move the barrier a little earlier in the process to
protect the node next array as well.
This was tripping an assert in next frame ownership change by way of the
ip4-arp node. The assert verifies that the node's next array length is
equal to the runtime next node count. The race above was lost and the
node next array data was updated in the main thread while the arp code
was still executing in a worker.
This was being hit when many arp requests were being sent from both ends
of a tunnel during which the add next node function was called, which
often led to an assert b/c the next node array was out of sync with the
runtime next node count.
- PS#2 update - move barrier sync to just above code that modifies state.
Ticket: VPP-1783
Type: fix
Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Change-Id: I868784e28f994ee0922aaaae11c4894a3f4f1fe7
Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Nathan Skrzypczak [Tue, 1 Oct 2019 11:04:59 +0000 (13:04 +0200)]
quic: Refactor naming & clibs
Type: refactor
Change-Id: I067fc7dbcc0985277df01384d9dcdb0bdf62fba5
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Dave Barach [Sun, 6 Oct 2019 13:19:29 +0000 (09:19 -0400)]
docs: grammar police raid
Edit the front-page intro text. Fix egregious grammar errors,
including an "it's" vs. "its" blunder.
Type: docs
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: If9d7d07899c402cd49bbae988110a15216035b02
Klement Sekera [Mon, 7 Oct 2019 09:48:06 +0000 (09:48 +0000)]
ip: reassembly add missing goto
Type: fix
Fixes:
de34c35fc73226943538149fae9dbc5cfbdc6e75
Change-Id: I256ef153b3b27a1f7ab7daa45015a2ec4bc84076
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Klement Sekera [Mon, 7 Oct 2019 09:34:44 +0000 (09:34 +0000)]
ip: reassembly remove dead code
Type: fix
Fixes:
de34c35fc73226943538149fae9dbc5cfbdc6e75
Change-Id: I79589f648f4c75762e5277fb94636a91fa36ccdd
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Nathan Skrzypczak [Mon, 16 Sep 2019 14:26:58 +0000 (16:26 +0200)]
build: add env variable to pass extra cmake args
If VPP_EXTRA_CMAKE_ARGS is set, its content will be
appended to the vpp cmake command cli
Type: feature
Change-Id: I825d4239e62b0a2fb70a652f0671f6c559630aad
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Neale Ranns [Mon, 7 Oct 2019 08:13:44 +0000 (08:13 +0000)]
dhcp: API return code fix
Type: fix
Change-Id: Ifcbfeecd6ca1215ec473eec4cce736ab4eacde80
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Mon, 7 Oct 2019 08:23:38 +0000 (08:23 +0000)]
ip: MFIB CLI fix for parsing path flags
Type: fix
Change-Id: I7ed9726d8c5ca26715a84b004a18fd7f93142486
Signed-off-by: Neale Ranns <nranns@cisco.com>
Benoît Ganne [Fri, 4 Oct 2019 13:28:12 +0000 (15:28 +0200)]
rdma: prevent loopback of broadcast packets
TX queues must be created before RX queues on Mellanox cards in order to
not receive our own broadcast packets.
Type: fix
Change-Id: I32ae25a47d819f715feda621a5ecddcf4efd71ba
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Steven Luong [Fri, 4 Oct 2019 21:18:37 +0000 (14:18 -0700)]
bonding: traffic traversing the wrong interface
Missing an increment in the while loop. Hashes not stored in the array.
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I603027f5a7305478f48a102ac8035ffde9102c53
(cherry picked from commit
0471cdbd3fe04a88a8b70b5f0eff0c378e19abf7)
Neale Ranns [Sun, 6 Oct 2019 08:04:26 +0000 (01:04 -0700)]
ip: Fix IP unnumbered dump of one interface
Type: fix
Change-Id: I35fb6fdfba50c4a59cf1ffb94cb51487bcf5afc9
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Barach [Fri, 4 Oct 2019 13:59:00 +0000 (09:59 -0400)]
misc: add "show run summary"
Prints the interior node vector rate, rx / tx / drop rates
Type: feature
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I57130db0f99e852a8498aa90d01e52f7ac33dcc9
Benoît Ganne [Fri, 4 Oct 2019 15:38:05 +0000 (17:38 +0200)]
rdma: make sure pci subsystem is initialized
The rdma driver use the pci subsystem, make sure the dependency is
recorded.
Type: fix
Change-Id: Ibd613f623d355612881acc31b9423f2de13793a3
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Fri, 4 Oct 2019 15:30:21 +0000 (17:30 +0200)]
vlib: pci: set pci driver name to none when no driver is loaded
If no Linux PCI driver module is loaded, then the driver_name in the PCI
info struct is NULL. This can triggers crash when checking driver name
eg. in vlib_pci_device_open().
Default to "<NONE>" as driver name, which should never match.
Type: fix
Change-Id: I9e69889a7566467bd8220b92bbbaa72ada957257
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Dave Barach [Fri, 4 Oct 2019 16:38:13 +0000 (12:38 -0400)]
docs: add packet-generator writeup
Type: docs
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I4abb5c17e6fdfeaed5bbadb2ce83098dde6d05b1
MathiasRaoul [Fri, 4 Oct 2019 15:28:00 +0000 (15:28 +0000)]
hsa: make APP_OPTIONS_PREALLOC_FIFO_PAIRS configurable
-add prealloc_fifo_pairs member in echo_main_t
-new cli parameter in vpp_echo
Type: feature
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I6bb1214ee93e06421cd0a3721420278c51cd59c4
MathiasRaoul [Fri, 4 Oct 2019 15:27:03 +0000 (15:27 +0000)]
quic: make quic fifo size configurable via cli
Type: feature
Change-Id: I6d6ac649094ef4bee2aed311915dd58f11972e79
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Benoît Ganne [Mon, 30 Sep 2019 08:55:33 +0000 (10:55 +0200)]
ip: fix use-after-free in IPv6 SLAAC expiration
Type: fix
Change-Id: I46b166b3a10c4543eafa4422531dd3c725db45f1
Signed-off-by: Benoît Ganne <bganne@cisco.com>
MathiasRaoul [Wed, 2 Oct 2019 14:56:15 +0000 (14:56 +0000)]
quic: update quicly to v0.0.5
-Update quicly patches
-Remove event logger (removed from quicly).
-Update quicly functions calls
Type: feature
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I0355befeb5ce961928f17225c83890ba87cf6ebc
MathiasRaoul [Fri, 4 Oct 2019 09:53:45 +0000 (09:53 +0000)]
vppinfra: create unformat function for data size parsing
Type: feature
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I8d71078a9ed42326e19453ea10008c6bb6992c52
Benoît Ganne [Thu, 18 Jul 2019 15:33:42 +0000 (17:33 +0200)]
nat: fix use-after-free
Type: fix
Change-Id: Iac91c086c4e975f0bada058f40b7b7d4475377f8
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Mon, 30 Sep 2019 10:56:28 +0000 (12:56 +0200)]
tcp: unittest: do not access non-existent samples
There is no bt->samples for this test, do not use it.
Type: fix
Change-Id: I2090290887bc5c0b5cdb0561cf2bf72a87781089
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Andrew Yourtchenko [Thu, 3 Oct 2019 07:55:52 +0000 (07:55 +0000)]
acl: fix intermittent test failure
ACL tests use random port number in the tests.
A port number 6081 causes the decode in scapy
to consume some of the Raw payload into GENEVE
encoding, which breaks the test.
Solution: bring up the lower range of random
port to 16384, so that it does not touch any
of the well known ports.
Type: test
Change-Id: I022660d8ec147857924b436f1871b0b5ddcf4c47
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
juraj.linkes [Wed, 14 Aug 2019 09:11:33 +0000 (11:11 +0200)]
ebuild: Unite default build platform to vpp
Top level makefile is using vpp as the default platform. The other place
where platform is specified has native as the default. Unite them to the
only currently supported platform - vpp.
Type: make
Change-Id: Idb12ccc3056dd6be640a2d6763dc30e4f789d2ac
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
Christian E. Hopps [Fri, 27 Sep 2019 16:59:30 +0000 (12:59 -0400)]
misc: add "maxframe" and "rate" to packet-generator cli.
Allow for setting the maximum number of generated packets to be included
in the frame passed to next nodes. This is very important for testing
code which may be susceptible to multi-frame vs single-frame bugs (e.g.,
code that is doing re-ordering where packets may be buffered between
frames).
Update:
- remove redundant packet "rate" option.
- reduce n_max_frame to u32 as that's what pulled from the CLI.
Type: feature
Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Change-Id: Ie362bbb110b2cf01d9f65c559bbe9101e17b7fdc
Signed-off-by: Christian Hopps <chopps@labn.net>
Dave Barach [Tue, 1 Oct 2019 16:10:57 +0000 (12:10 -0400)]
emacs: track improvements in vppapigen
Remove boilerplate which is now generated by vppapigen
Type: refactor
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I36bff1a651ac48caa969ed76d963b0a733ef5532
Padma Ram [Tue, 1 Oct 2019 01:05:18 +0000 (06:35 +0530)]
memif: memif buffer leaks during disconnect.
- code added to release the mbuf's to main pool during memif disconnect.
Type: fix
Change-Id: I504dacc9a40bc1702831cf3208fd532d1ae68a6f
Signed-off-by: Padma Ram <padmaram86.raja@gmail.com>
Benoît Ganne [Fri, 27 Sep 2019 16:07:39 +0000 (18:07 +0200)]
api: fix non-null-terminated C-string
Type: fix
Change-Id: I132112bf77e1fad7fc0227a96e6b0cee590295e8
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Christian E. Hopps [Fri, 27 Sep 2019 19:05:41 +0000 (15:05 -0400)]
ipsec: initialize msgid and allow no dh in child sa
- set msgid to 0 not random.
- allow for no DH in ESP child SA
Ticket: VPP-1781
Type: fix
Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Change-Id: Ibe26009d38f444eeaec5b042097f145d161c7672
Matthew Smith [Wed, 2 Oct 2019 21:34:27 +0000 (16:34 -0500)]
ethernet: fix dmac filter coverity warning
Static analysis says that a possibly null pointer is dereferenced.
Check it first.
Type: fix
Change-Id: I3d1a1548162d1dfc26f19fbcf159f0f1f91eb7c4
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Ole Troan [Wed, 2 Oct 2019 14:53:58 +0000 (16:53 +0200)]
pppoe: remove api boilerplate
Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I42705c508e88dae40a4c19ab20a1340623a57e16
Ole Troan [Wed, 2 Oct 2019 15:00:30 +0000 (17:00 +0200)]
oddbuf: remove api boilerplate
Type: refactor
Change-Id: Ic4922da46bf941249dd74b1a8bc6a98c62c099b7
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Wed, 2 Oct 2019 15:09:01 +0000 (17:09 +0200)]
nsim: remove api boilerplate
Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Idf2206ae3e3d8dd05e98528ee1f02c4c7d567f37
Ole Troan [Wed, 2 Oct 2019 15:17:58 +0000 (17:17 +0200)]
dpdk: remove api boilerplate
Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2cba1e2912902b092348dddcf9cbcba231c75995
Jakub Grajciar [Tue, 1 Oct 2019 09:37:30 +0000 (11:37 +0200)]
feature: API cleanup
Use consistent API types.
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Id1e7210298cb494f3cb7a47a9ecf2bc1d9c1d58e
Jakub Grajciar [Tue, 1 Oct 2019 09:30:56 +0000 (11:30 +0200)]
dhcp: API cleanup
Use consistent API types.
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ia63d920788add2584060a240321acced7a471640
Vladimir Ratnikov [Fri, 27 Sep 2019 07:26:49 +0000 (03:26 -0400)]
map: fix DF[Don't fragment] ip4-map-t behaviour
This patch allows ip4-map-t plugin to drop
packets if DF flag is set and packet size
is bigger than MTU
Type: fix
Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
Change-Id: I0c1531a1f876d9efc8e7e2bff9804f298becdb68
Klement Sekera [Tue, 1 Oct 2019 13:08:43 +0000 (13:08 +0000)]
map: fix indent-off
Replace erroneous INDENT-OFF with INDENT-ON and reformat code which is
non-conforming wrt to code style.
Type: style
Change-Id: Ia3310371e96b248e5da143fad8fdca3b2fb6650b
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Dave Barach [Tue, 1 Oct 2019 17:34:23 +0000 (13:34 -0400)]
vlib: improve summary vector-rate statistics
Type: refactor
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I4b77879b0a84fdec3c1518a972cf003d5135222d
Signed-off-by: Ole Troan <ot@cisco.com>
Neale Ranns [Tue, 1 Oct 2019 16:49:53 +0000 (09:49 -0700)]
ip: mfib CLI 'via local' fix
Type: fix
Change-Id: I6fd7bb27b95a50d37424f65dc51e8b341f8b1b28
Signed-off-by: Neale Ranns <nranns@cisco.com>
Matthew G Smith [Wed, 4 Sep 2019 20:01:04 +0000 (15:01 -0500)]
ethernet: dmac filter checks secondary mac addrs
Maintain a list of secondary MAC addresses on ethernet_interface_t.
In ethernet-input dmac filtering, If packets do not match the
primary interface hardware address, check to see if they match the
other addresses.
Type: feature
Change-Id: Ie0edf45cae0d85c038a61086c47b3ae82d7e162d
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
MathiasRaoul [Thu, 26 Sep 2019 09:17:13 +0000 (09:17 +0000)]
quic: Create custom event logger
Type: feature
Change-Id: I20acfe6a53cf9f15e3e4b8847b6f76757962f1c7
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
MathiasRaoul [Thu, 26 Sep 2019 09:13:39 +0000 (09:13 +0000)]
quic: Add Tx, Rx and packet drop counters
Type: feature
Change-Id: I25aeeed49fc569315296a73c5595c2e2e302434f
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Benoît Ganne [Thu, 18 Jul 2019 16:38:42 +0000 (18:38 +0200)]
session: fix use-after-free
Make sure to reinitialize data before free-ing it.
Type: fix
Change-Id: I45727c456d0345204d4825ecdd9690c5ebeb5e94
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Florin Coras [Tue, 1 Oct 2019 17:32:46 +0000 (10:32 -0700)]
session: allow transport cleanup in any state
Type: fix
Third time's a charm
Change-Id: I31555a35d2b51f49a93a2a213c28896b0cad4c09
Signed-off-by: Florin Coras <fcoras@cisco.com>
MathiasRaoul [Thu, 26 Sep 2019 09:07:16 +0000 (09:07 +0000)]
quic: add cli command for stats
add command to display stats from quicly (rtt, packet loss)
Type: feature
Change-Id: Iaa18bc78fbf80a9367ef150a8cf4997a456c6b39
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Benoît Ganne [Mon, 30 Sep 2019 14:43:25 +0000 (16:43 +0200)]
rdma: fix non-NULL terminated C-string overflow
Type: fix
Change-Id: I584777825636347c116bd084e348858bcb1b7d75
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Klement Sekera [Mon, 23 Sep 2019 09:00:30 +0000 (09:00 +0000)]
map: use SVR for MAP-T
This change is part of an effort to unify reassembly code. By removing
shallow virtual reassembly functionality in MAP and using the common
vnet provided shallow virtual reassembly, code size and complexity
is reduced.
Type: refactor
Change-Id: Iec8edd039f7b967b53e17bb9bca228a8b452ac0c
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Burt Silverman [Mon, 30 Sep 2019 13:50:42 +0000 (09:50 -0400)]
build: build-root/Makefile rm of install tree
Type: fix
The scenario is touch of a dpdk source file in places like
<TOP>/build-root/build-vpp-native/external/dpdk-19.08/. The subsequent
build will trigger an rm -rf $(PACKAGE_INSTALL_DIR) by
build-root/Makefile at around line 709. Because the package in
question, "external", consists of various "sub" packages, all of which
are controlled with files like .quicly.install.ok located in
build-root/build-vpp[_debug]-native/external, we end up not handling the
.*.install.ok files to reflect the removal of that PACKAGE_INSTALL_DIR.
This fix will correct that, at least for the case of touching/changing
dpdk files. A better long term solution would be to change the "sub"
packages to be full fledged build system packages, as Dave Barach points
out.
Signed-off-by: Burt Silverman <burtms@gmail.com>
Change-Id: Ia94ccaa2795cbf354b5921c3001a7141313b66be
Benoît Ganne [Mon, 9 Sep 2019 14:34:54 +0000 (16:34 +0200)]
ipsec: fix use-after-free
When deleting interface from the API, 'hi' gets removed before
'h->sw_if_index' is copied.
Type: fix
Change-Id: I8e10108e9bdf95ab2fe002790d98262d583ca58c
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Fri, 27 Sep 2019 16:08:22 +0000 (18:08 +0200)]
bonding: fix non-null-terminated C-string
Type: fix
Change-Id: Ibb7ba878b049b8b18e890c43fdd6324cb88d63b8
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Nathan Skrzypczak [Fri, 27 Sep 2019 15:03:15 +0000 (17:03 +0200)]
hsa: fix vpp_echo mq locking
Type: fix
Change-Id: I18d2cde0baaed4134e8378c09aaa88693fb997f8
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Jakub Grajciar [Mon, 30 Sep 2019 08:26:53 +0000 (10:26 +0200)]
dhcp: dhcp6_ia_na_client_cp API cleanup
Use consistent API types.
Type: fix
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ie2d2c74ed3832d137e808e0b52348b4e660feb6f
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Klement Sekera [Mon, 30 Sep 2019 14:35:36 +0000 (14:35 +0000)]
ip: svr: fix feature refcounts
Reference counts need to be per-interface as opposed to global. This
allows configuring the feature on more than one interface correctly.
Type: fix
Fixes:
de34c35fc73226943538149fae9dbc5cfbdc6e75
Change-Id: I05534ac59fa86e67290737ec6c61df2c19acab48
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Benoît Ganne [Fri, 30 Aug 2019 14:20:12 +0000 (16:20 +0200)]
vlib: fix old nodes vector overflow in refork
Type: fix
Change-Id: I81c4cf0ce87288bb2d3c7b9f31e9419290d588b4
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Mon, 30 Sep 2019 08:13:27 +0000 (10:13 +0200)]
dns: fix non-NULL terminated C-string
Type: fix
Change-Id: Ib030e6ac3386528901e0805d1ffe2eec033d819f
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Benoît Ganne [Wed, 11 Sep 2019 14:43:44 +0000 (16:43 +0200)]
api: fix use-after-free
Type: fix
Change-Id: I2a599c22d5770587fdd419e5d212c8527054d2e9
Signed-off-by: Benoît Ganne <bganne@cisco.com>