http: h2 fix handling of incomplete frame headers

Type: fix

Change-Id: I47155fd7d453b0e9bdcf39f5bc14139323a9a42e
Signed-off-by: Matus Fabian <[email protected]>

http: h2 connect-udp dgram mode flow control fix

keep some space for dgram headers

Type: fix

Change-Id: I91002022cf0a9878d23c4e98dfcfbb6089073cb7
Signed-off-by: Matus Fabian <[email protected]>

http: h2 client conn error handling fix

Notify only parent app session in case of http/2 connection error.

Type: fix

Change-Id: Ia02fe8863cd88df8a8dc7361655322c1335bbbd3
Signed-off-by: Matus Fabian <[email protected]>

http: req_state_udp_tunnel_tx fix

Type: fix

Change-Id: Ibf7afb69ba709dd28254807a34644ecc5bf892e8
Signed-off-by: Matus Fabian <[email protected]>

hs-test: fix envsubst not working

Type: fix

Change-Id: Iffb2a77ebd49d9d4784be80757c5a97a6ad98bb3
Signed-off-by: Adrian Villin <[email protected]>

hs-test: KinD cluster setup improvements

- script cleanup
- clarified Makefile build-msg
- release-cluster: versions can be specified
- master-cluster: local repo gets properly reset to its
  original state, fixed rebuild-master-cluster

Type: improvement

Change-Id: I81f813d2cd0227eaac3b996590152ba7e1173e38
Signed-off-by: Adrian Villin <[email protected]>

af_xdp: fix missing recvmsg argument

Because of missing argument syscall was failing
before reaching xdp system what could result in
degrated performance

Type: fix

Change-Id: I0ae1ce1bacf68457a02a31b3508e9c5100a754e6
Signed-off-by: Vladimir Zhigulin <[email protected]>

http: zero hdr.gso_size in udp_tunnel_rx

Type: fix

Change-Id: I78fb6263af14b37e2aee42386850f23bbacf40fb
Signed-off-by: Matus Fabian <[email protected]>

srtp: zero hdr.gso_size in srtp_ctx_read

Type: fix

Change-Id: I895b5f35b451c80c2ff2f3d7e7710e67aa546742
Signed-off-by: Matus Fabian <[email protected]>

hsa: echo client zero hdr.gso_size

Type: fix

Change-Id: I0efff82f942bf63af5bbad1d713c0a5ff90f00a2
Signed-off-by: Matus Fabian <[email protected]>

tls: zero hdr.gso_size in openssl_ctx_read_dtls

Type: fix

Change-Id: I621c846b3d2f3803c2799240f00b36979017bbec
Signed-off-by: Matus Fabian <[email protected]>

tls: fix coverity warning

Type: fix

Change-Id: I97e08e93b02271599e52462ab83767168a2eb1cb
Signed-off-by: Florin Coras <[email protected]>

session: restore cl session dscp support

Included dscp in session_listen messages and propagated it up to the
listener struct, which is used for connection info in cl sessions.
Additionally, included a switch in vcl_test_cl_udp allowing to select
dscp values for the session.

Type: fix
Change-Id: I6dffe12b66b25617dc9e3b6d4008f1097ff150cf
Signed-off-by: Semir Sionek <[email protected]>

hsa: fix potential udp echo server test-bytes int overflow

Make sure that when running echo server over UDP with test-bytes
enabled, we're getting at least the buffer offset and some data.

Type: fix
Fixes: 84d52285afd1b478d616026a3d63a714abb29f13
Change-Id: I9375e00a76caa9d043f0b5531169fb6f2ca07db7
Signed-off-by: Semir Sionek <[email protected]>

virtio: fix cli parser

Fixes: 84f09f4
Type: fix

Change-Id: If1d42dc7899cf87f016b12dc0eabff944ff20bea
Signed-off-by: Florin Coras <[email protected]>

gso: add support for ipip tso for phyiscal interfaces

Type: improvement

This patch also improves software GSO handling for
tunnel interfaces.

Signed-off-by: Mohsin Kazmi <[email protected]>
Change-Id: I210bf74a65feef0bb39b5925bf8632ef4d627eb5

tests: add vpp-opt-deps to vpp LD_LIBRARY_PATH

- When vpp-opt-deps is installed, add it to LD_LIBRARY_PATH
  when invoking vpp for 'make test' and 'make run' targets
  overriding the dynamically linked distro library version.

Type: test

Change-Id: Id2feb74b7232cca1c1870599c4b3d409e2d0aa59
Signed-off-by: Dave Wallace <[email protected]>

session: session_cb_vft add proxy_write_early_data

Allow zc proxy app write data to fifo before UDP transport on accepted
connection.

Type: feature

Change-Id: I93657de68d344f5d2d327dd4e36cc331043fdf98
Signed-off-by: Matus Fabian <[email protected]>

vppinfra: fix cpu time on riscv

Starting with Linux 6.6 [1], RDCYCLE is a privileged instruction on
RISC-V and can't be used directly from userland.Use RDTIME instead,
which while less accurate has the advantage of being synchronized
between CPU (and thus monotonic) and of constant frequency.

Type: fix
Change-Id: I53ab9cd1d0fcdd8f0e88d189840ba1d3b5ddd67a
Signed-off-by: Shubing Guo <[email protected]>

hs-test: load k8s pod definitions from a file

- improved pod teardown, fixed obtaining IP addresses from pods
- added contexts for better goroutine management

Type: improvement

Change-Id: Iab8bd76598465c44626188d47b57d561469e279b
Signed-off-by: Adrian Villin <[email protected]>

api: fix crash in pcap capture api

pcap api cleanup can cause crash if invalid sw_if_index
is provided. This fix is similar to https://gerrit.fd.io/r/c/vpp/+/41936
, which only fixed the invalid filename use-case.

Type: fix

Change-Id: I34ce178a4cb7fc92b4e4bb399a3fabd4efc85159
Signed-off-by: Hadi Rayan Al-Sandid <[email protected]>

hsa: show tx/rx stats for UDP on timeout and fix test-bytes for UDP

We shouldn't assume that all the dgrams will be transported between
server and client.
This patch addresses this issue in two places:

1. Now if we hit the timeout on UDP client rx (not all bytes
   transported), instead of an error - we display tx/rx byte stats.
2. For test-bytes mode, we now include a 4 byte buffer offset with each
   dgram to check against for data corruption. Previous solution was
   based on the assumption that data will arrive in sequence, which is
   just not the case for UDP.

Type: fix
Change-Id: I1a2ac8afe4180830b32f4ea67b4b477f167e0800
Signed-off-by: Semir Sionek <[email protected]>

http: h2 client connect-udp fix

Type: fix

Change-Id: I1ce22f70ecd609368ebaee351cbe1d260a6c2536
Signed-off-by: Matus Fabian <[email protected]>

http: h2 client tunnel fix

Type: fix

Change-Id: I7e86578c0430bc90cdff4668f8469a303d0bbc7e
Signed-off-by: Matus Fabian <[email protected]>

session: enable sending segmented dgrams

Split app_send_dgram_raw_gso into app_send_dgram_segs_raw and app_gen_dgram_header. The former sends out previously prepared segmented dgram, while the latter fills in the header in a prepared segment array.
Additionally, app_send_dgram_segs was introduced as an easier API for sending out segmented data.

Type: improvement
Change-Id: I3afdd9b974a7dbf936b7b7c07873ac72262525d9
Signed-off-by: Semir Sionek <[email protected]>

af_xdp: processing free buffer

af_xdp does not support big packets and they got dropped.
When that happens, we need to bump up the buffer pointer
and decrement packet count prior to going back to the
while loop.

Type: fix

Change-Id: I4722b15eb7ba5467f37e52ab532998c35caa3e2e
Signed-off-by: Steven Luong <[email protected]>

af_xdp: bump xdp-tools to 1.5.5

Type: feature

Change-Id: Ia6d32305045f51b859c4b888f5912f8d4cbbd766
Signed-off-by: Steven Luong <[email protected]>

http: http2_transport_rx_callback hardening

When we receive extra data bytes handle it as connection error to
prevent data leakage.

Type: improvement

Change-Id: I1316d019b252faa29a818b4aeff5d1d5752719e2
Signed-off-by: Matus Fabian <[email protected]>

build: updated to build on RHEL-8

Type: improvement

extras/rpm/vpp.spec: updated to ensure crypto libraries are copied into lib RPM but other, conflicting system libraries are not

Change-Id: I786b61d17141e7ed2f8c88f9646e2bdad09c93fb
Signed-off-by: Joel Godfrey-Smith <[email protected]>

tests: af_xdp interface tests

Type: test

Change-Id: I81019d2ac8b793c11b22deab8a103b37b88eb75e
Signed-off-by: Naveen Joy <[email protected]>

session: session debug crashes with elog track

session debug uses elog track in the the transport.
However, not all transports initialize elog track.
If they don't, session debug crashes.

The fix is to use non elog track if elog track
is not initialized in the transport.

Type: fix

Change-Id: I123f71b39a4262cd68e35634dd5c7ec0e7b88cb0
Signed-off-by: Steven Luong <[email protected]>

hs-test: add hsi and transparent proxy test

Type: test

Change-Id: Ie7fdc987ee300cf0d3dc5aed31dd28a972f0c394
Signed-off-by: Matus Fabian <[email protected]>

quic: reregister transport proto when no quic engine registered

- fixes incomplete implementation from original patch to fix
  crash on startup when no quic engine is enabled

Type: fix
Fixes: 19e0d0ef8

Change-Id: I8508c28dc2e3d6201fd5de296386d0309fc0edd1
Signed-off-by: Dave Wallace <[email protected]>

pg: add support for checksum offload

Type: improvement

This patch adds support for checksum offload.
There has been also added show packet-generator interface
cli.

Change-Id: I55462df45ea54b577c110e1cc4e3512d70bcfa90
Signed-off-by: Mohsin Kazmi <[email protected]>

tcp: fix persist handler in closed state

Do not rechedule connection if persist handler is called after
connection is closed.

Type: fix

Change-Id: Ibe7c3924c6fb107a36e4d459f32a39e49a0b7ae1
Signed-off-by: Florin Coras <[email protected]>

hs-test: glean proxy environment variables is present

Type: test

Change-Id: I2dc9136b12444f0fd2ef725b2d778a54538e5b17
Signed-off-by: Florin Coras <[email protected]>

tcp: conditionally initializing log track for unbind

elog track is initialized when tcp open, bind, or syn rcvd
message is received. Logging tcp unbind event requires and
expects elog track is already initialized. If tcp debug
is enabled after the aforementioned 3 messages and the
first event that tcp logs is unbind, we crash because elog
track is not initialized.

Let's check the elog track is initialized yet or not
prior to logging an unbind event. If not, we initialize
it.

Type: fix

Change-Id: Ib8fde694dc48f30a87aa3ecd378c1960857e8c38
Signed-off-by: Steven Luong <[email protected]>

session tls: scaffolding for async cert retrieval

Basic experimental infrastructure for server async retrieval.

Type: improvement

Change-Id: Iec48a0a30e5968a42237b810ec5e6c4e9d633728
Signed-off-by: Florin Coras <[email protected]>

hs-test: PromMemLeakTest improvement

do warmup with same nuber of requests and sleep before main test
section to prevent false positives

Type: test

Change-Id: Ie0ffbb27be58693f0c35c9a7ffed216ec4be1cb4
Signed-off-by: Matus Fabian <[email protected]>

http: h2 connect-udp for client apps

Type: improvement

Change-Id: Ib02f8494fe26be0abae8ceb4eba50866a2b08de1
Signed-off-by: Matus Fabian <[email protected]>

http: h2 connect for client apps

Type: improvement

Change-Id: If851b7802809f747b7613ba00c2ae31d944fb0d2
Signed-off-by: Matus Fabian <[email protected]>

hs-test: run containers wit --cap-add=SYS_PTRACE

otherwise you might not be able attach gdb to vpp running in container

Type: test

Change-Id: I4507971123ee67939b3a843916a6d523a2a09801
Signed-off-by: Matus Fabian <[email protected]>

http: format_http_transport_half_open fix

with postponed ho clenup underlying transport ho session might not
exist anymore

Type: fix

Change-Id: Iadb7f2b901d13e26f0d39bffcd11cdebc2f9357f
Signed-off-by: Matus Fabian <[email protected]>

hs-test: nsim loss rate test

Type: test

Change-Id: I592c755c7bdc5daf422655892b171c42f19e9a7c
Signed-off-by: Matus Fabian <[email protected]>

http: h2 free stream scheduler heads with conn

Type: fix

Change-Id: I1cddb7547d08a0668f6e536d77094911d9b26a6e
Signed-off-by: Matus Fabian <[email protected]>

linux-cp: fix multicast route updates on address add/del

Ensure multicast routes are only added when the first IPv4 address is configured on an interface,
and only removed when the last address is deleted.

This prevents premature removal or redundant addition of multicast routes during address changes.

Type: fix

Change-Id: Id191cd88abfc2c4c354fceec4aaabc030ed938cc
Signed-off-by: Denys Haryachyy <[email protected]>

vcl: atomics for tracking num workers in vls

Type: improvement

Change-Id: I272be20ae56e4bb8a25d754926d14e45460bd920
Signed-off-by: Florin Coras <[email protected]>

vcl: favor wr to vls_mt_spool_rwlock

Type: improvement

In a multi-thread single worker app, there can be contention between
many readers and the writers. The writers, which can be close operations
that potentially influence the app logic, could be starved if the
numbers of readers is significant.

To avoid this, always favor writers. Might require fine tuning in the
future.

Change-Id: I5ef529195a31114bb95e19e5880247f58d454370
Signed-off-by: Florin Coras <[email protected]>

hs-test: add nginx mirroring KinD test, cleanup

Type: test

Change-Id: I15e145023226ea0d442f69e42da4cdc586366873
Signed-off-by: Adrian Villin <[email protected]>

hs-test: containerize ginkgo

- ginkgo will run in a container
- replaced '--network=host' with '--network=container:ginkgo'
- removed --privileged flags
- removed network namespaces from HST
- updated goimports
- fixed state hashes

Type: improvement

Change-Id: I5f4c5aa93437f40b36a8eb2ba3d6486cdfe23e09
Signed-off-by: Adrian Villin <[email protected]>

hs-test: fix nsim interface in TcpWithLoss tests

Type: test

Change-Id: I94b3f052fa7a482083ae7459f1cfea067453c9b5
Signed-off-by: Matus Fabian <[email protected]>

hsa: cl udp app wait for pthreads to exit

Type: improvement

Change-Id: I31367de6fe3dde38d4379069b5c6fe589bd12e76
Signed-off-by: Florin Coras <[email protected]>

nsim: fix uninitialized variables

othervise user is not informed of missing parameter and demons fly out
of your nose

Type: fix

Change-Id: I54db587c99f193de1884fd7a0e292ae7128da5d7
Signed-off-by: Matus Fabian <[email protected]>

http: huffman decoder invalid EOS handling fix

Handle EOS longer than 7 bits

Type: fix

Change-Id: I4cb3ba37efe17dad9245c4d433eac987354d225c
Signed-off-by: Matus Fabian <[email protected]>

vlib: fix typo in ASAN stack size calculation

Type: fix

Change-Id: I771ca783854f704fc333a6dd857831ffe5d70bd3
Signed-off-by: Vladimir Zhigulin <[email protected]>

vlib: remove timer when sched node is dispatched by interrupt

Type: fix
Change-Id: I48a0da4a3af50101e2d2c1ed3cd8734b7e907f77
Signed-off-by: Damjan Marion <[email protected]>

http: validate h2 frame lengeth in handlers

Type: fix

Change-Id: I741a80a44c4355849e354c9b17d9213ac90a381d
Signed-off-by: Matus Fabian <[email protected]>

hs-test: h2 client memory leak test

Type: test

Change-Id: Ie8c49e84031d0da06c9770de25e94ff8166457f9
Signed-off-by: Matus Fabian <[email protected]>

http: starting http/2 with prior knowledge

Added flags member to transport_endpt_cfg_http_t where client app can
set HTTP_ENDPT_CFG_F_HTTP2_PRIOR_KNOWLEDGE when it want to use
HTTP/2 connection over cleartext TCP.

Type: improvement

Change-Id: Ib904a5cbdd34c6838d029a46c388e31a3329d399
Signed-off-by: Matus Fabian <[email protected]>

http: h2 client multiplexing

Type: improvement

Change-Id: I768df864cbda26b0901528789b52a33e788c2258
Signed-off-by: Matus Fabian <[email protected]>

http: h2 flow control improvement

resereve half of the app fifo size for headers to avoid full fifo when
first data frame is received

Type: improvement

Change-Id: I366b9a5495b3b6303125260b340b600fd212be58
Signed-off-by: Matus Fabian <[email protected]>

docs: correct deleting an interface ip address

The del keyword must be specified after ip address, not at the end
as the example shows.

DBGvpp# sh int addr
sh int addr
enp134s0f0np0/0 (up):
  L3 10.10.10.32/24
local0 (dn):
DBGvpp#  set interface ip address enp134s0f0np0/0 10.10.10.32/24 del
 set interface ip address enp134s0f0np0/0 10.10.10.32/24 del
set interface ip address: failed to add 10.10.10.32/24 on enp134s0f0np0/0 which conflicts with 10.10.10.32/24 for interface enp134s0f0np0/0
DBGvpp# sh int addr
sh int addr
enp134s0f0np0/0 (up):
  L3 10.10.10.32/24
local0 (dn):
DBGvpp#  set interface ip address del enp134s0f0np0/0 10.10.10.32/24
 set interface ip address del enp134s0f0np0/0 10.10.10.32/24
DBGvpp# sh int addr
sh int addr
enp134s0f0np0/0 (up):
local0 (dn):
DBGvpp#

Type: fix

Change-Id: Icd85cbbc5b149c67d411f837f0cd9b76beddc5b6
Signed-off-by: Steven Luong <[email protected]>

l2: stale cached value input->bd_seq_num

bd_seq_num is cached to l2_input_config to save a few cycles for lookup.
However, when the value is changed, we forgot to update the cache.

Type: fix
Fixes: 47a3d9975fa3af7a7537b565d6511dadc0df61fb

Change-Id: I553c61f4b072c74a6bc7fe1bf56d98ec881c833f
Signed-off-by: Steven Luong <[email protected]>

vcl: revert allow reads after transport cleanup

Type: fix
Fixes: 784410190eb96fa8dea9fa67a086aa0044fe9025

Change-Id: Iad0f083c4eceb9778f5dc8099c4a0da3fa230623
Signed-off-by: Florin Coras <[email protected]>

dpdk: bump to DPDK 25.07 and rdma-core 58.0

Type: feature
Change-Id: Ia9c378e144057128f123b2dc08c6f631c39f8e97
Signed-off-by: Jeff Shaw <[email protected]>

papi: fix deprecated call to setup.py

Type: fix
Change-Id: I0e5e61395b619e28cf75cde1770d631b47e8c0b7
Signed-off-by: Damjan Marion <[email protected]>

ip: common icmp echo structure

Move the replicated ICMP echo structure from the NAT implementations
to the common IP ICMP header.

Type: improvement
Change-Id: I3770d2609c2366859b014ae66096cd545f4b1262
Signed-off-by: Ole Troan <[email protected]>

session: set maximum memory for fifos

Add APP_OPTIONS_MAX_FIFO_MEMORY to set upper limit on how much memory
could be used by fifos. It is rounded upwards to nearest segment size.
If not specified, no limit is set.

Type: feature
Change-Id: I7fb87808973e761b7c40b734b18d55b8a8d8296e
Signed-off-by: Alexander Maltsev <[email protected]>

session: add new error MAX_STREAMS_HIT

Type: improvement

Change-Id: I2e5a153a30b566d7d20d8ceeec26b80075dfec80
Signed-off-by: Matus Fabian <[email protected]>

hsa: http client set connect_sep to null on init

Set connect_sep in http (cli) client to SESSION_ENDPOINT_CFG_NULL on
init to be sure that parrent_handle is invalid if not used.

Type: improvement

Change-Id: Ia42cbe8ea90402d20b07f933b5308642a098235f
Signed-off-by: Matus Fabian <[email protected]>

http: h2 coverity fix

Type: fix

Change-Id: Ib5ac44ae95a7e0c62830b8a93803312cbc875f88
Signed-off-by: Matus Fabian <[email protected]>

hs-test: h2 client testing with h2spec

Type: test

Change-Id: If588fa070adebb631bf71fc8c3e82a00ba628a69
Signed-off-by: Matus Fabian <[email protected]>

http: h2 client error handling improvement

Type: improvement

Change-Id: If989e6f1f2e23abae0214f467e8a285256ab1d17
Signed-off-by: Matus Fabian <[email protected]>

build: update openssl to 3.5.1 in vpp-opt-deps

Type: improvement

Change-Id: Ibe396e088c6d9620bbd2fdf85629de8c139ef650
Signed-off-by: Dave Wallace <[email protected]>

tls session: track internal tls objects in ckpair

Type: improvement

Change-Id: Ia38d355facd7af407a26c386327e8ea1a9aec116
Signed-off-by: Florin Coras <[email protected]>

session: remove unused attach options

- ACCEPT_COOKIE
- PRIVATE_SEGMENT_COUNT

They are not handled by session layer even if configured by
applications.

Type: improvement

Change-Id: I673f8da6e83181be018489b85082dfd1b1dab87b
Signed-off-by: Florin Coras <[email protected]>

hsa: http client send signal on transport reset

we don't need to wait for timeout

Type: improvement

Change-Id: I7aef2581c1ac48d4b147914ccae8aa5bedb363ca
Signed-off-by: Matus Fabian <[email protected]>

http: h2 client handle GOAWAY NO_ERROR

Type: improvement

Change-Id: I244528cdab03c3f17d17f98fd9182399b2ac6a17
Signed-off-by: Matus Fabian <[email protected]>

hsa: do not configure cert for tls ao

No need to configure cert for tls active opens as we don't support mtls
for now.

Type: improvement

Change-Id: Ied0a0152ec965e10f1a743a15188a4679ebb0b11
Signed-off-by: Florin Coras <[email protected]>

hsa: measure rtt in echo client

For TCP, rtt is extracted from transport info. For UDP & echo-bytes
option, we're measuring the time between sending & receiving the first
packet.
When using multiple clients, min/avg/max rtt values are displayed.

Type: improvement
Change-Id: I617527ca55726571638996dbcff05c2292f0ad18
Signed-off-by: Semir Sionek <[email protected]>

http: http2 client side

- only with TLS
- request are serialized within one app session (no multiplexing)
- http version can be specified in http client

Type: feature

Change-Id: I2fe11bd3252985d1bd1732616837f7a91f37f6a3
Signed-off-by: Matus Fabian <[email protected]>

virtio: add option to set interface name

Type: feature
Change-Id: I99421fc1f946e65a8e23a74c04593fe1ca4f4857
Signed-off-by: Damjan Marion <[email protected]>

tap: add option to specify interface name

Type: feature
Change-Id: If3f8b082a2750f2786724f0e55f501df3c7d4991
Signed-off-by: Damjan Marion <[email protected]>

hs-test: KinD cluster build script improvements

- new makefile targets, cleanup
- cluster can be rebuilt without shutting down

Type: improvement

Change-Id: I020e396a6410786ae29b9146a358d60503ac5662
Signed-off-by: Adrian Villin <[email protected]>

tls: fix cert and pkey leak

Free cert and pkey once assigned to make sure they're freed one the
ssl structs are freed.

Type: fix

Change-Id: I41546c8ae7bad169a1462b3b9a3807e4644a1c2c
Signed-off-by: Florin Coras <[email protected]>

hsa: http cli client improvement

notify http transport when body data is read and transport requested
notification (e.g. used by h2 flow control)

switch to new format of host and target path parsing

Type: improvement

Change-Id: Ie209f1e6fa244f44baa51b4e9a7c66b51b7e5a50
Signed-off-by: Matus Fabian <[email protected]>

quic: don't crash when no quic engine is available

- When there is no quic engine available, vpp crashes with an
  assert on startup which is not production friendly.
  Instead, emit warning message to stderr.
- Fix crash in session_transport_closing_notify if
  a remote closed notification happens on an invalid
  session in the quicly engine.
- Fix compilation errors when QUIC_DEBUG is set to 2
- Fix crash in 'show quic crypto context' command when
  quic engine is not present.
- Add quic engine type to 'show quic' output.

Type: fix

Change-Id: I83b9e69873fa3cd61d1d852b78ed1ccd2112825c
Signed-off-by: Dave Wallace <[email protected]>

hs-test: memleak tests fixes & json raport generation

Type: improvement
Change-Id: Ie2c18224d7073dd4821cb7716eb124f26dbe44ec
Signed-off-by: Semir Sionek <[email protected]>

hsa: http cli server add http1-only option

Type: improvement

Change-Id: I2d3656ee7e154a44efab7501399de4b1fc696dc7
Signed-off-by: Matus Fabian <[email protected]>

http: Tunneling UDP over HTTP/2

Type: feature

Change-Id: I94f6af893872ae28669b7b9c30d61e58c0b65422
Signed-off-by: Matus Fabian <[email protected]>

memif: avoid double-close of the socket on client abort with un-read data

In some cases, there are two times the clib_file_del is called:

1) from memif_disconnect -> memif_socket_close call site in memif_master_conn_fd_error
2) the supposedly defensive code at the end of memif_master_conn_fd_error.

This was observed upon using of an artisanal memif client, which did not correctly drain the data written by VPP to the notification socket - a simple Ctrl-C in the client was enough to trivially reproduce the issue.
In real world scenario using the stock client this is expected to be a fairly narrow race condition.

The issue can be demonstrated as follows:

diff --git a/src/vlib/file.c b/src/vlib/file.c
index 286b0d1f2..29138f485 100644
--- a/src/vlib/file.c
+++ b/src/vlib/file.c
@@ -200,6 +200,8 @@ epoll:
     {
       clib_file_t *f = e->data.ptr;
       clib_error_t *err;
+      clib_warning("EPOLL: count %d, fd index: %d, events: %x", n_fds_ready, f->index, e->events);
+

       if (PREDICT_FALSE (!f->active))
        {

vlib_file_poll:203: EPOLL: count 1, fd index: 6, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 11
memif_plugin       [error ]: memif0/0: default_socket_recvmsg: disconnected

Failing case, where the client did not drain the data sent to it:

DBGvpp# create interface memif master
DBGvpp# set int ip address memif0/0 192.0.2.1/24
DBGvpp# set interface state memif0/0 up
DBGvpp# vlib_file_poll:203: EPOLL: count 1, fd index: 6, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 1
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 4
vlib_file_poll:203: EPOLL: count 1, fd index: 7, events: 19
memif_plugin       [warn  ]: Error on unknown file descriptor 21
vlib/file          [error ]: vlib_file_update: epoll_ctl() failed, errno 9
/home/ayourtch/vpp/src/vppinfra/pool.h:291 (_pool_put_index) assertion `!pool_is_free_index (p, index)' fails
received signal SIGABRT, PC 0xffffa7f10a50

Type: fix
Change-Id: I13247c431605470c6a59d7d4630cefa999733107
Signed-off-by: Andrew Yourtchenko <[email protected]>

hs-test: fix go version mismatch

Type: test

Change-Id: Idce98c261c50ef0da2a4b7c4ee9146faa2194c4b
Signed-off-by: Matus Fabian <[email protected]>

arp: fix dump API

Add missing fib index to table id conversion in dump API.

Type: fix
Change-Id: Id5f7325ca31875abb39b33156f3938a051888ad3
Signed-off-by: Klement Sekera <[email protected]>

hs-test: fix install-kind-deps and kubeconfig path

Type: test

Change-Id: Ic9f883e510e275e862c700e4aae4630ad3dcfee8
Signed-off-by: Adrian Villin <[email protected]>

linux-cp: do not lock table when it's not needed

Do not lock table when lcp is not installing routes (e.g. zero nexthops
or ipv6 multicast routes), otherwise it will stay locked forever.

Type: fix

Signed-off-by: Stanislav Zaikin <[email protected]>
Change-Id: I4070ce0e0823b5afbd56c5cd79ae39a02c7d4300

fib: take barrier on LB pool put

Fixes ASAN crash after fib update with multiple
workers

Type: fix

Change-Id: I3d0112b608ffa5b5559311c6d494d27d6c1db511
Signed-off-by: Vladimir Zhigulin <[email protected]>

hs-test: use current VPP dir for CalicoVPP build

- make setup-cluster will use current VPP dir instead of CalicoVPP's dir
- VPP will be built only once
- changed build targets to build VPP as a non-root user (to avoid
  permission issues when building CalicoVPP)

Type: improvement

Change-Id: Iba90219660c1259da6ad81fe002f99b6d43ea248
Signed-off-by: Adrian Villin <[email protected]>

vlib: handle worker sync in wait one loop

Type: improvement

Change-Id: I8dcd9b7d305878eb385eb27481be6a241b4a024c
Signed-off-by: Florin Coras <[email protected]>

session: move app crypto to separate files

Type: refactor

Change-Id: Iac10665d3060e4c585e3ee1f94743809ab09d9db
Signed-off-by: Florin Coras <[email protected]>

session: cli to add/del collector to app

Type: improvement

Change-Id: Ie1ec27eab7d297f20ec7cad46d2e90b9965f896a
Signed-off-by: Florin Coras <[email protected]>