Jakub Grajciar [Thu, 14 Sep 2017 12:12:10 +0000 (14:12 +0200)]
libmemif: Jumbo frames support
Change-Id: I2b316358dcd2de7168a860541bcca35c3dd44649
Signed-off-by: Jakub Grajciar <grajciar.jakub@gmail.com>
dongjuan [Fri, 15 Sep 2017 02:21:07 +0000 (10:21 +0800)]
Modify return value of snat_out2in_lb(VPP-985)
in order to trace session_index
Change-Id: I4433155fbe21635f8a997523e2c7900c6a7569af
Signed-off-by: dongjuan <dong.juan1@zte.com.cn>
Damjan Marion [Mon, 11 Sep 2017 14:52:11 +0000 (16:52 +0200)]
clib_socket: add sendmsg / recvmsg with ancillary data support
Change-Id: Ie18580e05ec12291e7026f21ad874e088a712c8e
Signed-off-by: Damjan Marion <damarion@cisco.com>
Matus Fabian [Thu, 14 Sep 2017 06:00:53 +0000 (23:00 -0700)]
NAT: fixed bug in snat_alloc_outside_address_and_port (VPP-981)
generated random ports overlap between threads
Change-Id: I7a13785e3f98b87e475426b0bd7f6bf2d9c1336c
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Keith Burns (alagalah) [Tue, 12 Sep 2017 22:12:17 +0000 (15:12 -0700)]
Stats refactor
- added per-interface simple/combined counters
- refactored fib/nbr API to use common registration scheme
- refactored "want_stats" and "want_interface" to use
per interface registration scheme
- fixed issues with SEGV when client disconnects abruptly.
Change-Id: Ib701bd8e4105d03548259217bfc809bd738b7c72
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Jakub Grajciar [Wed, 30 Aug 2017 08:13:25 +0000 (10:13 +0200)]
Shared memory packet interface (memif) library
Change-Id: I5097462ae85acd705f19e92517c01094dba7565f
Signed-off-by: Jakub Grajciar <grajciar.jakub@gmail.com>
Florin Coras [Wed, 13 Sep 2017 00:24:00 +0000 (20:24 -0400)]
gpe: initialize fib index for native forward entries
Change-Id: I972e6e645c3ae9cba4bb2b4e32c0272dfd67e87b
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Tue, 12 Sep 2017 16:45:04 +0000 (09:45 -0700)]
Add a name to the creation of an IP and MPLS table
Change-Id: I4b4648831551519b2ffb6f93255d28a4b8726c22
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Barach [Tue, 12 Sep 2017 21:06:56 +0000 (17:06 -0400)]
API message table inspection utilities
Add doxygen tags for show/clear commands
Change-Id: Ic939c561b15b0b720a8db1ecacc17e3d74419e1d
Signed-off-by: Dave Barach <dave@barachs.net>
Steven [Wed, 13 Sep 2017 13:18:46 +0000 (06:18 -0700)]
devices: Fix coverity discovered 9/13/2017
Missing a break statement in the case
Change-Id: I1b1e198748343bc116ee0eaf9012abc3be15c40a
Signed-off-by: Steven <sluong@cisco.com>
flyingeagle23 [Fri, 8 Sep 2017 07:32:59 +0000 (15:32 +0800)]
lb_vip_command_fn param redundancy when unformat ip address(VPP-977)
Change-Id: I92de5b9ed42cda6c0438b8dc71892d322b642a70
Signed-off-by: flyingeagle23 <wang.hui56@zte.com.cn>
Ole Troan [Wed, 13 Sep 2017 07:28:48 +0000 (09:28 +0200)]
STATS: Refactor missed adding messages to CRC dictionary.
Change-Id: I0d74856d4fd999dd9ca5886b8375ab8dd700b8a9
Signed-off-by: Ole Troan <ot@cisco.com>
flyingeagle23 [Wed, 13 Sep 2017 11:03:56 +0000 (19:03 +0800)]
nat lb: del lb static mapping existed vec mem leak(VPP-983)
Change-Id: Id7306b432a33bb0fa594b6949e65ca528d8c0916
Signed-off-by: flyingeagle23 <wang.hui56@zte.com.cn>
Dave Barach [Wed, 13 Sep 2017 13:18:08 +0000 (09:18 -0400)]
VPP-972: fix coverity warnings in the stats scraper
Change-Id: I8843e57105c6c29bcdaf1e6e3bf8e9caf6bfd2ec
Signed-off-by: Dave Barach <dave@barachs.net>
Ole Troan [Thu, 31 Aug 2017 11:18:44 +0000 (13:18 +0200)]
VPP-960: Python API add more information in exception for invalid arguments to API calls.
Change-Id: I266eef8419fd98b9b900573ac9b032a62600ab86
Signed-off-by: Ole Troan <ot@cisco.com>
Thomas F Herbert [Tue, 29 Aug 2017 20:07:51 +0000 (16:07 -0400)]
Add option to build without multi-buffer crypto.
JIRA VPP-498
This patch also allows RPMs to be built without multi-
buffer crypto for some RPM based downstream distros that
don't have sufficiently new nasm or don't have an USA
export license for multi-buffer crypto.
The default is to build WITH multi-buffer crypto
for x86-64. This patch allows optional building without
multi-buffer crypto.
To build without multi-buffer crypto, set the AESNI
environment variable to n.
To build rpm packages without multi-buffer crypto,
build the rpms with the option turned off.
make build AESNI=n
or..
make pkg-rpm --without aesni
---How to test this patch on a Centos build.---
Build as above and verify that nasm isn't executed during
the build process.
vpp may be installed and the dpdk plugin may be inspected to
verify that the multi-buffer code isn't present.
Change-Id: I8c5cfd4cdd9eb2b96772a687eaa54560806e001b
Signed-off-by: Thomas F Herbert <therbert@redhat.com>
Damjan Marion [Tue, 12 Sep 2017 13:34:17 +0000 (15:34 +0200)]
physmem: remove debug leftovers
Change-Id: I5a5dc0794d3398e749b64b07dfd1e2fc2230089b
Signed-off-by: Damjan Marion <damarion@cisco.com>
Matus Fabian [Tue, 12 Sep 2017 11:15:30 +0000 (04:15 -0700)]
NAT: fixed bug in snat_alloc_outside_address_and_port (VPP-981)
Change-Id: I6c5eccd4193c44604da3fd27c108defe71b38a4b
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Florin Coras [Tue, 5 Sep 2017 18:03:37 +0000 (14:03 -0400)]
tcp: horizontal scaling improvments
- do not scale syn-ack window
- fix the max number of outstanding syns in builtin client
- fix syn-sent ack validation to use modulo arithmetic
- improve retransmit timer handler
- fix output buffer allocator leakeage
- improved debugging
Change-Id: Iac3bc0eadf7d0b494a93e22d210a3153b61b3273
Signed-off-by: Florin Coras <fcoras@cisco.com>
Steven [Thu, 27 Jul 2017 21:54:44 +0000 (14:54 -0700)]
devices: Display VhostEthernet instead of UnknownEthernet for dpdk net_vhost driver
Added a new macro VNET_DPDK_PORT_TYPE_VHOST_ETHER for dpdk net_vhost driver
to display VhostEthernet instead of UnknownEthernet.
Change-Id: Ie407d83ebbbd60e4d11be79f0ebc44e2867a5f3b
Signed-off-by: Steven <sluong@cisco.com>
Shachar Beiser [Mon, 11 Sep 2017 08:06:18 +0000 (08:06 +0000)]
net/mlx5: fix warning message
Add support for Mellanox provider id and vendor id
Change-Id: Ib2451e69fbe949f01bcb1ee556aa3020da225610
Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
flyingeagle23 [Tue, 12 Sep 2017 07:10:46 +0000 (15:10 +0800)]
Fix issue in nat Bisearch algorithm (VPP-980)
Change-Id: I39b1d1ec6fb9a10e2a0e67d36b01c0bf2522d07f
Signed-off-by: flyingeagle23 <wang.hui56@zte.com.cn>
Andrew Yourtchenko [Mon, 11 Sep 2017 15:22:03 +0000 (17:22 +0200)]
acl-plugin: add startup-config section "acl-plugin" and heap/hash parameters
This adds the ability to tweak the memory allocation parameters of the ACL plugin
from the startup config. It may be useful in the cases involving higher limit
of the connections than the default 1M, or the high number of cores.
Change-Id: I2b6fb3f61126ff3ee998424b762b6aefe8fb1b8e
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
flyingeagle23 [Mon, 11 Sep 2017 08:02:40 +0000 (16:02 +0800)]
nat lb mapping command existed array out of bounds(VPP-979)
Change-Id: Id1dce0c2eebd4097bc17842f050453b76a94eb70
Signed-off-by: flyingeagle23 <wang.hui56@zte.com.cn>
Pavel Kotucek [Thu, 7 Sep 2017 06:17:31 +0000 (08:17 +0200)]
ACL-plugin add "replace" semantics for adding a new MacIP acl
Change-Id: Ia5c869b2d8b8ad012b9e89fb6720c9c32d9ee065
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
Neale Ranns [Mon, 11 Sep 2017 17:34:33 +0000 (10:34 -0700)]
replace uint32_t with u32
Change-Id: I6cab79c266837a8731adcf78c9e093dfa6be0ead
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Fri, 8 Sep 2017 20:22:38 +0000 (16:22 -0400)]
arp/glean: fix hash computation
Change-Id: Ifef8a9328bb865f6ddb041bafe3699153f89755a
Signed-off-by: Florin Coras <fcoras@cisco.com>
Colin Tregenza Dancer [Wed, 6 Sep 2017 19:23:24 +0000 (20:23 +0100)]
Recombine diags and minimum barrier open time changes (VPP-968)
Support logging to both syslog and elog
Also include DaveB is_mp_safe fix, which had been lost
Change-Id: If82f7969e2f43c63c3fed5b1a0c7434c90c1f380
Signed-off-by: Colin Tregenza Dancer <ctd@metaswitch.com>
Steven [Fri, 8 Sep 2017 22:40:32 +0000 (15:40 -0700)]
memif: mode ip is not settable from binary API
While mode ip is supported via the CLI for creating a memif interface,
it is not settable from the binary API due to missing code.
While at it, update the help usage to include the missing keyword secret.
Change-Id: Ia9c71f4017210a5e1733ce4992fbb566b7d20c1a
Signed-off-by: Steven <sluong@cisco.com>
Neale Ranns [Sun, 10 Sep 2017 11:39:11 +0000 (04:39 -0700)]
FIB table add/delete API
part 2;
- this adds the code to create an IP and MPLS table via the API.
- but the enforcement that the table must be created before it is used is still missing, this is so that CSIT can pass.
Change-Id: Id124d884ade6cb7da947225200e3bb193454c555
Signed-off-by: Neale Ranns <nranns@cisco.com>
Brian Brooks [Wed, 6 Sep 2017 18:19:48 +0000 (13:19 -0500)]
Improved arm64 chip detection
Use ARMv8 Main ID Register (exposed thru /proc/cpuinfo) to identify
the CPU implementor and part number. For further details, see the
ARMv8 ARM D7.2.66.
Change-Id: I2b0d0b165cda4ab9fc57c645af90e9e354b73f44
Signed-off-by: Brian Brooks <brian.brooks@arm.com>
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Signed-off-by: Ola Liljedahl <ola.liljedahl@arm.com>
Reviewed-by: Song Zhu <song.zhu@arm.com>
Matus Fabian [Mon, 11 Sep 2017 05:17:47 +0000 (22:17 -0700)]
NAT: fixed hairpinning for in2out translation as an output feature (VPP-976)
Test whether the hairpinning flag is set only for packets from NAT inside interface.
Change-Id: I4a4fdd2084a76a70ce9dfe3e2b8332c02fa2eccd
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Damjan Marion [Fri, 8 Sep 2017 17:52:02 +0000 (19:52 +0200)]
move unix_file_* code to vppinfra
This will allow us to use this code in client libraries without vlib.
Change-Id: I8557b752496841ba588aa36b6082cbe2cd1867fe
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 8 Sep 2017 17:21:00 +0000 (19:21 +0200)]
physmem: make fake allocation non-fatal if we cannot pick numa node
Change-Id: I563c043ed82e3ef199fc3d47931108f31cc01728
Signed-off-by: Damjan Marion <damarion@cisco.com>
Keith Burns (alagalah) [Fri, 8 Sep 2017 17:58:44 +0000 (10:58 -0700)]
gitignore update for IDE
Change-Id: I95096e8d507f9bcb0f808d0da0355655b474d29a
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
dongjuan [Thu, 7 Sep 2017 06:58:56 +0000 (14:58 +0800)]
Initialize ip4_reass_lock of map_main to zero (VPP-975)
Change-Id: I0f58100a944e36f5b530101178303d4595b3207f
Signed-off-by: dongjuan <dong.juan1@zte.com.cn>
Gabriel Ganne [Wed, 6 Sep 2017 08:44:07 +0000 (10:44 +0200)]
add apr-devel to rpm dependency list for centos-7
Error mesasge:
...
rpmbuild -bb \
--define "_topdir /home/gannega/vpp" \
--define "_version 17.10" \
--define "_release rc0~269_g030ab48" \
vpp.spec
error: Failed build dependencies:
apr-devel is needed by vpp-17.10-rc0~269_g030ab48.x86_64
Change-Id: I7c09b65dcc9e57cae3da396c0165b8a4c85a8c2b
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
Damjan Marion [Fri, 8 Sep 2017 10:26:12 +0000 (12:26 +0200)]
vlib: move linux-specific code to vlib/linux
Change-Id: Id79d2c2be7a98e15416a537c890a8f2dd6d4464d
Signed-off-by: Damjan Marion <damarion@cisco.com>
Marco Varlese [Fri, 8 Sep 2017 08:40:34 +0000 (10:40 +0200)]
PUNT: Missing include for readv()
The missing header include was generating a compile-time error;
src/vnet/ip/punt.c:460:10: error: implicit declaration of function 'readv'
Change-Id: I3f74294e7824ea3602b8d416c86fdada1aac1906
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Steven [Thu, 7 Sep 2017 16:20:56 +0000 (09:20 -0700)]
memif: fix coverity warnings as of 9/7
1. coverity complains about "buffer not null terminated" for strncpy because we
pass the size of the destination to the call which is equal to the true size
of the destination. We subtract 1 for the size to accommodate the null like all
other places are already doing it.
2. Add a check to tx_queues in memif_interface_tx_inline to avoid "divide by zero".
3. To avoid null pointer dereference in memif_create_if, change the goto done
rather than goto error and spit a more meaningful error rather than silent about it.
4. Shuffle a line to avoid "check after use" in vl_api_memif_delete_t_handler.
Change-Id: Icba7ecd5362c012a48ac35795d31aab356617420
Signed-off-by: Steven <sluong@cisco.com>
Pavel Kotucek [Thu, 7 Sep 2017 12:44:52 +0000 (14:44 +0200)]
ACL-plugin MACIP ACLs tests
Change-Id: Ie40c837358454cfe9475cb2c14fdf20b24fa6602
Signed-off-by: Pavel Kotucek <pkotucek@cisco.com>
Andrew Yourtchenko [Thu, 7 Sep 2017 11:49:07 +0000 (13:49 +0200)]
acl-plugin: add hitcount to applied hash-acl entries
Add a counter incremented upon the ACL check,
so it is easier to see which kind of traffic
is being checked by the policy, add the corresponding
output to the debug CLI "show acl-plugin tables" command.
Change-Id: Id811dddf204e63eeceabfcc509e3e9c5aae1dbc8
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Dave Wallace [Wed, 6 Sep 2017 05:59:43 +0000 (01:59 -0400)]
Fix socket_test.sh vagrant based multi-host tests.
Change-Id: I8ef75a0c702098030c6814c127d3443820122327
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Chris Luke [Thu, 7 Sep 2017 11:40:13 +0000 (07:40 -0400)]
Fixes for issues reported by Coverity (VPP-972)
Change-Id: I25238debb7081b4467aec4620dfdef33fbef3295
Signed-off-by: Chris Luke <chrisy@flirble.org>
Keith Burns (alagalah) [Sun, 6 Aug 2017 15:26:29 +0000 (08:26 -0700)]
Allow individual stats API and introduce stats.api
- want_interface_simple_stats
- want_interface_combined_stats
- want_ip4|6_fib|nbr_stats
Change-Id: I4e97461def508958b3e429c3fe8859b36fef2d18
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Damjan Marion [Thu, 20 Jul 2017 16:10:35 +0000 (18:10 +0200)]
vlib physmem rework
This patch adds supprot support for multiple numa-aware physmem regions.
Change-Id: I5c69a6f4da33c8ee21bdb8604d52fd2886f2327e
Signed-off-by: Damjan Marion <damarion@cisco.com>
Filip Tehlar [Mon, 4 Sep 2017 16:54:33 +0000 (18:54 +0200)]
LISP: add neighbor discovery and CP protocol separation APIs
Change-Id: Ia2fc4621f0e199b0d02ac4d2104b54bdb49c14dd
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Filip Tehlar [Wed, 6 Sep 2017 08:07:39 +0000 (10:07 +0200)]
LISP: Add APIs for enable/disable xTR/P-ITR/P-ETR modes
Change-Id: Ieeb3b7eaabb568180320fe54d3eae2d26f3e4704
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Marco Varlese [Sun, 3 Sep 2017 17:04:46 +0000 (19:04 +0200)]
The missing variable (added with this patch) was causing the build on AARCH64
platforms to default to lib (instead of lib64) when not explicitely defining
the --libdir through the configure script.
This patch fixes that.
Change-Id: Ia4c152e0f40acab7f098885d672ff9385f57b0fe
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Steven [Sun, 30 Jul 2017 17:29:26 +0000 (10:29 -0700)]
Devices: Set interface rx-mode may cause SIGSEGV with nonexistent queue
When I type in set interface rx-mode with a nonexistent queue, I got a crash with the following
traceback. It looks like the vm is NULL when vlib_node_get_runtime is called.
DBGvpp# sh int rx
Thread 0 (vpp_main):
node dpdk-input:
TenGigabitEthernet5/0/0 queue 0 (polling)
TenGigabitEthernet5/0/1 queue 0 (polling)
TenGigabitEthernet7/0/0 queue 0 (polling)
TenGigabitEthernet7/0/1 queue 0 (polling)
node vhost-user-input:
VirtualEthernet0/0/2 queue 0 (adaptive)
DBGvpp# set interface rx-mode VirtualEthernet0/0/2 queue 1 polling
Thread 1 "vpp_main" received signal SIGSEGV, Segmentation fault.
0x00007ffff6d4e0bc in vlib_node_get_runtime (vm=0x0, node_index=125)
at /home/sluong/vpp/build-data/../src/vlib/node_funcs.h:92
92 vlib_node_t *n = vec_elt (nm->nodes, node_index);
(gdb) where
at /home/sluong/vpp/build-data/../src/vlib/node_funcs.h:92
at /home/sluong/vpp/build-data/../src/vlib/node_funcs.h:112
vnm=0x6f0fa0 <vnet_main>, hw_if_index=7, queue_id=1, mode=0x7fffb62099e8)
at /home/sluong/vpp/build-data/../src/vnet/devices/devices.c:307
hw_if_index=7, queue_id=1, mode=VNET_HW_INTERFACE_RX_MODE_POLLING)
at /home/sluong/vpp/build-data/../src/vnet/interface_cli.c:1192
vm=0x7ffff7b9d440 <vlib_global_main>, input=0x7fffb6209ef0,
cmd=0x7fffb61d5d14)
at /home/sluong/vpp/build-data/../src/vnet/interface_cli.c:1288
vm=0x7ffff7b9d440 <vlib_global_main>,
cm=0x7ffff7b9d630 <vlib_global_main+496>, input=0x7fffb6209ef0,
parent_command_index=18)
at /home/sluong/vpp/build-data/../src/vlib/cli.c:588
vm=0x7ffff7b9d440 <vlib_global_main>,
cm=0x7ffff7b9d630 <vlib_global_main+496>, input=0x7fffb6209ef0,
parent_command_index=12)
The fix is to add a check for vec_len(hw->input_node_thread_index_by_queue)
and vec_len (hw->rx_mode_by_queue) to reject the command if the queue_id is
out of bound. While at it, I notice inputting queue_id=-1 is being interpreted
as all queues. An easy fix is to not overload the queue_id variable with -1 to
mean something else.
Change-Id: Id70ec3e7d06ccc67635e6d28ef53420bdac4a988
Signed-off-by: Steven <sluong@cisco.com>
Andrew Yourtchenko [Thu, 7 Sep 2017 11:22:24 +0000 (13:22 +0200)]
test: factor out "L4_Conn" into a class within util.py (VPP-931)
It seems a useful abstraction for the purposes of writing
fine-grained tests, to be able to create a "connection" object
which would be bound to two VPP interfaces, and hold some
information about the state, allowing to send the packets
back and forth with minimal amount of arguments.
Change-Id: Idb83b6b82b38bded5b7e1756a41bb2df4cd58e3a
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Matus Fabian [Thu, 7 Sep 2017 10:50:49 +0000 (03:50 -0700)]
NAT: fixed bug in snat_get_worker_out2in_cb (VPP-832)
Change-Id: Id9c977634a1259865e3403ba0d90aecaca85207d
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Jan Gelety [Wed, 6 Sep 2017 07:24:44 +0000 (09:24 +0200)]
Update CSIT tests 170814 -> 170906
- update of CSIT operational branch to be used for VPP-patch test
Change-Id: I23c6b5cb9bab6e295ff145531eabc2d51df49a94
Signed-off-by: Jan Gelety <jgelety@cisco.com>
Andrew Yourtchenko [Thu, 10 Aug 2017 15:02:58 +0000 (17:02 +0200)]
acl-plugin: match index set to first portrange element if non-first portrange matches on the same hash key (VPP-937)
Multiple portranges that land on the same hash key will always report the match
on the first portrange - even when the subsequent portranges have matched.
Test escape, so make a corresponding test case and fix the code so it passes.
(the commit on stable/1707 has erroneously mentioned VPP-938 jira ticket)
Change-Id: Idbeb8a122252ead2468f5f9dbaf72cf0e8bb78f1
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
(cherry picked from commit
fb088f0a201270e949469c915c529d75ad13353e)
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Ole Troan [Thu, 7 Sep 2017 08:04:41 +0000 (10:04 +0200)]
Punt socket: Fix coverity error for pathname length mismatch between API and sun_path.
Change-Id: I69d67707540e075afe7bad0a70e57d9d80b1bc8e
Signed-off-by: Ole Troan <ot@cisco.com>
Dave Wallace [Wed, 6 Sep 2017 20:45:04 +0000 (16:45 -0400)]
Add fd/socket name to clib_socket_* error msgs.
Change-Id: Ifcc9df04e7b224dfc9e9be53a30df5bbccbe05b4
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Dave Wallace [Wed, 6 Sep 2017 05:20:02 +0000 (01:20 -0400)]
Fix session connect_* api message handling.
Change-Id: If7fd125989c90240de12953658d10007b9eb4f07
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Jerome Tollet [Tue, 5 Sep 2017 11:13:22 +0000 (12:13 +0100)]
Support for bridge domain free text tag
Change-Id: I9a75fdafd0c1d87b6f071fda5b77ff5f6b79deb7
Signed-off-by: Jerome Tollet <jtollet@cisco.com>
Florin Coras [Tue, 5 Sep 2017 23:15:49 +0000 (16:15 -0700)]
make test: disable L2BD Multi-instance test 5
Change-Id: Iba44aec60a74ada5add41ecf00b25dc44f3ad3a3
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Wallace [Thu, 31 Aug 2017 19:54:11 +0000 (15:54 -0400)]
Set uid/gid on ssvm segment file.
Change-Id: I482bb9654f4dfe240bace5c2b61056cfd04cf018
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Dave Barach [Fri, 1 Sep 2017 23:12:11 +0000 (19:12 -0400)]
Improve "show segment-manager segments"
Clean up private-segment fifo preallocation
Change-Id: I53c630ed81d48f2832a204992d73635536926983
Signed-off-by: Dave Barach <dave@barachs.net>
Chris Luke [Tue, 5 Sep 2017 15:59:55 +0000 (11:59 -0400)]
Fixes for issues raised by Coverity (VPP-972)
Change-Id: I4b1f27b95d67d48b7a13750ff8754c344ed7afa7
Signed-off-by: Chris Luke <chrisy@flirble.org>
Matus Fabian [Mon, 4 Sep 2017 09:17:18 +0000 (02:17 -0700)]
NAT: Destination NAT44 with load-balancing (VPP-954)
added load-balancing static mappings with unequal load support
Change-Id: Ie505e41f24d46f812b94dd28bdafe3dc170a6060
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Sergio Gonzalez Monroy [Tue, 5 Sep 2017 12:47:21 +0000 (13:47 +0100)]
dpdk/ipsec: fix setup when using master core only
Change-Id: I62b7aa896dfe218358f11a5197b1228a3dd67152
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Pierre Pfister [Fri, 28 Jul 2017 02:57:34 +0000 (22:57 -0400)]
Add pidfile cmdline option
Change-Id: Ibaa61b624eb6683b1be6901a7b29f5f73aad27b2
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
Colin Tregenza Dancer [Mon, 4 Sep 2017 14:27:49 +0000 (15:27 +0100)]
Refork worker thread data structures in parallel (VPP-970)
Change the rebuilding of worker thread clone datastructures
to run in parallel on the workers, instead of serially
on main.
Change-Id: Ib76bcfbef1e51f2399972090f4057be7aaa84e08
Signed-off-by: Colin Tregenza Dancer <ctd@metaswitch.com>
Ole Troan [Tue, 16 May 2017 12:59:29 +0000 (14:59 +0200)]
PUNT socket: External control plane processes connected via UNIX domain sockets.
An external (to VPP) process can register (over the VPP binary API) to
receive control plane packets over a UNIX domain socket. The packets are
prepended with a packet descriptor containing meta-data (if_index of
interface, etc).
Currently only UDP is supported.
The socket supports sending of packets/frames as well.
The sent packet is prepended with a descriptor, telling VPP to
route the packet (via ip4-lookup, ip6-lookup) or as an pre-formed
Ethernet frame that is sent directly to interface-output.
The intended use case for this is for an external DHCP client or
a RIP implementation.
New configuration option:
punt { socket <socket path> }
To register use the punt_socket API message.
TODO:
- Add support for pre-routing. I.e send L3 packet to given
TX interface, but do ARP/ND (ip[46]-rewrite)
- Add test scripts
- Support for abstract names (starting with \0)
- Add rate limiting (COP)
- Support for other protocols, e.g. IPv6 ND
Change-Id: I4a0afc8020deebb3d9d74686dde694ee5bcb8d0f
Signed-off-by: Ole Troan <ot@cisco.com>
Filip Tehlar [Mon, 14 Aug 2017 17:15:36 +0000 (19:15 +0200)]
LISP: re-fetch mapping before it expires
Change-Id: I0581a1bddad55d8d573c546ec84b0b2760abab3d
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
John Lo [Sat, 2 Sep 2017 12:27:36 +0000 (08:27 -0400)]
Improve L2FIB PDR/NDR performance (VPP-963)
1. Limit MAC entry update per l2-learn call to reduce update burst
when wall clock advance to the the next minute so all MAC time
stamps are behind current time needing update.
2. Optimize l2-learn node fast path code sequence.
3. Invalidate cache_key when update MAC entry.
4. Change L2 learn hit counter to L2 learn hit-update counter.
5. Increase L2FIB table memory size to 512MB to fit 4M entries
6. Set MAC learn limit at 4M entries
Change-Id: I3075ee8fb59645a56850126bac2e3e6d341cef4d
Signed-off-by: John Lo <loj@cisco.com>
Marco Varlese [Fri, 1 Sep 2017 12:47:53 +0000 (14:47 +0200)]
The build system still builds the DPDK plugin when the option
vpp_uses_dpdk is set to "no" in build-data/platforms/vpp.mk causing the
build to fail.
This patch addresses that issue.
Change-Id: Icc1aaa508e730c9b8715119e1259e4c82f974048
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Dave Barach [Tue, 29 Aug 2017 15:43:37 +0000 (11:43 -0400)]
Add fixed-size, preallocated pool support
Simply call pool_init_fixed(...) before using the pool. Note that
fixed, preallocated pools live in individually-mmap'ed address
segments, except for the free element bitmap. A large fixed pool can
exceed 4gb.
Fix tcp buffer allocator leak, remove broken assert
Change-Id: I4421082e12a77c41c6e20f7747f3150dcd01fc26
Signed-off-by: Dave Barach <dave@barachs.net>
Ole Troan [Thu, 31 Aug 2017 10:59:43 +0000 (12:59 +0200)]
VPP-959: Python API require minimum CFFI version.
Change-Id: I328689b7d4efe6017412de43630a5e9f3633dd71
Signed-off-by: Ole Troan <ot@cisco.com>
Sergio Gonzalez Monroy [Thu, 31 Aug 2017 14:12:00 +0000 (15:12 +0100)]
dpdk/ipsec: update doc regarding startup.conf
Change-Id: Ie449072ab1efec081235b508f1def60a1287ff5f
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Steven [Sat, 29 Jul 2017 15:56:08 +0000 (08:56 -0700)]
vhost: Disallow interrupt mode config if driver opts out interrupt support
According to the spec, supporting interrupt mode from the driver is optional,
not a must. When interrupt mode is configured on the interface, we should
check to make sure that the driver didn't opt out for the kickfd support and
reject the configuration if it did.
Change-Id: I7d3dbaddde65458e1a6a802754a3768ae8685a0e
Signed-off-by: Steven <sluong@cisco.com>
Thomas F Herbert [Thu, 31 Aug 2017 14:22:57 +0000 (10:22 -0400)]
Add explicit check for Fedora.
Change-Id: I0a5aece190ccc82f0f840e3bc75e1d27433f5b47
Signed-off-by: Thomas F Herbert <therbert@redhat.com>
Damjan Marion [Thu, 31 Aug 2017 09:33:34 +0000 (11:33 +0200)]
Do arithemtric comparison in Makefile without using bc
Change-Id: I245f56814ba3911b832e7450d42c58f235bc6dc2
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 31 Aug 2017 09:23:10 +0000 (11:23 +0200)]
Revert "add bc to dependency list"
Adding new dependency is not right solution to this problem.
This reverts commit
e58c93b2764eb306d286531a2b920c6de080cb77.
Change-Id: I08f2af5cf9c26c4302b0dbaccebbb52f0614f80f
Signed-off-by: Damjan Marion <damarion@cisco.com>
Dave Barach [Thu, 31 Aug 2017 09:58:22 +0000 (05:58 -0400)]
Fix BIHASH_KVP_CACHE_SIZE == 0 case
Setting the bucket-level LRU cache size to zero removes the
bucket-level LRU cache code.
Change-Id: Idf2e63d0d508675e957366515863766f79a3479c
Signed-off-by: Dave Barach <dbarach@cisco.com>
Brian Brooks [Mon, 28 Aug 2017 18:05:26 +0000 (13:05 -0500)]
Native arm64 build: dpdk/Makefile change
With this change, the status of `make build':
Huawei D02, Linux 4.4.0, gcc 5.4.1 - success
AMD Seattle, Linux 4.4.6, gcc 5.3.1 - compiler ICEs
Cavium ThunderX, Linux 4.4.49, gcc 5.4.0 - success
Before:
Huawei D02, Linux 4.4.0, gcc 5.4.1 - fail
AMD Seattle, Linux 4.4.6, gcc 5.3.1 - fail
Cavium ThunderX, Linux 4.4.49, gcc 5.4.0 - success
Change-Id: I49db34a33f9ca0725c7511d4f796706892b5b2da
Signed-off-by: Brian Brooks <brian.brooks@arm.com>
dongjuan [Thu, 31 Aug 2017 06:57:54 +0000 (14:57 +0800)]
Fix vent_data memory leak in function run_ping_ip46_address (VPP-966)
Change-Id: I05d0c8310aa86480a3d283f45e115284c4b4ebd5
Signed-off-by: dongjuan <dong.juan1@zte.com.cn>
Damjan Marion [Wed, 30 Aug 2017 15:12:25 +0000 (17:12 +0200)]
Set runtime_path properly when running non-root
non-root users should use /run/user/$PID/...
Change-Id: I1ca136df7a339eff193ed9c9a396d6965b192d0e
Signed-off-by: Damjan Marion <damarion@cisco.com>
ShenJibiao [Thu, 31 Aug 2017 05:57:48 +0000 (13:57 +0800)]
Free memory the 'rpaths' pointers, that may incur memory leaks(VPP-965).
Change-Id: I2732c02b97f4602162638bbcf3ab46521c2782da
Signed-off-by: ShenJibiao <shen.jibiao@zte.com.cn>
Keith Burns (alagalah) [Wed, 30 Aug 2017 21:06:52 +0000 (14:06 -0700)]
Improvements to socket_test.sh script
Change-Id: I10c59dc32edb7336a56722b1de8cca1d0ae31c60
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Gabriel Ganne [Wed, 30 Aug 2017 17:44:56 +0000 (19:44 +0200)]
add bc to dependency list
replace $(echo "..." | bc) by `echo ... | bc` as they do not seem to
behave the same way.
Change-Id: Ib8f13f0c8213aaae89d65559427e01bc40f4e8d1
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
Damjan Marion [Mon, 28 Aug 2017 22:15:35 +0000 (00:15 +0200)]
Thread safe internal buffer manager, take two
First attempt to make internal buffer manager thread safe was not
succesfull, so trying again. This time with more testing.
Change-Id: I01b8385a9c26d233934a3339255ea4bd31c865ac
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Tue, 29 Aug 2017 21:50:13 +0000 (14:50 -0700)]
tcp: re-enable persist timer if no data available to send
Additionally, flush rx fifos for closed sessions.
Change-Id: If2cc563fbda0451e7572650e98b15f0a694a0ff9
Signed-off-by: Florin Coras <fcoras@cisco.com>
Dave Barach [Wed, 30 Aug 2017 12:14:03 +0000 (08:14 -0400)]
Offload prep calls needed for IP and UDP checksum offload pkts
Change-Id: I9b29bcff348bddfb49b1c38b1d409249e37bb075
Signed-off-by: Dave Barach <dave@barachs.net>
Steven [Tue, 29 Aug 2017 16:23:26 +0000 (09:23 -0700)]
vhost: Cache qsz_mask instead of qsz in vhost_user_vring_t
In the data path, we grab qsz from vhost_user_vring_t to compute
qsz_mask and store it in a stack variable to use on many occasions.
We never use qsz for any meaningful purpose. It is more useful to
cache qsz_mask in vhost_user_vring_t to avoid the needless computation
in the data path.
Change-Id: Idf4d94a9754d5c75c899f1f4f59602275b9904a6
Signed-off-by: Steven <sluong@cisco.com>
Hongjun Ni [Tue, 29 Aug 2017 16:55:59 +0000 (00:55 +0800)]
Fix static mapping lookup issue for NAT plugin
Change-Id: Ic99d1db5360f69126b23bb2b78f29d6404cbbae9
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
Hongjun Ni [Tue, 29 Aug 2017 12:39:42 +0000 (20:39 +0800)]
Fix some issue of comment and help for nat feature
Change-Id: I9233e427b5f8874492fefb2bfe7c1ab329e366b2
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
Keith Burns (alagalah) [Tue, 29 Aug 2017 18:16:32 +0000 (11:16 -0700)]
Add .pybuild to gitignore
Change-Id: I4467a30ec1beff67a0517619296f1a27589ff55b
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Florin Coras [Thu, 17 Aug 2017 02:55:49 +0000 (19:55 -0700)]
session: segment manager improvements
- cleanup connects segment manager even if first
- fix segment manager allocation for listen sessions
- improve handling of process private segments (mheaps/main heap)
- added segment manager cli
Change-Id: Ic2ca97c3622ab2286d5fb5772aeb57680e64f769
Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Gabriel Ganne [Tue, 29 Aug 2017 09:29:38 +0000 (11:29 +0200)]
silence makefile warning on ubuntu
shell error on ubuntu when OS_VERSION_ID == 16.04:
/bin/sh: 1: [: Illegal number: 16.04
Change-Id: I8db55f751ad7fb677a6565cbbce93a9bc08060b7
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
Marco Varlese [Tue, 29 Aug 2017 12:04:06 +0000 (14:04 +0200)]
Fix for bootstrap crash when VPP compiled with gcc-7
See issue VPP-964
Change-Id: I2aed5abdc02e47e7bb5b0ce78cb6589a1ce7302f
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
Pierre Pfister [Wed, 9 Aug 2017 08:42:06 +0000 (10:42 +0200)]
Flowprobe: Fix flow start time and hash computation
Upon hash collision, the flow start time was not reset.
The hash computation techniques (crc32 or xxhash) also both
had bugs which are now fixed.
Change-Id: I94d72997f34018d1699324264f7dded2a5cbd776
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
Steven [Mon, 28 Aug 2017 18:34:47 +0000 (11:34 -0700)]
vhost: Remove operation mode in the API
create/delete/modify vhost_user APIs no longer support the operation mode
(polling/interrupt/adaptive). They are now done via the generic interface.
Change-Id: I9e9bd503f9b56c953ecd2b271b3e2007da20c72a
Signed-off-by: Steven <sluong@cisco.com>
Thomas F Herbert [Thu, 3 Aug 2017 15:04:24 +0000 (11:04 -0400)]
Add Build Requirements from Makefile to spec file.
JIRA: VPP-498
Changes to build to help with downstream distro builds
for Fedora, Centos and RHEL distros.
Add nasm, automake, libtool, byacc, bison and flex.
Remove libconfuse and dependencies.
Remove epel-release rpm and dependencies.
Add conditionals to work around Python 2 packaging
inconsistency in Fed 25.
Add numactl to rpm requirements.
Change-Id: Ia39f8b931dc87e42df56414d38662eb33c7a4ca7
Signed-off-by: Thomas F Herbert <therbert@redhat.com>
Matej Perina [Wed, 23 Aug 2017 10:48:46 +0000 (12:48 +0200)]
jvpp: adding debug usage into test documentation
added debug version commands to Readme files for example tests
Change-Id: Icc5d5cdd33efb6d7c7512c7a78e22d9dc3d31fdc
Signed-off-by: Matej Perina <mperina@cisco.com>
Dave Barach [Tue, 22 Aug 2017 21:56:46 +0000 (17:56 -0400)]
TCP horizontal scaling
- Remove frame handoff support machinery. We haven't used it in a long
time.
- Configuration support for the local endpoints bihash table
- Drop lookup failure packets in tcp46_syn_sent
Change-Id: Icd51e6785f74661c741e76fac23d21c4cc998d17
Signed-off-by: Dave Barach <dave@barachs.net>
Damjan Marion [Fri, 25 Aug 2017 17:10:57 +0000 (19:10 +0200)]
dpdk: bump to dpdk 17.08, remove support for dpdk 17.02
Change-Id: I674fb1212e48693939045523df085326a4dd1809
Signed-off-by: Damjan Marion <damarion@cisco.com>