Florin Coras [Fri, 28 Sep 2018 22:03:16 +0000 (15:03 -0700)]
gitignore: build/external/downloads
Change-Id: I041764a5546352086aa9803e4bbeb9dff5f8d69a
Signed-off-by: Florin Coras <fcoras@cisco.com>
Steven [Fri, 28 Sep 2018 03:06:26 +0000 (20:06 -0700)]
bond: tx performance enhancement part deux
- Reduce per packet cost by buffering the output packet buffer indexes in the queue and
process the queue outside the packet processing loop.
- Move unnecessary variable initialization outside of the while loop.
- There is no need to save the old interface if tracing is not enabled.
Test result for 256 bytes packet comparison. Other packet size shows similar improvement.
With the patch
--------------
BondEthernet0-output active 52836
13526016 0 1.71e1 256.00
BondEthernet0-tx active 52836
13526016 0 2.68e1 256.00
TenGigabitEthernet6/0/0-output active 52836
6762896 0 9.17e0 127.99
TenGigabitEthernet6/0/0-tx active 52836
6762896 0 6.97e1 127.99
TenGigabitEthernet6/0/1-output active 52836
6763120 0 9.40e0 128.00
TenGigabitEthernet6/0/1-tx active 52836
6763120 0 7.00e1 128.00
bond-input active 52836
13526016 0 1.76e1 256.00
Without the patch
-----------------
BondEthernet0-output active 60858
15579648 0 1.73e1 256.00
BondEthernet0-tx active 60858
15579648 0 2.94e1 256.00
TenGigabitEthernet6/0/0-output active 60858
7789626 0 9.29e0 127.99
TenGigabitEthernet6/0/0-tx active 60858
7789626 0 7.01e1 127.99
TenGigabitEthernet6/0/1-output active 60858
7790022 0 9.31e0 128.00
TenGigabitEthernet6/0/1-tx active 60858
7790022 0 7.10e1 128.00
bond-input active 60858
15579648 0 1.77e1 256.00
Change-Id: Ib6d73a63ceeaa2f1397ceaf4c5391c57fd865b04
Signed-off-by: Steven <sluong@cisco.com>
Ole Troan [Fri, 28 Sep 2018 12:28:00 +0000 (14:28 +0200)]
MAP: Add check for well known ports.
And more unit-tests.
Change-Id: I4667d82d928b7ba8d96b5a5648d464115b3ed216
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Fri, 28 Sep 2018 12:27:24 +0000 (14:27 +0200)]
IP ttl check in ip4-input missing for single packet path.
Change-Id: Idc17b2f8794d37cd3242a97395ab56bd633ca575
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Wed, 26 Sep 2018 13:26:42 +0000 (15:26 +0200)]
stats: Split stat_segment and stats code in preparation for deprecation.
Split the stat_segment.c code from stats.c.
Rename stats.[ch] to prepare for removing (19.01?)
In addition stats.api can be removed.
Since the stats aggregation for the stat segment does not use the API, that
part is now done on the main thread. (Old stats aggregator is also left in place).
Change-Id: I9867429f4fc547b1a7ab7f88bc4f3625428d681b
Signed-off-by: Ole Troan <ot@cisco.com>
Damjan Marion [Thu, 27 Sep 2018 18:02:28 +0000 (18:02 +0000)]
Revert "japi: Move Java API binding to cmake"
components: Development
CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find JNI (missing: JAVA_AWT_INCLUDE_PATH)
Call Stack (most recent call first):
/usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
/usr/share/cmake-3.10/Modules/FindJNI.cmake:310 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
CMakeLists.txt:37 (find_package)
-- Configuring incomplete, errors occurred!
See also "/scratch/vpp-tmp/build-root/build-vpp-native/japi/CMakeFiles/CMakeOutput.log".
See also "/scratch/vpp-tmp/build-root/build-vpp-native/japi/CMakeFiles/CMakeError.log".
Makefile:640: recipe for target 'japi-configure' failed
make[2]: *** [japi-configure] Error 1
make[2]: Leaving directory '/scratch/vpp-tmp/build-root'
This reverts commit
a33db2528485ac39e8987bec7b138dbdad21dc5a.
Change-Id: I8a818ce70a8379656c1134432e22db418a4690fe
Signed-off-by: Damjan Marion <damarion@cisco.com>
Ole Troan [Thu, 27 Sep 2018 11:54:30 +0000 (13:54 +0200)]
MAP: Correctly print ea-bits-len in map commands.
Change-Id: I17b19875547cd6056aaf8f8fde439caa8e42d274
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Thu, 27 Sep 2018 11:53:30 +0000 (13:53 +0200)]
MAP: 64-bit DMR
Change-Id: I261e11f1006039e4a4019fec2fd3271763ae476a
Signed-off-by: Ole Troan <ot@cisco.com>
Paul Vinciguerra [Mon, 24 Sep 2018 12:25:00 +0000 (05:25 -0700)]
Trivial: Cleanup some typos.
This is a new commit for code under a different maintainer.
Change-Id: I79fa403fec6a312238a9a4b18b35dbcafaa05439
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Damjan Marion [Thu, 27 Sep 2018 12:54:49 +0000 (14:54 +0200)]
Add logging to vfio code
Change-Id: Iacdff0a5006a0617e3c9559ce7b258f26e256abb
Signed-off-by: Damjan Marion <damarion@cisco.com>
Sirshak Das [Sat, 22 Sep 2018 19:57:26 +0000 (14:57 -0500)]
dpdk_plugin: fix mlx5 build and runtime issues
There are issues with VPP finding and linking the mlx5 shared glue
library which was built by default if mlx5 was enabled.
Runtime Errors this patch fixes:
net_mlx5: cannot load glue library: librte_pmd_mlx5_glue.so.18.05.0:
cannot open shared object file: No such file or directory
net_mlx5: cannot initialize PMD due to missing run-time dependency on
rdma-core libraries (libibverbs, libmlx5)
This patch introduces additional config parameter to disable glue
library building and instead statically link ibverbs and mlx5
libraries to the PMD and dpdk_plugin.
Change-Id: I0b2f67652a57854c778e991780903fb15706ace8
Signed-off-by: Sirshak Das <sirshak.das@arm.com>
Reviewed-by: Lijian Zhang <Lijian.Zhang@arm.com>
Jakub Grajciar [Thu, 27 Sep 2018 08:26:35 +0000 (10:26 +0200)]
libmemif: external region bugfix
Change-Id: I7dbece80dda917ff78f53f8f4074132895aed316
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Jakub Grajciar [Wed, 19 Sep 2018 11:36:16 +0000 (13:36 +0200)]
memif: Memif Test Case
Change-Id: Ic0d5fc6ccbd496afcc870b908ef799af7c804c30
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Dave Barach [Thu, 27 Sep 2018 12:46:15 +0000 (08:46 -0400)]
"show log": print wall-clock time
Change-Id: I36f42c03f778955dd543da6c878be090d0443922
Signed-off-by: Dave Barach <dave@barachs.net>
Florin Coras [Thu, 27 Sep 2018 16:19:29 +0000 (09:19 -0700)]
tcp: use scaled window for new connects
Change-Id: Idf83fce8ca176e57b323e3741034e3223f1d195a
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ping Yu [Thu, 27 Sep 2018 12:49:33 +0000 (08:49 -0400)]
add cmake build option to build openssl async
This code is orignally in automake, but it is missing in cmake.
Thus add it to make openssl async work in cmake build system
Change-Id: Ie69ee9c2099273e51ce13ccab27bdd2619db4814
Signed-off-by: Ping Yu <ping.yu@intel.com>
Steven [Wed, 26 Sep 2018 17:56:46 +0000 (10:56 -0700)]
avf: may crash if failed to allocate buffers to ring
In avf_rxq_refill, we invoke vlib_buffer_alloc_to_ring which may fill buffers from the
end of the ring and continue to the beginning of the ring. If we fill some in the end and
continue to fill some in the beginning, but does not have enough buffers to fill the
whole request, n_alloc returns a value which is not equal to n_refill to indicate partial
refill. We don't like partial refill and invoke vlib_buffer_free to get rid of
the buffers that just got refilled. However, vlib_buffer_free API is to free the buffers
from the slot continuously. It does not know how to free some from rxq->bufs[slot], and then
continue to free the rest when it reaches the end of the ring.
The fix is to use vlib_buffer_free_from_ring which is smart enough to figure that stuff
out.
Change-Id: I93c28e0b0d8d8f22c321d1a5912e00c27b4e2e8d
Signed-off-by: Steven <sluong@cisco.com>
Marco Varlese [Thu, 27 Sep 2018 09:58:34 +0000 (11:58 +0200)]
SCTP: fix advanced debug output
Change-Id: Ied63ebaec8e19189f8b1ab2a7f6d7474c3f2ad6e
Signed-off-by: Marco Varlese <marco.varlese@suse.com>
juraj.linkes [Wed, 19 Sep 2018 12:59:43 +0000 (14:59 +0200)]
Test typo fixes
Renamed one acl testcase class which was copy-pasted and fixed one
inheritance issue.
Renamed one bihash testcase class.
Change-Id: I70d911ee7872d8d9ddba96c7f721dd099f0152f7
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
Damjan Marion [Thu, 27 Sep 2018 12:04:43 +0000 (14:04 +0200)]
fix typo in vpp-ext-deps rpm packaging
Change-Id: Ia23a876cefbfd32d6f543a77dfec57a4aa5676ae
Signed-off-by: Damjan Marion <damarion@cisco.com>
Ole Troan [Wed, 19 Sep 2018 10:38:51 +0000 (12:38 +0200)]
IPIP and IPv6 fragmentation
- Error where ICMPv6 error code doesn't reset VLIB_TX = -1
Leading to crash for ICMP generated on tunnelled packets
- Missed setting VNET_BUFFER_F_LOCALLY_ORIGINATED, so
IP in IPv6 packets never got fragmented.
- Add support for fragmentation of buffer chains.
- Remove support for inner fragmentation in frag code itself.
Change-Id: If9a97301b7e35ca97ffa5c0fada2b9e7e7dbfb27
Signed-off-by: Ole Troan <ot@cisco.com>
Mohsin Kazmi [Tue, 25 Sep 2018 16:26:52 +0000 (18:26 +0200)]
vom: Add ip punt redirect
Change-Id: I5c7b925b22b53f18b0c45374883a6a4bff580c75
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Steven [Wed, 26 Sep 2018 17:44:54 +0000 (10:44 -0700)]
vnet: show interface rx-placement may display garbage characters
Before
------
DBGvpp# sh int rx-mode
sh int rx-mode
Thread 1 (vpp_wk_0^@):
node vmxnet3-input:
vmxnet3-0/b/0/0 queue 0 (polling)
Thread 2 (vpp_wk_1^@):
node vmxnet3-input:
vmxnet3-0/13/0/0 queue 0 (polling)
DBGvpp#
After
-----
DBGvpp# sh int rx-placement
sh int rx-placement
Thread 1 (vpp_wk_0):
node vmxnet3-input:
vmxnet3-0/b/0/0 queue 0 (polling)
Thread 2 (vpp_wk_1):
node vmxnet3-input:
vmxnet3-0/13/0/0 queue 0 (polling)
DBGvpp#
Change-Id: I5910d502757054c3942fac9d20c5104e95fc6b56
Signed-off-by: Steven <sluong@cisco.com>
Steven [Wed, 26 Sep 2018 17:14:18 +0000 (10:14 -0700)]
vmxnet3: delete interface causes a crash
Need to free the buffers starting from ring->consume+1, not ring->consume
Make use of the cool API vlib_buffer_free_from_ring
Fix a memory leak in vmxnet3_txq_init
Change-Id: I0a539ea75211408d84ce433d97a0a0aec5a9618d
Signed-off-by: Steven <sluong@cisco.com>
Andrew Yourtchenko [Wed, 26 Sep 2018 19:03:06 +0000 (21:03 +0200)]
acl-plugin: fix the stateful ICMP handling and add testcases
The stateful ICMP/ICMPv6 handling got broken.
Fix that and introduce testcases to catch in the future.
Change-Id: Ie602e72d6ac613d64ab0bf6693b6d75afb1a9552
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Neale Ranns [Wed, 26 Sep 2018 12:07:25 +0000 (05:07 -0700)]
MPLS tunnel dump: use sw_if_index not tunnel_index
Change-Id: I6c0d5aec6ee96a0d40358f0e09a0901b22265063
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Florin Coras [Tue, 25 Sep 2018 23:27:51 +0000 (16:27 -0700)]
perftool: fix c2cpel
Change-Id: I0f39477bbf88d490409fdcd5f58df55cfe2ec531
Signed-off-by: Florin Coras <fcoras@cisco.com>
Kingwel Xie [Wed, 26 Sep 2018 09:07:09 +0000 (05:07 -0400)]
forget to assign spd_index to config
Change-Id: I35dcb987edf11097f34a633ac36d87cecd12088f
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
Mohsin Kazmi [Thu, 13 Sep 2018 07:59:50 +0000 (09:59 +0200)]
japi: Move Java API binding to cmake
Change-Id: Ia7ddd9f9e2e2d9c133967593c3e187fe42501eac
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Mohsin Kazmi [Wed, 26 Sep 2018 08:49:41 +0000 (10:49 +0200)]
rpm: Fix the spec file to look into right directories
Change-Id: If526e9f17226d7c371a8a98b9ac932196dab547a
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Kingwel Xie [Wed, 26 Sep 2018 08:59:52 +0000 (04:59 -0400)]
mismatch bi0 and b0 when finalizing ip reassembly.
bi0 always points to the first buffer in chain but b0 could be any fragment in a ip packet.
It causes a vnet_feature_next function call to the wrong buffer
and crashes sometime when there is >1 feature nodes under ip-unicast.
The fix is simple, makes b0 and bi0 both pointed to the first buffer
Change-Id: I7de36e68fb42b050fa63201abd98aeb6ba2e0cd3
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
Damjan Marion [Wed, 26 Sep 2018 13:28:17 +0000 (15:28 +0200)]
dpdk: fix QSFP+ module info
Change-Id: I89c7df778e66a5d2147190dc99445405d81964e5
Signed-off-by: Damjan Marion <damarion@cisco.com>
Alexander Chernavin [Mon, 24 Sep 2018 09:42:01 +0000 (05:42 -0400)]
Modify return values of L2 bridge API handlers
Change-Id: Ie6a6dde1fdc0e4fa8560682072a69876867a88d3
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Matus Fabian [Wed, 26 Sep 2018 08:08:00 +0000 (01:08 -0700)]
NAT44: endpoint-dependent mode session timeout improvement (VPP-1423)
Change-Id: Ib62e503f4eb5d72431288de32f417a4553df4e0c
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Damjan Marion [Fri, 21 Sep 2018 16:11:33 +0000 (18:11 +0200)]
bond: tx perf improvements
Change-Id: I0c3f2add35ad9fc11308b7a2a2c69ffd8472dd2e
Signed-off-by: Damjan Marion <damarion@cisco.com>
Mohsin Kazmi [Mon, 10 Sep 2018 16:11:00 +0000 (18:11 +0200)]
itf: dump interface rx-placement
Change-Id: I7dd48c8a2c77f82a2c1aa8311b062f5f0bc4e3fd
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Neale Ranns [Tue, 11 Sep 2018 02:14:07 +0000 (19:14 -0700)]
FIB: recusrive paths must lock the table to prevent its deletion
Change-Id: I958bf057be751dc7b3a0d93080021b3addc405b7
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Neale Ranns [Wed, 5 Sep 2018 16:13:57 +0000 (09:13 -0700)]
L2 BD: introduce a BD interface on which to send UU packets
Change-Id: I21ad6b04c19c8735d057174b1f260a59f2812241
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Tue, 25 Sep 2018 14:22:36 +0000 (07:22 -0700)]
MPLS tunnel dump fix
Change-Id: I9d3d5243841d5b888f079e3ea5dc1e2e8befd1dc
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Damjan Marion [Mon, 24 Sep 2018 13:17:36 +0000 (15:17 +0200)]
dpdk: show pluggable info in 'show hardware'
module: id SFP/SFP+/SFP28, compatibility: 40g_active_cable
vendor: Amphenol, part NDCCGF-I202
revision: C, serial: APF1711202351C, date code: 170318
cable length: 2m
Change-Id: Ife35607b4f078f7b56737fe066ad4cbd247a7504
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Tue, 25 Sep 2018 06:38:37 +0000 (23:38 -0700)]
BIER; bi-dir to/from underlay
set and check a special RX interface value as the packet enters and
exits a BIER domain
Change-Id: I5ff2f0e2d1b3ce0f3598b935f518fc11eb0896ee
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Andrew Yourtchenko [Fri, 14 Sep 2018 09:21:58 +0000 (11:21 +0200)]
acl-plugin: optimize session idle timer checks
This commit adds explicit signaling from a non-owning thread to the owning thread
to restart the session timer as necessary.
Consequently, we now can sweep the session lists at their respective timeouts,
rather than sweeping all the lists at the pace of the shortest timeout value,
just taking care to wake up if the session requeue to a different list results
in needing to wake up earlier.
Change-Id: Ifc8c500f6988748f4cd3dc184dd7824321aaaaca
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Damjan Marion [Tue, 25 Sep 2018 08:19:25 +0000 (10:19 +0200)]
dpdk: add patch to fix 25G AOC cable detection
Change-Id: I6b54d4c7767a20b875b5bc05f23a7ac15cb9fbcc
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Tue, 25 Sep 2018 07:30:23 +0000 (00:30 -0700)]
UDP-Encap: fix coverity found error
Change-Id: Idbe5f4d7f37dbe4dbf8d2679c3d816aeaed148d8
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Mon, 24 Sep 2018 21:40:40 +0000 (14:40 -0700)]
tcp: accept rst+ack in syn-rcvd state
Change-Id: I49da8be88dd033aae1b190e8e2163069ef480442
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Mon, 24 Sep 2018 20:58:05 +0000 (13:58 -0700)]
tcp: add option to cfg max rx fifo size
Change-Id: Icff3d688506e7658330db004c58bcfcac273fcec
Signed-off-by: Florin Coras <fcoras@cisco.com>
Lijian Zhang [Thu, 20 Sep 2018 10:40:56 +0000 (18:40 +0800)]
Enable verbose output during VPP cmake compiling
During VPP compiling, the command “make build-release V=1” gives verbose output on dpdk part.
This is to enable verbose output on vpp part, with CMAKE_VERBOSE_MAKEFILE:BOOL=ON passed to cmake.
It would help to get more cmake compiling information.
Change-Id: I2b01c8e234beb3189fe401801ff339f224c14470
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Reviewed-by: Sirshak Das <Sirshak.Das@arm.com>
Steven [Tue, 25 Sep 2018 04:09:36 +0000 (21:09 -0700)]
bond: crash when deleting bond interface [VPP-1427]
After the slave interface is removed from bond, bond input node still receives traffic for
the slave interface.
We have to disable feature arc for the corresponding slave interface.
Change-Id: I44e7001e6685e290b032c48147d02911a55d547b
Signed-off-by: Steven <sluong@cisco.com>
Steven [Mon, 24 Sep 2018 21:23:44 +0000 (14:23 -0700)]
vmxnet3: guard against array overflow
Under extreme condition, it is possible for input node to have more than 256 packets available
to process. Add a check to the while loop to prevent overrun buffer_indices and nexts.
Change-Id: Id9830e5c254f04216eb79e864a5460e08cf2e4e5
Signed-off-by: Steven <sluong@cisco.com>
Matus Fabian [Mon, 24 Sep 2018 10:44:49 +0000 (03:44 -0700)]
NAT44: fix nat44_o2i_ed_is_idle_session_cb (VPP-1424)
Change-Id: I47e1fc789ddf3dbfdf9768b99d5c3a8804d6b750
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Matus Fabian [Mon, 24 Sep 2018 11:41:28 +0000 (04:41 -0700)]
NAT44: endpoint-dependent mode session timeout improvement (VPP-1423)
Change-Id: I630f3da1ea4e6e50a50f1352c097becef1efe3c0
Signed-off-by: Matus Fabian <matfabia@cisco.com>
jdenisco [Mon, 24 Sep 2018 18:59:33 +0000 (14:59 -0400)]
Add the sphinx docs build options
Change-Id: If7ac5b41ca4ac602a100b616b37d07f658fd6a90
Signed-off-by: jdenisco <jdenisco@cisco.com>
Damjan Marion [Mon, 24 Sep 2018 19:02:13 +0000 (21:02 +0200)]
nsim: fix multiple definitions of nsim_node
Change-Id: Iedd79eeba35fb7385c03a177f8ac7d3ddfeb6a84
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Wed, 19 Sep 2018 06:11:55 +0000 (23:11 -0700)]
svm: march svm_fifo take 2
Change-Id: Ifa4fceef7edbe43d444790a624957db0817064de
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Mon, 24 Sep 2018 18:30:32 +0000 (20:30 +0200)]
avf: rename interface name
Change-Id: I4a1dca92a69547f8b26e9aec7574332f39e43c37
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Mon, 24 Sep 2018 08:34:11 +0000 (08:34 +0000)]
ARP: don't use RPC for requests initiated from the main thread
Change-Id: If833680149eb33db6adc836c5330f350042869f4
Signed-off-by: Neale Ranns <nranns@cisco.com>
Dave Barach [Fri, 21 Sep 2018 17:10:28 +0000 (13:10 -0400)]
Network delay simulator plugin
Change-Id: I4a70c7df8f0cb368a4e1cb16f30eeef5c6058c79
Signed-off-by: Dave Barach <dave@barachs.net>
Paul Vinciguerra [Sat, 22 Sep 2018 12:32:50 +0000 (05:32 -0700)]
Trivial: Clean up some typos.
Change-Id: I085615fde1f966490f30ed5d32017b8b088cfd59
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Hongjun Ni [Tue, 18 Sep 2018 15:25:02 +0000 (23:25 +0800)]
LB: fix flush flow table issue
Change-Id: Ib0a06ab71aed42eb5bb2ab2edf4844b2167e0610
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
Florin Coras [Sat, 22 Sep 2018 00:55:04 +0000 (17:55 -0700)]
vcl: remove vcl_event
Change-Id: I0f805ae47f6e9465070a54d85f164bc74877af01
Signed-off-by: Florin Coras <fcoras@cisco.com>
Khers [Sat, 22 Sep 2018 14:23:06 +0000 (17:53 +0330)]
fix following error in debian jessie:
'‘for’ loop initial declarations are only allowed in C99 or C11 mode'
Change-Id: Id842382f884122555abaa936c56cdfd305f2a5f3
Signed-off-by: Khers <s3m2e1.6star@gmail.com>
Steven [Fri, 21 Sep 2018 14:55:07 +0000 (07:55 -0700)]
vmxnet3: Add hardware link status handling
Added an interrupt line for monitoring and notifying hardware link status
Displayed additional information for show hardware for vmxnet3 interface
Fixed possible garbage display on interface name for show vmxnet3
Change-Id: If457bfe7c216287fb3a4e2630f00434d595f387b
Signed-off-by: Steven <sluong@cisco.com>
Damjan Marion [Fri, 21 Sep 2018 10:27:45 +0000 (12:27 +0200)]
add: nasm and ipsec-mb into vpp-ext-deps packaging
Change-Id: Ie5d85af84ae0d8b15edf5962213ed1b1953bee2f
Signed-off-by: Damjan Marion <damarion@cisco.com>
Tibor Král [Wed, 19 Sep 2018 14:14:22 +0000 (16:14 +0200)]
Fixed japi/java/Makefile.am so the JAR for NSH plugin builds as well.
Change-Id: I15b3e51d6e0206f4a387eb2ce764914167149385
Signed-off-by: Tibor Král <tibor.kral@pantheon.tech>
Matus Fabian [Fri, 21 Sep 2018 06:18:41 +0000 (23:18 -0700)]
NAT: Refactoring / Housekeeping (VPP-1415)
Change-Id: Ia3ce24cc94f9b2fb331ad62a4181ddcd41bc78ca
Signed-off-by: Matus Fabian <matfabia@cisco.com>
John Lo [Thu, 20 Sep 2018 20:07:00 +0000 (16:07 -0400)]
Add more CLI options to vpp_api_test for calling ip_add_del_route
Change-Id: I114e93b6bc71cfcdcfe6d3ddde26f77118e36ab8
Signed-off-by: John Lo <loj@cisco.com>
Florin Coras [Fri, 21 Sep 2018 01:36:54 +0000 (18:36 -0700)]
tcp: accept fin-ack in syn-rcvd state
Change-Id: Ibe57abc7d2a06be80146ce28edf4c60ecda991eb
Signed-off-by: Florin Coras <fcoras@cisco.com>
Steven [Thu, 20 Sep 2018 18:50:35 +0000 (11:50 -0700)]
vhost: show vhost may display garbage after the interface name
DBGvpp# show vhost-user
Virtio vhost-user interfaces
Global:
coalesce frames 32 time 1e-3
number of rx virtqueues in interrupt mode: 0
Interface: VirtualEthernet0/0/0�?x�D (ifindex 3)
The fix is to use format_vnet_hw_if_index_name rather than hi->name. The former
format the name with %v rather than %s
Change-Id: If4d275e1eb249cf87b2d6b796b42f24769f9e3e3
Signed-off-by: Steven <sluong@cisco.com>
Andrew Yourtchenko [Thu, 20 Sep 2018 13:36:51 +0000 (15:36 +0200)]
bihash template: avoid memory leak upon rehash
Call the BV (value_free) when we have performed the rehash
and thus no longer need the memory that old value for the
bucket refers to.
Change-Id: Ibb82174fc8002aeb3e1a6c8d1f90293d73bc45d8
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Damjan Marion [Tue, 18 Sep 2018 16:41:38 +0000 (18:41 +0200)]
rename vpp-dpdk-dev to vpp-ext-deps
We need to have new tenants in the development package.
This is first of series of patches which will allow us to have multiple
external libs and tools packaged for developer's convenience.
Change-Id: I884bd75fba96005bbf8cea92774682b2228e0e22
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Fri, 7 Sep 2018 15:57:41 +0000 (08:57 -0700)]
UDP-Encap: name counters for the stats segment
change the ADD api so that is returns the 'ID' that can be used
by the client to read the stats from the stats segment and to
delete the object. Previously a similar value used required
to be chosen by the client, now VPP allocates one (like it
does e.g. for interfaces)
Change-Id: I563cf6092276eb990c52d5457c86e72546bcf69e
Signed-off-by: Neale Ranns <nranns@cisco.com>
Neale Ranns [Thu, 20 Sep 2018 09:49:25 +0000 (02:49 -0700)]
SR-MPLS: MPLS table checks (VPP-1422)
Change-Id: I397715ea8c1966f5ee61128f284d62d875c568e1
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Tue, 18 Sep 2018 05:09:02 +0000 (22:09 -0700)]
session/svm: add want_tx_event flag to fifo
Have applications use explicit flag to request events from vpp when it
transmits from a full fifo.
Change-Id: I687c8f050a066bd5ce739d880eaec1f286038d95
Signed-off-by: Florin Coras <fcoras@cisco.com>
Neale Ranns [Fri, 7 Sep 2018 16:32:36 +0000 (09:32 -0700)]
Route counters in the stats segment
route ADD API changed to return the stats segment index to use to read the counters
Change-Id: I2ef41e01eaa2f9cfaa49d9c88968897793825925
Signed-off-by: Neale Ranns <nranns@cisco.com>
Mohsin Kazmi [Tue, 21 Aug 2018 14:07:03 +0000 (16:07 +0200)]
vhost-user: Add disable feature support in api
Two flags to disable mergable rx buffers and indirect
descriptors are added to api.
Change-Id: Iba0ee9c48d19dfc3d3420a3fdaf44a1a1d325e99
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Juraj Sloboda [Mon, 23 Jul 2018 10:22:54 +0000 (12:22 +0200)]
NAT44 virtual fragmentation reassembly for endpoint-dependent mode (VPP-1325)
Change-Id: I36ece2ef2eaef9fa559d69ec7f7f07e7c16a7a9d
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
Steven [Wed, 19 Sep 2018 22:30:25 +0000 (15:30 -0700)]
vmxnet3: invoke vlib_buffer_enqueue_to_next() with the wrong buffers for chain buffers
If we invoke the subject API with 2 buffers, each with 2 chains, the content of
buffers[0] should be head of 1st buffer, and content of buffer[1] should be
head of 2nd buffer.
What the code did was to put
buffers[0] = head of 1st buffer
buffers[1] = next chain of 1st buffer
buffers[2] = head of 2nd buffer
buffers[3] = next chain of 2nd buffer
This is wrong and can cause crash.
The fix is to only increment bi when the entire packet is found which may consist
of multiple fragments.
Change-Id: If02cd5186a039d7a6c08a0959112840bdb242317
Signed-off-by: Steven <sluong@cisco.com>
juraj.linkes [Wed, 19 Sep 2018 13:01:47 +0000 (15:01 +0200)]
VPP-1421: Reworked results gathering
The previous version sent the whole VPPTestResult object through pipe,
which uses pickle to transfer objects. Pickle does not support sending
any arbitrary objects and was causing issues. Now just a tuple of
(test_id, result) is sent.
Change-Id: I3a3a9e6f1b9ac9b05889babfc1f7560c7ac4471c
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
Andrew Yourtchenko [Wed, 19 Sep 2018 13:50:55 +0000 (15:50 +0200)]
bihash template: reinstate the check for the available memory in the arena
ffb14b9554afa1e58c3657e0c91dda3135008274 has changed the semantics
of alloc_arena_next to become an offset off alloc_arena, but
in the available memory check in BV (alloc_aligned) it still treats
it as a virtual address, resulting in the check always succeeding,
thus over a prolonged period bihash arena allocator
potentially overwriting whatever is following the arena.
Change-Id: I18882c5f340ca767a389e15cca2696a0a97ef015
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Neale Ranns [Wed, 19 Sep 2018 11:55:32 +0000 (04:55 -0700)]
GRE: fix 4o6 and 6o4 adj stacking
Change-Id: I13dc5eab8835c4f3b95906816d42dccfeee8b092
Signed-off-by: Neale Ranns <nranns@cisco.com>
Damjan Marion [Wed, 19 Sep 2018 08:39:43 +0000 (10:39 +0200)]
dpdk: mask and warn if rx/tx offload is not available
Warning messsage is displayed in system log:
vpp# show log
1970/ 1/ 1 01:00:01:198 warn dpdk unsupported rx offloads requested on port 0: scatter
Change-Id: I40021066daf2d37ca5233e3adce55e412f0d3932
Signed-off-by: Damjan Marion <damarion@cisco.com>
Neale Ranns [Wed, 19 Sep 2018 11:07:02 +0000 (04:07 -0700)]
L2-fib-dump: send 1 or 0 rather than flag value
Change-Id: I487b3b480347f60ffe3af4029adfb22b6700cea7
Signed-off-by: Neale Ranns <nranns@cisco.com>
Florin Coras [Thu, 2 Aug 2018 19:16:03 +0000 (12:16 -0700)]
socket api: do not delay sending of messages
Instead of relying on main epoll loop to send messages, try to send as
soon as possible.
Change-Id: I27c0b4076f3599ad6e968df4746881a6717d4299
Signed-off-by: Florin Coras <fcoras@cisco.com>
dongjuan [Tue, 11 Sep 2018 11:20:30 +0000 (11:20 +0000)]
nat: free port_bitmap
Change-Id: Ied0fc50f1afb0f7fc563784544699726a6d03380
Signed-off-by: dongjuan <dong.juan1@zte.com.cn>
Florin Coras [Tue, 18 Sep 2018 23:12:50 +0000 (16:12 -0700)]
session: improve close procedure
Change-Id: I6201a044e70ab6a58db8212960c57edc77c41f96
Signed-off-by: Florin Coras <fcoras@cisco.com>
Yichen Wang [Wed, 19 Sep 2018 00:32:29 +0000 (17:32 -0700)]
Fix documentation for SHG in bridge domain
Change-Id: If094971cf011d09fa0daf3ff393f490e584c1151
Signed-off-by: Yichen Wang <yicwang@cisco.com>
Steven [Tue, 18 Sep 2018 19:34:59 +0000 (12:34 -0700)]
vmxnet3: add support for "non-default" next node
Support feature arc
Support set interface next node
Enqueue packet to either ip4, ip6, or ethernet_input based on packet type
Change-Id: I11fb6bba98ee0bfa1d057474fc6cf3be48ef1c48
Signed-off-by: Steven <sluong@cisco.com>
jdenisco [Mon, 17 Sep 2018 19:39:09 +0000 (15:39 -0400)]
docs: Added Related Projects and Archive
Change-Id: I9a6076aa53d810ec44761d9f9459eb91f2c05974
Signed-off-by: jdenisco <jdenisco@cisco.com>
Klement Sekera [Tue, 18 Sep 2018 12:32:27 +0000 (14:32 +0200)]
fix TEST_JOBS=auto max jobs detection
Change-Id: I63f747e92d239e878550392df24fb7aac2b5a3e3
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Matthew Smith [Tue, 18 Sep 2018 15:52:58 +0000 (10:52 -0500)]
disable scatter/gather for ENA with DPDK 18.08
The scatter/gather rxmode flag was set for ENA when building
against DPDK >= 18.08. ENA does not support this, so disable
it. It looks like enabling it was a copy/paste error.
Also, after offloads are adjusted based on whether "no-multi-seg"
is set, those configurations are overwritten by copying
port_conf_template over the port config. That should only happen
for versions of DPDK older than 18.08 because 18.08 and newer
make changes directly on the port config instead of making changes
to the template. Make the clib_memcpy() conditional on the DPDK
version being less than 18.08. After doing so, compiler
errors complain about port_conf_template being declared but not
used, so make it's declaration conditional.
Change-Id: If81980d71c379a565b51dd700b953f8c811a8703
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Ole Troan [Tue, 18 Sep 2018 10:46:14 +0000 (12:46 +0200)]
STATS: First go at documentation
Change-Id: I4d586456c46994b60ff7670d1411997a3615a284
Signed-off-by: Ole Troan <ot@cisco.com>
Florin Coras [Fri, 29 Jun 2018 15:44:31 +0000 (08:44 -0700)]
svm: better march support for svm fifo
Change-Id: I6a4335654882a2ca66d3d465e35e350868242b8d
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ole Troan [Tue, 18 Sep 2018 09:06:33 +0000 (11:06 +0200)]
STATS: Optimistic concurrency handling in Python library.
Change-Id: I2135f3e77206fd171636a1e0b07c373c0bf093e4
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Tue, 18 Sep 2018 08:23:01 +0000 (10:23 +0200)]
STATS: Add Python 3 support to vpp_stats.py.
Change-Id: Iad0b0315fbd493b67e6ca490206ec8e8422790ea
Signed-off-by: Ole Troan <ot@cisco.com>
Ole Troan [Tue, 4 Sep 2018 11:19:12 +0000 (13:19 +0200)]
STATS: Dynamically mapped shared memory segment
Move from using a hash to a vector with offsets into shared memory.
Limit exposure of VPP data structures and include files to
external stats library and applications.
Change-Id: Ic06129f12d10cf4c4946a86d9bc734eacff2c7da
Signed-off-by: Ole Troan <ot@cisco.com>
Dave Barach [Sun, 16 Sep 2018 15:03:04 +0000 (11:03 -0400)]
Register cdp_input when enabled for the first time
Graceful handling of unknown tlv types
Change-Id: Idbc9ed524fc8b865c8e12571813cc73548bde480
Signed-off-by: Dave Barach <dave@barachs.net>
Florin Coras [Sun, 16 Sep 2018 21:49:36 +0000 (14:49 -0700)]
vmxnet3: fix clang initialization error
Change-Id: I2958bd3bdec98d3e380a8ff8f970563020e28afd
Signed-off-by: Florin Coras <fcoras@cisco.com>
zhanglimao [Sat, 15 Sep 2018 05:19:41 +0000 (13:19 +0800)]
fix nsh map index error, it will cause vpp appear Segmentation fault when vpp process double packages
Change-Id: Ib32bb351356b84aaf696c57398610b52a5a1f4dd
Signed-off-by: zhanglimao <zhanglimao0017@gmail.com>
Florin Coras [Sat, 15 Sep 2018 00:56:29 +0000 (17:56 -0700)]
tls: fix openssl engine write complete condition
Change-Id: Ic1526f6916970ce2b0c4fc0d148d4396fa629b5f
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 14 Sep 2018 20:17:41 +0000 (13:17 -0700)]
session: ensure detach is done with worker barrier
Change-Id: I98a79f2c3b0268c414dd295c7ebfc561ce049d4b
Signed-off-by: Florin Coras <fcoras@cisco.com>