Semir Sionek [Wed, 26 Mar 2025 13:29:32 +0000 (13:29 +0000)]
hsa: add timed runs option for echo client
Introduce the run-time parameter for echo client, which allows for
running for a certain time with a full buffer as opposed to running
until n amount of data is bounced back.
Type: improvement
Change-Id: I7b5b2138fe3fbbc36511331095a02dafd776fa94
Signed-off-by: Semir Sionek <ssionek@cisco.com>
Adrian Villin [Wed, 2 Apr 2025 17:01:17 +0000 (19:01 +0200)]
hs-test: simplify core allocation
- no longer distinguishing between release and debug build in the CI
- core allocation will always start from core 1 (or 0 if CPU0=true)
Type: improvement
Change-Id: I4568bda01bd90fba14ca81f6669bdab3b7521415
Signed-off-by: Adrian Villin <avillin@cisco.com>
Andrew Yourtchenko [Thu, 18 Jul 2024 12:01:53 +0000 (14:01 +0200)]
acl: use ip4_preflen_to_mask instead of artisanal function
Type: improvement
Change-Id: I4cd52a9f2b8814e8d27a72ea3547fd9f8ee23562
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Bence Romsics [Thu, 18 Jul 2024 08:57:12 +0000 (10:57 +0200)]
vat2: fix -p in vat2 help text
Since commit
fe1fb3c31a short option -p stands for --plugin-path and -s
stands for --prefix. Adjust the help text. Also fix a typo and sort
option lists.
Type: fix
Change-Id: I8e9fd825cca930e13e0a09a4492f22951a25e2ee
Signed-off-by: Bence Romsics <bence.romsics@gmail.com>
Naveen Joy [Tue, 1 Apr 2025 21:26:44 +0000 (14:26 -0700)]
tests: gracefully terminate iperf3 process to enable cleanups
Type: fix
Change-Id: I24660305ea20d7b69e825a785ce5be3f80b431eb
Signed-off-by: Naveen Joy <najoy@cisco.com>
Ivan Ivanets [Tue, 1 Apr 2025 17:30:34 +0000 (20:30 +0300)]
tests: update lcov ignore_error param
Type: test
Add the value 'negative' into ignore_error param to fix lcov error
for test-cov.
Change-Id: Ia10f70315e9f9f24bfa1d177a7293b65c3889fd2
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>
Nithinsen Kaithakadan [Thu, 23 Jan 2025 05:04:52 +0000 (10:34 +0530)]
octeon: set cpt descriptor count to 16k
Set the number of CPT descriptors to 16384.
Add an option to configure cpt descriptor count
from startup conf.
Type: feature
Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com>
Change-Id: Id1ffbe69ad7d457dbd0b11494be1dc0d4a28c324
Nithinsen Kaithakadan [Sun, 9 Mar 2025 13:16:01 +0000 (18:46 +0530)]
octeon: fix invalid mac length in chacha poly
This patch fixes invalid mac length to resolve crash in Chacha Poly.
Type: fix
Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com>
Change-Id: Ia940a721b5cb47f7b5fe68adbea78adaaa0f54f0
Andrew Yourtchenko [Mon, 31 Mar 2025 12:05:52 +0000 (12:05 +0000)]
build: fix the make-ext-deps
After the spring cleaning there were a couple of packages missing,
which prevented the install of the external dependencies.
Also as per Damjan, dkms is no longer needed for dpdk.
Type: fix
Fixes:
27c80923d0cc941c3d6954e2339b0ec75bcf18f9
Change-Id: I7f51577fee25283d64ddb898af87ae7520d6afb0
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Semir Sionek [Fri, 28 Mar 2025 15:05:11 +0000 (15:05 +0000)]
hsa: remove mbytes/gbytes parameters from echo client
...since we're already doing unformat_memory_size on the regular bytes
parameter anyway. In conjunction with that, adjust some make
test/hs-test tests to make use of this parameter.
Type: refactor
Change-Id: Ia0c2899a31b14a8689fdc256e25c4bb418de37fc
Signed-off-by: Semir Sionek <ssionek@cisco.com>
Adrian Villin [Fri, 28 Mar 2025 11:59:12 +0000 (12:59 +0100)]
hs-test: remove assert in container.Exec
- removed so we can ignore errors (e.g. vppinstance.Stop)
Type: test
Change-Id: Ib83057eaac7ae6e7338ae9cb59ab2af6239c47a5
Signed-off-by: Adrian Villin <avillin@cisco.com>
Florin Coras [Fri, 28 Mar 2025 18:05:10 +0000 (14:05 -0400)]
http: leave space for msg header on transport method
Type: fix
Change-Id: I4bcc9c6168c18ccf5701b832c26b16d3bb24bc98
Signed-off-by: Florin Coras <fcoras@cisco.com>
Matus Fabian [Fri, 28 Mar 2025 16:04:50 +0000 (12:04 -0400)]
http_static: POST to static files improvement
Type: improvement
Change-Id: I6a6794dee3c9e948227e6c08769d45aa595bfe02
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Ivan Ivanets [Fri, 28 Mar 2025 15:48:41 +0000 (17:48 +0200)]
tests: fix text cov-post
Type: test
Need to remove unused html/cmd_line file after genhtml based on
jjb/script/publish_cov.sh error about file name patter without
extension
Change-Id: I607951f8e464bb9e0bb88b4ee84010a5984f082a
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>
Florin Coras [Fri, 28 Mar 2025 04:17:44 +0000 (00:17 -0400)]
vcl: fix coverity warnings
Type: fix
Change-Id: I41a9332bdd7a34ce30eaa5cd2378990dbe8e31f5
Signed-off-by: Florin Coras <fcoras@cisco.com>
Jeff Shaw [Fri, 21 Mar 2025 15:00:17 +0000 (08:00 -0700)]
dma_intel: fix dsa software fallback
When a page fault occurs, and the "block on fault" flag is not set, the
DSA device reports the error in the completion descriptor and software
should complete the operation in software. This behavior works properly,
except the batch was not added to the list of pending batches, so the
DSA node failed to completely process the batch. The side effect is the
application callback is not called, so buffers are not freed, and the
batch is never added back to the freelist, leading to eventual buffer
exhaustion, and traffic stopping.
The fix is to make sure the batch is added to the list of pending
batches so the DSA node completes the batch. This change also removes
the line that increments the "submitted" counter as that is only used
to count batches that are submitted to hardware. A separate counter,
sw_fallback, is used to count batches that are handled in software.
Type: fix
Change-Id: Ib54e8d77ac02e5dca237bb9348440c3ddaad993b
Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
Ivan Ivanets [Thu, 27 Mar 2025 13:53:04 +0000 (15:53 +0200)]
tests: fix test cov for PG Stream and Session SDL
Type: test
Localized cli response waiting time configuration only for
test_pg_stream and test_session_sdl instead of asfframework conf
Change-Id: Iabeccdda97e518662f1243edd91217c02cdc8711
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>
Ivan Ivanets [Wed, 26 Mar 2025 21:53:05 +0000 (23:53 +0200)]
tests: fix test cov
Type: test
Need to add cli response waiting timeout for test cov for test_session_sdl
and test_pg_stream.
Change-Id: I3eedfdb0de1ca01d9786742986fbcce2487500e3
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>
Florin Coras [Tue, 25 Mar 2025 07:29:40 +0000 (00:29 -0700)]
vcl: improve vpp detached handling for mq epoll apps
Apps that rely on epoll and use eventfds for mq signaling can
potentially sleep indefinitely if vcl detaches from vpp and no libc fd
generates events.
To avoid this, at detach time, force creation of a pair of pipes that
constantly generates mq_epfd events to force apps, including ldp, to
request vppcom epoll_waits which retry attaching to vpp.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ie2ac338cc10721829e6ac525ee7d6b812354e9a3
Florin Coras [Wed, 26 Mar 2025 03:54:51 +0000 (23:54 -0400)]
hs-test: fix redis test on ubuntu 24.04
Noticed in local runs that after snapshots, vcl crashes due to what
appears to be a memory corruption. Given that snapshot are done in a
forked child process, probably this is some mishandling of child
processes in multi-threaded apps.
Disable snapshotting for now.
Type: fix
Change-Id: Ide2dd3d68911b936742b41992485cc06db737564
Signed-off-by: Florin Coras <fcoras@cisco.com>
Andrew Yourtchenko [Wed, 26 Mar 2025 15:52:25 +0000 (16:52 +0100)]
acl: fix an off-by-one error in fa_acl_match_ip6_addr which does masked IPv6 comparison
The comparison code for the bit remainder (non-zero part of prefix length modulo 8)
was incorrectly looking one byte further than it should.
Type: fix
Change-Id: Idd27d218e77eff5f368f2ba0a5cefb86ecf605f5
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Damjan Marion [Mon, 17 Mar 2025 14:51:59 +0000 (15:51 +0100)]
vlib: add new node type - SCHED nodes
SCHED nodes are new type of nodes, similar to input nodes but they are
scheduled to be run from timing wheel.
SCHED nodes work both on main and worker threads.
Typically SCHED nodes can be scheduled to be run in two ways:
- vlib_node_set_interrupt_pending() - from any thread, run ASAP
- vlib_node_schedule() - from own thread, afer sepcific interval
Type: feature
Change-Id: Id29a66532328d9b3c454e65d09495e8fb479cedf
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Tue, 25 Mar 2025 21:50:05 +0000 (22:50 +0100)]
build: remove unused packages
Type: improvement
Change-Id: I324e34198b5332407759f3acff8b185f936d9090
Signed-off-by: Damjan Marion <damarion@cisco.com>
Matus Fabian [Tue, 25 Mar 2025 09:51:17 +0000 (05:51 -0400)]
hs-test: iperf and redis server logs
send output to a log file for iperf server and redis server
Type: test
Change-Id: I07a5222e4717eee9cac3aab5c9a1a324d843e3b5
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Jeff Shaw [Tue, 25 Mar 2025 15:13:10 +0000 (08:13 -0700)]
misc: update maintainers
Update dma_intel, dpdk-cryptodev, idpf, and ipsec maintainers.
Also fix whitespace formatting.
Type: docs
Change-Id: Ic25343164c2fc33010a0d7044dab2e813dc6c7b7
Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
Matus Fabian [Fri, 14 Mar 2025 13:10:38 +0000 (09:10 -0400)]
http: http/2 core skeleton
Type: feature
Change-Id: Ia6581b685c9dbc89e72bdec320b7f52f6f962542
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Matus Fabian [Fri, 7 Mar 2025 13:02:42 +0000 (08:02 -0500)]
http: extendable conn/req ctx and multiplexing
multiplexing support:
- set request index as connection_index in application session
- do not allocate app session/http req immediately in
http_ts_accept_callback but wait for request/stream opening
HTTP version specific data in connection and request ctx:
- opaque pointer in http_conn_t
- req_pool manged entirely by specific version engine
Version specific configuration:
- added name to http_engine_vft_t
- added unformat_cfg_callback (optional) to http_engine_vft_t
Type: improvement
Change-Id: Ib43f0489337a222a68b0f81d45cb2e64b2c606c0
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Benoît Ganne [Wed, 18 Dec 2024 16:38:23 +0000 (17:38 +0100)]
build: fix coverage for various lcov versions
Starting with lcov version 2, we need to add some errors filtering.
Unfortunately, those filters are not available with lcov version 1.
Type: fix
Fixes:
66fcfb845b8e588901b4f663435e9e1b30499467
Change-Id: Ic8f4c55be89dcc59370b5a69ed8e8f39c5647ec8
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Andrew Yourtchenko [Wed, 19 Mar 2025 14:11:44 +0000 (14:11 +0000)]
tests: allow to define SKIP_TESTS in a similar fashion to TEST
This change adds the possibility to specify the tests to skip
from the selected set of tests. This allows to construct test
sets "everything except foo and bar" that are tedious to make
otherwise.
Type: improvement
Change-Id: I0862031baf22fef926554873a88a068dfc8f0623
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Ivan Ivanets [Wed, 19 Mar 2025 14:35:42 +0000 (16:35 +0200)]
tests: use vcl_test_client and server for installation
Type: test
Need to use vcl_test_client and server for deb pkg installation.
After that it is possible to use for the new one CSIT testsuit.
Change-Id: I5a374e47e9c0d0fa3920f26f6dcc9adfbc05103b
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>
nucleo [Mon, 17 Mar 2025 14:25:41 +0000 (16:25 +0200)]
quic: Fix compilation error with CMake 4.0.0
Fixes quicly compilation error and warning with CMake 4
Compatibility with CMake < 3.5 has been removed from CMake.
Compatibility with CMake < 3.10 will be removed from a future version of CMake.
Type: fix
Change-Id: I810f70459d5ba70f6a8c0ea0d57c77fe20dddb73
Signed-off-by: nucleo <alekcejk@googlemail.com>
Adrian Villin [Mon, 17 Mar 2025 09:43:06 +0000 (10:43 +0100)]
hs-test: lower minimum iperf perf requirements
- lowering because of ubuntu 24.04
Type: test
Change-Id: I35ec190f10bda0ea0bfe815f00ac147e451b3607
Signed-off-by: Adrian Villin <avillin@cisco.com>
nucleo [Fri, 14 Mar 2025 15:09:18 +0000 (17:09 +0200)]
af_xdp: Backport Get rid of llc and use clang to build BPF object files directly
Fixes xdp-tools compilation error with clang 20
error: argument unused during compilation: '-c' [-Werror,-Wunused-command-line-argument]
Type: fix
Change-Id: I4d37256a722499ec1cbe8fe8e708810a2c8c9d99
Signed-off-by: nucleo <alekcejk@googlemail.com>
Nicolas PLANEL [Wed, 5 Mar 2025 15:37:47 +0000 (16:37 +0100)]
dpdk: rte_eth_tx_prepare need to called before transmiting packets
By the DPDK documentation rte_eth_tx_prepare() call is required
to prepare the NIC and to validate the mbufs.
This would fix hardware bad UDP checksum generated by ena driver issue.
As performance will be impacted depending on the driver tx_prepare() callback
I defined a tx-prepare flag that would be enabled by default on ena driver but
could be enabled in the configuration if need for others drivers.
Note: This option would normally be exclusive with intel_phdr_cksum as driver's
tx_prepare would normally cover this usage.
Type: fix
Change-Id: Ic7c21682f7bd92b35bd9b1028129709baa2a64d4
Signed-off-by: Nicolas PLANEL <nplanel@cisco.com>
Signed-off-by: Nicolas PLANEL <nplanel@gmail.com>
Adrian Villin [Thu, 13 Mar 2025 11:12:13 +0000 (12:12 +0100)]
hs-test: added session, tcp, svm unit tests
- moved HttpUnitTest to unittests_test.go
- unit tests will only run on coverage builds
- added "SUCCESS" message to some unit tests
Type: test
Change-Id: I35a0510d0ac2899d85f2aa6875a738b280e9b89c
Signed-off-by: Adrian Villin <avillin@cisco.com>
Klement Sekera [Tue, 26 Nov 2024 14:42:41 +0000 (15:42 +0100)]
ip: fix ICMP inner payload parsing
Add a check so that ICMP type is verified to be an error before parsing
inner payload. If it's not an error, then the inner payload is not there.
Type: fix
Fixes:
46d0ff3945
Change-Id: I5c7d8ddacb347ec030784f349064e66d63cd525e
Signed-off-by: Klement Sekera <klement.sekera@gmail.com>
Semir Sionek [Fri, 14 Mar 2025 10:44:21 +0000 (06:44 -0400)]
hs-test: enable coverage file filtering correctly
Type: fix
Change-Id: Idb14eebb42d31ff3c6ad5cde30fdb2e53d47302b
Signed-off-by: Semir Sionek <ssionek@cisco.com>
Florin Coras [Wed, 12 Mar 2025 08:18:32 +0000 (04:18 -0400)]
vcl: fix cl sendto on unbound socket
Type: fix
Change-Id: Ia1e61a7ed633ad9708bd02fbaf4a39fe1a0ca1f3
Signed-off-by: Florin Coras <fcoras@cisco.com>
Jay Wang [Tue, 11 Mar 2025 10:49:43 +0000 (10:49 +0000)]
build: remove the duplicate `make install-dep` in `make pkg-verify`
In Makefile, when a target has multiple prerequisites, the order of
execution of prerequisites is not guaranteed. So we might encounter the
following `apt-get` lock issue when executing `make pkg-verify` due to
the duplicate execution of `make install-dep` command.
Reading package lists...
E: Could not get lock /var/lib/apt/lists/lock. It is held by process 21872 (apt-get)
E: Unable to lock directory /var/lib/apt/lists/
make[1]: *** [Makefile:404: install-dep] Error 100
make[1]: Leaving directory '/builds/software/ias/networking/vpp'
make: *** [Makefile:373: /builds/software/ias/networking/vpp/build-root/.deps.ok] Error 2
Type: fix
Change-Id: I057cebf5e31c0f3eef42f7ad07c7759a2d8e7f73
Signed-off-by: Jay Wang <jay.wang2@arm.com>
Alexander Skorichenko [Wed, 5 Feb 2025 13:29:29 +0000 (14:29 +0100)]
urpf: fix multicast traffic
Type: fix
Change-Id: I937d5d8c89bd1e0cc6ff396df6e81ff96755702c
Signed-off-by: Maxim Babichev <maxim@netgate.com>
Signed-off-by: Alexander Skorichenko <askorichenko@netgate.com>
Semir Sionek [Thu, 13 Mar 2025 14:35:09 +0000 (10:35 -0400)]
hs-test: ignore some never used code paths for coverage generation
Type: fix
Change-Id: I4318efee62d7fdeb936b00aafd431a4927899f9b
Signed-off-by: Semir Sionek <ssionek@cisco.com>
Semir Sionek [Tue, 11 Mar 2025 12:05:31 +0000 (08:05 -0400)]
hs-test: shutdown VPP cleanly when finishing a testcase
Good practice in general, but especially helpful when SIGKILL'd VPP
can't write out coverage data.
Type: fix
Change-Id: I7e7261b6f2e63fd4a6b24a3832c32800c71493c2
Signed-off-by: Semir Sionek <ssionek@cisco.com>
Nicolas PLANEL [Thu, 27 Feb 2025 08:51:33 +0000 (09:51 +0100)]
dpdk: format UDP hw offload info consistently
Format the hardware offload info the same way than other protocol
to avoid confusion when reading logs, like this :
PKT_TX_SCTP_CKSUM (0x0000) SCTP cksum of TX pkt. computed by NIC
PKT_TX_TCP_CKSUM (0x0000) TCP cksum of TX pkt. computed by NIC
PKT_TX_UDP_CKSUM (0x0000) TX UDP cksum
Type: improvement
Change-Id: Icd16a484eabe36af4488352312245d638d7dff4b
Signed-off-by: Nicolas PLANEL <nplanel@cisco.com>
Signed-off-by: Nicolas PLANEL <nplanel@gmail.com>
Matus Fabian [Fri, 7 Mar 2025 09:34:59 +0000 (04:34 -0500)]
http: http_transport_connect TLS support
enable HTTPS for client apps
Type: improvement
Change-Id: I2ca8b926771a350863cca81729102faf6ee9c874
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Semir Sionek [Wed, 26 Feb 2025 16:50:23 +0000 (11:50 -0500)]
http_static: resize header response buffer if needed
Type: fix
Change-Id: If77469fbdf2b95b0c546a2d1de1cc8663464e1fc
Signed-off-by: Semir Sionek <ssionek@cisco.com>
Florin Coras [Fri, 7 Mar 2025 02:58:14 +0000 (21:58 -0500)]
vcl: improve vpp detatch handling
Better handling of multi-threaded applications that share sessions.
Type: improvement
Change-Id: Id69bcb1a4b1d67aab020beefdb2fa196ec2ee108
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 7 Mar 2025 03:15:23 +0000 (22:15 -0500)]
vcl: remove listen_no_mq from state to flag
One less state in state machine
Type: improvement
Change-Id: Ib6445a425b1e2d5a957318a94c3f132cddd8370b
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Sat, 8 Mar 2025 07:08:31 +0000 (02:08 -0500)]
session: improve endpoint cfg unit test
We are currently testing only active open from default to non-default
appns. Add connect test from non-default to default appns and make sure
transport cleans up ports.
Type: improvement
Change-Id: Id0f05aa295ac175b549d8035eb530dbb9a15d85d
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Thu, 6 Mar 2025 19:20:14 +0000 (14:20 -0500)]
session: fix lcl port allocation with fib
Type: fix
Change-Id: I0b0cc664cec2643a543a39cc7482292604381bf7
Signed-off-by: Florin Coras <fcoras@cisco.com>
Matus Fabian [Wed, 5 Mar 2025 14:06:59 +0000 (09:06 -0500)]
http_static: hss_ts_rx_callback fix
reset hs->data_len before handling new request
Type: fix
Change-Id: I5b02f8ec418c56e8ec607c5bc5c8716d53e5376f
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Florin Coras [Mon, 3 Mar 2025 21:19:01 +0000 (16:19 -0500)]
misc: add and consolidate host stack scripts
Move all existing host stack scripts under extras/scripts/host-stack
Also add scripts for iperf/vcl performance testing
Type: improvement
Change-Id: Ia79b6bd061db49f61a0e4c6577cf45afe0323eb1
Signed-off-by: Florin Coras <fcoras@cisco.com>
Vladislav Grishenko [Fri, 29 Oct 2021 15:40:52 +0000 (20:40 +0500)]
papi: fix socket api max message id calculation
In case of sparse message ids due fixed offsets, length of
the message table is less than max message id, causing
"IndexError: list assignment index out of range" exception
in _register_function() due "self.id_msgdef[i] = msg".
Unlike shmem api, socket api needs to use max id.
Type: fix
Signed-off-by: Vladislav Grishenko <themiron@yandex-team.ru>
Change-Id: Ib777db9dabc3a5a3ff83f07ec211cf2fb3c15cf0
Signed-off-by: Ole Troan <otroan@employees.org>
Matus Fabian [Fri, 28 Feb 2025 15:15:15 +0000 (10:15 -0500)]
http: http2 frames
Type: feature
Change-Id: Id2c6f6b5747c1f676048642e277eb66850f728b7
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Florin Coras [Sun, 2 Mar 2025 23:40:11 +0000 (18:40 -0500)]
vppinfra: make verbose format time more verbose
Dump more cpu and reftime fields in clib time struct. Example:
DBGvpp# sh clock verbose
Time now 6.890267
cpu time 6.890267 now
22333609568369233 last
22333609568350337 since start
19981775480
reftime 6.890268 now
1740958292.416887 last
1740958285.526620 init
1740958285.526620
error 0.000000, clocks/sec
2900000000.000000, Sun, 02 Mar 2025 23:31:32 GMT
Time last barrier release 3.
291883104
0: Time now 6.890387
cpu time 6.890387 now
22333609568706225 last
22333609568696497 since start
19982121640
reftime 6.890387 now
1740958292.417007 last
1740958285.526620 init
1740958285.526620
error -.000001, clocks/sec
2900000000.000000
Thread 0 offset 0.
000000000 error 0.
000000000
1: Time now 5.695180
cpu time 5.695180 now
22333609568926421 last
22333609568920073 since start
16516023212
reftime 5.695181 now
1740958292.417084 last
1740958286.721903 init
1740958286.721903
error -.000001, clocks/sec
2900000000.000000
Thread 1 offset 1.
195283275 error -.
000000114
Type: improvement
Change-Id: I383b9b1a2ef64a731bbc335cd512d565d47f0cd9
Signed-off-by: Florin Coras <fcoras@cisco.com>
Adrian Villin [Thu, 27 Feb 2025 14:04:56 +0000 (15:04 +0100)]
session: uri parsing improvements
- It is now possible to use "proto://ip4:port/target" or
"proto://[ip6]:port/target" format.
- Updated http_client and related tests to use the new format
Type: improvement
Change-Id: Ic6afd8c66eddca2ab1d7afc034e193441c34f8ee
Signed-off-by: Adrian Villin <avillin@cisco.com>
Florin Coras [Fri, 28 Feb 2025 03:13:19 +0000 (22:13 -0500)]
session: ignore tx evts for cl sessions with no fifo
Type: fix
Change-Id: I3e484ed3447dde3540c39b2c5c5ce26329c83340
Signed-off-by: Florin Coras <fcoras@cisco.com>
Andrew Yourtchenko [Thu, 23 Jan 2025 11:43:20 +0000 (12:43 +0100)]
misc: VPP 25.02 Release Notes
Type: docs
Change-Id: Iff452c28396159f7818e0a294daa0277870077f4
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
(cherry picked from commit
af12ed005d50809e130b93a4d9c934a961081dcf)
Bence Romsics [Tue, 27 Feb 2024 12:18:16 +0000 (13:18 +0100)]
docs: Restore and update nat section of progressive tutorial
The NAT section of the Progressive Tutorial was likely accidentally lost
in If5b0d07ea90d978c6b1f11210a661876b7929653. This patch restores it. It
is also updated to reflect current package and plugin names and cli
reference links.
Type: docs
Change-Id: Ifb6117cd00768fd05dccfa506b4e97c81f9bcf21
Signed-off-by: Bence Romsics <bence.romsics@gmail.com>
Matus Fabian [Tue, 25 Feb 2025 11:52:25 +0000 (06:52 -0500)]
http: hpack headers encoding
1) header encoding without dynamic table
2) serialization of response header block
Type: feature
Change-Id: I7ec470310e5aec0f8055492e92682261b4af5e81
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Matus Fabian [Thu, 27 Feb 2025 11:00:28 +0000 (06:00 -0500)]
hs-test: make docker cache dir multi-user friendly
Type: test
Change-Id: Ib569a48b61e337e3a1bef5ba5b37d10e3322c44a
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Matus Fabian [Thu, 27 Feb 2025 10:33:57 +0000 (05:33 -0500)]
hs-test: create docker buildx with proxy
Type: test
Change-Id: If887916bc540a51747e342a76edc2f37d54e6b0f
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Matus Fabian [Thu, 27 Feb 2025 09:45:41 +0000 (04:45 -0500)]
hs-test: fix make install-deps
run apt-get commands with sudo
Type: test
Change-Id: I1044be65a21bd8a830c11f53239accf2cf86c33d
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Benoît Ganne [Wed, 26 Feb 2025 15:06:23 +0000 (16:06 +0100)]
abf: run abf after reassembly
If reassembly is enabled, make sure to apply ABF after reassembly.
Type: fix
Change-Id: Ic12ccba34a9e4d13caba1821e8175ee5adc7f8c3
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Akeel Ali [Thu, 9 Jan 2025 17:01:13 +0000 (12:01 -0500)]
linux-cp: Add support for LACP packets
This patch adds support to mirror LACP packets between host and phy.
It is needed for the Sonic-VPP project to support LAG and allow Sonic
to run LACP in the control plane.
The change has 3 parts:
(1) Converted lip_punt_node to lip_punt_xc_inline, which now supports
the creation of two distinct nodes: lip_punt_node and lip_punt_xc_node.
lip_punt_node retains its original punt functionality.
lip_punt_xc_node supports both punt and x-connect between host & phy.
(2) Add 2 new API (and corresponding CLI) to the linux-cp plugin:
(A) lcp_ethertype_enable ("lcp ethertype enable <ethertype>")
(B) lcp_ethertype_get ("show lcp ethertype")
(3) Add UT to test the new functionality and API/CLI for LACP and LLDP.
Type: improvement
Change-Id: Iab66e3b29351dcf2c471babd4f1ef4bdd19da46e
Signed-off-by: Akeel Ali <akeelapi@gmail.com>
Semir Sionek [Fri, 21 Feb 2025 14:09:29 +0000 (09:09 -0500)]
http_static: squash subsequent forward slashes in request target path
In the file handler, squash groups of forward slashes during path
sanitation to minify the risk of running out of memory.
Type: fix
Change-Id: Ic29d691f876b891ff588157851334162b4e3c5e3
Signed-off-by: Semir Sionek <ssionek@cisco.com>
Matus Fabian [Tue, 18 Feb 2025 09:29:10 +0000 (04:29 -0500)]
http: hpack headers decoding
1) parsing of binary format (RFC7541 section 6)
2) simple dynamic table implementation
3) parsing of request header block
Type: feature
Change-Id: If43e175a0643f9731c15efc412a82345d9e33cee
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Nikita Skrynnik [Wed, 24 Jan 2024 01:09:47 +0000 (12:09 +1100)]
ping: Check only PING_RESPONSE_IP4 and PING_RESPONSE_IP6 events
Check only PING_RESPONSE_IP4 and PING_RESPONSE_IP6
in ping binary API so it doesn't block other binary API
requests while working. (current version of ping binary API
can read other events like SOCKET_READ_EVENT, for example).
Type: fix
Change-Id: Ie7c5c92322af28633680c9c0d60fed739d4e65a0
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Nicolas PLANEL [Mon, 24 Feb 2025 10:33:43 +0000 (11:33 +0100)]
build: generate TAGS file for emacs
Type: improvement
Change-Id: I7915b674f22184deed6a63a6ed66193d216c65e4
Signed-off-by: Nicolas PLANEL <nplanel@cisco.com>
Signed-off-by: Nicolas PLANEL <nplanel@gmail.com>
Piotr Bronowski [Thu, 20 Feb 2025 11:18:57 +0000 (11:18 +0000)]
ipsec: coverity warning, issue CID 509068
UNUSED_VALUE warning fixed.
Type: fix
Change-Id: Idd1f0fab96f252f2081d5c268ecc722223289477
Signed-off-by: Piotr Bronowski <piotrx.bronowski@intel.com>
lajoskatona [Wed, 8 May 2024 15:02:54 +0000 (17:02 +0200)]
vxlan: move vxlan-gpe to a plugin
Move vxlan-gpe folder under vnet to the plugin folder,
update cmake configuration and header paths,
and add plugin.c to register plugin.
JIRA: VPP-2059
Type: improvement
Change-Id: I31b6d326276c4aa684fcdcf8443ef349f7816a6d
Signed-off-by: lajoskatona <katonalala@gmail.com>
Signed-off-by: Nicolas PLANEL <nplanel@cisco.com>
Florin Coras [Mon, 24 Feb 2025 05:20:32 +0000 (00:20 -0500)]
udp: fix cli for next node and opaque
Type: fix
Change-Id: I77c2d8e64ed463b1c8e84e0fca8d79684a88714c
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Thu, 20 Feb 2025 05:55:07 +0000 (00:55 -0500)]
session: trace all packets sourced by session layer
Trace both packets generated by dispatching sessions and those that have
been enqueued by other nodes, e.g., syns, fins, acks enqueued by tcp
input and output.
Because not all buffer sources know the session, remove for now the
session index from the trace. Nonetheless, next node on path will print
it, so no information is lost.
Type: improvement
Change-Id: Id69094fbf00e6bc8f98095e90cdf20e2b7f0aeda
Signed-off-by: Florin Coras <fcoras@cisco.com>
Alexander Slesarev [Thu, 17 Oct 2024 19:52:06 +0000 (15:52 -0400)]
libmemif: Fixed strlcpy symbol detection.
Type: fix
libmemif can't be compiled with the modern glibc (since 2.38)
and musl as they include strlcpy for _GNU_SOURCE by default now.
The change introduced:
- proper symbol detection for both strlcpy and memfd_create;
- bumped CMake version requirements due to soon-to-be failed
compilation for very old version;
- fixed Unity compilation on the modern compilers (it has warnings,
but compiled with `-Werror`).
Change-Id: I48f9c410aa5405174dc6b65e9c9001e8b11ba276
Signed-off-by: Alexander Slesarev <aslesare@cisco.com>
Matus Fabian [Wed, 19 Feb 2025 20:44:36 +0000 (15:44 -0500)]
vppinfra: bihash_vec8_8 set key in mark_free
When key not set to ~0 clib_bihash_key_compare_vec8_8 do not skip empty
slot during search and we crash.
Type: fix
Change-Id: I48f510bceffcfb5e4851dd757cad055a6f7f12d0
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Matus Fabian [Fri, 7 Feb 2025 19:34:42 +0000 (14:34 -0500)]
http: hpack primitive types
RFC7541 section 5, Huffman encoding included
Type: feature
Change-Id: I5a024f654610729b8f3f53734aa242bb4b5a25fe
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Dave Wallace [Sat, 15 Feb 2025 01:53:47 +0000 (20:53 -0500)]
build: make clang the default compiler for build targets
- fixes compiler version for hs-test and other CI jobs which
default to CC=cc in make
- not all build targets compile successfully with clang (e.g.
libmemif, xdp-tools) which are hard-coded to use gcc for now
Type: fix
Change-Id: I505e67a08687f17fd4e26e1a3c236fb7c54ff49d
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Piotr Bronowski [Thu, 6 Feb 2025 09:01:44 +0000 (09:01 +0000)]
ipsec: add tests for bypass/discard ipv6 policies and upd encapsulation
Support for ipv6 policy mode bypass and discard policies has been introduced.
Also ipsec traffic may be sent encapsulated in udp packages.
With this change both types of policies are testeg together with udp encapsulation.
Type: test
Change-Id: I9ec0c5154af6f654143f9e5104f10311cda1a514
Signed-off-by: Piotr Bronowski <piotrx.bronowski@intel.com>
Piotr Bronowski [Thu, 6 Feb 2025 09:00:47 +0000 (09:00 +0000)]
ipsec: enable support for ipv6 udp ipsec encapsulation in policy mode
IPSec traffic may be sent encapsulated inside UDP packagaes.
In case of esp packgaes decryption is required (according to defined policies),
whereas IKE traffic should be bypassed (relevant policy needs to be defined).
With this patch required behaviour is provided.
Type: feature
Change-Id: If99c7bf121db881c0bdf2b45e6fdca87c0d872a5
Signed-off-by: Piotr Bronowski <piotrx.bronowski@intel.com>
Piotr Bronowski [Thu, 6 Feb 2025 08:38:29 +0000 (08:38 +0000)]
ipsec: add support for bypass and discard policies for ipv6
In case of ipv6 addresses spd did not support bypass and discard policies.
This change introduces missing implementation
in the same way as it was implemented for ipv4.
Type: feature
Change-Id: Idad974655b209d946414d7d85037d0783cde7db3
Signed-off-by: Piotr Bronowski <piotrx.bronowski@intel.com>
Artem Glazychev [Wed, 14 Aug 2024 04:16:23 +0000 (11:16 +0700)]
sr: fix sr_policy fib table
fib_table_get_flow_hash_config accepts fib_index, not fib_table.
Type: fix
Change-Id: I0372ca1b6caab4a34bc0590f9856d89deff6ee90
Signed-off-by: Artem Glazychev <glazychev@mts.ru>
Mohsin Kazmi [Mon, 10 Feb 2025 11:19:47 +0000 (11:19 +0000)]
ip: add support to preallocate pools
Type: improvement
In certain use cases, the underlying pools expand by allocating a new,
larger pool and copying the existing elements into it. This process
can be time-consuming, leading to slower control plane configurations,
especially when a large number of elements are already present.
This patch allows users to pre-configure some of these pools through
startup.conf.
It also fixes alignment for ip4 mtrie.
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Change-Id: Ib0f1d40e3efb8b4fce989219196c718d6834498a
Benoît Ganne [Fri, 14 Feb 2025 18:27:51 +0000 (19:27 +0100)]
build: use clang by default when using Makefile
Change https://gerrit.fd.io/r/c/vpp/+/42189 changed default compiler
from clang to GCC as a side effect when using Makefile.
Restore default behavior.
Type: fix
Fixes:
b7a00271990b67458afd2e660f92ebf3ebb6f887
Change-Id: I3478fa7c5e2132486a4c3b9d8363c60ed81b0d43
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Florin Coras [Sat, 8 Feb 2025 06:49:53 +0000 (01:49 -0500)]
session: improve chained buffer enqueue
Type: improvement
Change-Id: I86497255cd2a73e37ae9be61dcce3a27199c552f
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Fri, 14 Feb 2025 06:24:21 +0000 (01:24 -0500)]
tcp: improve exception checks for established connections
Separate exception state checks, e.g., no connection or closed, from
segment validation. Segments with no ack, rst, syn flag should not be
received in established node. Still, leave the check in for now.
Type: improvement
Change-Id: I7ceb01d7133f3a571e18721b6e51ff79f533f8cb
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Thu, 13 Feb 2025 22:52:27 +0000 (23:52 +0100)]
ipsec: better pack outbound SA runtime data
Type: improvement
Change-Id: I9a0437dcfaf5e6930bb7fa057866ea36e7ca328f
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 13 Feb 2025 20:21:15 +0000 (21:21 +0100)]
ipsec: keep inbound seq as u64
Type: improvement
Change-Id: I03f0b6137db6780f2c2935df90e98acf4bd471f9
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 13 Feb 2025 17:56:16 +0000 (18:56 +0100)]
ipsec: combine huge and normal anti-replay-window handling
Type: improvement
Change-Id: Idfbaf56e3b56e77c8deaca9d3e41f7a78d8c4e0b
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 13 Feb 2025 16:09:52 +0000 (17:09 +0100)]
ipsec: embed anti-replay bitmap in the runtime data
Type: improvement
Change-Id: I753917c6d7e30b8d5e3291b85a7532a455ebc2bb
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 13 Feb 2025 15:39:35 +0000 (16:39 +0100)]
ipsec: store anti_replay_window_size in runtime data
Type: improvement
Change-Id: I0626af365855ad5301419e72e9430a47a5d0e5d7
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 13 Feb 2025 14:37:13 +0000 (14:37 +0000)]
vppinfra: add few uword_bitmap_* functions
Change-Id: I592668a385489d0eaccd9e7693121ff25090e353
Type: improvement
Signed-off-by: Damjan Marion <damarion@cisco.com>
Benoît Ganne [Thu, 13 Feb 2025 15:19:59 +0000 (16:19 +0100)]
session: make sure we cannot pass wrong IO event type
GCC 11 complains about potential cast from u32 to session_t.
Type: fix
Change-Id: Id777e339c40e0ea3c3c8b2b0800acf7cd7a4ced3
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Adrian Villin [Thu, 6 Feb 2025 13:22:17 +0000 (14:22 +0100)]
build: fix broken HST gcov build
- also added a "NO_COLOR" option for HS tests
- http coverage is not generated for now
Type: make
Change-Id: Ib58672ae6035fda01efee933ebf35a1dd48e8afa
Signed-off-by: Adrian Villin <avillin@cisco.com>
Florin Coras [Wed, 12 Feb 2025 06:43:45 +0000 (01:43 -0500)]
tcp: rename worker ctx to just wrk
Align with session layer (also less typing in gdb ..)
Type: refactor
Change-Id: I1455a1aa3e3bad7b53fe638a678774b88b9969b9
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Sat, 8 Feb 2025 05:19:06 +0000 (00:19 -0500)]
session: move io inlines to header file
Make sure compiler can optimize out constants.
Type: improvement
Change-Id: I3982d4b2cf1e0e08e31a0836fd64fab82564a7d6
Signed-off-by: Florin Coras <fcoras@cisco.com>
Matthew Smith [Mon, 27 Jan 2025 19:49:07 +0000 (19:49 +0000)]
vrrp: force sleeps between timer events
Adding a virtual MAC to some NICs can take a significant amount of time.
If a lot of VRs enter the master state around the same time, the process
node can stay active for a very long time processing all of the transitions.
Try to force a 10 us sleep between processing events to ensure that the
process node does not prevent API messages and RPCs from being handled for
an extended period.
Type: improvement
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Change-Id: I400a7d395b4c0fec371f70d359e9d184ae79645e
Matus Fabian [Mon, 27 Jan 2025 13:12:22 +0000 (08:12 -0500)]
http: modularization in preparation for h2 and h3
Prepare code to handle multiple http versions and move http/1
specific code into http1.c
Type: improvement
Change-Id: I1f2c958dadb7721b305c65b2da7c2943695ad740
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Adrian Villin [Fri, 24 Jan 2025 12:56:22 +0000 (13:56 +0100)]
hsa: http client parallel sessions
- client is now able to use multiple workers to send requests
(sometimes it uses multiple sessions on a single worker)
Type: feature
Change-Id: I2d83d47a9768011b3d8d05ed320852606841e4b8
Signed-off-by: Adrian Villin <avillin@cisco.com>
Ivan Ivanets [Mon, 10 Feb 2025 13:10:55 +0000 (13:10 +0000)]
build: add socat deb package
Type: improvement
Integrated the installation of the socat deb package into the make
install-dep target.
Socat is essential for enabling communication with
the VPP CLI over UNIX domain socket.
Signed-off-by: Ivan Ivanets <iivanets@cisco.com>
Change-Id: I14f270eea23db7f7e0b20b7b67f75dd72ad734da
Damjan Marion [Mon, 10 Feb 2025 19:34:47 +0000 (20:34 +0100)]
build: replace __FUNCTION__ with C11 __func__
Type: improvement
Change-Id: I6cf7aaf42e8c0738d5b677fa66c99f071c1526bb
Signed-off-by: Damjan Marion <damarion@cisco.com>
Adrian Villin [Mon, 10 Feb 2025 09:13:38 +0000 (10:13 +0100)]
hs-test: option to skip tests using cli args
Type: test
Change-Id: Ic0fd117c53a3547cebfca38d089b5ba3f79cca28
Signed-off-by: Adrian Villin <avillin@cisco.com>