vpp.git
5 years agoavf: fix eat own tail issue on tx 90/17790/2
Damjan Marion [Fri, 22 Feb 2019 16:25:00 +0000 (17:25 +0100)]
avf: fix eat own tail issue on tx

Change-Id: Ie14ca18bab47ac6765ff0799475d0c2a4d936f90
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agophysmem: keep physmem VA in 39-bit address space on x86_64 74/17774/2
Damjan Marion [Thu, 21 Feb 2019 13:44:59 +0000 (14:44 +0100)]
physmem: keep physmem VA in 39-bit address space on x86_64

Some x86 CPUs have IOMMU capable dealing only with 39-bit address space
This patch also adds option to specify physmem base address from
startup.conf

Change-Id: I9e8abd26efb60e9c4ad54c035fb1751a4a61f4dc
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoAdd no-append flag to vlib_frame_t 73/17773/1
Damjan Marion [Thu, 21 Feb 2019 19:24:54 +0000 (20:24 +0100)]
Add no-append flag to vlib_frame_t

Change-Id: I01c4f5755d579282773ac227b0bc24f8ddbb2bd1
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoIP route local and connected 75/17175/3
Neale Ranns [Wed, 23 Jan 2019 08:36:16 +0000 (00:36 -0800)]
IP route local and connected

allow routes that are local and connected to be added via the API.
this emulates the addition of a second address in the same subnet
added to an interface.

Change-Id: Ib18a08c26956be9a07b3360664210c8cf6734c84
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit 7425f9289bdc17d330044b0df0fc31cdeeca626b)

5 years agoFIB: pass a copy the walk context 15/17715/1
Neale Ranns [Thu, 14 Feb 2019 14:58:40 +0000 (14:58 +0000)]
FIB: pass a copy the walk context

since it can realloc when new ctx are added. If
not we can get some nasty memory corruption.

Change-Id: I617709c3013acbcb8aee07dc147894f0de896555
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit 58085f2f6757e464196b283cc8335ab5cf34a012)

5 years agoRevert "bond: problem switching from l2 to l3" 94/17694/1
Peter Mikus [Thu, 14 Feb 2019 07:44:14 +0000 (07:44 +0000)]
Revert "bond: problem switching from l2 to l3"

During CSIT testing we discovered that LACP tests were failing and
producing coredumps. Reverting this patch fix the problem with VPP
crashing.

This reverts commit f23890138e02d4218c828c427f687f8ecdb0e165.

Change-Id: Icf97053ce1473350add885cbebe591f7f3efcbea
Signed-off-by: Peter Mikus <pmikus@cisco.com>
5 years agotcp: fix reset sending in syn-sent 93/17393/2
Florin Coras [Thu, 7 Feb 2019 08:15:53 +0000 (00:15 -0800)]
tcp: fix reset sending in syn-sent

Change-Id: I468b1015bca5f95b162fb49e904aa4e4d38db75e
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit d4c49be5e20406220cf89083c9df86c3c0761a81)

5 years agoFix borken install-dep on RHEL 09/17309/1
Yichen Wang [Tue, 5 Feb 2019 06:27:20 +0000 (22:27 -0800)]
Fix borken install-dep on RHEL

Change-Id: I247cca88e33f782e1acb72eb2c0e1515faf2f030
Signed-off-by: Yichen Wang <yicwang@cisco.com>
5 years ago19.01 Release Notes 25/16925/5 v19.01
Andrew Yourtchenko [Sun, 20 Jan 2019 18:32:44 +0000 (19:32 +0100)]
19.01 Release Notes

Change-Id: I43fd3aac9039c6d551fac8607374a0ebfdc6f74a
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agoipsec: fix check support functions 73/17173/4
Klement Sekera [Wed, 30 Jan 2019 10:11:23 +0000 (11:11 +0100)]
ipsec: fix check support functions

Change-Id: If94c57fbb07a7376a9f2873e1489c00b28152620
Signed-off-by: Klement Sekera <ksekera@cisco.com>
(cherry picked from commit 4fd5a9d3e6abdf61f266da8400a299fe5b0eb0ed)

5 years agoVTL: Fix pep8 test/test_syslog.py 79/17179/2
Paul Vinciguerra [Tue, 29 Jan 2019 20:27:16 +0000 (12:27 -0800)]
VTL: Fix pep8 test/test_syslog.py

Change-Id: I8894a7a8f2be117a4c1cec9ce5134a1572da7ec7
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
(cherry picked from commit 776e46d77c21899874d156a48b8d89e7133d212c)

5 years agoUpdate version (19.01) for API changes script 42/16942/2
Andrew Yourtchenko [Mon, 21 Jan 2019 15:50:47 +0000 (16:50 +0100)]
Update version (19.01) for API changes script

Change-Id: I9c39b5076d366b3455a875df32765b2cb8f3eca2
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agoUpdate to doxygen documentation for release 19.01 29/16929/3
Andrew Yourtchenko [Mon, 21 Jan 2019 14:22:05 +0000 (15:22 +0100)]
Update to doxygen documentation for release 19.01

Change-Id: Id19cefc24d391f0437a0355f5328505ec21aa58a
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agoavf: fix queue enable issue 23/17123/1
Damjan Marion [Thu, 24 Jan 2019 13:41:35 +0000 (14:41 +0100)]
avf: fix queue enable issue

It is actually a bitmap....

Change-Id: Ie359e085df3f371512f773600f8d7460b2232b3e
Signed-off-by: Damjan Marion <damjan.marion@gmail.com>
5 years agoIP6 FIB: walk table for dump (VPP-1553) 85/17085/1
Neale Ranns [Fri, 25 Jan 2019 08:51:09 +0000 (00:51 -0800)]
IP6 FIB: walk table for dump (VPP-1553)

Change-Id: Iaa57ace6df96bfacd1235c80ec7bb08e5f335530
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit 5c1f559b1bf32acd528664e7674a2d46f2aed947)

5 years agobond: packet drops on VPP bond interface [VPP-1544] 29/17029/1
Steven [Thu, 17 Jan 2019 23:11:29 +0000 (15:11 -0800)]
bond: packet drops on VPP bond interface [VPP-1544]

We register callback for VNET_HW_INTERFACE_LINK_UP_DOWN_FUNCTION and
VNET_SW_INTERFACE_ADMIN_UP_DOWN_FUNCTION to add and remove the slave
interface from the bond interface accordingly. For static bonding without
lacp, one would think that it is good enough to put the slave interface into
the ective slave set as soon as it is configured. Wrong, sometimes the slave
interface is configured to be part of the bonding without ever bringing up the
hardware carrier or setting the admin state to up. In that case, we send
traffic to the "dead" slave interface.

The fix is to make sure both the carrier and admin state are up before we put
the slave into the active set for forwarding traffic.

Change-Id: I93b1c36d5481ca76cc8b87e8ca1b375ca3bd453b
Signed-off-by: Steven <sluong@cisco.com>
(cherry picked from commit e43278f75fe3188551580c7d7991958805756e2f)

5 years agoldp: add support for TCP_CONGESTION sockopts (VPP-1550) 47/16947/1 v19.01-rc2
Florin Coras [Mon, 21 Jan 2019 17:03:10 +0000 (09:03 -0800)]
ldp: add support for TCP_CONGESTION sockopts (VPP-1550)

Change-Id: I0fcf3385cc4fb96f000b84d5f880f74131c0d60f
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 0ed24e93b207850078ca7f58cd4106cc4a906952)

5 years agodoxygen formatting fix: prevent stray examples appearing in the docs 31/16931/1
Andrew Yourtchenko [Mon, 21 Jan 2019 15:01:41 +0000 (16:01 +0100)]
doxygen formatting fix: prevent stray examples appearing in the docs

The 'example' keyword triggers the creation of very out-of-context
example in the "Examples" top level of documentation. Rename the
keyword in the comment so the comment is still readable, but
does not trigger the doxygen.

Change-Id: Iecbdc236918f9178a034817aa6cea7ab6b2c1654
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agosession: add support for vrf in session unformat (VPP-1546) 12/16912/2
Florin Coras [Sat, 19 Jan 2019 19:29:18 +0000 (11:29 -0800)]
session: add support for vrf in session unformat (VPP-1546)

Change-Id: Ic5ba751c2bd2db9af4a21d3db40cc305d1208c30
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit baee8d498830bbbf54ec76e7c0c887c6373fe985)

5 years agotcp: fix debugging without cc stats (VPP-1547) 13/16913/1
Florin Coras [Sun, 20 Jan 2019 00:45:13 +0000 (16:45 -0800)]
tcp: fix debugging without cc stats (VPP-1547)

Change-Id: I376856fcadce570bb555064435f5876eefb2befa
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 0702554639e5149d9012cc196aa43c3c8d0d7f9b)

5 years agofix data_length in IpSec API call (VPP-1548) 70/16870/5
Michal Cmarada [Fri, 18 Jan 2019 11:51:08 +0000 (12:51 +0100)]
fix data_length in IpSec API call (VPP-1548)

Change-Id: Idb2839f6082bd2e052be2bc5417f0ebb43d1c0a6
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
5 years agoVOM: ip-mroute inspect register handler fix 76/16876/2
Neale Ranns [Thu, 17 Jan 2019 16:28:58 +0000 (08:28 -0800)]
VOM: ip-mroute inspect register handler fix

Change-Id: I57689446005da00fa064e2938cfe55a9e1cef9fc
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit d870ce441272d7057c8cb2b8f9731ebe41a17f0a)

5 years agotcp: allow data in passive open ack (VPP-1545) 96/16896/1
Florin Coras [Fri, 18 Jan 2019 20:12:29 +0000 (12:12 -0800)]
tcp: allow data in passive open ack (VPP-1545)

Change-Id: Iceb99d3f8b7029bd1b1e9ebafb1e0b3790c573e4
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 865872ebdb2bbaf3f157e2a9889405b84114d2eb)

5 years agoVTL: Use latest version of syslog_rfc5424_parser (0.2.0) released: 190117 90/16890/2
Paul Vinciguerra [Fri, 18 Jan 2019 16:20:31 +0000 (08:20 -0800)]
VTL: Use latest version of syslog_rfc5424_parser (0.2.0) released: 190117

Upstream changes not compatable with: https://gerrit.fd.io/r/#/c/16797/

Running tests using custom test runner
Active filters: file=test_syslog.py, class=None, function=None
Adding tests from directory tree /vpp/test
1 out of 914 tests match specified filters
Not running extended tests (some tests will be skipped)
==============================================================================
Syslog Protocol Test Cases
==============================================================================
Syslog Protocol test                                                     OK

==============================================================================
TEST RESULTS:
     Scheduled tests: 1
      Executed tests: 1
        Passed tests: 1
==============================================================================

Test run was successful

Change-Id: I42f86ae3e7f062c0343025ba16bc6e8d2c34ed50
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
(cherry picked from commit 5011c67058c3c37d344c5d83ab6046700327b7b4)

5 years agoInitial changes for stable/1901 branch 42/16842/1 v19.01-rc1
Andrew Yourtchenko [Wed, 16 Jan 2019 18:26:41 +0000 (19:26 +0100)]
Initial changes for stable/1901 branch

This patch adds an entry for the defaultbranch in .gitreview

Change-Id: I3dc45492ec51b10524b0a6d894c7e42c352f0daa
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agomake test: raise packet tracing limit to 1000 26/16826/4
Klement Sekera [Tue, 15 Jan 2019 12:25:09 +0000 (13:25 +0100)]
make test: raise packet tracing limit to 1000

Change-Id: I4309cefe13ee861342e7962c7652919a47748656
Signed-off-by: Klement Sekera <ksekera@cisco.com>
5 years agoDOC ONLY: update readme.md 36/16836/1
Dave Barach [Wed, 16 Jan 2019 13:21:16 +0000 (08:21 -0500)]
DOC ONLY: update readme.md

Remove the source code, replace with reference to the upstreamed
patch.

Change-Id: I6f5430b1e9804530afbec1805353852e1da745d6
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agovmxnet3: add numa support and link speed 31/16831/1
Steven [Tue, 15 Jan 2019 17:26:18 +0000 (09:26 -0800)]
vmxnet3: add numa support and link speed

Allocate physmem on the same numa
set link speed
cap vmxnet3 support version to 3 if the device supports higher version

Change-Id: Id47dd83b0da53e623fd6cf3ad010e58158b1ab15
Signed-off-by: Steven <sluong@cisco.com>
5 years agoapi_helper_macro mp->pid is network endian 20/16720/4
Ole Troan [Mon, 7 Jan 2019 21:17:31 +0000 (22:17 +0100)]
api_helper_macro mp->pid is network endian

Change-Id: I7d2385b9e9bf5a62f3e9382ca2627a74a4e30785
Signed-off-by: Ole Troan <ot@cisco.com>
5 years agoVTL: vpp_papi_provider: Don't shortcircuit vpp_papi jasonfile detection. 92/16792/3
Paul Vinciguerra [Sun, 13 Jan 2019 18:26:05 +0000 (10:26 -0800)]
VTL: vpp_papi_provider: Don't shortcircuit vpp_papi jasonfile detection.

The detection login in vpp_papi is significantly more advanced than
the implementation in vpp_papi_provider.

Let's take full advantage of it and ensure consistent behavior.

Change-Id: I786e6d5f4588a0d74e863cce1b0bc1a93fa0e614
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoVTL: Allow running simple unittest.TestCases. 95/16795/12
Paul Vinciguerra [Mon, 14 Jan 2019 00:09:10 +0000 (16:09 -0800)]
VTL:  Allow running simple unittest.TestCases.

It came to my attention that Ole added a simple test in:
https://gerrit.fd.io/r/#/c/16381/ and the framework forced him
to launch an instance of VPP to test the formatting of a mac address.

This change allows the test framework to run standard unittest.TestCases
without the need to spawn a VPP instance.

Change-Id: I56651ab27c4c6bf920081a526f168a743d643201
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoVTL: New version of pyparsing breaks tests. 97/16797/2
Paul Vinciguerra [Mon, 14 Jan 2019 06:00:46 +0000 (22:00 -0800)]
VTL: New version of pyparsing breaks tests.

Specify use of version <2.3.1 released Jan 13, 2019

Change-Id: I23cfb802a677956b77897e0c2b690fac50e18541
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoremove useless line in dpdk cryptodev 29/16729/2
Simon Zhang [Wed, 9 Jan 2019 01:25:18 +0000 (09:25 +0800)]
remove useless line in dpdk cryptodev

Change-Id: I2ef33c7c15b3eb1f55bbfd5cbdd230d6a4d58936
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
5 years agobonding: support custom interface IDs 65/16465/8
Alexander Chernavin [Thu, 13 Dec 2018 14:08:09 +0000 (09:08 -0500)]
bonding: support custom interface IDs

Change-Id: I78fe58144fa3ba2e1c7135897a13a2541f235c91
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
5 years agodpdk: show hardware may display the wrong information for rss active 66/16766/2
Steven [Fri, 11 Jan 2019 16:29:41 +0000 (08:29 -0800)]
dpdk: show hardware may display the wrong information for rss active

Some dpdk driver does not support rte_eth_dev_rss_hash_conf_get. When that
happens, we display whatever that was in the stack variable for rss_hf which
is confusing.

The fix is to clear rss_hf prior to the call.

Before the fix
--------------
DBGvpp# sh hard
              Name                Idx   Link  Hardware
format_dpdk_device:599: rte_eth_dev_rss_hash_conf_get returned -95
GigabitEthernet13/0/0              2     up   GigabitEthernet13/0/0
  Link speed: 10 Gbps
  Ethernet address 00:0c:29:c4:8c:eb
  VMware VMXNET3
  ...
    rss avail:         ipv4 ipv4-tcp ipv6 ipv6-tcp
    rss active:        ipv4 ipv4-frag ipv4-tcp ipv4-udp ipv4-other

After the fix
-------------
DBGvpp# sh hard
              Name                Idx   Link  Hardware
format_dpdk_device:600: rte_eth_dev_rss_hash_conf_get returned -95
GigabitEthernet13/0/0              2     up   GigabitEthernet13/0/0
  Link speed: 10 Gbps
  Ethernet address 00:0c:29:c4:8c:eb
  VMware VMXNET3
  ..
    rss avail:         ipv4 ipv4-tcp ipv6 ipv6-tcp
    rss active:        none

Change-Id: If8f8327f0012eecc8d23cd7f3f9cc581ca025654
Signed-off-by: Steven <sluong@cisco.com>
5 years agosession: generate wrong thread errors instead of crashing 58/16758/4
Florin Coras [Thu, 10 Jan 2019 20:42:47 +0000 (12:42 -0800)]
session: generate wrong thread errors instead of crashing

Change-Id: I7e59ae718d2722c49d42b22a0874e1645a191e89
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoFix custom-dump for gre_add_del_tunnel: src and dst IPs 67/16767/2
Igor Mikhailov (imichail) [Fri, 11 Jan 2019 21:59:04 +0000 (13:59 -0800)]
Fix custom-dump for gre_add_del_tunnel: src and dst IPs

Change-Id: I747ca01dc8df9fb5e11168ec46979c4a1f1baa7c
Signed-off-by: Igor Mikhailov (imichail) <imichail@cisco.com>
5 years agoFix 'show interface span' field length 68/16768/1
Igor Mikhailov (imichail) [Fri, 11 Jan 2019 22:03:53 +0000 (14:03 -0800)]
Fix 'show interface span' field length

Allow to display longer interface names, e.g. VirtualEthernet0/0/0.102
The field length (32) is now the same as for 'show interface'.

Change-Id: I1cb1efd459acb800bfaeeec40b672c8b17cd8c3d
Signed-off-by: Igor Mikhailov (imichail) <imichail@cisco.com>
5 years agoFix interactive tests 49/16749/4
juraj.linkes [Thu, 10 Jan 2019 11:13:07 +0000 (12:13 +0100)]
Fix interactive tests

When running tests interactively (i.e. not using child process) the
tests are split into small suites each containing tests from a
VPPTestCase, but only the first suite is run. Fix this by creatin a new
suite with all of these small suites in it and running that suite.

Change-Id: I0236f4a980d01765eb993f41d54d98640bb2cd39
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
5 years agogbp2: Fix typo in condition 15/16715/6
Mohsin Kazmi [Mon, 7 Jan 2019 14:33:13 +0000 (15:33 +0100)]
gbp2: Fix typo in condition

Change-Id: I1b327309586c9234a22cda011953a1940d31e1ba
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agostrncpy_s_inline copies more bytes than necessary 23/16723/2
Steven [Tue, 8 Jan 2019 04:32:01 +0000 (20:32 -0800)]
strncpy_s_inline copies more bytes than necessary

Given n equals to the maximum number of bytes to copy from src in the API,
or the rough estimate strlen of src, strncpy_s_inline should not copy more
than the number of bytes, computed by strlen(src), to dst if n is greater than
strlen(src). The number of bytes to copy is computed by strnlen(src,n), not n.

Change-Id: I088b46125d9776962750e121f1fbf441952efc2b
Signed-off-by: Steven <sluong@cisco.com>
5 years agovpp_config: Rework for Python2/3 compatibility. 55/16555/7
Paul Vinciguerra [Wed, 19 Dec 2018 10:05:25 +0000 (02:05 -0800)]
vpp_config: Rework for Python2/3 compatibility.

On ubuntu:
   $cd <basedir>/extras/vpp_config
   $./scripts/clean.sh
   $./scripts/cp-data.sh
   $sudo apt-get install python3-pip python3-setuptools
   $python3 -m pip install .
   $vpp-config

Changes:
   * Convert to print() function.
   * raw_input changes.
   * floor division changes.
   * replace vpp-config.py with a setuptools 'vpp-config' entry_point.
   * replace netaddr with ipaddress from the standard library and backport.
   * .decode() subprocess.Popen's stdout because in python3 they are bytes.

Change-Id: Id98894ee54e0c31a0ba0304134b159caef415705
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoVOM: IP route ECMP support 53/16753/2
Neale Ranns [Thu, 10 Jan 2019 16:56:38 +0000 (08:56 -0800)]
VOM: IP route ECMP support

Change-Id: Iede0c30aacfe7289f428062bb9540410097c40e2
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agosession/vcl: improve fifo tx notifications 44/16744/4
Florin Coras [Thu, 10 Jan 2019 04:04:38 +0000 (20:04 -0800)]
session/vcl: improve fifo tx notifications

Change-Id: Ied476c417c8ba5b4d7c615125c36eecd9ca64fbc
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoARP/ND: copy opaque2 persistent fields to new packet 34/16734/2
Neale Ranns [Wed, 9 Jan 2019 08:04:04 +0000 (00:04 -0800)]
ARP/ND: copy opaque2 persistent fields to new packet

Change-Id: Ic65f686aaccaf8450732d88d7471b587faccaa9d
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoEnable random reassembly test for ARM 69/16569/5
juraj.linkes [Thu, 20 Dec 2018 13:53:27 +0000 (14:53 +0100)]
Enable random reassembly test for ARM

The underlying failure has been fixed and now the test can be
re-enabled.

Change-Id: I75251f6150ef1771dc23ea079799229690cf87d9
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
5 years agoEnable GBP tests for ARM 81/16581/3
juraj.linkes [Fri, 21 Dec 2018 09:17:03 +0000 (10:17 +0100)]
Enable GBP tests for ARM

The underlying failure has been fixed.

Change-Id: If2ca92a17cfed1c2d7253e46ab161f301f847f29
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
5 years agoUse the official libpcap file type 42/16742/1
Dave Barach [Wed, 9 Jan 2019 15:22:24 +0000 (10:22 -0500)]
Use the official libpcap file type

Change-Id: Ia34a4278eedc8cf450688b1fa0291e1f976868d3
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agotest/vpp_papi_provider.py: Fix simple copy/paste error. 31/16731/2
Paul Vinciguerra [Wed, 9 Jan 2019 04:57:30 +0000 (20:57 -0800)]
test/vpp_papi_provider.py: Fix simple copy/paste error.

Change-Id: I8993132bdd0931c96ba8bc879ec3b4ae938a46c5
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agotest framework. Remove unused code. 21/16721/3
Paul Vinciguerra [Tue, 8 Jan 2019 00:29:26 +0000 (16:29 -0800)]
test framework.  Remove unused code.

Change-Id: I1bd14d5aff4918b58aef18fa0a9264e033989f6e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agogbp: Fix coverity warnings 16/16716/3
Mohsin Kazmi [Mon, 7 Jan 2019 18:54:20 +0000 (19:54 +0100)]
gbp: Fix coverity warnings

Change-Id: Iea64d246008b298edeeae338d781b79362f42046
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agoVXLAN: Prevent duplicate bypass graph nodes. 82/16682/5
Jon Loeliger [Thu, 3 Jan 2019 18:56:02 +0000 (12:56 -0600)]
VXLAN: Prevent duplicate bypass graph nodes.

Change-Id: I68cc509b594b09751ff5e0e09bbca187a4a88edd
Signed-off-by: Jon Loeliger <jdl@netgate.com>
5 years agoFix name of ipv6-n-tuple 35/16635/3
Hongjun Ni [Fri, 28 Dec 2018 10:27:04 +0000 (18:27 +0800)]
Fix name of ipv6-n-tuple

Change-Id: Ia95a75295e4865b4720573f164ccba8bcc7679ae
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
5 years agovirtio: fix kick race issue 56/16556/4
Damjan Marion [Thu, 20 Dec 2018 09:44:47 +0000 (10:44 +0100)]
virtio: fix kick race issue

Change-Id: I25b2a28513821bc5eab9ac6890a3964d412b0399
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agovcl/ldp: select cleanup/improvements 22/16722/8
Florin Coras [Tue, 8 Jan 2019 01:49:17 +0000 (17:49 -0800)]
vcl/ldp: select cleanup/improvements

Change-Id: I640e69388f2ab0f66ad60c5165c749f5a5a9f525
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agostring_test: coverity woe 00/16700/2
Steven [Sun, 6 Jan 2019 19:23:24 +0000 (11:23 -0800)]
string_test: coverity woe

Remove the needless tests and checks which coverity complains about in
string_test.c

Change-Id: I971650cada77136f06528a65625ef99bd3d7e915
Signed-off-by: Steven <sluong@cisco.com>
5 years agotapv2: add "tap_flags" field to the TAPv2 interface API 19/16719/3
Andrew Yourtchenko [Mon, 7 Jan 2019 19:56:46 +0000 (20:56 +0100)]
tapv2: add "tap_flags" field to the TAPv2 interface API

Change-Id: I26f99d95f52c9fe107d17dcbbf5c6185523beade
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agoavf: allocate descriptor memory from local numa 17/16717/2
Damjan Marion [Mon, 7 Jan 2019 19:56:04 +0000 (20:56 +0100)]
avf: allocate descriptor memory from local numa

Change-Id: Ic56ee4ce83b282a5f0f5aed500721fe639b941b3
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoVOM: mroutes 13/16713/3
Neale Ranns [Thu, 27 Dec 2018 11:21:28 +0000 (03:21 -0800)]
VOM: mroutes

- fixes in ip.api for dumping mroute path flags

Change-Id: I13b0cfb15d374250ed71bd4e13dda9b798c18204
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoL2 BD API to flush all IP-MAC entries in the specified BD 18/16718/3
John Lo [Mon, 7 Jan 2019 20:16:33 +0000 (15:16 -0500)]
L2 BD API to flush all IP-MAC entries in the specified BD

Implement API/CLI to clear IP-MAC tables used for ARP-termination
in the specified bridge domain.
The CLI to flush MAC IP tables for a BD is:
 set bridge-domain arp entry <bd-id> del-all
The API added is bd_ip_mac_flush.

Change-Id: I34ceb87c0f480c7102f6559312c24081ed485af8
Signed-off-by: John Lo <loj@cisco.com>
5 years agoMAP: Prevent duplicate MAP-E/T graph nodes. 83/16683/5
Jon Loeliger [Thu, 3 Jan 2019 23:12:59 +0000 (17:12 -0600)]
MAP: Prevent duplicate MAP-E/T graph nodes.

Change-Id: I6031f3f9cfa048a901a8424d33d47679115c2eb3
Signed-off-by: Jon Loeliger <jdl@netgate.com>
5 years agoChange vpp code to align with openssl interface change 09/16709/3
Ping Yu [Mon, 7 Jan 2019 21:03:07 +0000 (16:03 -0500)]
Change vpp code to align with openssl interface change

PR in openssl community is almost done, and need to change some code in VPP
to align with the openssl interface.

Change-Id: Ic7da53e507b67b53958760d07738dd774b1c526d
Signed-off-by: Ping Yu <ping.yu@intel.com>
5 years agoHandle buffer alloc failure in vlib_buffer_add_data 10/16710/2
Dave Barach [Mon, 7 Jan 2019 14:15:47 +0000 (09:15 -0500)]
Handle buffer alloc failure in vlib_buffer_add_data

It's not OK to crash due to a transient buffer allocation failure.

Return 1 if the requested operation failed, otherwise 0.

Buffer index parameter change to a value-result, so the caller can
differentiate between partial and complete allocation failure: callers
which request an initial allocation (inbound bi = ~0) need to check
the (out) value to decide whether or not to call vlib_buffer_free(...).

Change-Id: I03029d7f2714c17dca4630dfd95a1eb578b68384
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoFix TCP checksum. 02/16702/4
Andrej Kozemcak [Mon, 7 Jan 2019 07:39:22 +0000 (08:39 +0100)]
Fix TCP checksum.

Set TCP checksum to zero, before calculate the TCP checksum.

Change-Id: Id96743334481804b8ebb74afef2f1dbfed29e0cb
Signed-off-by: Andrej Kozemcak <andrej.kozemcak@pantheon.tech>
5 years agovcl/ldp: add locked sessions shim layer 95/16695/29
Florin Coras [Sat, 5 Jan 2019 01:05:43 +0000 (17:05 -0800)]
vcl/ldp: add locked sessions shim layer

Moves LDP logic that allows sharing of sessions between multi-process
app workers into a separate VCL shim layer. Also refactors LDP to use
the new layer.

Change-Id: I8198b51eae7d099a8c486e36b29e3a0cb8cee8e9
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoUpdate tcpdump / wireshark packet format writeup 01/16701/2
Dave Barach [Sun, 6 Jan 2019 20:06:06 +0000 (15:06 -0500)]
Update tcpdump / wireshark packet format writeup

Change-Id: I8195bae1421f68a823b86e12373840f5292ac0df
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agogbp: Fix typo in condition 11/16711/1
Mohsin Kazmi [Mon, 7 Jan 2019 14:33:13 +0000 (15:33 +0100)]
gbp: Fix typo in condition

Change-Id: Ib474e2af98d98d54c9fc4070fab56799555c0f31
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agovpp-api: Add context to VPPStatsIOError. 99/16699/2
Paul Vinciguerra [Sun, 6 Jan 2019 03:37:27 +0000 (19:37 -0800)]
vpp-api: Add context to VPPStatsIOError.

* Provide context information and return meaningful information.
VPPStatsIOError: Stat segment client connection returned: -2 Stat client socket open but couldn't connect.

Change-Id: I14ea35c58452a2cb7598a7efd136f0c7e1f5743a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agopktgen: support mixed multi/single chunk pcap replay 98/16698/2
Dave Barach [Sat, 5 Jan 2019 21:51:41 +0000 (16:51 -0500)]
pktgen: support mixed multi/single chunk pcap replay

Change-Id: I3d387b5e2b17f89ed688ea6cfee3fb6d782fe326
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agovcl/session: add api for changing session app worker 76/16676/11
Florin Coras [Thu, 3 Jan 2019 03:31:22 +0000 (19:31 -0800)]
vcl/session: add api for changing session app worker

In case of multi process apps, after forking, the parent may decide to
close part or all of the sessions it shares with the child. Because the
sessions have fifos allocated in the parent's segment manager, they must
be moved to the child's segment manager.

Change-Id: I85b4c8c8545005724023ee14043647719cef61dd
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agosocket API: Use pool index instead of handle in sock_delete handler 97/16697/2
Ole Troan [Sat, 5 Jan 2019 10:27:54 +0000 (11:27 +0100)]
socket API: Use pool index instead of handle in sock_delete handler

The socket API used the socket index handle directly in the sock_delete handler,
resulting in "unknown client id" warnings, and a failure in return for socket clients.

Change-Id: Ia69f740ce0f834cd9b62b7157243a1f42bcad765
Signed-off-by: Ole Troan <ot@cisco.com>
5 years agoVPP-1508: Python3: Support simultaneous p2/p3 venvs. 63/16563/3
Paul Vinciguerra [Wed, 19 Dec 2018 22:34:45 +0000 (14:34 -0800)]
VPP-1508: Python3: Support simultaneous p2/p3 venvs.

Change-Id: I24cf3e390f6f0b98be939ef717048742d3f183d6
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agotcp: fix reset in syn-sent 94/16694/2
Florin Coras [Fri, 4 Jan 2019 16:45:22 +0000 (08:45 -0800)]
tcp: fix reset in syn-sent

Change-Id: I6732adc06fbb3d4b427e671ddcfe6eabc08d4a1b
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoAdd TLS support for VCL 06/16306/7
Ping Yu [Sat, 1 Dec 2018 00:16:17 +0000 (19:16 -0500)]
Add TLS support for VCL

Ater this patch, vcl_test_client and vcl_test_server can work happily with
TLS connection.
"-S" is to indicate TLS connection.

Change-Id: I761894b0b5929912691625f0fe63604725b55978
Signed-off-by: Ping Yu <ping.yu@intel.com>
5 years agolibmemif: fix incorrect write leading to memory corruption 65/16665/2
Koichiro Den [Wed, 2 Jan 2019 15:22:24 +0000 (00:22 +0900)]
libmemif: fix incorrect write leading to memory corruption

in the worst case scenario this leads to segfault in a hard-to-debug way.

Change-Id: I165adae0bd2dee26af777a2665c8c124d3a49808
Signed-off-by: Koichiro Den <den@klaipeden.com>
5 years agoVPP-1525: additional fixes for strings in Japi 77/16477/4
Michal Cmarada [Fri, 4 Jan 2019 12:29:25 +0000 (13:29 +0100)]
VPP-1525: additional fixes for strings in Japi

Change-Id: Ic5aa09fdc360cdded16d3c4693f0d4b2067f66d6
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
5 years agotcp: add more closing state arcs 74/16674/3
Florin Coras [Wed, 2 Jan 2019 18:10:08 +0000 (10:10 -0800)]
tcp: add more closing state arcs

Change-Id: If6f4d6404753b2d6b96e17f5414079bcdb9edde8
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agotcp: better randomize iss 75/16675/3
Florin Coras [Wed, 2 Jan 2019 20:22:02 +0000 (12:22 -0800)]
tcp: better randomize iss

Change-Id: I3638221e59024d6b7d82499d57e25b8e609f73cb
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoFix used-before-set in vl_api_bridge_flags_t_handler 80/16680/1
Dave Barach [Thu, 3 Jan 2019 14:30:00 +0000 (09:30 -0500)]
Fix used-before-set in vl_api_bridge_flags_t_handler

The aarch64 cross-compiler complains about this when building an
optimized image. So we fix it...

Change-Id: Ib2b2089c0534753d7d470311012fa0073ab27d1d
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoFix an issue in tls.c 21/16621/4
Ping Yu [Wed, 26 Dec 2018 10:42:38 +0000 (05:42 -0500)]
Fix an issue in tls.c

Curernt code will overwrite parent_app_api_context, and defer the
setting after this value is used in callback.

Change-Id: Ie16e432fd0f4214e6deff3aa3b58b3be824b0331
Signed-off-by: Ping Yu <ping.yu@intel.com>
5 years agoRevert "add ipsecmb plugin" 72/16672/2
Florin Coras [Wed, 2 Jan 2019 17:43:01 +0000 (17:43 +0000)]
Revert "add ipsecmb plugin"

This reverts commit be16020c5034bc69df25a8ecd7081aec9898d93c.

The arm verify job actually failed but the result was overwritten by an x86 ubuntu retry.

Change-Id: Idcae7691fc575053563b8ff8bcad661c15891668
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoFixes for buliding for 32bit targets: 97/16497/6
David Johnson [Fri, 14 Dec 2018 19:53:41 +0000 (14:53 -0500)]
Fixes for buliding for 32bit targets:
  * u32/u64/uword mismatches
  * pointer-to-int fixes
  * printf formatting issues
  * issues with incorrect "ULL" and related suffixes
  * structure alignment and padding issues

Change-Id: I70b989007758755fe8211c074f651150680f60b4
Signed-off-by: David Johnson <davijoh3@cisco.com>
5 years agoAdd microarch details to 'show cpu'. 47/16647/2
Paul Vinciguerra [Sun, 30 Dec 2018 19:07:36 +0000 (11:07 -0800)]
Add microarch details to 'show cpu'.

Change-Id: I31a3ff9e8f70468196c091027592a3aed2d09ac3
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoipsec: fix support check when using AES-GCM 89/16589/2
Matthew Smith [Fri, 21 Dec 2018 17:53:16 +0000 (11:53 -0600)]
ipsec: fix support check when using AES-GCM

When adding an IPsec SA, ipsec_check_support_cb() is called. This
invokes a callback for AH and a callback for ESP to check if the
algorithms are supported.

When using AES-GCM on an ESP SA with the DPDK IPsec backend selected,
the AH callback fails. The DPDK IPsec backend has no AH support,
so the callback for the default OpenSSL backend is invoked. This
checks whether the crypto algorithm is AES-GCM and returns failure.

Only invoke the callback to check support for the IPsec protocol
of the SA - either AH or ESP rather than doing both.

Change-Id: Ic10be6a17b580d06ffb7e82ef5866e53a4f8b525
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
5 years agoadd ipsecmb plugin 09/14909/33
Klement Sekera [Thu, 8 Nov 2018 12:25:49 +0000 (13:25 +0100)]
add ipsecmb plugin

Change-Id: I99c0737dfeeec2db267773625ddc9b55324fd237
Signed-off-by: Klement Sekera <ksekera@cisco.com>
5 years agoldp/vcl: epoll and shutdown cleanup 56/16656/7
Florin Coras [Mon, 31 Dec 2018 01:11:31 +0000 (17:11 -0800)]
ldp/vcl: epoll and shutdown cleanup

Change-Id: I882b4c495426551fad63372dc106496c5e8c141e
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoDefault huge page size to the regular page size 57/16657/2
Dave Barach [Tue, 1 Jan 2019 14:45:08 +0000 (09:45 -0500)]
Default huge page size to the regular page size

With this simple tweak, vpp is OK for "make test" or non-dpdk driver
operation over a kernel which doesn't support hugepages at all.

Tested on a Raspberry-pi 3B+ running the Ubuntu 18.04 64-bit server
beta image. It's amazing that such a minimal system will not only
self-compile vpp, but also run the unit tests. It's slow, but what do
you expect for that amount of money?

Change-Id: I7f080f871c828cc4b44be13809495278fadbd717
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agobuffers: remove unused code 46/16646/4
Damjan Marion [Sun, 30 Dec 2018 17:09:59 +0000 (18:09 +0100)]
buffers: remove unused code

Change-Id: If2bbfbc52994f5de0879763e0b7a7864498debb6
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agovcl/ldp: add write msg function and fine tuning 34/16634/11
Florin Coras [Thu, 27 Dec 2018 22:51:46 +0000 (14:51 -0800)]
vcl/ldp: add write msg function and fine tuning

Allows app to push data. Additionally, ensure reset/close replies are
not sent unless vcl closes the session.

Change-Id: Icbbf933cf57b55cfbcc7b802af0f83919a066f65
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agobinary api clients: wait for vpp to start 32/16632/3
Dave Barach [Thu, 27 Dec 2018 18:57:41 +0000 (13:57 -0500)]
binary api clients: wait for vpp to start

Change-Id: I740a7423327b724e88fdfa35d90cb1285e9f9746
Signed-off-by: Dave Barach <dbarach@cisco.com>
5 years agoavf: tx dequeue optimizations 37/16637/2
Damjan Marion [Fri, 28 Dec 2018 16:43:22 +0000 (17:43 +0100)]
avf: tx dequeue optimizations

Change-Id: I9d8fcf930132e832941e5678a9278a029e104dc3
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoavf: chained buffers rx support 22/16622/5
Damjan Marion [Thu, 27 Dec 2018 15:18:55 +0000 (16:18 +0100)]
avf: chained buffers rx support

Change-Id: I76ba11441f0ab3d150cdd080919cda91eac60b01
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoavf: chained buffers tx support 29/16629/4
Damjan Marion [Thu, 27 Dec 2018 10:35:40 +0000 (11:35 +0100)]
avf: chained buffers tx support

Change-Id: Ib573d45def80b4123d5623fda920e6cda1247638
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agovppinfra: add simple ring implementation 36/16636/2
Damjan Marion [Fri, 28 Dec 2018 14:46:10 +0000 (15:46 +0100)]
vppinfra: add simple ring implementation

Change-Id: I188e2dfd187d7b2ab7e0fbb11461f3db052f3224
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agosession: free session after transport and app confirm 33/16633/4
Florin Coras [Thu, 27 Dec 2018 19:53:11 +0000 (11:53 -0800)]
session: free session after transport and app confirm

In addition to that, a bit of refactoring.

Change-Id: Iea1eabc2167bcdef185ec53bc09bae087c5398e6
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agovcl: handle invalid sessions in epoll 27/16627/3
Florin Coras [Thu, 27 Dec 2018 00:29:06 +0000 (16:29 -0800)]
vcl: handle invalid sessions in epoll

Change-Id: I62d37f3c05451e5667863a2c6c551872d5dac1ea
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agovpp_papi: MACAddress equals fails in unittest. 26/16626/4
Paul Vinciguerra [Wed, 26 Dec 2018 23:27:10 +0000 (15:27 -0800)]
vpp_papi:  MACAddress equals fails in unittest.

Before:
    EqualsAssertionError:  :: MACAddress(11:22:33:44:55:66) != MACAddress(11:22:33:44:55:66)
    ----------------------------------------------------------------------
    Ran 1 test in 0.002s
    FAILED (failures=1)
    MACAddress(11:22:33:44:55:66) != MACAddress(11:22:33:44:55:66)

After:

    ----------------------------------------------------------------------
    Ran 1 test in 0.001s
    OK

Change-Id: I89896a823b8f8a861813dabf23e7c9207e4fabb6
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoMAP: Install lpm.h as map.h references it. 24/16624/2
Jon Loeliger [Wed, 26 Dec 2018 21:13:21 +0000 (15:13 -0600)]
MAP: Install lpm.h as map.h references it.

Change-Id: I97c6475920b7f7028c2bb1117ff9e5f629a54b44
Signed-off-by: Jon Loeliger <jdl@netgate.com>
5 years agoinstall-dep: force osleap boost dep install 31/16631/2
Florin Coras [Thu, 27 Dec 2018 17:07:32 +0000 (09:07 -0800)]
install-dep: force osleap boost dep install

Change-Id: I4a053f41eef138fc0e6db7e2650860c0ac999552
Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agotcp: add more last-ack arcs 18/16618/3
Florin Coras [Tue, 25 Dec 2018 18:55:01 +0000 (10:55 -0800)]
tcp: add more last-ack arcs

Change-Id: If538bb9d6fb489906099b727a7bfdb9d9af29402
Signed-off-by: Florin Coras <fcoras@cisco.com>