Ole Troan [Thu, 15 Apr 2021 14:53:39 +0000 (16:53 +0200)]
papi: change default to use socket transport instead of shared memory transport
In preparation for removing Python shared memory support, change the default to use sockets.
This may affect users of PAPI. E.g. if running against instances of VPP where
the API socket is in a different location or disabled.
Type: improvement
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I96308ed70b9ff314c9b487722174f5e4b14efdd2
Signed-off-by: Ole Troan <ot@cisco.com>
mdr78 [Tue, 23 Mar 2021 12:40:21 +0000 (12:40 +0000)]
pg: exec file fixes
A number of the pg commands were being passed the whole exec file,
instead of just a line from the file.
Type: fix
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Change-Id: I2f96e7648b9b7d501088eddff7e4a761973e71f4
Florin Coras [Wed, 28 Apr 2021 00:03:24 +0000 (17:03 -0700)]
hsa: fix quic vcl test
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I9a4bf384be65ba8b868d1172c7b6e00ae959601e
Florin Coras [Wed, 28 Apr 2021 07:04:33 +0000 (00:04 -0700)]
hsa: support sigint in vcl test client
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ie0d5fe97a727465f8851fc2110219483a5bf3f27
Arthur de Kerhor [Mon, 12 Apr 2021 15:16:56 +0000 (08:16 -0700)]
ip: extend the punt cli to accept reason filter for sockets registration
Type: improvement
Signed-off-by: Arthur de Kerhor <arthurdekerhor@gmail.com>
Change-Id: I769db1213b0936abbf304bc6cf9dbcfbbebf06aa
Matthew Smith [Wed, 4 Nov 2020 17:18:10 +0000 (11:18 -0600)]
nat: fix byte order on ipfix message fields
Type: fix
The code for quota exceeded events is a u32 and was being copied
into ipfix packets in host byte order. Same for the limit field.
Swap the order before copying into packet buffer.
This change was applied once before but had to be reverted. This was
because between the time the change was uploaded/reviewed and the
time it was merged, a different patch was merged which activated a
NAT ipfix unit test that had formerly only been run as part of the
extended tests. The test was expecting the values to be in host byte
order so it failed with this patch applied. This time around, that
test has also been updated to expect network byte order.
Change-Id: If5413b1f806d664f6786e56ba13c3eee573c26d2
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Neale Ranns [Tue, 27 Apr 2021 13:54:46 +0000 (13:54 +0000)]
gre: Remove the debugging logging from the mGRE tests
Type: test
Signed-off-by: Neale Ranns <neale@graphiant.com>
Change-Id: I5c540b3a2f26689973daec80372c5a935a455a12
Damjan Marion [Tue, 27 Apr 2021 22:11:33 +0000 (00:11 +0200)]
build: Makefile cleanup
Type: make
Change-Id: I751b0a25161c6eb8614ca19f7c77a4de82401f3d
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Tue, 27 Apr 2021 17:41:45 +0000 (19:41 +0200)]
misc: fix dead stores
Type: fix
Change-Id: I08969e1c4a78f8ac92ec066a3b67e64dc931bc16
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 22 Apr 2021 16:08:28 +0000 (18:08 +0200)]
vlib: improve enqueue_to_next buffer indices extraction
Type: improvement
Change-Id: Ib7b2fa7d821f6d2708f6dc378a0f36f68c843f57
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Tue, 27 Apr 2021 01:43:20 +0000 (18:43 -0700)]
hsa: custom proto vfts for vcl tests
Define custom connect, listen, accept, close handlers for transport
protos under test.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ifa260d05917256c590f29078f465ce47c576cbc3
Florin Coras [Tue, 27 Apr 2021 20:30:37 +0000 (13:30 -0700)]
session: fix mq ext config cleanup
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I18eb1a71ac22017f75f835a23a57b023b46524ce
Damjan Marion [Sun, 25 Apr 2021 08:46:26 +0000 (10:46 +0200)]
misc: add StatementMacros to .clang-format
Type: make
Change-Id: I79d8d0aa8b8349df0b3c1f338861350e8df31ca6
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Tue, 27 Apr 2021 09:00:54 +0000 (11:00 +0200)]
vppinfra: silence coverity warnings related to clib_memcpy_u32()
Type: fix
Change-Id: I17e7b3fca390c0b0150c4606f7c93771ee9bdbdc
Signed-off-by: Damjan Marion <damarion@cisco.com>
Steven Luong [Wed, 21 Apr 2021 18:11:41 +0000 (11:11 -0700)]
misc: update arp and ip6-nd files location
arp and ip6-nd are not plugins [yet]. Change the files location to
reflect its current correct locations.
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ibcde8867cc50abbf2061d1e80390c528393ec4df
Ryo Nishikawa [Thu, 22 Apr 2021 14:31:09 +0000 (23:31 +0900)]
vppinfra: Fix a bug related to path_search
Type: fix
Signed-off-by: Ryo Nishikawa <nishikawa0320@gmail.com>
Change-Id: Iabf7e088245395ea3fff62a22266a31de3fc305e
Matthew Smith [Fri, 16 Apr 2021 19:13:58 +0000 (14:13 -0500)]
vrrp: increase stack size of process node
Type: fix
The process node which wakes up when a timer expires and transitions
a backup node to master state may call a function to add a MAC address
to an interface. This works fine for some devices, but with DPDK 20.11
on i40e interfaces, the i40e PMD functions which enact the change cause
the stack to be exhausted. Increase the stack size for the node.
Change-Id: I824603e162f4f6d680486706210986572f0d9845
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Vladimir Lavor [Thu, 8 Apr 2021 11:08:04 +0000 (13:08 +0200)]
misc: auto-generate go bindings
Type: feature
Added target 'make go-api-files' creating compatible go bindings
using JSON API definition and GoVPP binary API generator.
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Change-Id: I5bae113b85eaf5ebda8e292d34c9826075ef19b5
mdr78 [Fri, 19 Mar 2021 19:03:54 +0000 (19:03 +0000)]
perfmon: top down level 1 support
Adding perfmon node TMAM support on ICX.
Type: improvement
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Change-Id: I48a9a9ff6a72efc28eaf0cb11ef39fb62cebb126
Florin Coras [Mon, 26 Apr 2021 19:10:21 +0000 (12:10 -0700)]
hsa: use only one conn type for vcl tests
Type: refactor
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I31d0f8e32f7bb508c6f57913d5a829ceaad91f7d
Damjan Marion [Mon, 26 Apr 2021 21:25:08 +0000 (23:25 +0200)]
vapi: silence warnings
Type: fix
Change-Id: I91d7bfbfaafc7b780f91dec7c9e5ce07241e6394
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Fri, 23 Apr 2021 21:01:01 +0000 (14:01 -0700)]
hsa: use tcp for vcl test control channel
Also, only exchange config over control session.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I001df635896762bc5330cebb7d5744e3e754482d
Damjan Marion [Wed, 21 Apr 2021 19:11:35 +0000 (21:11 +0200)]
vppinfra: clib_memcpy_u32() utilizing SIMD mask loads/stores
Type: improvement
Change-Id: I55c4688bd1feffae139ce12a66d15885373e5cd7
Signed-off-by: Damjan Marion <damarion@cisco.com>
Ray Kinsella [Fri, 12 Mar 2021 14:29:48 +0000 (14:29 +0000)]
pg: fix packet coalescing cli
Small fix to the packet coalescing cli.
Type: fix
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Change-Id: I1edbf6e43937aa0345185f06437095e0558dba31
Paul Vinciguerra [Tue, 8 Dec 2020 15:56:15 +0000 (15:56 +0000)]
vppapigen: remove flag day code
The flag day for the crc algorithm change has long passed and
should not be carried into the next release.
Type: refactor
Change-Id: I1b1027139a778907926e48a8a553b908a79db08f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Paul Vinciguerra [Mon, 26 Apr 2021 01:50:38 +0000 (21:50 -0400)]
tests: clean up gbp calls from vpp_papi_provider
Move info from vpp_papi_provider to .api/vpp_objects
Change-Id: Iaf46483fda2840dfec8d37e0b9262e1c9912be59
Type: test
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
liuyacan [Sun, 25 Apr 2021 12:11:30 +0000 (20:11 +0800)]
session: fix race condition in fifo allocation
Under some timing conditions,VCL may receive CONNECTED/ACCEPTED
event before ADD_SEGMENT event.
Timing example:
2 threads call segment_manager_alloc_session_fifos() parallelly
Thread 1 Thread 2
sm read lock |
| |
try to alloc fifo =>failed |
| |
sm read unlock |
| |
sm write lock |
| |
add segment |
| |
sm write unlock |
| sm read lock
| |
| try to alloc fifo=>successful
sm read lock |
| sm read unlock
| |
| emit CONNECTED/ACCEPTED
emit ADD_SEGMENT event
|
sm read unlock
This commit move ADD_SEGMENT notification under the protection
of the write lock in some scenarios.
Type: fix
Signed-off-by: liuyacan <liuyacan@corp.netease.com>
Change-Id: I25d5475c5e6d37cfccefa9506f6030c26ce8ee9b
Damjan Marion [Sun, 25 Apr 2021 08:55:53 +0000 (10:55 +0200)]
vppinfra: add COMPILE_TIME_CONST() macro
Type: improvement
Change-Id: I10d7489f57bc60eb92049962b4e6ea84974f17b8
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Sun, 25 Apr 2021 08:51:51 +0000 (10:51 +0200)]
vppinfra: AVX512 mask load/stores and compress store
Type: improvement
Change-Id: Id6be598aade072653e408cca465e62931d060233
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Sun, 25 Apr 2021 08:58:07 +0000 (10:58 +0200)]
vppinfra: add clear_lowest_set_bit() function, use BMI2 if available
Type: improvement
Change-Id: I973cacd0cade0ca98e6261c1fb026a5eb38b44d3
Signed-off-by: Damjan Marion <damarion@cisco.com>
Klement Sekera [Thu, 22 Apr 2021 11:38:58 +0000 (13:38 +0200)]
nat: correct detection of icmp bypass presence
Type: fix
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: Iead167e7497e0779c440f7fb243014a06ae2b452
Nathan Skrzypczak [Wed, 21 Apr 2021 17:56:34 +0000 (19:56 +0200)]
vxlan: Fix L3 mode
Type: fix
Partially revert fix SEGV reported in VPP-1962
[commit
a4b0541f64eef02fa0d003d8f831cfdeb45d3668]
This adds an is_l3 option to choose between L2 & L3
mode add tunnel creation time
Change-Id: Ia2c91a1099074b7d23fc031b78ed0f68628eeabe
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Florin Coras [Fri, 23 Apr 2021 15:58:57 +0000 (08:58 -0700)]
session: set connected session index for ct
Set connected session index for ct as well.
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id82ffcf5572b6a9d2769c0e685c7a0b4d1ea9e9f
Alexander Chernavin [Thu, 22 Apr 2021 08:48:34 +0000 (04:48 -0400)]
dpdk: support md5 async handler in dpdk cryptodev
With this change, enable MD5 with AES-CBC support in dpdk cryptodev.
Type: improvement
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Change-Id: Ic587aaa1fa0dc102e36eb34f329ef21a16156f26
Florin Coras [Fri, 23 Apr 2021 04:10:02 +0000 (21:10 -0700)]
tcp: try to update sack list only if not empty
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ieb5af96de5be33356dbab7bc4ab4696731fa8866
Florin Coras [Thu, 22 Apr 2021 23:58:23 +0000 (16:58 -0700)]
tcp: reorganize connection members
Optimize connection size and move timestamp_delta closer to other
timestamp related members.
Type: refactor
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iec42efb46482ebfdf234518a4e91af836e4f4c07
Florin Coras [Thu, 22 Apr 2021 18:48:35 +0000 (11:48 -0700)]
tls quic: improve error reporting
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I92f0c1f7c0f4696fa12071440a643aa703d6306f
liuyacan [Fri, 23 Apr 2021 01:38:38 +0000 (09:38 +0800)]
session: set fifo's session index before vcl attach
Current implementation may have timing issue:
1. The TCP 3-way-handshake is completed but the app is busy and
does not process the CONNECTED event.
2. VPP receive some data from peer and try to send a RX event to
VCL, but the fifo's client session index is not initialized yet.
So this event will be sent to incorrect session 0.
Type: fix
Change-Id: I54f222232968bfaea5f4745284a1cfacc89482a9
Signed-off-by: liuyacan <liuyacan@corp.netease.com>
Florin Coras [Thu, 22 Apr 2021 17:58:17 +0000 (10:58 -0700)]
session: remove unused connect/listen msg members
Type: refactor
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ie46824f95f9488b04fa1f701ff94345e2dc83de2
Florin Coras [Wed, 21 Apr 2021 16:05:56 +0000 (09:05 -0700)]
vcl session: refactor passing of crypto context
Pass tls/quic crypto context using extended config instead of bloating
conect/listen messages.
Type: refactor
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I0bc637ae310e6c31ef1e16847501dcb81453ee94
Chenmin Sun [Thu, 3 Sep 2020 22:50:22 +0000 (06:50 +0800)]
flow: Add API implementation of IP4/IP6, IP4_VXLAN/IP6_VXLAN
This patch adds the API handler implementation of the below flows:
FLOW_TYPE_IP4,
FLOW_TYPE_IP6,
FLOW_TYPE_IP4_VXLAN,
FLOW_TYPE_IP6_VXLAN
Type: feature
Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I62e1c466b46f940180e957c859d122086aa22f1c
Nathan Skrzypczak [Thu, 22 Apr 2021 11:23:13 +0000 (13:23 +0200)]
tls: tlspicotls require version when building
Type: fix
When building the tlspicotls plugin, we rely
on vpp-ext-deps having installed quicly & picotls.
We add a dependancy on the version installed thus
ensuring that people with older vpp-ext-deps version
installed don't have their build fail.
This has the drawback that picotls doesn't have its
own versionning scheme
Change-Id: I9e2ccfc00b3c37af2bc2483a791eb05f994dd4a4
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Florin Coras [Tue, 20 Apr 2021 00:34:54 +0000 (17:34 -0700)]
vcl session: extended connect/listen configuration
Type: feature
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ic8d9386fef37ffd3446aaeb93a96ee6d60633831
Benoît Ganne [Wed, 3 Mar 2021 16:37:25 +0000 (17:37 +0100)]
misc: add filter for specific error for pcap trace
Type: feature
Change-Id: I325257454df1cc22833fa6a1dedd4739d4d5a558
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Damjan Marion [Wed, 21 Apr 2021 21:44:40 +0000 (23:44 +0200)]
ip: remove unnecesary inlining in ip4-rewrite node
Type: refactor
Change-Id: Ifbaf42ef88a7e0f1715b7b5e342af790e3b6acd9
Signed-off-by: Damjan Marion <damarion@cisco.com>
Mathias Raoul [Fri, 2 Apr 2021 18:02:24 +0000 (18:02 +0000)]
quic: update quicly to v0.1.3
This bumps quicly version to v0.1.3 ( sha
d44c089364067dbcdfbad7fb2c821900fb4aef5e in
https://github.com/h2o/quicly )
Also simplifies the build to only make needed
dependancies, and silence compiletime warnings
Type: feature
Change-Id: Ie00ec7e408d234464871b68ddc79bb33dc4179ed
Signed-off-by: Mathias Raoul <mathias.raoul@gmail.com>
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Dave Barach [Tue, 20 Apr 2021 11:52:38 +0000 (07:52 -0400)]
docs: document "make test-help"
Type: docs
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I67a582b7bf16c3fe307941973e983a0fe28cb221
Damjan Marion [Wed, 21 Apr 2021 13:25:47 +0000 (15:25 +0200)]
buffers: vlib_get_buffers() with 512-bit SIMD
Type: improvement
Change-Id: Id8ce3ffc1299a38171b82a7082454412c840a40c
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Wed, 21 Apr 2021 10:55:15 +0000 (12:55 +0200)]
vlib: don't inline vlib_buffer_enqueue_to_*
Function call in this case is not bad thing, as those functions
are called once per frame.
Type: improvement
Change-Id: I7bd61cf746b905e2c8e3085ebb2ff001c0a52da8
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Tue, 20 Apr 2021 19:28:45 +0000 (21:28 +0200)]
vppinfra: more avx512 inlines (compress, expand, from, is_equal_mask)
Type: improvement
Change-Id: I4cb86cafba92ae70cea160b9bf45f28a916ab6db
Signed-off-by: Damjan Marion <damarion@cisco.com>
Nathan Skrzypczak [Tue, 6 Apr 2021 15:58:18 +0000 (17:58 +0200)]
cnat: Fix session flag initialization
Type: fix
Sometimes session->value.flags wasn't initialized
leading to next_node index corruption.
Also added a debug flag to tell session/rsessions appart
Change-Id: I80da50f2267e03a4552e8c9efc8e3aa08bc5569d
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Klement Sekera [Wed, 31 Mar 2021 11:38:09 +0000 (13:38 +0200)]
nat: fix multi worker scenarios
Properly select worker from hash table in out2in direction, increase
number of worker threads in MW test to 4 to test these cases.
Type: fix
Change-Id: I76eda5761ff497b85b031dd913a64b7fcb53b33a
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Florin Coras [Tue, 20 Apr 2021 21:26:46 +0000 (14:26 -0700)]
svm: allow external chunk alloc on segment
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I89f9caa8dd44dc640615a58fe7708f388fdd84e9
Klement Sekera [Tue, 20 Apr 2021 16:08:45 +0000 (18:08 +0200)]
pmalloc: tolerate move_pages failure on numa node #0
Type: fix
Change-Id: I65dbc4f3db47c745a0187e015845e07b3b0568e5
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Filip Varga [Tue, 20 Apr 2021 14:25:16 +0000 (16:25 +0200)]
nat: fixing cli bug for nat44-ei and nat44-ed
Removing obsolete optional parameters.
Type: fix
Change-Id: I135eb4767979ab81636da16e91752a2ad80e0a45
Signed-off-by: Filip Varga <fivarga@cisco.com>
Florin Coras [Mon, 19 Apr 2021 17:58:00 +0000 (10:58 -0700)]
tls: honor tcp deq notification request
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ic24516a7242ef4193c5d751a2d5424918c390759
Florin Coras [Mon, 19 Apr 2021 17:17:26 +0000 (10:17 -0700)]
tcp: req app deq notification on fifo full
If fifo full, default to requesting an app deq notification and forcing
an ack (window update) if zero rcv window sent is still active.
Type: improvement
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iade7e1722503da149c62c465c472edbb0a5599f7
Alexander Chernavin [Mon, 1 Feb 2021 10:17:24 +0000 (05:17 -0500)]
crypto: support async handlers for 3des and md5
With this change, add support for 3DES and MD5 in IPsec async mode.
After changes in foreach_crypto_link_async_alg, the last combination in
the list (aes-256-cbc-hmac-sha-512) started to fail during decription.
That was also fixed by proper vector size validation.
Type: improvement
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Change-Id: I660657bdab62ea9cf031c3e43d99f2317e5f74d7
Filip Varga [Tue, 20 Apr 2021 14:39:07 +0000 (16:39 +0200)]
nat: nat44-ed i2o & o2i trace fix
If cache used than we don't print in trace session index.
Type: fix
Change-Id: Ib965cd8632b5217f8b2dd8b6cc6af3286c747582
Signed-off-by: Filip Varga <fivarga@cisco.com>
Damjan Marion [Mon, 19 Apr 2021 16:15:31 +0000 (18:15 +0200)]
ipsec: remove WITH_LIBSSL macros
We don't use libssl anymore... At least not directly.
Type: improvement
Change-Id: I9a0fab6e3c576d945498ce46f030bd26c1a14d15
Signed-off-by: Damjan Marion <damarion@cisco.com>
Mohammed Hawari [Tue, 20 Apr 2021 08:05:52 +0000 (10:05 +0200)]
dpdk: fix mlx4 mlx5 detection in plugin build
Since the move to DPDK 21.02, compatibility build symbols were depreca-
ted, breaking the static linkage of the DPDK plugin to libibverbs.
Change-Id: I2fec0807e4c0eb00268618f1495af862eede9081
Type: fix
Fixes:
5f35a185d5afee2c364fe84f33922bac1a808113
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Damjan Marion [Mon, 19 Apr 2021 19:47:24 +0000 (21:47 +0200)]
vlib: remove unused code
Type: refactor
Change-Id: I01dba12a7f8aa2fa6d2e4113c91dc97e638aca77
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Mon, 19 Apr 2021 19:44:21 +0000 (21:44 +0200)]
vppinfra: momve clib_sysfs_list_to_bitmap to sysfs.c
Type: refactor
Change-Id: Ia5a7ebd5c8492326f5bf2f1264f1c5ef38ccb4dc
Signed-off-by: Damjan Marion <damarion@cisco.com>
Aloys Augustin [Thu, 15 Apr 2021 16:12:51 +0000 (18:12 +0200)]
ip: fix offload flags handling
The per-protocol offload flags only make sense if F_OFFLOAD is set on
the vlib buffer main flags.
vnet_calc_checksums_inline is called from many places which should do
this check and don't, moving the check to this function is less error
prone and shouldn't have an impact on performance since the function
is always_inline.
Type: fix
Change-Id: I0297f109f31e409f07bfbaea3cd8b90c659658c4
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
Damjan Marion [Fri, 16 Apr 2021 09:49:26 +0000 (11:49 +0200)]
interface: interface-output end node rework
- rename node to more meaningful name
- introduce lookup tables
- enable multiarch
- quad-loop node
- enqqueue to next instead of enqueueing to node
Type: improvement
Change-Id: Ibb208047ae04bb6cfe56db558d3b8938bc14b4fe
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Sun, 18 Apr 2021 19:03:24 +0000 (21:03 +0200)]
ip: remove dead code from ip_csum
Type: fix
Change-Id: I3b37257e86175743a7bac80c531491565f0a8dcd
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Sun, 18 Apr 2021 13:33:39 +0000 (15:33 +0200)]
vppinfra: remove outdated and unused unix format functions
Type: refactor
Change-Id: If1772980dbdbde1fbf3d1989daa40599e9f23e8c
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 9 Oct 2020 15:16:55 +0000 (17:16 +0200)]
vppinfra: remove linux/syscall.h
For portabiliy reasons it is better to have all wrapped in clib code.
I.e. instead of using getcpu() we have clib_get_current_numa_node () and
clib_get_current_cpu_id().
Type: refactor
Change-Id: I29b52d7f29bc7f93873402c4070561f564b71c63
Signed-off-by: Damjan Marion <damarion@cisco.com>
Benoît Ganne [Fri, 26 Feb 2021 12:47:41 +0000 (13:47 +0100)]
classify: honor pcap interface filter also when classify filter is used
Type: fix
Change-Id: Ic32550ee9c5d76d232d8b67a7810611f6c8b9177
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Klement Sekera [Thu, 8 Apr 2021 17:37:41 +0000 (19:37 +0200)]
tests: cpus awareness
Introduce MAX_CPUS parameters to control maximum number of CPUs used by
VPP(s) during testing, with default value 'auto' corresponding to all
CPUs available.
Calculate test CPU requirements by taking into account the number of
workers, so a test requires 1 (main thread) + # of worker CPUs.
When running tests, keep track of both running test jobs (controlled by
TEST_JOBS parameter) and free CPUs. This then causes two limits in the
system - to not exceed number of jobs in parallel but also to not exceed
number of CPUs available.
Skip tests which require more CPUs than are available in system (or more
than MAX_CPUS) and print a warning message.
Type: improvement
Change-Id: Ib8fda54e4c6a36179d64160bb87fbd3a0011762d
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Damjan Marion [Thu, 15 Apr 2021 17:54:44 +0000 (19:54 +0200)]
vlib: make vlib_pending_frame_t smaller
Type: improvement
Change-Id: I8715631718dca9bc7d7b364451b137484aadd58e
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Thu, 15 Apr 2021 15:50:00 +0000 (08:50 -0700)]
tcp: support for rate sample attr flag
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I94b8063c9d8f9b811589c6815cb5c8ca6220f2b5
Paul Vinciguerra [Thu, 15 Apr 2021 15:37:44 +0000 (11:37 -0400)]
vrrp: refactor test
Move scapy packet generation code out of vpp object and into the test
case.
Type: test
Change-Id: Ib4de7409eefb79fc59f9815bed3befe5ecde483c
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Florin Coras [Thu, 15 Apr 2021 00:55:02 +0000 (17:55 -0700)]
vcl: validate fs before cleanup
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I1d3677923ab28325380c4a9e8469da83077262a9
Tianyu Li [Wed, 14 Apr 2021 04:36:20 +0000 (12:36 +0800)]
papi: fix ubuntu 1804 make test socket.close error
make test failed on ubuntu 18.04
File "/vpp/src/vpp-api/python/vpp_papi/vpp_stats.py", line 135, in connect
socket.close(mfd)
AttributeError: module 'socket' has no attribute 'close'
Due to ubuntu 18.04 using python3.6 and
socket.close() is introduced since python3.7
Using os.close to replace socket.close as mfd is a memory fd
Type: fix
Signed-off-by: Tianyu Li <tianyu.li@arm.com>
Change-Id: I6d980fc87ae6c77bbed416879f9b2fcd0a0abe6a
Damjan Marion [Thu, 15 Apr 2021 14:13:20 +0000 (16:13 +0200)]
vppinfra: move bitmap format functions to .c file, add format_bitmap_list
Type: improvement
Change-Id: I9baa845ecab8655e0623453666092d2dbc674b0f
Signed-off-by: Damjan Marion <damarion@cisco.com>
Radu Nicolau [Thu, 15 Apr 2021 14:11:49 +0000 (14:11 +0000)]
avf: fix tx path segfault
Type: fix
Fixes:
ca1812dbe714fc8e4de13f88df2d3b830d95a2c9
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Change-Id: I657be40689caa0c9e202fb411da6323aafeab57e
Lijian.Zhang [Wed, 14 Apr 2021 08:12:28 +0000 (16:12 +0800)]
vppinfra: correct intrinsic called by u16x16_from_u8x16
u16x16_from_u8x16() and i16x16_from_i8x16() call intrisics
_mm256_cvtepu8_epi64 and _mm256_cvtepi8_epi64. But they are not seems
doing the right data conversion from the name of the wrappers.
The correct intrinsics been called should be _mm256_cvtepu8_epi16
and _mm256_cvtepi8_epi16.
Type: fix
Change-Id: Id71de6ae1a266a370f11c33a46684202be766c43
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>
Chenmin Sun [Thu, 15 Apr 2021 10:51:24 +0000 (18:51 +0800)]
avf: remove the vxlan flow support
This patch fixes a vxlan flow type checking bug which is introduced in
commit
7a016e87e473.
It is the native avf instead of dpdk that doesn't support vxlan flow offloading.
So this patch removes Vxlan flow supporting in native avf_plugin and adds
the vxlan flow back to dpdk_plugin.
Type: fix
Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I1a72629cee462b890327c589c846f6d532b2d61d
Florin Coras [Wed, 14 Apr 2021 18:23:55 +0000 (11:23 -0700)]
session: fix next node add on transport registration
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I11eac12d2ae68a713e78ef68d09b692fce48c18e
Damjan Marion [Wed, 14 Apr 2021 17:07:13 +0000 (19:07 +0200)]
vlib: fix access before check issue in foreach_vlib_main macro
Type: fix
Change-Id: Iefb150a60b39d419d7dde35c80fbcba3a3a0d1e1
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Wed, 14 Apr 2021 16:48:22 +0000 (18:48 +0200)]
misc: clang-12 support
Type: improvement
Change-Id: Ie8ebbbcf5e93337036998d6ba8dac393b20ebc72
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Tue, 13 Apr 2021 02:55:37 +0000 (19:55 -0700)]
session tcp vcl: api to update connection attributes
Type: feature
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ifdd6024daf044751895bb8d2deabad41d3a80c92
Chenmin Sun [Mon, 12 Apr 2021 16:54:45 +0000 (00:54 +0800)]
dpdk: add RSS capability flag to iavf PMD in dpdk_plugin
Type: fix
Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I215b660a466e0579918e49de543163fd28f95c22
Benoît Ganne [Wed, 17 Mar 2021 15:16:16 +0000 (16:16 +0100)]
rdma: remove redundant memory registration
The memory region is already registered right above, looks like a
copy/paste error.
Type: fix
Change-Id: I97aed821e719e1a34ac38c86d0473a8fdd671d4e
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Filip Varga [Tue, 13 Apr 2021 15:47:13 +0000 (17:47 +0200)]
nat: test dynamic translation between two vrfs
Adding test for NAT44-ED subplugin.
Type: test
Change-Id: I10ce3d3ca8cb976ee9879efe77cb600df0102147
Signed-off-by: Filip Varga <fivarga@cisco.com>
Tianyu Li [Fri, 9 Apr 2021 07:51:46 +0000 (15:51 +0800)]
rdma: fix skip_ipv4_cksum behavior in scalar path
Current rdma input L3 validating behavior for scalar path is:
if any packet L3_OK flag matches, then unset skip_ip4_cksum.
The correct behavior should be if any packet L3_OK NOT match,
then unset skip_ip4_cksum. The logic is also different from
the vector path. This patch fixes the wrong behavior for scalar path.
Type: fix
Signed-off-by: Tianyu Li <tianyu.li@arm.com>
Change-Id: I5ca5ed3aa0c07d441f3c87b33f03ea8f7a3c9826
Florin Coras [Tue, 13 Apr 2021 22:45:54 +0000 (15:45 -0700)]
hsa: fix coverity warnings
Type: fix
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I1c38abde67c2f9be22186359a39ebc3a769b4a7f
Florin Coras [Tue, 13 Apr 2021 22:56:41 +0000 (15:56 -0700)]
tls: fix coverity warning
Type: fix
Avoid complaint that we're potentially incrementing ii which could be
null.
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I8511c07b1c2f260cc0e526d9aefeb4a051d98edf
Chenmin Sun [Mon, 7 Dec 2020 16:42:43 +0000 (00:42 +0800)]
flow: The type of vni in VxLAN flow should be u32
Type: fix
Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I40732dfb4fee4a5cfd699a8badea13d070f6b367
Damjan Marion [Tue, 13 Apr 2021 18:13:07 +0000 (18:13 +0000)]
avf: rework TX one-by-one loop
Type: improvement
Change-Id: I466fd0324d53e8d68b53a2c84d97a722be90f4a0
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Fri, 9 Apr 2021 15:38:31 +0000 (17:38 +0200)]
avf: avoid placeholder buffer alloc in datapath
Type: improvement
Change-Id: I0ad0fa42f056b5797ba71d6972a44273c13bb97e
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Thu, 8 Apr 2021 14:34:28 +0000 (16:34 +0200)]
avf: avoid ring wrap in the tx path
Type: improvement
Change-Id: I91ecf0bff2ddd43ab5cf0f03ed2882882154557b
Signed-off-by: Damjan Marion <damarion@cisco.com>
Chenmin Sun [Mon, 12 Apr 2021 12:42:42 +0000 (20:42 +0800)]
avf: avf flow bug fix
This patch fixes the below bugs in avf flow:
1. remove the VXLAN flow as it is not yet supported
2. fix a typo in IPv6 flow
3. fix the wrong type of the AH flows
Also did some cleanup in this patch
Type: fix
Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I5eae131f1e89071364a41b7006a00e8425089a4f
Mohammed Hawari [Wed, 31 Mar 2021 15:26:19 +0000 (17:26 +0200)]
geneve: fix options len parsing as 32-bits words
See https://tools.ietf.org/html/rfc8926 3.4. second paragraph Opt Len
Change-Id: I191d835651b2fa64eeb4ec4271497cf3342554be
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: fix
Klement Sekera [Tue, 16 Mar 2021 11:52:12 +0000 (12:52 +0100)]
tests: support attaching to existing vpp
Introduce a new option DEBUG=attach to run a test against existing
already running vpp. A new target 'make test-start-gdb' will spawn VPP
in gdb for this purpose. Customization options explained in test-help.
Type: improvement
Change-Id: Ia160a85b33da3b2df292d44bb95729af9dd9da96
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Klement Sekera [Thu, 1 Apr 2021 16:19:29 +0000 (18:19 +0200)]
tests: improve naming
Change capture to pcap to remove confusion in framework.py
Type: improvement
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: Idf8bd61f174b8b2df3bbd13908e54d597da4a83b
Fan Zhang [Tue, 30 Mar 2021 16:31:38 +0000 (17:31 +0100)]
dpdk: selection of cryptodev engine data-path
Type: improvement
This patch combined cryptodev op and cryptodev raw API data
paths into one and makes the engine run-timely select which
data path is used: if all cryptodev devices support
RTE_CRYPTODEV_FF_SYM_RAW_DP feature flag, the raw data path
API is used, otherwise the traditional data path is used.
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: Ibbd7c4405288bd9a48a34878954fd3040df7b4ad
Aloys Augustin [Mon, 29 Mar 2021 20:08:09 +0000 (22:08 +0200)]
devices: af_packet - use netlink to get/set mtu
The /sys filesystem is not always accurate when switching network
namespaces. Using netlink should work in more situations.
Type: improvement
Change-Id: I71611f14319820469ea7794eec5b7c6c70e2be6d
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
Steven Luong [Fri, 2 Apr 2021 19:23:05 +0000 (12:23 -0700)]
memif: Use log_debug for clib_file_add and clib_file_del
It is more appropriate to use log_debug instead of log_warn when inoking
clib_file_add and clib_file_del.
Type: fix
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I544d97037cfca3f22ce94242aef0c7b0fea2fa9b