Dave Barach [Tue, 7 Jun 2016 21:35:38 +0000 (17:35 -0400)]
VPP-83: fix collateral damage
Accidentally removed pthread_mutex_unlock (&root_rp->mutex) in the
dead client scan case. Oops. Bad idea.
Change-Id: I488b7e39d01c267052785bd346e8846351db90a9
Signed-off-by: Dave Barach <dave@barachs.net>
Filip Tehlar [Mon, 6 Jun 2016 11:13:16 +0000 (13:13 +0200)]
ONE-18: Fix trailing garbage string in LISP status dump API
Change-Id: I5cba5eae5a981e41df3f227834a079e10982537f
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Dave Wallace [Fri, 3 Jun 2016 21:09:11 +0000 (17:09 -0400)]
VPP-112: linux kernel info missing from build log
Change-Id: I343418d409d682b00e74e41236382fdc6b3c780c
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
John Lo [Sat, 4 Jun 2016 04:02:37 +0000 (00:02 -0400)]
VPP-113: BVI shall filter unicast DMAC for L2 to L3 forwading
As BVI receive a packet with unicast DMAC from the BD, including unknown
unicast flood packet, the packet should not be L3 forwarded unless its
DMAC matches the MAC of the BVI.
Change-Id: I46e18629c901062592c8ebe3a238c5cfdc1096b4
Signed-off-by: John Lo <loj@cisco.com>
John Lo [Sat, 4 Jun 2016 00:48:31 +0000 (20:48 -0400)]
VPP-100: Fix IP4 local handling of TCP/IP fragmented packet
Fix previous change that does not work on little endian machines.
Use inline call ip4_is_fragment() which is endian neutral.
Change-Id: I5a35d89d936650ab6c628dfc388b8c992a74a589
Signed-off-by: John Lo <loj@cisco.com>
Chris Luke [Thu, 2 Jun 2016 15:00:41 +0000 (11:00 -0400)]
VPP-91 fix sr tunnel add_del collision check
The add_del function was not properly checking if a tunnel already
existed; instead it was checking if the given tunnel name existed.
If no tunnel name was given it flat out refused to add a tunnel
even though that is optional.
Cleanup the add/del parameter validation to "do what I expect" it
to do:
When adding a tunnel:
- If a "name" is given, it must not exist.
- The "key" is always checked, and must not exist.
When deleting a tunnel:
- If the "name" is given, and it exists, then use it.
- If the "name" is not given, use the "key".
- If the "name" and the "key" are given, then both must point to the
same thing.
Change-Id: I9b48ae0203f9664cf8af0f7dc49bf480ddec10d5
Signed-off-by: Chris Luke <chrisy@flirble.org>
(cherry picked from commit
e54436005341800f76a584299ef8bf99e8d66227)
Chris Luke [Wed, 25 May 2016 18:39:47 +0000 (14:39 -0400)]
VPP-92 Fixup some srv6 issues
Some small fixes to the srv6 code to bring it toward
conformance with draft-previdi-6man-segment-routing-header-05.
- The first segment needs to remain in the segment list.
- The segment list template needs a space for the ultimate
destination.
- The ultimate destination needs to be inserted into that
space when adding the SRH.
Change-Id: I66db6912e0128da084f14ceca20918ef67ccff79
Signed-off-by: Chris Luke <chrisy@flirble.org>
(cherry picked from commit
4b8b718ff9bbba3bea018505ac591bb737f68001)
Ed Warnicke [Thu, 2 Jun 2016 22:38:22 +0000 (17:38 -0500)]
VPP-107 Fix for mistake that breaks pkg-rpm in
https://gerrit.fd.io/r/#/c/1338/
Change-Id: I8b7fffe24cbeb435b18faaada9ef1cea9fd93d39
Signed-off-by: Ed Warnicke <eaw@cisco.com>
John Lo [Thu, 2 Jun 2016 19:52:21 +0000 (15:52 -0400)]
VPP-106: Patch e40i driver to support VLAN sub-interface
Check packet for presence of VLAN tag in the MAC header and set
the PKT_RX_VLAN_PKT flag to trigger sub-interface lookup in VPP
ethernet-input node.
Change-Id: Iadbfc59d08ef85efb936c88323a90194f3cd656f
Signed-off-by: John Lo <loj@cisco.com>
John Lo [Thu, 2 Jun 2016 13:28:37 +0000 (09:28 -0400)]
VPP-100: Fix IPv4 local handling of IP fragmented packets
Before VPP is enhenced to do IP reassembly of local packets, just set
the protocol path to "experimental" for now so they will be error-punted
as unknow IP protocol.
Change-Id: I2ffefb0b4205357653ba24d80c722cafd5972fba
Signed-off-by: John Lo <loj@cisco.com>
Chris Luke [Wed, 1 Jun 2016 23:25:49 +0000 (19:25 -0400)]
VPP-105 Map API SHM uid/gid name to number
When providing uid or gid for the API SHM, if non-numeric values
are given look them up in the local system user database and if
found use the values discovered.
Change-Id: I95152f58646643bc44d2af4cbad6338901935c69
Signed-off-by: Chris Luke <chrisy@flirble.org>
Chris Luke [Tue, 31 May 2016 14:42:14 +0000 (10:42 -0400)]
VPP-98 Dedicated storage for VXLAN over IPv6 hash keys
When creating VXLAN over IPv6 the code was using storage for the
hash key that could later be moved. Since the key is larger than
the word size this was being referenced as a pointer; when the
storage moves that breaks the hash.
Instead allocate dedicated storage for the key.
This patch also includes other minor cleanups, including using
clib_memcpy in places it should be used and some whitespace
fixes.
Change-Id: I579f2cb515853ef56dedcca350fcad08aa6111a9
Signed-off-by: Chris Luke <chrisy@flirble.org>
Dave Barach [Tue, 31 May 2016 18:05:46 +0000 (14:05 -0400)]
VPP-83 Allow non-privileged clients to use the vpp binary API.
Use the command line argument "api-segment { uid <nnn> gid <nnn> }" to
configure shared memory segment file ownership. Defaults to uid = gid
= 0. Shared-memory segments are explicitly set to 0770 mode, aka
"rwxrwx---".
Change-Id: Ic5d596b68139add61e7de6ace035c57dfd030111
Signed-off-by: Dave Barach <dave@barachs.net>
John Lo [Tue, 31 May 2016 19:42:40 +0000 (15:42 -0400)]
VPP-102: vHost reconnect to previously used sockets on VPP restart
Change-Id: Ida11bddb52268e0e8513b7b379eeed6103bd48f1
Signed-off-by: John Lo <loj@cisco.com>
Ed Warnicke [Tue, 31 May 2016 21:04:16 +0000 (14:04 -0700)]
Fix build-root/scripts/version to not have spurious ~
Change-Id: Id28f134e3a4aa19c5756014d53004501db0d0c88
Signed-off-by: Ed Warnicke <eaw@cisco.com>
John Lo [Tue, 31 May 2016 20:25:13 +0000 (16:25 -0400)]
VPP97: Flooding of pkts with multiple buffers in BD with BVI crashes VPP
The loopback interface should use vnet_interface_output_no_flatten so
follow-on buffers of a jumbo packet do not get put on the output frame
and be sent back to ethernet-input or l2-input node.
The replication_recycle_callback() function should not assume follow-on
buffers of a jumbo packet are on the buffer free list.
Change-Id: Ide646a6d9b43e82782c0581ea3022a9e70f82582
Signed-off-by: John Lo <loj@cisco.com>
Andrej Kozemcak [Thu, 26 May 2016 10:20:08 +0000 (12:20 +0200)]
ONE-15: Fix duplicate locator, refactoring locator
Check duplication locator and clean after locator when remove it.
Refactoring locator_set code.
Change-Id: Ib83cbcddc7a363a60fa5b6a366203d0dc0ea7ca6
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
John Lo [Sat, 28 May 2016 02:07:44 +0000 (22:07 -0400)]
VPP-96 ENID driver update for rx of jumbo pkts using muliple mbuf's
Change-Id: I0e985b079da3224f4886e3ee2cece4d046e291eb
Signed-off-by: John Lo <loj@cisco.com>
Chris Luke [Fri, 27 May 2016 16:11:24 +0000 (12:11 -0400)]
VPP-95 VXLAN add_del API intermittent failure
The VXLAN add_del API sometimes rejects calls with
VNET_API_ERROR_SAME_SRC_DST when the two parameters are obviously
different. This is because the API code is checking the "is_ip6" flag in
a not-yet initialized area of memory leading to random results.
Also fix help text for vxlan_add_del_tunnel in vat.
This does not change the API; it repairs intermittent failure.
Change-Id: I41863694f478c1f669078f82f69d8cca4841c989
Signed-off-by: Chris Luke <chrisy@flirble.org>
Andrej Kozemcak [Wed, 25 May 2016 10:43:21 +0000 (12:43 +0200)]
ONE-14: Fix crash when re-enable Lisp
Change-Id: Ib95338d7055dea9036eddb7dff5ca7ccbcb35639
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
(cherry picked from commit
94e34764b46a2babcaea6b309158524a7c1bb632)
Hongjun Ni [Wed, 25 May 2016 09:35:51 +0000 (17:35 +0800)]
VPP-89: Fix an issue in format_vxlan_gpe_tunnel
Change-Id: Ie81e2eb918e441ddaa9e7ab57e8bb0129f0f4f8f
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
Marek Gradzki [Tue, 24 May 2016 11:32:26 +0000 (13:32 +0200)]
VPP-86: fix array copy in generated JNI code
Change-Id: Ic67b3c0623d98c5ee3f1ffa1e1bd9cfb96b233bd
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Chris Luke [Fri, 20 May 2016 16:13:02 +0000 (12:13 -0400)]
VPP-77 Creating VXLAN over IPv6 via API fails
Tunnel dst is incorrectly being set to the requested src address.
Change-Id: I44e2ee475f0572e78d148951c5d4684e85e08ce7
Signed-off-by: Chris Luke <chrisy@flirble.org>
Ed Warnicke [Tue, 17 May 2016 01:37:19 +0000 (20:37 -0500)]
Add newline to the end of .gitreview
Change-Id: I9a5a97c4a42b8aebbb6ba132879b7843ca7cfacd
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Ed Warnicke [Mon, 16 May 2016 20:02:30 +0000 (15:02 -0500)]
Initial changes for stable/1606 branch
This patch adds an entry for the defaultbranch
in .gitreview and also changes the generated
jar file version to 16.06.
Change-Id: I9acd35745eee7daa90d9abcc33e75b76c11af76e
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Keith Burns (alagalah) [Mon, 16 May 2016 16:53:13 +0000 (09:53 -0700)]
VPP-61 Patch2/2 Removing NSH from VPP for move to NSH_SFC
Change-Id: I76359b621b2edc599cf2e9ee845d97293a5d46f7
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Keith Burns (alagalah) [Mon, 16 May 2016 14:47:14 +0000 (07:47 -0700)]
VPP-61 Patch1/2 - Remove NSH from VPP
- Had issues with original patch and CSIT, breaking into
-- Makefile and API changes
-- Follow up patch removing NSH directory
Change-Id: I6c2f49a74d59b97ce4ea43799cc6f01f5cb1d5a2
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Damjan Marion [Mon, 16 May 2016 14:52:55 +0000 (16:52 +0200)]
VPP-58: Fix build on AMD Opteron
Change-Id: Ib3e10fd4c27dde4f90b8d156f0c8547787ad46e2
Signed-off-by: Damjan Marion <damarion@cisco.com>
Damjan Marion [Mon, 16 May 2016 13:55:36 +0000 (15:55 +0200)]
Add build number to VPP version if BUILD_NUMBER var is set
Change-Id: I73ecc12224fdfb08b7aa6118761b368577ce33d5
Signed-off-by: Damjan Marion <damarion@cisco.com>
Matus Fabian [Fri, 13 May 2016 12:44:48 +0000 (05:44 -0700)]
Add configure policer API
JIRA: VPP-67
Change-Id: I04560d78e2eb131cd6cc31472b70b3d3e8fdd79a
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Pierre Pfister [Fri, 13 May 2016 06:47:06 +0000 (07:47 +0100)]
VPP-68: L2 Rewrite: Support for chained classify tables
The classifying capabilities are pretty limited if only a single table can be used.
This patch adds support for chained classify tables to L2 Rewrite feature.
Change-Id: Ib678fe2028f17b441adb75d85bf3e31185e42c59
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
Pierre Pfister [Tue, 10 May 2016 16:11:22 +0000 (17:11 +0100)]
VPP-69: Create fib or bridge domain with arbitrary ID
It appeared to me that it might be usefull
to allow users to create fibs or bridge domains without
a complete knowledge of the current used IDs.
These changes define fib and bridge domain constructors
when the provided ID is ~0. In such a case, an unused ID is
used to create a new fib or bridge domain.
Change-Id: Iaba69a023296e6d17bdde45980f9db84832a3995
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
Chris Luke [Sat, 14 May 2016 16:06:42 +0000 (12:06 -0400)]
VPP-57 Add missing license headers in doc files
Change-Id: Icd1f8952f66d3cee027c59f3148c67f1839de306
Signed-off-by: Chris Luke <chrisy@flirble.org>
Dave Wallace [Sat, 14 May 2016 02:49:36 +0000 (22:49 -0400)]
VPP-64: Fix top-level "make pkg-deb" which breaks if CDPATH is set in the user's
bash environment.
Change-Id: Ib13e6fdafa67175937e57fad4e75e553cb1e08a3
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Dave Wallace [Fri, 13 May 2016 23:00:29 +0000 (19:00 -0400)]
VPP-65: Fix top-level "make install-dep" to work behind a firewall /
proxy-server on Ubuntu.
Change-Id: I3f662455728adb81ca5a079540d8a9c615a5b977
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Filip Tehlar [Fri, 13 May 2016 15:37:35 +0000 (17:37 +0200)]
ONE-13: Add CLI/API for LISP static remote mappings
Change-Id: Ic4c717af9629541bac0a0e6c65d0157619c8f578
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Chris Luke [Sat, 14 May 2016 16:17:12 +0000 (12:17 -0400)]
VPP-62 Add a doxy filter to enable vpe.api doc
This makes Doxygen think the API definitions are structs which is close
enough to be able to document the API methods.
It also has logic to create an indexed API page but that's disabled for
now because it duplicates the "brief" text twice in the struct doc.
Fixes a minor line numbering issue in filter_c.py.
Change-Id: If380160b73e7c10d999b35a76f55d0e27cbc91cc
Signed-off-by: Chris Luke <chrisy@flirble.org>
Dave Barach [Sat, 14 May 2016 22:38:48 +0000 (18:38 -0400)]
VPP-63: clean up config scripts, remove specific hostnames
Change-Id: Ifb77256fa691b1a90045a10448835c09b764e74f
Signed-off-by: Dave Barach <dave@barachs.net>
Chris Luke [Fri, 13 May 2016 17:41:36 +0000 (13:41 -0400)]
VPP-57 Add doxygen build dependencies
Change-Id: I764d8a440c050d753e0380e139f489d3085f17f4
Signed-off-by: Chris Luke <chrisy@flirble.org>
Florin Coras [Fri, 13 May 2016 16:09:56 +0000 (18:09 +0200)]
ONE-7: Fix map-request encapsulation
We now try to find the first map-resolver IP we have a route to and
decide the ip lookup node according to map-resolver IP.
Change-Id: I68fc12861dc1e9a203ebf6caefd4f053a741a785
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ed Warnicke [Mon, 9 May 2016 19:43:06 +0000 (14:43 -0500)]
Whitespace probe for CI
Change-Id: I3744ee19a21dcea2885aef2800244c93aa19763a
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Chris Luke [Tue, 3 May 2016 20:34:59 +0000 (16:34 -0400)]
VPP-57 Add Doxygen to VPP
- Configures Doxygen.
- Adds a source filter to do magic on our use of the preprocessor to do
constructor stuff to make Doxygen grok it better.
- Adds a convenience helper to the root Makefile.
- Adds a README.md to the root directory (and which Doxygem uses as its
"mainpage".
- Add several other documentative files.
- Currently using SVG for call graphs, though this may have a
load-time performance impact in browsers.
Change-Id: I25fc6fb5bf634319dcb36a7f0e32031921c125ac
Signed-off-by: Chris Luke <chrisy@flirble.org>
Keith Burns (alagalah) [Fri, 6 May 2016 01:16:50 +0000 (18:16 -0700)]
VPP43 - NSH refactoring: Added nsh-map nodes
- removed vnet/vnet/nsh-gre
- removed all nsh from vnet/vnet/nsh_vxlan_gpe to
vnet/vnet/nsh
- moved vnet/vnet/nsh_vxlan_gpe to vnet/vnet/vxlan_gpe
- added cli and binary api for VXLAN GPE tunnels
- plan to move vnet/vnet/nsh to new repo (sfc_nsh) and make plugin
- added cli for NSH (binary API will be done in sfc_nsh)
- vnet/vnet/gre will be extended in VPP-54
Change-Id: I1d27def916532321577ccd68cb982ae0d0a07e6f
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Andrej Kozemcak [Mon, 9 May 2016 08:52:16 +0000 (10:52 +0200)]
ONE-11: Fix bugs in LISP API
- check input variables
- in locator_set dump, add support for remote locator_set
Change-Id: Ib10028e83fead358f820ae45c71b6ca4dfbe2f1e
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
Damjan Marion [Thu, 12 May 2016 17:08:24 +0000 (19:08 +0200)]
VPP-53: clang build fails in API on SR tests
Change-Id: Ib3117d7b5b6b8c97acfea17ad27c965f6ce2e829
Signed-off-by: Damjan Marion <damarion@cisco.com>
Maros Marsalek [Thu, 12 May 2016 08:31:35 +0000 (10:31 +0200)]
Generate jvpp sources in build-root
+ Fail build when JVpp does not compile
Change-Id: I4ad3ffb5d7ff6edaad89de66a9f0bd79a14fb690
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Ed Warnicke [Thu, 12 May 2016 04:06:05 +0000 (04:06 +0000)]
Revert "Whitespace change for testing CI"
This reverts commit
cf9b712f57e3e81662e0815bd19ce19583783650.
This reverts gerrit: https://gerrit.fd.io/r/#/c/1078/
Change-Id: I4cf8c238fd81b5dc8bd077bbdd00cf72aef796ed
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Ed Warnicke [Thu, 12 May 2016 02:46:19 +0000 (21:46 -0500)]
Whitespace change for testing CI
Change-Id: I52bf3c1c8ece08a4b52fce1f34704b944f9c1888
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Tibor Sirovatka [Mon, 9 May 2016 14:41:31 +0000 (16:41 +0200)]
JVPP - null checks changed to Objects.requireNonNull usage
Review changes incorporated
Change-Id: Ia04b62144a0d3643095b518db538c7eb5137c048
Signed-off-by: Tibor Sirovatka <tsirovat@cisco.com>
Florin Coras [Wed, 11 May 2016 10:13:47 +0000 (12:13 +0200)]
ONE-9: Fix clang build errors
Change-Id: Icbf3e269471ee0fc1d21f842b2ea220328a0f891
Signed-off-by: Florin Coras <fcoras@cisco.com>
Florin Coras [Tue, 10 May 2016 18:01:44 +0000 (20:01 +0200)]
ONE-8: Fix adj signature issues
When inserting routes into ip4/6 fibs, we first added a dummy adjacency
and afterwards manually updated its rewrite header to enable src/dst
forwarding. The downside to this is that the adj signature is changed
and therefore when deleting a route the adjacency signature is not
removed from adj_index_by_signature hash resulting in crash if the same
adjacency is re-inserted.
This patch avoids the issue by enforcing the insertion of 'complete'
adjacencies thereby obviating the need to update the rewrite header.
Change-Id: Ib43bfe72a65e2cf9ef7685a99596eb1d7723e543
Signed-off-by: Florin Coras <fcoras@cisco.com>
Filip Tehlar [Tue, 10 May 2016 14:58:29 +0000 (16:58 +0200)]
ONE-6: dp is not programmed when re-enabling LISP
Change-Id: I4c0c5d44168da811a713943275430a378ff46929
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Chris Luke [Tue, 10 May 2016 14:45:10 +0000 (10:45 -0400)]
VPP-46 Fix cut-and-paste in the debug CLI
Since the move to line-mode the debug CLI was eating everything in the
input_vector but only processing upto the first newline. Cut-and-paste
type operations generally send a large block of input with multiple
newlines and thus all but the very first line were simply ignored.
This patch fixes that and also cleans up the difference between
input_vector and current_command which in turn removes a lot of cruft
from the keystroke parser.
Previously current_command was just the character accumulator inside the
char-by-char keystroke parser; complete commands were copied back to
input_vector (overwriting anything already in there).
Now, in char-by-char mode:
- input_vector is the stream of incoming bytes yet to be processed
- current_command is the accumulated characters of the next command to
be executed; once newline is found, it is the complete command to be
executed.
In line mode:
- input_vector and current_command are the same thing.
Change-Id: I72d21f0f3508b413879071ab186a71cef1124a2b
Signed-off-by: Chris Luke <chrisy@flirble.org>
Andrew Yourtchenko [Tue, 10 May 2016 10:51:34 +0000 (10:51 +0000)]
Avoid clobbering output_function by concurrent CLI sessions doing vlib_process_wait_for_event*.
A problem is easily reproducible by taking the test harness code from the commit,
and launching it in two terminals with some time overlap - the outputs will
be sent to the wrong session. This commit moves the output_function and argument
from a global structure into the process structure, thus the output_function
is not clobbered anymore and each session gets only its own output.
To ensure the callers can redirect the outputs to different destinations
(e.g. the API calls via shared memory, etc.) the existing logic
for vlib_cli_input() was retained.
To avoid the magic numbers usage in the logic that does the page-alignment
of the process stack, there are changes around the stack[] member
of vlib_process_t. Also added a compile-time assert to ensure that
the stack does indeed start on the page size multiple boundary.
Change-Id: I128680ac480735e5f214f81a884e414268e5d652
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Filip Tehlar [Mon, 9 May 2016 07:39:26 +0000 (09:39 +0200)]
ONE-4: Add LISP enable/disable API/CLI
This patch adds an enable/disable API/CLI for control plane
which calls similar functions for data plane. When re-enabling
it also re-populates dataplane with tunnels and interfaces.
Change-Id: Id8c3d6af90ecc0be331d502756914b1f62824046
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Matus Fabian [Fri, 6 May 2016 13:14:13 +0000 (15:14 +0200)]
Add af_packet API
Change-Id: I39409ae9e75fdb59d8cbbd940fa192b24eb79b6a
Signed-off-by: Matus Fabian <matfabia@cisco.com>
Florin Coras [Mon, 9 May 2016 17:28:58 +0000 (19:28 +0200)]
ONE-3: Delete dst route when src fib is empty
Properly check that src fib is empty.
Change-Id: I4072169027a404cad66eaaa8450f7c18f1fa8073
Signed-off-by: Florin Coras <fcoras@cisco.com>
Shwetha Bhandari [Wed, 4 May 2016 06:12:57 +0000 (08:12 +0200)]
VPP-44: iOAM service and path verification using shamir's secret sharing
Change-Id: I445ad13f8f93cb75cacc94192c4ae85c8ca14e35
Signed-off-by: Shwetha Bhandari <shwethab@cisco.com>
Florin Coras [Fri, 6 May 2016 12:22:40 +0000 (14:22 +0200)]
ONE-5: Remove unused vnet_lisp_gpe_add_del_tunnel API
Change-Id: Ib22ec807d2b74b7c3cb37f66052cd07bc4d896db
Signed-off-by: Florin Coras <fcoras@cisco.com>
Ole Troan [Mon, 9 May 2016 10:23:45 +0000 (12:23 +0200)]
VPP-20: Verify valid sw_if_index in ip_address_dump.
(Also checked other API calls for same error without finding any.)
Change-Id: I1062ecf8eff004efb3fad4582a00c6b512c36999
Signed-off-by: Ole Troan <ot@cisco.com>
Ed Warnicke [Thu, 5 May 2016 23:03:27 +0000 (18:03 -0500)]
Switch to using -headless JDK
By default, jdks bring a bunch of UI related things
we don't need, so switch to headeless.
Also, use default-jdk-headless for Ubuntu after 14.04.
Use openjdk-8-jdk-headless for Ubuntu 14.04.
Change-Id: I3cf14c39c9f59dc2f1beba8dfb19971f4b67f5a6
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Ed Warnicke [Thu, 5 May 2016 20:19:49 +0000 (15:19 -0500)]
Switch to using nexus.fd.io for dpdk tarball
Change-Id: I9751cbb9137627491ee4bd03e0318429327c0bd8
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Chris Luke [Fri, 6 May 2016 14:12:30 +0000 (10:12 -0400)]
VPP-35 Add GRE tunnels to sw_interface_dump
GRE tunnels were missing from vpp_api_test's sw_interface_dump command.
$ sudo ./build-root/install-vpp_debug-native/vpp-api-test/bin/vpp_api_test json
vat# sw_interface_dump
[
...
{
"sw_if_index": 7,
"sup_sw_if_index": 7,
"l2_address_length": 0,
"l2_address": [0, 0, 0, 0, 0, 0, 0, 0],
"interface_name": "gre0",
"admin_up_down": 1,
"link_up_down": 0,
"link_duplex": 0,
"link_speed": 0,
"mtu": 0,
"sub_id": 0,
"sub_dot1ad": 0,
"sub_number_of_tags": 0,
"sub_outer_vlan_id": 0,
"sub_inner_vlan_id": 0,
"sub_exact_match": 0,
"sub_default": 0,
"sub_outer_vlan_id_any": 0,
"sub_inner_vlan_id_any": 0,
"vtr_op": 0,
"vtr_push_dot1q": 0,
"vtr_tag1": 0,
"vtr_tag2": 0
}
]
Change-Id: I6f174f3c384eac464250b22f43b25be6a844aa66
Signed-off-by: Chris Luke <chrisy@flirble.org>
Chris Luke [Fri, 6 May 2016 15:51:54 +0000 (11:51 -0400)]
VPP-45 Fix crash when GRE packet received on new i/f
If a GRE tunnel is created, no other interface added and the GRE tunnel
is not set "up" then a crash occurs on the first packet for this tunnel
because fib_index_by_sw_if_index[] does not yet have a mapping to the fib
the new interface is in. The code to set this is missing from
gre/interface.c
Change-Id: I567ad74a2af3ea5afe4a40ed39a1d4395642f77c
Signed-off-by: Chris Luke <chrisy@flirble.org>
Ed Warnicke [Fri, 6 May 2016 17:58:31 +0000 (12:58 -0500)]
Small improvement to vagrant file
Change-Id: Ia85ed0ef55cb5da118289667d7b217d8890d487e
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Chris Luke [Fri, 6 May 2016 21:09:09 +0000 (17:09 -0400)]
VPP-34 GRE traffic blackholes in encap direction
The GRE code is missing the logic to indicate the "hardware" interface
is up. The fix is to listen for admin up/down events on the "software"
interface and reflect that into the hardware interface state.
Change-Id: If06e4f03989b2c52c32f50c11e1943e42bb2609f
Signed-off-by: Chris Luke <chrisy@flirble.org>
John Lo [Thu, 5 May 2016 23:55:13 +0000 (19:55 -0400)]
Check IP adj_index to make sure it is valid to prevent possible crash
Change-Id: I439aac05638fd40e314bec8756e42a32c436321c
Signed-off-by: John Lo <loj@cisco.com>
Damjan Marion [Thu, 5 May 2016 20:49:38 +0000 (22:49 +0200)]
Fix vpp_lite build caused by missing definition of unlikely macro
Change-Id: I11b34e171c1c7907dd3faec219866418b4e792f6
Signed-off-by: Damjan Marion <damarion@cisco.com>
Andrej Kozemcak [Mon, 2 May 2016 10:14:33 +0000 (12:14 +0200)]
ONE-2: Add new LISP dump API for lisp gpe
API:
lisp_gpe_enable_disable_dump
Change-Id: I1c8e78f00f9a3f99c1f2f54884af565292e4ccf8
Signed-off-by: Andrej Kozemcak <akozemca@cisco.com>
Keith Burns (alagalah) [Wed, 4 May 2016 23:11:38 +0000 (16:11 -0700)]
VPP-39 - refactoring of NSH into own folder
- common header files and structs used in both GRE and VXLAN-GPE
Change-Id: I06d0b773e936fb011408817237059f24a4beb412
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Mohsin Kazmi [Mon, 2 May 2016 12:04:57 +0000 (14:04 +0200)]
NETMAP: Some fixes
1) Correct the NIOCRXSYNC macro on receive side from NIOCTXSYNC.
2) Flush the pending messages in the tx rings.
Change-Id: I581040d03b1633a3d6fb22fa1fb285bcb7975afb
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Matthew Smith [Sun, 1 May 2016 19:52:08 +0000 (14:52 -0500)]
VPP-42: VPP crashes in IPsec code when running multithreaded
Change-Id: Ib231642cfead5f5e8e45508361a11c87aad83b51
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Marek Gradzki [Tue, 3 May 2016 15:05:27 +0000 (17:05 +0200)]
HONEYCOMB-10: fix issues with FindClass in multithreaded environments
Added jclass reference caching and updated JNI version to 1.8
Change-Id: Ie8dbbd4b91b90bf9e4e9a6148313e46056b0d67e
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Dave Barach [Wed, 4 May 2016 13:42:07 +0000 (09:42 -0400)]
VPP-12: only remove vpp-related files from /dev/shm
Change-Id: I1b6983a6d23d3d2635814cdd307efa25cd5c8b7b
Signed-off-by: Dave Barach <dave@barachs.net>
John Lo [Tue, 3 May 2016 21:47:48 +0000 (17:47 -0400)]
ENIC driver patch to set PKT_RX_VLAN_PKT only if pkt passed has VLAN tag
Change-Id: I72475bfe50e42886ffa8fb6e58eb8192892fa381
Signed-off-by: John Lo <loj@cisco.com>
Ed Warnicke [Tue, 3 May 2016 21:47:50 +0000 (16:47 -0500)]
Fix for unattended in Makefile
Also works around verify
Change-Id: I79ac470ec3fa9943c3a0913ebfaaf91176eb9a81
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Marek Gradzki [Tue, 3 May 2016 14:34:13 +0000 (16:34 +0200)]
HONEYCOMB-10: Copy context identifier from request to reply
Some of the send_*_details methods did not copy context
identifier from dump request message to details response.
The context identifier is used for request<->reply matching.
Change-Id: I8a744f3817bef94d7fa8ecb7bec6ea942c1a8793
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Hongjun Ni [Mon, 2 May 2016 17:43:44 +0000 (10:43 -0700)]
VPP-15 Add decap-next for nsh-gre tunnel short_help
Change-Id: I1965e9852f62aaf8c1576b72446a43b5878eb452
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
Hongjun Ni [Mon, 2 May 2016 17:56:48 +0000 (10:56 -0700)]
VPP-15 Add ethernet support for nsh-gre's decap-next
Change-Id: Icf3424671b4aa0f619983a3eb61785b533fdc11d
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
Florin Coras [Mon, 2 May 2016 16:26:26 +0000 (18:26 +0200)]
Small fixes to lisp-gpe header and decap
- enforce lisp-gpe router mode (set P bit)
- fix selection of ip6 decap node
- fix dual-dual lool error index init
Change-Id: I1a9623c0eb7e81a2cfb60efaa88dc44ee65e664d
Signed-off-by: Florin Coras <fcoras@cisco.com>
Chris Luke [Mon, 2 May 2016 20:00:43 +0000 (16:00 -0400)]
VPP-31 Fix linker issue with new sr-replicate
Changes in gnu ld in Ubuntu 16.04 tickles an issue with the
declaration pattern used for vlib_node_registration when,
as is the case in sr_replicate.c, the forward declaration is
seen by the linker in a module before the real declaration.
This patch uses the "extern" keyword in the forward declaration
to avoid this issue and removes extra forward declarations.
Change-Id: I075b0cd9932404e1360c7f9aec7114003d110f60
Signed-off-by: Chris Luke <chrisy@flirble.org>
Maros Marsalek [Tue, 26 Apr 2016 13:03:26 +0000 (15:03 +0200)]
HONEYCOMB-10: JVpp documentation
Change-Id: Ibca8fc8c1962ca36d91898c1523afb2df6dfdc49
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Thu, 28 Apr 2016 07:38:15 +0000 (09:38 +0200)]
HONEYCOMB-10: Add specific methods for each request to Future facade
These specific methods remove the need for casting on client
side code while using generic send method
Change-Id: Ic0240359333831b676a7d205f63ac1c3f3f8af4c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Keith Burns (alagalah) [Mon, 2 May 2016 20:13:46 +0000 (13:13 -0700)]
VPP-30 sr_replicate requires DPDK
- added fix to disable functionality when no DPDK
- may extend to support non-DPDK case in future.
Change-Id: Ic8ad4eeb91c4866f3f102dd4a718898eb0419dee
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Marek Gradzki [Tue, 26 Apr 2016 10:09:05 +0000 (12:09 +0200)]
HONEYCOMB-10: jVpp - the new java API. C code and jar file generation
Added comments generation for C and Java files.
Change-Id: Ifb670a5592eb871bfe68804f0a8d8f9b5b14f00a
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Damjan Marion [Mon, 2 May 2016 17:40:27 +0000 (19:40 +0200)]
Re-do java-8 handling, add unattended switch to toplevel Makefile
Change-Id: Ifaea353be5b42bb6edbcfa0506d02b721c00e392
Signed-off-by: Damjan Marion <damarion@cisco.com>
Ed Warnicke [Mon, 2 May 2016 01:33:53 +0000 (20:33 -0500)]
Break out install.sh from build.sh
This is necessary because we are now using
build.sh for CI... and we shouldn't
install packages on CI boxes.
Change-Id: I68f7880dfc75bbc4aa278ab0765a43e3fb899f3d
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Keith Burns (alagalah) [Sun, 1 May 2016 16:12:18 +0000 (09:12 -0700)]
VPP-32 Increase # cpus to 2, leave RAM at 4G for virtualbox vagrant users
Change-Id: Ifb40316db96e019d6c14ff6a6e9653579009d4c3
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Mohsin Kazmi [Mon, 25 Apr 2016 14:43:46 +0000 (16:43 +0200)]
Netmap: typo correct
There is a typo mistake in netmap. This patch corrects it.
Change-Id: Id358e0de74555ac7858c93fa1335f02abd5624b5
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Keith Burns (alagalah) [Mon, 2 May 2016 17:20:53 +0000 (10:20 -0700)]
VPP-33 Removing javah from Makefile. Merged as fix for Gerrit 884
Change-Id: I2d9d6a607ffa1a8788c1ce79770db8b2b9bae6fb
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Maros Marsalek [Thu, 28 Apr 2016 10:29:33 +0000 (12:29 +0200)]
HONEYCOMB-10: jVpp - the new java API. Java code generation
The old japi has two main drawbacks:
* it is not fully generated (requres manual coding for
every new api call that returns data other thanstatus code)
* it is not asynchronous from Java perspective (requires
active wait loops - big overhead due to JNI boundary being
crossed lots of times).
The new api is lightweight (fully generated except for connect,
disconenct and ping) and truly asynchronous (uses callbacks,
utilities that offer java.util.concurrent.Future interface
are also provided).
Change-Id: I531080ef651e8a74f19210490c71d161221ab600
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Keith Burns (alagalah) [Fri, 25 Mar 2016 16:38:50 +0000 (09:38 -0700)]
IP6 SR multicast replicator
- adds ability to name tunnel
- creates policy as a collection of tunnel names
- map ip6 multicast address to policy and replicate packet
- adds zero memcpy for invariant portion of packet
Change-Id: Icd2fe6a2cf65c09906e82ed1afbb0eae8df79452
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Chris Luke [Fri, 29 Apr 2016 12:53:46 +0000 (08:53 -0400)]
VPP-26 Iterate through empty command line in cli history
When cursoring through the command history in the CLI, when you reach
the end of the history (ie, back at "where you started") most CLI's
typically show a blank line. This is a visual cue that you are back
where you started.
Change-Id: I5733dbd0dcdc6deac6a0a856cfadbdb987456ec0
Signed-off-by: Chris Luke <chrisy@flirble.org>
Florin Coras [Fri, 29 Apr 2016 13:36:29 +0000 (15:36 +0200)]
Fix use of vni throughout lisp code
This leverages the vni LCAF support introduced in a previous patch.
Change-Id: I0a1b6b9dfc8095d62ad3f4e800b9f2d04c475521
Signed-off-by: Florin Coras <fcoras@cisco.com>
John Lo [Fri, 29 Apr 2016 18:47:46 +0000 (14:47 -0400)]
Revert ixgbe driver vRX removal of packet type recognition
VPP still needs to use packet type recognition in vRX path of the
ixgbe driver so ip packet can bypass ethernet-input node processing
for better performance. The shortcoming of packet type recognition
in the vRX path does not affect VPP.
Change-Id: Ibc96021c50402a75a8bc4f80125c664714276cef
Signed-off-by: John Lo <loj@cisco.com>
Damjan Marion [Wed, 13 Apr 2016 07:48:56 +0000 (09:48 +0200)]
Add indirect next hop support
Change-Id: I0626c2650eba7961a15b1e87a664b57bef5503a2
Signed-off-by: Damjan Marion <damarion@cisco.com>
Florin Coras [Fri, 29 Apr 2016 15:04:50 +0000 (17:04 +0200)]
Remove unused variable in lisp decap
Change-Id: I6aef98252e6134fd2f1a30a8407086ab98285a53
Signed-off-by: Florin Coras <fcoras@cisco.com>
Chris Luke [Thu, 28 Apr 2016 17:44:38 +0000 (13:44 -0400)]
VPP-25 Add API for GRE tunnel create/delete/show.
Add API methods to create, delete and show GRE tunnels.
Also add missing CLI functionality for deleting and listing
configured tunnels.
Change-Id: I7565966037d94ade07938e4ff0d9333419716857
Signed-off-by: Chris Luke <chrisy@flirble.org>
Florin Coras [Fri, 29 Apr 2016 14:04:33 +0000 (16:04 +0200)]
Fix ip-udp encap checksum for ip6
Thanks to Chris Luke for reporting.
Change-Id: I4f2ac5bb0eb565738755ddb00e8c918134ff67b6
Signed-off-by: Florin Coras <fcoras@cisco.com>
Damjan Marion [Fri, 29 Apr 2016 12:51:57 +0000 (14:51 +0200)]
Fix ip4 address formatting in the show ip fib ouptut
Change-Id: I3ffb2e3cef63cbc9f2abc81bbdedabb34b9b3408
Signed-off-by: Damjan Marion <damarion@cisco.com>