From 32881935bb82b009528ba5a930b4399bad26abfd Mon Sep 17 00:00:00 2001 From: Florin Coras Date: Mon, 6 Feb 2023 13:30:13 -0800 Subject: [PATCH] vcl: improve vls handling of shared listeners Type: improvement Signed-off-by: Florin Coras Change-Id: I1970408de52e53d24cea06b3ae0cc68a38cbc97a --- src/vcl/vcl_locked.c | 15 +++++++-- src/vcl/vcl_private.h | 2 ++ src/vcl/vppcom.c | 86 ++++++++++++++++++++------------------------------- 3 files changed, 49 insertions(+), 54 deletions(-) diff --git a/src/vcl/vcl_locked.c b/src/vcl/vcl_locked.c index f6df0fbd5b7..8b0c66d4bdd 100644 --- a/src/vcl/vcl_locked.c +++ b/src/vcl/vcl_locked.c @@ -670,8 +670,19 @@ vls_listener_wrk_is_active (vcl_locked_session_t * vls, u32 wrk_index) static void vls_listener_wrk_start_listen (vcl_locked_session_t * vls, u32 wrk_index) { - vppcom_session_listen (vls_to_sh (vls), ~0); - vls_listener_wrk_set (vls, wrk_index, 1 /* is_active */ ); + vcl_worker_t *wrk; + vcl_session_t *ls; + + wrk = vcl_worker_get (wrk_index); + ls = vcl_session_get (wrk, vls->session_index); + + /* Listen request already sent */ + if (ls->flags & VCL_SESSION_F_PENDING_LISTEN) + return; + + vcl_send_session_listen (wrk, ls); + + vls_listener_wrk_set (vls, wrk_index, 1 /* is_active */); } static void diff --git a/src/vcl/vcl_private.h b/src/vcl/vcl_private.h index 93e76565ee7..a3ae42714d5 100644 --- a/src/vcl/vcl_private.h +++ b/src/vcl/vcl_private.h @@ -142,6 +142,7 @@ typedef enum vcl_session_flags_ VCL_SESSION_F_WR_SHUTDOWN = 1 << 5, VCL_SESSION_F_PENDING_DISCONNECT = 1 << 6, VCL_SESSION_F_PENDING_FREE = 1 << 7, + VCL_SESSION_F_PENDING_LISTEN = 1 << 8, } __clib_packed vcl_session_flags_t; typedef struct vcl_session_ @@ -726,6 +727,7 @@ int vcl_segment_attach (u64 segment_handle, char *name, ssvm_segment_type_t type, int fd); void vcl_segment_detach (u64 segment_handle); void vcl_segment_detach_segments (u32 *seg_indices); +void vcl_send_session_listen (vcl_worker_t *wrk, vcl_session_t *s); void vcl_send_session_unlisten (vcl_worker_t * wrk, vcl_session_t * s); int vcl_segment_attach_session (uword segment_handle, uword rxf_offset, diff --git a/src/vcl/vppcom.c b/src/vcl/vppcom.c index a800b44aaa0..1b0da450781 100644 --- a/src/vcl/vppcom.c +++ b/src/vcl/vppcom.c @@ -51,8 +51,8 @@ vcl_msg_add_ext_config (vcl_session_t *s, uword *offset) clib_memcpy_fast (c->data, s->ext_config, s->ext_config->len); } -static void -vcl_send_session_listen (vcl_worker_t * wrk, vcl_session_t * s) +void +vcl_send_session_listen (vcl_worker_t *wrk, vcl_session_t *s) { app_session_evt_t _app_evt, *app_evt = &_app_evt; session_listen_msg_t *mp; @@ -80,6 +80,7 @@ vcl_send_session_listen (vcl_worker_t * wrk, vcl_session_t * s) clib_mem_free (s->ext_config); s->ext_config = 0; } + s->flags |= VCL_SESSION_F_PENDING_LISTEN; } static void @@ -554,6 +555,7 @@ vcl_session_bound_handler (vcl_worker_t * wrk, session_bound_msg_t * mp) session->transport.lcl_port = mp->lcl_port; vcl_session_table_add_listener (wrk, mp->handle, sid); session->session_state = VCL_STATE_LISTEN; + session->flags &= ~VCL_SESSION_F_PENDING_LISTEN; if (vcl_session_is_cl (session)) { @@ -1232,7 +1234,7 @@ vppcom_session_unbind (u32 session_handle) vcl_send_session_unlisten (wrk, session); - VDBG (1, "session %u [0x%llx]: sending unbind!", session->session_index, + VDBG (0, "session %u [0x%llx]: sending unbind!", session->session_index, session->vpp_handle); vcl_evt (VCL_EVT_UNBIND, session); @@ -1693,29 +1695,6 @@ vppcom_session_listen (uint32_t listen_sh, uint32_t q_len) return VPPCOM_OK; } -static int -validate_args_session_accept_ (vcl_worker_t * wrk, vcl_session_t * ls) -{ - if (ls->flags & VCL_SESSION_F_IS_VEP) - { - VDBG (0, "ERROR: cannot accept on epoll session %u!", - ls->session_index); - return VPPCOM_EBADFD; - } - - if ((ls->session_state != VCL_STATE_LISTEN) - && (!vcl_session_is_connectable_listener (wrk, ls))) - { - VDBG (0, - "ERROR: session [0x%llx]: not in listen state! state 0x%x" - " (%s)", - ls->vpp_handle, ls->session_state, - vcl_session_state_str (ls->session_state)); - return VPPCOM_EBADFD; - } - return VPPCOM_OK; -} - int vppcom_unformat_proto (uint8_t * proto, char *proto_str) { @@ -1749,38 +1728,41 @@ vppcom_unformat_proto (uint8_t * proto, char *proto_str) } int -vppcom_session_accept (uint32_t listen_session_handle, vppcom_endpt_t * ep, - uint32_t flags) +vppcom_session_accept (uint32_t ls_handle, vppcom_endpt_t *ep, uint32_t flags) { - u32 client_session_index = ~0, listen_session_index, accept_flags = 0; + u32 client_session_index = ~0, ls_index, accept_flags = 0; vcl_worker_t *wrk = vcl_worker_get_current (); session_accepted_msg_t accepted_msg; - vcl_session_t *listen_session = 0; - vcl_session_t *client_session = 0; + vcl_session_t *ls, *client_session = 0; vcl_session_msg_t *evt; u8 is_nonblocking; - int rv; again: - listen_session = vcl_session_get_w_handle (wrk, listen_session_handle); - if (!listen_session) + ls = vcl_session_get_w_handle (wrk, ls_handle); + if (!ls) return VPPCOM_EBADFD; - listen_session_index = listen_session->session_index; - if ((rv = validate_args_session_accept_ (wrk, listen_session))) - return rv; + if ((ls->session_state != VCL_STATE_LISTEN) && + (ls->session_state != VCL_STATE_LISTEN_NO_MQ) && + (!vcl_session_is_connectable_listener (wrk, ls))) + { + VDBG (0, "ERROR: session [0x%llx]: not in listen state! state (%s)", + ls->vpp_handle, vcl_session_state_str (ls->session_state)); + return VPPCOM_EBADFD; + } + + ls_index = ls->session_index; - if (clib_fifo_elts (listen_session->accept_evts_fifo)) + if (clib_fifo_elts (ls->accept_evts_fifo)) { - clib_fifo_sub2 (listen_session->accept_evts_fifo, evt); + clib_fifo_sub2 (ls->accept_evts_fifo, evt); accept_flags = evt->flags; accepted_msg = evt->accepted_msg; goto handle; } - is_nonblocking = vcl_session_has_attr (listen_session, - VCL_SESS_ATTR_NONBLOCK); + is_nonblocking = vcl_session_has_attr (ls, VCL_SESS_ATTR_NONBLOCK); while (1) { if (svm_msg_q_is_empty (wrk->app_event_queue) && is_nonblocking) @@ -1793,20 +1775,21 @@ again: handle: - client_session_index = vcl_session_accepted_handler (wrk, &accepted_msg, - listen_session_index); + client_session_index = + vcl_session_accepted_handler (wrk, &accepted_msg, ls_index); if (client_session_index == VCL_INVALID_SESSION_INDEX) return VPPCOM_ECONNABORTED; - listen_session = vcl_session_get (wrk, listen_session_index); + ls = vcl_session_get (wrk, ls_index); client_session = vcl_session_get (wrk, client_session_index); if (flags & O_NONBLOCK) vcl_session_set_attr (client_session, VCL_SESS_ATTR_NONBLOCK); - VDBG (1, "listener %u [0x%llx]: Got a connect request! session %u [0x%llx]," - " flags %d, is_nonblocking %u", listen_session->session_index, - listen_session->vpp_handle, client_session_index, + VDBG (1, + "listener %u [0x%llx]: Got a connect request! session %u [0x%llx]," + " flags %d, is_nonblocking %u", + ls->session_index, ls->vpp_handle, client_session_index, client_session->vpp_handle, flags, vcl_session_has_attr (client_session, VCL_SESS_ATTR_NONBLOCK)); @@ -1825,16 +1808,15 @@ handle: VDBG (0, "listener %u [0x%llx] accepted %u [0x%llx] peer: %U:%u " "local: %U:%u", - listen_session_handle, listen_session->vpp_handle, - client_session_index, client_session->vpp_handle, - vcl_format_ip46_address, &client_session->transport.rmt_ip, + ls_handle, ls->vpp_handle, client_session_index, + client_session->vpp_handle, vcl_format_ip46_address, + &client_session->transport.rmt_ip, client_session->transport.is_ip4 ? IP46_TYPE_IP4 : IP46_TYPE_IP6, clib_net_to_host_u16 (client_session->transport.rmt_port), vcl_format_ip46_address, &client_session->transport.lcl_ip, client_session->transport.is_ip4 ? IP46_TYPE_IP4 : IP46_TYPE_IP6, clib_net_to_host_u16 (client_session->transport.lcl_port)); - vcl_evt (VCL_EVT_ACCEPT, client_session, listen_session, - client_session_index); + vcl_evt (VCL_EVT_ACCEPT, client_session, ls, client_session_index); /* * Session might have been closed already -- 2.16.6