From e3750671423e70283dd1e60c53ddffdfe651ecbb Mon Sep 17 00:00:00 2001 From: Matthew Smith Date: Fri, 20 Jul 2018 11:52:05 -0500 Subject: [PATCH] fix IP directed broadcast node declarations The dev build ('make build') was failing because ip4_rewrite_bcast() and ip6_rewrite_bcast() are declared static and were not referenced. The node functions that were set for directed broadcast rewrite: ip4_rewrite_bcast_node - ip4_rewrite() ip6_rewrite_bcast_node - ip6_rewrite() Changed to: ip4_rewrite_bcast_node - ip4_rewrite_bcast() ip6_rewrite_bcast_node - ip6_rewrite_bcast() The release build ('make build-release') succeeds because there is a VLIB_NODE_FUNCTION_MULTIARCH() call referencing the function. That macro is empty for dev builds. Change-Id: I2a05f00ca43d0eae8ff2e3026991e69917003fe1 Signed-off-by: Matthew Smith --- src/vnet/ip/ip4_forward.c | 2 +- src/vnet/ip/ip6_forward.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vnet/ip/ip4_forward.c b/src/vnet/ip/ip4_forward.c index 000710ed817..8d4aead051e 100644 --- a/src/vnet/ip/ip4_forward.c +++ b/src/vnet/ip/ip4_forward.c @@ -2652,7 +2652,7 @@ VLIB_REGISTER_NODE (ip4_rewrite_node) = { }; VLIB_REGISTER_NODE (ip4_rewrite_bcast_node) = { - .function = ip4_rewrite, + .function = ip4_rewrite_bcast, .name = "ip4-rewrite-bcast", .vector_size = sizeof (u32), diff --git a/src/vnet/ip/ip6_forward.c b/src/vnet/ip/ip6_forward.c index 888b52643c1..efd5e0d106a 100644 --- a/src/vnet/ip/ip6_forward.c +++ b/src/vnet/ip/ip6_forward.c @@ -2013,7 +2013,7 @@ VLIB_REGISTER_NODE (ip6_rewrite_node) = VLIB_NODE_FUNCTION_MULTIARCH (ip6_rewrite_node, ip6_rewrite); VLIB_REGISTER_NODE (ip6_rewrite_bcast_node) = { - .function = ip6_rewrite, + .function = ip6_rewrite_bcast, .name = "ip6-rewrite-bcast", .vector_size = sizeof (u32), -- 2.16.6