From 18874913fb18c8089362dc72f9a0b3a6ac918f17 Mon Sep 17 00:00:00 2001 From: Dave Barach Date: Fri, 17 May 2019 14:48:27 -0400 Subject: [PATCH] Fix punctuation fails in 2x plugins More to the point: fix the Python API binding for the plugins. The http_static and ct6 plugin setup_message_id_table calls didn't have "_"'s between message names and CRCs. I would have expected this to originate in the emacs skeleton, but the skeleton is correct. Punctuation saves lives: "Let's eat Grandma..." != "Let's eat, Grandma..." More or less. Change-Id: Icd87813308701d203cf6f147b2bb90d39d51ddeb Signed-off-by: Dave Barach --- src/plugins/ct6/ct6.c | 2 +- src/plugins/http_static/http_static.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/ct6/ct6.c b/src/plugins/ct6/ct6.c index 478e9ac8f50..3dfa09f1875 100644 --- a/src/plugins/ct6/ct6.c +++ b/src/plugins/ct6/ct6.c @@ -235,7 +235,7 @@ ct6_plugin_api_hookup (vlib_main_t * vm) static void setup_message_id_table (ct6_main_t * cmp, api_main_t * am) { -#define _(id,n,crc) vl_msg_api_add_msg_name_crc (am, #n #crc, id + cmp->msg_id_base); +#define _(id,n,crc) vl_msg_api_add_msg_name_crc (am, #n "_" #crc, id + cmp->msg_id_base); foreach_vl_msg_name_crc_ct6; #undef _ } diff --git a/src/plugins/http_static/http_static.c b/src/plugins/http_static/http_static.c index 57f1cf70f0d..d4ec2983680 100644 --- a/src/plugins/http_static/http_static.c +++ b/src/plugins/http_static/http_static.c @@ -102,7 +102,7 @@ http_static_plugin_api_hookup (vlib_main_t * vm) static void setup_message_id_table (http_static_main_t * hmp, api_main_t * am) { -#define _(id,n,crc) vl_msg_api_add_msg_name_crc (am, #n #crc, id + hmp->msg_id_base); +#define _(id,n,crc) vl_msg_api_add_msg_name_crc (am, #n "_" #crc, id + hmp->msg_id_base); foreach_vl_msg_name_crc_http_static; #undef _ } -- 2.16.6