From 2113c7f28b154df16af3637f67484971759a00a7 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Beno=C3=AEt=20Ganne?= Date: Wed, 25 Nov 2020 13:53:21 +0100 Subject: [PATCH] dns: fix double-unlock MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit dns cache should no longer be unlocked by caller. Type: fix Fixes: 84a563ae4050cc0389dcd438fbe9ea882f2b8404 Change-Id: I3708718ae8f00e4e4f4e04381caa0095c8494b82 Signed-off-by: Benoît Ganne --- src/plugins/dns/dns.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/plugins/dns/dns.c b/src/plugins/dns/dns.c index de1862dd52c..f063e4f9e26 100644 --- a/src/plugins/dns/dns.c +++ b/src/plugins/dns/dns.c @@ -1471,12 +1471,6 @@ vl_api_dns_resolve_name_t_handler (vl_api_dns_resolve_name_t * mp) rmp->retval = clib_host_to_net_u32 (rv); })); /* *INDENT-ON* */ - - /* - * dns_resolve_name leaves the cache locked when it returns - * a cached result, so unlock it here. - */ - dns_cache_unlock (dm); } static void @@ -1551,12 +1545,6 @@ vl_api_dns_resolve_ip_t_handler (vl_api_dns_resolve_ip_t * mp) rmp->retval = clib_host_to_net_u32 (rv); })); /* *INDENT-ON* */ - - /* - * vnet_dns_resolve_name leaves the cache locked when it returns - * a cached result, so unlock it here. - */ - dns_cache_unlock (dm); } static clib_error_t * -- 2.16.6