From 4ebcd95e620a2be1c69cce3297f31754d9aa8c88 Mon Sep 17 00:00:00 2001 From: Jieqiang Wang Date: Thu, 5 May 2022 12:33:57 +0000 Subject: [PATCH] rdma: two small improvements for rdma interface - fix branch prediction for checking rdma ERROR flag - add the missing right angle bracket to help message Type: improvement Signed-off-by: Jieqiang Wang Reviewed-by: Lijian Zhang Reviewed-by: Tianyu Li Change-Id: I2ce667631b3e3f60939069e2a16ddba0ff12a695 --- src/plugins/rdma/cli.c | 8 ++++---- src/plugins/rdma/input.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/plugins/rdma/cli.c b/src/plugins/rdma/cli.c index 8f191e34b63..0edc83a05ce 100644 --- a/src/plugins/rdma/cli.c +++ b/src/plugins/rdma/cli.c @@ -48,10 +48,10 @@ rdma_create_command_fn (vlib_main_t * vm, unformat_input_t * input, VLIB_CLI_COMMAND (rdma_create_command, static) = { .path = "create interface rdma", .short_help = "create interface rdma [name ]" - " [rx-queue-size ] [tx-queue-size ]" - " [num-rx-queues ] [mode ]", + " [rx-queue-size ] [tx-queue-size ]" + " [num-rx-queues ] [mode ]" + " [no-multi-seg] [no-striding]" + " [max-pktlen ]", .function = rdma_create_command_fn, }; /* *INDENT-ON* */ diff --git a/src/plugins/rdma/input.c b/src/plugins/rdma/input.c index f1c508affa2..2ff04a6ec46 100644 --- a/src/plugins/rdma/input.c +++ b/src/plugins/rdma/input.c @@ -1028,7 +1028,7 @@ VLIB_NODE_FN (rdma_input_node) (vlib_main_t * vm, if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_ADMIN_UP) == 0) continue; - if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_ERROR)) + if (PREDICT_FALSE (rd->flags & RDMA_DEVICE_F_ERROR)) continue; if (PREDICT_TRUE (rd->flags & RDMA_DEVICE_F_MLX5DV)) -- 2.16.6