From 5d8072c059eda181b54d5ad425abc6f8edaf2a31 Mon Sep 17 00:00:00 2001 From: Klement Sekera Date: Fri, 22 Oct 2021 13:05:48 +0200 Subject: [PATCH] perfmon: fix coverity warning Check that cpumask is initialised properly to avoid possible NULL pointer dereference. Type: fix Signed-off-by: Klement Sekera Change-Id: I8df5a718104fe703d6baf3f1294b4a6d2ca01619 --- src/plugins/perfmon/intel/uncore.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/plugins/perfmon/intel/uncore.c b/src/plugins/perfmon/intel/uncore.c index e8939cb67c9..ee3e4aea630 100644 --- a/src/plugins/perfmon/intel/uncore.c +++ b/src/plugins/perfmon/intel/uncore.c @@ -132,6 +132,14 @@ intel_uncore_init (vlib_main_t *vm, perfmon_source_t *src) goto done; } + if (!cpumask) + { + clib_error_free (err); + err = clib_error_return ( + 0, "while discovering numa topology: cpumask unexpectedly NULL"); + goto done; + } + clib_bitmap_foreach (j, cpumask) { vec_validate_init_empty (numa_by_cpu_id, j, -1); -- 2.16.6