From 81284163a293759bc5c2d6a124639c6796589d15 Mon Sep 17 00:00:00 2001 From: Matthew Smith Date: Fri, 24 Apr 2020 13:43:12 -0500 Subject: [PATCH 1/1] devices: allow link state down with netlink Type: fix Use the up parameter in vnet_netlink_set_link_state(). It was ignoring the parameter and always setting IFF_UP on an interface. Change-Id: I0d44406d982afbdc43bc6b26d0f22c0bdd47abdc Signed-off-by: Matthew Smith --- src/vnet/devices/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vnet/devices/netlink.c b/src/vnet/devices/netlink.c index 72603514772..34309e1b916 100644 --- a/src/vnet/devices/netlink.c +++ b/src/vnet/devices/netlink.c @@ -201,7 +201,7 @@ vnet_netlink_set_link_state (int ifindex, int up) struct ifinfomsg ifmsg = { 0 }; clib_error_t *err = 0; - ifmsg.ifi_flags = IFF_UP; + ifmsg.ifi_flags = ((up) ? IFF_UP : 0); ifmsg.ifi_change = IFF_UP; ifmsg.ifi_index = ifindex; -- 2.16.6