From 9847792e18f1fd9f3b8fedea4fc53eed1096ab75 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Beno=C3=AEt=20Ganne?= Date: Wed, 10 Apr 2019 14:21:11 +0200 Subject: [PATCH] ethernet: fix packet tracing MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Node tracing condition was wrongly reversed by commit "5ecd5a5d15 Move pcap rx/tx trace code out of the dpdk plugin". This prevented packet tracing in ethernet-input node and also impacted performance in the no tracing case. Change-Id: I345a11191d027c6c4ec474a2901995338050680a Signed-off-by: Benoît Ganne --- src/vnet/ethernet/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vnet/ethernet/node.c b/src/vnet/ethernet/node.c index 950a962217c..38c596e56f8 100755 --- a/src/vnet/ethernet/node.c +++ b/src/vnet/ethernet/node.c @@ -963,7 +963,7 @@ ethernet_input_trace (vlib_main_t * vm, vlib_node_runtime_t * node, vlib_frame_t * from_frame) { u32 *from, n_left; - if (PREDICT_FALSE ((node->flags & VLIB_NODE_FLAG_TRACE) == 0)) + if (PREDICT_FALSE ((node->flags & VLIB_NODE_FLAG_TRACE))) { from = vlib_frame_vector_args (from_frame); n_left = from_frame->n_vectors; -- 2.16.6