From 9ce35233658d6c19a4458ec7e728b6ee75fd3ace Mon Sep 17 00:00:00 2001 From: Andrew Yourtchenko Date: Mon, 18 Nov 2019 10:23:54 +0000 Subject: [PATCH 1/1] vppinfra: fix coverity issue 205691 in pmalloc set the address to MMAP_FAILED if mmap has failed, so that we do not attempt to free it in the error handling path. Change-Id: I6e6b51a365fb68086dc20aa40a676a36af59a3ba Type: fix Signed-off-by: Andrew Yourtchenko --- src/vppinfra/pmalloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vppinfra/pmalloc.c b/src/vppinfra/pmalloc.c index ce78ca00334..cca8039433d 100644 --- a/src/vppinfra/pmalloc.c +++ b/src/vppinfra/pmalloc.c @@ -331,6 +331,7 @@ pmalloc_map_pages (clib_pmalloc_main_t * pm, clib_pmalloc_arena_t * a, pm->error = clib_error_return_unix (0, "failed to mmap %u pages at %p " "fd %d numa %d flags 0x%x", n_pages, va, a->fd, numa_node, mmap_flags); + va = MAP_FAILED; goto error; } -- 2.16.6