From aa9903cabfd44ed9c88d1f624a39096ff7fee37f Mon Sep 17 00:00:00 2001 From: Klement Sekera Date: Tue, 16 Nov 2021 12:19:26 +0100 Subject: [PATCH] misc: vppctl - fix coverity warning Check that provided path fits into defined buffer. Don't write too many bytes to avoid having an unterminated string. Type: fix Fixes: 31f192434660 Signed-off-by: Klement Sekera Change-Id: I1ea8b6d6a3474c032e542b6980ed14bac72093a8 --- src/vpp/app/vppctl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/vpp/app/vppctl.c b/src/vpp/app/vppctl.c index c9f33abf7ab..de5572d6bfa 100644 --- a/src/vpp/app/vppctl.c +++ b/src/vpp/app/vppctl.c @@ -192,6 +192,13 @@ main (int argc, char *argv[]) struct sockaddr_un saddr = { 0 }; saddr.sun_family = AF_UNIX; + + if (strlen (sock_fname) > sizeof (saddr.sun_path) - 1) + { + perror ("socket path too long"); + exit (1); + } + strncpy (saddr.sun_path, sock_fname, sizeof (saddr.sun_path) - 1); sock_fd = socket (AF_UNIX, SOCK_STREAM, 0); -- 2.16.6