From b7b88b6cffd52089072e93925a7e8042d189c537 Mon Sep 17 00:00:00 2001 From: Semir Sionek Date: Mon, 22 Sep 2025 10:05:35 +0000 Subject: [PATCH] hsa: remove unused test_send_buffer from echo client test_send_buffer was originally supposed to be used for assembling dgrams with included data buffer offsets. As we decided on using segments, this is not needed. Type: fix Change-Id: I3cdbfc077aefeecc44615cb93f7d9f3274b6b5fb Signed-off-by: Semir Sionek --- src/plugins/hs_apps/echo_client.c | 15 --------------- src/plugins/hs_apps/echo_client.h | 1 - 2 files changed, 16 deletions(-) diff --git a/src/plugins/hs_apps/echo_client.c b/src/plugins/hs_apps/echo_client.c index cae7a73ea72..75811331186 100644 --- a/src/plugins/hs_apps/echo_client.c +++ b/src/plugins/hs_apps/echo_client.c @@ -839,9 +839,6 @@ ec_session_connected_callback (u32 app_index, u32 api_context, session_t *s, es->vpp_session_index = s->session_index; es->bytes_paced_target = ~0; es->bytes_paced_current = ~0; - if (ecm->transport_proto != TRANSPORT_PROTO_TCP && ecm->cfg.test_bytes) - vec_validate (es->test_send_buffer, - ecm->max_chunk_bytes + sizeof (int) + 1); s->opaque = es->session_index; vec_add1 (wrk->conn_indices, es->session_index); @@ -883,14 +880,8 @@ static void ec_session_disconnect_callback (session_t *s) { ec_main_t *ecm = &ec_main; - ec_worker_t *wrk; - ec_session_t *es; vnet_disconnect_args_t _a = { 0 }, *a = &_a; - wrk = ec_worker_get (s->thread_index); - es = ec_session_get (wrk, s->opaque); - vec_free (es->test_send_buffer); - if (session_handle (s) == ecm->ctrl_session_handle) { ec_dbg ("ctrl session disconnect"); @@ -907,14 +898,8 @@ void ec_session_disconnect (session_t *s) { ec_main_t *ecm = &ec_main; - ec_worker_t *wrk; - ec_session_t *es; vnet_disconnect_args_t _a = { 0 }, *a = &_a; - wrk = ec_worker_get (s->thread_index); - es = ec_session_get (wrk, s->opaque); - vec_free (es->test_send_buffer); - a->handle = session_handle (s); a->app_index = ecm->app_index; vnet_disconnect_session (a); diff --git a/src/plugins/hs_apps/echo_client.h b/src/plugins/hs_apps/echo_client.h index 17d41c5ec2e..63e48639c8f 100644 --- a/src/plugins/hs_apps/echo_client.h +++ b/src/plugins/hs_apps/echo_client.h @@ -49,7 +49,6 @@ typedef struct ec_session_ u64 bytes_paced_current; f64 send_rtt; u8 rtt_stat; - u8 *test_send_buffer; u64 dgrams_sent; u64 dgrams_received; } ec_session_t; -- 2.16.6