From cf214cc6005ad53371bfbce9901b04bfa116207b Mon Sep 17 00:00:00 2001 From: Duncan Eastoe Date: Wed, 30 Nov 2022 21:16:13 +0000 Subject: [PATCH] stats: fix memory leak in stat_segment_dump_r() The built stat_segment_data_t is leaked if stat_segment_access_end() returns false. Type: fix Signed-off-by: Duncan Eastoe Change-Id: I70adabbe7947d3e8a798cdfb3eaa14c683dce9da --- src/vpp-api/client/stat_client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/vpp-api/client/stat_client.c b/src/vpp-api/client/stat_client.c index 1c31ea0cb23..359813f8d57 100644 --- a/src/vpp-api/client/stat_client.c +++ b/src/vpp-api/client/stat_client.c @@ -433,6 +433,8 @@ stat_segment_dump_r (uint32_t * stats, stat_client_main_t * sm) fprintf (stderr, "Epoch changed while reading, invalid results\n"); // TODO increase counter + if (res) + stat_segment_data_free (res); return 0; } -- 2.16.6