From dd801665604e94139c5ee0b3efe3fa2a3bd6e433 Mon Sep 17 00:00:00 2001 From: Damjan Marion Date: Wed, 5 Jan 2022 21:26:51 +0100 Subject: [PATCH] dpdk: no need to copy default tx conf Type: improvement Change-Id: Ifd5201c101da7f4fb63f9b64280a6ec35b2af6a0 Signed-off-by: Damjan Marion --- src/plugins/dpdk/device/common.c | 4 ++-- src/plugins/dpdk/device/dpdk.h | 1 - src/plugins/dpdk/device/init.c | 3 --- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/plugins/dpdk/device/common.c b/src/plugins/dpdk/device/common.c index 19c0c32243d..f77e377e14c 100644 --- a/src/plugins/dpdk/device/common.c +++ b/src/plugins/dpdk/device/common.c @@ -103,12 +103,12 @@ dpdk_device_setup (dpdk_device_t * xd) for (j = 0; j < xd->conf.n_tx_queues; j++) { rv = rte_eth_tx_queue_setup (xd->port_id, j, xd->conf.n_tx_desc, - xd->cpu_socket, &xd->tx_conf); + xd->cpu_socket, 0); /* retry with any other CPU socket */ if (rv < 0) rv = rte_eth_tx_queue_setup (xd->port_id, j, xd->conf.n_tx_desc, - SOCKET_ID_ANY, &xd->tx_conf); + SOCKET_ID_ANY, 0); if (rv < 0) dpdk_device_error (xd, "rte_eth_tx_queue_setup", rv); diff --git a/src/plugins/dpdk/device/dpdk.h b/src/plugins/dpdk/device/dpdk.h index 5da1834160a..3026734c39f 100644 --- a/src/plugins/dpdk/device/dpdk.h +++ b/src/plugins/dpdk/device/dpdk.h @@ -216,7 +216,6 @@ typedef struct /* PMD related */ struct rte_eth_conf port_conf; - struct rte_eth_txconf tx_conf; /* flow related */ u32 supported_flow_actions; diff --git a/src/plugins/dpdk/device/init.c b/src/plugins/dpdk/device/init.c index 80d85a856de..05d1e74f088 100644 --- a/src/plugins/dpdk/device/init.c +++ b/src/plugins/dpdk/device/init.c @@ -362,9 +362,6 @@ dpdk_lib_init (dpdk_main_t * dm) else last_pci_addr.as_u32 = ~0; - clib_memcpy (&xd->tx_conf, &di.default_txconf, - sizeof (struct rte_eth_txconf)); - if (di.rx_offload_capa & DEV_RX_OFFLOAD_IPV4_CKSUM) { xd->port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_IPV4_CKSUM; -- 2.16.6