From b70497124840fb6d9e8e5cf7239a41cb2bc7013c Mon Sep 17 00:00:00 2001 From: Damjan Marion Date: Fri, 20 May 2022 13:05:38 +0200 Subject: [PATCH] api: keep api common code in vlibapi Type: refactor Change-Id: I6edbff9a02fcb3c592ccfe8f47ddb3f848be1b6d Signed-off-by: Damjan Marion --- src/vat2/CMakeLists.txt | 3 ++- src/vlibapi/CMakeLists.txt | 20 +++++++++++--------- src/{vlibmemory => vlibapi}/memory_shared.c | 0 src/{vlibmemory => vlibapi}/memory_shared.h | 0 src/vlibmemory/CMakeLists.txt | 11 ++--------- src/vlibmemory/memory_api.h | 2 +- src/vlibmemory/memory_client.h | 2 +- src/vlibmemory/socket_client.h | 2 +- 8 files changed, 18 insertions(+), 22 deletions(-) rename src/{vlibmemory => vlibapi}/memory_shared.c (100%) rename src/{vlibmemory => vlibapi}/memory_shared.h (100%) diff --git a/src/vat2/CMakeLists.txt b/src/vat2/CMakeLists.txt index 108e184b570..6f843c34661 100644 --- a/src/vat2/CMakeLists.txt +++ b/src/vat2/CMakeLists.txt @@ -44,9 +44,10 @@ add_vpp_executable(test_vat2 ENABLE_EXPORTS NO_INSTALL DEPENDS api_headers LINK_LIBRARIES + vppinfra vlibmemoryclient + vlibapi svm - vppinfra vppapiclient Threads::Threads dl diff --git a/src/vlibapi/CMakeLists.txt b/src/vlibapi/CMakeLists.txt index e6937a6db01..95bb4cf7469 100644 --- a/src/vlibapi/CMakeLists.txt +++ b/src/vlibapi/CMakeLists.txt @@ -11,16 +11,18 @@ # See the License for the specific language governing permissions and # limitations under the License. -install( - FILES - api_helper_macros.h +add_vpp_library (vlibapi + SOURCES + api_shared.c + node_serialize.c + memory_shared.c + + INSTALL_HEADERS api.h - vat_helper_macros.h api_common.h + api_helper_macros.h api_types.h - - DESTINATION - ${CMAKE_INSTALL_INCLUDEDIR}/vlibapi - - COMPONENT vpp-dev + vat_helper_macros.h + memory_shared.h ) + diff --git a/src/vlibmemory/memory_shared.c b/src/vlibapi/memory_shared.c similarity index 100% rename from src/vlibmemory/memory_shared.c rename to src/vlibapi/memory_shared.c diff --git a/src/vlibmemory/memory_shared.h b/src/vlibapi/memory_shared.h similarity index 100% rename from src/vlibmemory/memory_shared.h rename to src/vlibapi/memory_shared.h diff --git a/src/vlibmemory/CMakeLists.txt b/src/vlibmemory/CMakeLists.txt index d14e9cad954..2ee4dd08ba9 100644 --- a/src/vlibmemory/CMakeLists.txt +++ b/src/vlibmemory/CMakeLists.txt @@ -14,17 +14,13 @@ add_vpp_library (vlibmemory SOURCES memory_api.c - memory_shared.c socket_api.c memclnt_api.c vlib_api_cli.c vlib_api.c - ../vlibapi/api_shared.c - ../vlibapi/node_serialize.c INSTALL_HEADERS vl_memory_msg_enum.h - memory_shared.h vl_memory_api_h.h socket_client.h memory_api.h @@ -36,19 +32,16 @@ add_vpp_library (vlibmemory memclnt.api vlib.api - LINK_LIBRARIES vppinfra svm vlib + LINK_LIBRARIES vppinfra svm vlib vlibapi ) add_dependencies(vlibmemory vlibmemory_api_headers) add_vpp_library (vlibmemoryclient SOURCES - memory_shared.c memory_client.c socket_client.c - ../vlibapi/api_shared.c - ../vlibapi/node_serialize.c - LINK_LIBRARIES vppinfra svm + LINK_LIBRARIES vppinfra svm vlibapi ) add_dependencies(vlibmemoryclient vlibmemory_api_headers) diff --git a/src/vlibmemory/memory_api.h b/src/vlibmemory/memory_api.h index 843bf8935b2..4a1573c6544 100644 --- a/src/vlibmemory/memory_api.h +++ b/src/vlibmemory/memory_api.h @@ -23,7 +23,7 @@ #include #include #include -#include +#include svm_queue_t *vl_api_client_index_to_input_queue (u32 index); int vl_mem_api_init (const char *region_name); diff --git a/src/vlibmemory/memory_client.h b/src/vlibmemory/memory_client.h index a0168693a4b..3b8f671415c 100644 --- a/src/vlibmemory/memory_client.h +++ b/src/vlibmemory/memory_client.h @@ -18,7 +18,7 @@ #ifndef SRC_VLIBMEMORY_MEMORY_CLIENT_H_ #define SRC_VLIBMEMORY_MEMORY_CLIENT_H_ -#include +#include #include /* diff --git a/src/vlibmemory/socket_client.h b/src/vlibmemory/socket_client.h index 231290088b3..619b7f4fccc 100644 --- a/src/vlibmemory/socket_client.h +++ b/src/vlibmemory/socket_client.h @@ -20,7 +20,7 @@ #include #include -#include +#include typedef struct { -- 2.16.6