HC Test: improve functional suite setup and teardown

[csit.git] / tests / func / honeycomb / mgmt-cfg-proxyarp-apihc-func.robot

diff --git a/tests/func/honeycomb/mgmt-cfg-proxyarp-apihc-func.robot b/tests/func/honeycomb/mgmt-cfg-proxyarp-apihc-func.robot
index aea7f2d..5e162a3 100644 (file)
--- a/tests/func/honeycomb/mgmt-cfg-proxyarp-apihc-func.robot
+++ b/tests/func/honeycomb/mgmt-cfg-proxyarp-apihc-func.robot
@@ -16,8 +16,8 @@
 | ${interface}= | ${node['interfaces']['port1']['name']}
 | &{proxyarp_settings_ipv4}= | vrf-id=${0}
 | ... | low-addr=192.168.1.2 | high-addr=192.168.1.10
-| ${tg_to_dut_ip}= | 192.168.1.100
-| ${dut_to_tg_ip}= | 192.168.1.1
+| ${tg_to_dut_ip}= | 10.0.0.100
+| ${dut_to_tg_ip}= | 10.0.0.1
 | ${prefix_length}= | ${24}
 | ${test_ip}= | 192.168.1.5
 
@@ -30,24 +30,31 @@
 | Resource | resources/libraries/robot/ipv4.robot
 | Resource | resources/libraries/robot/traffic.robot
 | Library | resources.libraries.python.Trace
-| Suite Teardown
-| ... | Run Keyword If Any Tests Failed
-| ... | Restart Honeycomb And VPP And Clear Persisted Configuration | ${node}
-| Force Tags | honeycomb_sanity
+| ...
+| Suite Setup | Set Up Honeycomb Functional Test Suite | ${node}
+| ...
+| Suite Teardown | Tear Down Honeycomb Functional Test Suite | ${node}
+| ...
+| Force Tags | HC_FUNC
+| ...
 | Documentation | *Honeycomb proxyARP management test suite.*
 
 *** Test Cases ***
 # TODO: Add operational data and VAT dump verification if/when avaliable
 | TC01: Honeycomb can configure ipv4 proxyARP
 | | [Documentation] | Check if Honeycomb can configure the proxyARP feature.
+| | ...
 | | [Teardown] | Honeycomb removes proxyARP configuration | ${node}
+| | ...
 | | Honeycomb configures proxyARP | ${node} | ${proxyarp_settings_ipv4}
 
 | TC02: Honeycomb can enable proxyarp on an interface
 | | [Documentation] | Check if Honeycomb can enable the proxyARP feature\
 | | ... | on an interface.
+| | ...
 | | [Teardown] | Honeycomb disables proxyARP on interface
 | | ... | ${node} | ${interface}
+| | ...
 | | Honeycomb enables proxyARP on interface | ${node} | ${interface}
 
 | TC03: DUT sends ARP reply on behalf of another machine from the IP range
@@ -59,22 +66,24 @@
 | | ... | [Ver] Make TG send ARP request to DUT1 interface,
 | | ... | verify if DUT1 sends correct ARP reply on behalf of machine whose
 | | ... | IP is in the configured range.
+| | ...
 | | [Teardown] | Run Keywords
-| | ... | Honeycomb removes proxyARP configuration | ${node}
-| | ... | AND | Honeycomb disables proxyARP on interface
-| | ... | ${node} | ${interface}
-| | ... | AND | Honeycomb sets interface state
+| | ... | Show Packet Trace on all DUTs | ${nodes}
+| | ... | AND | Honeycomb removes proxyARP configuration | ${node}
+| | ... | AND | Honeycomb configures interface state
 | | ... | ${dut_node} | ${dut_to_tg_if1} | down
-| | ... | AND | Honeycomb removes interface ipv4 addresses
+| | ... | AND | Honeycomb removes interface IPv4 addresses
 | | ... | ${node} | ${interface}
-| | Given Path for 2-node testing is set
+| | ...
+| | Given Configure path in 2-node circular topology
 | | ... | ${nodes['TG']} | ${nodes['DUT1']} | ${nodes['TG']}
-| | ${tg_to_dut_if1_name}= | Get interface name | ${tg_node} | ${tg_to_dut_if1}
-| | And Honeycomb sets interface state | ${dut_node} | ${dut_to_tg_if1} | up
-| | And Honeycomb sets interface ipv4 address with prefix | ${dut_node}
+| | ${dut_to_tg_name}= | Get interface name | ${dut_node} | ${dut_to_tg_if1}
+| | ${tg_to_dut_name}= | Get interface name | ${tg_node} | ${tg_to_dut_if1}
+| | And Honeycomb configures interface state | ${dut_node} | ${dut_to_tg_if1} | up
+| | And Honeycomb sets interface IPv4 address with prefix | ${dut_node}
 | | ... | ${dut_to_tg_if1} | ${dut_to_tg_ip} | ${prefix_length}
 | | When Honeycomb configures proxyARP | ${dut_node} | ${proxyarp_settings_ipv4}
-| | And Honeycomb enables proxyARP on interface | ${node} | ${dut_to_tg_if1}
-| | Then Send ARP Request | ${tg_node} | ${tg_to_dut_if1_name}
-| | ...                   | ${tg_to_dut_if1_mac} | ${dut_to_tg_if1_mac}
-| | ...                   | ${tg_to_dut_ip} | ${test_ip}
+| | And Honeycomb enables proxyARP on interface | ${node} | ${dut_to_tg_name}
+| | Then Send ARP Request | ${tg_node} | ${tg_to_dut_name}
+| | ... | ${tg_to_dut_if1_mac} | ${dut_to_tg_if1_mac}
+| | ... | ${tg_to_dut_ip} | ${test_ip}