X-Git-Url: https://gerrit.fd.io/r/gitweb?p=csit.git;a=blobdiff_plain;f=resources%2Flibraries%2Fpython%2FDPDK%2FL2fwdTest.py;h=80a91e2ff6253be18561effeb67b7e02a7550122;hp=fa2f879492f701732f0130a44c1c8817b14edf7d;hb=6dd47ed60a15c9f4c86d095844839610783a8393;hpb=3f71d7394f1dc584de9725736d130a5a0e076533

diff --git a/resources/libraries/python/DPDK/L2fwdTest.py b/resources/libraries/python/DPDK/L2fwdTest.py
index fa2f879492..80a91e2ff6 100644
--- a/resources/libraries/python/DPDK/L2fwdTest.py
+++ b/resources/libraries/python/DPDK/L2fwdTest.py
@@ -11,44 +11,45 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-
-"""
-This module exists to provide the l2fwd test for DPDK on topology nodes.
+"""This module implements functionality which sets L2 forwarding for DPDK on
+DUT nodes.
 """
 
 from resources.libraries.python.ssh import SSH
 from resources.libraries.python.constants import Constants as con
 
+
 class L2fwdTest(object):
-    """Test the DPDK l2fwd performance."""
+    """Setup the DPDK for l2fwd performance test."""
 
     @staticmethod
-    def start_the_l2fwd_test(dut_node, cpu_coremask, nb_cores, queue_nums,
+    def start_the_l2fwd_test(dut_node, cpu_cores, nb_cores, queue_nums,
                              jumbo_frames):
         """
         Execute the l2fwd on the dut_node.
 
         :param dut_node: Will execute the l2fwd on this node.
-        :param cpu_coremask: The DPDK run core mask.
+        :param cpu_cores: The DPDK run cores.
         :param nb_cores: The cores number for the forwarding.
         :param queue_nums: The queues number for the NIC.
-        :param jumbo_frames: Is jumbo frames or not.
+        :param jumbo_frames: Are jumbo frames used or not.
         :type dut_node: dict
-        :type cpu_coremask: str
+        :type cpu_cores: str
         :type nb_cores: str
         :type queue_nums: str
         :type jumbo_frames: str
         :returns: none
+        :raises RuntimeError: If the script "run_l2fwd.sh" fails.
         """
+
         ssh = SSH()
         ssh.connect(dut_node)
 
-        cmd = 'cd {0}/dpdk-tests/dpdk_scripts/ && sudo ./run_l2fwd.sh ' \
-              '{1} {2} {3} {4}'.format(con.REMOTE_FW_DIR, cpu_coremask, \
-              nb_cores, queue_nums, jumbo_frames)
+        cmd = 'cd {0}/dpdk-tests/dpdk_scripts/ && sudo ./run_l2fwd.sh {1} ' \
+              '{2} {3} {4}'.format(con.REMOTE_FW_DIR, cpu_cores, nb_cores,
+                                   queue_nums, jumbo_frames)
 
         (ret_code, _, _) = ssh.exec_command(cmd, timeout=600)
         if ret_code != 0:
-            raise Exception('Failed to execute l2fwd test at node {0}'
-                            .format(dut_node['host']))
-
+            raise RuntimeError('Failed to execute l2fwd test at node {0}'.
+                               format(dut_node['host']))