X-Git-Url: https://gerrit.fd.io/r/gitweb?p=csit.git;a=blobdiff_plain;f=resources%2Flibraries%2Fpython%2FDpdkUtil.py;h=541ec9b151518bfeb1fe83e294d4869c8b441aa5;hp=a81251c97bbc03e2d15019650262c0040d6125a4;hb=39b4a07718ecab94ea331362edb62dfcf678bd09;hpb=e9ce3e7fe123c7ed6847e7d615b0e963429b0298

diff --git a/resources/libraries/python/DpdkUtil.py b/resources/libraries/python/DpdkUtil.py
index a81251c97b..541ec9b151 100644
--- a/resources/libraries/python/DpdkUtil.py
+++ b/resources/libraries/python/DpdkUtil.py
@@ -1,4 +1,4 @@
-# Copyright (c) 2016 Cisco and/or its affiliates.
+# Copyright (c) 2018 Cisco and/or its affiliates.
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at:
@@ -19,16 +19,14 @@ from resources.libraries.python.ssh import SSH, exec_cmd_no_error
 class DpdkUtil(object):
     """Utilities for DPDK."""
 
-    #pylint: disable=too-many-locals
     @staticmethod
-    def dpdk_testpmd_start(node, **args):
-        """Start DPDK testpmd app on VM node.
+    def get_eal_options(**args):
+        """Create EAL parameters string.
 
-        :param node: VM Node to start testpmd on.
         :param args: List of testpmd parameters.
-        :type node: dict
-        :type args: list
-        :return: nothing
+        :type args: dict
+        :returns: EAL parameters string.
+        :rtype: str
         """
         # Set the hexadecimal bitmask of the cores to run on.
         eal_coremask = '-c {} '.format(args['eal_coremask'])\
@@ -43,6 +41,23 @@ class DpdkUtil(object):
             if args.get('eal_socket_mem', '') else ''
         # Load an external driver. Multiple -d options are allowed.
         eal_driver = '-d /usr/lib/librte_pmd_virtio.so '
+        eal_options = '-v '\
+            + eal_coremask\
+            + eal_master_core\
+            + eal_mem_channels\
+            + eal_socket_mem\
+            + eal_driver
+        return eal_options
+
+    @staticmethod
+    def get_pmd_options(**args):
+        """Create PMD parameters string.
+
+        :param args: List of testpmd parameters.
+        :type args: dict
+        :returns: PMD parameters string.
+        :rtype: str
+        """
         # Set the forwarding mode: io, mac, mac_retry, mac_swap, flowgen,
         # rxonly, txonly, csum, icmpecho, ieee1588
         pmd_fwd_mode = '--forward-mode={} '.format(args['pmd_fwd_mode'])\
@@ -50,18 +65,25 @@ class DpdkUtil(object):
         # Set the number of packets per burst to N.
         pmd_burst = '--burst=64 '
         # Set the number of descriptors in the TX rings to N.
-        pmd_txd = '--txd=256 '
+        pmd_txd = '--txd={} '.format(args.get('pmd_txd', '256')) \
+            if args.get('pmd_txd', '256') else ''
         # Set the number of descriptors in the RX rings to N.
-        pmd_rxd = '--rxd=256 '
+        pmd_rxd = '--rxd={} '.format(args.get('pmd_rxd', '256')) \
+            if args.get('pmd_rxd', '256') else ''
         # Set the number of queues in the TX to N.
-        pmd_txq = '--txq=1 '
+        pmd_txq = '--txq={} '.format(args.get('pmd_txq', '1')) \
+            if args.get('pmd_txq', '1') else ''
         # Set the number of queues in the RX to N.
-        pmd_rxq = '--rxq=1 '
+        pmd_rxq = '--rxq={} '.format(args.get('pmd_rxq', '1')) \
+            if args.get('pmd_rxq', '1') else ''
         # Set the hexadecimal bitmask of TX queue flags.
         pmd_txqflags = '--txqflags=0xf00 '
         # Set the number of mbufs to be allocated in the mbuf pools.
-        pmd_total_num_mbufs = '--total-num-mbufs={} '.format(\
+        pmd_total_num_mbufs = '--total-num-mbufs={} '.format(
             args['pmd_num_mbufs']) if args.get('pmd_num_mbufs', '') else ''
+        # Set the max packet length.
+        pmd_max_pkt_len = "--max-pkt-len={0}".format(args["pmd_max_pkt_len"]) \
+            if args.get("pmd_max_pkt_len", "") else ""
         # Set the hexadecimal bitmask of the ports for forwarding.
         pmd_portmask = '--portmask={} '.format(args['pmd_portmask'])\
             if args.get('pmd_portmask', '') else ''
@@ -77,15 +99,9 @@ class DpdkUtil(object):
         pmd_eth_peer_1 = '--eth-peer={} '.format(args['pmd_eth_peer_1'])\
             if args.get('pmd_eth_peer_1', '') else ''
         # Set the number of forwarding cores based on coremask.
-        pmd_nb_cores = '--nb-cores={} '.format(\
+        pmd_nb_cores = '--nb-cores={} '.format(
             bin(int(args['eal_coremask'], 0)).count('1')-1)\
             if args.get('eal_coremask', '') else ''
-        eal_options = '-v '\
-            + eal_coremask\
-            + eal_master_core\
-            + eal_mem_channels\
-            + eal_socket_mem\
-            + eal_driver
         pmd_options = '-- '\
             + pmd_fwd_mode\
             + pmd_burst\
@@ -100,7 +116,23 @@ class DpdkUtil(object):
             + pmd_disable_rss\
             + pmd_eth_peer_0\
             + pmd_eth_peer_1\
-            + pmd_nb_cores
+            + pmd_nb_cores\
+            + pmd_max_pkt_len
+        return pmd_options
+
+    @staticmethod
+    def dpdk_testpmd_start(node, **args):
+        """Start DPDK testpmd app on VM node.
+
+        :param node: VM Node to start testpmd on.
+        :param args: List of testpmd parameters.
+        :type node: dict
+        :type args: dict
+        :returns: nothing
+        """
+        eal_options = DpdkUtil.get_eal_options(**args)
+        pmd_options = DpdkUtil.get_pmd_options(**args)
+
         ssh = SSH()
         ssh.connect(node)
         cmd = "/start-testpmd.sh {0} {1}".format(eal_options, pmd_options)
@@ -113,7 +145,7 @@ class DpdkUtil(object):
 
         :param node: Node to stop testpmd on.
         :type node: dict
-        :return: nothing
+        :returns: nothing
         """
         ssh = SSH()
         ssh.connect(node)