X-Git-Url: https://gerrit.fd.io/r/gitweb?p=csit.git;a=blobdiff_plain;f=resources%2Flibraries%2Fpython%2FIPUtil.py;fp=resources%2Flibraries%2Fpython%2FIPUtil.py;h=c3df1fe3762a5449f38a6e3277cf236a20cb65ce;hp=04961fa45a6ea4cc3ced9c0987579bdc1d7ca545;hb=46224ef45ad749e100c591a63c89dc59a94528aa;hpb=53f3ee868ef4dbd2ab41a6fdf0a7255a370f9678 diff --git a/resources/libraries/python/IPUtil.py b/resources/libraries/python/IPUtil.py index 04961fa45a..c3df1fe376 100644 --- a/resources/libraries/python/IPUtil.py +++ b/resources/libraries/python/IPUtil.py @@ -117,12 +117,10 @@ class IPUtil: if not sw_if_index: return list() - is_ipv6 = 1 if ip_version == u"ipv6" else 0 - cmd = u"ip_address_dump" args = dict( sw_if_index=sw_if_index, - is_ipv6=is_ipv6 + is_ipv6=bool(ip_version == u"ipv6") ) err_msg = f"Failed to get L2FIB dump on host {node[u'host']}" @@ -430,7 +428,7 @@ class IPUtil: ) cmd = u"ip_neighbor_add_del" args = dict( - is_add=1, + is_add=True, neighbor=neighbor ) err_msg = f"Failed to add IP neighbor on interface {iface_key}" @@ -607,8 +605,8 @@ class IPUtil: net_addr = ip_address(network) cmd = u"ip_route_add_del" args = dict( - is_add=1, - is_multipath=int(kwargs.get(u"multipath", False)), + is_add=True, + is_multipath=kwargs.get(u"multipath", False), route=None ) err_msg = f"Failed to add route(s) on host {node[u'host']}" @@ -656,11 +654,11 @@ class IPUtil: cmd = u"ip_table_add_del" table = dict( table_id=int(table_id), - is_ip6=int(ipv6) + is_ip6=ipv6 ) args = dict( table=table, - is_add=1 + is_add=True ) err_msg = f"Failed to add FIB table on host {node[u'host']}"