X-Git-Url: https://gerrit.fd.io/r/gitweb?p=csit.git;a=blobdiff_plain;f=resources%2Flibraries%2Fpython%2FPapiHistory.py;h=cacfbd6b194ff760aa2d504838b6e0c0b2f465a1;hp=78279f559abbd6912dc06210739cdb41690a314d;hb=fa3c865b27c2cfcf11b5fc45bf1a34290f3c32ce;hpb=2dc5924d35671c01e9aaa4ea6b9ae18bdd184ca8 diff --git a/resources/libraries/python/PapiHistory.py b/resources/libraries/python/PapiHistory.py index 78279f559a..cacfbd6b19 100644 --- a/resources/libraries/python/PapiHistory.py +++ b/resources/libraries/python/PapiHistory.py @@ -17,13 +17,13 @@ from robot.api import logger from resources.libraries.python.topology import NodeType, DICT__nodes -__all__ = ["DICT__DUTS_PAPI_HISTORY", "PapiHistory"] +__all__ = [u"DICT__DUTS_PAPI_HISTORY", u"PapiHistory"] DICT__DUTS_PAPI_HISTORY = dict() -class PapiHistory(object): +class PapiHistory: """Contains methods to set up DUT PAPI command history. """ @@ -34,7 +34,7 @@ class PapiHistory(object): :param node: DUT node to reset PAPI command history for. :type node: dict """ - DICT__DUTS_PAPI_HISTORY[node['host']] = list() + DICT__DUTS_PAPI_HISTORY[node[u"host"]] = list() @staticmethod def reset_papi_history_on_all_duts(nodes): @@ -44,13 +44,15 @@ class PapiHistory(object): :type nodes: dict """ for node in nodes.values(): - if node['type'] == NodeType.DUT: + if node[u"type"] == NodeType.DUT: PapiHistory.reset_papi_history(node) @staticmethod def add_to_papi_history(node, csit_papi_command, papi=True, **kwargs): """Add command to PAPI command history on DUT node. + Repr strings are used for argument values. + The argument name 'csit_papi_command' must be unique enough as it cannot be repeated in kwargs. @@ -83,16 +85,15 @@ class PapiHistory(object): """ if papi: args = list() - for key, val in kwargs.iteritems(): - args.append("{key}={val}".format(key=key, val=val)) - item = "{cmd}({args})".format(cmd=csit_papi_command, - args=",".join(args)) + for key, val in kwargs.items(): + args.append(f"{key}={val!r}") + item = f"{csit_papi_command}({u','.join(args)})" else: # This else part is here to store VAT commands. # VAT history is not used. # TODO: Remove when VatExecutor is completely removed. - item = "{cmd}".format(cmd=csit_papi_command) - DICT__DUTS_PAPI_HISTORY[node['host']].append(item) + item = f"{csit_papi_command}" + DICT__DUTS_PAPI_HISTORY[node[u"host"]].append(item) @staticmethod def show_papi_history(node): @@ -101,12 +102,11 @@ class PapiHistory(object): :param node: DUT node to show PAPI command history for. :type node: dict """ - history_list = DICT__DUTS_PAPI_HISTORY[node['host']] + history_list = DICT__DUTS_PAPI_HISTORY[node[u"host"]] if not history_list: - history_list = ("No PAPI command executed", ) - logger.trace( - "{0} PAPI command history:\n{1}\n".format( - node['host'], "\n".join(history_list))) + history_list = (u"No PAPI command executed", ) + history = u'\n'.join(history_list) + logger.info(f"{node[u'host']} PAPI command history:\n{history}\n") @staticmethod def show_papi_history_on_all_duts(nodes): @@ -116,7 +116,7 @@ class PapiHistory(object): :type nodes: dict """ for node in nodes.values(): - if node['type'] == NodeType.DUT: + if node[u"type"] == NodeType.DUT: PapiHistory.show_papi_history(node)