X-Git-Url: https://gerrit.fd.io/r/gitweb?p=csit.git;a=blobdiff_plain;f=resources%2Flibraries%2Fpython%2FSetupFramework.py;h=9b50b90bc5aa31ab92ba423438990a5c29af1251;hp=61a02346928ff1271d1265fec1ce0683a4671cc8;hb=da799981f5373b09398319df12e77e2efc75caa6;hpb=d68c77c3fe1a3c1b5010efed0087ca0537510296 diff --git a/resources/libraries/python/SetupFramework.py b/resources/libraries/python/SetupFramework.py index 61a0234692..9b50b90bc5 100644 --- a/resources/libraries/python/SetupFramework.py +++ b/resources/libraries/python/SetupFramework.py @@ -27,7 +27,7 @@ from robot.api import logger from robot.libraries.BuiltIn import BuiltIn from resources.libraries.python.ssh import SSH -from resources.libraries.python.constants import Constants as con +from resources.libraries.python.Constants import Constants as con from resources.libraries.python.topology import NodeType __all__ = ["SetupFramework"] @@ -56,7 +56,7 @@ def pack_framework_dir(): proc = Popen( split("tar --sparse --exclude-vcs --exclude=output*.xml " - "--exclude=./tmp --exclude=*.deb --exclude=*.rpm -zcf {0} ." + "--exclude=./tmp -zcf {0} ." .format(file_name)), stdout=PIPE, stderr=PIPE) (stdout, stderr) = proc.communicate() @@ -84,6 +84,7 @@ def copy_tarball_to_node(tarball, node): ssh.connect(node) ssh.scp(tarball, "/tmp/") + logger.console('Copying tarball to {0} done'.format(node['host'])) def extract_tarball_at_node(tarball, node): @@ -108,6 +109,8 @@ def extract_tarball_at_node(tarball, node): if ret_code != 0: raise RuntimeError('Failed to extract {0} at node {1}' .format(tarball, node['host'])) + logger.console('Extracting tarball to {0} on {1} done' + .format(con.REMOTE_FW_DIR, node['host'])) def create_env_directory_at_node(node): @@ -131,8 +134,8 @@ def create_env_directory_at_node(node): if ret_code != 0: raise RuntimeError('Virtualenv setup including requirements.txt on {0}' .format(node['host'])) - else: - logger.console('Virtualenv on {0} created'.format(node['host'])) + + logger.console('Virtualenv on {0} created'.format(node['host'])) def setup_node(args): @@ -224,8 +227,7 @@ class SetupFramework(object): :param nodes: Topology nodes. :type nodes: dict - :returns: True - success, False - error - :rtype: bool + :raises RuntimeError: If setup framework failed. """ tarball = pack_framework_dir() @@ -256,10 +258,8 @@ class SetupFramework(object): delete_local_tarball(tarball) if node_success: logger.console('All nodes are ready') - return True else: - logger.console('Failed to setup framework') - return False + raise RuntimeError('Failed to setup framework') class CleanupFramework(object): @@ -271,8 +271,7 @@ class CleanupFramework(object): :param nodes: Topology nodes. :type nodes: dict - :returns: True - success, False - error - :rtype: bool + :raises RuntimeError: If cleanup framework failed. """ # Turn off logging since we use multiprocessing log_level = BuiltIn().set_log_level('NONE') @@ -295,7 +294,5 @@ class CleanupFramework(object): if node_success: logger.console('All nodes cleaned up') - return True else: - logger.console('Failed to cleaned up framework') - return False + raise RuntimeError('Failed to cleaned up framework')